Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-23 Thread joel jaeggli
On 3/23/17 9:38 AM, Yoav Nir wrote: > >> On 21 Mar 2017, at 11:04, Stephen Farrell wrote: >> >> >> Thanks Yoav, >> >> On 21/03/17 07:44, Yoav Nir wrote: >>> Some that are not addressed, I’ve answered below. Let me know if you >>> want me to merge and submit. >> >> I'd

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-23 Thread Yoav Nir
> On 21 Mar 2017, at 11:04, Stephen Farrell wrote: > > > Thanks Yoav, > > On 21/03/17 07:44, Yoav Nir wrote: >> Some that are not addressed, I’ve answered below. Let me know if you >> want me to merge and submit. > > I'd say give it a chance for one round of

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-21 Thread Yoav Nir
> On 21 Mar 2017, at 14:28, Sean Turner wrote: > > >> On Mar 21, 2017, at 08:02, Eric Rescorla wrote: >> >> What we probably should actually do is make this depend on the IANA draft >> and then mark >> these Not Recommended. > > That is an option as none of

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-21 Thread Sean Turner
> On Mar 21, 2017, at 08:02, Eric Rescorla wrote: > > What we probably should actually do is make this depend on the IANA draft and > then mark > these Not Recommended. That is an option as none of the 3DES suites are marked as Recommended in the IANA draft. spt

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-21 Thread Eric Rescorla
On Tue, Mar 21, 2017 at 12:44 AM, Yoav Nir wrote: > Hi > > This pull request addresses most of these comments. > https://github.com/tlswg/rfc4492bis/pull/39 There is some discussion on > that PR > > Some that are not addressed, I’ve answered below. Let me know if you want

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-21 Thread Stephen Farrell
Thanks Yoav, On 21/03/17 07:44, Yoav Nir wrote: > Some that are not addressed, I’ve answered below. Let me know if you > want me to merge and submit. I'd say give it a chance for one round of comments from Eric and/or others, and then submit. Or, submit before you head for an airport on your

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-21 Thread Yoav Nir
Hi This pull request addresses most of these comments. https://github.com/tlswg/rfc4492bis/pull/39 There is some discussion on that PR Some that are not addressed, I’ve answered below. Let me know if you want me to merge and submit. Yoav On

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread Yoav Nir
LGTM > On 15 Mar 2017, at 21:32, David Benjamin wrote: > > How's this look? https://github.com/tlswg/rfc4492bis/pull/37 > > > On Wed, Mar 15, 2017 at 2:45 PM Yoav Nir >

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread David Benjamin
How's this look? https://github.com/tlswg/rfc4492bis/pull/37 On Wed, Mar 15, 2017 at 2:45 PM Yoav Nir wrote: > There is (going to be a re-spin). There already is a PR there. > > If you can make a PR to solve your issue, that would be great. > > On 15 Mar 2017, at 19:20,

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread Yoav Nir
There is (going to be a re-spin). There already is a PR there. If you can make a PR to solve your issue, that would be great. > On 15 Mar 2017, at 19:20, David Benjamin wrote: > > If there's to be a respin anyway, I have another small editorial comment: >

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread David Benjamin
If there's to be a respin anyway, I have another small editorial comment: https://github.com/tlswg/rfc4492bis/issues/36 On Wed, Mar 15, 2017 at 11:22 AM Eric Rescorla wrote: > FWIW, there's a lot here, but I think it's all essentially editorial, so > it shouldn't > be that hard

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread Eric Rescorla
FWIW, there's a lot here, but I think it's all essentially editorial, so it shouldn't be that hard to clean up. -Ekr On Wed, Mar 15, 2017 at 8:07 AM, Stephen Farrell wrote: > > Thanks Eric, > > Let's see what folks say in response to this and I can post > anything

Re: [TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread Stephen Farrell
Thanks Eric, Let's see what folks say in response to this and I can post anything not immediately resolved as a DISCUSS ballot. We can then process that in the coming week or two, and you can take over the DISCUSS for whatever's not resolved by the swap-over in Chicago. Or if someone else wants

[TLS] Review of draft-ietf-tls-rfc4492bis-15

2017-03-15 Thread Eric Rescorla
Sorry for the late review of this document. I just got to it this week. I'm sending this as comments rather than issues/PR due to how late it is in the proces. I have two high-level comments: - This document seems to still have a bunch of material about static DH (especially static DH