Re: [PATCH 1/4] screen-redraw.c: Improve names of border related functions.

On Sun, Oct 27, 2013 at 11:37:02PM +0100, Marcel Partap wrote: > Rename > screen_redraw_cell_border1() => screen_redraw_get_border_rel() > screen_redraw_cell_border() => screen_redraw_cell_is_border() > screen_redraw_check_cell() => screen_redraw_get_cell_type() > screen_redraw_check_active(

Re: [PATCH 3/4] Merge function into code block. Less confusion.

I think this is worse. Original message From: Marcel Partap Date: 27/10/2013 22:37 (GMT+00:00) To: tmux-users@lists.sourceforge.net Subject: [PATCH 3/4] Merge function into code block. Less confusion. --- screen-redraw.c | 77 -

Re: [PATCH 1/4] screen-redraw.c: Improve names of border related functions.

This seems to do more than just rename? Don't like get_border_rel maybe is_pane_border? Also last one is too long. Original message From: Marcel Partap Date: 27/10/2013 22:37 (GMT+00:00) To: tmux-users@lists.sourceforge.net Subject: [PATCH 1/4] screen-redraw.c: Improve na

Re: [PATCH 4/4] Show how VT100 ACS (alternate character set) should actually render.

Source files need to stay 7-bit ASCII. You could include the Unicode symbol names in a comment instead. Original message From: Marcel Partap Date: 27/10/2013 22:37 (GMT+00:00) To: tmux-users@lists.sourceforge.net Subject: [PATCH 4/4] Show how VT100 ACS (alternate character

[PATCH 1/4] screen-redraw.c: Improve names of border related functions.

Rename screen_redraw_cell_border1() => screen_redraw_get_border_rel() screen_redraw_cell_border() => screen_redraw_cell_is_border() screen_redraw_check_cell() => screen_redraw_get_cell_type() screen_redraw_check_active() => screen_redraw_check_active_pane_indicator() --- screen-redraw.c | 6

[PATCH 2/4] Add option to choose active-pane indicator (none, colorsplit, arrows).

--- examples/tmux.vim | 2 +- options-table.c | 9 + screen-redraw.c | 27 ++- tmux.1| 5 + tty-term.c| 2 +- 5 files changed, 38 insertions(+), 7 deletions(-) diff --git a/examples/tmux.vim b/examples/tmux.vim index e85f8ff..7547e35

[PATCH 4/4] Show how VT100 ACS (alternate character set) should actually render.

--- screen-redraw.c | 2 ++ tty-acs.c | 64 - 2 files changed, 34 insertions(+), 32 deletions(-) diff --git a/screen-redraw.c b/screen-redraw.c index 1af1bb1..9e387c3 100644 --- a/screen-redraw.c +++ b/screen-redraw.c @@ -44,6 +44,7 @

[PATCH 3/4] Merge function into code block. Less confusion.

--- screen-redraw.c | 77 - 1 file changed, 27 insertions(+), 50 deletions(-) diff --git a/screen-redraw.c b/screen-redraw.c index 6131907..1af1bb1 100644 --- a/screen-redraw.c +++ b/screen-redraw.c @@ -26,8 +26,6 @@ int screen_redraw_get_