Re: [PATCH] dynamic cmd_table maybe 2

2013-03-26 Thread Nicholas Marriott
I am happy to look at this stuff but I don't think we should actually include this change at least until we are also adding something that uses it. Don't know if I didn't make that clear before :-). On Mon, Mar 25, 2013 at 04:15:12PM +, Philip Herron wrote: > Yeah i understand what you mean.

Re: [PATCH] dynamic cmd_table maybe 2

2013-03-25 Thread Philip Herron
Yeah i understand what you mean. I remember posting my python stuff before i am cleaning it all up at the moment. And i remember Nic saying about how he wasn't against the idea of a dynamic cmd table. I think its an interesting patch since we can change stuff at runtime. But its probably only valid

Re: [PATCH] dynamic cmd_table maybe 2

2013-03-22 Thread Thomas Adam
Hi, Given that I'm about to roll-out hook-support -- what is this change for? I vaguely recall some mangling of cmd.c to support some odd python-specific integration in the past -- and I'd personally be loathe to add changes to _that_ end in to tmux, unless they had a more generic benefit elsewhe

[PATCH] dynamic cmd_table maybe 2

2013-03-22 Thread Philip Herron
--- cmd.c | 14 -- tmux.c |2 +- tmux.h |4 +++- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/cmd.c b/cmd.c index c8e9702..083c5eb 100644 --- a/cmd.c +++ b/cmd.c @@ -27,7 +27,8 @@ #include "tmux.h" -const struct cmd_entry *cmd_table[] = { +struct cmd_