Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2015-02-22 Thread Balazs Kezes
On 2015-01-25 00:18 +, Nicholas Marriott wrote: > Unfortunately I don't have the backtrace anymore, I was busy and the > easiest thing at the time was to revert it, it was definitely under > grid_view_insert_cells and I couldn't see anything obvious. I've kept running my main instance with thi

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2015-01-24 Thread Nicholas Marriott
Hi Unfortunately I don't have the backtrace anymore, I was busy and the easiest thing at the time was to revert it, it was definitely under grid_view_insert_cells and I couldn't see anything obvious. I only saw it very occasionally and never managed to reproduce - I know it was crashing regularly

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2015-01-24 Thread Balazs Kezes
On 2015-01-06 21:31 +, Nicholas Marriott wrote: > This was causing random crashes, so it's clearly still wrong and I've > reverted back to before any of these changes. I don't have time to > look into it further but maybe you want to have a look (with valgrind > maybe?). I had no luck reproduc

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2015-01-06 Thread Nicholas Marriott
This was causing random crashes, so it's clearly still wrong and I've reverted back to before any of these changes. I don't have time to look into it further but maybe you want to have a look (with valgrind maybe?). Cheers On Mon, Dec 01, 2014 at 10:23:54PM +, Nicholas Marriott wrote: > I th

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-12-01 Thread Nicholas Marriott
I think this is alright, the calculations seem sensible anyway. On Sat, Nov 29, 2014 at 09:31:10PM +, Balazs Kezes wrote: > Disregard my previous patch, after a little bit of thinking I came up > with this: > > diff --git a/grid-view.c b/grid-view.c > index a34c5a0..0b890d8 100644 > --- a/gr

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-29 Thread Balazs Kezes
Disregard my previous patch, after a little bit of thinking I came up with this: diff --git a/grid-view.c b/grid-view.c index a34c5a0..0b890d8 100644 --- a/grid-view.c +++ b/grid-view.c @@ -184,9 +184,10 @@ grid_view_insert_cells(struct grid *gd, u_int px, u_int py, u_int nx) px = grid_vi

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-21 Thread Balazs Kezes
Hey Nick! Sorry, but this is still broken. :( You can reproduce it in bash, if you type "a b" then go to the beginning press "c": you can see that the "b" has disappeared and all you can see is "ca". Here's a patch to fix this. diff --git a/grid-view.c b/grid-view.c index a34c5a0..defb86d 10064

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-12 Thread Nicholas Marriott
Looks good, applied thanks On Mon, Nov 10, 2014 at 08:55:38PM +, Balazs Kezes wrote: > On 2014-11-10 20:04 +, Nicholas Marriott wrote: > > I reverted the grid-view.c change because it breaks insertion. Try: > > $ tmux new 'tput ich 10' > > Oh, sorry about that. What a silly mistake, the 4

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-10 Thread Balazs Kezes
On 2014-11-10 20:04 +, Nicholas Marriott wrote: > I reverted the grid-view.c change because it breaks insertion. Try: > $ tmux new 'tput ich 10' Oh, sorry about that. What a silly mistake, the 4th parameter underflows in grid_move_cells: ... #1 0x0042a3f9 in log_fatal (msg=0x46e461 "

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-10 Thread Nicholas Marriott
Hi I reverted the grid-view.c change because it breaks insertion. Try: $ tmux new 'tput ich 10' I guess probably the line does need to be extended a bit... On Sat, Nov 08, 2014 at 12:58:52PM +, Nicholas Marriott wrote: > Both this and the other one make sense to me - applied, thanks! >

Re: [PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-08 Thread Nicholas Marriott
Both this and the other one make sense to me - applied, thanks! On Fri, Nov 07, 2014 at 04:31:10PM +, Balazs Kezes wrote: > Steps to reproduce: > 1. Create a vertical split. > 2. Assuming we are running bash in the left pane, enter this: >echo -e 'xy\e[D\e[@' ># or >echo -e 'xyz\e

[PATCH 1/2] Fix broken reflowing after insert/delete characters

2014-11-07 Thread Balazs Kezes
Steps to reproduce: 1. Create a vertical split. 2. Assuming we are running bash in the left pane, enter this: echo -e 'xy\e[D\e[@' # or echo -e 'xyz\e[2D\e[P' 3. Make the left pane smaller: tmux resize-pane -L 5 4. Observe the extra newline. This is ugly. This happens because whenever