Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2013-01-15 Thread Nicholas Marriott
Hi Sorry for the delay. I like the new behaviour but I'm not averse to another case in cmd_get_default_path for the old if it can be derived without too much disruption. On Wed, Dec 19, 2012 at 11:32:31AM -0500, Benjamin Poirier wrote: > [ original thread: > http://thread.gmane.org/gmane.comp.

Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-12-21 Thread Benjamin Poirier
[ original thread: http://thread.gmane.org/gmane.comp.terminal-emulators.tmux.user/3274/focus=3286 ] commit 5d60bc7f7c43c20fcf65531b5a5fb1fc7dcbb338 Author: Nicholas Marriott Date: Mon Sep 24 14:05:38 2012 +0100 Use pgrp of pty fd not pid of immediate child when recovering current working

Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-09-24 Thread Nicholas Marriott
Applied, thanks. On Sat, Sep 15, 2012 at 03:22:37PM +0200, Marcel Partap wrote: > by picking up the process group leader from the terminal fd > via tcgetpgrp() instead of using the direct pane child process. > > (works on linux, other platforms untested) > --- > trunk/cmd.c |2 +

Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-09-16 Thread Nicholas Marriott
I think this makes sense, will look at it more closely tomorrow though. On Sat, Sep 15, 2012 at 03:22:37PM +0200, Marcel Partap wrote: > by picking up the process group leader from the terminal fd > via tcgetpgrp() instead of using the direct pane child process. > > (works on linux, other platfo

Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-09-16 Thread Marcel Partap
>> by picking up the process group leader from the terminal fd >> via tcgetpgrp() instead of using the direct pane child process. > > Why? I mean, what problem is this solving? You don't mention it in your > commit message. Nested subshells and su invocations. Consider this: > # root key binding

Re: [PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-09-15 Thread Thomas Adam
On Sat, Sep 15, 2012 at 03:22:37PM +0200, Marcel Partap wrote: > by picking up the process group leader from the terminal fd > via tcgetpgrp() instead of using the direct pane child process. Why? I mean, what problem is this solving? You don't mention it in your commit message. -- Thomas Adam

[PATCH 1/7] Find working path of foreground sub process in osdep_get_cwd

2012-09-15 Thread Marcel Partap
by picking up the process group leader from the terminal fd via tcgetpgrp() instead of using the direct pane child process. (works on linux, other platforms untested) --- trunk/cmd.c |2 +- trunk/format.c |2 +- trunk/osdep-aix.c |2 +- trunk/osdep-darwin.c