RE: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-04 Thread pero
ok, looked into cvs so forget that mail :) > -Original Message- > From: pero [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, February 05, 2003 4:20 AM > To: 'Tomcat Developers List' > Subject: RE: [PATCH] allow tomcat5 to compile/run with JDK1.3 >

RE: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-04 Thread pero
> Everyone will call JdkCompat.getJdkCompat() to get a > JdkCompat instance. > When JdkCompat is statically initialized, it determines which > implementation to load. Currently, it performs a check on > System.getProperty("java.version"). If the property starts > with 1.4 then > the Jdk14Comp

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Tim Funk
Here is an attempt at a JdkCompat implementation. There are 2 classes, JdkCompat which is the base support class and Jdk14Compat which extends JdkCompat. The patch is in JdkCompat.txt for WebappClassloader and build.xml. I manually edited the patch file to eliminate all the extra edits my text

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Tim Funk wrote: > To get functionality like jdkCompat (and looking at tomcat3), it looks > like something similar to the following would need added to the existing > jakarta-tomcat-catalina/catalina/build.xml: > -- > unless="jdk.1.4.present"/

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Tim Funk
To get functionality like jdkCompat (and looking at tomcat3), it looks like something similar to the following would need added to the existing jakarta-tomcat-catalina/catalina/build.xml: -- unless="jdk.1.4.present"/> -

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: >> >> >>>Tim Funk wrote: >>> Tomcat5 does not compile with JDK1.3. It does with JDK1.4. There is only one line of code that prevents it from compiling with JDK1.3. org.apache.catalina.loader.WebappClassLoad

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Remy Maucherat
Costin Manolache wrote: Tim Funk wrote: Oh, NO. Please don't even think about it Commons-dbcp must do it because it is impossible to write a JDBC driver that works and compiles in both 1.3 and 1.4. Reflection is fine - I would preffer using a jdkCompat-like trick and have substitute code f

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Remy Maucherat
Costin Manolache wrote: Remy Maucherat wrote: Tim Funk wrote: Tomcat5 does not compile with JDK1.3. It does with JDK1.4. There is only one line of code that prevents it from compiling with JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on File.toURI() which does not exist on jd

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Tim Funk wrote: > After looking at the older revisions, I agree my patch was stupendously > horrible :( > > The patch now uses reflection to keep the current code equivalent for > jdk14 and use the old way in case of a jdk1.3 jvm. > > That being said - I would assume that the RMI issue your patc

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Remy Maucherat wrote: > Tim Funk wrote: >> Tomcat5 does not compile with JDK1.3. It does with JDK1.4. >> >> There is only one line of code that prevents it from compiling with >> JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on >> File.toURI() which does not exist on jdk1.3. >> >>

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Tim Funk
After looking at the older revisions, I agree my patch was stupendously horrible :( The patch now uses reflection to keep the current code equivalent for jdk14 and use the old way in case of a jdk1.3 jvm. That being said - I would assume that the RMI issue your patch addressed would still be a

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Remy Maucherat
Tim Funk wrote: Tomcat5 does not compile with JDK1.3. It does with JDK1.4. There is only one line of code that prevents it from compiling with JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on File.toURI() which does not exist on jdk1.3. I got around this by the performing the fol

[PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-02 Thread Tim Funk
Tomcat5 does not compile with JDK1.3. It does with JDK1.4. There is only one line of code that prevents it from compiling with JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on File.toURI() which does not exist on jdk1.3. I got around this by the performing the following: OLD CODE: