Henri,
>> BTW while testing with this I found that on Linux when compiled with APXS
>> also no PCRE is used...
> What do you means ?
just to confirm this quickly I just inserted a line 'xxx' inside the HAS_PCRE in
jk_uriEnv.c and compilation went trough without error, while if I add '-DHAS_PCRE'
Hi Guenter,
I've reviewed your patch and have some comments included inline below.
From: "Guenter Knauf" <[EMAIL PROTECTED]>
> Hi all,
> the previous patch seems to break non-Apache connectors, so here's
another patch which shouldnt break anything unless you set the
HAVE_AP_PCRE.
>
> I would like
Hi Kurt,
> I've reviewed your patch and have some comments included inline below.
> regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp
> needs an apr_pool to be passed to it and it returns the regex_t. I
> think (apr_pool_t *)uriEnv->pool->_private is correct here (Henri?,
> Je
Hi Kurt,
> I've reviewed your patch and have some comments included inline below.
> regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp
> needs an apr_pool to be passed to it and it returns the regex_t. I
> think (apr_pool_t *)uriEnv->pool->_private is correct here (Henri?,
> Je
Hi Guenter,
Just a tweak or two and its ready. The preg calloc only applies to the
HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
test and commit it tomorrow.
-Kurt
From: "Guenter Knauf" <[EMAIL PROTECTED]>
> Hi Kurt,
> > I've reviewed your patch and have some comments in
Hi Kurt,
> Just a tweak or two and its ready. The preg calloc only applies to the
> HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
> test and commit it tomorrow.
yep, forgot to remove PREGCOMP.
you mean perhaps so:
{
#ifdef HAS_AP_PCRE
regex_t *preg = a
Hi Kurt,
> Just a tweak or two and its ready. The preg calloc only applies to the
> HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
> test and commit it tomorrow.
thanks again for reviewing and comments!
Guenter.
http://www.gknw.com/test/pcre_patch4
Guenter Knauf wrote:
Hi Henri,
+#include "httpd.h"
httpd.h may not be found for IIS or Netscape, so it will brake these.
Ditto for others.
yep - found this already; please see my second patch which shouldnt break any other platforms.
ok
BTW while testing with this I found that on Linux when c
Hi Henri,
>> +#include "httpd.h"
> httpd.h may not be found for IIS or Netscape, so it will brake these.
> Ditto for others.
yep - found this already; please see my second patch which shouldnt break any other
platforms.
BTW while testing with this I found that on Linux when compiled with APXS als
Guenter Knauf wrote:
Hi all,
I would like to get this patch into CVS in order to use PCRE on NetWare where only the
ap_ prefixed pcre functions are exported. I have tested that the patch below compiles
fine with NetWare, Linux and Win32.
As a positive side effect on Win32 the binary is about 24
Hi all,
the previous patch seems to break non-Apache connectors, so here's another patch which
shouldnt break anything unless you set the HAVE_AP_PCRE.
I would like to get this patch into CVS in order to use PCRE on NetWare where only the
ap_ prefixed pcre functions are exported. I have tested t
Hi all,
I would like to get this patch into CVS in order to use PCRE on NetWare where only the
ap_ prefixed pcre functions are exported. I have tested that the patch below compiles
fine with NetWare, Linux and Win32.
As a positive side effect on Win32 the binary is about 24 kb smaller.
Guenter.
12 matches
Mail list logo
