Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-10-06 Thread James C. McPherson
Hi everybody, thankyou for the reviews on phase 1, I've now incorporated your feedback and merged in some more changes from Rich which remove references to INS.dir.root.sys and INS.dir.root.bin (6880460) since they are definitely not needed any more. I've also resolved 6885068 no need for racine

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-10-06 Thread James C. McPherson
Danek Duvall wrote: James C. McPherson wrote: The answer is that while most people are using bldenv or nightly with an appropriate env file, some (including myself) use "ws" or some other method to set $SRC, $ROOT etc. Having the PRE_POUND etc in Makefile.master makes sure that those people als

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-24 Thread James C. McPherson
Richard Lowe wrote: Danek Duvall writes: James C. McPherson wrote: The answer is that while most people are using bldenv or nightly with an appropriate env file, some (including myself) use "ws" or some other method to set $SRC, $ROOT etc. Having the PRE_POUND etc in Makefile.master makes su

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-23 Thread Richard Lowe
Danek Duvall writes: > James C. McPherson wrote: > >> The answer is that while most people are using bldenv or nightly with >> an appropriate env file, some (including myself) use "ws" or some other >> method to set $SRC, $ROOT etc. Having the PRE_POUND etc in Makefile.master >> makes sure that t

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-23 Thread Danek Duvall
James C. McPherson wrote: > The answer is that while most people are using bldenv or nightly with > an appropriate env file, some (including myself) use "ws" or some other > method to set $SRC, $ROOT etc. Having the PRE_POUND etc in Makefile.master > makes sure that those people also see the benef

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-23 Thread Darren Reed
Danek Duvall wrote: James C. McPherson wrote: http://cr.opensolaris.org/~jmcp/6414832/webrev Is the new way of computing POUND_SIGN in Makefile.master on top of setting POUND_SIGN in nightly and bldenv just belt and suspenders? Shouldn't the first do the trick? (Cute trick, BTW.) g

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-23 Thread James C. McPherson
James C. McPherson wrote: Hi folks, as I mentioned to Rainer eariler this evening, I've been working on changes for the following CRs: 6414832 SUNWonbld gk account should be removed 6536468 date in Nevada motd should be changed 6855668 webrev mangles dates in non-Romanised locales 6866716 estim

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread Brent Paulson
On Tue, Sep 22, 2009 at 08:54:18AM -0700, Danek Duvall wrote: > James C. McPherson wrote: > > > http://cr.opensolaris.org/~jmcp/6414832/webrev > gen_make.machines.sh: > - line 40: might > > kstat -p ::cpu_info0:clock_MHz | awk '{print $1}' > > be more appropriate? Line 40 sets t

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread Richard Lowe
Danek Duvall writes: > James Carlson wrote: > >> I almost commented on the same thing ... but then declined because a mix >> of old nightly with new code and vice-versa is not unlikely for some >> time to come, so having both helps everyone. > > Good point. I'd just add a comment to that effect,

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread Danek Duvall
James Carlson wrote: > I almost commented on the same thing ... but then declined because a mix > of old nightly with new code and vice-versa is not unlikely for some > time to come, so having both helps everyone. Good point. I'd just add a comment to that effect, then. Danek __

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread James Carlson
Danek Duvall wrote: > James C. McPherson wrote: > >> http://cr.opensolaris.org/~jmcp/6414832/webrev > > Is the new way of computing POUND_SIGN in Makefile.master on top of setting > POUND_SIGN in nightly and bldenv just belt and suspenders? Shouldn't the > first do the trick? (Cute trick, BTW.)

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread Danek Duvall
James C. McPherson wrote: > http://cr.opensolaris.org/~jmcp/6414832/webrev Is the new way of computing POUND_SIGN in Makefile.master on top of setting POUND_SIGN in nightly and bldenv just belt and suspenders? Shouldn't the first do the trick? (Cute trick, BTW.) gen_make.machines.sh: - line

Re: [tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread James Carlson
James C. McPherson wrote: > The webrev is available at > > http://cr.opensolaris.org/~jmcp/6414832/webrev Looks good, and thanks for getting CR 6750554 in here! -- James Carlson 42.703N 71.076W ___ tools-discuss mailing list tools-dis

[tools-discuss] code review request for several SUNWonbld and Makefile changes

2009-09-22 Thread James C. McPherson
Hi folks, as I mentioned to Rainer eariler this evening, I've been working on changes for the following CRs: 6414832 SUNWonbld gk account should be removed 6536468 date in Nevada motd should be changed 6855668 webrev mangles dates in non-Romanised locales 6866716 estimation of max-jobs for /.mak