[tor-commits] [tor/master] microdesc_parse: convert some ints to bools

commit c309169217eace3eaee84f3dc16347234929e4b3 Author: Nick Mathewson Date: Thu Sep 19 13:59:37 2019 -0400 microdesc_parse: convert some ints to bools Noted by ahf during review of #31675 --- src/feature/dirparse/microdesc_parse.c | 15 --- 1 file changed, 8

[tor-commits] [tor/master] Extract field-parsing code for microdesc_parse.c

commit ec368409fa7732a08e85c1bfb254469f02458266 Author: Nick Mathewson Date: Mon Sep 9 15:41:24 2019 -0400 Extract field-parsing code for microdesc_parse.c The code here parses the fields from the microdescriptor, including possible annotations, and stores them into a

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1309'

commit 99f75373def3520fac4f00c072748f2a0886c923 Merge: 0cb57a490 c30916921 Author: George Kadianakis Date: Wed Sep 25 14:12:42 2019 +0300 Merge branch 'tor-github/pr/1309' changes/ticket31675 | 3 + scripts/maint/practracker/exceptions.txt | 1 -

[tor-commits] [tor/master] Add a coccinelle script to look for {inc, dec}rements in log_debug

commit 387cfccee47394adeba8cbf49c130cc9b332b025 Author: Nick Mathewson Date: Wed Sep 11 18:53:16 2019 -0400 Add a coccinelle script to look for {inc,dec}rements in log_debug We want to forbid this pattern since, unlike the other log_*() macros, log_debug() conditionally

[tor-commits] [tor/master] Extract the body-copying portion of microdesc parsing

commit 9cbc166ea038e51baec92c8f37a2646c76a97480 Author: Nick Mathewson Date: Mon Sep 9 15:21:01 2019 -0400 Extract the body-copying portion of microdesc parsing This code is logically independent of the rest of the function, and goes better in its own function. This

[tor-commits] [tor/master] microdesc_parse: Rename "next" label to "err".

commit 194884977cf00804ddac19e6211cd47aec9099ca Author: Nick Mathewson Date: Mon Sep 9 15:47:01 2019 -0400 microdesc_parse: Rename "next" label to "err". --- src/feature/dirparse/microdesc_parse.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[tor-commits] [tor/master] Reindent microdesc_extract_body().

commit b1552e8814559fc8bf773765975fa1fded83c391 Author: Nick Mathewson Date: Mon Sep 9 15:22:16 2019 -0400 Reindent microdesc_extract_body(). This commit is whitespace-only; I suggest reviewing with -b. --- src/feature/dirparse/microdesc_parse.c | 30

[tor-commits] [tor/master] changes file for microdesc_parse refactoring.

commit 6100378c29072dda5264d9e88993133f484df168 Author: Nick Mathewson Date: Mon Sep 9 15:48:58 2019 -0400 changes file for microdesc_parse refactoring. --- changes/ticket31675 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/ticket31675 b/changes/ticket31675 new file mode

[tor-commits] [tor/master] Reindent microdesc_parse_fields().

commit 2094796c24e1f4e5868a4d4e2e29fd45d4e0a799 Author: Nick Mathewson Date: Mon Sep 9 15:44:56 2019 -0400 Reindent microdesc_parse_fields(). I suggest reviewing this with -b: it should be whitespace-only. --- src/feature/dirparse/microdesc_parse.c | 150

[tor-commits] [tor/master] Add a unit test for ed25519 identity parsing in microdescriptors

commit d8ef6b154890e1b6e8842c68ebd68d954c852e38 Author: Nick Mathewson Date: Mon Sep 9 20:24:03 2019 -0400 Add a unit test for ed25519 identity parsing in microdescriptors This test makes sure that we parse ed25519 identities to get the correct data from them. It also tests:

[tor-commits] [tor/master] Remove practracker exception for microdesc parsing function

commit 2e1989daccde12db31aa0b89d27e8c8d58ed26bb Author: Nick Mathewson Date: Mon Sep 9 15:47:46 2019 -0400 Remove practracker exception for microdesc parsing function --- scripts/maint/practracker/exceptions.txt | 1 - 1 file changed, 1 deletion(-) diff --git

[tor-commits] [tor/master] Do not look inside bogus microdesc when listing its digest as invalid

commit e7d7e04155f0c7dd1282d4c77bdd02cae8bc0fe7 Author: Nick Mathewson Date: Mon Sep 9 12:58:30 2019 -0400 Do not look inside bogus microdesc when listing its digest as invalid We have code in microdescs_parse_from_string() to record the digests of microdescriptors that we

[tor-commits] [tor/master] Extract saved_location_to_string() from microdesc parsing.

commit 7282213bd3aa1b21928e7d134180781158ebdb4b Author: Nick Mathewson Date: Mon Sep 9 12:56:04 2019 -0400 Extract saved_location_to_string() from microdesc parsing. We may be able to use this function in other places in the future; if so, we should move it to somewhere more

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1323'

commit 585eaa123f21c4fed85865b938aeafac47730fec Merge: a28a682a1 34bab120d Author: George Kadianakis Date: Tue Sep 17 14:51:43 2019 +0300 Merge branch 'tor-github/pr/1323' changes/ticket31687_1 | 4 changes/ticket31687_2 | 5 + src/core/or/connection_edge.c |

[tor-commits] [tor/master] pf: when extracting an IPv6 address, make sure we got an IPv6 address

commit 97f7efa9e3316e4e8970a87a1ee53fd4fd0075d8 Author: Nick Mathewson Date: Tue Sep 10 11:07:25 2019 -0400 pf: when extracting an IPv6 address, make sure we got an IPv6 address Our code assumes that when we're configured to get IPv6 addresses out of a TRANS_PF transparent

[tor-commits] [tor/master] Ticket 31687: fix for tor_isinf() as well

commit 34bab120df213970edf32db1f3462ff2585ee098 Author: Nick Mathewson Date: Thu Sep 12 09:53:13 2019 -0400 Ticket 31687: fix for tor_isinf() as well tor_isinf() was new in 0.4.0, and also needs to look at the same rules as clamp_double_to_i64() --- src/lib/math/fp.c | 11

[tor-commits] [tor/master] Merge branch 'ticket31687_035' into ticket31687_040

commit 0327f9a0757e202666ec54460a69303633af4b33 Merge: 896a1ac50 97f7efa9e Author: Nick Mathewson Date: Thu Sep 12 09:51:04 2019 -0400 Merge branch 'ticket31687_035' into ticket31687_040 changes/ticket31687_1 | 4 changes/ticket31687_2 | 5 +

[tor-commits] [tor/master] fp.c: Suppress float-conversion warnings on FreeBSD.

commit 51475aee57523318d0b0a9e47dedad89ef1b578c Author: Nick Mathewson Date: Tue Sep 10 10:53:39 2019 -0400 fp.c: Suppress float-conversion warnings on FreeBSD. We used to do this on Windows only, but it appears to affect multiple platforms when building with certain versions

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1312'

commit 987742373645d4d4de20059066ef1855478753e7 Merge: 8377b610b f0044e44f Author: George Kadianakis Date: Mon Sep 16 19:44:33 2019 +0300 Merge branch 'tor-github/pr/1312' changes/ticket31678 | 4 ++ scripts/git/git-merge-forward.sh | 63 ++

[tor-commits] [tor/master] scripts: Make the git scripts show usage messages

commit f0044e44f2afaac08bf8b7ac931a652a8d998904 Author: teor Date: Tue Sep 10 12:14:49 2019 +1000 scripts: Make the git scripts show usage messages All of the git scripts now have usage messages on: * a new -h option, and * usage errors. Closes 31677. ---

[tor-commits] [tor/master] scripts: reformat the comments in git-pull-all.sh for consistency

commit 785391a9342a84a926d672c602189f9ef87f8ec0 Author: teor Date: Tue Sep 10 12:14:00 2019 +1000 scripts: reformat the comments in git-pull-all.sh for consistency Preparation for 31677. --- scripts/git/git-pull-all.sh | 18 +++--- 1 file changed, 11 insertions(+), 7

[tor-commits] [tor/master] scripts: Improve a usage message in git-push-all.sh

commit 97da440f9efeac6c70983ba5de01a9104048d612 Author: teor Date: Tue Sep 10 12:12:04 2019 +1000 scripts: Improve a usage message in git-push-all.sh Part of 31677. --- scripts/git/git-push-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[tor-commits] [tor/master] scripts: Make checkShellScripts.sh error exit if it can't find src

commit af12b6fd294c3019b8109d9607cd24740a0d3a99 Author: teor Date: Tue Sep 10 12:24:08 2019 +1000 scripts: Make checkShellScripts.sh error exit if it can't find src Closes 31679. --- scripts/maint/checkShellScripts.sh | 1 + 1 file changed, 1 insertion(+) diff --git

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1313'

commit 8f2ab4522908df982b89382e57c001f6869ccad6 Merge: 987742373 af12b6fd2 Author: George Kadianakis Date: Mon Sep 16 19:45:20 2019 +0300 Merge branch 'tor-github/pr/1313' scripts/maint/checkShellScripts.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[tor-commits] [tor/master] scripts: Allow checkShellScripts.sh to be run from its parent directory

commit 8c37bf738dce0bf8487e94e386ed3d580e5d13c3 Author: teor Date: Tue Sep 10 12:23:12 2019 +1000 scripts: Allow checkShellScripts.sh to be run from its parent directory ... on systems that don't have realpath. Part of 31679. --- scripts/maint/checkShellScripts.sh | 2 +-

[tor-commits] [tor/master] scripts: Allow git-push-all.sh to be run from any directory

commit 51b792b000d8560cf5b61b887eadcd9aece27d04 Author: teor Date: Tue Sep 10 12:07:13 2019 +1000 scripts: Allow git-push-all.sh to be run from any directory Closes 31678. --- changes/ticket31678 | 4 scripts/git/git-push-all.sh | 18 -- 2 files

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1327'

commit 8377b610bd0821fc2c272aa6b105bb259f2efe7a Merge: f6ea89024 8ad419744 Author: George Kadianakis Date: Mon Sep 16 19:43:44 2019 +0300 Merge branch 'tor-github/pr/1327' src/test/test_parseconf.sh | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-)

[tor-commits] [tor/master] Fix a shellcheck warning in test_parseconf.sh.

commit a1694b73632952e15c9d54ae3306e641a8d5e94a Author: Nick Mathewson Date: Mon Sep 16 09:22:43 2019 -0400 Fix a shellcheck warning in test_parseconf.sh. I wonder why this didn't show up before. --- src/test/test_parseconf.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[tor-commits] [tor/master] On windows, allow failures in test_parseconf.sh

commit 8ad419744f7956bb755f4afec113d1ad0395043f Author: Nick Mathewson Date: Mon Sep 16 09:23:09 2019 -0400 On windows, allow failures in test_parseconf.sh There seems to be some unreliability issue with this test on appveyor. Addresses ticket 31757; This isn't a

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1316'

commit cd72850e08f39413d281a480a78f38838ddf42e9 Merge: 5ec751b38 bfc5f0997 Author: George Kadianakis Date: Mon Sep 16 15:22:18 2019 +0300 Merge branch 'tor-github/pr/1316' changes/ticket31475 | 5 + src/lib/confmgt/type_defs.c | 20 ++--

[tor-commits] [tor/master] Detect overflow or underflow on double config values.

commit bfc5f09979d49867b373b9433edf37adce8c66dd Author: Nick Mathewson Date: Fri Sep 13 18:24:15 2019 -0400 Detect overflow or underflow on double config values. Any floating point value too positive or negative to distinguish from +/-Inf, or too small to distinguish from

[tor-commits] [tor/master] Use strtod, not atof, for parsing doubles in the configuration.

commit 9d604959036bd02e7ff0ca1bd33f842664610b82 Author: Nick Mathewson Date: Tue Sep 10 18:59:10 2019 -0400 Use strtod, not atof, for parsing doubles in the configuration. This lets us detect erroneous doubles, which previously we could not do. Fixes bug 31475; bugfix

[tor-commits] [tor/master] Add a test with many non-default options.

commit 7e9ee3a58d609b284b163a22782488350a2f0d0b Author: Nick Mathewson Date: Fri Sep 13 18:07:26 2019 -0400 Add a test with many non-default options. --- src/test/conf_examples/large_1/expected | 159 ++ src/test/conf_examples/large_1/torrc| 167

[tor-commits] [tor/master] Add a few error test cases

commit 617679df420234019f1395d61f051a6521eb4062 Author: Nick Mathewson Date: Fri Sep 13 17:10:15 2019 -0400 Add a few error test cases --- src/test/conf_examples/badnick_1/error | 1 + src/test/conf_examples/badnick_1/torrc | 2 ++

[tor-commits] [tor/master] Add an integration test for %include.

commit 80e858e3e63aa4141415cb177551893fb91b75df Author: Nick Mathewson Date: Fri Sep 13 16:53:40 2019 -0400 Add an integration test for %include. --- src/test/conf_examples/include_1/expected | 3 +++ src/test/conf_examples/include_1/included.inc | 4

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1324'

commit 5ec751b38b6ea5b40dece321a2c673c6b7e9cf01 Merge: a1192b6b4 11cf4d9c3 Author: George Kadianakis Date: Mon Sep 16 15:21:28 2019 +0300 Merge branch 'tor-github/pr/1324' changes/ticket31637 | 6 + src/test/conf_examples/badnick_1/error | 1 +

[tor-commits] [tor/master] test_parseconf.sh: On --dump-config failure, --verify-config

commit 11cf4d9c3a62c4c501f91e883d1645cc57fbbee9 Author: Nick Mathewson Date: Fri Sep 13 18:31:59 2019 -0400 test_parseconf.sh: On --dump-config failure, --verify-config --- src/test/test_parseconf.sh | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] test_parseconf: run each test from inside its directory.

commit 28025698a15e19f0336b48d057177382a5a30b35 Author: Nick Mathewson Date: Fri Sep 13 16:45:58 2019 -0400 test_parseconf: run each test from inside its directory. We need this to test includes and relative paths. --- src/test/test_parseconf.sh | 45

[tor-commits] [tor/master] Add test for +Option, /Option, and Option

commit 850a00dc07d33c6bd9af660281b4fd1baa6a0a6f Author: Nick Mathewson Date: Thu Sep 12 16:42:03 2019 -0400 Add test for +Option, /Option, and Option Here we use these directives to replace, extend, or clear values in torrc.defaults and in torrc. ---

[tor-commits] [tor/master] Add a test script to try parsing and encoding Tor configurations

commit 7c7e8402b599515846cbb77ab4cbb5520f8463d8 Author: Nick Mathewson Date: Wed Sep 11 14:50:06 2019 -0400 Add a test script to try parsing and encoding Tor configurations This script takes a set of example torrcs and command-lines from src/test/conf_examples. If a success

[tor-commits] [tor/master] Move our first 3 example conf_examples to named directories

commit 2f7be9620b92e922b91e079d6d5cf216ff1509db Author: Nick Mathewson Date: Thu Sep 12 15:56:32 2019 -0400 Move our first 3 example conf_examples to named directories I'm not planning to use "example" as the name for all of them, but these first three _are_ simple examples.

[tor-commits] [tor/master] Add a changes file for ticket 31637.

commit 98ab3817a86239f9c4888339625a55c55505ede2 Author: Nick Mathewson Date: Thu Sep 12 16:54:32 2019 -0400 Add a changes file for ticket 31637. --- changes/ticket31637 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/changes/ticket31637 b/changes/ticket31637 new file mode 100644

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1273'

commit a1192b6b4afd194043e2f80751ada9f6b30662cf Merge: bdd17da9f fb0e8966f Author: George Kadianakis Date: Mon Sep 16 15:20:25 2019 +0300 Merge branch 'tor-github/pr/1273' changes/bug31552| 5 +++ src/feature/dirauth/keypin.h| 18 -

[tor-commits] [tor/master] Stub out some more functions in dirvote/*.h, fix compilation.

commit 4256ee0d379daf35098c396757ce92b97b025c6e Author: Nick Mathewson Date: Thu Aug 29 09:50:38 2019 -0400 Stub out some more functions in dirvote/*.h, fix compilation. This fixes LTO compilation for Android and -O0 compilation in general, when --disable-module-dirauth is

[tor-commits] [tor/master] Stub more functions in dirvote headers to fix more of 31552.

commit fb0e8966f00c4349602594f312dae60cad2ea11d Author: Nick Mathewson Date: Thu Aug 29 11:18:42 2019 -0400 Stub more functions in dirvote headers to fix more of 31552. --- src/feature/dirauth/keypin.h| 18 -- src/feature/dirauth/process_descs.h | 69

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1318'

commit bdd17da9fdfbe9de0547f27c7a78255a56570aa4 Merge: 286b129b0 0891a31ad Author: George Kadianakis Date: Mon Sep 16 15:19:38 2019 +0300 Merge branch 'tor-github/pr/1318' changes/bug31696 | 5 + src/lib/malloc/map_anon.c | 21 ++--- 2 files changed, 23

[tor-commits] [tor/master] madvise: tolerate EINVAL and ENOSYS when minherit fails

commit 0891a31ad32d0567fbc8f73a0598925cb543d699 Author: Nick Mathewson Date: Wed Sep 11 09:13:50 2019 -0400 madvise: tolerate EINVAL and ENOSYS when minherit fails These errors can occur if we are built on a system with support for madvise(MADV_NOFORK) but then we are run on a

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1303'

commit 028733e8b6f36bae420b1e41897401fa3b14ccf8 Merge: 3aaa4d416 ebce7059f Author: George Kadianakis Date: Thu Sep 12 18:09:35 2019 +0300 Merge branch 'tor-github/pr/1303' changes/bug31594| 5 +++ src/lib/err/backtrace.c | 2 +- src/lib/err/torerr.c| 64

[tor-commits] [tor/master] changes: file for 31594

commit ebce7059ffbc3a4a8b7ff7cf923b0e6a402f4f33 Author: teor Date: Mon Sep 9 13:53:58 2019 +1000 changes: file for 31594 --- changes/bug31594 | 5 + 1 file changed, 5 insertions(+) diff --git a/changes/bug31594 b/changes/bug31594 new file mode 100644 index 0..75e6ec33c ---

[tor-commits] [tor/master] torerr: Close sigsafe fds on shutdown

commit d02ced4cafaed5b11079585f03f47e73034dd980 Author: teor Date: Wed Sep 4 14:54:08 2019 +1000 torerr: Close sigsafe fds on shutdown And clear the list of error fds. Part of 31594. --- src/lib/err/torerr.c | 42 --

[tor-commits] [tor/master] log: Don't close file log fds that are being used by the err module

commit a22fbab98690f802ae3bda276078cc7fc767feba Author: teor Date: Wed Sep 4 15:38:58 2019 +1000 log: Don't close file log fds that are being used by the err module Instead, dup() file log fds, before passing them to the err module. Closes 31613, part of 31594. ---

[tor-commits] [tor/master] log: Close log and err file descriptors before aborting

commit 1609916c79612b5cc3a9b363a22f1a9035f2f77b Author: teor Date: Wed Sep 4 17:16:49 2019 +1000 log: Close log and err file descriptors before aborting Part of 31594. --- src/lib/err/backtrace.c | 2 +- src/lib/err/torerr.c| 16 ++-- src/lib/err/torerr.h

[tor-commits] [tor/master] Workaround for GCC "note" about "variable tracking size limit"

commit c3b1a25d46273a730529f6bfd2ee49cbdac5197a Author: Nick Mathewson Date: Thu Sep 5 17:46:42 2019 -0400 Workaround for GCC "note" about "variable tracking size limit" GCC complains that we are using too many variables here, probably because of the sheer number of locals

[tor-commits] [tor/master] Remove variable declarations from macros in test_addr_parse()

commit 261ec900dbcac91d8da354d93195bbd70a05b483 Author: Nick Mathewson Date: Thu Sep 5 17:12:17 2019 -0400 Remove variable declarations from macros in test_addr_parse() Instead, put them in the function itself. This is an attempt to fix the gcc warning about the "variable

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1299'

commit 3aaa4d416beee81eba3fed1ce9eda17e686fed52 Merge: 87944cecf c3b1a25d4 Author: George Kadianakis Date: Thu Sep 12 18:08:00 2019 +0300 Merge branch 'tor-github/pr/1299' src/test/test_addr.c | 66 1 file changed, 25 insertions(+), 41

[tor-commits] [tor/master] build: The is now deprecated on Linux

commit 409df19b5a0053175f05851086e6ef35c5bce2c0 Author: David Goulet Date: Mon Sep 9 11:55:33 2019 -0400 build: The is now deprecated on Linux Closes #31673 --- changes/ticket31673 | 3 +++ src/lib/meminfo/meminfo.c | 7 --- 2 files changed, 7 insertions(+), 3

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1307'

commit 3b32f2508ca320e63956a3bb746729e1a4fb0190 Merge: e7565855c 409df19b5 Author: George Kadianakis Date: Wed Sep 11 16:19:21 2019 +0300 Merge branch 'tor-github/pr/1307' changes/ticket31673 | 3 +++ src/lib/meminfo/meminfo.c | 7 --- 2 files changed, 7 insertions(+), 3

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1295'

commit 545c21e23dcb2c73ab9d9f33e2ea6906a230b4b5 Merge: ddd01541b 88839ab2a Author: George Kadianakis Date: Thu Sep 5 17:13:29 2019 +0300 Merge branch 'tor-github/pr/1295' src/lib/confmgt/structvar.c | 18 +++--- src/lib/confmgt/typedvar.c | 134

[tor-commits] [tor/master] typedvar: remove now-unused functions taking config_type_t.

commit 161c392a4fbd85e2c67ae977cc6b46840a51151d Author: Nick Mathewson Date: Wed Sep 4 14:54:59 2019 -0400 typedvar: remove now-unused functions taking config_type_t. These functions are no longer used. Part of 31629. --- src/lib/confmgt/typedvar.c | 96

[tor-commits] [tor/master] Remove _ex suffix from typed_var_*_ex() functions.

commit 88839ab2ac489af7b80c2812fc87ab8b89075fbb Author: Nick Mathewson Date: Wed Sep 4 14:58:56 2019 -0400 Remove _ex suffix from typed_var_*_ex() functions. Now that the variants of these functions that took config_line_t are gone, there is no longer any reason for the

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1294'

commit ddd01541b909a84396e2d9ba31266ae63670c938 Merge: fb56b4c2b eb909c4e4 Author: George Kadianakis Date: Thu Sep 5 17:12:19 2019 +0300 Merge branch 'tor-github/pr/1294' src/app/config/confparse.c | 9 ++ src/app/config/confparse.h | 69

[tor-commits] [tor/master] Document warn_deprecated_option().

commit 3db56aeeb8a59629690a05cd43565764a254d1e1 Author: Nick Mathewson Date: Wed Sep 4 14:01:43 2019 -0400 Document warn_deprecated_option(). --- src/app/config/confparse.c | 4 1 file changed, 4 insertions(+) diff --git a/src/app/config/confparse.c b/src/app/config/confparse.c

[tor-commits] [tor/master] Document validate_fn_t as it stands.

commit 39dd2e2aa826930bfe681d99c3e8374757ac511b Author: Nick Mathewson Date: Wed Sep 4 13:54:26 2019 -0400 Document validate_fn_t as it stands. Also document that it will be changed in a later branch. --- src/app/config/confparse.h | 26 ++ 1 file changed,

[tor-commits] [tor/master] Document fields of struct_magic_decl_t.

commit b3c28677159c26070f26909b3f4c2e00e50d7bff Author: Nick Mathewson Date: Wed Sep 4 14:03:38 2019 -0400 Document fields of struct_magic_decl_t. --- src/lib/conf/conftypes.h | 4 1 file changed, 4 insertions(+) diff --git a/src/lib/conf/conftypes.h b/src/lib/conf/conftypes.h index

[tor-commits] [tor/master] config: note that some arguments are required.

commit eb909c4e433087b466e78d33af8eed47adcabf16 Author: Nick Mathewson Date: Thu Sep 5 07:57:36 2019 -0400 config: note that some arguments are required. --- src/app/config/confparse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/app/config/confparse.c

[tor-commits] [tor/master] Document configuration and abbreviation types.

commit 577ea20b3a34ed61bc7a005e4105c63abad85d41 Author: Nick Mathewson Date: Wed Sep 4 13:41:53 2019 -0400 Document configuration and abbreviation types. --- src/app/config/confparse.h | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git

[tor-commits] [tor/master] config_assign: Document CAL_* options.

commit aeda598fd5935331e96975b91eb91bce21096f9b Author: Nick Mathewson Date: Wed Sep 4 13:48:16 2019 -0400 config_assign: Document CAL_* options. These were sort of described in config_assign() documentation, but not so well. --- src/app/config/confparse.h | 20

[tor-commits] [tor/master] Document return value of config_mgr_add_format().

commit 39316da9b643583f52c1ff30bca7a07ea04cdba3 Author: Nick Mathewson Date: Wed Sep 4 14:01:32 2019 -0400 Document return value of config_mgr_add_format(). --- src/app/config/confparse.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/app/config/confparse.c

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1293'

commit fb56b4c2bffe5d1d752694901b1853d89e3fb8cc Merge: c750ec20a 03ce67d37 Author: George Kadianakis Date: Thu Sep 5 17:10:07 2019 +0300 Merge branch 'tor-github/pr/1293' src/lib/conf/conftypes.h | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-)

[tor-commits] [tor/master] config: explain CONFIG_TYPE_EXTENDED

commit 03ce67d37840f260f478009caa04aad1aa9b60c0 Author: Nick Mathewson Date: Wed Sep 4 11:54:42 2019 -0400 config: explain CONFIG_TYPE_EXTENDED Also add an explanation of a possible future refactoring where we might remove the config_type_t enumeration entierly. Fixes

[tor-commits] [tor/master] buffers: use ptrdiff_t to indicate offsets.

commit 3aba13f77927e669d80009b2318c6d3d3d90a922 Author: Nick Mathewson Date: Wed Sep 4 11:06:15 2019 -0400 buffers: use ptrdiff_t to indicate offsets. Previously we used int in some places and off_t for others. Neither is correct: ptrdiff_t is right for differences between

[tor-commits] [tor/master] smartlist_pqueue: use ptrdiff_t instead of int for offsets.

commit dc199f40fb03588af0bccb149a564e895e11d60d Author: Nick Mathewson Date: Wed Sep 4 10:56:14 2019 -0400 smartlist_pqueue: use ptrdiff_t instead of int for offsets. This is technically correct, but should not matter in practice, since we don't use this on any structs whose

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1291'

commit c750ec20ab3f24fad09695317da55888788e772e Merge: c29f05b15 106b75aa5 Author: George Kadianakis Date: Thu Sep 5 17:09:20 2019 +0300 Merge branch 'tor-github/pr/1291' changes/ticket31532 | 4 src/app/config/confparse.h| 2 +- src/feature/rend/rendclient.c | 2 +-

[tor-commits] [tor/master] config: use ptrdiff_t for all field-offset members.

commit 539158f2be6001a7849b7a85e053e43d7d78195a Author: Nick Mathewson Date: Wed Sep 4 10:50:09 2019 -0400 config: use ptrdiff_t for all field-offset members. Previously we used int here, but it is more correct to use ptrdiff_t. (This never actually matters for our code in

[tor-commits] [tor/master] changes file for 31532

commit 106b75aa5398f7a260a4d0f3093c244376258242 Author: Nick Mathewson Date: Wed Sep 4 11:09:01 2019 -0400 changes file for 31532 --- changes/ticket31532 | 4 1 file changed, 4 insertions(+) diff --git a/changes/ticket31532 b/changes/ticket31532 new file mode 100644 index

[tor-commits] [tor/master] compat_compiler: fix documentation for STRUCT_VAR_P

commit b39ee42904d9210ff3b6872d69535d32f588f907 Author: Nick Mathewson Date: Wed Sep 4 10:56:57 2019 -0400 compat_compiler: fix documentation for STRUCT_VAR_P Previously we had said that off_t was a reasonable type to hold the result of offsetof(). That isn't so: ptrdiff_t is

[tor-commits] [tor/master] rendclient: use ptrdiff, not off_t, for offset of DH field.

commit ec724fe8c8baf245a4cada85bb8b8b4832f6e725 Author: Nick Mathewson Date: Wed Sep 4 10:59:18 2019 -0400 rendclient: use ptrdiff, not off_t, for offset of DH field. The off_t type is only useful for offsets on the filesystem. For in-memory offsets, use ptrdiff_t. ---

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1292'

commit c29f05b159ae51472cd2a183a36cb9d352c082e5 Merge: cdd7e8897 870874fec Author: George Kadianakis Date: Thu Sep 5 17:06:58 2019 +0300 Merge branch 'tor-github/pr/1292' changes/ticket31529| 5 + src/app/config/confparse.c | 11 --- 2 files changed, 13

[tor-commits] [tor/master] config: Make CLEAR with a nonempty value into a nonfatal assertion.

commit 870874fec8cadf3a3e91f63cd7f25757b1ec8b8a Author: Nick Mathewson Date: Wed Sep 4 11:28:21 2019 -0400 config: Make CLEAR with a nonempty value into a nonfatal assertion. When we parse a CLEAR line (e.g., "/OrPort" or /OrPort blah blah"), we always suppress the value, even

[tor-commits] [tor/master] Check IPv6 exit policies on microdescriptors in node_exit_policy_rejects_all()

commit be4a60945d724ca964d9d53f57cad6190a500077 Author: Neel Chauhan Date: Sun Aug 25 20:22:57 2019 -0400 Check IPv6 exit policies on microdescriptors in node_exit_policy_rejects_all() --- changes/bug27284 | 5 + src/feature/dirparse/microdesc_parse.c | 11

[tor-commits] [tor/master] Add tests for IPv6 exit policies on microdescriptors

commit 0127888b0623696d654125b4fa69200485e65a7f Author: Neel Chauhan Date: Sun Aug 25 22:32:07 2019 -0400 Add tests for IPv6 exit policies on microdescriptors --- src/test/test_microdesc.c | 52 ++- 1 file changed, 51 insertions(+), 1

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1261'

commit cdd7e889703fbc089780f446715b7b41ccbf688e Merge: 2591440fa 0127888b0 Author: George Kadianakis Date: Thu Sep 5 17:02:53 2019 +0300 Merge branch 'tor-github/pr/1261' changes/bug27284 | 5 src/feature/dirparse/microdesc_parse.c | 11 +++

[tor-commits] [tor/master] test_confparse: verify that clearing a routerset sets it to NULL.

commit 1ef084c5fcc5f9185f05a71e7ca09fd88cfb641c Author: Nick Mathewson Date: Wed Aug 28 12:28:17 2019 -0400 test_confparse: verify that clearing a routerset sets it to NULL. --- src/test/test_confparse.c | 4 1 file changed, 4 insertions(+) diff --git a/src/test/test_confparse.c

[tor-commits] [tor/master] Routerset config parsing: represent empty sets as NULL.

commit 2074fed6642713bcdfdc76f379956e97663ab8d0 Author: Nick Mathewson Date: Wed Aug 28 11:51:16 2019 -0400 Routerset config parsing: represent empty sets as NULL. routerset_t has two representations of an empty routerset: NULL, and a set containing no elements. But some of

[tor-commits] [tor/master] Document configuration type definition functions for routerset_t

commit f0c1f96adcc049c49f7784645a5b197c8b3e44af Author: Nick Mathewson Date: Wed Aug 28 12:23:36 2019 -0400 Document configuration type definition functions for routerset_t These functions are all used to implement the ROUTERSET_type_defn object, which maps strings to and from

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1269'

commit 7fa624537cded3859a6f8408f9613bc53b6a1875 Merge: a617001fd 1ef084c5f Author: George Kadianakis Date: Tue Sep 3 17:11:25 2019 +0300 Merge branch 'tor-github/pr/1269' src/feature/nodelist/routerset.c | 47 ++-- src/test/test_confparse.c| 4

[tor-commits] [tor/release-0.4.0] Fix gcc build exclude on travis

commit 190386f1c44462fbef568ca9e3c1c997dbebcf12 Author: Sebastian Hahn Date: Tue Aug 20 05:03:58 2019 +0200 Fix gcc build exclude on travis The main build doesn't use HARDENING_OPTIONS, so the exclude shouldn't, either. Reduces the number of builders by one. --- .travis.yml

[tor-commits] [tor/release-0.4.0] Merge branch 'maint-0.3.5' into maint-0.4.0

commit 357e9a6f2c88b99e85e65c0401c524adbe921665 Merge: 90f4ed233 190386f1c Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.3.5' into maint-0.4.0 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/maint-0.4.1] Merge branch 'maint-0.3.5' into maint-0.4.0

commit 357e9a6f2c88b99e85e65c0401c524adbe921665 Merge: 90f4ed233 190386f1c Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.3.5' into maint-0.4.0 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/release-0.3.5] Fix gcc build exclude on travis

commit 190386f1c44462fbef568ca9e3c1c997dbebcf12 Author: Sebastian Hahn Date: Tue Aug 20 05:03:58 2019 +0200 Fix gcc build exclude on travis The main build doesn't use HARDENING_OPTIONS, so the exclude shouldn't, either. Reduces the number of builders by one. --- .travis.yml

[tor-commits] [tor/release-0.4.0] Merge branch 'maint-0.4.0' into release-0.4.0

commit d05db86010bc54d5c6dba525ded3028b5839ceb2 Merge: 2ecd36f3c 357e9a6f2 Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.4.0' into release-0.4.0 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/release-0.4.1] Merge branch 'maint-0.4.0' into maint-0.4.1

commit 5a73f369dbd4d19ced536f4862b12ef98d6a2002 Merge: 7c92f4faa 357e9a6f2 Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.4.0' into maint-0.4.1 ___ tor-commits mailing list

[tor-commits] [tor/release-0.4.1] Merge branch 'maint-0.3.5' into maint-0.4.0

commit 357e9a6f2c88b99e85e65c0401c524adbe921665 Merge: 90f4ed233 190386f1c Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.3.5' into maint-0.4.0 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/release-0.4.1] Merge branch 'maint-0.4.1' into release-0.4.1

commit 561134610f76420ac0f5bebbfc2c2dc65b7e89f3 Merge: ef2ba568d 5a73f369d Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.4.1' into release-0.4.1 ___ tor-commits mailing list tor-commits@lists.torproject.org

[tor-commits] [tor/maint-0.4.1] Merge branch 'maint-0.4.0' into maint-0.4.1

commit 5a73f369dbd4d19ced536f4862b12ef98d6a2002 Merge: 7c92f4faa 357e9a6f2 Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.4.0' into maint-0.4.1 ___ tor-commits mailing list tor-commits@lists.torproject.org

[tor-commits] [tor/release-0.3.5] Merge branch 'maint-0.3.5' into release-0.3.5

commit 7a53e3552cb8fef7dfd0ed2670991fca72a2d4ba Merge: 3a088d43f 190386f1c Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.3.5' into release-0.3.5 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/maint-0.4.0] Fix gcc build exclude on travis

commit 190386f1c44462fbef568ca9e3c1c997dbebcf12 Author: Sebastian Hahn Date: Tue Aug 20 05:03:58 2019 +0200 Fix gcc build exclude on travis The main build doesn't use HARDENING_OPTIONS, so the exclude shouldn't, either. Reduces the number of builders by one. --- .travis.yml

[tor-commits] [tor/maint-0.4.0] Merge branch 'maint-0.3.5' into maint-0.4.0

commit 357e9a6f2c88b99e85e65c0401c524adbe921665 Merge: 90f4ed233 190386f1c Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.3.5' into maint-0.4.0 .travis.yml | 2 +- changes/bug31463 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[tor-commits] [tor/maint-0.3.5] Fix gcc build exclude on travis

commit 190386f1c44462fbef568ca9e3c1c997dbebcf12 Author: Sebastian Hahn Date: Tue Aug 20 05:03:58 2019 +0200 Fix gcc build exclude on travis The main build doesn't use HARDENING_OPTIONS, so the exclude shouldn't, either. Reduces the number of builders by one. --- .travis.yml

[tor-commits] [tor/master] Merge branch 'maint-0.4.0' into maint-0.4.1

commit 5a73f369dbd4d19ced536f4862b12ef98d6a2002 Merge: 7c92f4faa 357e9a6f2 Author: George Kadianakis Date: Tue Aug 27 11:49:36 2019 +0300 Merge branch 'maint-0.4.0' into maint-0.4.1 ___ tor-commits mailing list

<    3   4   5   6   7   8   9   10   11   12   >