RE: template changes to add filler methods

2011-06-22 Thread Thomas Fox
Thomas Vandahl wrote: > On 21.06.11 22:45, Thomas Fox wrote: > > But as I said, the methods can be turned off via a generation option, and > > the default is that the methods are generated. If you are more happy with > > the default that the methods are not generated, I can easily change it. > >

Re: template changes to add filler methods

2011-06-21 Thread Thomas Vandahl
On 21.06.11 22:45, Thomas Fox wrote: > But as I said, the methods can be turned off via a generation option, and > the default is that the methods are generated. If you are more happy with > the default that the methods are not generated, I can easily change it. I have no problem with the approach

Re: template changes to add filler methods

2011-06-21 Thread Graham Leggett
On 21 Jun 2011, at 11:15 PM, Thomas Fox wrote: These two approaches also have problems - they also bloat a class API which is already big - If one table has several foreign keys, user could want some relations to be filled and some not. This can not be achieved with the above approach. Thi

RE: template changes to add filler methods

2011-06-21 Thread Thomas Fox
> Hmm, I wonder if this could be tucked into the "doSelect" > methods as an extra flag parameter. E.g., if you do > something like: > > boolean fillRelated = true; > AuthorPeer.doSelect(criteria, true); > > Then a variation of your fill method gets called to > efficiently return fully populated o

Re: template changes to add filler methods

2011-06-21 Thread Graham Leggett
On 19 Jun 2011, at 1:57 PM, Thomas Fox wrote: I have locally implemented filler methods for associated objects and would like to commit the changes. The filler methods efficiently read related objects. E.g. for the author and book tables in the tutorial, the generated methods are AuthorPeer

Re: template changes to add filler methods

2011-06-21 Thread Thomas Fox
>> Any objections or comments to the above ? If not, I'll commit the changes >> in a few days. >If I understand the concept correctly, this is one more method to deal >with related entities. Each of them may have its advantages and >disadvantages, however I'm afraid it gets a bit crowded in the P

RE: template changes to add filler methods

2011-06-21 Thread Greg Monroe
ed of just going with the fillXXX method if the JavaDocs made it very clear about what it was. Greg -Original Message- From: Thomas Fox [mailto:thomas@seitenbau.net] Sent: Sunday, June 19, 2011 7:57 AM To: Apache Torque Developers List Subject: template changes to add filler methods I

Re: template changes to add filler methods

2011-06-21 Thread Noctarius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Thomas, I guess this could be achieved by using managers, won't it? Bye, Chris Am 21.06.2011 19:30, schrieb Thomas Vandahl: > On 19.06.11 13:57, Thomas Fox wrote: >> Any objections or comments to the above ? If not, I'll commit the changes >> in

Re: template changes to add filler methods

2011-06-21 Thread Thomas Vandahl
On 19.06.11 13:57, Thomas Fox wrote: > Any objections or comments to the above ? If not, I'll commit the changes > in a few days. If I understand the concept correctly, this is one more method to deal with related entities. Each of them may have its advantages and disadvantages, however I'm afraid

template changes to add filler methods

2011-06-19 Thread Thomas Fox
I have locally implemented filler methods for associated objects and would like to commit the changes. The filler methods efficiently read related objects. E.g. for the author and book tables in the tutorial, the generated methods are AuthorPeer.fillBook(Collection) and BookPeer.fillAuthors (Colle