Nightly build crash on SVN Log with log cache enabled

2023-05-21 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, I'm experiencing crashes in the TortoiseSVN, Show log command (tortoiseproc.exe /command:log ...) with the latest nightly builds. If I disable the log cache the crashes go away. Other commands, for example Update, works fine so I don't think it is related to the OpenSSL or Serf changes

Re: Automated retrieval of SVN comments for documentation purpose

2023-05-23 Thread Daniel Sahlberg via TortoiseSVN-dev
tisdag 23 maj 2023 kl. 09:43:46 UTC+2 skrev socrat...@gmail.com: Hello Daniel, Thank you for the details you gave. I really appreciate them. Another couple.of questions: 1. If ever we use command lines to.instruct SVN to retrieve comments for a specified date, how do we produce the code and

Re: Nightly build crash on SVN Log with log cache enabled

2023-06-10 Thread Daniel Sahlberg via TortoiseSVN-dev
torsdag 8 juni 2023 kl. 19:23:42 UTC+2 skrev Stefan: I had that situation too, then I added the logic that caused the crashes. But now I can't get it to show the duplicate entries anymore! I deleted my old cache. And showing logs for different repos just don't get me to where duplicate entries

Re: Updated dependencies for TortoiseSVN

2023-05-31 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 31 maj 2023 kl. 22:05:23 UTC+2 skrev Evgeny Kotkov: Daniel Sahlberg writes: > Evgeny, > > Since r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be > using the 1.3.x branch. Builds seems fine, I've been using them for a > few days. Serf 1.3.10 with support for

Re: Enable asm for OpenSSL

2023-05-31 Thread Daniel Sahlberg via TortoiseSVN-dev
måndag 29 maj 2023 kl. 16:39:28 UTC+2 skrev Denis Kovalchuk: Hi! I am wondering if there are any reasons to build OpenSSL with the '-no-asm' [1][2] option? Below are the results of synthetic benchmarks for Subversion, depending on whether OpenSSL is built with or without asm support: 1)

Re: Nightly build crash on SVN Log with log cache enabled

2023-05-27 Thread Daniel Sahlberg via TortoiseSVN-dev
lördag 27 maj 2023 kl. 07:38:48 UTC+2 skrev Stefan: and I still don't see the crash on my machine. Tried showing log for several working copies, single files in them. Even showed the log for urls instead of local paths. I don't get any crashes or error messages about illegal repo urls. Also

Re: build.txt

2023-06-03 Thread Daniel Sahlberg via TortoiseSVN-dev
Thanks. r29576. I also added instructions for building the ARM 64 version in Win64. I'd love to test building natively on ARM but I don't have such a machine... -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group

build.txt

2023-06-03 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, Since Visual Studio 2022 doesn't install on 32-bit operating systems[1], we could simplify build.txt by removing the section "build64cross Building 64 bit packages on win32 (cross-compile)". Is this ok or am I missing something? Kind regards, Daniel Sahlberg [1]

Re: Enable asm for OpenSSL

2023-06-03 Thread Daniel Sahlberg via TortoiseSVN-dev
I can ask Ian to install nasm on the build machine, but I have no idea how long that will take. Could you maybe add a nant target that enables the asm build and still use no-asm if the nant target was not called? That way the nightly builds would still run through with no-asm. And users who

Re: build.txt

2023-06-03 Thread Daniel Sahlberg via TortoiseSVN-dev
I did a followup in r29578 to update the 'cross' option to only support ARM64. I hope I got it right. I suppose it would be possible to crosscompile for x86/x64 on ARM-VS, but I have no way of testing. -- You received this message because you are subscribed to the Google Groups

Re: Enable asm for OpenSSL

2023-06-03 Thread Daniel Sahlberg via TortoiseSVN-dev
lördag 3 juni 2023 kl. 18:48:01 UTC+2 skrev Stefan: good idea, haven't thought of the "schedule" action :) Learnt about it from the best in r29552 ;-) I've tried to come up with something useful in r29579, let's hope I didn't screw up too badly. /Daniel -- You received this message because

Re: osdn.net longterm stability

2023-07-31 Thread Daniel Sahlberg via TortoiseSVN-dev
lördag 29 juli 2023 kl. 07:27:47 UTC+2 skrev Stefan: On Friday, July 28, 2023 at 10:43:06 PM UTC+2 daniel.l...@gmail.com wrote: If there's anything I missed, just shout. Looks good I think. How about updating https://openhub.net/p/tortoisesvn? updated the url yesterday, but the status is

Re: osdn.net longterm stability

2023-07-26 Thread Daniel Sahlberg via TortoiseSVN-dev
The offer from VisualSVN is very generous, however considering the recent development of the EU CRA regulations, see for example [1], and the uncertainty of wether accepting recurring donations from a commercial entity would would make the whole project "commercial" (=> ie, bringing in a

Re: osdn.net longterm stability

2023-07-28 Thread Daniel Sahlberg via TortoiseSVN-dev
If there's anything I missed, just shout. Looks good I think. How about updating https://openhub.net/p/tortoisesvn? I saw that the issue tracker is active. I have mixed feelings about issue trackers, they often tend to be a dump of things which no-one care about enough to fix. Maybe hide

Merge fail and call to GenerateMergeLogMessage()

2023-08-05 Thread Daniel Sahlberg via TortoiseSVN-dev
Prompted by the discussion in the users group [1], I've been investigating why the prompt to merge doesn't appear sometimes. When merging with a specified range, CSVNProgressDlg::CmdMerge() is used while merging without a range (or All revisions) is using CSVNProgressDlg::CmdMergeAll().

Re: Merge fail and call to GenerateMergeLogMessage()

2023-08-07 Thread Daniel Sahlberg via TortoiseSVN-dev
söndag 6 augusti 2023 kl. 18:56:39 UTC+2 skrev Stefan: agreed. Thanks for the suggestions. All done in r29601 and r29602. /Daniel -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails

Re: osdn.net longterm stability

2023-07-28 Thread Daniel Sahlberg via TortoiseSVN-dev
Now even the OSDN Subversion repository seems to be offline (don't know if that was intentional or not). $ svn ls https://svn.osdn.net/svnroot/tortoisesvn/trunk svn: E170013: Unable to connect to a repository at URL 'https://svn.osdn.net/svnroot/tortoisesvn/trunk' svn: E02: Could not find

editorconfig built twice

2023-06-18 Thread Daniel Sahlberg via TortoiseSVN-dev
I'm trying to understand the build system. editorconfig seems to be built twice when building the "binaries" target through different dependencies: * Via TortoiseSVN => editorconfig * Via Subversion => build target in ext\build\default.build. It adds "only" about a second to the builds, but it

Re: Nightly build crash on SVN Log with log cache enabled

2023-06-17 Thread Daniel Sahlberg via TortoiseSVN-dev
måndag 12 juni 2023 kl. 20:24:38 UTC+2 skrev Stefan: On Saturday, June 10, 2023 at 6:27:59 PM UTC+2 daniel.l...@gmail.com wrote: I can reproduce this by: * deleting %appdata%\TortoiseSVN\logcache * doing Show log *and clicking a few different revisions* * Settings, Log Caching, Cached

Re: Automated retrieval of SVN comments for documentation purpose

2023-05-17 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 17 maj 2023 kl. 07:00:07 UTC+2 skrev socrat...@gmail.com: Hello Tortoise Dev Team, We in our team wanted to create a documentation based on the comments that the members of the development team give each time they commit a code change to SVN. Currently, we have set a standard format on

Re: Drop translated documentation

2023-12-03 Thread Daniel Sahlberg via TortoiseSVN-dev
måndag 20 november 2023 kl. 19:23:55 UTC+1 skrev Stefan: On Monday, November 20, 2023 at 10:56:49 AM UTC+1 daniel.l...@gmail.com wrote: Hi, A little over two years ago Stefan sent a message on the user list [1] about usage of the translated documentation. It only got a single response (from

Re: debugging TSVN in Visual Studio 2022

2023-11-15 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 15 november 2023 kl. 16:17:26 UTC+1 skrev Stefan Sperling: I am trying to follow the file notes/Debug-Hints.txt in order to set breakpoints in TortoiseSVN. I am stuck at the following step: - Start VS.NET and load the TortoiseSVN solution file. Set the TortoiseProc project as

Re: debugging TSVN in Visual Studio 2022

2023-11-16 Thread Daniel Sahlberg via TortoiseSVN-dev
torsdag 16 november 2023 kl. 14:47:03 UTC+1 skrev Stefan Sperling: On Wed, Nov 15, 2023 at 10:45:46AM -0800, Stefan via TortoiseSVN-dev wrote: > [image: Screenshot 2023-11-15 194517.png] Thank you both, Daniel and Stefan. I see how this works now. TortoiseProc takes an argument which

Re: r29635

2023-11-19 Thread Daniel Sahlberg via TortoiseSVN-dev
söndag 19 november 2023 kl. 20:40:31 UTC+1 skrev Stefan: On Sunday, November 19, 2023 at 8:19:02 PM UTC+1 daniel.l...@gmail.com wrote: Nit, but why the added ) in line 794 of /trunk/src/SVN/SVNStatusListCtrlHelpers.cpp? That's an accident ;) Was afraid it was a test to see if anyone

Re: "Edit Conflicts" for Excel Files

2023-11-19 Thread Daniel Sahlberg via TortoiseSVN-dev
lördag 18 november 2023 kl. 22:13:20 UTC+1 skrev Ömer GÜNDÜZ: Hello again, Thank you very much for your answer, Daniel. After facing challenges in finding an effective conflict resolution method, I have opted to utilize my workspace within the OneDrive folder. This approach allows us to

r29635

2023-11-19 Thread Daniel Sahlberg via TortoiseSVN-dev
Nit, but why the added ) in line 794 of /trunk/src/SVN/SVNStatusListCtrlHelpers.cpp? /Daniel -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Drop translated documentation

2023-11-20 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, A little over two years ago Stefan sent a message on the user list [1] about usage of the translated documentation. It only got a single response (from me). The translation of the documentation is done using a Python2 script with a script that seems obsolete (xml2po, depending on an

Re: SVN::GetRootAndHead

2024-04-28 Thread Daniel Sahlberg via TortoiseSVN-dev
So. That didn't turn out well at all (https://groups.google.com/g/tortoisesvn/c/IJuG6WvHTds). I've successfully reproduced the error. Some quick debugging indicate that svn_client_open_ra_session2() now barf if the user doesn't have read access to the repository root. I've reproduced this

Re: SVN::GetRootAndHead

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sahlberg: Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev < tortois...@googlegroups.com>: would it work if we do both? rev = cachedProperties.GetHeadRevision(uuid, path); if ((rev == NO_REVISION) || (m_err

Re: To not delete the pathfile

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 1 maj 2024 kl. 19:57:34 UTC+2 skrev Stefan: if you set the registry DWORD value HKCU\Software\TortoiseSVN\Debug to 1, then TortoiseProc will show a message box on startup with the command line. While that message box is shown you can make a copy of the pathfile. Clever trick, works

To not delete the pathfile

2024-05-01 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, I'm looking at the bug report that Win11 context menu only processes a subset of the selected items (https://groups.google.com/g/tortoisesvn/c/tXskNbYHCAQ/m/rIbHwMoTAgAJ?utm_medium=email_source=footer). I'm leaning towards a Win11 bug but to prove it I'd like to keep the path file

Re: Nightly builds fail

2024-03-08 Thread Daniel Sahlberg via TortoiseSVN-dev
måndag 4 mars 2024 kl. 18:56:31 UTC+1 skrev Stefan: I think the build machine might have the hiccups. When I check now, the 32-bit build succeeds, but a few language packs fail because* '..\bin\Release\bin\restext.exe' failed to start.* but the restext.exe must be ok because the language packs

SVN::GetRootAndHead

2024-03-09 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, In the users group, a user reported an error when starting View log from the repobrowser using a peg revision if the file had subsequently been deleted, see [1]. I have investigated and it seems SVN::GetRootAndHead is calling GetHeadRevision with a path (which potentially is deleted and

Re: SVN::GetRootAndHead

2024-03-10 Thread Daniel Sahlberg via TortoiseSVN-dev
Thanks! Committed in r29682 lördag 9 mars 2024 kl. 21:11:08 UTC+1 skrev Stefan: > no objections from me. > The revision for the repo root is the same as for the path, but of course > works for non-existing paths as well since the root is never deleted. > > -- You received this message because

Re: Add modern authentication (OAuth 2.0 + OIDC) to TortoiseSVN

2024-03-20 Thread Daniel Sahlberg via TortoiseSVN-dev
>From what I understand, OAuth2 requires both server- and clientside support. So any solution would need to involve both TortoiseSVN and the Subversion project (or VisualSVN). I think it is a great idea but I think some additional development resources would be required to make this happen.

Re: Add modern authentication (OAuth 2.0 + OIDC) to TortoiseSVN

2024-03-29 Thread Daniel Sahlberg via TortoiseSVN-dev
s it using the "svn auth" subcommand (or equivalent). Alternatively add this support in TSVN which would be the ideal UX. Best regards, Thomas Å. On 20 Mar 2024, at 08:28, Daniel Sahlberg via TortoiseSVN-dev < tortois...@googlegroups.com> wrote: >From what I understand

Nightly builds fail

2024-03-03 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, I noticed that the nightly builds have started failing. In the win32 builds the build seems to succeed but the MSI generation fails: [[[ msi: [nant] C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\setup.build setup Buildfile: file:///C:/TSVN/tortoisesvn/src/TortoiseSVNSetup/setup.build Target

Re: Duplicate files copy paste issue after Windows OS upgrade to 11 pro

2024-06-13 Thread Daniel Sahlberg via TortoiseSVN-dev
I've tried it on two different computers and I'm unable to reproduce. Maybe you can give some more details exactly how to reproduce? Kind regars, Daniel torsdag 13 juni 2024 kl. 14:19:21 UTC+2 skrev anikg...@gmail.com: > Hi Team > > Greetings > > Recently our organisation has upgraded windows

pegrev or pegrevision

2024-06-21 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, I'm debugging a case where "Show changes" in TortoiseBlame doesn't work. HEAD is r1880 and it turned out the file had been moved in r1236 and I was trying to look at changes from r585. The command line was: TortoiseProc.exe /command:diff /path:"C:/temp/WC/newfile.txt" /startrev:584

r29665 causing issue with piped diff

2024-07-03 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, As noted in the TortoiseSVN group [1], TortoiseUDiff will quit with an error message "The pipe has been ended" if you try to pipe a diff to the program. The original post uses git but it can be reproduced with any source (for example piping from svn). The root cause seems to be the

Re: r29665 causing issue with piped diff

2024-07-03 Thread Daniel Sahlberg via TortoiseSVN-dev
onsdag 3 juli 2024 kl. 18:56:09 UTC+2 skrev Stefan: On Wednesday, July 3, 2024 at 3:40:54 PM UTC+2 daniel.l...@gmail.com wrote: Maybe a check for GetLastError() == ERROR_BROKEN_PIPE? I can't figure out from the documentation for ReadFile [4] how to detect EOF for a pipe. Yes, that's the

<    1   2