Re: [Toybox] [landley/toybox] More xargs cleanup, with one possible accounting error but not what fixes (b39584e)

2019-10-28 Thread Rob Landley
On 10/28/19 5:34 PM, enh-google wrote: > > // count entries > > for (entries = 0, bytes = -1; entries < toys.optc; entries++) > > bytes += strlen(toys.optargs[entries])+1+sizeof(char *)*!FLAG(s); > > why is this initialized to |bytes = -1|? Because "echo one | xargs -s 9" should succeed

Re: [Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-28 Thread Rob Landley
On 10/28/19 10:07 AM, Jarno Mäkipää wrote: > I can try to help writing tests for lib/ utf-8 stuff, and I am sure > there is lot of things to do there to do for Andrew also. Anyway there > is ton of corner cases. > > I would also like to know if there would be anyway to do automated > testing for

Re: [Toybox] [landley/toybox] Add ln -r (#145)

2019-10-28 Thread Andrew Ilijic
Hi Rob, I did not have a chance to look at this today. I'll let you know as soon as I can. ~Andrew ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

[Toybox] [Patch] ls: Add -w argument

2019-10-28 Thread Andrew Ilijic
~Andrew From dfc237de7b02cb19b41f11ce61bc37d0ca65e67d Mon Sep 17 00:00:00 2001 From: Andrew Ilijic Date: Mon, 28 Oct 2019 22:20:38 -0400 Subject: [PATCH] ls: Add `-w` which sets the column width --- tests/ls.test | 3 +++ toys/posix/ls.c | 13 + 2 files changed, 12 insertions(+),

Re: [Toybox] [PATCH 1/2] ls: Add tests for `-C` and `-x` options

2019-10-28 Thread Andrew Ilijic
Hi Rob, These two patches should work. The code in "...Remove-trailing..." is different from what we discussed. > - if (curcol < 255) printf("%*c", curcol, ' '); > + // Use dtlen and ul to not print spaces when we are at the end > + if (curcol < 255 && ((dtlen - ul - 1) > 0))

Re: [Toybox] [PATCH] xargs: "proper" fix for E2BIG.

2019-10-28 Thread Rob Landley
On 10/28/19 1:12 AM, Rob Landley wrote: > I tried changing the -2048 to -4096 and I still got the kernel saying > "Argument > too long" from my "find /usr -print0 | toybox xargs -0" test (but not on the > first echo call, on the second). that's why I haven't checked that in as a > temporary fix

Re: [Toybox] [PATCH] Pass cflags and hostcc in mkroot.

2019-10-28 Thread Denys Nykula
On Mon, Oct 28, 2019 at 01:37:57AM -0500, Rob Landley wrote: > On 10/27/19 10:08 AM, Denys Nykula wrote: > > Script master is acme.js.org/world, comment at the beginning is example > > how to run. > > This is usually the kind of thing people have a repo for somewhere. :) Comment mentions github.

Re: [Toybox] Android sitrep

2019-10-28 Thread Denys Nykula
On Sun, Oct 27, 2019 at 03:27:46PM -0500, Rob Landley wrote: > On 10/23/19 11:58 AM, Denys Nykula wrote: > > This, yes. "Other implementations replace the symlink with the dir and > > keep unpacking files there". > > Try now? Works! Git related packages build correctly without bsdtar now.

Re: [Toybox] [PATCH] Pass cflags and hostcc in mkroot.

2019-10-28 Thread enh via Toybox
On Sun, Oct 27, 2019 at 11:35 PM Rob Landley wrote: > > On 10/27/19 10:08 AM, Denys Nykula wrote: > > On Sat, Oct 26, 2019 at 07:06:54PM -0500, Rob Landley wrote: > >> On 10/16/19 6:19 PM, Denys Nykula wrote: > >>> Yes, NetBSD package repository appears to be easier to bootstrap on Linux > >>>

Re: [Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-28 Thread Jarno Mäkipää
On Mon, Oct 28, 2019 at 8:14 AM Rob Landley wrote: > > > > On 10/25/19 4:12 PM, Jarno Mäkipää wrote: > > hi > > > > Feel free to ask me if you run into any questions. And also share your > > experiments and results. I have gained some knowledge on utf-8 > > encoding past years. I did

Re: [Toybox] [PATCH] Pass cflags and hostcc in mkroot.

2019-10-28 Thread Rob Landley
On 10/27/19 10:08 AM, Denys Nykula wrote: > On Sat, Oct 26, 2019 at 07:06:54PM -0500, Rob Landley wrote: >> On 10/16/19 6:19 PM, Denys Nykula wrote: >>> Yes, NetBSD package repository appears to be easier to bootstrap on Linux >>> than >>> those of GNU/distros. Package recipes are an independent

Re: [Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-28 Thread Rob Landley
On 10/25/19 4:12 PM, Jarno Mäkipää wrote: > hi > > Feel free to ask me if you run into any questions. And also share your > experiments and results. I have gained some knowledge on utf-8 > encoding past years. I did internationalization support for > microcontroller based system around ~2011 on

Re: [Toybox] [PATCH] xargs: "proper" fix for E2BIG.

2019-10-28 Thread Rob Landley
On 10/24/19 5:19 PM, enh via Toybox wrote: > ping? > > i've tested both this fix and the hacky (but findutils-like) fix on > macOS, and they fix the macOS build issues i'd been seeing. > > i've also tried both fixes with the Android kernel build that was > failing, and both fix that too. > > so

Re: [Toybox] [PATCH] fallocate: remove uClibc workaround to benefit macOS.

2019-10-28 Thread Rob Landley
On 10/23/19 2:54 AM, scsijon wrote: > enh, it's changed to uClib-ng. Found at: https://uclibc-ng.org/ and still > running good. Latest is 1.0.32 (Codename Reissdorf Kölsch) released > 15.10.2019. Last time I looked at that fork I wasn't impressed: