Hello,
Attached is a patch to fix a comparison bug in bc. See
https://github.com/gavinhoward/bc/pull/25 and
https://github.com/gavinhoward/bc/pull/25/commits/ddbecaa0601375b86dffb525973148cdd0dda8f7
Gavin Howard
From 347bd813437538f0d6f5a8719a7b677c3669983c Mon Sep 17 00:00:00 2001
From: Gavin
t; or ">|"...
>
> And yes, "{x}
> $ echo {abc
> {abc
> $ echo {abc {abc
>
> because of course.
>
> I cut and paste these things to a big text file I need to turn into a much,
> much
> longer tests/sh.test. My _code_ may not be getting longer fast, but that file
> is...
>
> Rob
> ___
> Toybox mailing list
> Toybox@lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
I see. I apologize for bothering you.
Gavin Howard
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
Maybe I can help? My experience with bc's parser (and others) might help
with parsing and tokenizing.
Gavin Howard
On Mon, Jul 8, 2019, 23:40 Rob Landley wrote:
> Yes please.
>
> (Sorry, hip deep in https://twitter.com/landley/status/1148345079565864960
> and
> https://twit
$BC_REPO/tests/all.sh 0 0 1 0 $TOYBOX_REPO/generated/unstripped/toybox bc
Because that will be available, I don't see a need to doubly license my bc.
Anyway, in making sure my test suite could be run on the bc in toybox,
I found several bugs. The patch to fix them is also attached, as
0
Landley has created his own version of my test suite; I do not know
what he has done.
Gavin Howard
On Thu, Jun 20, 2019 at 11:42 PM enh wrote:
>
> this breaks the power tests. did you mean to update them to the
> current upstream ones, as in the attached patch? (it's not clear to me
I accidentally put the error check into the wrong if statement...
Gavin Howard
From 487eff77b970cf940893dd49bdcd8e29d0423df6 Mon Sep 17 00:00:00 2001
From: Gavin Howard
Date: Tue, 11 Jun 2019 20:07:43 -0600
Subject: [PATCH] bc: fix previous patch
I put the check into the wrong if. That was my
Hello,
This patch fixes a bug in power in bc; 0 to any negative power should
be an error, but bc returns 0. This bug is my bad.
Gavin Howard
From 4aab9295913d8fcf7f3082d51b97b8b679655379 Mon Sep 17 00:00:00 2001
From: Gavin Howard
Date: Mon, 10 Jun 2019 19:52:37 -0600
Subject: [PATCH] bc: fix
Hello,
Attached is a patch is to fix a bug in bc_num_ulong() where overflow was
not being detected correctly.
Gavin Howard
From ef5bafdc4d5256348c573614bcdf9b3469d0cbf2 Mon Sep 17 00:00:00 2001
From: Gavin Howard
Date: Sat, 16 Mar 2019 14:52:19 -0600
Subject: [PATCH] bc: fix an overflow bug
Because C puts a limit on the size of string literals before it
becomes undefined behavior.
You can rest assured that it is correct; I have tested it well.
Gavin Howard
On Fri, Feb 1, 2019 at 2:27 PM enh via Toybox wrote:
>
> the current bc_lib[] seems like an oddly unreadable/undebuggab
willing to support it directly, as well as
share responsibility. I am good with whatever.
Thank you for your patience to this point.
Gavin Howard
0001-Update-bc-for-1.1-release.tar.xz
Description: application/xz
___
Toybox mailing list
Toybox
, would you want it
before or after the next release?
Gavin Howard
On Fri, Sep 21, 2018 at 5:30 PM Rob Landley wrote:
>
> signal() defaults to SA_RESTART, xsignal() uses sigaction() which does not.
> I'm
> not sure which is correct? (It's currently using signal() and things seem ok
g an entire fast arbitrary precision
> implementation written by other authors (appears to be CM Graff and
> Bao Hexing) which was stripped, renamed and then badly reimplemented.
>
> Please just fix your fix your "implementation" (if one can really call
> it that) and
Hi Sasha,
Thank you for bringing to my attention these potentially serious
issues. I will certainly investigate each of them and make the
appropriate changes. I've included an associate who is familiar
with the origins and development of this `bc' to help me address
each point below, as you make
Hello,
Since it has been a month, I thought I would ping.
Gavin Howard
On Thu, Jul 5, 2018 at 7:59 PM Gavin Howard
wrote:
> Hello,
>
> Attached is a patch for adding my bc to toybox.
>
> Gavin Howard
>
___
Toybox m
Oops. I forgot to put my patch somewhere where I could submit it while on
vacation. You'll get it on next Monday, tests and all.
It's a big patch though. Should I split it up?
Gavin H.
On Sat, Jun 23, 2018, 15:07 Rob Landley wrote:
> And lo, I hath cut a release!
>
> And immediately went "I
Even if off topic, please do post again when you get the context behind
Microsoft's acquisitions going sour. I would love to read it.
Until then, I need to migrate my own stuff to GitLab.
GH
On Tue, Jun 5, 2018 at 1:12 PM, Rob Landley wrote:
> On 06/05/2018 05:34 AM, Reverend Homer wrote:> On
. Do you like having
them? Do you want them gone?
Gavin Howard
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
product; you need a *bulletproof* product.
All of that preparation is made even more essential by the fact that
you seem to want to take it and make a lot of changes, whether or not
you want me maintain it. The more I can satisfy your desires for it
(reduce loc is the bi
I am talked to another person that would like the bc (for a Linux
distro) about making the VM global. He said that yes, he thought it
would be better. Because of that, if you want it, I will do it.
Gavin H.
On Thu, Mar 15, 2018 at 11:50 AM, Gavin Howard <gavin.d.how...@gmail.com> wrote:
&
Oh, I guess another advantage to making the BcVm instance global would
be that I could inline bc_vm_init() and bc_vm_free().
GH
On Thu, Mar 15, 2018 at 10:47 AM, Gavin Howard <gavin.d.how...@gmail.com> wrote:
> Before I answer your questions, I have good news: in the midst of
> fi
03:24 PM, Gavin Howard wrote:
>> I am about to try to implement your changes to bc_exec (and maybe
>> bc_vm_init) in my release script. While doing so, if you would like,
>> it would make sense to try to remove the BcStatus enum and replace it
>> with either #defines (chars, so
choice. What would you like me to do?
Gavin Howard
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
the common infrastructure moved
> to
> lib in a 4th file).
Okay, I do not know how large the sed language is, so I have no idea
how to compare these. I still think bc is bigger, but that is naivete.
> I've had... let's call them "opinions"... about external commands stuck into
Forwarded mail that was accidentally sent privately to Rob.
Gavin Howard
-- Forwarded message --
From: Gavin Howard <gavin.d.how...@gmail.com>
Date: Mon, Mar 12, 2018 at 5:02 PM
Subject: Re: [Toybox] Graff and bc
To: Rob Landley <r...@landley.net>
That is a reall
Also, bc_code is equivalent to "toys.optflags & FLAG_c", not
"toys.optflags & FLAG_i." FLAG_i is for bc_interactive.
GH
On Tue, Mar 13, 2018 at 8:49 AM, Gavin Howard <gavin.d.how...@gmail.com> wrote:
> Rob,
>
> If you inline bc_exec() and bc_vm_
is worth that, not even for you. Please do not do this
change.
The other changes I can make without a problem.
Gavin Howard
On Tue, Mar 13, 2018 at 8:22 AM, Rob Landley <r...@landley.net> wrote:
> On 03/12/2018 08:41 PM, Rob Landley wrote:> They're both intentionally small
to cut releases of
bc for toybox. If you do not work with me, and change it yourself, it would
very difficult for me to maintain it for you.
I look forward to working with you.
Gavin Howard
___
Toybox mailing list
Toybox@lists.landley.net
http
the fixes into my
bc and just merge again.
Gavin Howard
On Mon, Feb 19, 2018 at 12:17 PM, Rob Landley <r...@landley.net> wrote:
> On 02/16/2018 01:32 PM, Gavin Howard wrote:
>> Hello,
>>
>> The bc is coming along nicely. I am at the point where I may be ready
>> to suppo
reduction from 7 kb to around 5.5 kb.
Here is my question: is the reduction in executable size and
(possible) faster startup time worth the complexity of the second
option?
Gavin Howard
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.land
29 matches
Mail list logo
