Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-10 Thread Rob Landley
On 10/9/23 19:53, Oliver Webb wrote: >> I tested this. If I build toybox sed without ASAN the 1 megabyte search and >> replace completes in 0.15 seconds. If I build it with ASAN, it takes 29.35 >> seconds. The gcc address sanitizer is slowing sed down 200 times. > > Huh, now sed passes it's tests

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-09 Thread Oliver Webb via Toybox
--- Original Message --- On Monday, October 9th, 2023 at 17:29, Rob Landley wrote: > I installed a mint vm (xfce flavor) and reproduced your issues. Sent in fixes > for some of them, although your gcc still produces warnings about "unused > return > result" even when I typecast the re

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-09 Thread Rob Landley
I installed a mint vm (xfce flavor) and reproduced your issues. Sent in fixes for some of them, although your gcc still produces warnings about "unused return result" even when I typecast the return to (void). (Still, the commit comment says _why_ each of those return results are not useful to try

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-07 Thread Rob Landley
On 10/7/23 00:35, Oliver Webb wrote: >> Is it the "touch" that fails, or tar? Because the test is doing: > > Putting a ' || echo "whatever" ' after the touch command that creates the > long filenames shows nothing, > these are the logs from the test failure: > > ln: failed to create symbolic li

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-06 Thread Oliver Webb via Toybox
--- Original Message --- On Friday, October 6th, 2023 at 23:01, Rob Landley wrote: > On 10/6/23 16:33, Oliver Webb wrote: > > > > Hadn't seen that one, I'm aware of a sparse file issue on some > > > filesystems. > > > (That hit on microsoft github.) > > > > My home directory is ecryptfs

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-06 Thread Rob Landley
On 10/6/23 16:33, Oliver Webb wrote: >> Hadn't seen that one, I'm aware of a sparse file issue on some filesystems. >> (That hit on microsoft github.) > > My home directory is ecryptfs, Yup, that would explain it. > Testing on my /tmp directory (etx4) makes the errors > go away for both du and t

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-06 Thread Oliver Webb via Toybox
--- Original Message --- On Friday, October 6th, 2023 at 00:33, Rob Landley wrote: > On 10/5/23 22:50, Oliver Webb via Toybox wrote:> I ran "VERBOSE=allnopass make > > tests" to see exactly what was still broken. > > Note that all of them pass for me. I was not aware of this, I would

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-05 Thread Rob Landley
On 10/5/23 22:50, Oliver Webb via Toybox wrote:> I ran "VERBOSE=allnopass make tests" to see exactly what was still broken. Note that all of them pass for me. > (du has some symlink issues, On what filesystem? > tar has a long filename issue, Hadn't seen that one, I'm aware of a sparse file is

[Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-05 Thread Oliver Webb via Toybox
I ran "VERBOSE=allnopass make tests" to see exactly what was still broken. (du has some symlink issues, tar has a long filename issue, sed fails the performance test even though it can process a megabyte of data in less then 20s, and the test passes on "make test_sed", mkpasswd segfaults due