I know it's not toybox specific, but blame it on your fuzz statements in
Vol87 Issue9.
Any chance of a two or three page "Introduction to Creating and
Understanding Patches for Dummies" for those of us who either don't know
how to build one, or like me, have, "but don't really know what i'm do
On 02/21/2017 04:30 PM, Daniel K. Levy wrote:
> On Mon, 2017-02-20 at 22:06 -0600, Rob Landley wrote:
>> I've been sitting on my local changes here for months (haven't found
>> time to finish testing and writing up the rationale for the changes)
>> and it's not fair to you, so I'm deleting my chang
On 02/21/2017 04:30 PM, Daniel K. Levy wrote:
> I'm guessing there's quite a bit of good work sitting in your local
> changes that just needs time for *someone* to look at.
I agree I have a lot of half-finished todo items. :)
I'm not sure what process changes can do about "shortage of time due to
On Mon, 2017-02-20 at 22:06 -0600, Rob Landley wrote:
> I've been sitting on my local changes here for months (haven't found
> time to finish testing and writing up the rationale for the changes)
> and it's not fair to you, so I'm deleting my changes (patch attached
> for posterity, doubt I'll ever
On 02/20/2017 10:06 PM, Rob Landley wrote:
> I've been sitting on my local changes here for months (haven't found
> time to finish testing and writing up the rationale for the changes) and
> it's not fair to you, so I'm deleting my changes (patch attached for
> posterity, doubt I'll ever look at it
On 02/16/2017 09:20 PM, Daniel K. Levy wrote:
> Coming back to this.
Sorry, I suck.
I've been sitting on my local changes here for months (haven't found
time to finish testing and writing up the rationale for the changes) and
it's not fair to you, so I'm deleting my changes (patch attached for
po
Coming back to this.
Split up into multiple commits for easier understanding. The first four
should have no behavioral changes; the last one does.
I'd like to add tests for the patch 5 changes, but I don't see a way to
test for something that's supposed to error.From 35aca7512cc68659cbafa46906eca
Hi Rob & List,
Attached are the patches.
1. *dumpleases.c:* Added IPv6 support and sync with dhcp server.
Added long opt for "-r" and "-a" options.
2. *ip.c:* Couple of bug fixes in different modules of IP.
a. *IP-link:* with multiple sub-options, parsing
Hello,
I've started working through the test suite trying to expand it and fix
where commands are failing. Here's what I've got so far for basename,
blkid, cat, and cp.
The cp test rewrite was done a few months ago, and looking at it now it
seems a bit dense. I was trying to minimize the number
Hi Rob, List,
Few more issues observed. Please find attached the fix patches.
ln.c : with __-f__ with an existing destination unlink was done,
but in case where the requested operation failed, the original
file is not restored.
e.g. ln -f dir/ lnk, where source is dir and dest
On Tue, 14 Oct 2014 00:38:27 -0500 Rob Landley wrote:
> On 10/07/14 00:50, Ashwini Sharma wrote:
> > Hi Rob, List,
> >
> > Attached are few more static analysis fixes. This includes issues
> > like resource leaks, logical dead codes etc...
>
> The reason I didn't do this bit in lib.c:
>
> -
On 10/07/14 00:50, Ashwini Sharma wrote:
> Hi Rob, List,
>
> Attached are few more static analysis fixes. This includes issues like
> resource leaks, logical dead codes etc...
The reason I didn't do this bit in lib.c:
-if (!pidstr) xputs(signames[i].name);
+if (!pidstr) xprintf("%02d) %s
On 10/12/14 22:39, Ashwini Sharma wrote:
> Hi Rob,
>
> --- cp.c.patch:
>
> Why this change?
>
> -if (CFG_CP_MV && toys.which->name[0] == 'm') rc = rename(src,
> TT.destname);
> +if (CFG_CP_MV && toys.which->name[0] == 'm' && (toys.optflags &
> FLAG_f))
> + rc = rename(src, TT.destna
Hi Rob,
--- cp.c.patch:
Why this change?
-if (CFG_CP_MV && toys.which->name[0] == 'm') rc = rename(src,
TT.destname);
+if (CFG_CP_MV && toys.which->name[0] == 'm' && (toys.optflags &
FLAG_f))
+ rc = rename(src, TT.destname);
$ strace mv umount umount.old 2>&1 | grep rename
rename("
On 10/10/14 00:20, David Seikel wrote:
> On Thu, 09 Oct 2014 23:43:25 -0500 Rob Landley wrote:
>
>> --- getty.c.patch:
>>
>> I actually have a pending cleanup to getty I haven't checked in for
>> ages because I haven't got a serial port setup lying around to test.
>> It redoes the speed calculato
On Thu, 09 Oct 2014 23:43:25 -0500 Rob Landley wrote:
> --- getty.c.patch:
>
> I actually have a pending cleanup to getty I haven't checked in for
> ages because I haven't got a serial port setup lying around to test.
> It redoes the speed calculatons to look like:
Er, serial port console on a
On 10/07/14 00:50, Ashwini Sharma wrote:
> Hi Rob, List,
>
> Attached are few more static analysis fixes. This includes issues like
> resource leaks, logical dead codes etc...
>
> chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled.
> Garbage output was there.
>
> comm.c: loop error
Hi Rob, List,
While verifying toybox on one of our products, came across few issues.
Attached are the patches to those.
1. cp.c : For __mv__ with __-f__ and __-i__ user was prompted.
2. date.c: added support for additional date format parsing, a SIGSEGV for
setdate, output in __-u__.
3. d
Hi Rob, List,
Attached are few more static analysis fixes. This includes issues like
resource leaks, logical dead codes etc...
chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled. Garbage
output was there.
comm.c: loop error
id.c: single build issue for OLD_TOYs, same issue is ther
Hi Rob,
Attached are few fixes for issues reported in static analysis. Do have a
look and
share your inputs.
regards,
Ashwini
bootchartd.c.patch
Description: Binary data
cpio.c.patch
Description: Binary data
cut.c.patch
Description: Binary data
find.c.patch
Description: Binary data
fsck
On 08/11/14 23:01, Ashwini Sharma wrote:
> Hi Andre,
>
> I used _prevent_ by Coverity and also a proprietary tool.
>
> regards,
> Ashwini
Durign the time my email machine was dead (turned out to be bad ram) I
applied these fixes. I wrote up notes in a file and forgot to post them.
Static analy
Hi Andre,
I used _prevent_ by Coverity and also a proprietary tool.
regards,
Ashwini
On Tue, Aug 12, 2014 at 1:07 AM, Andre Renaud
wrote:
> Hi Ashwini,
> > Attached are the patches to commands for issues reported from static
> > analysis tool.
>
> Just out of curiosity, which static analysis
compiler I used is gcc version 4.4.3 on ubuntu 64-bit with
linux kernel 2.6.32. This complained of undeclared O_CLOEXEC.
Ashwini
On Mon, Aug 11, 2014 at 6:47 PM, Rob Landley wrote:
> On 08/11/2014 04:27 AM, Ashwini Sharma wrote:
> > Hi Rob, List,
> >
> > Attached are the patches to commands f
Hi Andre
Quoting Andre Renaud :
Hi Ashwini,
Attached are the patches to commands for issues reported from static
analysis tool.
Just out of curiosity, which static analysis tool did you use to find these?
I've done some investigation into these recently, and found them to be
quite nice to in
Hi Ashwini,
> Attached are the patches to commands for issues reported from static
> analysis tool.
Just out of curiosity, which static analysis tool did you use to find these?
I've done some investigation into these recently, and found them to be
quite nice to integrate into the build system, al
On 08/11/2014 04:27 AM, Ashwini Sharma wrote:
> Hi Rob, List,
>
> Attached are the patches to commands for issues reported from static
> analysis tool.
Still reading through that part.
> portability.h.patch - it is for O_CLOEXEC, as compiler complained of it.
Which compiler? It was added to the
Hi Rob, List,
Attached are the patches to commands for issues reported from static
analysis tool.
portability.h.patch - it is for O_CLOEXEC, as compiler complained of it.
Makefile.patch - for cleaning generated/*.o files and libopts.dat file
regards,
Ashwini
arp.c.patch
Description: Binary da
On 06/23/14 10:35, luck...@vp.pl wrote:
> I created own build system for small linux distributions. I had to write
> two patches for your
> toybox-0.4.8. First patch fixes display of the id toy. Second patch
> fixes sigsegv of the which
> toy for the unset PATH variable of environment. These patche
Hi Rob,
Attached are the patches for
fdisk : partitions > 60, are deleted, offset entry for extended partitions
was wrong.
fsck: memory leak/segfault resolved.
ftpget : warning for unused variable 'ptr' removed.
Thanks,
Ashwini
fdisk.c.patch
Description: Binary data
fsck.c.patch
Description:
On 06/23/14 10:35, luck...@vp.pl wrote:
> I created own build system for small linux distributions. I had to write
> two patches for your
> toybox-0.4.8. First patch fixes display of the id toy. Second patch
> fixes sigsegv of the which
> toy for the unset PATH variable of environment. These patche
On 06/24/14 16:20, Isaac Dunham wrote:
> On Tue, Jun 24, 2014 at 04:54:57PM +0200, luck...@vp.pl wrote:
>> W dniu 23.06.2014 23:45, Isaac Dunham pisze:
>>> On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
I created own build system for small linux distributions. I had to
wri
On Tue, Jun 24, 2014 at 04:54:57PM +0200, luck...@vp.pl wrote:
> W dniu 23.06.2014 23:45, Isaac Dunham pisze:
> >On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
> >>I created own build system for small linux distributions. I had to
> >>write two patches for your
> >>toybox-0.4.8. Fir
luck...@vp.pl wrote:
[..]
> getty.c requires sys/ttydefaults.h. Error of my compilation:
>
> toys/pending/getty.c:168:29: error: 'CERASE' undeclared (first use in
> this function)
>
> The CERASE macro and more similar macros just are defined at
> sys/ttydefaults.h in
> musl libc. This header fi
W dniu 23.06.2014 23:45, Isaac Dunham pisze:
On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
I created own build system for small linux distributions. I had to
write two patches for your
toybox-0.4.8. First patch fixes display of the id toy. Second patch
fixes sigsegv of the which
W dniu 24.06.2014 15:20, Rob Landley pisze:
On 06/23/14 16:45, Isaac Dunham wrote:
On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
I created own build system for small linux distributions. I had to
write two patches for your
toybox-0.4.8. First patch fixes display of the id toy.
On 06/23/14 16:45, Isaac Dunham wrote:
> On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
>> I created own build system for small linux distributions. I had to
>> write two patches for your
>> toybox-0.4.8. First patch fixes display of the id toy. Second patch
>> fixes sigsegv of the
On Mon, Jun 23, 2014 at 05:35:55PM +0200, luck...@vp.pl wrote:
> I created own build system for small linux distributions. I had to
> write two patches for your
> toybox-0.4.8. First patch fixes display of the id toy. Second patch
> fixes sigsegv of the which
> toy for the unset PATH variable of en
I created own build system for small linux distributions. I had to write
two patches for your
toybox-0.4.8. First patch fixes display of the id toy. Second patch
fixes sigsegv of the which
toy for the unset PATH variable of environment. These patches:
https://github.com/luckboy/toyroot/blob/mas
38 matches
Mail list logo
