Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-25 Thread Luca Ferretti
Il giorno gio, 24/01/2008 alle 21.52 +0800, Halton Huo ha scritto: >On Wed, 2008-01-23 at 11:44 +0100, Luca Ferretti wrote: >> Halton, ideally, shouldn't Apply and OK buttons grayed out if there >> are no changes to confirm? > > Check with Desktop property dialog on Windows, seems only Apply gray

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-22 Thread Halton Huo
On Tue, 2008-01-22 at 23:04 -0500, Jamie McCracken wrote: > everything looks ok but can you *NOT* reindex on following: > > 1) chkSkipMountPoints > 2) WatchDirectoryRoots > 3) CrawlDirectoryRoots > 4) NoWatchDirectoryRoots (we already handle this at startup in > trackerd.c) > 5) NoIndexFileType

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-22 Thread Jamie McCracken
On Tue, 2008-01-22 at 20:34 +0800, Halton Huo wrote: > Jamie and All, > > The patch for explicit apply is ready for review. > > Summary: > [1] Functions throttle_changed_cb() spin_value_changed_cb() and > check_toggled_cb() are removed since they are for instant apply. And the > also the signal

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-22 Thread Halton Huo
Jamie and All, The patch for explicit apply is ready for review. Summary: [1] Functions throttle_changed_cb() spin_value_changed_cb() and check_toggled_cb() are removed since they are for instant apply. And the also the signal connect calls are removed. [2] Rename action button "Close" to "Apply

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Jamie McCracken
On Mon, 2008-01-21 at 15:15 +0100, Mathieu Dimanche wrote: > Michael Biebl a écrit : > > 2008/1/21, Halton Huo <[EMAIL PROTECTED]>: > > > >> On Fri, 2008-01-18 at 10:48 +0800, Halton Huo wrote: > >> > [2]. tracker-preferences will send out the key changes D-BUS message > when use

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Halton Huo
Michal, On Mon, 2008-01-21 at 15:15 +0100, Mathieu Dimanche wrote: > I'm not really sure the preferences dialog follows the instant-apply > scheme. > > As seen in the Gnome HIG v2.0 [1], my guess is this particuliar > dialog > should be an "explicit apply window" : > [...] > If most of the contro

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Mathieu Dimanche
Michael Biebl a écrit : > 2008/1/21, Halton Huo <[EMAIL PROTECTED]>: > >> On Fri, 2008-01-18 at 10:48 +0800, Halton Huo wrote: >> [2]. tracker-preferences will send out the key changes D-BUS message when user click the widget, that will cause trackerd get the change

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Halton Huo
Michal, Thanks for your time :) On Mon, 2008-01-21 at 14:44 +0100, Michael Biebl wrote: > > The problem is, that this doesn't follow GNOME's instant-apply idea. Yes, it is true. For the time being, when a bool/int key is changed, the D-Bus message will be sent out directly, but the configuratio

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Michael Biebl
2008/1/21, Halton Huo <[EMAIL PROTECTED]>: > On Fri, 2008-01-18 at 10:48 +0800, Halton Huo wrote: > > > [2]. tracker-preferences will send out the key changes D-BUS message > > > when user click the widget, that will cause trackerd get the change > > and > > > take effect directly. I'd like to chan

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-21 Thread Halton Huo
On Fri, 2008-01-18 at 10:48 +0800, Halton Huo wrote: > > [2]. tracker-preferences will send out the key changes D-BUS message > > when user click the widget, that will cause trackerd get the change > and > > take effect directly. I'd like to change t-p to send out the changes > > only after use cli

Re: [Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-17 Thread Halton Huo
woops, forget attach patch last time. On Fri, 2008-01-18 at 10:37 +0800, Halton Huo wrote: > Hi Jamie and All, > > I spent several days to find a good way to fix bug > http://bugzilla.gnome.org/show_bug.cgi?id=503376. Since this patch is > big, so I'd like to ask you to review first before I commi

[Tracker] [patch] bug 503376 - Cannot disable evolution "Enable Evolution email Indexing" in "Emails" tab

2008-01-17 Thread Halton Huo
Hi Jamie and All, I spent several days to find a good way to fix bug http://bugzilla.gnome.org/show_bug.cgi?id=503376. Since this patch is big, so I'd like to ask you to review first before I commit. My aim is to find a better way to let trackerd update indexing without restart/reindex trackerd w