[tryton-dev] My review commitment

2017-03-29 Thread Cédric Krier
Hi, I have found that more and more reviews need way too much work for me to process. This is mainly because I have to review them more than 10 times, I have to repeat many times the same comments. But also because it seems for others having a quick solution is more important than having the right

Re: [tryton-dev] Removal of Property

2017-03-29 Thread Sergi Almacellas Abellana
El 29/03/17 a les 00:12, Cédric Krier ha escrit: Hi, The patches that removes the Property fields is ready for testing. It is passing all the tests. https://bugs.tryton.org/issue2349 First of all: Thanks for the big work :) I would like to commit it ASAP to get enough time to find all bugs

Re: [tryton-dev] Removal of Property

2017-03-29 Thread Cédric Krier
On 2017-03-29 16:13, Sergi Almacellas Abellana wrote: > El 29/03/17 a les 00:12, Cédric Krier ha escrit: > > I would like to commit it ASAP to get enough time to find all bugs > > before the release. > > Indeed bugs can be found before commiting. It's a mather of appling all of > the reviews. I ha

[tryton-dev] reconciliation in GeneralLedgerLine

2017-03-29 Thread Richard PALO
I prototyped adding display of line.reconciliation.name in General Ledger reports iff the reconciliation date is '<=' to the end_date of the end_period (if specified) or of the fiscal year. This seems to work nicely in the generated report, but for 'correctness' I'd like to filter the column alre