Re: [Java SDO CTS] thoughts on structure

2007-05-02 Thread Brian Murray
I have opened Tuscany-1241 to provide the changes my team has made to the CTS. As is mentioned in the Jira, the patch is not entirely complete in and of itself and further may not reflect some of the changes that have gone in recently. However, I'm aware that changes are being made to the CTS an

Re: [Java SDO CTS] thoughts on structure

2007-05-02 Thread Frank Budinsky
I added a few comments in-line. Thanks, Frank. "kelvin goodson" <[EMAIL PROTECTED]> wrote on 05/02/2007 06:38:28 AM: > I'm inclined to agree that a blanket approach to this kind of testing is not > best. The more directed the tests are the better we can understand how > comprehensive the CTS

Re: [Java SDO CTS] thoughts on structure

2007-05-02 Thread kelvin goodson
I'm inclined to agree that a blanket approach to this kind of testing is not best. The more directed the tests are the better we can understand how comprehensive the CTS is. However, it's not clear to me whether we can now confirm the types are as they should be through the metadata API alone, o

Re: [Java SDO CTS] thoughts on structure

2007-05-01 Thread Frank Budinsky
I think this approach sounds a little too brute force. Regardless of how the metadata is defined, once instances are created in memory, they will be exactly the same. Verifying this by repeating every possible test on the exact same DataObjects, just created differently, sounds a little ineffic

Re: [Java SDO CTS] thoughts on structure

2007-05-01 Thread Robbie Minshall
I agree that the tests should be structured in a way that is spec and functionaly orientated. I have never really liked the split between paramatized and non paramatized tests so getting rid of this is just fine. Other than that I think that the test cases are more or less organized by API thoug

[Java SDO CTS] thoughts on structure

2007-05-01 Thread kelvin goodson
Having spent some time getting to grips with the CTS there are some things I think I'd like to improve. First amongst them is to get some structure that allows us to get a feel for how well the spec is covered by the tests. One thing that concerns me is that one of the most apparent things in th