Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Tobias Oberstein
but we have had enough difficulty keeping our CI configuration current based on what cloud provider is falling over this month ;-). Yes, CI seems to be universally one of those things that is conceptually simple but somehow takes hours and hours to maintain. Absolutely agreed, glad that it's

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Tobias Oberstein
on their end.  If initially, say, crossbar and matrix would like to work with us to set up some kind of repeatable pattern we can suggest to others, that would be great. ok, I'll take that to the team: https://github.com/crossbario/crossbar/issues/1867 tldr: we could run our CI in 2 sets, one

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Richard van der Hoff
On 03/03/2021 18:47, Glyph wrote: I'll take this to the Synapse team to discuss further, but we could probably easily arrange for one of our CI runs to install Twisted trunk from git instead of pypi, which might be a good start. This is specifically the approach I'd really rather /not/ take

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 3, 2021, at 4:58 AM, Jean-Paul Calderone > wrote: > > Broadly, I agree. But not with this part. It seems like there is clearly a > trade-off that is better for everyone. The trade-off represented by #1298: > Breaks application code without providing any new functionality or fixing

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 3, 2021, at 8:25 AM, Richard van der Hoff wrote: > > > On 03/03/2021 08:07, Glyph wrote: >> >> If dependencies could start testing against Twisted trunk in some capacity, >> we could get notified close to when unintentionally breaking changes occur, >> and dependencies can let us k

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Richard van der Hoff
On 03/03/2021 08:07, Glyph wrote: If dependencies could start testing against Twisted trunk in some capacity, we could get notified close to when unintentionally breaking changes occur, and dependencies can let us know well before the release happens, and we can either revert or they can fix

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Jean-Paul Calderone
On Wed, Mar 3, 2021 at 3:08 AM Glyph wrote: > > On Mar 2, 2021, at 6:10 PM, Jean-Paul Calderone > wrote: > > Policy aside, this change doesn't seem like much of an improvement to me. > If I were to guess, I would guess the change was made to satisfy some check > Mypy is now being asked to make a

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 2, 2021, at 6:10 PM, Jean-Paul Calderone > wrote: > > Policy aside, this change doesn't seem like much of an improvement to me. If > I were to guess, I would guess the change was made to satisfy some check Mypy > is now being asked to make about Twisted. If that's the case, it seem

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-02 Thread Tobias Oberstein
Hi Jean-Paul, It seems like this change does not actually violate Twisted's compatibility policy.  This is not to say introducing such regressions is desirable, but when constructing such work-arounds it might be worth paying closer-than-average attention to what the policy actually is. The

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-02 Thread Tobias Oberstein
Hi Craig, thanks for your answer, tips and questions! much appreciated Am 03.03.21 um 02:58 schrieb Craig Rodrigues: On Tue, Mar 2, 2021 at 12:12 PM Tobias Oberstein mailto:tobias.oberst...@gmail.com>> wrote: this fix broke our workaround for the bug now fixed;) I had to read that se

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-02 Thread Jean-Paul Calderone
On Tue, Mar 2, 2021 at 3:09 PM Tobias Oberstein wrote: > Hi all, > > rgd Twisted v21.2.0, thanks a lot to all involved in this release! the > release, mypy, more py3, .. +1! really appreciated. > > now, fwiw, just wanted to let you know (sorry, too late) about a > regression with > > https://gith

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-02 Thread Craig Rodrigues
On Tue, Mar 2, 2021 at 12:12 PM Tobias Oberstein wrote: > > this fix broke our workaround for the bug now fixed;) > > I had to read that sentence a few times before I fully understood it, and my mind did a backflip. :) Is there a quick and dirty way to run Crossbar's CI against a pre-release ver

[Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-02 Thread Tobias Oberstein
Hi all, rgd Twisted v21.2.0, thanks a lot to all involved in this release! the release, mypy, more py3, .. +1! really appreciated. now, fwiw, just wanted to let you know (sorry, too late) about a regression with https://github.com/crossbario/crossbar that actually originates from https://