Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-22 Thread Arno Garrels
Arno Garrels wrote: > Fastream Technologies wrote: >> Hello, >> >> But the Abort() routine is not working currently since when the >> exception is thrown and not excepted/catched it quits the function! > > More in depth changes than just eating the exception are being > investigated, will take a

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-21 Thread Arno Garrels
Fastream Technologies wrote: > Hello, > > But the Abort() routine is not working currently since when the > exception is thrown and not excepted/catched it quits the function! More in depth changes than just eating the exception are being investigated, will take a while. Anyway thanks for the re

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-21 Thread Fastream Technologies
Also when it is a base class that is problematic (and so base as tcustomwsocket!) inheritence does not help to fix the issue! Maybe there can be another conditional? Regards, SubZero On Mon, Mar 21, 2011 at 2:04 PM, Anton S. wrote: > IMHO such operations as Abort should be as much quiet as possi

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-21 Thread Anton S.
IMHO such operations as Abort should be as much quiet as possible. Nobody cares the results, they just must work. -- Anton -- To unsubscribe or change your settings for TWSocket mailing list please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket Visit our website at http://www.ove

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-20 Thread Fastream Technologies
Hello, But the Abort() routine is not working currently since when the exception is thrown and not excepted/catched it quits the function! And this call is in InternalAbort() so it could be called by other component code as well (not just applications' direct call to Abort() )! And why would anybo

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-20 Thread Arno Garrels
Hi, I'm not sure if it is a good idea to ignore an Exception in CancelDnsLookup without some precaution. What happens i.e. if the error code was 10037 "Operation already in progress"? -- Arno Garrels Fastream Technologies wrote: > This is how it is called from httpprot.pas: > > if bFlag th

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-20 Thread Fastream Technologies
This is how it is called from httpprot.pas: if bFlag then try FCtrlSocket.CancelDnsLookup; except { Ignore any exception } end; which also confirms the fix. Regards, SZ On Sun, Mar 20, 2011 at 4:08 PM, Fastream Technologies wr

Re: [twsocket] I think I found an important bug in wsocket.pas

2011-03-20 Thread Fastream Technologies
My fix seems to work on our web proxy server! If nobody has any objection, Arno or Francois could you apply this to SVN? Best Regards, SubZero On Sun, Mar 20, 2011 at 3:15 PM, Fastream Technologies wrote: > Hello, > > procedure TCustomWSocket.InternalAbort(ErrCode : Word); > begin > CancelD

[twsocket] I think I found an important bug in wsocket.pas

2011-03-20 Thread Fastream Technologies
Hello, procedure TCustomWSocket.InternalAbort(ErrCode : Word); begin CancelDnsLookup; // ==> may raise exception due to Winsock error 11002! DeleteBufferedData; { Be sure to close as fast as possible (abortive close) } if (State = wsConnected) and (FProto = IPPROTO_TCP) then begin