Re: [U-Boot] [PATCH v4 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver

2012-04-29 Thread Lukasz Majewski
Hi Marek, > Dear Lukasz Majewski, > > > This commit adds support for storing private data to Samsung's UDC > > driver. This data is afterward used by usb gadget. > > > > Signed-off-by: Lukasz Majewski > > Signed-off-by: Kyungmin Park > > Cc: Marek Vasut > > --- > > drivers/usb/gadget/s3c_udc

Re: [U-Boot] [PATCH v2 2/3] LCD: add compressed 32bpp BMP image data

2012-04-29 Thread Donghwa Lee
Dear Wolfgang Denk, Mr.Kang and I think TIZEN logo is not a board/vendor specific although samsung will release it. So, Mr.kang had proposed new directory include/video or include/video/logo/. How do you think about that? When you receive this e-mail, please replay with your opinions. Thank yo

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-29 Thread Simon Glass
Hi, On Sun, Apr 29, 2012 at 7:25 PM, Marek Vasut wrote: > Dear Anatolij Gustschin, > > > Data cache flushing is required for frame buffer in RAM to fix the > > distorted console text output. Currently this text distortion is > > observed with cfb on beageboard and N900 when running with data > >

Re: [U-Boot] [PATCH 0/2] Replace yaffs2 with new version

2012-04-29 Thread Wolfgang Denk
Dear Charles Manning, In message <1335739336-2942-1-git-send-email-cdhmann...@gmail.com> you wrote: > This patch set replaces fs/yaffs2 with a new version. > > This new version is faster and also adds the ability to dynamically > add yaffs2 mount points which makes configuration far simpler. So

[U-Boot] [PATCH 0/2] Replace yaffs2 with new version

2012-04-29 Thread Charles Manning
This patch set replaces fs/yaffs2 with a new version. This new version is faster and also adds the ability to dynamically add yaffs2 mount points which makes configuration far simpler. -- Charles ___ U-Boot mailing list U-Boot@lists.denx.de http://list

Re: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings

2012-04-29 Thread Marek Vasut
Dear Eric Nelson, > Signed-off-by: Eric Nelson > > --- > V2 has been stripped of the board-independent changes and > uses clrsetbits_le32() instead of twiddling bits by hand. > > V3 returns immediately from setup_sata() if enable_sata_clock() > returns an error. > > board/freescale/mx6qsabrel

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-29 Thread Marek Vasut
Dear Anatolij Gustschin, > Data cache flushing is required for frame buffer in RAM to fix the > distorted console text output. Currently this text distortion is > observed with cfb on beageboard and N900 when running with data > cache enabled. beagleboard ;-) > > Reported-by: Pali Rohár > Sign

Re: [U-Boot] [PATCH 2/5] x86: Forward declate gd_t

2012-04-29 Thread Marek Vasut
Dear Graeme Russ, > So it can be used as a type in struct global_data and remove an ugly > typecast > > Signed-off-by: Graeme Russ > --- > arch/x86/cpu/cpu.c |2 +- > arch/x86/include/asm/global_data.h |4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff

Re: [U-Boot] [PATCH 2/2 v5] Add support for MINI2440 (s3c2440).

2012-04-29 Thread Marek Vasut
Dear Gabriel Huau, > --- > Changes for v2: > - Coding style cleanup > - Remove unnecessary files modification > - Remove unnecessary board configuration set > > Changes for v3: > - Coding style cleanup > - Move some macro definition from lowlevel_init.S > to a

Re: [U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-29 Thread Marek Vasut
Dear Gabriel Huau, Commit message got lost ? :p > Signed-off-by: Gabriel Huau > --- > arch/arm/include/asm/arch-s3c24x0/gpio.h | 183 > +++ arch/arm/include/asm/arch-s3c24x0/iomux.h | > 197 + drivers/gpio/Makefile > |

Re: [U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)

2012-04-29 Thread Marek Vasut
Dear Gabriel Huau, > From the last time, I removed the patch about the PLL initialization > because it's board specific. I added a new patch for s3c440 gpio driver. > Now in the board file we have no more magic bloat. Even without looking, I sense flaws ... I sense fluctuations in the patch-force

Re: [U-Boot] [PATCH v4 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver

2012-04-29 Thread Marek Vasut
Dear Lukasz Majewski, > This commit adds support for storing private data to Samsung's UDC > driver. This data is afterward used by usb gadget. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/s3c_udc_otg.c | 12 > 1

Re: [U-Boot] [PATCH v4 2/3] usb:gadget:composite: Support for composite at gadget.h

2012-04-29 Thread Marek Vasut
Dear Lukasz Majewski, > Add device data pointer to the USB gadget's device struct. > Wrapper for extracting usb_gadget from Linux's usb device > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut Acked-by: Marek Vasut > > --- > include/linux/usb/gadget.h |

Re: [U-Boot] [PATCH v4 1/3] usb:gadget:composite USB composite gadget support

2012-04-29 Thread Marek Vasut
Dear Lukasz Majewski, > On Thu, 26 Apr 2012 00:53:01 +0200 > > Marek Vasut wrote: > > Dear Lukasz Majewski, > > > > > USB Composite gadget implementation for u-boot. It builds on top > > > of USB UDC drivers. > > > > > > This commit is based on following files from Linux Kernel v2.6.36: > > >

Re: [U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)

2012-04-29 Thread Gabriel Huau
On Sun, Apr 29, 2012 at 11:32:27PM +0200, Wolfgang Denk wrote: > Dear Gabriel Huau, > > In message <1335734845-27396-1-git-send-email-cont...@huau-gabriel.fr> you > wrote: > > > > >> +/* > > >> + * When booting from NAND, it is impossible to access the lowest > > >> addresses > > >> + * due to t

Re: [U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)

2012-04-29 Thread Wolfgang Denk
Dear Gabriel Huau, In message <1335734845-27396-1-git-send-email-cont...@huau-gabriel.fr> you wrote: > > >> +/* > >> + * When booting from NAND, it is impossible to access the lowest addresses > >> + * due to the SteppingStone being in the way. Luckily the NOR doesn't > >> really > >> + * care a

[U-Boot] [PATCH 2/2 v5] Add support for MINI2440 (s3c2440).

2012-04-29 Thread Gabriel Huau
--- Changes for v2: - Coding style cleanup - Remove unnecessary files modification - Remove unnecessary board configuration set Changes for v3: - Coding style cleanup - Move some macro definition from lowlevel_init.S to a new header - Remove

[U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-29 Thread Gabriel Huau
Signed-off-by: Gabriel Huau --- arch/arm/include/asm/arch-s3c24x0/gpio.h | 183 +++ arch/arm/include/asm/arch-s3c24x0/iomux.h | 197 + drivers/gpio/Makefile |1 + drivers/gpio/s3c2440_gpio.c | 74 ++

[U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)

2012-04-29 Thread Gabriel Huau
>From the last time, I removed the patch about the PLL initialization because it's board specific. I added a new patch for s3c440 gpio driver. Now in the board file we have no more magic bloat. >> +/* >> + * When booting from NAND, it is impossible to access the lowest addresses >> + * due to the

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-29 Thread Luka Perkov
Hi Albert, On Thu, Apr 19, 2012 at 08:38:19AM +0200, Albert ARIBAUD wrote: > Not my main area of expertise here, but I am not sure how this plays > on Marvell non-kirkwood platforms (e.g., orion5x). > > ISTR it is not the first time we deal with the whole IDE number of > bus / number of ports [ /

Re: [U-Boot] [PATCH] i.MX6Q: mx6qsabrelite: Add keypress support to alter boot flow

2012-04-29 Thread stefano babic
Am 29/04/2012 20:24, schrieb Eric Nelson: > On 04/29/2012 07:59 AM, Stefano Babic wrote: >> On 26/04/2012 02:14, Eric Nelson wrote: >>> Uses the 'magic_keys' idiom as described in doc/README.kbd: >>> http://lists.denx.de/pipermail/u-boot/2012-April/122502.html >>> >>> Signed-off-by: Eric Nelson

Re: [U-Boot] [PATCH] i.MX6Q: mx6qsabrelite: Add keypress support to alter boot flow

2012-04-29 Thread Eric Nelson
On 04/29/2012 07:59 AM, Stefano Babic wrote: On 26/04/2012 02:14, Eric Nelson wrote: Uses the 'magic_keys' idiom as described in doc/README.kbd: http://lists.denx.de/pipermail/u-boot/2012-April/122502.html Signed-off-by: Eric Nelson Acked-by: Marek Vasut --- Applied after rebasing on

Re: [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c

2012-04-29 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201204291511.36960.ma...@denx.de> you wrote: > > > Yes, I think I can: don't use funny characters like these quotes > > > around "arg_off_size" and "maxsize" in the commit messages. > > > > Looking closer at it, it's not standard "'" quote

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Dirk, On Sun, Apr 29, 2012 at 1:26 PM, Fabio Estevam wrote: > This should be fixed, but it seems it does not explain the problem you > are seeing. We need to check whether get_ahb_clk() is using the weak > definition of get_periph_clk() instead the one from clock.c. Yes, I confirmed that that g

[U-Boot] [PATCH v2] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
get_ahb_clk() is a common function between mx5 and mx6. Place it into imx-common directory. Cc: Dirk Behme Signed-off-by: Fabio Estevam --- Changes since v1: Do not use weak definition for get_periph_clk() arch/arm/cpu/armv7/imx-common/cpu.c| 13 + arch/arm/cpu/a

Re: [U-Boot] [PATCH] eb_cpux9k2: fix chip select

2012-04-29 Thread Jens Scharsig
Please ignore this patch, it was send with misconfigured mail server The resend http://patchwork.ozlabs.org/patch/155739/ is the valid one. Best regards Jens Scharsig ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

Re: [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c

2012-04-29 Thread Wolfgang Denk
Dear Marek Vasut, In message <201204291511.36960.ma...@denx.de> you wrote: > > > Yes, I think I can: don't use funny characters like these quotes > > around "arg_off_size" and "maxsize" in the commit messages. > > Looking closer at it, it's not standard "'" quote character, what the heck. > But

[U-Boot] [PATCH] eb_cpux9k2: add ram target configuration

2012-04-29 Thread Jens Scharsig
* add ram target for EB+CPUx9k2 board (eb_cpux9k2_ram_config) Signed-off-by: Jens Scharsig --- boards.cfg |3 ++- include/configs/eb_cpux9k2.h |5 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/boards.cfg b/boards.cfg index 3cf75c3..efca4fc 100644

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Stefano Babic
On 29/04/2012 18:43, Dirk Behme wrote: > Hi Stefano, > > On 29.04.2012 16:54, Fabio Estevam wrote: >> Hi Dirk, >> >> On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme >> wrote: >> >>> We had this patch on a v2012.04.1 based test branch and it showed some >>> strange issues with SD cards on i.MX6. >>> >

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Dirk Behme
Hi Stefano, On 29.04.2012 16:54, Fabio Estevam wrote: Hi Dirk, On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme wrote: We had this patch on a v2012.04.1 based test branch and it showed some strange issues with SD cards on i.MX6. Depending on the SD card used (different ones) and the board (Sabre

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Dirk, On Sun, Apr 29, 2012 at 11:54 AM, Fabio Estevam wrote: > Thanks for testing it. I found one mistake and will submit a fix shortly. Here is one issue I found: --- a/arch/arm/cpu/armv7/imx-common/cpu.c +++ b/arch/arm/cpu/armv7/imx-common/cpu.c @@ -147,6 +147,4 @@ u32 get_ahb_clk(void)

Re: [U-Boot] [PATCH v2 2/2] hush.c: Move default CONFIG_SYS_PROMPT_HUSH_PS2 to hush.c

2012-04-29 Thread Stefano Babic
On 27/04/2012 00:46, Tom Rini wrote: > Exactly one board has defined CONFIG_SYS_PROMPT_HUSH_PS2 to a value > different than "> " which is vision2. I have Cc'd the maintainer here > as I strongly suspect this is a bug rather than intentional behavior. Hi Tom, you're right, it was n ot my intentio

Re: [U-Boot] Using sata on mx6qsabrelite

2012-04-29 Thread Stefano Babic
On 26/04/2012 00:11, Eric Nelson wrote: > On 04/25/2012 12:10 PM, Eric Nelson wrote: >> On 04/25/2012 11:40 AM, Fabio Estevam wrote: >>> Hi, >>> >>> On Stefano´s tree I see this sata patch for mx5/mx6: >>> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=6931bd30d03de827c52bf2c8ddc6ed0c8f21dc

Re: [U-Boot] [PATCH] i.MX6Q: mx6qsabrelite: Add keypress support to alter boot flow

2012-04-29 Thread Stefano Babic
On 26/04/2012 02:14, Eric Nelson wrote: > Uses the 'magic_keys' idiom as described in doc/README.kbd: > http://lists.denx.de/pipermail/u-boot/2012-April/122502.html > > Signed-off-by: Eric Nelson > Acked-by: Marek Vasut > --- Applied after rebasing on current u-boot-imx, thanks. Best reg

Re: [U-Boot] [PATCH] i.MX6Q: mx6qsabrelite: Add keypress support to alter boot flow

2012-04-29 Thread Stefano Babic
On 26/04/2012 12:12, Marek Vasut wrote: > Dear Eric Nelson, > >> On 04/25/2012 05:17 PM, Marek Vasut wrote: >>> Dear Eric Nelson, >>> Uses the 'magic_keys' idiom as described in doc/README.kbd: http://lists.denx.de/pipermail/u-boot/2012-April/122502.html >>> >>> If this is a V2 of a p

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Hi Dirk, On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme wrote: > We had this patch on a v2012.04.1 based test branch and it showed some > strange issues with SD cards on i.MX6. > > Depending on the SD card used (different ones) and the board (SabreLite and > a custom one) > > - the SD card just wor

Re: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings

2012-04-29 Thread Stefano Babic
On 28/04/2012 17:36, Eric Nelson wrote: > Hi Dirk, > > On 04/28/2012 07:51 AM, Dirk Behme wrote: >> Hi Eric, >> >> On 26.04.2012 01:50, Eric Nelson wrote: >>> Signed-off-by: Eric Nelson >>> >>> --- >>> V2 has been stripped of the board-independent changes and >>> uses clrsetbits_le32() instead of

[U-Boot] [PATCH] eb_cpux9k2: fix chip select

2012-04-29 Thread y
From: Jens Scharsig * fix chip select initialization for frame buffer, this will be increase frame buffer access speed Signed-off-by: Jens Scharsig --- board/BuS/eb_cpux9k2/cpux9k2.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/board/BuS/eb_cpux9k2/cpux9k2.c

Re: [U-Boot] [PATCH 3/4] mx6qarm2: Allow booting a zImage kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:31, Fabio Estevam wrote: > Allow booting a zImage kernel. > > Cc: Jason Liu > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering Gmb

Re: [U-Boot] [PATCH 2/4] mx6qsabrelite: Allow booting a zImage kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:31, Fabio Estevam wrote: > Allow booting a zImage kernel. > > Cc: Jason Liu > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering G

Re: [U-Boot] [PATCH 1/4] mx28evk: Allow booting a zImage kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:31, Fabio Estevam wrote: > Allow booting a zImage kernel. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfga

Re: [U-Boot] [PATCH 4/4] mx31pdk: Allow booting a zImage kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:31, Fabio Estevam wrote: > Allow booting a zImage kernel. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfga

Re: [U-Boot] [PATCH 2/2] m28evk: Allow to booting a dt kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:06, Fabio Estevam wrote: > Allow to booting a dt kernel. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgan

Re: [U-Boot] [PATCH 1/2] mx28evk: Allow to booting a dt kernel

2012-04-29 Thread Stefano Babic
On 23/04/2012 18:06, Fabio Estevam wrote: > Allow to booting a dt kernel. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfga

[U-Boot] [PATCH] eb_cpux9k2: fix chip select

2012-04-29 Thread Jens Scharsig
* fix chip select initialization for frame buffer, this will be increase frame buffer access speed Signed-off-by: Jens Scharsig --- board/BuS/eb_cpux9k2/cpux9k2.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/board/BuS/eb_cpux9k2/cpux9k2.c b/board/BuS/eb_cpux9k2

Re: [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c

2012-04-29 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1335652120-2646-1-git-send-email-ma...@denx.de> you wrote: > > cmd_nand.c: In function ‘arg_off_size’: > > cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this > > function [-Wmaybe-uninitialized] > > > > Signed-off-by: Ma

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 29 April 2012 11:10:42 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > On Sunday 29 April 2012 00:15:23 Marek Vasut wrote: > > > > Won't it be easier to create a preprocessing function > > > > that'd > > > > fill gd properly, so uboot can generate the atags through

Re: [U-Boot] [PATCH v2 11/11] New board support: Nokia RX-51 aka N900

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <2499233.2JzaJFJkCD@pali> you wrote: > > > Please stop sending base64 encoded patches! Send plain text > > only! > > I used git format-patch and git send-email. Is there easy way how > to tell this to git? Yes: do not use characters that cause p

Re: [U-Boot] [PATCH v2 10/11] New config variable CONFIG_PREMONITOR

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <1886523.MLHYlDJPrM@pali> you wrote: > > I need to run some script before monitor code but after menucmd. > And preboot is called before bootdelay and also before menucmd. > So I added premonitor which is called before monitor, but after > bootdel

Re: [U-Boot] [PATCH v2 06/11] cfb_console: Add support for some ANSI terminal escape codes

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <3284404.3VX1zBQJtc@pali> you wrote: > > > > + if (ansi_buf_size > 0) { > > > + /* > > > + 0 - ESC > > > + 1 - [ > > > + 2 - num1 > > > + 3 - .. > > > + 4 - ; > > > + 5 - num2 > > > + 6

Re: [U-Boot] [PATCH 0/5] Various x86 patches

2012-04-29 Thread Graeme Russ
Hi Andy, On 04/29/2012 10:25 PM, Andy Pont wrote: > Hi Graeme, > >> Graeme Russ (5): >> x86: Fix compilation on 64-built built machines > > Shouldn't this be 64-bit build machines? Yep - Thanks Regards, Graeme ___ U-Boot mailing list U-Boot@lists.

Re: [U-Boot] [PATCH 0/5] Various x86 patches

2012-04-29 Thread Andy Pont
Hi Graeme, > Graeme Russ (5): > x86: Fix compilation on 64-built built machines Shouldn't this be 64-bit build machines? Regards, Andy. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 05/11] cfb_console: Add functions for moving with cursor

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <1704132.kQI9AKOLjq@pali> you wrote: > > > How/where do you use these? Documentation entry is missing and > > there're no comments in the code. > > In ansi terminal. I cannot parse this. Where is the documentation? Best regards, Wolfgang Denk -

Re: [U-Boot] [PATCH v2 03/11] cfb_console: Fix function console_back

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <1581447.hx3godgTju@pali> you wrote: > > > Can you elaborate please? > > console_back is called only from cfb putc function which already > turn off cursor at begin and turn on at the end of call. > > So function console_back will have always disa

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Wolfgang Denk
Dear Pali =?ISO-8859-1?Q?Roh=E1r?=, In message <2099459.BqkWJMp2Uq@pali> you wrote: > > On Saturday 28 April 2012 23:20:04 Wolfgang Denk wrote: > > Please stop posting your patches with base64 > > Content-transfer-encoding; thanks. > > How can I tell this to git format-patch and git send-email?

Re: [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c

2012-04-29 Thread Wolfgang Denk
Dear Marek Vasut, In message <1335652120-2646-1-git-send-email-ma...@denx.de> you wrote: > cmd_nand.c: In function ‘arg_off_size’: > cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > > Signed-off-by: Marek Vasut > Cc: Scott Wood > Cc: W

[U-Boot] [PATCH 5/5] x86: Add ilog2 to bitops

2012-04-29 Thread Graeme Russ
ilog2 is required by AHCI driver Signed-off-by: Graeme Russ --- arch/x86/include/asm/bitops.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index c7a38f2..5a7e4cb 100644 --- a/arch/x86/include/asm/bitops

[U-Boot] [PATCH 3/5] x86: Put global data on the stack

2012-04-29 Thread Graeme Russ
Putting global data on the stack simplifies the init process (and makes it slightly quicker). During the 'flash' stage of the init sequence, global data is in the CAR stack. After SDRAM is initialised, global data is copied from CAR to the SDRAM stack Signed-off-by: Graeme Russ --- arch/x86/cpu/

[U-Boot] [PATCH 4/5] x86: Remove duplicate PCI init

2012-04-29 Thread Graeme Russ
Signed-off-by: Graeme Russ --- arch/x86/lib/board.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c index 100ac1e..8c8b6fe 100644 --- a/arch/x86/lib/board.c +++ b/arch/x86/lib/board.c @@ -169,9 +169,6 @@ init_fnc_t *init_sequ

[U-Boot] [PATCH 2/5] x86: Forward declate gd_t

2012-04-29 Thread Graeme Russ
So it can be used as a type in struct global_data and remove an ugly typecast Signed-off-by: Graeme Russ --- arch/x86/cpu/cpu.c |2 +- arch/x86/include/asm/global_data.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/cpu.c b/arch/x86/

[U-Boot] [PATCH 1/5] x86: Fix compilation on 64-built built machines

2012-04-29 Thread Graeme Russ
Signed-off-by: Graeme Russ --- Makefile |1 + arch/x86/cpu/config.mk |3 ++- examples/standalone/Makefile |2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index cdd4294..4f5cb60 100644 --- a/Makefile +++ b/Makefile @@

[U-Boot] [PATCH 0/5] Various x86 patches

2012-04-29 Thread Graeme Russ
These have been floating around for a while waiting for 2012.04 The first patch touches on the common makefiles, but it is only examples/standalone/Makefile that really needs to be checked for cross-platform issues Graeme Russ (5): x86: Fix compilation on 64-built built machines x86: Forward

Re: [U-Boot] [PATCH v2 11/11] New board support: Nokia RX-51 aka N900

2012-04-29 Thread Marek Vasut
Dear Pali Rohár, > On Saturday 28 April 2012 23:32:25 Wolfgang Denk wrote: > > Please stop sending base64 encoded patches! Send plain text > > only! > > I used git format-patch and git send-email. Is there easy way how > to tell this to git? > > > While it is a good idea to provide documentati

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Pali Rohár
On Sunday 29 April 2012 11:10:42 Marek Vasut wrote: > Dear Pali Rohár, > > > On Sunday 29 April 2012 00:15:23 Marek Vasut wrote: > > > Won't it be easier to create a preprocessing function > > > that'd > > > fill gd properly, so uboot can generate the atags through > > > standard means then? > > >

Re: [U-Boot] [PATCH v2 05/11] cfb_console: Add functions for moving with cursor

2012-04-29 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 29 April 2012 00:18:21 Marek Vasut wrote: > > Dear Pali Rohár, > > > > > * console_cursor_fix - fix cursor position (check for out of > > > screen) * console_cursor_up, console_cursor_down, > > > console_cursor_left,> > > > > > >console_cursor_right, console_

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Marek Vasut
Dear Pali Rohár, > On Sunday 29 April 2012 00:15:23 Marek Vasut wrote: > > Won't it be easier to create a preprocessing function that'd > > fill gd properly, so uboot can generate the atags through > > standard means then? > > Do you mean to generate/copy other atags in board code? This will > no

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Pali Rohár
On Saturday 28 April 2012 19:22:38 Mike Frysinger wrote: > On Saturday 28 April 2012 13:26:41 Pali Rohár wrote: > > defined(CONFIG_INITRD_TAG) || \ > > defined(CONFIG_SERIAL_TAG) || \ > > defined(CONFIG_REVISION_TAG) > > > > + #define CONFIG_SETUP_ANY_TAG > > don't indent the

Re: [U-Boot] [PATCH v2 11/11] New board support: Nokia RX-51 aka N900

2012-04-29 Thread Pali Rohár
On Saturday 28 April 2012 23:32:25 Wolfgang Denk wrote: > > Please stop sending base64 encoded patches! Send plain text > only! I used git format-patch and git send-email. Is there easy way how to tell this to git? > > While it is a good idea to provide documentation, this is the > wrong place

Re: [U-Boot] [PATCH v2 10/11] New config variable CONFIG_PREMONITOR

2012-04-29 Thread Pali Rohár
On Saturday 28 April 2012 22:39:51 Wolfgang Denk wrote: > Dear =?UTF-8?q?Pali Rohár?=, > > In message <1335634011-9104-11-git-send-email- pali.ro...@gmail.com> you wrote: > > * if defined run env "premonitor" before Main Loop for > > Monitor Processing > What would be the difference compared to "

Re: [U-Boot] [PATCH v2 06/11] cfb_console: Add support for some ANSI terminal escape codes

2012-04-29 Thread Pali Rohár
On Sunday 29 April 2012 00:19:03 Marek Vasut wrote: > > + > > + if (ansi_buf_size > 0) { > > + /* > > + 0 - ESC > > + 1 - [ > > + 2 - num1 > > + 3 - .. > > + 4 - ; > > + 5 - num2 > > + 6 - .. > > + 7 - cchar

Re: [U-Boot] [PATCH v2 05/11] cfb_console: Add functions for moving with cursor

2012-04-29 Thread Pali Rohár
On Sunday 29 April 2012 00:18:21 Marek Vasut wrote: > Dear Pali Rohár, > > > * console_cursor_fix - fix cursor position (check for out of > > screen) * console_cursor_up, console_cursor_down, > > console_cursor_left,> > >console_cursor_right, console_cursor_set_position for > >change cur

Re: [U-Boot] [PATCH v2 03/11] cfb_console: Fix function console_back

2012-04-29 Thread Pali Rohár
On Sunday 29 April 2012 00:15:58 Marek Vasut wrote: > Dear Pali Rohár, > > > * Do not disable and enable cursor again > > Can you elaborate please? > console_back is called only from cfb putc function which already turn off cursor at begin and turn on at the end of call. So function console_back

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Pali Rohár
On Saturday 28 April 2012 23:20:04 Wolfgang Denk wrote: > Please stop posting your patches with base64 > Content-transfer-encoding; thanks. How can I tell this to git format-patch and git send-email? Also I looked in my mailbox and all emails have no base64 header, but Content-Transfer-Encoding: 8

Re: [U-Boot] [PATCH v2 01/11] arm: Optionally use existing atags in bootm.c

2012-04-29 Thread Pali Rohár
On Sunday 29 April 2012 00:15:23 Marek Vasut wrote: > Won't it be easier to create a preprocessing function that'd > fill gd properly, so uboot can generate the atags through > standard means then? Do you mean to generate/copy other atags in board code? This will not work because u-boot (in bootm.