Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
Hi Marek, On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: > Dear Julius Werner, > >> These patches haven't gone in yet, right? I think Vivek wants to >> discuss/update them himself, he just asked me to move my reviews to >> this thread. > > They're not in, but they're already pushed in my tr

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
Hi Julius, On Fri, Apr 19, 2013 at 11:52 PM, Julius Werner wrote: > Migrating my comments here for public discussion. Thanks for your valuable comments here. > >> This adds usb framework support for super-speed usb, which will >> further facilitate to add stack support for xHCI. >> >> Signed-o

[U-Boot] [PATCH v2 2/2] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-21 Thread Pierre Aubert
The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the support of the i.MX6DL. The config file and the board directory are renamed to remove the reference to the MX6Q. Signed-off-by: Pierre Aubert CC: Stefano Babic --- Changes in v2: - update MAINTAINERS -

[U-Boot] Driver Model Thoughts

2013-04-21 Thread Simon Glass
Hi Marek, Another U-Boot engineer and I are looking at running up driver model. It seems to work in sandbox quite nicely. I had half a mind to try to get some core patches together for this merge window, but have questions. For 'struct instance' it seems to be an attempt to keep the constant dat

Re: [U-Boot] [PATCH v2 03/12] net: add Faraday FTMAC110 10/100Mbps ethernet support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-4-git-send-email-dant...@gmail.com> you wrote: >> >> +/***/ >> +/* FTMAC110 DMA design issue */ >> +/*

Re: [U-Boot] [PATCH v2 05/12] spi: add Faraday FTSPI010 SPI controller support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-6-git-send-email-dant...@gmail.com> you wrote: > ... >> +/* Register access macros */ >> +#define SPI_READ(r) le32_to_cpu(readl(r)) >> +#define SPI_WRITE(v, r) writel(cpu_to_le32(v), r) >> +

Re: [U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-5-git-send-email-dant...@gmail.com> you wrote: > ... >> +#define I2C_READ(r) le32_to_cpu(readl(r)) >> +#define I2C_WRITE(v, r) writel(cpu_to_le32(v), r) > > Please drop these macros and use the real functio

Re: [U-Boot] [PATCH v2 06/12] mmc: add an alternative driver to Faraday FTSDC010

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-7-git-send-email-dant...@gmail.com> you wrote: >> From: Kuo-Jung Su >> >> Faraday FTSDC010 is a MMC/SD host controller. >> Although there is already a driver in current u-boot release, >> which is modified from eSHDC an

Re: [U-Boot] [PATCH v2 07/12] mtd: nand: add Faraday FTNANDC021 NAND controller support

2013-04-21 Thread Kuo-Jung Su
2013/4/19 Scott Wood : > On 04/18/2013 04:25:34 AM, Kuo-Jung Su wrote: >> >> diff --git a/drivers/mtd/nand/ftnandc021.c b/drivers/mtd/nand/ftnandc021.c >> new file mode 100644 >> index 000..58863dc >> --- /dev/null >> +++ b/drivers/mtd/nand/ftnandc021.c >> @@ -0,0 +1,544 @@ >> +/* >> + * Farada

Re: [U-Boot] [PATCH v2 07/12] mtd: nand: add Faraday FTNANDC021 NAND controller support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-8-git-send-email-dant...@gmail.com> you wrote: > ... >> +/* Register access macros */ >> +#define NAND_READ(r) le32_to_cpu(readl(r)) >> +#define NAND_WRITE(v, r) writel(cpu_to_le32(v), r) >> +#define NAND_SET

Re: [U-Boot] [PATCH v2 08/12] mtd: spi: add FTSPI020 SPI Flash controller support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-9-git-send-email-dant...@gmail.com> you wrote: > ... >> +/* Register access macros */ >> +#define SPI_READ(r) le32_to_cpu(readl(r)) >> +#define SPI_WRITE(v, r) writel(cpu_to_le32(v), r) >> +

Re: [U-Boot] [PATCH v2 09/12] usb: ehci: add Faraday USB 2.0 EHCI support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-10-git-send-email-dant...@gmail.com> you wrote: > ... >> +#define HCD_READ(r) le32_to_cpu(readl(r)) >> +#define HCD_WRITE(v, r) writel(cpu_to_le32(v), r) >> +#define HCD_SETBITS(m, r)set

Re: [U-Boot] [PATCH v2 10/12] usb: gadget: add Faraday FOTG210 USB gadget support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-11-git-send-email-dant...@gmail.com> you wrote: >> From: Kuo-Jung Su >> >> The Faraday FOTG210 is an OTG chip which could operate >> as either an EHCI Host or a USB Device as a time. > ... >> + uint32_t maxpacket:16

Re: [U-Boot] [PATCH v2 11/12] arm: add MMU/d-cache support for Faraday cores

2013-04-21 Thread Kuo-Jung Su
2013/4/19 Albert ARIBAUD : > Hi Kuo-Jung, > > On Thu, 18 Apr 2013 17:25:38 +0800, Kuo-Jung Su > wrote: > >> From: Kuo-Jung Su >> >> This patch would enable MMU for Faraday ARMv5TE cores. >> >> Here is the abstract of this MMU design. >> >> Assume SDRAM memory region starts at 0x1000, and its

Re: [U-Boot] [PATCH v2 00/12] arm: add Faraday A36x SoC platform support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-1-git-send-email-dant...@gmail.com> you wrote: >> >> These patches introduce Faraday A36x SoC platform support. > > Please run all your patches through checkpatch and clean up thew > reported warnings and errors before y

Re: [U-Boot] [PATCH v2 12/12] arm: add Faraday A36x SoC platform support

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-13-git-send-email-dant...@gmail.com> you wrote: > ... >> +#define CONFIG_FTMAC1101 >> +#define CONFIG_ETHADDR 00:84:14:72:61:69 /* used by env_common.c */ >> +#define CONFIG_NETMASK 255.255.255.0

Re: [U-Boot] [PATCH v2 11/12] arm: add MMU/d-cache support for Faraday cores

2013-04-21 Thread Kuo-Jung Su
2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-12-git-send-email-dant...@gmail.com> you wrote: > ... >> --- a/common/cmd_boot.c >> +++ b/common/cmd_boot.c >> @@ -50,6 +50,10 @@ static int do_go(cmd_tbl_t *cmdtp, int flag, int argc, >> char * const argv[]) >> >>

Re: [U-Boot] [PATCH] video: exynos_fb: Add the missing #else clause

2013-04-21 Thread Donghwa Lee
It looks good to me. Acked-by: Donghwa Lee Thank you, Donghwa Lee On Mon, Apr 22, 2013 at 02:03, Ajay kumar wrote: ping. On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar > wrote: This patch fixes a bug introduced while adding DT support to Exynos FIMD d

Re: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <201304211642.56723.ma...@denx.de> you wrote: > > > Yes, they set it for this single place where it gets used. > > > > Do you want me to fix it or will you ? > > If you have some time left... thanks in advance. Looking through the code, it seems

Re: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Wolfgang Denk
Dear Marek, In message <201304211642.56723.ma...@denx.de> you wrote: > > > Yes, they set it for this single place where it gets used. > > Do you want me to fix it or will you ? If you have some time left... thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Marek Vasut
Dear Benoît Thébaudeau, > Dear Marek Vasut, > > On Sunday, April 21, 2013 9:12:31 PM, Marek Vasut wrote: > > Dear Benoît Thébaudeau, > > > > > Dear Marek Vasut, > > > > > > On Sunday, April 21, 2013 5:52:27 PM, Marek Vasut wrote: > > > > Add basic support for the DENX M53EVK board. Currently su

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Benoît Thébaudeau
Dear Marek Vasut, On Sunday, April 21, 2013 9:12:31 PM, Marek Vasut wrote: > Dear Benoît Thébaudeau, > > > Dear Marek Vasut, > > > > On Sunday, April 21, 2013 5:52:27 PM, Marek Vasut wrote: > > > Add basic support for the DENX M53EVK board. Currently supported is: > > > MMC (incl. booting) > >

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Marek Vasut
Dear Benoît Thébaudeau, > Dear Marek Vasut, > > On Sunday, April 21, 2013 5:52:27 PM, Marek Vasut wrote: > > Add basic support for the DENX M53EVK board. Currently supported is: > > MMC (incl. booting) > > ^ > Can you clarify this, please? Use u-boot.imx for SD booting as usual. >

[U-Boot] [PATCH] Fix usb buffer size for large descriptor of devices

2013-04-21 Thread Nicolas Chauvet
scanning bus 0 for devices... usb_get_configuration_no: failed to get descriptor - too long: 943 This was experienced on toshiba ac100 aka paz00, when discovering the webcam. This patch is probably wrong, as it raise the buffer for all usb. Instead it could probably be raised only per target syst

[U-Boot] Regression from v2013.04-rc3 with sdcard detection

2013-04-21 Thread Nicolas Chauvet
Hi, I'm experiencing a regression from v2013.04-rc3 that I found related to the following commit: 64f4a6192f0670de2d9af98900b750a3e7bf8ce6 1741c64d642a95c4bb88a2b03e96c6dc7ed5fe62 With v2013.04 release, when trying to boot from sdcard, I have: "Card did not respond to voltage select" while detec

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Benoît Thébaudeau
Dear Marek Vasut, On Sunday, April 21, 2013 5:52:27 PM, Marek Vasut wrote: > Add basic support for the DENX M53EVK board. Currently supported is: > MMC (incl. booting) ^ Can you clarify this, please? spl_boot_device() points only to NAND, so you're clearly talking about hardware MMC b

Re: [U-Boot] [PATCH] video: exynos_fb: Add the missing #else clause

2013-04-21 Thread Ajay kumar
ping. On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar wrote: > This patch fixes a bug introduced while adding DT support > to Exynos FIMD driver: > > commit c23f3157d69bbb6c044256870f745f195b12431e > Author: Ajay Kumar > Date: Thu Feb 21 23:53:01 2013 + > >

Re: [U-Boot] [PATCH 3/3] mx6sl: Add initial support for mx6slevk board

2013-04-21 Thread Fabio Estevam
Hi Stefano, On Wed, Apr 17, 2013 at 5:48 AM, Stefano Babic wrote: > Ok, let's do in this way - I agree that U-boot should only turn on the > clocks that it requires and do not touch the rest. But let's start > pushing this into u-boot-imx and then we can trim this setup. Please let me know when

[U-Boot] [PATCH] powerpc: Use lower case for the core names

2013-04-21 Thread Fabio Estevam
From: Fabio Estevam Freescale documentation presents the PowerPC core names in lower case, such as "e300", "e500", "e600", etc. Change the upper case occurrences into lower case so that the core names reported in U-boot can match the ones from the documentation. While at it also fix a checkpat

[U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Marek Vasut
Add basic support for the DENX M53EVK board. Currently supported is: MMC (incl. booting) NAND (incl. booting) Ethernet, I2C, USB, SATA, RTC. Signed-off-by: Marek Vasut Cc: Albert ARIBAUD Cc: Benoît Thébaudeau Cc: Fabio Estevam Cc: Scott Wood Cc: Stefano Babic Cc: Tom Rini Cc: Wolfgang Denk

[U-Boot] [PATCH 5/6] arm: mx5: Add NAND clock handling

2013-04-21 Thread Marek Vasut
Augment the MX5 clock code with function to enable and configure NFC clock. This is necessary to get NFC working on MX5. Signed-off-by: Marek Vasut Cc: Albert ARIBAUD Cc: Benoît Thébaudeau Cc: Fabio Estevam Cc: Scott Wood Cc: Stefano Babic Cc: Tom Rini --- arch/arm/cpu/armv7/mx5/clock.c

[U-Boot] [PATCH V2 2/6] nand: Add SPL_NAND support to mxc_nand_spl

2013-04-21 Thread Marek Vasut
Add support for generic NAND SPL via the SPL framework into the mxc_nand_spl driver. This is basically just a simple rename and publication of the already implemented functions. To avoid the bare-bones functions getting in the way of the NAND_SPL, build them only if CONFIG_SPL_FRAMEWORK is not defi

[U-Boot] [PATCH V2 3/6] arm: imx: Pack u-boot.bin into uImage for SPL

2013-04-21 Thread Marek Vasut
The U-Boot SPL can parse the uImage format and gather information from it about the payload. Make use of this and wrap u-boot.bin into uImage format. The benefit is the SPL will know the size of the payload instead of using fixed size of the payload defined at compile time. Signed-off-by: Marek Va

[U-Boot] [PATCH 4/6] arm: mx5: Add SPL support code to MX5

2013-04-21 Thread Marek Vasut
Fix minor adjustments needed to get SPL framework building on MX5. Signed-off-by: Marek Vasut Cc: Albert ARIBAUD Cc: Benoît Thébaudeau Cc: Fabio Estevam Cc: Scott Wood Cc: Stefano Babic Cc: Tom Rini --- arch/arm/include/asm/arch-mx5/spl.h | 19 +++ spl/Makefile

[U-Boot] [PATCH V2 1/6] imx: Align the imximage header and payload to multiples of 4k

2013-04-21 Thread Marek Vasut
The MX53 ROM loads the data from NAND in multiples of pages and supports maximum page size of 4k. Thus, align the image and header to 4k to be safe from ROM bugs. Signed-off-by: Marek Vasut Cc: Albert ARIBAUD Cc: Benoît Thébaudeau Cc: Fabio Estevam Cc: Scott Wood Cc: Stefano Babic Cc: Tom Ri

Re: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-21 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201304210243.05923.ma...@denx.de> you wrote: > > > > > What do we need CONFIG_LOADADDR for? > > > > > > > > For this stuff, the "loadaddr" env variable. I have kinda idea to > > > > kill this and unify it to CONFIG_SYS_LOAD_ADDR all around,