Re: [U-Boot] [PATCH] common: hash: fix crc32 verify

2015-05-05 Thread Marcel Ziswiler
On 5 May 2015 19:25:26 CEST, Joe Hershberger wrote: >This is clearly the wrong way to fix this issue since it breaks pretty >much every other aspect of hashing. Proper fix forthcoming. I admit that I don't know nothing about any of that hashing stuff off late but it is crystal clear that Nikol

Re: [U-Boot] loading environment from SATA

2015-05-05 Thread Ben Hewson
Hi Fabio, Sorry, kind of got side tracked a bit. Tom, in response to SATA off a PCI bus, that was my main concern with just adding a SATA init. However after looking through the code I have noticed that there is a CONFIG_SYS_EARLY_PCI_INIT which if declared will call initr_pci before my initr_

Re: [U-Boot] [PATCH 04/24] dm: i2c: Implement 'i2c bus' command for driver model

2015-05-05 Thread Heiko Schocher
Hello Simon, Am 04.05.2015 19:30, schrieb Simon Glass: This command was missed in the conversion. Add it back for driver model. Signed-off-by: Simon Glass --- common/cmd_i2c.c | 63 +--- 1 file changed, 55 insertions(+), 8 deletions(-) d

Re: [U-Boot] [PATCH 1/5] x86: Support QEMU x86 targets

2015-05-05 Thread Bin Meng
Hi Simon, On Wed, May 6, 2015 at 12:01 PM, Simon Glass wrote: > Hi Bin, > > On 5 May 2015 at 09:24, Bin Meng wrote: >> This commit introduces the initial U-Boot support for QEMU x86 targets. >> U-Boot can boot from coreboot as a payload, or directly without coreboot. >> >> Signed-off-by: Bin Men

Re: [U-Boot] [RFC PATCH v1] Makefile: Add U_BOOT_TZ and include in version

2015-05-05 Thread Chris Packham
Hi, On Thu, Apr 30, 2015 at 12:38 PM, Chris Packham wrote: > Define U_BOOT_TZ alongside U_BOOT_TIME and U_BOOT_DATE and use it to > include the timezone in the version output. > > Signed-off-by: Chris Packham > --- > > Makefile | 3 ++- > include/version.h | 2 +- > 2 files changed, 3

Re: [U-Boot] [PATCH 05/24] dm: i2c: Add a function to find out the chip offset length

2015-05-05 Thread Heiko Schocher
Hello Simon, Am 04.05.2015 19:30, schrieb Simon Glass: We can currently set this but there is no API function to get it. Add one. Signed-off-by: Simon Glass --- drivers/i2c/i2c-uclass.c | 7 +++ include/i2c.h| 9 - 2 files changed, 15 insertions(+), 1 deletion(-)

Re: [U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy

2015-05-05 Thread Michael Trimarchi
Hi On Wed, May 6, 2015 at 9:40 AM, qiang.z...@freescale.com wrote: > On Tue, May 5, 2015 at 5:41 PM, Michael Trimarchi wrote: > >> -Original Message- >> From: Michael Trimarchi [mailto:mich...@amarulasolutions.com] >> Sent: Tuesday, May 05, 2015 5:41 PM >> To: Zhao Qiang-B45475 >> Cc: u-b

Re: [U-Boot] [PATCH 4/5] x86: Change coreboot default build configuration to QEMU

2015-05-05 Thread Simon Glass
On 5 May 2015 at 09:24, Bin Meng wrote: > QEMU is much easier for us test booting U-Boot as a coreboot payload > than having a real board like chromebook_link. > > Signed-off-by: Bin Meng > --- > > board/coreboot/coreboot/Kconfig | 6 +++--- > configs/coreboot-x86_defconfig | 1 + > 2 files cha

Re: [U-Boot] [PATCH 5/5] x86: Update README.x86 for QEMU support

2015-05-05 Thread Simon Glass
On 5 May 2015 at 09:24, Bin Meng wrote: > Document how to build and test U-Boot with QEMU. > > Signed-off-by: Bin Meng > --- > > doc/README.x86 | 65 > +++--- > 1 file changed, 48 insertions(+), 17 deletions(-) Acked-by: Simon Glass

Re: [U-Boot] [PATCH 2/5] x86: Make QEMU the default vendor

2015-05-05 Thread Simon Glass
On 5 May 2015 at 09:24, Bin Meng wrote: > Now that we have QEMU support, make it the default vendor in the > 'make menuconfig' screen. > > Signed-off-by: Bin Meng > --- > > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconf

Re: [U-Boot] [PATCH 1/5] x86: Support QEMU x86 targets

2015-05-05 Thread Simon Glass
Hi Bin, On 5 May 2015 at 09:24, Bin Meng wrote: > This commit introduces the initial U-Boot support for QEMU x86 targets. > U-Boot can boot from coreboot as a payload, or directly without coreboot. > > Signed-off-by: Bin Meng > --- > > arch/x86/Kconfig | 5 +++ > arch/x86/

[U-Boot] [PATCH] fsl/sata: Replace sprintf() with snprintf()

2015-05-05 Thread Yuantian.Tang
From: Tang Yuantian Function 'sprintf' does not check buffer boundaries but outputs to the buffer of fixed size which could potentially cause buffer overflow. Use a safer function to replace it. Signed-off-by: Tang Yuantian --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH] fsl/sata: Replace sprintf() with snprintf()

2015-05-05 Thread Yuantian.Tang
From: Tang Yuantian Function 'sprintf' does not check buffer boundaries but outputs to the buffer of fixed size which could cause buffer overflow. Use a safer function to replace it. Signed-off-by: Tang Yuantian --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH v2] dm: sf: Update default name of spi flash in structure udevice

2015-05-05 Thread Simon Glass
On 5 May 2015 at 20:37, Haikun Wang wrote: > Default name of spi flash like this "0:0", update it to "spi_flash@0:0". > > Signed-off-by: Haikun Wang > --- > > Changes in v2: > - Increase the size of array "name" to 30 > > Changes in v1: None > drivers/mtd/spi/sf-uclass.c | 4 ++-- > 1 file chang

Re: [U-Boot] [PATCH v3] dm: sf: Add Atmel DataFlash spi flash driver

2015-05-05 Thread Simon Glass
Hi, On 5 May 2015 at 05:10, Haikun Wang wrote: > Atmel DataFlash chips have commands different from common spi > flash commands. > Atmel DataFlash also have special page-size. > This driver add support for accessing Atmel DataFlash. > It is based on the Driver Model. > > Signed-off-by: Haikun Wan

[U-Boot] [PATCH v2] dm: sf: Update default name of spi flash in structure udevice

2015-05-05 Thread Haikun Wang
Default name of spi flash like this "0:0", update it to "spi_flash@0:0". Signed-off-by: Haikun Wang --- Changes in v2: - Increase the size of array "name" to 30 Changes in v1: None drivers/mtd/spi/sf-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/

Re: [U-Boot] Add spi nand support in u-boot

2015-05-05 Thread peterpandong
On 5 May 2015 at 16:105, Jagan Tek > On 4 May 2015 at 06:19, Peter Pan 潘栋 (peterpandong) > wrote: > > Hi All, > > > > I’d like to add spi nand support in u-boot. But I don’t know where > should > > the spi nand drivers put in and how to define the architecture. > > > > I find that currently spi_fl

Re: [U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy

2015-05-05 Thread qiang.z...@freescale.com
On Tue, May 5, 2015 at 5:41 PM, Michael Trimarchi wrote: > -Original Message- > From: Michael Trimarchi [mailto:mich...@amarulasolutions.com] > Sent: Tuesday, May 05, 2015 5:41 PM > To: Zhao Qiang-B45475 > Cc: u-boot@lists.denx.de; Sun York-R58495 > Subject: Re: [U-Boot] [PATCH 2/2] qe: us

Re: [U-Boot] Please pull u-boot-mpc85xx master

2015-05-05 Thread Tom Rini
On Tue, May 05, 2015 at 09:55:43AM -0700, York Sun wrote: > Tom, > > The following changes since commit ace97d26176a3ebc9ec07738450de93eea35975c: > > Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze (2015-04-29 > 06:46:33 -0400) > > are available in the git repository at: > >

Re: [U-Boot] Please pull u-boot-marvell master

2015-05-05 Thread Tom Rini
On Tue, May 05, 2015 at 12:50:01PM +, Luka Perkov wrote: > Hi Tom, > > please pull from marvell/master. The changes include Stefan's Armada 38x > series which reached v3 on the mailing list and two more Marvell Armada > related fixes. > > The following changes since commit ace97d26176a3ebc9e

Re: [U-Boot] fw_env.h: include autoconf.h

2015-05-05 Thread Tom Rini
On Tue, Apr 14, 2015 at 09:50:47PM +0200, Marcel Ziswiler wrote: > From: Max Krummenacher > > Without this, when CONFIG_ENV_VARS_UBOOT_CONFIG is active we get > a compile time error when doing 'make env'. > In file included from tools/env/fw_env.c:117:0: > include/env_default.h:110:11: error: ex

[U-Boot] [ANN] U-Boot v2015.07-rc1 released

2015-05-05 Thread Tom Rini
Hey all, I've pushed v2015.07-rc1 out to the repository and tarballs should exist soon. The merge window is now closed. I'm going to continue todo my best to keep to the every two weeks we do an RC thing, with probably a few days slip here and there. I think it's gone well so far relying on eve

Re: [U-Boot] Pull request: u-boot-mmc 05052015

2015-05-05 Thread Tom Rini
On Tue, May 05, 2015 at 12:44:10PM +0300, Pantelis Antoniou wrote: > Hi Tom, > > The following changes since commit ace97d26176a3ebc9ec07738450de93eea35975c: > > Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze (2015-04-29 > 06:46:33 -0400) > > are available in the git reposito

Re: [U-Boot] Pull request: u-boot-arm/master

2015-05-05 Thread Tom Rini
On Tue, May 05, 2015 at 11:30:11AM +0200, Albert ARIBAUD wrote: > Hello Tom, > > The following changes since commit ace97d26176a3ebc9ec07738450de93eea35975c: > > Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze (2015-04-29 > 06:46:33 -0400) > > are available in the git reposito

Re: [U-Boot] Please pull u-boot-x86

2015-05-05 Thread Tom Rini
On Fri, May 01, 2015 at 02:39:03PM -0600, Simon Glass wrote: > Hi Tom, > > This includes PIRQ routing support for a few platforms, the beginnings > of better GPIO/pinmux support and multi-core + SFI support. > > > The following changes since commit ace97d26176a3ebc9ec07738450de93eea35975c: > >

Re: [U-Boot] Please pull u-boot-sunxi master

2015-05-05 Thread Tom Rini
On Mon, May 04, 2015 at 05:21:29PM +0200, Hans de Goede wrote: > Hi Tom, > > Please pull u-boot-sunxi/master into master for the second round of sunxi > work, highlights: > > -A33 SoC support (full support including otg & display) > -Move ALL sunxi boards over to the driver-model for serial, gpi

Re: [U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

2015-05-05 Thread Joe Hershberger
Hi Simon, On Tue, May 5, 2015 at 3:56 PM, Simon Glass wrote: > Hi Joe, > > On 3 May 2015 at 14:12, Joe Hershberger wrote: >> Make sure that the env gets cleaned up after a test fails so that other >> tests aren't affected. >> >> Signed-off-by: Joe Hershberger >> --- >> >> Changes in v3: >> -New

Re: [U-Boot] [PATCH 09/16] usb: ohci: Fix ctrl in messages with a data-len of 0

2015-05-05 Thread Marek Vasut
On Wednesday, May 06, 2015 at 01:25:29 AM, Hans de Goede wrote: > Hi, > > On 05/06/2015 12:59 AM, Marek Vasut wrote: > > On Tuesday, May 05, 2015 at 11:56:12 PM, Hans de Goede wrote: > >> Fix taken from the Linux kernel ohci driver. > > > > Commit ID from Linux where this came from would be nice

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Marek Vasut
On Wednesday, May 06, 2015 at 12:57:54 AM, Stephen Warren wrote: > On 05/05/2015 04:42 PM, Marek Vasut wrote: > > On Wednesday, May 06, 2015 at 12:37:38 AM, Stephen Warren wrote: > >> On 05/05/2015 04:17 PM, Marek Vasut wrote: > >>> On Tuesday, May 05, 2015 at 11:46:56 PM, Stephen Warren wrote: > >

Re: [U-Boot] [PATCH 1/2] Fix inconsistency of VERIFY defines in cmd_mem

2015-05-05 Thread Joe Hershberger
Hi Simon, On Tue, May 5, 2015 at 4:37 PM, Simon Glass wrote: > Hi Joe, > > On 5 May 2015 at 11:23, Joe Hershberger wrote: >> >> Introduced in change d20a40de9db07de1f1f06a79a4da1cdda5379b75 >> "Roll crc32 into hash infrastructure" >> >> Use a consistent define to enable the verify feature in crc

Re: [U-Boot] [PATCH 09/16] usb: ohci: Fix ctrl in messages with a data-len of 0

2015-05-05 Thread Hans de Goede
Hi, On 05/06/2015 12:59 AM, Marek Vasut wrote: On Tuesday, May 05, 2015 at 11:56:12 PM, Hans de Goede wrote: Fix taken from the Linux kernel ohci driver. Commit ID from Linux where this came from would be nice to have in the commit message, but that's a minor thing. I did not take this from

Re: [U-Boot] [PATCH 15/16] usb: ohci: Add dm support

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:18 PM, Hans de Goede wrote: > Add driver-model support to the ohci code. > > Signed-off-by: Hans de Goede I'll leave thorough review of this to Simon, but a brief skim tells me to add Reviewed-by: Marek Vasut The "todo" in ohci_deregister() is a bit concerni

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Marek Vasut
On Wednesday, May 06, 2015 at 12:53:31 AM, Simon Glass wrote: > On 5 May 2015 at 16:52, Marek Vasut wrote: > > On Wednesday, May 06, 2015 at 12:50:08 AM, Hans de Goede wrote: > >> Hi, > > > > Hi! > > > >> On 05/06/2015 12:23 AM, Marek Vasut wrote: > >> > On Tuesday, May 05, 2015 at 11:56:03 PM,

Re: [U-Boot] [PATCH 16/16] sunxi: ohci: Add ohci usb host controller support

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:19 PM, Hans de Goede wrote: > This commit adds support for the OHCI companionen controller, which makes > usb-1 devices directly plugged into to usb root port work. > > Note for now this switches usb-keyboard support for sunxi back from > int-queue support to the

Re: [U-Boot] [PATCH 10/16] usb: ohci: Add proper cache flushing / invalidating for non cache coherent cpus

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:13 PM, Hans de Goede wrote: > Add proper cache flushing / invalidating for non cache coherent cpus, for > now only enable this for new (driver-model) usb code to avoid regressions. > > Signed-off-by: Hans de Goede Reviewed-by: Marek Vasut Best regards, Marek V

Re: [U-Boot] [PATCH 14/16] usb: ohci: Skip unnecessary mdelay(1) calls in various places

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:17 PM, Hans de Goede wrote: > For some reason the ohci code is full with: > > pkt_print(...) > mdelay(1); > > AFAICT there is no reason for the mdelay(1) calls. This commit disables > them when building the ohci code for new driver-mod

Re: [U-Boot] [PATCH 13/16] usb: ohci: Remove unnecessary delays from hc_start and power power-on paths

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:16 PM, Hans de Goede wrote: > The common usb_hub code already waits a full second after powering up > ports, so there is no need for additional delays inside the hcd code. > > Signed-off-by: Hans de Goede This makes a driver depend on the behavior of the subsyst

Re: [U-Boot] [PATCH 12/16] usb: ohci: Do not resubmit and leak urbs for interrupt packets

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:15 PM, Hans de Goede wrote: > Auto-resubmission of interrupt packets does not match the u-boot usb model. Just a bit more verbose commit message would be helpful, really ;-) > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut __

Re: [U-Boot] [PATCH 11/16] usb: ohci: Don't log an error on interrupt packet timeout

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:14 PM, Hans de Goede wrote: > Interrupts transfers timing out is normal, so do not log an error for this. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH 05/16] usb: ohci: Move the ohci_dev struct to inside the main ohci struct

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:08 PM, Hans de Goede wrote: > This is a preparation patch for adding driver-model support. > > Note we do keep ohci_dev as a separate struct so that we can later add > support for interrupt-queues which requires allocating a separate ohci_dev > per interrupt-queue

Re: [U-Boot] [PATCH 08/16] usb: ohci: Move static func and var declarations from ohci.h to ohci-hcd.c

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:11 PM, Hans de Goede wrote: > Non static function and variable declarations do not belong in a .h file. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@

Re: [U-Boot] [PATCH 09/16] usb: ohci: Fix ctrl in messages with a data-len of 0

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:12 PM, Hans de Goede wrote: > Fix taken from the Linux kernel ohci driver. Commit ID from Linux where this came from would be nice to have in the commit message, but that's a minor thing. > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Mare

Re: [U-Boot] [PATCH 06/16] usb: ohci: Move the td array struct to inside the ohci_dev struct

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:09 PM, Hans de Goede wrote: > This is a preparation patch for adding driver-model support. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 07/16] usb: ohci: Remove unnecessary phcca variable

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:10 PM, Hans de Goede wrote: > This is a preparation patch for adding driver-model support. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 04/16] usb: ohci: Pass around a pointer to ohci_t rather then accessing global vars

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:07 PM, Hans de Goede wrote: > This is a preparation patch for adding driver-model support. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Stephen Warren
On 05/05/2015 04:42 PM, Marek Vasut wrote: On Wednesday, May 06, 2015 at 12:37:38 AM, Stephen Warren wrote: On 05/05/2015 04:17 PM, Marek Vasut wrote: On Tuesday, May 05, 2015 at 11:46:56 PM, Stephen Warren wrote: On 05/04/2015 02:54 PM, Marek Vasut wrote: Switch to generic timer implementati

Re: [U-Boot] [PATCH 01/16] usb: Fix maxpacketsize for first descriptor read for low-speed usb devs

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:04 PM, Hans de Goede wrote: > This fixes descriptor reading of lowspeed devices through ohci not working. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH 03/16] usb: ohci: Remove unused devgone global variable

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:06 PM, Hans de Goede wrote: > devgone is never assigned a value, so the one comparisson reading it will > never be true, and devgone can be completely removed. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___

Re: [U-Boot] [PATCH 02/16] usb: Stop reset procedure when a dev is handed over to a companion hcd

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:05 PM, Hans de Goede wrote: > Do not try to reset a device 5 times when it is handed over to a companion > controller, also do not print an error when it has been handed over. > > Signed-off-by: Hans de Goede Acked-by: Marek Vasut Best regards, Marek Vasut ___

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Simon Glass
On 5 May 2015 at 16:52, Marek Vasut wrote: > On Wednesday, May 06, 2015 at 12:50:08 AM, Hans de Goede wrote: >> Hi, > > Hi! > >> On 05/06/2015 12:23 AM, Marek Vasut wrote: >> > On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: >> >> Hi Marek and Simon, >> > >> > Hi! >> > >> >> Here is

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 16:50, Hans de Goede wrote: > Hi, > > > On 05/06/2015 12:23 AM, Marek Vasut wrote: >> >> On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: >>> >>> Hi Marek and Simon, >> >> >> Hi! >> >>> Here is a series with a few usb core fixes, a lot of ohci fixes and ohci

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Marek Vasut
On Wednesday, May 06, 2015 at 12:50:08 AM, Hans de Goede wrote: > Hi, Hi! > On 05/06/2015 12:23 AM, Marek Vasut wrote: > > On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: > >> Hi Marek and Simon, > > > > Hi! > > > >> Here is a series with a few usb core fixes, a lot of ohci fixes

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Hans de Goede
Hi, On 05/06/2015 12:23 AM, Marek Vasut wrote: On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: Hi Marek and Simon, Hi! Here is a series with a few usb core fixes, a lot of ohci fixes and ohci dm support (tested on sunxi). This series sits on top of the series adding companion

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Marek Vasut
On Wednesday, May 06, 2015 at 12:37:38 AM, Stephen Warren wrote: > On 05/05/2015 04:17 PM, Marek Vasut wrote: > > On Tuesday, May 05, 2015 at 11:46:56 PM, Stephen Warren wrote: > >> On 05/04/2015 02:54 PM, Marek Vasut wrote: > >>> Switch to generic timer implementation from lib/time.c . > >>> This

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Stephen Warren
On 05/05/2015 04:17 PM, Marek Vasut wrote: On Tuesday, May 05, 2015 at 11:46:56 PM, Stephen Warren wrote: On 05/04/2015 02:54 PM, Marek Vasut wrote: Switch to generic timer implementation from lib/time.c . This also fixes a signed overflow which was in __udelay() implementation. Can you expla

Re: [U-Boot] [PATCH 3/5] dm: usb: Do not scan companion busses if no devices where handed over

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 16:14, Hans de Goede wrote: > Hi, > > > On 05/05/2015 11:46 PM, Simon Glass wrote: >> >> Hi Hans, >> >> On 5 May 2015 at 07:28, Hans de Goede wrote: >>> >>> USB scanning is slow, and there is no need to scan the companion busses >>> if no usb devices where handed over t

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Simon Glass
Hi Marek, On 5 May 2015 at 16:23, Marek Vasut wrote: > On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: >> Hi Marek and Simon, > > Hi! > >> Here is a series with a few usb core fixes, a lot of ohci fixes and ohci >> dm support (tested on sunxi). This series sits on top of the series

Re: [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:56:03 PM, Hans de Goede wrote: > Hi Marek and Simon, Hi! > Here is a series with a few usb core fixes, a lot of ohci fixes and ohci > dm support (tested on sunxi). This series sits on top of the series adding > companion controller support to the dm usb code and 2 e

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Marek Vasut
On Tuesday, May 05, 2015 at 11:46:56 PM, Stephen Warren wrote: > On 05/04/2015 02:54 PM, Marek Vasut wrote: > > Switch to generic timer implementation from lib/time.c . > > This also fixes a signed overflow which was in __udelay() > > implementation. > > Can you explain that a bit more? > > > -vo

Re: [U-Boot] [PATCH 3/5] dm: usb: Do not scan companion busses if no devices where handed over

2015-05-05 Thread Hans de Goede
Hi, On 05/05/2015 11:46 PM, Simon Glass wrote: Hi Hans, On 5 May 2015 at 07:28, Hans de Goede wrote: USB scanning is slow, and there is no need to scan the companion busses if no usb devices where handed over to the companinon controllers by any of the main controllers. This saves e.g. 2 sec

Re: [U-Boot] [PATCH 2/5] dm: usb: Add support for companion controllers

2015-05-05 Thread Hans de Goede
Hi Simon, On 05/05/2015 11:46 PM, Simon Glass wrote: Hi Hans, On 5 May 2015 at 07:28, Hans de Goede wrote: USB companion controllers must be scanned after the main controller has been scanned, so that any devices which the main controller which to hand over to the companion have actually been

[U-Boot] [PATCH 14/16] usb: ohci: Skip unnecessary mdelay(1) calls in various places

2015-05-05 Thread Hans de Goede
For some reason the ohci code is full with: pkt_print(...) mdelay(1); AFAICT there is no reason for the mdelay(1) calls. This commit disables them when building the ohci code for new driver-model using boards. It leaves the mdelay(1) calls in place when building fo

[U-Boot] [PATCH 10/16] usb: ohci: Add proper cache flushing / invalidating for non cache coherent cpus

2015-05-05 Thread Hans de Goede
Add proper cache flushing / invalidating for non cache coherent cpus, for now only enable this for new (driver-model) usb code to avoid regressions. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 67 + drivers/usb/host/ohci.h | 22 +

[U-Boot] [PATCH 16/16] sunxi: ohci: Add ohci usb host controller support

2015-05-05 Thread Hans de Goede
This commit adds support for the OHCI companionen controller, which makes usb-1 devices directly plugged into to usb root port work. Note for now this switches usb-keyboard support for sunxi back from int-queue support to the old interrupt polling method. Adding int-queue support to the ohci code

[U-Boot] [PATCH 12/16] usb: ohci: Do not resubmit and leak urbs for interrupt packets

2015-05-05 Thread Hans de Goede
Auto-resubmission of interrupt packets does not match the u-boot usb model. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 41 ++--- 1 file changed, 2 insertions(+), 39 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/o

[U-Boot] [PATCH 11/16] usb: ohci: Don't log an error on interrupt packet timeout

2015-05-05 Thread Hans de Goede
Interrupts transfers timing out is normal, so do not log an error for this. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 3744658..494b760 100644 -

[U-Boot] [PATCH 13/16] usb: ohci: Remove unnecessary delays from hc_start and power power-on paths

2015-05-05 Thread Hans de Goede
The common usb_hub code already waits a full second after powering up ports, so there is no need for additional delays inside the hcd code. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/us

[U-Boot] [PATCH 15/16] usb: ohci: Add dm support

2015-05-05 Thread Hans de Goede
Add driver-model support to the ohci code. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 84 + drivers/usb/host/ohci.h | 7 2 files changed, 91 insertions(+) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-h

[U-Boot] [PATCH 09/16] usb: ohci: Fix ctrl in messages with a data-len of 0

2015-05-05 Thread Hans de Goede
Fix taken from the Linux kernel ohci driver. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 15aea98..02aa7f3 100644 --- a/drivers/usb/host/ohci-hcd.c

[U-Boot] [PATCH 08/16] usb: ohci: Move static func and var declarations from ohci.h to ohci-hcd.c

2015-05-05 Thread Hans de Goede
Non static function and variable declarations do not belong in a .h file. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 86 + drivers/usb/host/ohci.h | 93 - 2 files changed, 86 insertions(+)

[U-Boot] [PATCH 03/16] usb: ohci: Remove unused devgone global variable

2015-05-05 Thread Hans de Goede
devgone is never assigned a value, so the one comparisson reading it will never be true, and devgone can be completely removed. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/o

[U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support

2015-05-05 Thread Hans de Goede
Hi Marek and Simon, Here is a series with a few usb core fixes, a lot of ohci fixes and ohci dm support (tested on sunxi). This series sits on top of the series adding companion controller support to the dm usb code and 2 ehci fixes which I send earlier today. Regards, Hans _

[U-Boot] [PATCH 01/16] usb: Fix maxpacketsize for first descriptor read for low-speed usb devs

2015-05-05 Thread Hans de Goede
This fixes descriptor reading of lowspeed devices through ohci not working. Signed-off-by: Hans de Goede --- common/usb.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/common/usb.c b/common/usb.c index 48f0780..4a09583 100644 --- a/common/usb.c +++ b/comm

[U-Boot] [PATCH 07/16] usb: ohci: Remove unnecessary phcca variable

2015-05-05 Thread Hans de Goede
This is a preparation patch for adding driver-model support. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index b5676ab..07e0848 100644 --- a/dri

[U-Boot] [PATCH 02/16] usb: Stop reset procedure when a dev is handed over to a companion hcd

2015-05-05 Thread Hans de Goede
Do not try to reset a device 5 times when it is handed over to a companion controller, also do not print an error when it has been handed over. Signed-off-by: Hans de Goede --- common/usb_hub.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/common/usb_hub.c b/c

[U-Boot] [PATCH 06/16] usb: ohci: Move the td array struct to inside the ohci_dev struct

2015-05-05 Thread Hans de Goede
This is a preparation patch for adding driver-model support. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 10 ++ drivers/usb/host/ohci.h | 19 +++ 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/u

[U-Boot] [PATCH 05/16] usb: ohci: Move the ohci_dev struct to inside the main ohci struct

2015-05-05 Thread Hans de Goede
This is a preparation patch for adding driver-model support. Note we do keep ohci_dev as a separate struct so that we can later add support for interrupt-queues which requires allocating a separate ohci_dev per interrupt-queue. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 22 +

[U-Boot] [PATCH 04/16] usb: ohci: Pass around a pointer to ohci_t rather then accessing global vars

2015-05-05 Thread Hans de Goede
This is a preparation patch for adding driver-model support. Signed-off-by: Hans de Goede --- drivers/usb/host/ohci-hcd.c | 124 +++- 1 file changed, 64 insertions(+), 60 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c

Re: [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer

2015-05-05 Thread Stephen Warren
On 05/04/2015 02:54 PM, Marek Vasut wrote: Switch to generic timer implementation from lib/time.c . This also fixes a signed overflow which was in __udelay() implementation. Can you explain that a bit more? -void __udelay(unsigned long usec) -{ - ulong endtime; - signed long diff;

Re: [U-Boot] [PATCH 3/5] dm: usb: Do not scan companion busses if no devices where handed over

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 07:28, Hans de Goede wrote: > USB scanning is slow, and there is no need to scan the companion busses > if no usb devices where handed over to the companinon controllers by any > of the main controllers. > > This saves e.g. 2 seconds when booting a A10 OLinuxIno Lime wit

Re: [U-Boot] [PATCH 2/5] dm: usb: Add support for companion controllers

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 07:28, Hans de Goede wrote: > USB companion controllers must be scanned after the main controller has > been scanned, so that any devices which the main controller which to hand > over to the companion have actually been handed over before we scan the > companion. > > As

Re: [U-Boot] [PATCH 1/5] dm: usb: Move printing of usb scan status to usb_scan_bus()

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 07:28, Hans de Goede wrote: > Move printing of usb scan status to usb_scan_bus(). > > This is a preparation patch for adding companion controller support to the > usb uclass. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/usb-uclass.c | 22 +-

Re: [U-Boot] [PATCH v4 9/9] sunxi: ehci: Convert to the driver-model

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 15:37, Hans de Goede wrote: > Hi, > > > On 05/05/2015 11:06 PM, Simon Glass wrote: >> >> Hi Hans, >> >> On 5 May 2015 at 11:42, Simon Glass wrote: >>> >>> On 5 May 2015 at 03:54, Hans de Goede wrote: Convert sunxi-boards which use the sunxi-ehci code to the d

Re: [U-Boot] [PATCH 1/2] Fix inconsistency of VERIFY defines in cmd_mem

2015-05-05 Thread Simon Glass
Hi Joe, On 5 May 2015 at 11:23, Joe Hershberger wrote: > > Introduced in change d20a40de9db07de1f1f06a79a4da1cdda5379b75 > "Roll crc32 into hash infrastructure" > > Use a consistent define to enable the verify feature in crc32 command. > > Signed-off-by: Joe Hershberger > --- > > common/cmd_mem

Re: [U-Boot] [PATCH v4 9/9] sunxi: ehci: Convert to the driver-model

2015-05-05 Thread Hans de Goede
Hi, On 05/05/2015 11:06 PM, Simon Glass wrote: Hi Hans, On 5 May 2015 at 11:42, Simon Glass wrote: On 5 May 2015 at 03:54, Hans de Goede wrote: Convert sunxi-boards which use the sunxi-ehci code to the driver-model. Signed-off-by: Hans de Goede Acked-by: Simon Glass --- Changes in v4: -A

Re: [U-Boot] [PATCH 2/2] Fix broken verify functionality in crc32 command

2015-05-05 Thread Simon Glass
On 5 May 2015 at 11:23, Joe Hershberger wrote: > Introduced in change d20a40de9db07de1f1f06a79a4da1cdda5379b75 > "Roll crc32 into hash infrastructure" > > The crc32 command with no -v expects an optional 3rd argument to be an > address to store the result in. With the -v switch, the last argument

[U-Boot] [PATCH 2/5] tbs2910: only enable vga output for stdout/stderr when hdmi detected

2015-05-05 Thread Soeren Moch
Only enable graphical output for stdout/stderr (and a usb keyboard for stdin) when a hdmi device is detected. Serial console is always enabled for stdin/stdout/stderr. Signed-off-by: Soeren Moch --- Cc: Stefano Babic --- include/configs/tbs2910.h | 17 + 1 file changed, 13 inser

[U-Boot] [PATCH 4/5] tbs2910: add CONFIG_SUPPORT_EMMC_BOOT

2015-05-05 Thread Soeren Moch
Add emmc boot partition commands to be able to select the boot partition. Signed-off-by: Soeren Moch --- Cc: Stefano Babic --- include/configs/tbs2910.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 9efb8c2..1f3c3d8 100644 --- a/

[U-Boot] [PATCH 5/5] tbs2910: add ext4 write support

2015-05-05 Thread Soeren Moch
Add CONFIG_CMD_EXT4_WRITE to enable ext4 write support. Signed-off-by: Soeren Moch --- Cc: Stefano Babic --- include/configs/tbs2910.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 1f3c3d8..d0d6a30 100644 --- a/include/configs/tb

[U-Boot] [PATCH 3/5] tbs2910: use default CONFIG_SYS_PBSIZE

2015-05-05 Thread Soeren Moch
Since there is a default CONFIG_SYS_PBSIZE definition in config_fallbacks.h, this setting is no longer required in board configurations. Signed-off-by: Soeren Moch --- Cc: Stefano Babic --- include/configs/tbs2910.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/tbs2910.h

[U-Boot] [PATCH 1/5] tbs2910: support for usb otg host mode

2015-05-05 Thread Soeren Moch
Add support for USB OTG host mode. Only high speed devices supported so far (e.g. usb 2.0 hub required to connect a keyboard). Signed-off-by: Soeren Moch --- Cc: Stefano Babic --- board/tbs/tbs2910/tbs2910.c | 10 ++ include/configs/tbs2910.h | 1 + 2 files changed, 11 insertions(+)

Re: [U-Boot] [PATCH v4 9/9] sunxi: ehci: Convert to the driver-model

2015-05-05 Thread Simon Glass
Hi Hans, On 5 May 2015 at 11:42, Simon Glass wrote: > On 5 May 2015 at 03:54, Hans de Goede wrote: >> Convert sunxi-boards which use the sunxi-ehci code to the driver-model. >> >> Signed-off-by: Hans de Goede >> Acked-by: Simon Glass >> --- >> Changes in v4: >> -Add a comment to document the s

Re: [U-Boot] [PATCH v1 1/2] cmd_sf: Add command "sf info" to show current device info

2015-05-05 Thread Simon Glass
On 5 May 2015 at 05:37, haikun.w...@freescale.com wrote: > On 5/1/2015 9:54 AM, Simon Glass wrote: >> Hi, >> >> On 29 April 2015 at 04:40, Haikun Wang wrote: >>> Add command "sf info" to show the information of the current SPI flash >>> device. >>> >>> Signed-off-by: Haikun Wang >>> --- >>> In

Re: [U-Boot] [PATCH v3 24/26] test: dm: Move the dm tests over to the ut command

2015-05-05 Thread Simon Glass
On 3 May 2015 at 14:13, Joe Hershberger wrote: > Unify the command for running unit tests further by moving the "dm test" > command over to "ut dm". > > Signed-off-by: Joe Hershberger > --- > > Changes in v3: > -New for version 3 > > Changes in v2: None > > arch/sandbox/Kconfig | 5 - > in

Re: [U-Boot] [PATCH v3 20/26] test: dm: Recover the driver model tree after tests

2015-05-05 Thread Simon Glass
On 3 May 2015 at 14:12, Joe Hershberger wrote: > Put the driver model for the system back into a good state after > completing the DM testing. > > Signed-off-by: Joe Hershberger > --- > > Changes in v3: > -New for version 3 > > Changes in v2: None > > test/dm/test-main.c | 5 + > 1 file chan

Re: [U-Boot] [PATCH v3 16/26] test: Move the unit tests to their own menu

2015-05-05 Thread Simon Glass
On 3 May 2015 at 14:12, Joe Hershberger wrote: > Make all unit tests selectable as a menu of test suites instead of just > sitting in the top-level menu individually. > > Signed-off-by: Joe Hershberger > --- > > Changes in v3: > -New for version 3 > > Changes in v2: None > > test/Kconfig| 7

Re: [U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

2015-05-05 Thread Simon Glass
Hi Joe, On 3 May 2015 at 14:12, Joe Hershberger wrote: > Make sure that the env gets cleaned up after a test fails so that other > tests aren't affected. > > Signed-off-by: Joe Hershberger > --- > > Changes in v3: > -New for version 3 > > Changes in v2: None > > test/dm/eth.c | 79 > ++

Re: [U-Boot] [PATCH V3] i2c: mxc: refactor i2c driver and support dm

2015-05-05 Thread Simon Glass
On 27 April 2015 at 07:36, Peng Fan wrote: > > 1. Introduce a new structure `struct mxc_i2c_bus`, this structure will >used for non-DM and DM. > 2. Remove `struct mxc_i2c_regs` structure, but use register offset to access >registers based on `base` entry of `struct mxc_i2c_bus`. > 3. Remov

Re: [U-Boot] [PATCH v3 15/26] test: Add a common unit test command

2015-05-05 Thread Simon Glass
On 3 May 2015 at 14:12, Joe Hershberger wrote: > Add a command that all other unit tests should be a sub-command of. > Also include a command that will run all tests. > > Signed-off-by: Joe Hershberger > --- > > Changes in v3: > -New for version 3 > > Changes in v2: None > > include/test/suites.

[U-Boot] [PATCH v3 5/6] serial: stm32: add stm32f1 support

2015-05-05 Thread Matt Porter
Add support for the STM32F1 famly to the STM32 serial driver. Signed-off-by: Matt Porter --- v3: - Update copyright notice v2: - Explicitly check for F4/F1 family and error if not set to a supported STM32 family. drivers/serial/serial_stm32.c | 10 ++ 1 file ch

  1   2   3   >