Re: [U-Boot] [PATCH 09/55] exynos: i2c: Fix code style with ReadWriteByte()

2015-07-04 Thread Heiko Schocher
Hello Simon, Am 03.07.2015 um 02:15 schrieb Simon Glass: This function should not use mixed case, and it is simpler to use clrbits_le32() when clearing bits. Fix it. Signed-off-by: Simon Glass --- drivers/i2c/s3c24x0_i2c.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-

Re: [U-Boot] [PATCH 08/55] i2c: Add a mux for GPIO-based I2C bus arbitration

2015-07-04 Thread Heiko Schocher
Hello Simon, Am 03.07.2015 um 02:15 schrieb Simon Glass: While I2C supports multi-master buses this is difficult to get right. This What do you mean here? Where are the problems? You have an i2c mux, or? driver provides a scheme based on two 'claim' GPIOs, one driven by the AP and one driver

Re: [U-Boot] [PATCH 07/55] exynos: i2c: Correct bug in pinmux selection

2015-07-04 Thread Heiko Schocher
Hello Simon, Am 03.07.2015 um 02:15 schrieb Simon Glass: When driver model is not used the current code does not correctly select the pinmux for the I2C bus. This bug was introduced by this commit: 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api Signed-off-by: Simon Glass --- drivers/i2c/s3

Re: [U-Boot] [PATCH 06/55] dm: i2c: Add support for multiplexed I2C buses

2015-07-04 Thread Heiko Schocher
Hello Simon, Am 03.07.2015 um 02:15 schrieb Simon Glass: Add a new I2C_MUX uclass. Devices in this class can multiplex between several I2C buses, selecting them one at a time for use by the system. The multiplexing mechanism is left to the driver to decide - it may be controlled by GPIOs, for ex

Re: [U-Boot] [PATCH] mtd: fix false positive "Offset exceeds device limit" error

2015-07-04 Thread Heiko Schocher
Hello Masahiro, Am 04.07.2015 um 19:07 schrieb Masahiro Yamada: Hey, quick review and apply please? NAND commands are not working! 2015-07-01 21:35 GMT+09:00 Masahiro Yamada : Since commit 09c3280754f8 (mtd, nand: Move common functions from cmd_nand.c to common place), NAND commands would

Re: [U-Boot] [PATCH 19/55] dm: gpio: Add support for setting a GPIO's pull direction

2015-07-04 Thread Masahiro Yamada
Hi Simon, 2015-07-03 9:15 GMT+09:00 Simon Glass : > At present the driver model GPIO API does not support pull-up/pull-down on > input GPIOs. This is required in some cases. > > Add this feature to the API with two new methods that drivers can optionally > implement. > > Signed-off-by: Simon Glas

Re: [U-Boot] [PATCH] mtd: fix false positive "Offset exceeds device limit" error

2015-07-04 Thread Masahiro Yamada
Hey, quick review and apply please? NAND commands are not working! 2015-07-01 21:35 GMT+09:00 Masahiro Yamada : > Since commit 09c3280754f8 (mtd, nand: Move common functions from > cmd_nand.c to common place), NAND commands would not work at all > on large devices. > > => nand read 800

[U-Boot] [PATCH 1/4] kconfig: sync with Linux 4.1

2015-07-04 Thread Masahiro Yamada
Update the files under scripts/kconfig/ to match Linux 4.1. Some Kconfig sources have diverged from those in the kernel, so commit-base syncing was done not to lose U-Boot specific updates. The commits cherry-picked from Linux are: [1] commit be8af2d54a66911693eddc556e4f7a866670082b Author: B

[U-Boot] [PATCH 3/4] kbuild: do not add $((generic-)offsets-file) to targets

2015-07-04 Thread Masahiro Yamada
$(always) is added to targets by scripts/Makefile.build. Moreover, filechk does not need .*.cmd files. Adding these two files to targets is redundant. Signed-off-by: Masahiro Yamada --- Kbuild | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Kbuild b/Kbuild index 465b930..

[U-Boot] [PATCH 0/4] kbuild & kconfig: sync with Linux 4.1

2015-07-04 Thread Masahiro Yamada
These change sets have been imported from Linux. This series should not change any boards. Masahiro Yamada (4): kconfig: sync with Linux 4.1 kbuild: sync with Linux 4.1 kbuild: do not add $((generic-)offsets-file) to targets kbuild: use relative path more to include Makefile Kbuild

[U-Boot] [PATCH 4/4] kbuild: use relative path more to include Makefile

2015-07-04 Thread Masahiro Yamada
Prior to this commit, it was impossible to use relative path to include Makefiles from the top level Makefile because the option "--include-dir=$(srctree)" becomes effective when Make enters into sub Makefiles. To use relative path in any places, this commit moves the option above the "sub-make" t

[U-Boot] [PATCH 2/4] kbuild: sync with Linux 4.1

2015-07-04 Thread Masahiro Yamada
Update some build scripts to match Linux 4.1. Commit-based syncing was done so as not to break U-Boot specific changes. The previous big sync was from Linux 3.18-rc1 by commit 176d09827725 (kbuild: sync misc scripts with Linux 3.18-rc1). The commits imported from Linux (some with adjustments) are

Re: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-04 Thread Jagan Teki
On 4 July 2015 at 18:23, R, Vignesh wrote: > > > On 7/3/2015 7:27 PM, Andy Pont wrote: >> Vignesh wrote... >> >> [snip] >> >>> +#define BIT(x) (1 << (x)) >>> + >> >> Is this not something that would be better in a global header file somewhere >> rather than it

Re: [U-Boot] [PATCH] net/designware: revert MAC-address setup on init

2015-07-04 Thread Alexey Brodkin
Hi Joe, On Wed, 2015-07-01 at 18:02 -0400, Tom Rini wrote: > On Wed, Jul 01, 2015 at 10:26:21AM -0500, Joe Hershberger wrote: > > Hi Alexey, > > > > On Wed, Jul 1, 2015 at 9:25 AM, Alexey Brodkin > > wrote: > > > Hi Tom, Joe, > > > > > > On Wed, 2015-07-01 at 22:22 +0800, Bin Meng wrote: > > >

Re: [U-Boot] [PATCH v2 1/4] usb: USB download gadget and functions config options coherent naming

2015-07-04 Thread Paul Kocialkowski
Le vendredi 12 juin 2015 à 19:56 +0200, Paul Kocialkowski a écrit : > This introduces a coherent scheme for naming USB download gadget and functions > config options. The download USB gadget config option is moved to > CONFIG_USB_GADGET_DOWNLOAD for better consistency with other gadgets and each >

[U-Boot] [PATCH 1/2] usb: gadget: fastboot: Request status and length check in rx handler

2015-07-04 Thread Paul Kocialkowski
This avoids handling requests that have an error status or no data. In particular, this avoids showing unnecessary error messages when the USB gadget gets disconnected (e.g. with fastboot continue) and the fastboot USB gadget driver sends an error back to the host (that has disconnected already).

[U-Boot] [PATCH 2/2] usb: gadget: fastboot: Dequeue the previous IN request for the current request

2015-07-04 Thread Paul Kocialkowski
Recent versions of the fastboot tool will query the partition type before doing an operation on a partition (such as erase, flash, etc). It will then submit the operation as soon as the response for the partition type is received. Usually, the MUSB controller will see that the partition type reque

Re: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-04 Thread R, Vignesh
On 7/3/2015 7:27 PM, Andy Pont wrote: > Vignesh wrote... > > [snip] > >> +#define BIT(x) (1 << (x)) >> + > > Is this not something that would be better in a global header file somewhere > rather than it starting a trend of a per-driver, per-arch, etc. defi

Re: [U-Boot] [PATCH 08/11] spi: ti_qspi: Use DMA to read from qspi flash

2015-07-04 Thread R, Vignesh
On 7/3/2015 5:12 PM, Tom Rini wrote: > On Fri, Jul 03, 2015 at 04:46:10PM +0530, Vignesh R wrote: > >> ti_qspi uses memory map mode for faster read. Enabling DMA will increase >> read speed by 3x @48MHz on DRA74 EVM. >> >> Signed-off-by: Vignesh R > > This ignores the feedback from > http://li

[U-Boot] [PATCH] cmd_fdt: save fdtaddr in hex format

2015-07-04 Thread Sudeep Holla
Commit 90fbee3e4051 ("cmd_fdt: Actually fix fdt command in sandbox") changed the format(from hex address to unsigned long) in which "fdtaddr" is saved . However do_fdt continues reads the "fdtaddr" assuming it to be in hex format. This may lead to fdt being either loaded or attempted to load at err

Re: [U-Boot] Pull request: u-boot-spi/master

2015-07-04 Thread Tom Rini
On Sat, Jul 04, 2015 at 02:11:35PM +0530, Jagan Teki wrote: > Hi Tom, > > Please pull this PR. > > thanks! > Jagan. > > The following changes since commit 891b487098ee2169a16b1bbb354aaef28aa90630: > > Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-07-01 15:38:12 > -0400) > > ar

[U-Boot] [PATCH 2/5] arm1176/cpu: Add icache and dcache support

2015-07-04 Thread Alexander Stein
The code is copied 1:1 from arm1136 which uses the same cp15 registers. Signed-off-by: Alexander Stein --- arch/arm/cpu/arm1176/cpu.c | 97 ++ 1 file changed, 97 insertions(+) diff --git a/arch/arm/cpu/arm1176/cpu.c b/arch/arm/cpu/arm1176/cpu.c index

[U-Boot] [PATCH 3/5] arm1176/cpu: Align cache flushing addresses to cacheline size

2015-07-04 Thread Alexander Stein
cache flushing addresses must be cacheline size aligned, so mask the start and stop address appropriately. Signed-off-by: Alexander Stein --- arch/arm/cpu/arm1176/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/cpu/arm1176/cpu.c b/arch/arm/cpu/arm1176/cpu.c index 2ff0e2

[U-Boot] [PATCH 4/5] arm/mach-bcm283x/mbox: Flush and invalidate dcache when using fw mailbox

2015-07-04 Thread Alexander Stein
When using dcache the setup data for the mailbox must be actually written into memory before calling into firmware. Thus flush and invalidate the memory. Signed-off-by: Alexander Stein --- arch/arm/mach-bcm283x/mbox.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-bcm283

[U-Boot] [PATCH 1/5] arm1176/cpu: Match cache_flush to arm1136

2015-07-04 Thread Alexander Stein
This is effectively the same code but it also does a clean cache before invalidating and doing a memory barrier. Signed-off-by: Alexander Stein --- arch/arm/cpu/arm1176/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/cpu/arm1176/cpu.c b/arch/arm/cpu/

[U-Boot] [PATCH 0/5] dcache support for Raspberry Pi 1

2015-07-04 Thread Alexander Stein
This patchset enables dcache support for Raspberry Pi 1. First the cache support code was made similar to existing arm1136 code. The invalidate and flush functions were inprovoed to accept also non-cacheline aligned addresses. This reduces the cacheline size knowledge from generic code. Then rpi ma

[U-Boot] [PATCH 5/5] arm/rpi: Enable dcache

2015-07-04 Thread Alexander Stein
Now that mailbox driver supports cache flush and invalidation, we can enable dcache. Signed-off-by: Alexander Stein --- include/configs/rpi-common.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/rpi-common.h b/include/configs/rpi-common.h index 1012cdd..dd638c4 100644 --- a/

Re: [U-Boot] [PATCH v2 0/8] JFFS2 fixes and performance improvements

2015-07-04 Thread Chris Packham
Mark, On Wed, Jul 1, 2015 at 4:38 PM, Mark Tomlinson wrote: > > In reply to comments from Wolfgang Denk and Heiko Schocher: I think you forgot to Cc Wolfgang and Heiko on this. Ditto with the updated patches Heiko reviewed from v1. > My aim was to optimize U-Boot's loading of a JFFS2 file, sinc

[U-Boot] Pull request: u-boot-spi/master

2015-07-04 Thread Jagan Teki
Hi Tom, Please pull this PR. thanks! Jagan. The following changes since commit 891b487098ee2169a16b1bbb354aaef28aa90630: Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-07-01 15:38:12 -0400) are available in the git repository at: git://git.denx.de/u-boot-spi.git master for

Re: [U-Boot] New sunxi board: Lamobo Bananapi R1

2015-07-04 Thread Hans de Goede
Hi Fabioca, On 15-06-15 15:17, fabioca wrote: Please find patch below. I indicated as maintainer name Hans The Goede, as he his the maintainer of all other sunxi boards. Hope that was the correct thing to do. For the next version of this patch please set the MAINTAINERS entry to yourself, I do