Re: [U-Boot] [PATCH v2 01/13] include: Add log2 header from the kernel

On 24 October 2015 at 20:56, Fabio Estevam wrote: > From: Fabio Estevam > > Use the log2 header files from the kernel. > > Imported from kernel 4.2.3. > > Signed-off-by: Fabio Estevam > Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 06/21] sf: Update status reg check in spi_flash_cmd_wait_ready

On 12 October 2015 at 20:30, Jagan Teki wrote: > Current flash wait_ready logic is not modular to add new > register status check, hence updated the status check for > adding few more register checks in future. > > Below are the sf speed runs with 'sf update' on whole flash,

Re: [U-Boot] [PATCH v4 07/21] sf: Add FSR support to spi_flash_cmd_wait_ready

On 12 October 2015 at 20:31, Jagan Teki wrote: > This patch adds flag status register reading support to > spi_flash_cmd_wait_ready. > > Signed-off-by: Jagan Teki > Cc: Simon Glass > Cc: Marek Vasut > Cc: Michal Simek

[U-Boot] [PATCH 3/5] driver: usb: Fix pointer conversion warnings for hikey

Fix below compilation warings happening for hikey_defconfig drivers/usb/eth/smsc95xx.c:698:56: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] debug("** %s(), len %d, buf %#x\n", __func__, length, (int)msg);

[U-Boot] [PATCH 4/5] driver: net: Fix pointer conversion warnings for xilinx_zynqmp_ep

Fix below warnings happening for xilinx_zynqmp_ep_defconfig drivers/net/zynq_gem.c: In function ‘zynq_gem_init’: drivers/net/zynq_gem.c:330:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ((u32)(priv->rxbuffers) + ^ In file included from

[U-Boot] [PATCH 5/5] driver: USB: Fix pointer conversion warnings for xilinx_zynqmp_ep

Fix below warnings happening for xilinx_zynqmp_ep_defconfig drivers/usb/dwc3/core.c: In function ‘dwc3_setup_scratch_buffers’: drivers/usb/dwc3/core.c:284:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] dma_unmap_single((void *)dwc->scratch_addr,

Re: [U-Boot] [PATCH v5 00/23] spi: Use BIT and GENMASK

On 24 October 2015 at 09:08, Jagan Teki wrote: > This series replaces numerical bit shitfts and mask values > with BIT and GENMASK macro's > > Changes for v5: > - Dropped exynos_spi BIT changes > - Removed GENMASK for 0XFF on cadence_qspi_qpb > - Split the commit message body

Re: [U-Boot] [PATCH v4 05/21] sf: Make flash->flags use for generic usage

On 12 October 2015 at 20:30, Jagan Teki wrote: > Use the flash->flags for generic usage, not only for dm-spi-flash, > this will be used for future flag additions. > > Signed-off-by: Jagan Teki > [Correct the spi flash flags detect logic] > Signed-off-by:

Re: [U-Boot] [PATCH v4 04/21] sf: Optimize BAR write code

On 12 October 2015 at 20:30, Jagan Teki wrote: > Optimized spi-flash bar writing code and also removed > unnecessary bank_sel in read_ops. > > Signed-off-by: Jagan Teki > Cc: Simon Glass > Cc: Michal Simek >

Re: [U-Boot] [PATCH v4 03/21] sf: Add spi_flash_read_bar

On 12 October 2015 at 20:30, Jagan Teki wrote: > Add spi_flash_read_bar function for reading bar and > discovering bar commands at probe time. > > Signed-off-by: Jagan Teki > Cc: Michal Simek > Cc: Siva Durga Prasad Paladugu

Re: [U-Boot] [PATCH v2 02/13] include: Add generic bitops headers

Hi Febio, You replaced __always_inline to inline any specific reason? found __always_inline at some parts of header in code. But my compilation is not-smooth with this. On 24 October 2015 at 20:56, Fabio Estevam wrote: > From: Fabio Estevam > >

[U-Boot] [PATCH 1/5] driver: gpio: hikey: Fix pointer conversion warnings for hikey

Fix below compilation warnings- drivers/gpio/hi6220_gpio.c: In function ‘hi6220_gpio_probe’: drivers/gpio/hi6220_gpio.c:82:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] bank->base = (u8 *)plat->base; Signed-off-by: Prabhakar Kushwaha

[U-Boot] [PATCH 2/5] driver: dwmmc: Fix pointer conversion warnings for hikey

Fix below compilation warings happening for hikey_defconfig drivers/mmc/dw_mmc.c: In function ‘dwmci_set_idma_desc’: drivers/mmc/dw_mmc.c:43:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] desc->next_addr = (unsigned int)desc + sizeof(struct dwmci_idmac);

[U-Boot] [PATCH 0/5] driver: Fix pointer conversion warnings for hikey and xilinx_zynqmp_ep

ARMv8 platforms hikey and xilinx_zynqmp_ep showing compilation warning related to pointer conversion. These warnings are coming with aarch64-linux-gnu-gcc (crosstool-NG linaro-1.13.1-4.8-2013.12 - Linaro GCC 2013.11) 4.8.3 20131202 Prabhakar Kushwaha (5): driver: gpio: hikey: Fix pointer

[U-Boot] Pull request: u-boot-spi/master

Hi Tom, This PR will also include zynq changes which I sent before the release. And the zynq SPI SPL build issue still there, as Michal need to send related patches. thanks! Jagan. The following changes since commit 677f970bc62a661690b3431543d5a5d5e682ba70: common/board_f.c: modify the

Re: [U-Boot] [PATCH v2 03/12] compat: Remove is_power_of_2() definition

Hi Febio, On 24 October 2015 at 20:56, Fabio Estevam wrote: > From: Fabio Estevam > > Use the is_power_of_2() definition from log2.h to align with the > kernel implementation. > > Signed-off-by: Fabio Estevam >

Re: [U-Boot] [PATCH v4 02/21] sf: Return bank_sel, if flash->bank_curr == bank_sel

On 12 October 2015 at 20:30, Jagan Teki wrote: > If computed bank_sel is same as flash->bank_curr which is > computed at probe time, then return the bank_sel instead of zero. > > Signed-off-by: Jagan Teki > Cc: Michal Simek > Cc:

Re: [U-Boot] [PATCH v4 01/21] spi: zynq_spi: Remove unneeded headers

On 12 October 2015 at 20:30, Jagan Teki wrote: > - Removed unneeded inclusion of header files > - Add "Xilinx" on license text > > Signed-off-by: Jagan Teki > Cc: Michal Simek > Cc: Siva Durga Prasad Paladugu

Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

On 25 October 2015 at 09:36, Jagan Teki wrote: > - Use __func__ on debug > - Removed unnecessary comment > > Signed-off-by: Jagan Teki Applied to u-boot-spi/master -- Jagan | openedev. ___ U-Boot mailing list

Re: [U-Boot] [PATCH] mtd: do not include cfi_flash.h if no flash

On Sunday, October 25, 2015 at 02:29:06 PM, Thomas Chou wrote: > Hi Marek, > > On 10/25/2015 12:00 PM, Marek Vasut wrote: > > On Sunday, October 25, 2015 at 04:02:58 AM, Thomas Chou wrote: > >> Do not include cfi_flash.h if CONFIG_SYS_NO_FLASH. Because > >> the flash_info is undefined in flash.h

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sunday, October 25, 2015 at 05:44:47 AM, Siarhei Siamashka wrote: > This is necessary to distinguish between the "dfu-util --detach" and > the "dfu-util --reset" requests. > > The default weak implementation of dfu_usb_get_reset() unconditionally > reboots the device, but we want to be able to

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

Hello Marek, On Sun, 25 Oct 2015 12:00:09 +0100, Marek Vasut wrote: > On Sunday, October 25, 2015 at 05:44:47 AM, Siarhei Siamashka wrote: > > This is necessary to distinguish between the "dfu-util --detach" and > > the "dfu-util --reset" requests. > > > > The default weak

Re: [U-Boot] [PATCH v2 01/13] include: Add log2 header from the kernel

On Sun, Oct 25, 2015 at 4:44 AM, Jagan Teki wrote: >> +++ b/include/linux/log2.h >> @@ -0,0 +1,205 @@ >> +/* Integer base 2 logarithm calculation > > Of-course Linux look same, but the multi-line comment should be as > > /** > * Integer base 2 logarithm calculation > * >

Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

On 25 October 2015 at 19:17, Tom Rini wrote: > On Sun, Oct 25, 2015 at 09:36:59AM +0530, Jagan Teki wrote: > >> - Use __func__ on debug >> - Removed unnecessary comment >> >> Signed-off-by: Jagan Teki >> --- >> drivers/spi/zynq_qspi.c | 8 +++- >> 1

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

Hello Ian, On Sun, 25 Oct 2015 12:40:45 +, Ian Campbell wrote: > On Sun, 2015-10-25 at 12:46 +0100, Albert ARIBAUD wrote: > > > > +static u8 last_int_usb; > > > > + > > > > +bool dfu_usb_get_reset(void) > > > > +{ > > > > + return !!(last_int_usb &

Re: [U-Boot] [PATCH v4] net: TFTP: variables cleanup and addition

On Mon, 12 Oct 2015 00:02:57 +0200, Albert ARIBAUD (3ADEV) wrote: > TFTP source and destination port variable names are > 'tftpsrcp' and 'tftpdstp' in the code, but 'tftpsrcport' > and 'tftpdstport' in the README file. Fix the README. > > Add environment variable

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 2015-10-25 at 12:46 +0100, Albert ARIBAUD wrote: > > > +static u8 last_int_usb; > > > + > > > +bool dfu_usb_get_reset(void) > > > +{ > > > + return !!(last_int_usb & MUSB_INTR_RESET); > > > > The !! is not needed. > > Except if you want to be sure that you return 0 or 1 rather than 0 or

Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

On Sun, Oct 25, 2015 at 09:36:59AM +0530, Jagan Teki wrote: > - Use __func__ on debug > - Removed unnecessary comment > > Signed-off-by: Jagan Teki > --- > drivers/spi/zynq_qspi.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git

Re: [U-Boot] [PATCH v2 1/2] arm: stm32f4: fix a bug when only first sector gets erased

Hello Vadzim, On Fri, 23 Oct 2015 21:14:06 +0300, Vadzim Dambrouski wrote: > flash_lock call is inside a for loop, so after the first iteration flash > is locked and no more sectors can be erased. > Move flash_lock out of the loop. > > Signed-off-by: Vadzim Dambrouski

Re: [U-Boot] [PATCH v2 03/12] compat: Remove is_power_of_2() definition

On Sun, Oct 25, 2015 at 4:53 AM, Jagan Teki wrote: > Hi Febio, > > On 24 October 2015 at 20:56, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Use the is_power_of_2() definition from log2.h to align with the >> kernel

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sunday, October 25, 2015 at 02:22:53 PM, Albert ARIBAUD wrote: > Hello Ian, Hi! > On Sun, 25 Oct 2015 12:40:45 +, Ian Campbell > > wrote: > > On Sun, 2015-10-25 at 12:46 +0100, Albert ARIBAUD wrote: > > > > > +static u8 last_int_usb; > > > > > + > > > > > +bool

Re: [U-Boot] [PATCH] mtd: do not include cfi_flash.h if no flash

Hi Marek, On 10/25/2015 12:00 PM, Marek Vasut wrote: On Sunday, October 25, 2015 at 04:02:58 AM, Thomas Chou wrote: Do not include cfi_flash.h if CONFIG_SYS_NO_FLASH. Because the flash_info is undefined in flash.h if CONFIG_SYS_NO_FLASH. Signed-off-by: Thomas Chou ---

Re: [U-Boot] [PATCH] u-boot/mpc85xx/u-boot*.lds: remove _GLOBAL_OFFSET_TABLE_ definition

On Sun, Oct 25, 2015 at 09:28:50AM +0530, Prabhakar Kushwaha wrote: > From: Zhenhua Luo > > In binutils-2.25, the _GLOBAL_OFFSET_TABLE_ symbols defined by PROVIDE in > u-boot.lds overrides the linker built-in symbols >

Re: [U-Boot] [PATCH] mtd: do not include cfi_flash.h if no flash

Hi Marek, On 10/25/2015 09:30 PM, Marek Vasut wrote: btw. do you plan to send a PR with all the nios2 goodies (patches) any soon ? I did send it. And Tom applied them already. I am working on max10 devboard. I am cleaning up the flash code and will add an altera quadspi driver. The altera

Re: [U-Boot] [PATCH V2 03/14] xfi3: correct function name

Hi Stefano, On Tue, Oct 20, 2015 at 03:10:38PM +0200, Stefano Babic wrote: >On 20/10/2015 13:39, Peng Fan wrote: >> board_mxsfb_system_setup shoule be named mxsfb_system_setup. > ^---should > >But really it is better *must*, else it is dead code as we currently have.

Re: [U-Boot] [PATCH V2 07/14] imx: mx6: add clock api for lcdif

Hi Stefano, On Tue, Oct 20, 2015 at 03:39:32PM +0200, Stefano Babic wrote: >Hi Peng, > >On 20/10/2015 13:39, Peng Fan wrote: >> Implement mxs_set_lcdclk, enable_lcdif_clock and enable_pll_video. >> The three API can be used to configure lcdif related clock when >> CONFIG_VIDEO_MXS enabled. >> >>

Re: [U-Boot] [PATCH V2 01/14] mxs: add parameter base_addr for mxs_set_lcdclk

Hi Stefano, Sorry for this late reply. On Tue, Oct 20, 2015 at 03:05:05PM +0200, Stefano Babic wrote: >Hi Peng, > > >On 20/10/2015 13:39, Peng Fan wrote: >> Change mxs_set_lcdclk prototype to add a new parameter >> base_addr. There are two LCD interfaces for i.MX6SX, >> we may support LCDIF1 or

[U-Boot] [PATCH v2] arm: at91: clock: Add the generated clock support

Some peripherals may need a second clock source that may be different from the system clock. This second clock is the generated clock (GCK) and is managed by the PMC via PMC_PCR. For simplicity, the clock source of the GCK is fixed to PLLA_CLK. Signed-off-by: Wenyou Yang

[U-Boot] [PATCH v3] mmc: atmel: Add atmel sdhci support

The SDHCI is introduced by sama5d2, named as Secure Digital Multimedia Card Controller(SDMMC). It supports the embedded MultiMedia Card (e.MMC) Specification V4.41, the SD Memory Card Specification V3.0, and the SDIO V3.0 specification. It is compliant with the SD Host Controller Standard V3.0

Re: [U-Boot] [PATCH] mtd: do not include cfi_flash.h if no flash

On Monday, October 26, 2015 at 12:15:15 AM, Thomas Chou wrote: > Hi Marek, Hi! > On 10/25/2015 09:30 PM, Marek Vasut wrote: > > btw. do you plan to send a PR with all the nios2 goodies (patches) any > > soon ? > > I did send it. And Tom applied them already. Excellent , thanks! > I am working

Re: [U-Boot] [PATCH V2 09/14] video: mxsfb: introduce lcdif_power_down

Hi Stefano, On Tue, Oct 20, 2015 at 03:59:18PM +0200, Stefano Babic wrote: >Hi Peng, > >On 20/10/2015 13:39, Peng Fan wrote: >> Introudce a new function lcdif_power_down. >> >> 1. Waits for a VSYNC interrupt to guarantee the reset is done at the >>VSYNC edge, which somehow makes the LCDIF

Re: [U-Boot] [PATCH v2] mmc: atmel: Add atmel sdhci support

Hi Andreas, Thank you for your review. The new version is sent, please help review, thanks. > -Original Message- > From: Andreas Bießmann [mailto:andreas.de...@googlemail.com] > Sent: 2015年10月24日 5:27 > To: Yang, Wenyou; U-Boot Mailing List > Cc: Bo Shen; Pantelis Antoniou > Subject:

Re: [U-Boot] [PATCH] env_ubi.c: Correct pointer error in env load

Hello Kevin, Am 23.10.2015 um 19:51 schrieb Kevin Smith: The variable "buf" in this function is a char array, and the function ubi_volume_read is expecting a char *. In the call, the address of the pointer is being taken, incorrectly passing a char **. The compiler warning was being silenced

Re: [U-Boot] [PATCH V2 04/14] imx: imx-common: move lcdif structure and macro definition to imx-common

Hi Stefano, On Tue, Oct 20, 2015 at 03:15:19PM +0200, Stefano Babic wrote: >Hi Peng, > >On 20/10/2015 13:39, Peng Fan wrote: >> Move 'struct mxs_lcdif_regs' and lcdif related macro definitions to >> arch/arm/include/asm/imx-common/regs-lcdif.h. >> >> i.MX6SX/UL/28 have similar register layout

Re: [U-Boot] [PATCH V2 08/14] imx: mx6ul_14x14_evk: support lcdif display

Hi Stefano, On Tue, Oct 20, 2015 at 03:41:58PM +0200, Stefano Babic wrote: >Hi Peng, > >On 20/10/2015 13:39, Peng Fan wrote: >> Support lcdif display: >> 1. Add pinmux and pad settings for LCDIF >> 2. Introduce setup_lcd to do the settings for LCDIF >> 3. Enable VIDEO related macros in board

[U-Boot] [PATCH] nios2: add 10m50 devboard support

Add 10m50 devboard support. It is based on the Golden Hardware Reference Design (GHRD), available at, http://rocketboards.org/foswiki/view/Documentation/ AlteraMAX1010M50RevCDevelopmentKitLinuxSetup Though we supported only one nios2-generic board in the past. Now, with the removal of the

Re: [U-Boot] [PATCH v2] spi: zynq_qspi: Minor cleanups

On 26 October 2015 at 00:21, Tom Rini wrote: > On Sun, Oct 25, 2015 at 07:49:57PM +0530, Jagan Teki wrote: >> - Use __func__ on debug >> - Removed unnecessary comment >> - Fix function name in debug as zynq_qspi_xfer instead of spi_xfer >> >> Cc: Tom Rini

Re: [U-Boot] [PATCH] gpio: atmel: Add the PIO4 driver support

Hi Andreas, Could you help review? Thanks a lot. > -Original Message- > From: Wenyou Yang [mailto:wenyou.y...@atmel.com] > Sent: 2015年9月8日 14:33 > To: U-Boot Mailing List > Cc: Yang, Wenyou; andreas.de...@googlemail.com > Subject: [PATCH] gpio: atmel: Add the PIO4 driver support > > The

Re: [U-Boot] [PATCH] arm: at91: clock: Add the generated clock support

Hi Andreas, Thank you for your review. The new version has been sent for review. > -Original Message- > From: Andreas Bießmann [mailto:andreas.de...@googlemail.com] > Sent: 2015年10月24日 5:01 > To: Yang, Wenyou; U-Boot Mailing List > Subject: Re: [PATCH] arm: at91: clock: Add the

Re: [U-Boot] [PATCH v1 01/12] rockchip: define SUPPORT_SPL and SPL config in RK3288 config

Hi, On Oct 22, 2015 7:22 PM, "hl" wrote: > > Hi Simon, > > > On 23/10/15 09:04, Simon Glass wrote: >> >> Hi Eddie, >> >> On 22 October 2015 at 18:54, Eddie Cai wrote: >>> >>> Hi Simon >>> >>> 2015-10-23 0:30 GMT+08:00 Simon Glass

Re: [U-Boot] [PATCH 03/13] compat: Remove is_power_of_2() definition

Hello Fabian, Am 24.10.2015 um 14:28 schrieb Fabio Estevam: From: Fabio Estevam Use the is_power_of_2() definition from log2.h to align with the kernel implementation. Signed-off-by: Fabio Estevam --- arch/arm/mach-mvebu/mbus.c | 2

Re: [U-Boot] [PATCH] net/eth: fix a bug in on_ethaddr()

Hi Joe, Do you have any objection about this patch? If yes, then please share your comments then we can refine it. If no, would you please help to pick up the patch? Thanks in advance. Mingkai > -Original Message- > From: Hu Mingkai-B21284 > Sent: Wednesday, October 21, 2015 6:07 PM >

Re: [U-Boot] [PATCH v5 01/23] spi: zynq_[q]spi: Use BIT macro

> -Original Message- > From: Jagan Teki [mailto:jt...@openedev.com] > Sent: Saturday, October 24, 2015 9:09 AM > To: u-boot@lists.denx.de > Cc: Jagan Teki; Siva Durga Prasad Paladugu; Michal Simek > Subject: [PATCH v5 01/23] spi: zynq_[q]spi: Use BIT macro > > Used BIT macro on

Re: [U-Boot] [PATCH v5 17/23] spi: cadence_qspi_apb: Use GENMASK

On 25.10.2015 00:25, Tom Rini wrote: On Sun, Oct 25, 2015 at 12:13:14AM +0200, Marek Vasut wrote: On Saturday, October 24, 2015 at 11:51:39 PM, Tom Rini wrote: On Sat, Oct 24, 2015 at 02:41:41PM +0200, Marek Vasut wrote: On Saturday, October 24, 2015 at 05:39:04 AM, Jagan Teki wrote: Replace

Re: [U-Boot] [PATCH v2 02/13] include: Add generic bitops headers

Hi Jagan, On Sun, Oct 25, 2015 at 2:28 PM, Fabio Estevam wrote: > On Sun, Oct 25, 2015 at 4:50 AM, Jagan Teki wrote: >> Hi Febio, >> >> You replaced __always_inline to inline any specific reason? found >> __always_inline at some parts of header in code.

[U-Boot] [PATCH v3 10/12] sandbox: Use the generic bitops headers

From: Fabio Estevam The generic bitops headers are required when calling logarithimic functions, such as ilog2(). Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 12/12] spi: Add SPI NOR protection mechanism

From: Fabio Estevam Many SPI flashes have protection bits (BP2, BP1 and BP0) in the status register that can protect selected regions of the SPI NOR. Take these bits into account when performing erase operations, making sure that the protected areas are skipped.

[U-Boot] [PATCH v3 11/12] spi: sf_ops: Add SPI protection mechanism from the kernel

From: Fabio Estevam Add the SPI NOR protection mechanism from the kernel. This code is based on the work from Brian Norris

[U-Boot] [PATCH v3 08/12] blackfin: bitops: Use the generic bitops headers

From: Fabio Estevam The generic bitops headers are required when calling logarithimic functions, such as ilog2(). Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 09/12] sh: bitops: Use the generic bitops headers

From: Fabio Estevam The generic bitops headers are required when calling logarithimic functions, such as ilog2(). Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 05/12] ARM: bitops: Use the generic bitops headers

From: Fabio Estevam The generic bitops headers are required when calling logarithimic functions, such as ilog2(). Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 06/12] x86: bitops: Use the generic bitops headers

From: Fabio Estevam Use the generic bitops and also add custom __ffs() implementation as per the kernel. Also align the ffs() implementation with the kernel. Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v3 03/12] compat: Remove is_power_of_2() definition

From: Fabio Estevam Use the is_power_of_2() definition from log2.h to align with the kernel implementation. Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 04/12] powerpc: Remove __ilog2_u64 and ffs4 from bitops

From: Fabio Estevam Remove __ilog2_u64 and ffs4 from powerpc bitops to align with the kernel implementation. Use the generic __ffs64 instead of a custom powerpc implementation. Cc: York Sun Signed-off-by: Fabio Estevam

[U-Boot] [PATCH v3 07/12] m68k: bitops: Use the generic bitops headers

From: Fabio Estevam The generic bitops headers are required when calling logarithimic functions, such as ilog2(). Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini --- Changes since v2: - None

[U-Boot] [PATCH v3 2/12] include: Add generic bitops headers

From: Fabio Estevam Use the generic bitops header files from the kernel. Imported from kernel 4.2.3. Signed-off-by: Fabio Estevam --- Changes since v2: - Use the original __always_inline (Jagan) include/asm-generic/bitops/__ffs.h |

[U-Boot] [PATCH v3 01/12] include: Add log2 header from the kernel

From: Fabio Estevam Use the log2 header files from the kernel. Imported from kernel 4.2.3. Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini Reviewed-by: Jagan Teki --- Changes since v2: -

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 25 Oct 2015 19:24:04 + Ian Campbell wrote: > On Sun, 2015-10-25 at 16:46 +0200, Siarhei Siamashka wrote: > > replace "#include " with "typedef int bool;" and try it > > again. > > So don't do that then. Yes, I'm not going to do this. It was just an

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

Hello Siarhei, On Sun, 25 Oct 2015 16:55:43 +0200, Siarhei Siamashka wrote: > On Sun, 25 Oct 2015 12:00:09 +0100 > Marek Vasut wrote: > > > On Sunday, October 25, 2015 at 05:44:47 AM, Siarhei Siamashka wrote: > > > This is necessary to distinguish

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

Hello Ian, On Sun, 25 Oct 2015 19:22:00 +, Ian Campbell wrote: > On Sun, 2015-10-25 at 14:22 +0100, Albert ARIBAUD wrote: > > On Sun, 25 Oct 2015 12:40:45 +, Ian Campbell > > > Doesn't the bool return type already cause that to happen? (from the > > > PoV of the

Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

On 25 October 2015 at 19:34, Tom Rini wrote: > On Sun, Oct 25, 2015 at 07:22:24PM +0530, Jagan Teki wrote: >> On 25 October 2015 at 19:17, Tom Rini wrote: >> > On Sun, Oct 25, 2015 at 09:36:59AM +0530, Jagan Teki wrote: >> > >> >> - Use __func__ on debug

[U-Boot] [PATCH v2] spi: zynq_qspi: Minor cleanups

- Use __func__ on debug - Removed unnecessary comment - Fix function name in debug as zynq_qspi_xfer instead of spi_xfer Cc: Tom Rini Signed-off-by: Jagan Teki --- Changes for v2: - Fix commit message - Use meaningful commit header, add

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 25 Oct 2015 12:00:09 +0100 Marek Vasut wrote: > On Sunday, October 25, 2015 at 05:44:47 AM, Siarhei Siamashka wrote: > > This is necessary to distinguish between the "dfu-util --detach" and > > the "dfu-util --reset" requests. > > > > The default weak implementation of

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sunday, October 25, 2015 at 03:55:43 PM, Siarhei Siamashka wrote: > On Sun, 25 Oct 2015 12:00:09 +0100 > > Marek Vasut wrote: > > On Sunday, October 25, 2015 at 05:44:47 AM, Siarhei Siamashka wrote: > > > This is necessary to distinguish between the "dfu-util --detach" and > >

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sunday, October 25, 2015 at 03:46:15 PM, Siarhei Siamashka wrote: > On Sun, 25 Oct 2015 14:29:59 +0100 > > Marek Vasut wrote: > > On Sunday, October 25, 2015 at 02:22:53 PM, Albert ARIBAUD wrote: > > > Hello Ian, > > > > Hi! > > > > > On Sun, 25 Oct 2015 12:40:45 +, Ian

Re: [U-Boot] [PATCH v2 02/13] include: Add generic bitops headers

On Sun, Oct 25, 2015 at 4:50 AM, Jagan Teki wrote: > Hi Febio, > > You replaced __always_inline to inline any specific reason? found > __always_inline at some parts of header in code. But my compilation is > not-smooth with this. Yes, if I use the original __always_inline I

Re: [U-Boot] [PATCH] spi: zynq_qspi: Use __func__ on debug

On Sun, Oct 25, 2015 at 07:22:24PM +0530, Jagan Teki wrote: > On 25 October 2015 at 19:17, Tom Rini wrote: > > On Sun, Oct 25, 2015 at 09:36:59AM +0530, Jagan Teki wrote: > > > >> - Use __func__ on debug > >> - Removed unnecessary comment > >> > >> Signed-off-by: Jagan Teki

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 25 Oct 2015 14:29:59 +0100 Marek Vasut wrote: > On Sunday, October 25, 2015 at 02:22:53 PM, Albert ARIBAUD wrote: > > Hello Ian, > > Hi! > > > On Sun, 25 Oct 2015 12:40:45 +, Ian Campbell > > > > wrote: > > > On Sun, 2015-10-25 at 12:46

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 2015-10-25 at 16:46 +0200, Siarhei Siamashka wrote: > replace "#include " with "typedef int bool;" and try it > again. So don't do that then. In u-boot the "bool" type comes from stdbool.h and it is therefore completely reasonable to assume that bool in u-boot has the properties which

Re: [U-Boot] [PATCH v2] spi: zynq_qspi: Minor cleanups

On Sun, Oct 25, 2015 at 07:49:57PM +0530, Jagan Teki wrote: > - Use __func__ on debug > - Removed unnecessary comment > - Fix function name in debug as zynq_qspi_xfer instead of spi_xfer > > Cc: Tom Rini > Signed-off-by: Jagan Teki > --- > Changes for v2:

Re: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

On Sun, 2015-10-25 at 14:22 +0100, Albert ARIBAUD wrote: > On Sun, 25 Oct 2015 12:40:45 +, Ian Campbell > > Doesn't the bool return type already cause that to happen? (from the > > PoV of the caller at least) > > When all is said and done, a C bool is a C int, Not if it is a _Bool (via