Re: [U-Boot] [PATCH v4 8/8] dm: x86: spi: Convert ICH SPI driver to driver model PCI API

2016-01-17 Thread Bin Meng
Hi Simon, On Sun, Jan 17, 2016 at 7:44 AM, Simon Glass wrote: > At present this SPI driver works by searching the PCI buses for its > peripheral. It also uses the legacy PCI API. > > In addition the driver has code to determine the type of Intel PCH that is > used (version 7 or version 9). Now th

Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.

2016-01-17 Thread Eddie Cai
Hi Lukasz Have you back to office? Much appreciate if you can review Frank's patch. Thanks Eddie 2015-12-30 17:14 GMT+08:00 Lukasz Majewski : > Hi Frank > >> [PATCH 1/3] Modified the check condition for max packet size of >> ep_in in high speed >> >> [PATCH 2/3] Fixed the error that the last p

[U-Boot] [PATCH v3] Enable snooping on transactions from CAAM block

2016-01-17 Thread Aneesh Bansal
To enable snooping on CAAM transactions following programming is done 1. Enable core snooping (CCI interface, Core is Slave5 on CCI) This setting is also required for making the system coherent 2. CAAM IP lies behind SMMU3 in the system. Configure SMMU3 to do the following: a) Program SCR to bypa

Re: [U-Boot] [PATCH v4 5/8] dm: x86: Add a driver for Intel PCH7

2016-01-17 Thread Bin Meng
Hi Simon, On Sun, Jan 17, 2016 at 7:44 AM, Simon Glass wrote: > At some point we may need to distinguish between different types of PCHs, > but for existing supported platforms we only need to worry about version 7 > and version 9 bridges. Add a driver for the PCH7. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v4 6/8] dm: x86: Add a driver for Intel PCH9

2016-01-17 Thread Bin Meng
On Sun, Jan 17, 2016 at 7:44 AM, Simon Glass wrote: > At some point we may need to distinguish between different types of PCHs, > but for existing supported platforms we only need to worry about version 7 > and version 9 bridges. Add a driver for the PCH9. > > Signed-off-by: Simon Glass > --- > >

Re: [U-Boot] [PATCH v4 4/8] dm: Expand the uclass for Platform Controller Hubs (PCH)

2016-01-17 Thread Bin Meng
On Sun, Jan 17, 2016 at 7:44 AM, Simon Glass wrote: > A Platform Controller Hub is an Intel concept - it is like the peripherals > on an SoC and is often in a separate chip from the CPU. The chip is typically > found on the first PCI bus and integrates multiple devices. > > We have a very simple u

Re: [U-Boot] [PATCH v4 2/8] dm: pci: Add a function to write a BAR

2016-01-17 Thread Bin Meng
On Sun, Jan 17, 2016 at 7:44 AM, Simon Glass wrote: > Add a driver-model version of the pci_write_bar32 function so that this is > supported in the new API. > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Tidy up mentions on control bits in the header file > > Changes in v3: None > Ch

Re: [U-Boot] [PATCH 5/5] i2c: omap24xx: Convert fully to DM_I2C

2016-01-17 Thread Heiko Schocher
Hello Christophe, Am 17.01.2016 um 12:09 schrieb Christophe Ricard: For several reasons: - code clarity - DM trends in u-boot ... It is better to make omap24xx_i2c driver 100% DM_I2C based. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c.c | 447 +-

Re: [U-Boot] [PATCH 2/2] Remove the cmd_ prefix from command files

2016-01-17 Thread Stefan Roese
Hi Simon, On 18.01.2016 04:53, Simon Glass wrote: Now that they are in their own directory, we can remove this prefix. This makes it easier to find a file since the prefix does not get in the way. Signed-off-by: Simon Glass Acked-by: Stefan Roese Thanks, Stefan ___

Re: [U-Boot] [PATCH 1/2] Move all command code into its own directory

2016-01-17 Thread Stefan Roese
Hi Simon, On 18.01.2016 04:53, Simon Glass wrote: There are a lot of unrelated files in common, including all of the commands. Moving them into their own directory makes them easier to find and is more logical. Some commands include non-command code, such as cmd_scsi.c. This should be sorted ou

Re: [U-Boot] [PATCH 4/5] i2c: omap24xx: Fix high speed trimming calculation

2016-01-17 Thread Heiko Schocher
Hello Christophe, Am 17.01.2016 um 12:09 schrieb Christophe Ricard: Work based on i2c-omap.c from linux kernel. fsscll/fssclh and hsscll/hssclh was always negative in high speed. i2c high speed frequency start after 400Khz. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c.c |

Re: [U-Boot] [PATCH 3/5] i2c: omap24xx: Remove unused I2C_WAIT macro

2016-01-17 Thread Heiko Schocher
Hello Christophe, Am 17.01.2016 um 12:09 schrieb Christophe Ricard: I2C_WAIT macro is not used in the code. 200 is bound to a fixed 10 Hz i2c speed based on an existing formula: ( 1000 / speed ) * 2 where speed = 100 000. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c

Re: [U-Boot] [PATCH 2/5] i2c: omap24xx: Fix waitdelay value for I2C HS

2016-01-17 Thread Heiko Schocher
Hello Christophe, Am 17.01.2016 um 12:09 schrieb Christophe Ricard: After several testings and experiment, it appears that waitdelay calculation formula was giving different behavior on the i2c status registers. Experiment shows waitdelay needs to be extended at least 4 times to get proper resu

Re: [U-Boot] [PATCH 1/5] i2c: omap24xx: Convert to DM

2016-01-17 Thread Heiko Schocher
Hello Christophe, Am 17.01.2016 um 12:09 schrieb Christophe Ricard: Convert omap24xx_i2c driver to DM Signed-off-by: Christophe Ricard --- drivers/i2c/Kconfig| 8 ++ drivers/i2c/omap24xx_i2c.c | 280 +++-- 2 files changed, 277 insertions(+

Re: [U-Boot] [PATCH 2/2] Remove the cmd_ prefix from command files

2016-01-17 Thread Heiko Schocher
Hello Simon, Am 18.01.2016 um 04:53 schrieb Simon Glass: Now that they are in their own directory, we can remove this prefix. This makes it easier to find a file since the prefix does not get in the way. Signed-off-by: Simon Glass --- Thanks! Reviewed-by: Heiko Schocher bye, Heiko cmd

Re: [U-Boot] [PATCH 1/2] Move all command code into its own directory

2016-01-17 Thread Heiko Schocher
Hello Simon, Am 18.01.2016 um 04:53 schrieb Simon Glass: There are a lot of unrelated files in common, including all of the commands. Moving them into their own directory makes them easier to find and is more logical. Some commands include non-command code, such as cmd_scsi.c. This should be so

Re: [U-Boot] [PATCH 00/17] arm: ls1021atwr: Convert to use driver model TSEC driver

2016-01-17 Thread Bin Meng
Joe, York, On Tue, Jan 12, 2016 at 2:41 PM, Bin Meng wrote: > This series adds driver model ethernet support to the Freescale > TSEC ethernet driver and convert ls1021atwr board to use it. > > Enable the support in the ls1021atwr_nor_defconfig and > ls1021atwr_nor_lpuart_defconfig configurations.

Re: [U-Boot] [PATCH] drivers/power/regulator/max77686.c: Don't use switch() on bools

2016-01-17 Thread Bin Meng
On Sun, Jan 17, 2016 at 10:44 AM, Tom Rini wrote: > With gcc-5.3 we get a warning for using switch() on a bool type. > Rewrite these sections as if/else and update the one section that was > using 1/0 instead of true/false. > > Cc: Simon Glass > Cc: Przemyslaw Marczak > Signed-off-by: Tom Rini

[U-Boot] [PATCH 8/9] ARM: ARMv7: PSCI: ls102xa: add psci functions implemention

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Based on PSCI v1.0, implement interface for ls102xa SoC: psci_version, psci_features, psci_cpu_suspend, psci_affinity_info, psci_system_reset, psci_system_off. Tested on LS1021aQDS, LS1021aTWR. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/ls102xa/psci.S |

[U-Boot] [PATCH 2/9] ARM: PSCI: Change PSCI related macro definition style

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng The macro style changes just to keep the style of the macro concise and consistent, and style mimicking linux. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/ls102xa/psci.S | 2 +- arch/arm/cpu/armv7/psci.S | 12 ++-- arch/arm/cpu/armv7/sunxi

Re: [U-Boot] [PATCH 2/2] Remove the cmd_ prefix from command files

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 11:53 AM, Simon Glass wrote: > Now that they are in their own directory, we can remove this prefix. > This makes it easier to find a file since the prefix does not get in the > way. > > Signed-off-by: Simon Glass > --- > > cmd/Makefile

Re: [U-Boot] [PATCH 1/2] Move all command code into its own directory

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 11:53 AM, Simon Glass wrote: > There are a lot of unrelated files in common, including all of the commands. > Moving them into their own directory makes them easier to find and is more > logical. > > Some commands include non-command code, such as cmd_scsi.c. This should be

[U-Boot] [PATCH 6/9] ARM: ARMv7: PSCI: ls102xa: Verify CPU ID for CPU_ON

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Add validation code to make sure target cpu ID is valid. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/ls102xa/psci.S | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/ls102xa/psci.S b/arch/arm/cpu/a

[U-Boot] [PATCH 7/9] ARM: ARMv7: PSCI: Add PSCI 1.0 version support

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Add the PSCI v1.0 API to U-Boot: PSCI_VERSION, AFFINITY_INFO, MIGRATE_INFO_TYPE, MIGRATE_INFO_UP_CPU, SYSTEM_OFF, SYSTEM_RESET, PSCI_FEATURES, SYSTEM_SUSPEND. In order to be compatible with PSCI v0.1 version, introduce CONFIG_ARMV7_PSCI_GTE_1_0 macro to add the PSCI

[U-Boot] [PATCH v2] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng "DISCARD" will remove ._secure.text relocate, but PSCI framework has already used some absolute address those need to relocate. Use readelf -t -r u-boot show us: .__secure_start addr: 601408e4 .__secure_end addr: 60141460 60141140 0017 R_ARM_RELATIVE

Re: [U-Boot] [PATCH 8/8] net: Probe PCI before looking for ethernet devices

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 5:52 AM, Simon Glass wrote: > Some ethernet devices may be on a PCI bus. Probe the first PCI controller to > find these, so that ethernet init will complete correctly. > > Signed-off-by: Simon Glass > --- > > net/eth-uclass.c | 5 + > 1 file changed, 5 inse

Re: [U-Boot] [PATCH 7/8] net: Rename eth.c to eth_lecacy.c

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 5:52 AM, Simon Glass wrote: > Rename this file to make it clear it is for the old networking drivers > and not for use with driver model. > > Signed-off-by: Simon Glass > --- > > net/Makefile| 2 +- > net/{eth.c => eth_legacy.c} | 0 > 2 files changed, 1 i

Re: [U-Boot] [PATCH 5/8] net: Move remaining common functions to eth_common.c

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: > Move eth_current_changed(), eth_set_current(), eth_mac_skip() and > eth_get_name() into the common file. > > Signed-off-by: Simon Glass > --- > > net/eth.c | 108 > ++--- > net/eth_com

Re: [U-Boot] [PATCH 6/8] net: Move driver-model code into its own file

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 5:52 AM, Simon Glass wrote: > Every other uclass is in its own file. Create a new eth-uclass.c file and > move the driver-model code into it, so that networking is consistent. > > Signed-off-by: Simon Glass > --- > > net/Makefile | 4 + > net/eth-uclass.c | 549 > +

Re: [U-Boot] [PATCH 3/8] net: Move common init into a new eth_common.c file

2016-01-17 Thread Bin Meng
On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: > Only half of the init is actually common. Move that part into a new common > file and call it from driver-model and legacy code. More common functions > will be added in future patches. > > Signed-off-by: Simon Glass > --- > > net/Makefile

Re: [U-Boot] [PATCH 4/8] net: Move environment functions to the common file

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: > Move the functions which set ethernet environment variables to the common > file. > > Signed-off-by: Simon Glass > --- > > net/eth.c | 43 --- > net/eth_common.c | 43 +

[U-Boot] [PATCH 4/9] ARM: ARMv7: PSCI: Factor out reusable psci_cpu_on_common

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Move save target PC codes to a common function. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/ls102xa/psci.S | 20 -- arch/arm/cpu/armv7/mx7/psci.S | 3 --- arch/arm/cpu/armv7/psci.S | 39 ---

[U-Boot] [PATCH 5/9] ARM: ARMv7: PSCI: Pass contextID to target CPU

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng To follow PSCI, we need to save a "Context ID" in CPU_ON, and pass it to a CPU when it first enters the OS. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/nonsec_virt.S | 4 arch/arm/cpu/armv7/psci.S| 28 2 files changed, 32

[U-Boot] [PATCH 9/9] ARM: ARMv7: PSCI: ls102xa: put secure text section into OCRAM

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng LS1021 support two secure OCRAM block for trustzone. So move all of secure text section into OCRAM, and not need to use memory anymore. Signed-off-by: Wang Dongsheng --- arch/arm/include/asm/arch-ls102xa/config.h | 2 +- include/configs/ls1021atwr.h | 1 + 2

[U-Boot] [PATCH 3/9] ARM: ARMv7: PSCI: move target PC in each CPU stack no longer is shared

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng All of cpu share the same targetPC space that is unsafe. So move target PC save space into CPU stack. Signed-off-by: Wang Dongsheng --- arch/arm/cpu/armv7/ls102xa/psci.S | 4 +-- arch/arm/cpu/armv7/mx7/psci.S | 4 +-- arch/arm/cpu/armv7/psci.S | 5

[U-Boot] [PATCH 0/9] ARM: ARMv7: PSCI: add PSCI v1.0 support

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Support PSCI v1.0 for u-boot. Wang Dongsheng (9): ARM: PSCI: Change function ID base value ARM: PSCI: Change PSCI related macro definition style ARM: ARMv7: PSCI: move target PC in each CPU stack no longer is shared ARM: ARMv7: PSCI: Factor out reusable psci_cpu_on_c

[U-Boot] [PATCH 1/9] ARM: PSCI: Change function ID base value

2016-01-17 Thread Dongsheng Wang
From: Wang Dongsheng Following PSCI v1.0 spec and Linux kernel bindings: U-Boot's choice of base value is arbitrary for v0.1, because it's described in the device tree, so we're choosing to make things easier by using 0x8400 for all PSCI versions. Signed-off-by: Wang Dongsheng --- arch/ar

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 11:58 AM, Simon Glass wrote: > Hi Bin, > > On 17 January 2016 at 20:25, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: >>> We should avoid weak functions with driver model. Existing boards that use >>> driver model don't

Re: [U-Boot] [PATCH 06/11] imx: imx-common: introduce boot auxiliary core

2016-01-17 Thread Peng Fan
Hi Simon, Sorry for this late reply. On Thu, Jan 14, 2016 at 10:17:20AM -0700, Simon Glass wrote: >+Bin > >Hi Peng, > >On 4 January 2016 at 22:56, Peng Fan wrote: >> From: Peng Fan >> >> To boot a auxiliary core in asymmetric multicore system, introduce the >> new command "bootaux" to do it. Exa

Re: [U-Boot] [PATCH 06/11] imx: imx-common: introduce boot auxiliary core

2016-01-17 Thread Peng Fan
Hi Stefan, Sorry for this late reply. On Wed, Jan 13, 2016 at 12:45:05PM -0800, Stefan Agner wrote: >Hi, > >I would like to keep the discussion going and shed some light on the >image format introduced here, see below... > >On 2016-01-07 00:38, Peng Fan wrote: >> Hi Stefan, >> On Wed, Jan 06, 201

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Simon Glass
Hi Bin, On 17 January 2016 at 20:25, Bin Meng wrote: > Hi Simon, > > On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: >> We should avoid weak functions with driver model. Existing boards that use >> driver model don't need them, so let's kill them off. >> >> Signed-off-by: Simon Glass >> ---

Re: [U-Boot] [PATCH v2 16/26] dm: tegra: net: Convert tegra boards to driver model for Ethernet

2016-01-17 Thread Simon Glass
Hi Stephen, On 15 January 2016 at 16:53, Stephen Warren wrote: > On 12/13/2015 08:46 PM, Simon Glass wrote: >> >> Applied to u-boot-dm/next. > > > This change has removed/disabled/... PCIe support on at least Jetson TK1. I > haven't checked the other Tegra boards. My local copy works OK. I suspe

Re: [U-Boot] [PATCH v2 4/6] clk: change the type of return value to long

2016-01-17 Thread Simon Glass
Hi Masahiro, On 12 January 2016 at 21:16, Masahiro Yamada wrote: > The comments in include/clk.h state "or -ve error code" for these > functions, and actually the functions return negative error code > here and there. Returning unsigned value is not suitable. > > Signed-off-by: Masahiro Yamada

Re: [U-Boot] [PATCH v4 02/19] dm: timer: uclass: add timer init in uclass driver to add timer device

2016-01-17 Thread Simon Glass
Hi Mugunthan, On 16 January 2016 at 09:51, Mugunthan V N wrote: > On Saturday 16 January 2016 10:11 PM, Simon Glass wrote: >> Hi Mugunthan, >> >> On 16 January 2016 at 09:08, Mugunthan V N wrote: >>> On Saturday 16 January 2016 09:33 PM, Mugunthan V N wrote: Adding timer init function in ti

Re: [U-Boot] [PATCH v7 4/7] mips: ath79: add serial driver for ar933x SOC

2016-01-17 Thread Simon Glass
On 16 January 2016 at 11:13, Wills Wang wrote: > Reviewed-by: Thomas Chou > > Signed-off-by: Wills Wang > --- > > Changes in v7: > - remove map_physmem for debug port > > Changes in v6: > - Remove wait loop in putc and getc > - Use map_physmem instead of KSEG1ADDR > > Changes in v5: > - remove a

Re: [U-Boot] [PATCH v2 5/6] clk: add API to enable clock

2016-01-17 Thread Simon Glass
On 12 January 2016 at 21:16, Masahiro Yamada wrote: > The most basic thing for clock is to enable it, but it is missing > in this uclass. > > Signed-off-by: Masahiro Yamada > Acked-by: Simon Glass > --- > > Changes in v2: > - Add clk_enable() function > > drivers/clk/clk-uclass.c | 10 +++

Re: [U-Boot] [PATCH v2] patman: Add --thread option

2016-01-17 Thread Simon Glass
On 14 January 2016 at 16:12, Simon Glass wrote: > On 14 January 2016 at 12:37, Mateusz Kulikowski > wrote: >> Add option to create threaded series of patches. >> With it, it will be possible to create patch threads like this: >> [PATCH 0/10] Add support for time travel >> [PATCH 1/10] Add Flux

[U-Boot] [PATCH 0/2] Move commands into their own directory

2016-01-17 Thread Simon Glass
This series makes a start at cleaning up the common directory. At present it includes any code that is not board-specific, a library or a driver. This means there are a lot of files, including all the commands. Moving the command files into their own directory makes them easier to find and is more

[U-Boot] [PATCH 2/2] Remove the cmd_ prefix from command files

2016-01-17 Thread Simon Glass
Now that they are in their own directory, we can remove this prefix. This makes it easier to find a file since the prefix does not get in the way. Signed-off-by: Simon Glass --- cmd/Makefile | 258 ++--- cmd/{cmd_aes.c => aes.c}

[U-Boot] [PATCH 1/2] Move all command code into its own directory

2016-01-17 Thread Simon Glass
There are a lot of unrelated files in common, including all of the commands. Moving them into their own directory makes them easier to find and is more logical. Some commands include non-command code, such as cmd_scsi.c. This should be sorted out at some point so that the function can be enabled w

Re: [U-Boot] [v2] mmc: fsl_esdhc: fix mmc read/write error on T4080

2016-01-17 Thread Yangbo Lu
> -Original Message- > From: Tom Rini [mailto:tr...@konsulko.com] > Sent: Friday, January 15, 2016 2:09 AM > To: york sun > Cc: Andy Fleming; Yangbo Lu; U-Boot list > Subject: Re: [U-Boot] [v2] mmc: fsl_esdhc: fix mmc read/write error on > T4080 > > On Thu, Jan 14, 2016 at 05:51:32PM +

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: > We should avoid weak functions with driver model. Existing boards that use > driver model don't need them, so let's kill them off. > > Signed-off-by: Simon Glass > --- > > net/eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-17 Thread Dongsheng Wang
Hi Tom, Thanks for your review. I will update this patch. Regards, -Dongsheng > On Mon, Jan 11, 2016 at 02:51:39AM +, Dongsheng Wang wrote: > > Hi Tom, > > > > Sorry for my late reply, and thanks for your reply. > > > > How about the following comments, following your suggestion I remove >

Re: [U-Boot] x86: Bay Trail support with W83627DHG

2016-01-17 Thread Bin Meng
Hi Stefan, On Mon, Jan 18, 2016 at 1:44 AM, Stefan Roese wrote: > Hi Bin, > > On 17.01.2016 03:35, Stefan Roese wrote: >> >> On 16.01.2016 15:08, Bin Meng wrote: >>> >>> On Fri, Jan 15, 2016 at 10:37 PM, Stefan Roese wrote: Hi Simon, Hi Bin! I'm currently busy with porting U-

Re: [U-Boot] [PATCH v2 02/55] dm: usb: Add a compatible string for PCI EHCI controller

2016-01-17 Thread Marek Vasut
On Monday, January 18, 2016 at 12:11:07 AM, Simon Glass wrote: > Add a compatible string to allow this to be specified in the device tree > if needed. > > Signed-off-by: Simon Glass Acked-by: Marek Vasut Best regards, Marek Vasut ___ U-Boot mailing l

Re: [U-Boot] [PATCH 18/18] dm: video: test: Test that bitmap display works correctly

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:14 -0700 Simon Glass wrote: > Add a test for the 'bmp' command. Test both the uncompressed and compressed > versions of the file, since they use different code paths. > > Signed-off-by: Simon Glass > --- > > include/configs/sandbox.h | 2 ++ > test/dm/video.c

Re: [U-Boot] [PATCH 17/18] dm: video: test: Add tests for rotated consoles

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:13 -0700 Simon Glass wrote: > Test that text is displayed correctly when the console is rotated. > > Signed-off-by: Simon Glass > --- > > configs/sandbox_defconfig | 1 + > test/dm/video.c | 27 +++ > 2 files changed, 28 insertions(

Re: [U-Boot] [PATCH 16/18] dm: video: test: Add tests for the video uclass

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:12 -0700 Simon Glass wrote: > Add tests that check that the video console is working correcty. Also check > that text output produces the expected result. Test coverage includes > character output, wrapping and scrolling. > > Signed-off-by: Simon Glass > --- > > arch

Re: [U-Boot] [PATCH 15/18] dm: video: sandbox: Convert sandbox to use driver model for video

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:11 -0700 Simon Glass wrote: > Now that driver model support is available, convert sandbox over to use it. > We can remove a few of the special hooks that sandbox currently has. > > Signed-off-by: Simon Glass > --- > > arch/sandbox/dts/sandbox.dts | 1 + > board/sand

Re: [U-Boot] [PATCH 14/18] sandbox: Move CONFIG_VIDEO_SANDBOX_SDL to Kconfig

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:10 -0700 Simon Glass wrote: > Move this option to Kconfig. This is quite simple as only sandbox uses the > driver. > > Signed-off-by: Simon Glass > --- > > configs/sandbox_defconfig | 3 ++- > drivers/video/Kconfig | 9 + > include/configs/sandbox.h | 1 -

Re: [U-Boot] [PATCH 13/18] dm: stdio: video: Plumb the video uclass into stdio

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:09 -0700 Simon Glass wrote: > Register video drivers with stdio so that they can be used for text output. > This needs to be done explicitly for now. At some point we should be able to > convert stdio itself to driver model and avoid this step. > > Signed-off-by: Simon

Re: [U-Boot] [PATCH 12/18] dm: video: Implement the bmp command for driver model

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:08 -0700 Simon Glass wrote: > This command can use the bitmap display code in the uclass. This is similar > to the code in lcd.c and cfb_console.c. These other copies will go away when > all boards are converted to use driver model for video. > > Signed-off-by: Simon Gl

Re: [U-Boot] [PATCH 11/18] dm: common: Add memory reservation for the video uclass

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:07 -0700 Simon Glass wrote: > Before relocation we need to reserve memory for the video driver frame > buffers so that they can use this memory when they start up (after > relocation). Add a call to the uclass to permit this. > > The current top and bottom of the region

Re: [U-Boot] [PATCH 10/18] common: Move LCD and video memory reservation together

2016-01-17 Thread Anatolij Gustschin
On Tue, 5 Jan 2016 09:31:06 -0700 Simon Glass wrote: > These two functions are conceptually the same. Move them together in the > pre-relocation init. > > Signed-off-by: Simon Glass > --- > > common/board_f.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions

[U-Boot] Board specific hook for performing pre-os tweaks

2016-01-17 Thread Chris Packham
Hi, Is there any hook for performing board specific actions prior to booting the OS. A quick google search turned up this thread from 2014[1]. But the eventual outcome seemed to be that the device model will take care of restoring devices to their unused state, for anything else there is arch_preb

[U-Boot] [PATCH v2 40/55] x86: ivybridge: Use the I2C driver to perform SMbus init

2016-01-17 Thread Simon Glass
Move the init code into the I2C driver. Signed-off-by: Simon Glass Reviewed-by: Heiko Schocher Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/cpu.c | 39 +++ arch/x86/dts/chromebook_link.dts | 6 ++ configs/chromebook_link_

[U-Boot] [PATCH v2 19/55] x86: ivybridge: Move CPU init code into the driver

2016-01-17 Thread Simon Glass
Use the CPU driver's probe() method to perform the CPU init. This will happen automatically when the first CPU is probed. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/bd82x6x.c | 6 -- arch/x86/cpu/ivybridge/model_206ax.c

[U-Boot] [PATCH v2 47/55] x86: ivybridge: Convert pch.c to use DM PCI API

2016-01-17 Thread Simon Glass
Convert this file to use the driver model PCI API. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/lpc.c | 10 arch/x86/cpu/ivybridge/pch.c | 35 ++ arch/x86/cpu/ivybridge/sata.c

[U-Boot] [PATCH v2 30/55] x86: ivybridge: Do the SATA init before relocation

2016-01-17 Thread Simon Glass
The SATA device needs to set itself up so that it appears correctly on the PCI bus. The easiest way to do this is to set it up to probe before relocation. This can do the early setup. Signed-off-by: Simon Glass --- Changes in v2: - Update to use the disk uclass arch/x86/cpu/ivybridge/bd82x6x.c

[U-Boot] [PATCH v2 21/55] x86: ivybridge: Drop the dead MTRR code

2016-01-17 Thread Simon Glass
This is not used and MTRRs are set up elsewhere now. Drop it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/model_206ax.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/x86/cpu/ivybridge/model_206ax.c b/arch/x86/cpu/ivybr

[U-Boot] [PATCH v2 38/55] x86: Enable DM_USB for link and panther

2016-01-17 Thread Simon Glass
Move these two boards to use driver model for USB. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None configs/chromebook_link_defconfig | 2 ++ configs/chromebox_panther_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/chromebook_link_defconfig

[U-Boot] [PATCH v2 22/55] x86: ivybridge: Move early init code into northbridge.c

2016-01-17 Thread Simon Glass
This code is now part of the northbridge driver, so move it into the same place. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/Makefile | 1 - arch/x86/cpu/ivybridge/early_init.c | 81 arch/x86/cpu/i

[U-Boot] [PATCH v2 54/55] x86: ivybridge: Use syscon for the GMA device

2016-01-17 Thread Simon Glass
Until we have a proper video uclass we can use syscon to handle the GMA device, and avoid the special device tree and PCI searching. Update the code to work this way. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v2: None arch/x86/cpu/ivybridge/bd82x6x.c | 14 ++

[U-Boot] [PATCH v2 29/55] ahci: Add a disk-controller uclass

2016-01-17 Thread Simon Glass
Add a uclass ID for a disk controller. This can be used by AHCI/SATA or other controller types. There are no operations and no interface so far, but it is possible to probe a SATA device. Signed-off-by: Simon Glass --- Changes in v2: - Rename the AHCI uclass to DISK drivers/block/Kconfig

[U-Boot] [PATCH v2 48/55] x86: ivybridge: Move code from pch.c to bd82x6x.c

2016-01-17 Thread Simon Glass
This code relates to the PCH, so we should move it into the same file. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/Makefile | 1 - arch/x86/cpu/ivybridge/bd82x6x.c | 129 ++ arch/x86/cpu/ivybr

[U-Boot] [PATCH v2 41/55] x86: ivybridge: Convert enable_usb_bar() to use DM PCI API

2016-01-17 Thread Simon Glass
Convert this function over to use the driver model PCI API. In this case we want to avoid using the real PCI devices since they have not yet been probed. Instead, write directly to their PCI configuration address. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Avoid needi

[U-Boot] [PATCH v2 27/55] x86: ivybridge: Use driver model PCI API in bd82x6x.c

2016-01-17 Thread Simon Glass
Adjust most of the remaining functions in this file to use the driver model PCI API. The one remaining function is bridge_silicon_revision() which will need a little more work. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Drop northbridge_enable() arch/x86/cpu/ivybrid

[U-Boot] [PATCH v2 43/55] x86: ivybridge: Convert sdram_initialise() to use DM PCI API

2016-01-17 Thread Simon Glass
Convert this function to use the the driver model PCI API. We just need to pass in the northbridge device. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/sdram.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff -

[U-Boot] [PATCH v2 28/55] x86: ivybridge: Drop unnecessary northbridge setup

2016-01-17 Thread Simon Glass
This is done by default with PCI auto-config. Drop it. Signed-off-by: Simon Glass --- Changes in v2: - Rename from 'Move northbridge setup to the northbridge driver' - Drop this unnecessary init arch/x86/cpu/ivybridge/pci.c | 20 1 file changed, 20 deletions(-) diff --git

[U-Boot] [PATCH v2 37/55] x86: ivybridge: Convert lpc init code to DM PCI API

2016-01-17 Thread Simon Glass
Adjust this code to use the driver model PCI API. This is all called through lpc_init_extra(). Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/lpc.c | 129 ++- 1 file changed, 66 insertions(+), 63 deletion

[U-Boot] [PATCH v2 55/55] x86: fdt: Drop the unused compatible strings in fdtdec

2016-01-17 Thread Simon Glass
We have drivers for several more devices now, so drop the strings which are no-longer used. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Drop bd82x6x_pci_init() function and associated DM-conversion patch - Drop LPC init method an 'Add an init() method to the LPC uclass

[U-Boot] [PATCH v2 46/55] x86: ivybridge: Convert report_platform to DM PCI API

2016-01-17 Thread Simon Glass
Convert these functions to use the driver model PCI API. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/report_platform.c | 11 ++- arch/x86/cpu/ivybridge/sdram.c| 2 +- arch/x86/include/asm/arch-ivybridge/

[U-Boot] [PATCH v2 44/55] x86: chromebook_link: Enable the syscon uclass

2016-01-17 Thread Simon Glass
We will use a system controller to model the Intel Management Engine. Enable this for link. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None configs/chromebook_link_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/chromebook_link_defconfig b/con

[U-Boot] [PATCH v2 42/55] x86: ivybridge: Convert dram_init() to use DM PCI API

2016-01-17 Thread Simon Glass
Convert the top part of the DRAM init to use the driver model PCI API. Further work will complete the transformation. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/sdram.c | 39 +-- 1 file changed, 25 insert

[U-Boot] [PATCH v2 53/55] x86: Set up a shared syscon numbering schema

2016-01-17 Thread Simon Glass
Each system controller can have a number to identify it. It can then be accessed using syscon_get_by_driver_data(). Put this in a shared header file and update the only current user. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Enable SYSCON and REGMAP for panther to av

[U-Boot] [PATCH v2 26/55] x86: ivybridge: Move northbridge and PCH init into drivers

2016-01-17 Thread Simon Glass
Instead of calling the northbridge and PCH init from bd82x6x_init_extra() when the PCI bus is probed, call it from the respective drivers. Also drop the Northbridge init as it has no effect. The registers it touches appear to be read-only. Signed-off-by: Simon Glass --- Changes in v2: None arc

[U-Boot] [PATCH v2 34/55] x86: ivybridge: Move lpc_enable() into gma.c

2016-01-17 Thread Simon Glass
This graphics init code is best placed in the gma init code. Move the code and drop the function. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/bd82x6x.c | 1 - arch/x86/cpu/ivybridge/gma.c | 4 arch/x86/cpu/ivybridg

[U-Boot] [PATCH v2 45/55] x86: ivybridge: Convert SDRAM init to use driver model

2016-01-17 Thread Simon Glass
SDRAM init needs access to the Northbridge controller and the Intel Management Engine device. Add the latter to the device tree and convert all of this code to driver model. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/early_me.c| 68

[U-Boot] [PATCH v2 51/55] x86: ivybridge: Drop XHCI support

2016-01-17 Thread Simon Glass
This is not used on link which is the only ivybridge board. Drop this code. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/Makefile | 1 - arch/x86/cpu/ivybridge/usb_xhci.c | 32 --- arch/x86/i

[U-Boot] [PATCH v2 52/55] x86: ivybridge: Drop the SMM-locking code

2016-01-17 Thread Simon Glass
U-Boot does not support SMM yet, so we can drop this code. It is easy to bring back when needed. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/lpc.c | 57 1 file changed, 57 deletions(-) diff --git

[U-Boot] [PATCH v2 50/55] x86: ivybridge: Drop special EHCI init

2016-01-17 Thread Simon Glass
This is not needed. On reset wake-on-disconnect is already set. It may a problem during a soft reset or resume, but for now it does not seem important. Also drop the command register update since PCI auto-config does it for us. Signed-off-by: Simon Glass --- Changes in v2: - Rename from 'Convert

[U-Boot] [PATCH v2 49/55] x86: ivybridge: Sort out the calls to bridge_silicon_revision()

2016-01-17 Thread Simon Glass
This function is called all over the place. Convert it use the driver model PCI API, and rationalise the calls. Signed-off-by: Simon Glass --- Changes in v2: - Fix incorrect bits in bridge_silicon_revision() comment arch/x86/cpu/ivybridge/gma.c | 33 arch/

[U-Boot] [PATCH v2 15/55] x86: ivybridge: Move graphics init much later

2016-01-17 Thread Simon Glass
We don't need to init the graphics controller so early. Move it alongside the other graphics setup, just before we run the ROM. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/cpu.c| 1 - arch/x86/cpu/ivybridge/early_init.c | 80 ++-

[U-Boot] [PATCH v2 39/55] x86: i2c: Add a stub driver for Intel I2C/SMbus

2016-01-17 Thread Simon Glass
This is used on most Intel platforms. We don't have a driver for it yet, but add a stub to handle the init. For now this targets ivybridge so we may want to add a device tree binding and generalise it when other platforms are supported. Signed-off-by: Simon Glass Reviewed-by: Heiko Schocher Revi

[U-Boot] [PATCH v2 33/55] x86: ivybridge: Use driver model PCI API in sata.c

2016-01-17 Thread Simon Glass
Adjust the functions in this file to use the driver model PCI API. Signed-off-by: Simon Glass --- Changes in v2: - Drop unnecessary IRQ and command register init arch/x86/cpu/ivybridge/sata.c | 94 +-- 1 file changed, 45 insertions(+), 49 deletions(-) d

[U-Boot] [PATCH v2 36/55] x86: ivybridge: Drop the special PCI driver

2016-01-17 Thread Simon Glass
There is nothing special about the ivybridge pci driver now, so just use the generic one. Signed-off-by: Simon Glass --- Changes in v2: - Drop the special compatible string in chromebook_link.dts arch/x86/cpu/ivybridge/Makefile | 1 - arch/x86/cpu/ivybridge/pci.c | 46 ---

[U-Boot] [PATCH v2 17/55] x86: ivybridge: Move GPIO init to the LPC init() method

2016-01-17 Thread Simon Glass
This init can happen in the driver also. Move it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/cpu/ivybridge/cpu.c | 4 arch/x86/cpu/ivybridge/lpc.c | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/x86/cpu/ivybridge/cpu.c b

[U-Boot] [PATCH v2 25/55] x86: Bring up northbridge, pch and lpc after the CPUs

2016-01-17 Thread Simon Glass
These devices currently need to be inited early in boot. Once we have the init in the right places (with each device doing its own init and no problems with ordering) we should be able to remove this. For now it is needed to keep things working. Signed-off-by: Simon Glass --- Changes in v2: - Ad

[U-Boot] [PATCH v2 35/55] x86: ivybridge: Move LPC init into the LPC probe() method

2016-01-17 Thread Simon Glass
Drop the lpc_init_extra() function and just use the post-relocation LPC probe() instead. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Update to use LPC probe() method instead of init() arch/x86/cpu/ivybridge/bd82x6x.c | 4 arch/x86/cpu/ivybridge/lpc.c

[U-Boot] [PATCH v2 32/55] x86: ivybridge: Use the SATA driver to do the init

2016-01-17 Thread Simon Glass
Instead of manually initing the device, probe the SATA device and move the init there. Signed-off-by: Simon Glass --- Changes in v2: - Update to use the disk uclass arch/x86/cpu/ivybridge/bd82x6x.c | 13 + arch/x86/cpu/ivybridge/sata.c | 4 +++- arch/x

  1   2   >