[U-Boot] [PATCH] cmd/bdinfo: correct comment in board_detail

This appears to be a simple typo that dates back to the original implementation of board_detail in commit e79394643b26 ("common: Update cmd_bdinfo for PPC"). Signed-off-by: Chris Packham --- cmd/bdinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [U-Boot] [PATCH 1/5] arm: socfpga: Add checking function on searching boot device

On Jum, 2017-08-04 at 15:10 +0200, Marek Vasut wrote: > On 08/04/2017 07:37 AM, Chee, Tien Fong wrote: > > > > On Rab, 2017-08-02 at 23:32 +0200, Marek Vasut wrote: > > > > > > On 08/02/2017 12:21 PM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Isn, 2017-07-31 at 12:53 +0200, Marek Vasut

Re: [U-Boot] [PATCH 2/2] ARM: OMAP5: Enable support for AVS0 for OMAP5 production devices

On 8/5/2017 8:12 AM, Nishanth Menon wrote: > OMAP5432 did go into production with AVS class0 registers which were > mutually exclusive from AVS Class 1.5 registers. > > Most OMAP5-uEVM boards use the pre-production Class1.5 which has > production efuse registers set to 0. However on production

Re: [U-Boot] [PATCH 1/2] ARM: OMAP5: Remove OPP_LOW Definitions for ES2.0

On 8/5/2017 8:12 AM, Nishanth Menon wrote: > ES2.0 descopes OPP_LOW definition. So remove it from macros defined. Reviewed-by: Lokesh Vutla Thanks and regards, Lokesh ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 1/5] mmc: uniphier-sd: Factor out register IO

Hi Marek, 2017-08-06 4:23 GMT+09:00 Marek Vasut : > On 08/03/2017 02:36 PM, Masahiro Yamada wrote: >> Hi Marek, > > Hi, > > [...] > >>> +static u32 uniphier_sd_readl(struct uniphier_sd_priv *priv, const u32 reg) >> >> "const" is unneeded here. > > Why? The function should

Re: [U-Boot] [PATCH v2 2/3] regulator: pbias: Add PBIAS regulator for proper voltage switching on MMC1

Hi JJ, On 08/04/2017 09:26 PM, Jean-Jacques Hiblot wrote: > Hi Jaehoon, > > > On 01/08/2017 06:23, Jaehoon Chung wrote: >> Dear JJ, >> >> On 07/19/2017 10:52 PM, Jean-Jacques Hiblot wrote: >>> In the TI SOCs a PBIAS cell exists to provide a bias voltage to the MMC1 >>> IO cells. Without this

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

Hi : When run buildman rockchip on the master branch of current u-boot-rockchip tree, I got warnings about 16 rockchip arm32 based boards: include/config/auto.config: line x: ARCH: command not found. the line x is the definition of the: SPL_LDSCRITP

[U-Boot] [PATCH v2] m68k: add board stmark2, mcf5441x based

Sysam stmark2 board is a generic and fully (hw and sw) open board, with a mcf54415 Coldfire CPU, 128MB of DDR2, 16MB of SPI flash and SD card as non volatile memories, and a wifi module included on-board. The board is actually used mainly for Coldfire custodian testing activity related to the

Re: [U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

Hi Marek, On 6 August 2017 at 13:17, Marek Vasut wrote: > On 08/06/2017 07:15 AM, Simon Glass wrote: >> On 24 July 2017 at 09:07, wrote: >>> From: Patrice Chotard >>> >>> Add CONFIG_DM_USB flag to avoid following compilation

Re: [U-Boot] [PATCH 2/4] dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB

On 08/06/2017 07:15 AM, Simon Glass wrote: > On 24 July 2017 at 09:07, wrote: >> From: Patrice Chotard >> >> Add CONFIG_DM_USB flag to avoid following compilation errors >> detected by buildman : >> +drivers/usb/host/built-in.o: In function

Re: [U-Boot] [PATCH] m68k: add board stmark2, mcf5441x based

Hi Bin, On 05/08/2017 15:19, Bin Meng wrote: Hi Angelo, On Sat, Jul 15, 2017 at 5:45 AM, Angelo Dureghello wrote: Signed-off-by: Angelo Dureghello Can you please write something about your board in the commit message? sure, sending patch v2. ---

Re: [U-Boot] [PATCH] m68k: add board stmark2, mcf5441x based

Hi Christophe, On 05/08/2017 14:58, christophe leroy wrote: Le 14/07/2017 à 23:45, Angelo Dureghello a écrit : Signed-off-by: Angelo Dureghello --- arch/m68k/Kconfig | 5 + board/sysam/stmark2/Kconfig | 15 +++ board/sysam/stmark2/MAINTAINERS

Re: [U-Boot] [RFC] efi_loader: Add test to boot OpenBSD's efi bootloader

On Sun, Aug 6, 2017 at 2:54 PM, Mark Kettenis wrote: >> From: Rob Clark >> Date: Sun, 6 Aug 2017 12:10:28 -0400 >> >> Signed-off-by: Rob Clark >> --- >> Kinda works, but since we don't have an 'exit' command like grub, we >>

Re: [U-Boot] [RFC] efi_loader: Add test to boot OpenBSD's efi bootloader

> From: Rob Clark > Date: Sun, 6 Aug 2017 12:10:28 -0400 > > Signed-off-by: Rob Clark > --- > Kinda works, but since we don't have an 'exit' command like grub, we > have to reboot, which leaves the "board" in a bad state (I guess, > since the next test

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

On Sun, Aug 6, 2017 at 2:47 PM, Rob Clark wrote: > On Sun, Aug 6, 2017 at 2:37 PM, Mark Kettenis wrote: >>> Date: Sun, 6 Aug 2017 20:21:45 +0200 (CEST) >>> From: Mark Kettenis >>> >>> > Mind sending me or pastebin'ing your

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

On Sun, Aug 6, 2017 at 2:37 PM, Mark Kettenis wrote: >> Date: Sun, 6 Aug 2017 20:21:45 +0200 (CEST) >> From: Mark Kettenis >> >> > Mind sending me or pastebin'ing your u-boot .config? There are some >> > different device-path construction

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

On Sun, Aug 6, 2017 at 2:21 PM, Mark Kettenis wrote: >> From: Rob Clark >> Date: Sun, 6 Aug 2017 13:49:43 -0400 >> >> On Sun, Aug 6, 2017 at 1:28 PM, Mark Kettenis >> wrote: >> >> From: Rob Clark >> >>

Re: [U-Boot] [PATCH] efi_loader: LocateHandle should return EFI_NOT_FOUND if none found

> From: Rob Clark > Date: Sun, 6 Aug 2017 12:23:50 -0400 > > Spotted this debugging OpenBSD's bootloader in qemu. (Wouldn't really > fix anything, the problem was not having any disks, but we should > probably return the correct error code.) > > Signed-off-by: Rob Clark

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

> Date: Sun, 6 Aug 2017 20:21:45 +0200 (CEST) > From: Mark Kettenis > > > Mind sending me or pastebin'ing your u-boot .config? There are some > > different device-path construction depending on legacy vs > > CONFIG_DM+CONFIG_BLK (the legacy case *looks* right to me, and

Re: [U-Boot] [PATCH] Convert CONFIG_SYS_I2C_OMAP24XX et al to Kconfig

On Thu, Jul 27, 2017 at 6:55 AM, Tom Rini wrote: > On Wed, Jul 26, 2017 at 09:22:06PM -0500, Adam Ford wrote: >> On Wed, Jul 26, 2017 at 8:52 PM, Tom Rini wrote: >> > On Wed, Jul 26, 2017 at 09:03:37AM -0500, Adam Ford wrote: >> > >> >> This converts the

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

> From: Rob Clark > Date: Sun, 6 Aug 2017 13:49:43 -0400 > > On Sun, Aug 6, 2017 at 1:28 PM, Mark Kettenis wrote: > >> From: Rob Clark > >> Date: Sun, 6 Aug 2017 11:34:15 -0400 > >> > >> On Sun, Aug 6, 2017 at 10:45 AM, Rob

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

On Sun, Aug 6, 2017 at 6:49 PM, Rob Clark wrote: > On Sun, Aug 6, 2017 at 1:28 PM, Mark Kettenis wrote: >>> From: Rob Clark >>> Date: Sun, 6 Aug 2017 11:34:15 -0400 >>> >>> On Sun, Aug 6, 2017 at 10:45 AM, Rob Clark

[U-Boot] [PATCH v2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none found

Spotted this debugging OpenBSD's bootloader in qemu. (Wouldn't really fix anything, the problem was not having any disks, but we should probably return the correct error code.) Signed-off-by: Rob Clark --- v2: early-return in the EFI_NOT_FOUND case, as suggested by Heinrich

Re: [U-Boot] [U-Boot, v4, 10/66] spl: dm: Kconfig: SPL_RAM depends on SPL_DM

> This commit models the dependency from SPL_RAM to SPL_DM in Kconfig. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v4: None > Changes in v3: None >

Re: [U-Boot] [U-Boot, v2, 5/6] rockchip: lion-rk3368: defconfig: enable DM timer for all stages

> There is no reasonably robust way (this will be needed so early that > diagnostics will be limited) to specify the base-address of the secure > timer through the DTS for TPL and SPL. In order to allow us a cleaner > way to structure our SPL and TPL stage, we now move to a DM timer > driver. >

Re: [U-Boot] [U-Boot, v4, 61/66] spl: support TPL_STACK, TPL_MAX_SIZE and TPL_TEXT_BASE via Kconfig

> Let's clean up behind ourselves and move the (newly defined) > TPL_STACK, TPL_MAX_SIZE and TPL_TEXT_BASE into Kconfig. Given that > 0x0 might be considered to be valid values for TPL_TEXT_BASE and > TPL_STACK, we need to introduce helper config options > ("TPL_NEEDS_SEPARATE_...") to indicate

Re: [U-Boot] [U-Boot, v4, 12/66] spl: dm: Kconfig: SPL_CLK depends on SPL_DM

> SPL_CLK should also depend on SPL_DM (and not just on CLK). > Add the additional dependency. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v4: None >

Re: [U-Boot] [U-Boot, v4, 54/66] rockchip: spl: make spl-boot-order code reusable (split from rk3399)

> In order to reuse the support for the u-boot,spl-boot-order property > from the rk3399, we split it into a reusable module that can be > included by the SPL code for any of our boards. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 37/66] rockchip: pinctrl: rk3368: add SPI support

> To implement pinctrl support for the RK3368, we need to add the > bit-definitions to configure the IOMUX and tie these into the > pinctrl framework. This also adds the mapping from the IRQ# back > onto the periheral id for the SPI devices. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 16/66] armv8: move low-level assembly functions into function-sections

> TPL builds today don't need to call into firmware or set up the MMU > (if this changes, it should be controlled through a config option > whether to include this or not), but include the needed support code > for this anyway. By moving these unused low-level functions into > seperate

Re: [U-Boot] [U-Boot, v4, 34/66] rockchip: pinctrl: rk3368: add GMAC (RGMII only) support

> To add GMAC (Gigabit Ethernet) support (limited to RGMII only at this > point), we need support for additional pin-configuration. This commit > adds the pinctrl support for GMAC in RGMII mode: > * adds a PERIPH_ID_GMAC and the mapping from IRQ number to PERIPH_ID > * configures the RGMII pins

Re: [U-Boot] [U-Boot, v4, 53/66] rockchip: rk3368: spl: add TPL support

> This adds the TPL support for the RK3368, including the u-boot-tpl.lds. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass > --- > > Changes in v4: None > Changes in v3: > - removes the '#define DEBUG' > - uses the syscon

Re: [U-Boot] [U-Boot, v4, 23/66] drivers: spl: consistently use the $(SPL_TPL_) macro

> To simplify drivers/Makefile a bit when using TPL/SPL, we consistently > use the $(SPL_TPL_) macro to test for drivers that have separate > configuration symbols for the full U-boot, SPL and TPL stages. > Instead of explicitly repeating them in two separate if-guarded > sections of the Makefile,

Re: [U-Boot] [U-Boot, v4, 20/66] lib: spl: differentiate between TPL and SPL for libfdt/of_control/of_platdata

> This splits the compilation of code modules for TPL and SPL for > OF_CONTROL (and related) features between TPL and SPL. The typical > use-case of this is a TPL stage that uses OF_PLATDATA at TPL and > provides full OF_CONTROL at SPL (e.g. on the RK3368). > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 39/66] rockchip: clk: rk3368: support OF_PLATDATA for the RK3368 clk driver

> With the RK3368's limited TPL size, we'll want to use OF_PLATFDATA for > the SPL stage. This implements support for OF_PLATDATA in the clock > driver for the RK3368. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass >

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

On Sun, Aug 6, 2017 at 1:28 PM, Mark Kettenis wrote: >> From: Rob Clark >> Date: Sun, 6 Aug 2017 11:34:15 -0400 >> >> On Sun, Aug 6, 2017 at 10:45 AM, Rob Clark wrote: >> > >> > I've started trying to hack up test_efi_loader.py

Re: [U-Boot] [U-Boot, v4, 36/66] rockchip: pinctrl: rk3368: move IOMUX bit-definitions to pinctrl driver

> There is no real reason to keep the bit-definitions for the IOMUX in > the grf header file (which defines the register layout of the GRF block): > these should only be used by our pinctrl driver (with the possible > exception of early debug-init code in TPL/SPL). > > This moves the relevant

Re: [U-Boot] [U-Boot, v4, 26/66] rockchip: rk3368: mkimage: add support for the RK3368

> This commit adds support for RK3368 SoC in mkimage. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > tools/rkcommon.c | 1 + > 1 file

Re: [U-Boot] [U-Boot, v2, 6/6] rockchip: rk3368: remove setup of secure timer from TPL/SPL

> When using DM timers w/ the timer0 block within the RK3368, we no > longer depend on the ARMv8 generic timer counting. This allows us to > drop the secure timer initialisation from the TPL and SPL stages. > > The secure timer will later be set up by ATF, which starts the ARMv8 > generic timer.

Re: [U-Boot] [U-Boot, v2, 1/6] timer: add OF_PLATDATA support for timer-uclass

> The timer-uclass depends on full OF_CONTROL through its interrogation > of /chosen and the code to determine the clock-frequency. > > For the OF_PLATDATA case, these code-paths are disabled and it becomes > the timer driver's responsibility to correctly set the clock-frequency > in the uclass

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

> Set TPL_LDSCRIPT in Kconfig, so we don't have to pollute our > header file. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass > --- > > Changes in v4: > - (added) sets TPL_LDSCRIPT via Kconfig > > Changes in v3: None >

Re: [U-Boot] [U-Boot, 1/3] spl: add hierarchical defaults for SPL_LDSCRIPT

> With SPL_LDSCRIPT moved to Kconfig (and this being a 'string' config > node), all the lingering definitions in header files will cause errors > due to the redefinition of the configuration item. > > As we don't want to pollute the defconfig files (and values should > usually be identical for

Re: [U-Boot] [U-Boot, v2, 2/6] dm: timer: normalise SPL and TPL support

> To fully support DM timer in SPL and TPL, we need a few things cleaned > up and normalised: > - inclusion of the uclass and drivers should be an all-or-nothing > decision for each stage and under control of $(SPL_TPL_)TIMER > instead of having the two-level configuration with TIMER and >

Re: [U-Boot] [PATCH v0 13/20] efi_loader: use proper device-paths for partitions

> From: Rob Clark > Date: Sun, 6 Aug 2017 11:34:15 -0400 > > On Sun, Aug 6, 2017 at 10:45 AM, Rob Clark wrote: > > > > I've started trying to hack up test_efi_loader.py to add a test that > > loads OpenBSD's bootloader.. kinda muddling through it at

Re: [U-Boot] [U-Boot, v4, 63/66] rockchip: rk3368: mark TPL as not inheriting its stack, text-base and size from SPL

> The RK3368 needs to have a different base-address and stack-pointer > for its TPL stage. Now that we want to do this via Kconfig, we need > to tick the appropriate 'TPL_NEEDS_...' boxes. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 48/66] net: gmac_rockchip: Add support for the RK3368 GMAC

> The GMAC in the RK3368 once again is identical to the incarnation in > the RK3288 and the RK3399, except for where some of the configuration > and control registers are located in the GRF. > > This adds the RK3368-specific logic necessary to reuse this driver. > > Signed-off-by: Philipp

Re: [U-Boot] [U-Boot, v4, 22/66] spl: add TPL_DRIVER_MISC_SUPPORT option

> This adds the TPL_DRIVER_MISC_SUPPORT option to allow activation of > DRIVER_MISC_SUPPORT for devices that need it in the TPL stage. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini

Re: [U-Boot] [U-Boot, v4, 46/66] rockchip: clk: rk3368: mark 'priv' __maybe_unused in rk3368_clk_set_rate()

> With the clock support in rk3368_clk_set_rate() conditionalized on > various feature definitions, 'priv' can remain unused (e.g. in the > SPL build when only MMC is enabled). > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 51/66] rockchip: rk3368: dts: add DMC node in rk3368.dtsi

> For full SPL support, including DRAM initialisation, we need a few > nodes from the DTS: this commit adds the DMC (DRAM controller) node, > the service_msch (memory scheduler) node and marks GRF, PMUGRF and CRU > as 'u-boot,dm-pre-reloc'. In addition to this, we also include the > dt-binding

Re: [U-Boot] [U-Boot, v4, 14/66] spl: dm: Kconfig: split OF_CONTROL and OF_PLATDATA between SPL and TPL

> For the RK3368, we want to use OF_PLATDATA in TPL, but full OF_CONTROL > in SPL: this requires the introduction of a new family of > configuration options to decouple SPL_OF_CONTROL and SPL_OF_PLATDATA > from TPL. > > Consequently, Makefile.spl needs to be adjusted to test for these >

Re: [U-Boot] [U-Boot, v4, 41/66] rockchip: clk: rk3368: implement DPLL (DRAM PLL) support

> To implement a TPL stage (incl. its DRAM controller setup) for the > RK3368, we'll want to configure the DPLL (DRAM PLL). > > This commit implements setting the DPLL (CLK_DDR) and provides PLL > configuration details for the common DRAM operating speeds found on > RK3368 boards. > >

Re: [U-Boot] [U-Boot, v4, 49/66] rockchip: Makefile: streamline SPL/TPL configuration

> Handling TPL and SPL in the Makefile for mach-rockchip was based on > nested if checks and/or if-else-if paths. This can be simplified and > made more readable by using $(SPL_TPL_) and by introducing > intermediate variables for the aggregation of SPL and TPL features. > > Signed-off-by:

Re: [U-Boot] [U-Boot, v4, 64/66] moveconfig: migrate TPL_STACK, TPL_TEXT_BASE and TPL_MAX_SIZE

> We can finally drop TPL_STACK, TPL_TEXT_BASE and TPL_MAX_SIZE off the > whitelist (this time it's really happening!) and migrate the setting > (only used on the RK3368-uQ7 so far) into Kconfig. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 42/66] rockchip: clk: rk3368: define DMA1_SRST_REQ and DMA2_SRST_REQ

> On he RK3368, we need to temporarily disable security on the DMA > engines during TPL and SPL to allow the MMC host to DMA into DRAM. To > do so, we need to reset the two DMA engines, which in turn requires > the DMA1_SRST_REQ and DMA2_SRST_REQ constants to refer to the > appropriate bits in

Re: [U-Boot] [U-Boot, v4, 09/66] spl: dm: Kconfig: split REGMAP/SYSCON support for TPL from SPL

> This change introduces TPL variants of the REGMAP and SYSCON config > options (i.e. TPL_REGMAP and TPL_SYSCON in analogy to SPL_REGMAP and > SPL_SYSCON) in preparation of a finer-grained feature selection for > building feature-rich TPL variants. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 24/66] rockchip: Makefile: allow selective inclusion of sdram_common.o from TPL/SPL/U-Boot

> The utility functions in sdram_common.c will be useful both for some > SPL implementations (and if unused, the linked will discard these > anyway) and for the full U-Boot stage. > > This changes selects sdram_common.o through the $(SPL_TPL_) macro to > allow better control of its inclusion

Re: [U-Boot] [U-Boot, v4, 21/66] spl: consistently use $(SPL_TPL_) to select features for SPL and TPL builds

> To allow for a finer-grained control of features for TPL and SPL > builds all modules/boot-methods/etc. need to be consistently selected > based on the $(SPL_TPL_) macros. > > This allows splitting the associated config-options in Kconfig: we > don't split the Kconfig options here and now, as

Re: [U-Boot] [U-Boot, v4, 15/66] spl: dm: use CONFIG_IS_ENABLED to test for the DM option

> Even though there's now a TPL_DM configuration option, the spl logic > still checks for SPL_DM and thus does not pick up the proper config > option. > > This introduces the use of CONFIG_IS_ENABLED(DM) in spl.c to always > pick up the desired configuration option instead of having a >

Re: [U-Boot] [U-Boot, v4, 08/66] spl: dm: Kconfig: use more specific prereqs for SPL_REGMAP and SPL_SYSCON

> SPL_REGMAP and SPL_SYSCON were marked as depending on DM, when a > stricter dependency of SPL_DM was possible. This commit makes the > prereq more specific. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass >

Re: [U-Boot] [U-Boot, v4, 47/66] rockchip: clk: rk3368: add support for configuring the SPI clocks

> As SPI support may be useful in the boot-flow, this adds support for > configuring the SPI controller's clocks in the RK3368 clock driver. > > Reviewed-by: Simon Glass > Signed-off-by: Philipp Tomsich > --- > > Changes in v4: None >

Re: [U-Boot] [U-Boot, v2, 4/6] dts: rk3368: make timer0 accessible for SPL and TPL

> To use it with the DM timer driver in SPL and TPL, timer0 needs to be > marked as pre-reloc. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass > --- > > Changes in v2: > - add 'clock-frequency' prop to timer in the

Re: [U-Boot] [U-Boot, v4, 59/66] spl: Kconfig: migrate $(SPL_TPL_)LDSCRIPT to Kconfig

> Now that we have split up SPL_LDSCRIPT into a SPL and TPL variant and > have started to use the TPL-variant for the RK3368, it's time to clean > up behind ourselves: move both variants into Kconfig and remove them > from the whitelist. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 57/66] rockchip: spi: enable support for the rk_spi driver for the RK3368

> For the RK3368, we can reuse the SPI driver (although we'll have to > eventually investigate whether it can be merged with the > designware_spi.c driver) also used for the RK3288 and RK3399. > This adds the necessary compatible string to support the RK3368. > > Note that the assumption that

Re: [U-Boot] [U-Boot, v4, 33/66] rockchip: rk3368: dts: add sgrf node

> We will to drop device security temporarily (until the ATF initialises > it fully) from the TPL/SPL stage: this requires access to some > registers in the SGRF. > > This adds the sgrf node to the rk3368.dtsi, so we can then bind a > syscon device onto it and access its memory ranges. > >

Re: [U-Boot] [U-Boot, v4, 28/66] rockchip: rk3368: spl: define COUNTER_FREQUENCY to 24MHz

> The BootROM of the RK3368 Boot ROM does not initialise cntfrq_el0. > This change defines COUNTER_FREQUENCY, which is used by the AArch64 init > code in arch/arm/cpu/armv8/start.S to set up cntfrq_el0. > > If the counter-frequency is not correctly set up, the calculation of > delays using the

Re: [U-Boot] [U-Boot, 3/3] rockchip: rk3368: spl: move SPL_LDSCRIPT to Kconfig

> With the new way of doing things (i.e. the hierarchical selection of > SPL_LDSCRIPT via Kconfig) in place, this moves the SPL_LDSCRIPT setting > for the RK3368 from defconfig back into Kconfig. > > With this done, there should be no lingering cases of SPL_LDSCRIPT > outside of Kconfig files. >

Re: [U-Boot] [U-Boot, v4, 19/66] spl: Kconfig: split SYS_MALLOC_SIMPLE for TPL and SPL

> As include/malloc.h already checks for SYS_MALLOC_SIMPLE using the > CONFIG_IS_ENABLED macro, we need to move to having separate entries > as we switch to fully separate configuration for SPL and TPL. > > Signed-off-by: Philipp Tomsich > > Reviewed-by:

Re: [U-Boot] [U-Boot, v4, 30/66] rockchip: rk3368: syscon: MSCH/PMUGRF/GRF support for OF_PLATDATA

> The RK3368 has both a limited TPL size (just 0x7000 bytes) and the > added challenge of booting in AArch64, which increases the code size > for TPL (particularily when using the LP64 programming model). For > this reason we expect the RK3368 to always use OF_PLATDATA for its > TPL stage. > >

Re: [U-Boot] [U-Boot, v4, 29/66] rockchip: rk3368: spl: add memory layout for TPL and SPL

> For the RK3368, we use a multi-stage boot-process consisting of the > following: > 1. TPL: initalises DRAM, returns to boot-ROM (which then loads >the next stage and transfers control to it) > 2. SPL: a full-features SPL stage including OF_CONTROL and FIT >image

Re: [U-Boot] [U-Boot, v4, 44/66] rockchip: clk: rk3368: support configuring the DRAM PLL (from TPL)

> As part of the DRAM initialisation process (running as part of the TPL > stage) on the RK3368, we need to set up the DRAM PLL. > > This implements support for configuring the PLL to for 1200, 1332 or > 1600 MHz (i.e. for DDR3-1200, DDR3-1333, DDR3-1600 operating modes). > > Signed-off-by:

Re: [U-Boot] [U-Boot, v4, 25/66] rockchip: rk3368: improve Kconfig text for the RK3368

> The RK3368 option in Kconfig referred to the RK3328 (copy-and-paste) > and had a few typos and unnecessarily used UTF-8 characters. While > fixing this, I also reformatted and further clarified the text > (e.g. made the grouping into a a big and little cluster of 4 cores > each explicit). > >

Re: [U-Boot] [U-Boot, v4, 27/66] rockchip: rk3368: pmugrf: add definitions for os_reg[0..3]

> On the RK3368 we use a TPL-stage similar to Rockchip's DDR init > (i.e. it initialises DRAM, leaves some info for the next stage and > returns to the BootROM). To allow compatibility with Rockchip's DDR > init code, we use the same register os_reg2 in pmugrf for passing > this info (i.e. DRAM

Re: [U-Boot] [U-Boot, v4, 38/66] rockchip: clk: rk3368: implement bandwidth adjust for PLLs

> The RK3368 TRM recommends to configure the bandwith adjustment (CON2) > for PLLs to NF/2. This implements this for all reconfigurations of > PLLs and removes the 'has_bwadj' flag (as the RK3368 always has the > bandwidth-adjustment feature according to its manual). > > Signed-off-by: Philipp

Re: [U-Boot] [U-Boot, v4, 43/66] rockchip: clk: rk3368: implement MMC/SD clock reparenting

> The original clock support for MMC/SD cards on the RK3368 suffered > from a tendency to select a divider less-or-equal to the the one > giving the requested clock-rate: this can lead to higher-than-expected > (or rather: higher than supported) clock rates for the MMC/SD > communiction. > > This

Re: [U-Boot] [U-Boot, v4, 13/66] spl: dm: Kconfig: split CLK support for SPL and TPL

> Introduce TPL_CLK to allow finer-grained selection of TPL features > for feature-rich (i.e. DM-based) TPL stages. > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini > --- > >

Re: [U-Boot] [U-Boot, v4, 17/66] armv8: spl: Support separate stack for TPL

> To allow a TPL and SPL to run from different addresses/memories, we > need to split setup of the TPL and SPL stacks. To do so, we introduce > CONFIG_TPL_STACK (not listed in Kconfig) which can be used to override > the initial stack pointer for TPL. > > To provide backward compatibility for

Re: [U-Boot] rockchip: rk3188: rock: adjust for SPL/TPL split

> With the changes to split SPL/TPL for the RK3368, I apparently missed > some needed adjustments to the RK3188 Kconfig and rock_defconfig. > > This fixes build-issues for the rock board after applying the RK3368 > enablement (and SPL/TPL) set that resulted from TPL_SERIAL_SUPPORT, >

Re: [U-Boot] [U-Boot, v4, 50/66] rockchip: rk3368: add DRAM controller driver with DRAM initialisation

> This adds a DRAM controller driver for the RK3368 and places it in > drivers/ram/rockchip (where the other DM-enabled DRAM controller > drivers for rockchip devices should also be moved eventually). > > At this stage, only the following feature-set is supported: > - DDR3 > - 32-bit

Re: [U-Boot] [U-Boot, v4, 31/66] rockchip: rk3368: syscon: SGRF support for OF_PLATDATA

> In TPL we will need to configure security in the SGRF of the RK3368. > This change adds support for the SGRF as a syscon device, so we can > retrieve its address range through the syscon API in TPL (and can > avoid having to hard-code the address). > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 45/66] rockchip: clk: rk3368: add support for GMAC (SLCK_MAC) clock

> To enable the GMAC on the RK3368, we need to set up the clocking > appropriately to generate a tx_clk for the MAC. > > This adds an implementation that implements the use of the <_gmac> > clock (i.e. an external 125MHz clock for RGMII provided by the PHY). > This is the clock setup used by the

Re: [U-Boot] [U-Boot, v4, 52/66] rockchip: rk3368: spl: enable SPL_FRAMEWORK in rk3368_common.h

> To build TPL and SPL stages for the RK3368, we will also need to > enable the SPL_FRAMEWORK. > > Signed-off-by: Philipp Tomsich > > Version-changes: 2 > - dropped duplicate definition (this in fact dropped one of the > patches in this series) of

Re: [U-Boot] [U-Boot, v4, 40/66] rockchip: clk: rk3368: do not change CPLL/GPLL before returning to BROM

> The RK3368 has a somewhat temperamental BootROM (which I learned the > hard way) when it comes to reconfiguring the CPLL and GPLL (in fact, > experiments show that changing the GPLL broke things for me, while > changing the CPLL seems to be more benign). These should not be > modified by the

Re: [U-Boot] [U-Boot, v4, 56/66] rockchip: rk3368: spl: mark SPL and TPL as supported for ROCKCHIP_RK3368

> With SPL and TPL support for the RK3368 in place, mark SPL and TPL as > supported from Kconfig for the RK3368. As this is primarily tested on > the RK3368-uQ7, we'll leave it to board's individual defconfig to > enable. > > Also enable DEBUG_UART_BOARD_INIT for the RK3368, so we get output >

Re: [U-Boot] [U-Boot, v4, 11/66] spl: dm: Kconfig: introduce TPL_RAM (in analogy to SPL_RAM)

> To allow finer grained selection of features for TPL, we introduce > TPL_RAM (in analogy to SPL_RAM). > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in

Re: [U-Boot] [U-Boot, v4, 62/66] armv8: TPL_STACK will always be defined, so test CONFIG_TPL_NEEDS_SEPARATE_STACK

> Now that TPL_STACK has been moved off the whitelist (ok, I'm lying: > the 'moving off the whitelist' part comes in once moveconfig > runs... which will be a few commits down the line) and added to > Kconfig, we need to test CONFIG_TPL_NEEDS_SEPARATE_STACK to see > whether the value from

Re: [U-Boot] [U-Boot, v4, 35/66] rockchip: pinctrl: rk3368: add support for configuring the MMC pins

> The RK3368 has two SD/MMC controllers that can be used from U-Boot > both during SPL and for booting an OS from the full bootloader stage. > While both are configured to (mostly) sensible settings from the BROM, > additional configuration for the MMC controller is needed to configure > it to

Re: [U-Boot] [U-Boot, v4, 65/66] rockchip: board: puma-rk3399: fix warnings in puma_rk3399/fit_spl_atf.its

> The ITS file generated warnings due to @ designations in the naming > which cause DTC to complain as follows: > Warning (unit_address_vs_reg): Node /images/uboot@1 has a unit name, but no > reg property > Warning (unit_address_vs_reg): Node /images/atf@1 has a unit name, but no > reg

Re: [U-Boot] [U-Boot, v2, 3/6] rockchip: timer: add device-model timer driver for RK3368 (and similar)

> This adds a device-model driver for the timer block in the RK3368 (and > similar devices that share the same timer block, such as the RK3288) for > the down-counting (i.e. non-secure) timers. > > This allows us to configure U-Boot for the RK3368 in such a way that > we can run with the secure

Re: [U-Boot] [U-Boot, v4, 58/66] rockchip: board: lion-rk3368: add support for the RK3368-uQ7

> The RK3368-uQ7 (codenamed 'Lion') is a micro-Qseven (40mm x 70mm, > MXM-230 edge connector compatible with the Qseven specification) > form-factor system-on-module based on the octo-core Rockchip RK3368. > It is designed, supported and manufactured by Theobroma Systems. > > It provides the

Re: [U-Boot] [U-Boot, v4, 18/66] spl: allow a separate TEXT_BASE, LDSCRIPT and MAX_SIZE for TPL

> For the bringup of the RK3368, we need to support TPL and SPL running > from different addresses... which requires both stages to use a > distinct TEXT_BASE. > > This commit adds support for having a separate LDSCRIPT for TPL (which > is expected to make use of the TPL_MAX_SIZE define) and for

Re: [U-Boot] [U-Boot, v4, 32/66] rockchip: rk3368: grf: use shifted-constants

> The RK3368 GRF header was still defines with a shifted-mask but with > non-shifted function selectors for the IOMUX defines. As the RK3368 > support is still fresh enough to allow a quick change, we do this now > before having more code use this. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 55/66] rockchip: rk3368: spl: add SPL support

> Adds SPL support for the RK3368 (assuming that our TPL stage has > initialised DRAM and set up the memory firewall). > > Signed-off-by: Philipp Tomsich > > Reviewed-by: Simon Glass > --- > > Changes in v4: None > Changes in v3: None

Re: [U-Boot] [U-Boot, v4, 66/66] rockchip: board: puma_rk3399: rename ATF firmware

> From: Klaus Goger > > prefix the bl31 firmware needed to build uboot.itb so it can coexist in > the build area with ATFs from other boards (i.e. lion_rk3368) > > Signed-off-by: Klaus Goger > > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 07/66] spl: dm: Kconfig: fix help text for SPL/TPL confusion

> TPL_NAND_SUPPORT, TPL_SERIAL_SUPPORT, TPL_SPI_FLASH_SUPPORT and > TPL_SPI_SUPPORT refer to SPL in their help text. This fixes up > the description to correctly reference TPL. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Simon Glass

Re: [U-Boot] [U-Boot, v4, 02/66] spl: configure 'return to bootrom' separately for SPL and TPL

> On the RK3368, we want our TPL to use the 'return to bootrom' boot > method (to have the bootrom load up the SPL stage) and then continue > with different boot methods (MMC, SPI, etc.) from SPL. > > This adds the config option needed to control the availabily of the > 'return to bootrom'

Re: [U-Boot] [U-Boot, v4, 04/66] rockchip: back-to-bootrom: split BACK_TO_BOOTROM for TPL/SPL

> The back-to-bootrom option is rather unfortunately named > CONFIG_ROCKCHIP_SPL_BACK_TO_BOOTROM > instead of > CONFIG_SPL_ROCKCHIP_BACK_TO_BOOTROM > > To make is selectable through CONFIG_IS_ENABLED(ROCKCHIP_BACK_TO_BOOTROM), > we need to rename it. At the same time, we introduce a TPL_

Re: [U-Boot] [U-Boot, v4, 05/66] rockchip: back-to-bootrom: simplify the #ifdef-check for LIBGENERIC in TPL/SPL

> With the finer-grained control over LIBGENERIC_SUPPORT for TPL/SPL (i.e. > with the newly introduced distinction between TPL_LIBGENERIC_SUPPORT and > SPL_LIBGENERIC_SUPPORT), we can simplify the #ifdef-check to simply use > CONFIG_IS_ENABELD. > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v4, 06/66] spl: use TPL_SYS_MALLOC_F_LEN for TPL

> The (upstream) changes to break up SYS_MALLOC_F_LEN for the full > U-Boot and the SPL stage, break TPL (if simple malloc is enabled in > TPL). > > This adds support for a TPL-variant of SYS_MALLOC_F_LEN: > - adds TPL_SYS_MALLOC_F_LEN > - rewrites a test for CONFIG_SPL_SYS_MALLOC_F_LEN to access

Re: [U-Boot] [U-Boot, v4, 03/66] rockchip: back-to-bootrom: add 'back-to-bootrom' support for AArch64

> The back-to-bootrom support for Rockchip is equivalent to an > (assembly) implementation of setjmp/longjmp (i.e. it saves the > stack-pointer, link-register and callee-saved registers). Up until > now, this had only been implemented for AArch32 (i.e. ARMv7 or older), > which puts the new ARMv8

Re: [U-Boot] [U-Boot, 2/3] rockchip: set Pre-reloc malloc pool size to 4kb for rk3368 based boards

> The default 1kb pre-reloc malloc pool is not enough for dm > core to enable the dm-pre-reloc device drivers. > > Signed-off-by: Andy Yan > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich

  1   2   >