Re: [U-Boot] [PATCH v14 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-22 Thread Heinrich Schuchardt
On 11/22/18 9:50 PM, Simon Glass wrote: > Hi Heinrich, > > On Mon, 19 Nov 2018 at 12:41, Heinrich Schuchardt wrote: >> >> On 11/15/18 12:11 AM, Simon Glass wrote: >>> This function can be used from do_bootefi_exec() so that we use mostly the >>> same code for a normal EFI application and an EFI

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-11-22 Thread Hannes Schmelzer
On 30.10.2018 13:06, Hannes Schmelzer wrote: On 10/30/2018 09:13 AM, Bin Meng wrote: On Thu, Oct 25, 2018 at 10:25 PM Hannes Schmelzer wrote: This commit ports the existing (non-DM) function for writing the MAC- address into the shadow ram (and flash) for DM. Signed-off-by: Hannes

Re: [U-Boot] [PATCH] x86/bootm: fix compressed image boot

2018-11-22 Thread Hannes Schmelzer
On 20.11.2018 16:34, Bin Meng wrote: Hi Hannes, Hi Bin, thanks for having a look into and sorry for my late response. On Thu, Oct 11, 2018 at 2:41 PM Hannes Schmelzer wrote: On 11.10.2018 08:01, Bin Meng wrote: Hi Hannes, Hi Bing, thanks for very quick response on this. On Thu, Oct

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-22 Thread Jagan Teki
On Thu, Nov 22, 2018 at 2:29 PM Guochun Mao wrote: > > On Thu, 2018-11-22 at 11:51 +0530, Jagan Teki wrote: > > On Wed, Nov 21, 2018 at 5:16 PM Guochun Mao > > wrote: > > > > > > Hi Jagan, > > > > > > On Wed, 2018-11-21 at 15:08 +0530, Jagan Teki wrote: > > > > > > > > > > +static int

Re: [U-Boot] [PATCH u-boot v3 0/3] Add Amlogic Meson SPI Flash Controller driver

2018-11-22 Thread Jagan Teki
On Thu, Nov 22, 2018 at 3:31 PM Neil Armstrong wrote: > > The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. > > This patchset add the driver ported from linux, but also import the regmap > regmap_read_poll_timeout() to implify the register polling in the driver. > > Neil

Re: [U-Boot] [PATCH v2] sun8i_emac: add support for setting EMAC TX/RX delay

2018-11-22 Thread Jagan Teki
On Fri, Nov 23, 2018 at 5:08 AM Alexander Weidinger wrote: > > From: Icenowy Zheng > > Some boards have the EMAC TX/RX lanes wired with a different length with > the clock lane, which can be workarounded by setting a TX/RX delay in > the EMAC. > > This kind of delays are already defined in the

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Fabio Estevam
Hi Christian, On Thu, Nov 22, 2018 at 11:00 AM Christian Gmeiner wrote: > As the board is still mainted I will NAK it for the moment. Are there > any hints want needs to be done > to port thie board over to new DM stuff? There are some imx boards that use DM: git grep CONFIG_OF_CONTROL

Re: [U-Boot] [PATCH 00/93] dm: Move towards completing CONFIG_BLK migration

2018-11-22 Thread Fabio Estevam
Hi Soeren, On Tue, Nov 20, 2018 at 10:44 AM Soeren Moch wrote: > Fabio, Stefano, > > it seems (almost?) all i.mx6 boards should be removed within two weeks. > But would it not make more sense to convert the reference boards first > (mx6sabresd > in my case for tbs2910), and let hobbyist

[U-Boot] [PATCH v2] sun8i_emac: add support for setting EMAC TX/RX delay

2018-11-22 Thread Alexander Weidinger
From: Icenowy Zheng Some boards have the EMAC TX/RX lanes wired with a different length with the clock lane, which can be workarounded by setting a TX/RX delay in the EMAC. This kind of delays are already defined in the newest device tree binding of dwmac-sun8i, which has already entered

Re: [U-Boot] [PATCH 67/93] arm: Remove socfpga_stratix10 board

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 01:50:26PM -0700, Simon Glass wrote: > Hi, > > On Tue, 20 Nov 2018 at 18:01, Ley Foon Tan wrote: > > > > On Tue, Nov 20, 2018 at 1:27 AM Simon Glass wrote: > > > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > > Remove it. > > > > > >

Re: [U-Boot] [PATCH 00/93] dm: Move towards completing CONFIG_BLK migration

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 01:50:34PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 21 Nov 2018 at 08:10, Tom Rini wrote: > > > > On Tue, Nov 20, 2018 at 08:53:12AM -0500, Tom Rini wrote: > > > On Tue, Nov 20, 2018 at 02:45:24PM +0100, Marek Vasut wrote: > > > > On 11/20/2018 02:42 PM, Tom Rini

Re: [U-Boot] [PATCH 70/93] arm: Remove ap121 board

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 01:50:08PM -0700, Simon Glass wrote: > Hi Daniel, > > On Wed, 21 Nov 2018 at 17:47, Daniel Schwierzeck > wrote: > > > > Hi Simon, > > > > Am 19.11.18 um 16:53 schrieb Simon Glass: > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > > Remove it. >

Re: [U-Boot] [PATCH 47/93] arm: Remove mx6sabreauto board

2018-11-22 Thread Simon Glass
Hi Peng, On Mon, 19 Nov 2018 at 16:56, Peng Fan wrote: > > Hi Simon, > > Please not remove this, we will work on that. OK thank you. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 67/93] arm: Remove socfpga_stratix10 board

2018-11-22 Thread Simon Glass
Hi, On Tue, 20 Nov 2018 at 18:01, Ley Foon Tan wrote: > > On Tue, Nov 20, 2018 at 1:27 AM Simon Glass wrote: > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > > > Signed-off-by: Simon Glass > > --- > > > > board/altera/stratix10-socdk/MAINTAINERS

Re: [U-Boot] [PATCH 50/93] arm: Remove imx6dl_mamoj board

2018-11-22 Thread Simon Glass
Hi Jagan, On Mon, 19 Nov 2018 at 10:23, Jagan Teki wrote: > > On Mon, Nov 19, 2018 at 9:25 PM Simon Glass wrote: > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > It is CONFIG_BLK right? which is driver model block layer and it's > already enabled.

Re: [U-Boot] [PATCH 55/93] arm: Remove chiliboard board

2018-11-22 Thread Simon Glass
Hi Marcin, On Wed, 21 Nov 2018 at 06:05, Marcin Niestrój wrote: > > Hi Simon, All, > > Simon Glass writes: > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > I just got my hands on chiliboard to start using device-model > drivers. Unfortunately this

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Simon Glass
Hi, On Thu, 22 Nov 2018 at 10:02, Tom Rini wrote: > > On Thu, Nov 22, 2018 at 03:44:28PM +0100, Simon Goldschmidt wrote: > > Am Do., 22. Nov. 2018, 14:44 hat Tom Rini geschrieben: > > > > > On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote: > > > > On 11/22/2018 01:52 PM, Tom Rini

Re: [U-Boot] [PATCH 61/93] arm: Remove mx6sabresd board

2018-11-22 Thread Simon Glass
On Mon, 19 Nov 2018 at 16:58, Peng Fan wrote: > > Hi Simon, > > Please not remove this board, we will work to support DM_BLK. OK thanks Peng. - SImon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 56/93] arm: Remove am335x_baltos board

2018-11-22 Thread Simon Glass
On Tue, 20 Nov 2018 at 07:56, Yegor Yefremov wrote: > > Hi Simon, > > On Mon, Nov 19, 2018 at 4:55 PM Simon Glass wrote: > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > I've sent a fix: >

Re: [U-Boot] [PATCH 65/93] arm: Remove mx6cuboxi board

2018-11-22 Thread Simon Glass
Hi Mark, On Tue, 20 Nov 2018 at 00:52, Mark Kettenis wrote: > > > Date: Mon, 19 Nov 2018 08:53:45 -0700 > > From: Simon Glass > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > Hmm, isn't there something going wrong if a maintained board is > getting

Re: [U-Boot] [PATCH 0/2] dm: Complete CONFIG_BLK migration

2018-11-22 Thread Simon Glass
Hi Dennis, On Mon, 19 Nov 2018 at 09:28, Dennis Gilmore wrote: > > El mié, 27-06-2018 a las 17:40 -0400, Tom Rini escribió: > > On Sat, Jun 23, 2018 at 07:59:30AM -0600, Simon Glass wrote: > > > The time has come to migrate all boards to use CONFIG_BLK. This > > > series > > > is just a test to

Re: [U-Boot] [PATCH 25/93] arm: Remove warp7 board

2018-11-22 Thread Simon Glass
Hi Fabio, On Mon, 19 Nov 2018 at 10:56, Fabio Estevam wrote: > > Hi Simon, > > On Mon, Nov 19, 2018 at 2:29 PM Simon Glass wrote: > > > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > CONFIG_DM_BLK does not exist. > > Which deadline? Shouldn't we have a warning to let

Re: [U-Boot] [PATCH 1/3] Makefile: Add a warning for boards that don't use CONFIG_BLK

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 01:09:16PM -0700, Simon Glass wrote: > The deadline for this has passed and we are starting to remove boards that > do not use driver model for block devices. > > Add a noisy Makefile warning. > > Signed-off-by: Simon Glass > --- > > Makefile | 7 +++ > 1 file

[U-Boot] [PATCH] drivers: regulator: regulator-uclass: disallow disable of always-on

2018-11-22 Thread Richard Röjfors
It does not make sense to allow disable of a regulator that is defined always on. I found this because the new mmc code that tests if the mmc power can be switched off. That results in the rk3288 firefly board to die since the regulator, which is always-on, is shared with more than just mmc.

Re: [U-Boot] [PATCH 1/3] Makefile: Add a warning for boards that don't use CONFIG_BLK

2018-11-22 Thread Marek Vasut
On 11/22/2018 09:09 PM, Simon Glass wrote: > The deadline for this has passed and we are starting to remove boards that > do not use driver model for block devices. > > Add a noisy Makefile warning. > > Signed-off-by: Simon Glass > --- > > Makefile | 7 +++ > 1 file changed, 7

Re: [U-Boot] [PATCH 70/93] arm: Remove ap121 board

2018-11-22 Thread Simon Glass
Hi Daniel, On Wed, 21 Nov 2018 at 17:47, Daniel Schwierzeck wrote: > > Hi Simon, > > Am 19.11.18 um 16:53 schrieb Simon Glass: > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/mips/mach-ath79/Kconfig

[U-Boot] [PATCH v15 1/4] sandbox: smbios: Update to support sandbox

2018-11-22 Thread Simon Glass
At present this code casts addresses to pointers so cannot be used with sandbox. Update it to use mapmem instead. Signed-off-by: Simon Glass --- Changes in v15: None Changes in v14: - Fix condition for invalid pointer Changes in v13: - Update code to deal with the struct_table_address member

Re: [U-Boot] [PATCH 62/93] arm: Remove dh_imx6 board

2018-11-22 Thread Simon Glass
Hi Ludwig, On Tue, 20 Nov 2018 at 05:15, Ludwig Zenz wrote: > > On 19.11.2018 16:53, Simon Glass wrote: > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > Hi Simon, > > CONFIG_DM_BLK does not exist. Did you mean CONFIG_BLK? > Yes that's right. > I didn't

Re: [U-Boot] [PATCH 23/93] arm: Remove omap3_overo board

2018-11-22 Thread Simon Glass
On Tue, 20 Nov 2018 at 06:20, Andrew C. Smith wrote: > > Please hold off on the removal. I just became aware of this. We will get > the board updated. > Thank you, Andrew. - Simon ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH v15 0/4] efi_loader: Code refactoring and improvement

2018-11-22 Thread Simon Glass
This collects the patches previously sent to break up the very large functions in efi_loader into smaller pieces. Now that the other sandbox stuff is applied, perhaps it is time to apply these patches. This also adds a few new patches to fix more recent breakages. Unfortunately we still cannot

Re: [U-Boot] [U-Boot, v3, 3/4] rockchip: rk3399: Add Rock960 CE board support

2018-11-22 Thread Ezequiel Garcia
On Wed, 2018-10-03 at 21:35 +0200, Philipp Tomsich wrote: > > Add board support for Rock960 CE board from Vamrs. This board utilizes > > common Rock960 family support. > > > > Following peripherals are tested and known to work: > > * USB 2.0 > > * MMC > > > > This commit also adds DDR

Re: [U-Boot] [PATCH 00/93] dm: Move towards completing CONFIG_BLK migration

2018-11-22 Thread Simon Glass
Hi Tom, On Wed, 21 Nov 2018 at 08:10, Tom Rini wrote: > > On Tue, Nov 20, 2018 at 08:53:12AM -0500, Tom Rini wrote: > > On Tue, Nov 20, 2018 at 02:45:24PM +0100, Marek Vasut wrote: > > > On 11/20/2018 02:42 PM, Tom Rini wrote: > > > > On Tue, Nov 20, 2018 at 02:40:43PM +0100, Marek Vasut wrote:

Re: [U-Boot] [PATCH v14 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-22 Thread Simon Glass
Hi Heinrich, On Mon, 19 Nov 2018 at 12:41, Heinrich Schuchardt wrote: > > On 11/15/18 12:11 AM, Simon Glass wrote: > > This function can be used from do_bootefi_exec() so that we use mostly the > > same code for a normal EFI application and an EFI test. > > > > Rename the function and use it in

Re: [U-Boot] [PATCH 68/93] arm: Remove am65x_evm_a53 board

2018-11-22 Thread Simon Glass
Hi Lokesh, On Mon, 19 Nov 2018 at 09:58, Lokesh Vutla wrote: > > Hi Simon, > > On 11/19/2018 9:23 PM, Simon Glass wrote: > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > > > Signed-off-by: Simon Glass > > Not sure if this is by mistake, but I see

[U-Boot] [PATCH v15 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-22 Thread Simon Glass
This function can be used from do_bootefi_exec() so that we use mostly the same code for a normal EFI application and an EFI test. Rename the function and use it in both places. Signed-off-by: Simon Glass --- Changes in v15: - Add a comment about a leaked device path Changes in v14: - Go back

Re: [U-Boot] [PATCH] RFC: checkpatch: Add a check for tests needed for uclasses

2018-11-22 Thread Simon Glass
Hi Heinrich, On Wed, 21 Nov 2018 at 07:35, Heinrich Schuchardt wrote: > > On 11/18/18 4:16 PM, Simon Glass wrote: > > This is an experimental check for adding new uclasses without a test. > > > > I am not sure of the best way to add U-Boot-specific tests, although in > > this case, it would not

[U-Boot] [PATCH v15 2/4] efi: Split out test init/uninit into functions

2018-11-22 Thread Simon Glass
The functions in bootefi are very long because they mix high-level code and control with the low-level implementation. To help with this, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully long variable names here. Signed-off-by:

[U-Boot] [PATCH v15 3/4] efi: Create a function to set up for running EFI code

2018-11-22 Thread Simon Glass
There is still duplicated code in efi_loader for tests and normal operation. Add a new bootefi_run_prepare() function which holds common code used to set up U-Boot to run EFI code. Make use of this from the existing bootefi_test_prepare() function, as well as do_bootefi_exec(). Also shorten a

Re: [U-Boot] [PATCH 86/93] arm: Remove brppt1_mmc board

2018-11-22 Thread Simon Glass
Hi Hannes, On Tue, 20 Nov 2018 at 04:08, Hannes Schmelzer wrote: > > > On 11/19/18 4:54 PM, Simon Glass wrote: > > This board has not been converted to CONFIG_DM_BLK by the deadline. > > Remove it. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/arm/mach-omap2/Kconfig | 1 - > >

Re: [U-Boot] [PATCH 4/4] buildman: Show boards with warning with w+

2018-11-22 Thread sjg
At present we should boards with warnings in the same way as those with errors. This is not ideal. Add a new 'warn' state and show these listed in yellow to match the actual warning lines printing with -e. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 17 +---

Re: [U-Boot] [PATCH] fdt: Fix uncompress_blob() for U-Boot proper

2018-11-22 Thread sjg
On Thu, 18 Oct 2018 at 12:38, Marek Vasut wrote: > > When U-Boot proper is compiled with CONFIG_MULTI_DTB_FIT and tries > to call uncompress_blob(), it fails with -ENOTSUPP. This is because > the full implementation of this function which includes compression > is available only in SPL. In U-Boot

Re: [U-Boot] [PATCH] fdt: restore board_fdt_blob_setup() declaration

2018-11-22 Thread sjg
On 28 October 2018 at 05:41, Baruch Siach wrote: > Commit 90c08fa038451d (fdt: Add device tree memory bindings) removed the > prototype declaration of board_fdt_blob_setup(), most likely by mistake. > This didn't break the build because the only file calling this function > (lib/fdtdec.c)

Re: [U-Boot] [PATCH 16/25] binman: Set the pathname correctly for ELF files

2018-11-22 Thread sjg
At present, stripped files don't have the right pathname which means that blob compression cannot be used. Fix this. Signed-off-by: Simon Glass --- tools/binman/etype/u_boot_elf.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Applied to u-boot-dm/master, thanks!

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-22 Thread sjg
On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt wrote: > > On 31.10.2018 07:42, Simon Goldschmidt wrote: > > On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki > > wrote: > >> On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt > >> wrote: > >>> When the device tree is missing a correct spi slave

Re: [U-Boot] [PATCH 11/25] spl: Support bootstage, log, hash and early malloc in TPL

2018-11-22 Thread sjg
At present these features are supported in SPL but not TPL. Update the Kconfig and Makefile to allow this. Also add a few Makefile comments to make earier to track what is going on. Signed-off-by: Simon Glass --- common/Kconfig | 35 +++ common/Makefile | 10

Re: [U-Boot] [PATCH 1/4] buildman: Only print toolchain probing with -v

2018-11-22 Thread sjg
At present --list-tool-chains prints a lot of information about the toolchain-probing process. This is generally not very interesting. Update buildman to print this only if --list-tool-chains is given with -v. Signed-off-by: Simon Glass --- tools/buildman/cmdline.py | 2 +-

Re: [U-Boot] [PATCH] cmd: fdt: Fix fdt address information after the movement

2018-11-22 Thread Simon Glass
On Sun, 18 Nov 2018 at 14:22, Simon Glass wrote: > > Hi Marek, > > On Sun, 18 Nov 2018 at 08:02, Marek Vasut wrote: > > > > On 11/17/2018 01:13 AM, Simon Glass wrote: > > > On Thu, 18 Oct 2018 at 12:44, Marek Vasut wrote: > > >> > > >> From: Hiroyuki Yokoyama > > >> > > >> This patch fixes the

Re: [U-Boot] [PATCH 1/1] sandbox: README: use setenv ethrotate no

2018-11-22 Thread sjg
On Sun, 14 Oct 2018 at 14:01, Heinrich Schuchardt wrote: > > If we want to control which network interface is actually used, we have to > issue 'setenv ethrotate no'. If ethrotate is not set any interface may be > used. > > Signed-off-by: Heinrich Schuchardt > --- > board/sandbox/README.sandbox

Re: [U-Boot] [PATCH 06/25] sandbox: tpm: Allow debugging of data packages

2018-11-22 Thread sjg
This is not normally useful, so change the code to avoid writing out every data package. This can be enabled with #define DEBUG. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 6 ++ 1 file changed, 6 insertions(+) Applied to u-boot-dm/master, thanks!

Re: [U-Boot] [PATCH 03/25] cros_ec: Fail if we cannot determine the flash burst size

2018-11-22 Thread sjg
This value is required for flashing to work correctly. Add a check for it. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 3 +++ 1 file changed, 3 insertions(+) Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH 2/4] buildman: Detect dtc warnings

2018-11-22 Thread sjg
At present messages from the device-tree compiler like this: arch/arm/dts/socfpga_arria10_socdk_sdmmc.dtb: Warning (avoid_unnecessary_addr_size): /clocks: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property are detected as errors since they don't match the

Re: [U-Boot] [PATCH 01/25] cros_ec: Use uint instead of u8 for parameters

2018-11-22 Thread sjg
There is no advantage to using a u8 for function parameters. It forces the compiler to mask values and can increase code size. Also the command enum has been extended to 16 bits. Update the functions to use uint instead. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 10 -- 1

Re: [U-Boot] [PATCH 3/4] buildman: Rename the good, better, worse variables

2018-11-22 Thread sjg
At present we don't distinguish between errors and warnings when printing the architecture summary. Rename the variables to better describe their purpose. 'Worse' at present means we got an error, so use that as the name. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 28

Re: [U-Boot] [PATCH 13/25] spl: lz4: Allow use of lz4 compression in SPL

2018-11-22 Thread sjg
In some cases U-Boot is compressed and it is useful to be able to decompress it in SPL. Add a Kconfig and Makefile change to allow this. Note that this does not actually implement decompression. Signed-off-by: Simon Glass --- lib/Kconfig | 8 lib/Makefile | 2 +- 2 files changed, 9

Re: [U-Boot] [PATCH 09/25] sandbox: cros_ec: exynos: Drop use of cros_ec_get_error()

2018-11-22 Thread sjg
On 07/11/18 07:21, Simon Glass wrote: > This function is really just a call to uclass_get_device() and there is no > reason why the caller cannot do it. Update sandbox and snow accordingly. > > Signed-off-by: Simon Glass > --- > > board/samsung/common/board.c | 10 ++ >

Re: [U-Boot] [PATCH 04/25] cros_ec: Align uclass data to a cache boundary

2018-11-22 Thread sjg
The LPC driver expects its buffer to be word-aligned. Add the required flag to the uclass driver to ensure this. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/master, thanks! ___

Re: [U-Boot] [PATCH 15/25] binman: Drop an unnecessary comma in blob handling

2018-11-22 Thread sjg
This comma is not needed. Drop it. Signed-off-by: Simon Glass --- tools/binman/etype/blob.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v2] dm: core: Widen the dump tree to show more of the driver's name.

2018-11-22 Thread sjg
With drivers that have prefix names that are quite long (like 'versatile_') it is useful to have a wider column for the driver's name when dumping the device driver tree. Also update the tests to take into account the wider output format. Signed-off-by: Liviu Dudau Reviewed-by: Simon Glass ---

Re: [U-Boot] [PATCH 1/1] sandbox: README: setting environment variables

2018-11-22 Thread sjg
On 14 October 2018 at 13:40, Heinrich Schuchardt wrote: > The command to set environment variables is setenv. > > Signed-off-by: Heinrich Schuchardt > --- > board/sandbox/README.sandbox | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Glass Applied

Re: [U-Boot] [PATCH 1/2] dm/pci: Change the first CFG read to Vendor ID in enumeration

2018-11-22 Thread sjg
Hi Bin, Thanks a lot for your review! Thanks, Zhiqiang > -Original Message- > From: Bin Meng > Sent: 2018年10月8日 16:53 > To: Z.q. Hou > Cc: U-Boot Mailing List ; Simon Glass > ; Christian Gmeiner ; > Tuomas Tynkkynen ; Bernhard Messerklinger > ; Masahiro Yamada > ; Mingkai Hu ; > M.h.

Re: [U-Boot] [PATCH 10/25] sandbox: Update some drivers to work in SPL/TPL

2018-11-22 Thread sjg
At present sandbox drivers are mostly not used before relocation. Some of these are needed by Chromium OS verified boot, since it uses sandbox TPL, so update them accordingly. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dts | 15 +++ 1 file changed, 15 insertions(+)

Re: [U-Boot] [PATCH 02/25] cros_ec: Add error logging on a few commands

2018-11-22 Thread sjg
Add some more logging to provide more information on failures. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH 05/25] cros_ec: Add new features for events and power

2018-11-22 Thread sjg
This adds new commands to the EC related to setting and clearing events as well as controlling power-related settings. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 345 - drivers/misc/cros_ec_sandbox.c | 2 +- include/cros_ec.h

Re: [U-Boot] [PATCH 08/25] sandbox: Add a function to read a host file

2018-11-22 Thread sjg
Add a way to read a file from the host filesystem. This can be useful for reading test data, for example. Also fix up the writing function which was not the right version, and drop the debugging lines. Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c | 44

Re: [U-Boot] [PATCH 19/25] video: Update video_set_default_colors() to support invert

2018-11-22 Thread sjg
It is useful to be able to invert the colours in some cases so that the text matches the background colour. Add a parameter to the function to support this. It is strange that function takes a private data structure from another driver as an argument. It seems better to pass the device and have

Re: [U-Boot] [PATCH 14/25] binman: Add a way to enable debugging from the build

2018-11-22 Thread sjg
When the build fails due to something wrong in binman it is sometimes useful to get a full backtrace showing the location of the failure. Add a BINMAN_DEBUG environment variable to support this along with some documentation. Signed-off-by: Simon Glass --- Makefile| 6 --

Re: [U-Boot] [PATCH 07/25] sandbox: log: Add a category for sandbox

2018-11-22 Thread sjg
It seems useful to make sandbox its own log category since it is used for so much testing. Add this as a new category. Signed-off-by: Simon Glass --- include/log.h | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/master, thanks! ___ U-Boot

Re: [U-Boot] [PATCH 22/25] misc: Update read() and write() methods to return bytes xfered

2018-11-22 Thread sjg
Hi Simon, > From: Simon Glass > Sent: mardi 6 novembre 2018 23:22 > Subject: [PATCH 22/25] misc: Update read() and write() methods to return bytes > > At present these functions return 0 on success. For some devices we want to > know how many bytes were transferred. It seems useful to adjust the

Re: [U-Boot] [PATCH 23/25] test: sf: Add a simple SPI flash test

2018-11-22 Thread sjg
The current test is a functional test, covering all the way from the command line to the sandbox SPI driver. This is useful, but it is easier to diagnose failures with a smaller test. Add a simple test which reads and writes data and checks that it is stored and retrieved correctly.

Re: [U-Boot] [PATCH 21/25] string: Include the config header

2018-11-22 Thread sjg
At present the config header is not included in this file, but it does use a CONFIG option. Fix it. Signed-off-by: Simon Glass --- lib/string.c | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH 24/25] sf: Add a method to obtain the block-protect setting

2018-11-22 Thread sjg
It is useful to obtain the block-protect setting of the SPI flash, so we know whether it is fully open or (perhaps partially) write-protected. Add a method for this. Update the sandbox driver to process this operation and add a test. Signed-off-by: Simon Glass ---

[U-Boot] [PATCH 2/3] dm: blk: Add a note about boards that don't use block devices

2018-11-22 Thread Simon Glass
Not all boards use block devices. Those that do not should explicitly disable CONFIG_BLK (and CONFIG_SPL_BLK if needed) to avoid any build problems when CONFIG_BLK becomes the default. Add a note to this effect. Signed-off-by: Simon Glass --- doc/driver-model/MIGRATION.txt | 5 + 1 file

[U-Boot] [PATCH 3/3] dm: Add a note about using driver model

2018-11-22 Thread Simon Glass
All boards should now use driver model. Add a noisy warning for those that still do not. Signed-off-by: Simon Glass --- Makefile | 8 1 file changed, 8 insertions(+) diff --git a/Makefile b/Makefile index 8bf422f6a85..21195948078 100644 --- a/Makefile +++ b/Makefile @@ -918,12

[U-Boot] [PATCH 1/3] Makefile: Add a warning for boards that don't use CONFIG_BLK

2018-11-22 Thread Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices. Add a noisy Makefile warning. Signed-off-by: Simon Glass --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile index

[U-Boot] [PATCH 1/3] Makefile: Add a warning for boards that don't use CONFIG_BLK

2018-11-22 Thread Simon Glass
The deadline for this has passed and we are starting to remove boards that do not use driver model for block devices. Add a noisy Makefile warning. Signed-off-by: Simon Glass --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile index

[U-Boot] (no subject)

2018-11-22 Thread sjg
From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Marek Vasut , Simon Glass , Masahiro Yamada , Rasmus Villemoes , Baruch Siach , Jagdish Gediya , Stephen Warren Subject: [PATCH 1/3] Makefile: Add a warning for boards that don't

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Simon Goldschmidt
[I've shortened the CC list a bit since this might be somewhat off-topic and both gmail warned be about too many CCs] On 22.11.2018 18:01, Tom Rini wrote: On Thu, Nov 22, 2018 at 03:44:28PM +0100, Simon Goldschmidt wrote: Am Do., 22. Nov. 2018, 14:44 hat Tom Rini geschrieben: On Thu, Nov

Re: [U-Boot] [PATCH 00/93] dm: Move towards completing CONFIG_BLK migration

2018-11-22 Thread Tom Rini
On Mon, Nov 19, 2018 at 10:54 AM Simon Glass wrote: > > All boards should now be migrated to use CONFIG_BLK. This series removes > those with build problems using this option. > > If maintainers want to keep these boards in they should send a patch in > the next week or two. Otherwise the board

Re: [U-Boot] [PATCH] arm: socfpga: crc-protect SPL on warm boot

2018-11-22 Thread Marek Vasut
On 11/22/2018 06:18 AM, Simon Goldschmidt wrote: > > > Am Do., 22. Nov. 2018, 03:00 hat Marek Vasut > geschrieben: > > On 11/21/2018 10:07 PM, Simon Goldschmidt wrote: > > On 21.11.2018 15:08, Marek Vasut wrote: > >> On 11/21/2018 06:09 AM, Simon Goldschmidt

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 03:44:28PM +0100, Simon Goldschmidt wrote: > Am Do., 22. Nov. 2018, 14:44 hat Tom Rini geschrieben: > > > On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote: > > > On 11/22/2018 01:52 PM, Tom Rini wrote: > > > > On Thu, Nov 22, 2018 at 10:25:14AM +0100, Christian

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Marek Vasut
On 11/22/2018 02:32 PM, Tom Rini wrote: > On Thu, Nov 22, 2018 at 02:30:11PM +0100, Marek Vasut wrote: >> On 11/22/2018 02:28 PM, Tom Rini wrote: >>> On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote: On 11/22/2018 01:52 PM, Tom Rini wrote: > On Thu, Nov 22, 2018 at 10:25:14AM

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 02:30:11PM +0100, Marek Vasut wrote: > On 11/22/2018 02:28 PM, Tom Rini wrote: > > On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote: > >> On 11/22/2018 01:52 PM, Tom Rini wrote: > >>> On Thu, Nov 22, 2018 at 10:25:14AM +0100, Christian Gmeiner wrote: > >>> >

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-11-22 Thread Simon Goldschmidt
Am Do., 22. Nov. 2018, 14:44 hat Tom Rini geschrieben: > On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote: > > On 11/22/2018 01:52 PM, Tom Rini wrote: > > > On Thu, Nov 22, 2018 at 10:25:14AM +0100, Christian Gmeiner wrote: > > > > > >> Am Mo., 19. Nov. 2018 um 16:56 Uhr schrieb Simon

[U-Boot] [PATCH] net: fix env flags for eth10addr and above

2018-11-22 Thread Simon Goldschmidt
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit. On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above. Fix this by changing ETHADDR_WILDCARD from

Re: [U-Boot] [swupdate] Re: SWUpdate - U-Boot environment library dependency

2018-11-22 Thread Simon Goldschmidt
Dear Wolfgang, On 22.11.2018 17:00, Wolfgang Denk wrote: Dear Simon, In message you wrote: I don't know your board. It may be intentional, for example if there are size restrictions for the SPL wich don't allow to include the CRC32 code... I don't think this is intentional. I discussed

Re: [U-Boot] [swupdate] Re: SWUpdate - U-Boot environment library dependency

2018-11-22 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I don't know your board. > > > > It may be intentional, for example if there are size restrictions > > for the SPL wich don't allow to include the CRC32 code... > > > > I don't think this is intentional. I discussed this in another thread with > Marek by

[U-Boot] [PATCH] net: remove duplicate definition of ETHADDR_WILDCARD

2018-11-22 Thread Simon Goldschmidt
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h Signed-off-by: Simon Goldschmidt --- include/env_callback.h | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [U-Boot] [PATCH] arm64: mvebu: fix crash in EFI memory allocation

2018-11-22 Thread Baruch Siach
Hi Alex, Adding Stephen Warren to Cc. On Thu, Nov 22, 2018 at 02:30:34PM +, Alexander Graf wrote: > > Am 22.11.2018 um 11:42 schrieb Baruch Siach : > > > > EFI memory allocation code return values that are not mapped by U-Boot > > MMU. This causes a crash when tftp calls efi_set_bootdev().

Re: [U-Boot] [PATCH v1 15/16] configs: am335x_evm: Do not disable DM_USB in SPL

2018-11-22 Thread Jean-Jacques Hiblot
On 22/11/2018 15:43, Tom Rini wrote: On Thu, Nov 22, 2018 at 03:25:07PM +0100, Jean-Jacques Hiblot wrote: On 22/11/2018 15:18, Tom Rini wrote: On Thu, Nov 22, 2018 at 02:36:11PM +0100, Jean-Jacques Hiblot wrote: Hi Tom, On 22/11/2018 13:45, Tom Rini wrote: On Thu, Nov 22, 2018 at

Re: [U-Boot] [PATCH v1 15/16] configs: am335x_evm: Do not disable DM_USB in SPL

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 03:25:07PM +0100, Jean-Jacques Hiblot wrote: > > On 22/11/2018 15:18, Tom Rini wrote: > >On Thu, Nov 22, 2018 at 02:36:11PM +0100, Jean-Jacques Hiblot wrote: > >>Hi Tom, > >> > >> > >>On 22/11/2018 13:45, Tom Rini wrote: > >>>On Thu, Nov 22, 2018 at 04:13:58PM +0530,

Re: [U-Boot] [swupdate] Re: SWUpdate - U-Boot environment library dependency

2018-11-22 Thread Simon Goldschmidt
Wolfgang, Am Do., 22. Nov. 2018, 15:23 hat Wolfgang Denk geschrieben: > Dear Simon, > > In message <97f8b0ec-103b-e9b7-42ed-e1922f6d4...@gmail.com> you wrote: > > > > Oops, I'll have to take that back. I just checked and SPL *does* boot > > the uImage U-Boot also if I deliberately corrupt the

Re: [U-Boot] [PATCH v2 4/4] rtc: m41t62: Convert the RTC driver to support the driver model (DM)

2018-11-22 Thread Stefan Roese
On 22.11.18 14:54, Lukasz Majewski wrote: After this change the m41t62.c can be used with RTC subsystem (i.e. date command) which uses device model (DM). Signed-off-by: Lukasz Majewski --- Changes in v2: - Extract common RTC handling code to avoid #ifdefs for CONFIG_DM_RTC - Provide extra

Re: [U-Boot] [PATCH v2 3/4] rtc: m41t62: Extract common RTC handling code to facilitate DM conversion

2018-11-22 Thread Stefan Roese
On 22.11.18 14:54, Lukasz Majewski wrote: This change facilitates the conversion of m41t62 RTC driver to device model (DM). Signed-off-by: Lukasz Majewski --- Changes in v2: - New patch Changes in v1: None drivers/rtc/m41t62.c | 32 1 file changed, 20

Re: [U-Boot] [PATCH v3 1/3] riscv: Add kconfig option to run u-boot in S-mode

2018-11-22 Thread Bin Meng
Hi Palmer, On Thu, Nov 22, 2018 at 12:28 AM Palmer Dabbelt wrote: > > On Tue, 20 Nov 2018 19:41:10 PST (-0800), a...@brainfault.org wrote: > > This patch adds kconfig option RISCV_SMODE to run u-boot in > > S-mode. When this opition is enabled we use s CSRs instead > > of m CSRs. > > > > It is

Re: [U-Boot] [PATCH] arm64: mvebu: fix crash in EFI memory allocation

2018-11-22 Thread Alexander Graf
> Am 22.11.2018 um 11:42 schrieb Baruch Siach : > > EFI memory allocation code return values that are not mapped by U-Boot > MMU. This causes a crash when tftp calls efi_set_bootdev(). Fix this > similarly to commit 0797f7f0b7e1 ("ARM: tegra: reserve unmapped RAM so > EFI doesn't use it"). > >

Re: [U-Boot] [linux-sunxi] Re: [PATCH v3 0/9] Stop AXP from crashing when enabling LDO3

2018-11-22 Thread Priit Laes
On Thu, Nov 22, 2018 at 03:07:46PM +0100, Olliver Schinagl wrote: > On 21-11-18 19:13, Priit Laes wrote: > > On Wed, Nov 21, 2018 at 08:05:24PM +0200, Priit Laes wrote: > >> This is a resend/v2 of a "Stop AXP from crashing when enabling LDO3" > >> series, > >> posted by Olliver Schinagl in March

Re: [U-Boot] [PATCH v1 15/16] configs: am335x_evm: Do not disable DM_USB in SPL

2018-11-22 Thread Jean-Jacques Hiblot
On 22/11/2018 15:18, Tom Rini wrote: On Thu, Nov 22, 2018 at 02:36:11PM +0100, Jean-Jacques Hiblot wrote: Hi Tom, On 22/11/2018 13:45, Tom Rini wrote: On Thu, Nov 22, 2018 at 04:13:58PM +0530, Lokesh Vutla wrote: On 21/11/18 4:21 PM, Jean-Jacques Hiblot wrote: DM_USB is now supported in

Re: [U-Boot] [swupdate] Re: SWUpdate - U-Boot environment library dependency

2018-11-22 Thread Wolfgang Denk
Dear Simon, In message <97f8b0ec-103b-e9b7-42ed-e1922f6d4...@gmail.com> you wrote: > > Oops, I'll have to take that back. I just checked and SPL *does* boot > the uImage U-Boot also if I deliberately corrupt the CRC of the image. > So you're right, it seems to be not protected at all! > > Is

Re: [U-Boot] [PATCH v1 15/16] configs: am335x_evm: Do not disable DM_USB in SPL

2018-11-22 Thread Tom Rini
On Thu, Nov 22, 2018 at 02:36:11PM +0100, Jean-Jacques Hiblot wrote: > Hi Tom, > > > On 22/11/2018 13:45, Tom Rini wrote: > >On Thu, Nov 22, 2018 at 04:13:58PM +0530, Lokesh Vutla wrote: > >> > >>On 21/11/18 4:21 PM, Jean-Jacques Hiblot wrote: > >>>DM_USB is now supported in the SPL. Do not

Re: [U-Boot] [PATCH v3 0/9] Stop AXP from crashing when enabling LDO3

2018-11-22 Thread Olliver Schinagl
On 21-11-18 19:13, Priit Laes wrote: > On Wed, Nov 21, 2018 at 08:05:24PM +0200, Priit Laes wrote: >> This is a resend/v2 of a "Stop AXP from crashing when enabling LDO3" series, >> posted by Olliver Schinagl in March 2017. Unfortunately it never got past >> initial discussion [1], but most Olimex

  1   2   3   >