[U-Boot] [PATCH v3 1/1] lib/vsprintf: allow printing upper case GUIDs

2019-04-28 Thread Heinrich Schuchardt
In the UEFI context GUIDs are expected to be rendered in upper case. The patch uses the formerly unused bit 1 of the parameter str_format of function uuid_bin_to_str() to indicate if we need upper or lower case output. Function uuid_string() in vsprint.c is adjusted to correctly set the bit depen

[U-Boot] [PATCH 1/1] lib/vsprintf: remove #include from vsprintf.c

2019-04-28 Thread Heinrich Schuchardt
common.h already includes uuid.h Signed-off-by: Heinrich Schuchardt --- lib/vsprintf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 2403825dc9..3502b8088f 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -16,7 +16,6 @@ #include #include #includ

Re: [U-Boot] [PATCH 2/8] Makefile: Trigger a Warning if BROKEN defined

2019-04-28 Thread Heinrich Schuchardt
On 4/28/19 10:47 PM, Jagan Teki wrote: If configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration. Cc: Heinrich Schuchardt Signed-off-by: Jagan Teki --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b

Re: [U-Boot] [PATCH 1/8] Kconfig: Update CONFIG_BROKEN help text

2019-04-28 Thread Heinrich Schuchardt
On 4/28/19 10:47 PM, Jagan Teki wrote: Add bool text to describe what configurations is this for. Update help text to describe the example use-case configs which comes under CONFIG_BROKEN, they are - legacy driver that would need dm conversion. - legacy driver that doesn't have proper update sin

Re: [U-Boot] [PATCH] mips: rename arch mt7620 to mt7628

2019-04-28 Thread Stefan Roese
On 28.04.19 11:38, Weijie Gao wrote: The MediaTek MT7620 and MT7628 SoCs are different. Although they use the same memory controller, the lowlevel code (CPU PLL) and other peripherals they use are totally different. Which means they should use seperate mach directories. s/seperate/separate Cu

[U-Boot] [PATCH v2 5/6] arm: mach-omap2: am33xx: ddr: update value for ext_phy_ctrl_36

2019-04-28 Thread Keerthy
From: Brad Griffis for suspend/resume robustness update value for ext_phy_ctrl_36 for suspend/resume robustness with hardware leveling enabled. Match recommended values from EMIF Tools app note: http://www.ti.com/lit/an/sprac70/sprac70.pdf Signed-off-by: Brad Griffis Signed-off-by: Keerthy

[U-Boot] [PATCH v2 1/6] arm: mach-omap2: am33xx: ddr: programming of EXT_PHY_CTRL1 and EXT_PHY_CTRL1_SHADOW

2019-04-28 Thread Keerthy
From: Brad Griffis Adjust DQS skew in case where invert_clkout=1 is used. Match recommended values from EMIF Tools app note: http://www.ti.com/lit/an/sprac70/sprac70.pdf Signed-off-by: Brad Griffis Signed-off-by: Keerthy --- arch/arm/mach-omap2/am33xx/ddr.c | 12 ++-- 1 file changed,

[U-Boot] [PATCH v2 6/6] board: ti: am43xx: Enable hardware leveling

2019-04-28 Thread Keerthy
From: Brad Griffis Remove the RDLVL_MASK, RDLVLGATE_MASK, WRLVL_MASK & enable PHY_INVERT_CLKOUT to enable Hardware leveling for am437x as recommended by EMIF Tools app note: http://www.ti.com/lit/an/sprac70/sprac70.pdf Signed-off-by: Brad Griffis Signed-off-by: Keerthy --- board/ti/am43xx/bo

[U-Boot] [PATCH v2 2/6] arm: mach-omap2: am33xx: ddr: Add 1ms delay to avoid L3 error

2019-04-28 Thread Keerthy
From: Brad Griffis Add 1ms delay to avoid L3 timeout error during suspend resume. Signed-off-by: Brad Griffis Signed-off-by: Keerthy --- arch/arm/mach-omap2/am33xx/ddr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/am33xx/ddr.c b/arch/arm/mach-omap2/am33xx/ddr.c

[U-Boot] [PATCH v2 0/6] board: ti: am43xx: Enable hardware leveling

2019-04-28 Thread Keerthy
The series adds the support for hardware leveling. This needs the kernel to be patched with hardware leveling support and the kernel support is already in linux-next: https://patchwork.kernel.org/project/linux-omap/list/?series=100273 Match recommended values from EMIF Tools app note: http://www.

[U-Boot] [PATCH v2 3/6] arm: mach-omap2: am33xx: Enable HW Leveling in the rtc+ddr path

2019-04-28 Thread Keerthy
From: Brad Griffis Enable HW leveling in RTC+DDR path. The mandate is to enable HW leveling bit and then wait for 1 ms before accessing any register. Signed-off-by: Brad Griffis Signed-off-by: Keerthy --- arch/arm/mach-omap2/am33xx/board.c | 30 +- 1 file changed,

[U-Boot] [PATCH v2 4/6] arm: mach-omap2: am33xx: Disable EMIF_DEVOFF immediately before hw leveling

2019-04-28 Thread Keerthy
From: Brad Griffis In case of RTC+DDR resume, need to restore EMIF context before initiating hardware leveling. Signed-off-by: Brad Griffis [j-keer...@ti.com Fixed the am335x build issues] Signed-off-by: Keerthy --- Changes in v2: * Added the am43xx specific changes under #ifdef arch/arm

Re: [U-Boot] [PATCH v1 2/2] configs: am335x_evm: enable SPL_FIT_IMAGE_TINY

2019-04-28 Thread Lokesh Vutla
On 26/04/19 6:51 PM, Jean-Jacques Hiblot wrote: > The size of the SPL for the am335x_evm is constrained. There is no need > to have advanced SPL FIT features, so keep the SPL FIT support tiny. > > Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Lokesh Vutla Thanks and regards, Lokesh > > -

Re: [U-Boot] [PATCH v1 1/2] spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled

2019-04-28 Thread Lokesh Vutla
On 26/04/19 6:51 PM, Jean-Jacques Hiblot wrote: > FIT_IMAGE_TINY is used to reduce the size of the SPL by removing os-type > tracking and recording the loadables into the loaded FDT. When this option > is enabled, it is assumed that the next stage firmware is u-boot. > However this does not play

Re: [U-Boot] [PATCH v2 3/4] riscv: prior_stage_fdt_address should only be used when OF_PRIOR_STAGE is enabled

2019-04-28 Thread Rick Chen
Auer, Lukas 於 2019年4月26日 週五 上午4:58寫道: > > On Thu, 2019-04-25 at 09:00 +0800, Rick Chen wrote: > > Bin Meng 於 2019年4月24日 週三 下午3:02寫道: > > > On Wed, Apr 24, 2019 at 2:38 PM Andes wrote: > > > > From: Rick Chen > > > > > > > > This patch will fix prior_stage_fdt_address write failure problem, when

Re: [U-Boot] [PATCH v2 2/4] riscv: configs: Support AE350 SMP booting from flash flow

2019-04-28 Thread Rick Chen
Hi Lukas Auer, Lukas 於 2019年4月26日 週五 上午4:56寫道: > > Hi Rick, > > On Wed, 2019-04-24 at 14:33 +0800, Andes wrote: > > From: Rick Chen > > > > Add two defconfigs to support AE350 SMP booting from flash. > > > > Signed-off-by: Rick Chen > > Cc: Greentime Hu > > --- > > configs/ae350_rv32_xip_defc

Re: [U-Boot] [PATCH 3/5] spi: add spi-mem driver for MediaTek MT7629 SoC

2019-04-28 Thread Weijie Gao
On Mon, 2019-04-29 at 08:50 +0800, Weijie Gao wrote: > On Sun, 2019-04-28 at 17:30 +0530, Jagan Teki wrote: > > On Sun, Apr 28, 2019 at 6:54 AM Weijie Gao wrote: > > > > > > On Sat, 2019-04-27 at 21:38 +0530, Jagan Teki wrote: > > > > On Fri, Apr 26, 2019 at 2:53 PM Weijie Gao > > > > wrote: > >

Re: [U-Boot] [PATCH v2 1/4] riscv: hart_lottery and available harts features can be selectable

2019-04-28 Thread Rick Chen
Hi Lukas Auer, Lukas 於 2019年4月26日 週五 上午4:55寫道: > > Hi Rick, > > Bin already included excellent feedback, I have just one more small nit > below. > > On Wed, 2019-04-24 at 14:33 +0800, Andes wrote: > > From: Rick Chen > > > > In smp flow these two features only can be enabled when U-Boot > > boot

Re: [U-Boot] [PATCH] riscv: qemu: Use correct SYS_TEXT_BASE for S-mode on 32bit system

2019-04-28 Thread Rick Chen
Hi Karsten > From: Karsten Merker [mailto:mer...@debian.org] > Sent: Friday, April 26, 2019 5:35 PM > To: Rick Jian-Zhi Chen(陳建志) > Cc: Anup Patel; Bin Meng; Lukas Auer; Tom Rini; U-Boot Mailing List; Palmer > Dabbelt > Subject: Re: [U-Boot] [PATCH] riscv: qemu: Use correct SYS_TEXT_BASE for > S-m

Re: [U-Boot] [PATCH v5 1/2] imx: fix building for i.mx8 without spl

2019-04-28 Thread Peng Fan
> Subject: [PATCH v5 1/2] imx: fix building for i.mx8 without spl > > From: Marcel Ziswiler > > Building with Travis CI complained and stopped with the following error: > +cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such > file or directory > +compilation terminated. > > Thi

Re: [U-Boot] [PATCH 3/5] spi: add spi-mem driver for MediaTek MT7629 SoC

2019-04-28 Thread Weijie Gao
On Sun, 2019-04-28 at 17:30 +0530, Jagan Teki wrote: > On Sun, Apr 28, 2019 at 6:54 AM Weijie Gao wrote: > > > > On Sat, 2019-04-27 at 21:38 +0530, Jagan Teki wrote: > > > On Fri, Apr 26, 2019 at 2:53 PM Weijie Gao > > > wrote: > > > > > > > > This patch adds spi-mem driver for MediaTek MT7629 S

Re: [U-Boot] [PATCH] spi: Zap lpc32xx_ssp driver-related code

2019-04-28 Thread Tom Rini
On Sat, Apr 27, 2019 at 10:08:34PM +0200, Simon Goldschmidt wrote: > > > On 22.04.19 23:00, Tom Rini wrote: > >On Mon, Apr 22, 2019 at 11:50:22PM +0300, Vladimir Zapolskiy wrote: > >>Hi Jagan, Tom, > >> > >>On 04/19/2019 09:48 AM, Jagan Teki wrote: > >>>Dropped > >>>- lpc32xx_ssp driver > >>>- CO

[U-Boot] [PATCH v5 0/2] colibri imx8qxp 2gb wb it v1.0b module support

2019-04-28 Thread Marcel Ziswiler
This series fixes building for i.MX8 without SPL and adds support for more lpuart instances, cleans-up and extends the Toradex SKU handling and last but not least introduces support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. This series is available together with the last few clean-u

[U-Boot] [PATCH v5 2/2] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

2019-04-28 Thread Marcel Ziswiler
From: Marcel Ziswiler This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U-Bo

[U-Boot] [PATCH v5 1/2] imx: fix building for i.mx8 without spl

2019-04-28 Thread Marcel Ziswiler
From: Marcel Ziswiler Building with Travis CI complained and stopped with the following error: +cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory +compilation terminated. This fixes commit caceb739ea07 ("imx: build flash.bin for i.MX8") which took SPL being e

Re: [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path

2019-04-28 Thread Philipp Tomsich
> Rockchip use 'arch-rockchip' instead of arch-$(SOC) as common > header file path, so that we can get the correct path directly. > > Signed-off-by: Kever Yang > --- > > .../include/asm/arch-rockchip/ddr_rk3188.h| 2 +- > arch/arm/mach-rockchip/Kconfig| 2 +- > arch/arm/ma

Re: [U-Boot] [REGRESSION] [PATCH] imx: add lowlevel init for ARM64

2019-04-28 Thread Marcel Ziswiler
On Sun, 2019-04-28 at 14:24 -0400, Joe Hershberger wrote: > > On Apr 28, 2019, at 12:52 PM, Stefano Babic wrote: > > > > > > > > > On 27/04/19 01:58, Peng Fan wrote: > > > Hi Marcel, > > > > > > Please apply this patch, Joe has not pick it up. > > > https://patchwork.ozlabs.org/patch/1085432/

Re: [U-Boot] DE10 Nano U-Boot v2019.04 Issues

2019-04-28 Thread rafael mello
Hello Simon, Thank you for the repply. >> You probably should use mrproper here, not distclean? I do agree, mrproper should be used. >> So what's $CC set to? I don't think you need ARCH=arm, works without that >> for me. Sorry, I forgot to say that ${CC} is pointig to Linaro gcc folder. >>So SPL

[U-Boot] [PATCH 4/4] ARM: da850evm: Enable da850-ohci USB host controller

2019-04-28 Thread Adam Ford
The DA850 EVM has one USB 1.1 OHCI Host controller. With the host controller now support DM_USB, this patch enables the respective functions for the da850evm. Signed-off-by: Adam Ford diff --git a/configs/da850evm_defconfig b/configs/da850evm_defconfig index ee39b0b1bc..1845813b2e 100644 --- a/

[U-Boot] [PATCH 3/4] usb: ohci: ohci-da8xx: Enable da850-ohci driver with DM support

2019-04-28 Thread Adam Ford
This patch reuses some former code for the hawkboard, combines it with some some similar DM_USB compatible code for the OHCI driver, and enables the use of the da850's OHCI controller with DM_USB compatibility. Signed-off-by: Adam Ford diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kco

[U-Boot] [PATCH 2/4] ARM: davinci: Remove unused functions from header

2019-04-28 Thread Adam Ford
There are a few functions defined in the header file, but they are not referenced by any Davinci code. In order to make a general function in the future with static function declarations, this patch will remove the references all together. Signed-off-by: Adam Ford diff --git a/arch/arm/mach-dav

[U-Boot] (no subject)

2019-04-28 Thread Adam Ford
From 323b5ea0eec7aac821eb2319ca0debda711e8bec Mon Sep 17 00:00:00 2001 From: Adam Ford Date: Sun, 28 Apr 2019 16:42:42 -0500 Subject: [PATCH 0/4] Enable Host OHCI USB controller wtih DM_USB This series enables some commented-out code, resurrects some older code and enables DA850 OHCI USB Host co

[U-Boot] [PATCH 1/4] usb: ohci: Re-enable commented out delay

2019-04-28 Thread Adam Ford
There is a delay function that was commented out. This patch re-enables it, because it will be needed for da850 ohci support. Signed-off-by: Adam Ford diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 3b6f889f7b..2b0df88f49 100644 --- a/drivers/usb/host/ohci-hcd.c +++

Re: [U-Boot] uboot of platdata question

2019-04-28 Thread Simon Glass
Hi Peng, On Thu, 25 Apr 2019 at 02:37, Peng Fan wrote: > > Hi Simon, > > We have such piece dtb in device tree, however with SPL_OF_PLATDATA, it > failed to compile. > It could not correct get address-cells/size-cells from cpus node. Actually > It not find the address-cell/size-cell property fro

Re: [U-Boot] [PATCH] rk8xx: implement poweroff

2019-04-28 Thread Simon Glass
Hi Urja, On Fri, 26 Apr 2019 at 04:47, Urja Rannikko wrote: > > Hi, > > On Wed, Apr 24, 2019 at 3:54 AM Simon Glass wrote: > > > > Hi, > > > > On Wed, 3 Apr 2019 at 06:21, Urja Rannikko wrote: > > > > > > Based on snooping around the linux kernel rk8xx driver, and > > > tested to work on the AS

Re: [U-Boot] [PATCH 2/2] disk: efi: ignore 'IGNOREME' GPT header found on cros eMMCs

2019-04-28 Thread Simon Glass
Hi Urja, On Fri, 26 Apr 2019 at 04:26, Urja Rannikko wrote: > > Hi Simon, > > On Wed, Apr 24, 2019 at 3:54 AM Simon Glass wrote: > > > > Hi Urja, > > > > > Could we add a Kconfig to control this? Other devices shouldn't have this > > code. > I suppose i can do that... but I will need to know a

Re: [U-Boot] [PATCH 1/1] lib/display_options: avoid illegal memory access

2019-04-28 Thread Simon Glass
On Fri, 26 Apr 2019 at 10:39, Heinrich Schuchardt wrote: > > display_options_get_banner_priv() overwrites bytes before the start of the > buffer if the buffer size is less then 3. This case occurs in the Sandbox > when executing the `ut_print` command. > > Correctly handle small buffer sizes. Adju

[U-Boot] [PATCH 4/8] spi: Kconfig: Mark MXS_SPI has BROKEN

2019-04-28 Thread Jagan Teki
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Cc: Marek Vasut Cc: Fabio Estevam Cc: Michael Trimarchi Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion

[U-Boot] [PATCH 7/8] spi: Kconfig: Mark FSL_ESPI has BROKEN

2019-04-28 Thread Jagan Teki
Mark FSL_ESPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Cc: Oleksandr Zhadan and Michael Durrant Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[U-Boot] [PATCH 5/8] spi: Kconfig: Mark SH_SPI has BROKEN

2019-04-28 Thread Jagan Teki
Mark SH_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig

[U-Boot] [PATCH 2/8] Makefile: Trigger a Warning if BROKEN defined

2019-04-28 Thread Jagan Teki
If configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration. Cc: Heinrich Schuchardt Signed-off-by: Jagan Teki --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 66a09ac900..02c9a73d33 1006

[U-Boot] [PATCH 1/8] Kconfig: Update CONFIG_BROKEN help text

2019-04-28 Thread Jagan Teki
Add bool text to describe what configurations is this for. Update help text to describe the example use-case configs which comes under CONFIG_BROKEN, they are - legacy driver that would need dm conversion. - legacy driver that doesn't have proper update since from the releases. Cc: Heinrich Sch

[U-Boot] [PATCH 8/8] spi: Kconfig: Mark LPC32XX_SSP has BROKEN

2019-04-28 Thread Jagan Teki
Mark LPC32XX_SSP has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Cc: Vladimir Zapolskiy Cc: Albert ARIBAUD Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -

[U-Boot] [PATCH 3/8] Makefile: Trigger a warning for legcay spi drivers

2019-04-28 Thread Jagan Teki
We have a warning text for non dm converted spi drivers, but the plan is to mark all these respetive drivers into CONFIG_BROKEN. So, trigger a warning saying that these driver configurations and associated code will remove in v2019.07 (earlier plan is to remove it from v2019.04) Signed-off-by: Ja

[U-Boot] [PATCH 6/8] spi: Kconfig: Mark SOFT_SPI has BROKEN

2019-04-28 Thread Jagan Teki
Mark SOFT_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Cc: Vasily Khoruzhick Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/Kconf

[U-Boot] [PATCH 0/8] spi: Mark non-dm spi drivers as BROKEN

2019-04-28 Thread Jagan Teki
We have trigger a zap patches about the legacy spi driver which are not converted into dm, but the seems like most of the associated developers are unaware about the migration plan for SPI. So, as per Tom request and make the removal smooth mark these non-dm drivers into BROKEN. The configs which

[U-Boot] [PATCH v2 05/19] spi: mpc8xxx: Fix function names in strings

2019-04-28 Thread Jagan Teki
From: Mario Six Replace the function name with a "%s" format string and the __func__ variable in debug statements (as proposed by checkpatch). Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spi/mpc8xxx

[U-Boot] [PATCH v2 15/19] spi: mpc8xxx: Re-order transfer setup

2019-04-28 Thread Jagan Teki
From: Mario Six Minize the time the adapter is disabled (via SPI_MODE_EN clearing/setting) to just the character length setting, and only set up the temporary data writing variable right before we need it, so there is a more clear distinction between setting up the SPI adapter, and setting up the

[U-Boot] [PATCH v2 07/19] spi: mpc8xxx: Use IO accessors

2019-04-28 Thread Jagan Teki
From: Mario Six Accesses to the register map are currently done by directly reading and writing the structure. Switch to the appropriate IO accessors instead. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 38 +++--- 1 file changed, 19 insertions(+),

[U-Boot] [PATCH v2 02/19] spi: mpc8xxx: Fix comments

2019-04-28 Thread Jagan Teki
From: Mario Six There are some comments on the same line as the code they document. Put comments above the code lines they document, so the line length is not unnecessarily increased. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 22 ++ 1 file changed, 14 inserti

[U-Boot] [PATCH v2 19/19] dm: MIGRATION: Update migration status for SPI

2019-04-28 Thread Jagan Teki
Now, we have few driver are fully converted into dm and few are partially converted. So, update the migration status accordingly. Signed-off-by: Jagan Teki --- doc/driver-model/MIGRATION.txt | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/doc/driver-model/MIGRATION.txt

[U-Boot] [PATCH v2 16/19] spi: mpc8xxx: Fix if check

2019-04-28 Thread Jagan Teki
From: Mario Six Decreasing the bit length and increasing the write data pointer should be done when there are more than 32 bit of data, not 16 bit. This did not produce incorrect behavior, because the only time where the two checks produce different outcomes is the case of 16 < bitlen < 32, and

[U-Boot] [PATCH v2 18/19] spi: mpc8xxx: Convert to DM

2019-04-28 Thread Jagan Teki
Support DM in the MPC8xxx SPI driver, and remove the legacy SPI interface. Signed-off-by: Mario Six Signed-off-by: Jagan Teki --- drivers/spi/Kconfig | 10 +-- drivers/spi/mpc8xxx_spi.c | 144 -- 2 files changed, 112 insertions(+), 42 deletions(-) dif

[U-Boot] [PATCH v2 08/19] spi: mpc8xxx: Simplify if

2019-04-28 Thread Jagan Teki
From: Mario Six Instead of having a nested if block, just have two branches within the overarching if block to eliminate one nesting level. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/spi/mpc8xx

[U-Boot] [PATCH v2 04/19] spi: mpc8xxx: Fix space after cast

2019-04-28 Thread Jagan Teki
From: Mario Six Fix all "superfluous space after case" style errors. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index 0393765b6f..1424e7febe 100644 --- a/

[U-Boot] [PATCH v2 11/19] spi: mpc8xxx: Reduce scope of loop variables

2019-04-28 Thread Jagan Teki
From: Mario Six The transmission loop starts with setting some variables, which are only used inside the loop. Reduce the scope to the loop to make the declaration and initialization of these variables coincide. In the case of char_size this also always initializes the variable immediately with

[U-Boot] [PATCH v2 14/19] spi: mpc8xxx: Document LEN setting better

2019-04-28 Thread Jagan Teki
From: Mario Six Instead of having a table right before the code implementing the length setting for documentation, have inline comments for the if branches actually implementing the length setting described table's entries (which is readable thanks to the set_char_len function). Signed-off-by: M

Re: [U-Boot] [PATCH v2 06/10] rockchip: rk3288: use grf structure to access soc_con2

2019-04-28 Thread Philipp Tomsich
> Prefer to use structure to access register if we can. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3288/rk3288.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Philipp Tomsich ___ U-Boot mailing l

Re: [U-Boot] [PATCH v2 09/10] rockchip: rk3399: use grf structure to access reg

2019-04-28 Thread Philipp Tomsich
> Prefer to use structure to access register if we could. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3399/rk3399.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Philipp Tomsich ___ U-Boot mailing l

[U-Boot] [PATCH v2 06/19] spi: mpc8xxx: Replace defines with enums

2019-04-28 Thread Jagan Teki
From: Mario Six Replace pre-processor defines with proper enums, and use the BIT macro where applicable. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/sp

[U-Boot] [PATCH v2 01/19] spi: mpc8xxx: Use short type names

2019-04-28 Thread Jagan Teki
From: Mario Six The function signatures in the driver are quite long as is. Use short type names (uint etc.) to make them more readable. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/spi/mpc8xxx_s

Re: [U-Boot] [PATCH v2 10/10] rockchip: rk3399: add board_debug_uart_init()

2019-04-28 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file for all rockchip SoCs later. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-ro

[U-Boot] [PATCH v2 10/19] spi: mpc8xxx: Simplify logic a bit

2019-04-28 Thread Jagan Teki
From: Mario Six We do nothing in the loop if the "not empty" event was not detected. To simplify the logic, check if this is the case, and skip the execution of the loop early to reduce the nesting level and flag checking. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 23 +++

[U-Boot] [PATCH v2 03/19] spi: mpc8xxx: Rename camel-case variables

2019-04-28 Thread Jagan Teki
From: Mario Six There are three variables that have camel-case names, which is not the preferred naming style. Give those variables more compliant names instead. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(

[U-Boot] [PATCH v2 17/19] spi: mpc8xxx: Use get_timer

2019-04-28 Thread Jagan Teki
From: Mario Six The comment before the transmission loop in conjunction with the definition of SPI_TIMEOUT as 1000 implies that the loop is supposed to have a timeout value of 1000 ms. But since there is no mdelay(1) or similar in the loop body, the loop just runs 1000 times, without regard for t

[U-Boot] [PATCH v2 13/19] spi: mpc8xxx: Rename variable

2019-04-28 Thread Jagan Teki
From: Mario Six The variable "char_size" holds the number of bits to be transferred in the current loop iteration. A better name would be "xfer_bitlen", which we rename this variable to. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 8 1 file changed, 4 insertions(+), 4 del

[U-Boot] [PATCH v2 00/19] spi: Convert MPC8XXX to DM

2019-04-28 Thread Jagan Teki
This would be next version mpc8xxx dm conversion. No functional changes in v2 apart from rebase, and this would merge soon. Changes for v2: - rebase on master - patch for SPI MIGRATION status Any inputs? Jagan. Jagan Teki (2): spi: mpc8xxx: Convert to DM dm: MIGRATION: Update migration stat

[U-Boot] [PATCH v2 09/19] spi: mpc8xxx: Get rid of is_read

2019-04-28 Thread Jagan Teki
From: Mario Six Get rid of the is_read variable, and just keep the state of the "not empty" and "not full" events in two boolean variables within the loop body. Signed-off-by: Mario Six --- drivers/spi/mpc8xxx_spi.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[U-Boot] [PATCH v2 12/19] spi: mpc8xxx: Make code more readable

2019-04-28 Thread Jagan Teki
From: Mario Six Introduce the to_prescale_mod and set_char_len inline functions to make the code more readable. Note that the added "if (bitlen > 16)" check does not change the semantics of the current code, and hence only preserves the current error (this will be fixed in a later patch in the s

Re: [U-Boot] [PATCH v2 07/10] rockchip: rk3288: add board_debug_uart_init()

2019-04-28 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file for all rockchip SoCs later. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-ro

Re: [U-Boot] [PATCH v2 08/10] rockchip: rk3368: move board_debug_uart_init() to rk3368.c

2019-04-28 Thread Philipp Tomsich
> Move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file later for all rockchip SoCs. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3368-board-spl.c | 8 -- > arch/arm/mach-rockchip/rk3368-board-tpl.c | 33

Re: [U-Boot] [PATCH v2 04/10] rockchip: rk3188: add board_debug_uart_init()

2019-04-28 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3188-board-spl.c |

Re: [U-Boot] [PATCH v2 05/10] rockchip: rk322x: move board_debug_uart_init() to rk322x.c

2019-04-28 Thread Philipp Tomsich
> Move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file later for all rockchip SoCs. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk322x-board-spl.c | 44 ++- > arch/arm/mach-rockchip/rk322x-

Re: [U-Boot] [PATCH v2 03/10] rockchip: rk3036: add board_debug_uart_init()

2019-04-28 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3036-board-spl.c |

Re: [U-Boot] [PATCH v2 02/10] rockchip; kylin-rk3036: enabl DEBUG UART

2019-04-28 Thread Philipp Tomsich
> Enable debug uart for kylin board in defconfig. > > Signed-off-by: Kever Yang > --- > > configs/kylin-rk3036_defconfig | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https:/

Re: [U-Boot] [PATCH v2 01/10] rockchip: enable DEBUG_UART_BOARD_INIT by default

2019-04-28 Thread Philipp Tomsich
> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board > UART IOMUX, enable it by default. > > Signed-off-by: Kever Yang > --- > > arch/arm/Kconfig | 1 + > arch/arm/mach-rockchip/Kconfig | 4 > 2 files changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Philipp

Re: [U-Boot] [PATCH] rockchip: add Kever Yang as co-custodian

2019-04-28 Thread Philipp Tomsich
> This updates MAINTAINERS and git-mailrc to add me as a > co-custodian for rockchip > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > Acked-by: Philipp Tomsich > Acked-by: Jagan Teki > Acked-by: Tom Rini > --- > > MAINTAINERS| 1 + > doc/git-mailrc | 3 ++- > 2 files chang

Re: [U-Boot] [REGRESSION] [PATCH] imx: add lowlevel init for ARM64

2019-04-28 Thread Joe Hershberger
> On Apr 28, 2019, at 12:52 PM, Stefano Babic wrote: > > > >> On 27/04/19 01:58, Peng Fan wrote: >> Hi Marcel, >> >> Please apply this patch, Joe has not pick it up. >> https://patchwork.ozlabs.org/patch/1085432/ >> >> Stefano, >> >> Would you pick it up? > > It is acked by Joe, i assign

Re: [U-Boot] [PATCH 1/1] cmd: efidebug: rework "boot dump" sub-command using GetNextVariableName()

2019-04-28 Thread Heinrich Schuchardt
On 4/26/19 2:44 AM, AKASHI Takahiro wrote: Currently in do_efi_boot_dump(), we directly read EFI variables from related environment variables. To accommodate alternative storage backends, we should switch to using the UEFI API instead. Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schu

Re: [U-Boot] [REGRESSION] [PATCH] imx: add lowlevel init for ARM64

2019-04-28 Thread Stefano Babic
On 27/04/19 01:58, Peng Fan wrote: > Hi Marcel, > > Please apply this patch, Joe has not pick it up. > https://patchwork.ozlabs.org/patch/1085432/ > > Stefano, > > Would you pick it up? It is acked by Joe, i assign the patch to me in patchwork and I pick it up. Regards, Stefano > > >> Sub

Re: [U-Boot] [PATCH 2/4] mvebu: turris_omnia: remove redundant code

2019-04-28 Thread Baruch Siach
Hi Marek, On Thu, Apr 25 2019, Marek Behún wrote: > The i2c slave disabling is done by mvtwsi driver and is not needed here. > > Signed-off-by: Marek Behún > Cc: Baruch Siach > --- > board/CZ.NIC/turris_omnia/turris_omnia.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/bo

Re: [U-Boot] [PATCH 3/5] spi: add spi-mem driver for MediaTek MT7629 SoC

2019-04-28 Thread Jagan Teki
On Sun, Apr 28, 2019 at 6:54 AM Weijie Gao wrote: > > On Sat, 2019-04-27 at 21:38 +0530, Jagan Teki wrote: > > On Fri, Apr 26, 2019 at 2:53 PM Weijie Gao wrote: > > > > > > This patch adds spi-mem driver for MediaTek MT7629 SoC to access SPI-NOR > > > and SPI-NAND flashes. > > > > > > Cc: Jagan T

Re: [U-Boot] [PATCH] rockchip: make_fit_atf: Use BL31 environ variable for file location

2019-04-28 Thread Mark Kettenis
> From: Jagan Teki > Date: Sun, 28 Apr 2019 14:38:06 +0530 > > On Sat, Apr 27, 2019 at 6:17 PM Emmanuel Vadot wrote: > > > > > > Hi Jagan, > > > > On Sun, 21 Apr 2019 22:42:45 +0530 > > Jagan Teki wrote: > > > > > On Tue, Feb 5, 2019 at 4:24 PM Emmanuel Vadot wrote: > > > > > > > > Other make

[U-Boot] [PATCH] drivers: core: use strcmp when find device by name

2019-04-28 Thread Peng Fan
`if (!strncmp(dev->name, name, strlen(name)))` might find out the wrong device, it might find out `dram_pll_ref_sel`, when name is `dram_pll`. So use strcmp to avoid such issue. Signed-off-by: Peng Fan --- drivers/core/uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[U-Boot] [PATCH] mips: rename arch mt7620 to mt7628

2019-04-28 Thread Weijie Gao
The MediaTek MT7620 and MT7628 SoCs are different. Although they use the same memory controller, the lowlevel code (CPU PLL) and other peripherals they use are totally different. Which means they should use seperate mach directories. Currently the mach mt7620 contains only architecture code of MT7

[U-Boot] [PATCH v2 8/9] dts: Makefile: Build rockchip dtbs based on SoC types

2019-04-28 Thread Jagan Teki
Sometimes u-boot specific dts nodes or properties can use from config macros from respective rockchip family include/configs files, example CONFIG_SPL_PAD_TO. So, it's better to compile the dtbs based on the respective rockchip family types rather than rockchip itself to avoid compilation issues.

[U-Boot] [PATCH v2 9/9] rockchip: rk3399: Create single image using BINMAN

2019-04-28 Thread Jagan Teki
RK3399 platform has two stage boot loaders like SPL and U-Boot proper. For each stage we need to burn the image on to flash with respective offsets. This patch create a single image using binman, so that user can get rid of burning different stage boot images. without this patch:

[U-Boot] [PATCH v2 6/9] Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip

2019-04-28 Thread Jagan Teki
Add u-boot.itb BUILD_TARGET for Rockchip platform when SPL_LOAD_FIT is being used. This can get rid of building itb explicitly with 'make u-boot.itb' so, from now all required images will build just by make. Signed-off-by: Jagan Teki --- Kconfig | 2 +- doc/README.rockchip | 2 -- 2

[U-Boot] [PATCH v2 2/9] Makefile: clean bl31_*.bin

2019-04-28 Thread Jagan Teki
Rockchip platform has its python script that would generate various bl31_*bin for creating u-boot.itb file by taking bl31.elf as input. These bl31_*.bin files are generated in u-boot root directory and have no rule to clean it up. so add support for it by adding in command entry of clean target in

[U-Boot] [PATCH v2 5/9] board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0

2019-04-28 Thread Jagan Teki
Right now puma rk3399 board need to copy bl31-rk3399.bin and rk3399m0.bin into u-boot source directory to make use of building u-boot.itb. So, add environment variable - BL31 for bl31.bin (instead of bl31-rk3399.bin to compatible with other platform BL31 env) - PMUM0 for rk3399m0.bin If the bui

[U-Boot] [PATCH v2 7/9] Makefile.spl: Create u-boot-spl-rockchip.bin for rk3399

2019-04-28 Thread Jagan Teki
Rockchip platform would require an explicit call to mkimage for creating bootable images which indeed specific to SoC family along with boot devices. Example of creating bootable image for rk3399 family with SD boot device as ₹ mkimage -n rk3399 -T rksd -d ./spl/u-boot-spl-dtb.bin u-boot-spl-rock

[U-Boot] [PATCH v2 4/9] rockchip: rk3399: Get bl31.elf via BL31

2019-04-28 Thread Jagan Teki
Right now rockchip platform need to copy bl31.elf into u-boot source directory to make use of building u-boot.itb. So, add environment variable BL31 like Allwinner SoC so-that the bl31.elf would available via BL31. If the builds are not exporting BL31 env, the make_fit_atf.py explicitly create du

Re: [U-Boot] [PATCH] rockchip: make_fit_atf: Use BL31 environ variable for file location

2019-04-28 Thread Jagan Teki
On Sat, Apr 27, 2019 at 6:17 PM Emmanuel Vadot wrote: > > > Hi Jagan, > > On Sun, 21 Apr 2019 22:42:45 +0530 > Jagan Teki wrote: > > > On Tue, Feb 5, 2019 at 4:24 PM Emmanuel Vadot wrote: > > > > > > Other make_fit script (like imx or sunxi) use the BL31 environment > > > variable to indicate t

[U-Boot] [PATCH v2 3/9] travis.yml: Add pyelftools install entry

2019-04-28 Thread Jagan Teki
Currently rockchip platform is using explicit 'make u-boot.itb' for building u-boot.itb but if we enable CONFIG_BUILD_TARGET as 'u-boot.itb' then the resulting u-boot.itb directly will create by make. But, that indeed make travis build fail since it require python-pyelftools host package. So add

[U-Boot] [PATCH v2 1/9] Makefile: clean image.map

2019-04-28 Thread Jagan Teki
binman tools for creating single image build will create image.map at the end, which has information about binman image node details. current u-boot, is unable to clean this image.map so add a command entry in clean target in Makefile. Signed-off-by: Jagan Teki --- Makefile | 3 ++- 1 file chan

[U-Boot] [PATCH v2 0/9] rk3399: make u-boot-rockchip-with-spl.bin

2019-04-28 Thread Jagan Teki
This is v2 for previous series[1] to create single bootable image using binman for rk3399 platform. This series resolved the travis-ci build issuesi[2] which were listed in previous series. Series introduce BL31 env for exporting bl31.elf, If the builds are not exporting BL31 env, the make_fit_a

[U-Boot] is "autoconfig.mk" simply a misspelling of "autoconf.mk"?

2019-04-28 Thread Robert P. J. Day
was going over README.kconfig and noticed these references: $ grep -r autoconfig.mk * doc/README.kconfig: - spl/include/autoconfig.mk(generated by the old config for SPL) doc/README.kconfig: - tpl/include/autoconfig.mk(generated by the old config for TPL) doc/README.kconfig:

[U-Boot] [PATCH v4 4/4] [RFC] env: call env_erase twice if CONFIG_ENV_OFFSET_REDUND is set

2019-04-28 Thread Frank Wunderlich
erase also the redundant environment location if offset is defined this is a possible implementation without adding additional parameter to env erase command Signed-off-by: Frank Wunderlich --- cmd/nvedit.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cmd/nvedit.c

Re: [U-Boot] [PATCH v6 09/13] rockchip: rk3399: Add Nanopc T4 board support

2019-04-28 Thread Jagan Teki
On Sat, Apr 27, 2019 at 5:19 PM Jagan Teki wrote: > > Add initial support for Nanopc T4 board. > > Specification > - Rockchip RK3399 > - Dual-Channel 4GB LPDDR3-1866 > - SD card slot > - 16GB eMMC > - RTL8211E 1Gbps > - AP6356S WiFI/BT > - HDMI In/Out, DP, MIPI DSI/CSI, eDP > - USB 3.0, 2.0 > - US

[U-Boot] [PATCH v4 3/4] env: add option to use redundant offset

2019-04-28 Thread Frank Wunderlich
allow env erase on secondary offset using CONFIG_ENV_OFFSET_REDUND Suggested-by: Simon Goldschmidt Signed-off-by: Frank Wunderlich --- cmd/nvedit.c | 2 +- env/env.c | 4 ++-- env/mmc.c | 9 +++-- include/environment.h | 4 ++-- 4 files changed, 12 insertion

  1   2   >