Re: [U-Boot] [PATCH 1/2] efi_loader: cursor positioning

2019-09-05 Thread Alexander Graf
> Am 05.09.2019 um 22:35 schrieb Heinrich Schuchardt : > >> On 9/5/19 10:21 PM, Alexander Graf wrote: >>> On 05.09.19 10:06, Heinrich Schuchardt wrote: >>> When backspacing in column 0 do no set the column index to ULONG_MAX. >>> Ensure that the row number is not set to ULONG_MAX even if the row

Re: [U-Boot] Issue in u-boot; TFTP error: trying to overwrite reserved memory...

2019-09-05 Thread Simon Goldschmidt
Hi, On Thu, Sep 5, 2019 at 4:14 PM Moses Christopher wrote: > Hello together, > > I was trying to build u-boot and spl for the arm target and tried to boot via > usb-ethernet. > I found an issue with one of the commit made in the early 2019, > http://patchwork.ozlabs.org/patch/1024795/ > > When

[U-Boot] [PATCH v2 2/2] efi_loader: selftest: enable APPEND_WRITE tests

2019-09-05 Thread AKASHI Takahiro
Now that APPEND_WRITE is supported, the result check for the only existing test case should be changed to 'todo' to 'error', while two more test cases are added. Signed-off-by: AKASHI Takahiro --- lib/efi_selftest/efi_selftest_variables.c | 20 +++- 1 file changed, 19 insertions(

[U-Boot] [PATCH v2] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-09-05 Thread AKASHI Takahiro
With this patch, when setting UEFI variable with "env set -e" command, we will be able to - specify vendor guid with "-guid guid", - specify variable attributes, BOOTSERVICE_ACCESS, RUNTIME_ACCESS, respectively with "-bs" and "-rt", - append a value instead of overwriting with "-a", - use memory

[U-Boot] [PATCH v2 1/2] efi_loader: variable: support APPEND_WRITE

2019-09-05 Thread AKASHI Takahiro
If EFI_VARIABLE_APPEND_WRITE is specified in attributes at efi_set_variable(), specified data will be appended to the variable's original value. Attributes other than APPEND_WRITE should not be modified. With this patch, APPEND_WRITE test in 'variables' selftest will pass. Signed-off-by: AKASHI T

[U-Boot] [PATCH v2 0/2] efi_loader: support APPEND_WRITE

2019-09-05 Thread AKASHI Takahiro
Changes in v2 (Sept 6, 2019) * add a check against read-only variable to delete with APPEND_WRITE * add a check against non-existent variable to append * add/modify APPEND_WRITE tests AKASHI Takahiro (2): efi_loader: variable: support APPEND_WRITE efi_loader: selftest: enable APPEND_WRITE test

[U-Boot] [v2, 1/3] mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC

2019-09-05 Thread Yangbo Lu
Current fsl_esdhc driver had support DM_MMC with BLK enabled. Since BLK will be hard requirement of DM_MMC, let's do this now in fsl_esdhc driver. Don't keep BLK conditioanl compiling. Signed-off-by: Yangbo Lu --- Changes for v2: - None. --- drivers/mmc/fsl_esdhc.c | 35 +

[U-Boot] [v2, 2/3] mmc: fsl_esdhc: clean up code

2019-09-05 Thread Yangbo Lu
This patch is just to clean up code. There were not changes on function. Signed-off-by: Yangbo Lu --- Changes for v2: - Involved esdhc_ops in non-DM conditional build. --- drivers/mmc/fsl_esdhc.c | 286 include/fsl_esdhc.h | 203 ++

[U-Boot] [v2, 3/3] mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg

2019-09-05 Thread Yangbo Lu
For non-DM code, below functions had similar names. - fsl_esdhc_initialize - fsl_esdhc_mmc_init - fsl_esdhc_init However fsl_esdhc_init was mainly used to get cfg. So rename it to fsl_esdhc_get_cfg. Fix up bus-width capability handling, and drop controller initialization because it will be re-init

[U-Boot] [v2, 0/3] mmc: fsl_esdhc: clean up code

2019-09-05 Thread Yangbo Lu
This patch-set is to clean up fsl_esdhc code. Changes for v2: - Involved esdhc_ops in non-DM conditional build. Yangbo Lu (3): mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC mmc: fsl_esdhc: clean up code mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg drivers/mm

Re: [U-Boot] [PATCH 0/3] mmc: fsl_esdhc: clean up code

2019-09-05 Thread Y.b. Lu
Hi Peng, > -Original Message- > From: Peng Fan > Sent: Friday, September 6, 2019 10:12 AM > To: Y.b. Lu ; u-boot@lists.denx.de > Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > > > Any comments? > > Patchset break bu

Re: [U-Boot] [PATCH 0/3] mmc: fsl_esdhc: clean up code

2019-09-05 Thread Peng Fan
> Subject: RE: [PATCH 0/3] mmc: fsl_esdhc: clean up code > > Any comments? Patchset break build https://travis-ci.org/MrVan/u-boot/jobs/581073165 Please take a look. Regards, Peng. > Thanks:) > > > -Original Message- > > From: Yangbo Lu > > Sent: Monday, August 19, 2019 4:28 PM > > T

[U-Boot] COM port tracing

2019-09-05 Thread MattS
Hi all I am new at this, so excuse my ignorance, but I have been playing with u-boot and have hit a bit of a wall with loading the kernel. The u-boot and kernel are compiled for PPC. The kernel is mkimaged to a uImage. i am loading it to RAM with tftp, and running it with bootm . Up to the p

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-05 Thread Johannes Berg
On Thu, 2019-09-05 at 21:48 +0200, Johannes Berg wrote: > > As a maintainer in the community, I'll also need to change the > .git/hooks/commit-msg script that comes with gerrit to not add a Change- > Id if the commit comes with a Link: tag already, but that should be > easy. This, I should mentio

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-05 Thread Johannes Berg
On Tue, 2019-09-03 at 13:15 -0700, Douglas Anderson wrote: > > Let's give that a try. > > In theory (if there is enough adoption) this could help a tool more > reliably find various versions of a commit. It's not quite as good as this (yet), but a very simple version of it for git-send-email cou

[U-Boot] spl: net: usb: problem with the re-initialization of the usb_ethernet

2019-09-05 Thread Moses Christopher
Hello together, The following patch is generating two Ethernet interfaces in SPL stage and is not able to proceed further, *spl: net: dm: usb: bind the gadget before attempting to load the image * By removing t

[U-Boot] Issue in u-boot; TFTP error: trying to overwrite reserved memory...

2019-09-05 Thread Moses Christopher
Hello together, I was trying to build u-boot and spl for the arm target and tried to boot via usb-ethernet. I found an issue with one of the commit made in the early 2019, http://patchwork.ozlabs.org/patch/1024795/ When using this CONFIG_LMB the max_size or the *lmb_get_free_size(&lmb, load_

Re: [U-Boot] [PATCH v5 18/19] env, efi_loader: define env context for UEFI variables

2019-09-05 Thread AKASHI Takahiro
On Thu, Sep 05, 2019 at 09:37:37PM +0200, Heinrich Schuchardt wrote: > On 9/5/19 10:21 AM, AKASHI Takahiro wrote: > >We will use two environment contexts for implementing UEFI variables, > >one (ctx_efi) for non-volatile variables and the other for volatile > >variables. The latter doesn't have a b

Re: [U-Boot] [PATCH v5 02/19] env: define env context for U-Boot environment

2019-09-05 Thread AKASHI Takahiro
On Thu, Sep 05, 2019 at 09:43:59PM +0200, Heinrich Schuchardt wrote: > On 9/5/19 10:21 AM, AKASHI Takahiro wrote: > >In this patch, env context fo U-Boot environment is defined to utilize > >new env interfaces, maintaining the compatibility with the existing > >semantics and Kconfig configuration.

Re: [U-Boot] What if ATF can be part of U-Boot source, like SPL?

2019-09-05 Thread André Przywara
On Thu, 5 Sep 2019 14:26:41 +0200 Marek Vasut wrote: Hi, > On 9/5/19 2:54 AM, André Przywara wrote: > > On 04/09/2019 18:56, Marek Vasut wrote: > >> On 9/4/19 7:32 PM, Andre Przywara wrote: > I have been avoiding this thread but today I attended a talk on ATF > and ARM's approach i

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 5:23 PM, Stephen Warren wrote: On 9/5/19 6:22 AM, Heinrich Schuchardt wrote: On 9/5/19 2:06 PM, Tom Rini wrote: On Thu, Sep 05, 2019 at 08:43:43AM +0200, Heinrich Schuchardt wrote: Currently we do no have a maintainer for the FAT file system. Takahiro has done a great job fixing some

[U-Boot] [PATCH 4/4] doc: UEFI API documentation

2019-09-05 Thread Heinrich Schuchardt
Add some more files to the UEFI API documentation. Correct some Sphinx comments. Signed-off-by: Heinrich Schuchardt --- doc/api/efi.rst | 33 + lib/efi_loader/efi_console.c | 11 ++- lib/efi_loader/efi_gop.c | 2 +- lib/efi_loader/efi_ne

[U-Boot] [PATCH 2/4] efi_loader: use EFI_PRINT() instead of debug()

2019-09-05 Thread Heinrich Schuchardt
EFI_PRINT() offers indention of debug messages. Adjust the debug messages of the BLOCK_IO_PROTOCOL. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c ind

[U-Boot] [PATCH 1/4] efi_loader: parameter checks BLOCK_IO_PROTOCOL

2019-09-05 Thread Heinrich Schuchardt
Check parameters of ReadBlocks() and WriteBlocks(). If the buffer size is not a multiple of the block size, we have to return EFI_BAD_BUFFER_SIZE. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 37 - 1 file changed, 36 insertions(+), 1 del

[U-Boot] [PATCH 3/4] efi_loader: EFI_BLOCK_IO_PROTOCOL.Reset()

2019-09-05 Thread Heinrich Schuchardt
We cannot do anything in EFI_BLOCK_IO_PROTOCOL.Reset() but this does not justify to return an error. Let EFI_BLOCK_IO_PROTOCOL.Reset() return EFI_SUCCESS. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) di

[U-Boot] [PATCH 0/4] efi_loader: fix EFI_BLOCK_IO_PROTOCOL

2019-09-05 Thread Heinrich Schuchardt
* provide parameter checks for ReadBlocks and WriteBlocks * correct return code for Reset * indented debug output * add EFI_BLOCK_IO_PROTOCOL and other protocols to HTML documentation Heinrich Schuchardt (4): efi_loader: parameter checks BLOCK_IO_PROTOCOL efi_loader: use EFI_PRINT() instead of

[U-Boot] [PATCH 1/1] efi_loader: cursor positioning

2019-09-05 Thread Heinrich Schuchardt
When backspacing in column 0 do no set the column index to ULONG_MAX. Ensure that the row number is not set to ULONG_MAX even if the row count is advertised as 0. Ignore control characters other the 0x08, 0x0a, 0x0d when updating the column. Signed-off-by: Heinrich Schuchardt --- v2 add c

Re: [U-Boot] [PATCH 1/2] efi_loader: cursor positioning

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 10:21 PM, Alexander Graf wrote: On 05.09.19 10:06, Heinrich Schuchardt wrote: When backspacing in column 0 do no set the column index to ULONG_MAX. Ensure that the row number is not set to ULONG_MAX even if the row count is advertised as 0. Ignore control characters other the 0x08,

Re: [U-Boot] [PATCH 2/2] efi_loader: do not set invalid screen mode

2019-09-05 Thread Alexander Graf
On 05.09.19 10:06, Heinrich Schuchardt wrote: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.SetMode() should return EFI_UNDEFINED if a screen mode is not available. Signed-off-by: Heinrich Schuchardt Reviewed-by: Alexander Graf Alex ___ U-Boot mailing list

Re: [U-Boot] [PATCH 1/2] efi_loader: cursor positioning

2019-09-05 Thread Alexander Graf
On 05.09.19 10:06, Heinrich Schuchardt wrote: When backspacing in column 0 do no set the column index to ULONG_MAX. Ensure that the row number is not set to ULONG_MAX even if the row count is advertised as 0. Ignore control characters other the 0x08, 0x0a, 0x0d when updating the column. Signed-

Re: [U-Boot] [PATCH v5 02/19] env: define env context for U-Boot environment

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 10:21 AM, AKASHI Takahiro wrote: In this patch, env context fo U-Boot environment is defined to utilize new env interfaces, maintaining the compatibility with the existing semantics and Kconfig configuration. In this commit, FAT file system and flash device are only supported devices f

Re: [U-Boot] [PATCH v5 18/19] env, efi_loader: define env context for UEFI variables

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 10:21 AM, AKASHI Takahiro wrote: We will use two environment contexts for implementing UEFI variables, one (ctx_efi) for non-volatile variables and the other for volatile variables. The latter doesn't have a backing storage. Those two contexts are currently used only in efi_variable.c

Re: [U-Boot] [PATCH v3 0/3] spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*

2019-09-05 Thread Tom Rini
On Thu, Sep 05, 2019 at 12:16:36AM +0200, Lukasz Majewski wrote: > This patch series introduces new SPL and TPL specific Kconfig entries for > DM_SPI* options. Such change allows using the spi driver in SPL/TPL or > U-Boot proper. > > First two patches - related to ls10{42}* NXP soc fix some issue

[U-Boot] [PATCH] spl: add a generic function board_init_r

2019-09-05 Thread Philippe Reynes
This commit add a generic function board_init_r that only initialize some device (for example serial). It avoid to define a board function only to launch the serial configuration. Signed-off-by: Philippe Reynes --- common/spl/Kconfig | 8 common/spl/spl.c | 19 +++ 2

Re: [U-Boot] [PATCH] Convert CONFIG_SKIP_LOWLEVEL_INIT et al to Kconfig

2019-09-05 Thread Tom Rini
On Sat, Aug 31, 2019 at 01:25:18PM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_SKIP_LOWLEVEL_INIT >CONFIG_SKIP_LOWLEVEL_INIT_ONLY > > Signed-off-by: Adam Ford This causes problems on at least: arm: + phycore-am335x-r2-wega apalis_t30 thuban am335x

Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.

2019-09-05 Thread Neil Armstrong
Hi Bin, I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI controller connected to 2 HS-only PHYs and no SS PHY. When a device is connected on the second PHY, I have the same BUG(), but no more when a device is also connected on the first PHY, and no issues at all on th

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread Stephen Warren
On 9/5/19 6:22 AM, Heinrich Schuchardt wrote: On 9/5/19 2:06 PM, Tom Rini wrote: On Thu, Sep 05, 2019 at 08:43:43AM +0200, Heinrich Schuchardt wrote: Currently we do no have a maintainer for the FAT file system. Takahiro has done a great job fixing some of the most prominent deficiencies. But s

Re: [U-Boot] Pull request: u-boot-net.git master

2019-09-05 Thread Tom Rini
On Wed, Sep 04, 2019 at 11:42:42AM -0500, Joe Hershberger wrote: > Hi Tom, > > This PR has bug, CVE, and regression fixes as well as a few features that took > some back-and-forth. > > Travis tested here: https://travis-ci.org/jhershbe/u-boot/builds/580493530 > > The following changes since com

[U-Boot] [PATCH v3] imx: Add support for i.MX28 based XEA board

2019-09-05 Thread Lukasz Majewski
From: Mans Rullgard This patch introduces support for i.MX28 based XEA board. This board supports DM/DTS in U-Boot proper as well as DM aware drivers in SPL (u-boot.sb). More detailed information regarding usage of it can be found in ./board/liebherr/xea/README file. U-Boot SPL 2019.10-rc1-0023

Re: [U-Boot] [PATCH] drivers: nand: brcmnand: fix nand_chip ecc layout structure

2019-09-05 Thread Philippe REYNES
> The current brcmnand driver is based on 4.18 linux kernel which uses > mtd_set_ooblayout to set ecc layout. But nand base code in u-boot is from > old kernel which does not use this new API and expect nand_chip.ecc.layout > structure to be set. This cause nand_scan_tail function running into a b

Re: [U-Boot] What if ATF can be part of U-Boot source, like SPL?

2019-09-05 Thread Marek Vasut
On 9/5/19 2:54 AM, André Przywara wrote: > On 04/09/2019 18:56, Marek Vasut wrote: >> On 9/4/19 7:32 PM, Andre Przywara wrote: > > Hi Marek, Hi, I have been avoiding this thread but today I attended a talk on ATF and ARM's approach in general. ARM seems to be moving towards an app

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 2:06 PM, Tom Rini wrote: On Thu, Sep 05, 2019 at 08:43:43AM +0200, Heinrich Schuchardt wrote: Currently we do no have a maintainer for the FAT file system. Takahiro has done a great job fixing some of the most prominent deficiencies. But still the driver is not in good shape: I once a

Re: [U-Boot] [PATCH v4 1/1] board: arm: Add support for Broadcom BCM7445

2019-09-05 Thread Bin Meng
Hi Simon, On Thu, Aug 29, 2019 at 11:24 PM Bin Meng wrote: > > +Simon > > On Thu, Aug 29, 2019 at 1:24 AM Thomas Fitzsimmons > wrote: > > > > Hi Bin, > > > > Bin Meng writes: > > > > > Hi Thomas, > > > > > > On Wed, Aug 28, 2019 at 6:31 AM Thomas Fitzsimmons > > > wrote: > > >> > > >> Hi Bin

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread Tom Rini
On Thu, Sep 05, 2019 at 08:43:43AM +0200, Heinrich Schuchardt wrote: > Currently we do no have a maintainer for the FAT file system. Takahiro > has done a great job fixing some of the most prominent deficiencies. But > still the driver is not in good shape: > > I once again ran upon errors in FAT

Re: [U-Boot] [PATCH] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-09-05 Thread Heinrich Schuchardt
On 9/5/19 11:20 AM, AKASHI Takahiro wrote: On Tue, Sep 03, 2019 at 10:46:04PM +0200, Heinrich Schuchardt wrote: On 9/3/19 7:41 AM, AKASHI Takahiro wrote: With this patch, when setting UEFI variable with "env set -e" command, we will be able to - specify vendor guid with "-guid guid", - specify

Re: [U-Boot] [PATCH v2 5/5] imx: add i.MX6ULZ board

2019-09-05 Thread Fabio Estevam
Hi Stefan, On Thu, Sep 5, 2019 at 5:59 AM Stefan Roese wrote: > a) > Why is SPL not used in the mainline i.MX6ULL/ULZ port? The i.MX6UL > (14x14) does use SPL. Yes, I think it could SPL as well. Maybe Peng can comment. > b) > Do you have a reference board (eval kit) that supports LPDDR2 on the

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-05 Thread Heiko Schocher
Hello Lukasz, Am 05.09.2019 um 11:42 schrieb Lukasz Majewski: Hi Stefano, On 04/09/19 12:35, Lukasz Majewski wrote: On Wed, 4 Sep 2019 11:54:40 +0200 Lukasz Majewski wrote: Hi Stefano, Heiko, On 04/09/19 10:46, Lukasz Majewski wrote: Hi Heiko, Hello Lukasz, added Stefano

Re: [U-Boot] [PATCH] ARM: exynos5: Try to boot on mmc2 before mmc0/1

2019-09-05 Thread Minkyu Kang
Hi, On 31/08/2019 00:51, Oleksandr Suvorov wrote: > On Fri, Aug 30, 2019 at 4:20 PM Guillaume Gardet > wrote: >> >> Hi, >> >> I got no feedback on this patch. Is there anything blocking it? >> >> Guillaume >> >> >>> -Original Message- >>> From: Guillaume GARDET >>> Sent: 24 July 2019 09:

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-05 Thread Heiko Schocher
Hello Stefano, Lukasz, Am 05.09.2019 um 10:08 schrieb Stefano Babic: On 04/09/19 12:35, Lukasz Majewski wrote: On Wed, 4 Sep 2019 11:54:40 +0200 Lukasz Majewski wrote: Hi Stefano, Heiko, On 04/09/19 10:46, Lukasz Majewski wrote: Hi Heiko, Hello Lukasz, added Stefano to cc as he is

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-05 Thread Lukasz Majewski
Hi Stefano, > On 04/09/19 12:35, Lukasz Majewski wrote: > > On Wed, 4 Sep 2019 11:54:40 +0200 > > Lukasz Majewski wrote: > > > >> Hi Stefano, Heiko, > >> > >>> On 04/09/19 10:46, Lukasz Majewski wrote: > Hi Heiko, > > > Hello Lukasz, > > > > added Stefano to

Re: [U-Boot] [PATCH] efi_loader: variable: support APPEND_WRITE

2019-09-05 Thread AKASHI Takahiro
On Tue, Sep 03, 2019 at 10:31:25PM +0200, Heinrich Schuchardt wrote: > On 9/3/19 7:40 AM, AKASHI Takahiro wrote: > >If EFI_VARIABLE_APPEND_WRITE is specified in attributes at > >efi_set_variable(), specified data will be appended to the variable's > >original value. Attributes other than APPEND_WRI

Re: [U-Boot] [PATCH] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-09-05 Thread AKASHI Takahiro
On Tue, Sep 03, 2019 at 10:46:04PM +0200, Heinrich Schuchardt wrote: > On 9/3/19 7:41 AM, AKASHI Takahiro wrote: > >With this patch, when setting UEFI variable with "env set -e" command, > >we will be able to > >- specify vendor guid with "-guid guid", > >- specify variable attributes, BOOTSERVICE

Re: [U-Boot] [PATCH v2 5/5] imx: add i.MX6ULZ board

2019-09-05 Thread Stefan Roese
Hi Peng, Hi Fabio, On 08.08.19 11:55, Peng Fan wrote: Add i.MX6ULZ board support. the i.MX6ULZ is SW compatible with i.MX6ULL. so most code of i.MX6ULL can be reused by i.MX6ULZ. Signed-off-by: Peng Fan --- V2: Add entry in MAINTAINERS arch/arm/dts/imx6ulz-14x14-evk.dts| 22 +

[U-Boot] [PATCH v2 0/4] Fix default values for address and size cells

2019-09-05 Thread matthias . bgg
From: Matthias Brugger The libftd implementation of U-Boot is outdated with the upstream project. Especially the default number of size-cells was wrong. This series fixes this by backporting the corresponding patches from the upstream project. Changes since v1: - fix spelling of U-Boot (patch 1

[U-Boot] [PATCH v2 2/4] libfdt: return correct value if #size-cells property is not present

2019-09-05 Thread matthias . bgg
From: Matthias Brugger According to the device tree specification, the default value for was not present. This patch also makes fdt_address_cells() and fdt_size_cells() conform to the behaviour documented in libfdt.h. The defaults are only returned if fdt_getprop() returns -FDT_ERR_NOTFOUND, oth

[U-Boot] [PATCH v2 4/4] dm: Fix default address cells return value

2019-09-05 Thread matthias . bgg
From: Matthias Brugger Default address cells value on the livetree access function returns the wrong value. Fix this so that the value returned corresponds to the device tree specification. Signed-off-by: Matthias Brugger --- include/dm/of.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[U-Boot] [PATCH v2 3/4] libfdt: Allow #size-cells of 0

2019-09-05 Thread matthias . bgg
From: Matthias Brugger The commit "libfdt: fdt_address_cells() and fdt_size_cells()" introduced a bug as it consolidated code between the helpers for getting be 0, and is frequently found so in practice for /cpus. IEEE1275 only requires implementations to handle 1..4 for #address-cells, although

[U-Boot] [PATCH v2 1/4] libfdt: fdt_address_cells() and fdt_size_cells()

2019-09-05 Thread matthias . bgg
From: Matthias Brugger Add internal fdt_cells() to avoid copy and paste. Fix typo in fdt_size_cells() documentation comment. This is based in upstream commit: c12b2b0 ("libfdt: fdt_address_cells() and fdt_size_cells()") but misses the test cases, as we don't implement them in U-Boot. Signed-off

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread AKASHI Takahiro
On Thu, Sep 05, 2019 at 08:43:43AM +0200, Heinrich Schuchardt wrote: > Currently we do no have a maintainer for the FAT file system. Takahiro > has done a great job fixing some of the most prominent deficiencies. But > still the driver is not in good shape: > > I once again ran upon errors in FAT

Re: [U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-09-05 Thread AKASHI Takahiro
One more issue: * Currently, Travis CI fails in lots of builds. I will try to fix them in the succeeding versions. -Takahiro Akashi On Thu, Sep 05, 2019 at 05:21:14PM +0900, AKASHI Takahiro wrote: > # In version 5 of this patch set, the implementation is changed again. > # > # I believe that th

[U-Boot] [PATCH v5 17/19] post: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- post/post.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/post/post.c b/post/post.c index fb751d9a83a5..d8a8279123cc 100644 --- a/post/post.c +++ b/post/post.c @@ -176,7 +176,7 @@ static void post_ge

[U-Boot] [PATCH v5 14/19] fs: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- fs/fs.c | 14 +++--- fs/ubifs/ubifs.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/fs.c b/fs/fs.c index d8a4ced4698e..b26c94f89764 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -647,

[U-Boot] [PATCH v5 18/19] env, efi_loader: define env context for UEFI variables

2019-09-05 Thread AKASHI Takahiro
We will use two environment contexts for implementing UEFI variables, one (ctx_efi) for non-volatile variables and the other for volatile variables. The latter doesn't have a backing storage. Those two contexts are currently used only in efi_variable.c and can be moved into there if desired. But I

[U-Boot] [PATCH v5 19/19] efi_loader: variable: rework with new env interfaces

2019-09-05 Thread AKASHI Takahiro
In the previous commit, two efi-related contexts were introduced. With this patch, EFI variables implementation will be modified to support volatile/non-volatile attribute properly in such away as UEFI specification expects; If a variable is non-volatile and modified, its value will be updated in

[U-Boot] [PATCH v5 16/19] net: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- net/bootp.c | 17 + net/dns.c| 2 +- net/eth-uclass.c | 6 +++--- net/eth_common.c | 18 +- net/eth_legacy.c | 2 +- net/link_local.c | 2 +- net/net.c| 11 ++--

[U-Boot] [PATCH v5 11/19] common: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- common/autoboot.c | 22 -- common/board_f.c | 3 ++- common/board_r.c | 10 +- common/bootm.c | 12 +++- common/bootm_os.c | 12 ++-- common/bootr

[U-Boot] [PATCH v5 15/19] lib: converted with new env interfaces (except efi_loader)

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- lib/efi_loader/efi_console.c | 2 +- lib/fdtdec.c | 2 +- lib/smbios.c | 2 +- lib/uuid.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/efi_lo

[U-Boot] [PATCH v5 12/19] disk: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- disk/part.c | 2 +- disk/part_amiga.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/disk/part.c b/disk/part.c index 8982ef3baed1..6bbb40c62182 100644 --- a/disk/part.c +++ b/disk/part.c @@

[U-Boot] [PATCH v5 13/19] drivers: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- drivers/bootcount/bootcount_env.c | 12 +++- drivers/ddr/fsl/fsl_ddr_gen4.c | 2 +- drivers/ddr/fsl/interactive.c | 5 +++-- drivers/ddr/fsl/options.c | 4 ++-- drivers/dfu/dfu.c

[U-Boot] [PATCH v5 07/19] api: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- api/api.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/api/api.c b/api/api.c index bc9454eb4b63..d1dd8bfc60af 100644 --- a/api/api.c +++ b/api/api.c @@ -458,7 +458,8 @@ static int API_env_ge

[U-Boot] [PATCH v5 10/19] cmd: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- cmd/ab_select.c | 2 +- cmd/avb.c| 2 +- cmd/bdinfo.c | 6 +++--- cmd/binop.c | 4 ++-- cmd/bootefi.c| 8 cmd/bootm.c | 4 ++-- cmd/bootmenu.c | 6 +++--- cmd/cbfs.c | 2

[U-Boot] [PATCH v5 08/19] arch: converted with new env interfaces

2019-09-05 Thread AKASHI Takahiro
env_xxx(...) -> env_xxx(ctx_uboot, ...) Signed-off-by: AKASHI Takahiro --- arch/arc/lib/bootm.c | 2 +- arch/arm/cpu/arm926ejs/spear/spr_misc.c | 8 ++--- arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 5 +-- arch/arm/cpu/armv8/fsl-layerscape/soc.c | 14 +

[U-Boot] [PATCH v5 06/19] hashtable: support multiple env contexts

2019-09-05 Thread AKASHI Takahiro
With this patch, variable's context is always honored in all operations, FIND/ENTER (including delete). Signed-off-by: AKASHI Takahiro --- include/search.h | 6 +- lib/hashtable.c | 14 +++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/include/search.h b/includ

[U-Boot] [PATCH v5 05/19] env: fat: support multiple env contexts

2019-09-05 Thread AKASHI Takahiro
To support multiple env contexts in this backing store driver, all the necessary parameters to load/save context data with will be contained in dedicated structure, env_fat_context. All the contexts that want to support their own context must provide its own Kconfig to fill in the parameters. Sig

[U-Boot] [PATCH v5 04/19] env: flash: support multiple env contexts

2019-09-05 Thread AKASHI Takahiro
To support multiple env contexts in this backing store driver, all the necessary parameters to load/save context data with will be contained in dedicated structure, env_flash_context. All the contexts that want to support their own context must provide its own Kconfig to fill in the parameters. S

[U-Boot] [PATCH v5 03/19] env: nowhere: rework with new env interfaces

2019-09-05 Thread AKASHI Takahiro
Make this function a place holder. Managing default values, in particular for U-Boot environment, should go into context-specific initialization. Signed-off-by: AKASHI Takahiro --- env/nowhere.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/env/nowhere.c b/env/nowher

[U-Boot] [PATCH v5 02/19] env: define env context for U-Boot environment

2019-09-05 Thread AKASHI Takahiro
In this patch, env context fo U-Boot environment is defined to utilize new env interfaces, maintaining the compatibility with the existing semantics and Kconfig configuration. In this commit, FAT file system and flash device are only supported devices for backing storages, but extending to other d

[U-Boot] [PATCH v5 01/19] env: extend interfaces allowing for env contexts

2019-09-05 Thread AKASHI Takahiro
The notion of "env context" (or simply "context") will provide users of env interfaces to manage their own domain of variables, which is separated from other contexts and can be loaded/stored with dedicated backing storage device. With this patch, almost of all env interfaces are extended to accep

[U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-09-05 Thread AKASHI Takahiro
# In version 5 of this patch set, the implementation is changed again. # # I believe that this is NOT intrusive, and that my approach here is NOT # selfish at all. If Wolfgang doesn't accept this approach, however, # I would like to go for "Plan B" for UEFI variables implementation, in # which EFI

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-05 Thread Stefano Babic
On 04/09/19 12:35, Lukasz Majewski wrote: > On Wed, 4 Sep 2019 11:54:40 +0200 > Lukasz Majewski wrote: > >> Hi Stefano, Heiko, >> >>> On 04/09/19 10:46, Lukasz Majewski wrote: Hi Heiko, > Hello Lukasz, > > added Stefano to cc as he is the imx custodian.

[U-Boot] [PATCH 0/2] efi_loader: fixes for Simple Output Protocol

2019-09-05 Thread Heinrich Schuchardt
Fix errors in the simple output protocol which may lead to providing incorrect values for columns or rows. Allowing to set an illegal screen mode has led to an illegal memory access in the UEFI SCT. For reference: As the illegal memory access led to QEMU stopping the following patch for Linux ha

[U-Boot] [PATCH 1/2] efi_loader: cursor positioning

2019-09-05 Thread Heinrich Schuchardt
When backspacing in column 0 do no set the column index to ULONG_MAX. Ensure that the row number is not set to ULONG_MAX even if the row count is advertised as 0. Ignore control characters other the 0x08, 0x0a, 0x0d when updating the column. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/

[U-Boot] [PATCH 2/2] efi_loader: do not set invalid screen mode

2019-09-05 Thread Heinrich Schuchardt
EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.SetMode() should return EFI_UNDEFINED if a screen mode is not available. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index d

Re: [U-Boot] [PATCH] env: Add CONFIG_ENV_SUPPORT

2019-09-05 Thread Patrick DELAUNAY
Hi Lukasz, > From: Lukasz Majewski > Sent: mercredi 4 septembre 2019 10:52 > > Hi Patrick, > > > Add a new flag CONFIG_ENV_SUPPORT to compile all the environment > > features in U-Boot (attributes, callbacks and flags). It is the > > equivalent of the 2 existing flags > > - CONFIG_SPL_ENV_SUPPO

[U-Boot] [PATCH v3 7/7] spi: Add support for SPL_OF_PLATDATA to mxs_gpio.c driver

2019-09-05 Thread Lukasz Majewski
After this patch the mxs_gpio.c DM/DTS driver can be used at early SPL to read states of gpio pins (and for example alter the boot flow). It was necessary to adjust its name to 'fsl_imx_2{38}_gpio' to match requirements for SPL_OF_PLATDATA usage. Signed-off-by: Lukasz Majewski --- Changes in v3

[U-Boot] [PATCH v3 5/7] mmc: Convert mxsmmc eMMC driver for i.MX2{38} to DM/DTS

2019-09-05 Thread Lukasz Majewski
This patch converts the mxsmmc driver to support DM/DTS. Moreover, it is also possible to use it in early SPL with SPL_OF_PLATDATA enabled. Signed-off-by: Lukasz Majewski --- Changes in v3: - Drop following patches from this series (as they are generic, non i.MX specific code): [U-Boot,v2

[U-Boot] [PATCH v3 3/7] spi: fix: Call mxs_reset_block() during DM/DTS probe

2019-09-05 Thread Lukasz Majewski
Without this change the DM/DTS version of mxs_spi driver doesn't reset the SPI IP block in probe. As a result this driver (when used solely on U-Boot proper) relies on reset performed by mxs spi driver in SPL. In the use case where eMMC is used in SPL as a boot primary device, the mxs_reset_block(

[U-Boot] [PATCH v3 1/7] dts: imx28: Remove #include "imx28.dtsi" from imx28-u-boot.dtsi file

2019-09-05 Thread Lukasz Majewski
After this change it is possible to use imx28--u-boot.dtsi with the imx28-u-boot.dtsi explicitly included without breaking setup from imx28-.dts file. The problem is that the imx28.dtsi included in a wrong place overrides the changes made in imx28-.dts. As a result some devices are "disabled" in t

[U-Boot] [PATCH v3 6/7] mmc: Replace printf with debug call for timeouts in the i.MX28 mxs driver

2019-09-05 Thread Lukasz Majewski
This change replaces printf() with debug() for the notification about commands timeouts. This is done on purpose (also other drivers use such approach - dw_mmc.c, mvebu_mmc.c), as the mmc core code (mmc.c) uses timeouts to assess if one is using sd card or eMMC device. In such situation timeout is

[U-Boot] [PATCH v3 2/7] spl: Init proper struct driver member (platdata_auto_alloc_size) for mxs_spi

2019-09-05 Thread Lukasz Majewski
This change initializes proper member of struct driver - platdata_auto_alloc_size instead of priv_auto_alloc_size, which is setup twice. Signed-off-by: Lukasz Majewski --- Changes in v3: None Changes in v2: - New patch drivers/spi/mxs_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[U-Boot] [PATCH v3 4/7] spi: Add support for SPL_OF_PLATDATA to mxs_spi.c driver

2019-09-05 Thread Lukasz Majewski
After this patch the mxs_spi.c DM/DTS driver can be used at early SPL to read payload from SPI-NOR memories. It was necessary to adjust its name to 'fsl_imx_2{38}_spi' to match requirements for SPL_OF_PLATDATA usage. Signed-off-by: Lukasz Majewski --- Changes in v3: None Changes in v2: None d

[U-Boot] [PATCH v3 0/7] imx: mxs: Fixes and DM/DTS conversion code for several i.MX28 drivers

2019-09-05 Thread Lukasz Majewski
This patch series focuses on fixing and enhancing the i.MX28 to be converted to DM/DTS. The mxs gpio, spi and eMMC drivers have been fixed and converted to DM/DTS. Some of them also gain support for OF_PLATDATA, when run in constrained SPL (u-boot.sb). Applies on -master SHA1: 448f11f7503995746a7b