Re: [PATCH 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-15 Thread Marek Vasut
On 2/15/20 8:39 PM, Simon Goldschmidt wrote: > Am 15.02.2020 um 15:02 schrieb Marek Vasut: >> The default timer rate may be different than 25 MHz, permit overriding >> the default rate in board configuration file. Ultimatelly, this should >> be properly handled by a clock driver, however that is

sunxi_nand_spl reading zeros on NextThing C.H.I.P.

2020-02-15 Thread Yevhenii Hrabliuk
Hello, I'm trying to get latest U-Boot to work on the NextThing C.H.I.P. After borrowing NFC config from the Chip Pro .dts, I can write the SPL to NAND after loading U-Boot via sunxi-fel and the bootrom will pick it up fine. So the "full" sunxi_nand.c works. SPL's sunxi_nand_spl.c appears to

NanoPi-M4 boot issue

2020-02-15 Thread Trevor Woerner
Hi, I'm trying to build an image for a NanoPi-M4 but it is not able to get out of TPL. The U-Boot build seems to be constructing the idbloader.img properly, but the board is failing to boot. Note that this is an original NanoPi-M4 (i.e. V1) and not the NanoPi-M4V2. >From the build log:

[PATCH 1/1] arm: mvebu: drivers/ddr: remove redundant assignment

2020-02-15 Thread Heinrich Schuchardt
The value of local variable ecc is immediately overwritten. So we can remove the first assignment. Signed-off-by: Heinrich Schuchardt --- drivers/ddr/marvell/axp/ddr3_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/ddr/marvell/axp/ddr3_init.c

[PATCH 1/1] dm: core: remove redundant assignment

2020-02-15 Thread Heinrich Schuchardt
Variable count is initialized at the start of every round of the while loop and it is not used after the while loop. So there is no need to initialize it beforehand. Identified by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/core/of_access.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 1/1] dm: core: remove redundant if statement

2020-02-15 Thread Heinrich Schuchardt
The value of parent is not changed in the first if statement. So we can merge the two if statements depending on parent. Indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/core/device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 1/1] clk: ICS8N3QV01 remove superfluous code

2020-02-15 Thread Heinrich Schuchardt
Do not calculate a unused value of n which is overwritten in both branches of the subsequent if statement. Identified by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/clk/ics8n3qv01.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/ics8n3qv01.c

[PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-15 Thread Heinrich Schuchardt
If all branches of a switch statement have a return instruction, all subsequent lines are unreachable. Identified with cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/clk/intel/clk_intel.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/clk/intel/clk_intel.c

[PATCH 1/1] clk: meson-g12a: missing break

2020-02-15 Thread Heinrich Schuchardt
Add missing break for CLKID_PCIE_PLL in switch statement. Reported by CppCheck. Cc: Neil Armstrong Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support") Signed-off-by: Heinrich Schuchardt --- Looking at the code it seems obvious that something is wrong in commit 08e09c263fdf but I have

Re: [PATCH 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-15 Thread Simon Goldschmidt
Am 15.02.2020 um 15:02 schrieb Marek Vasut: > The default timer rate may be different than 25 MHz, permit overriding > the default rate in board configuration file. Ultimatelly, this should > be properly handled by a clock driver, however that is not available > on Gen5 yet. Sigh, yes, I still

[PATCH 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-15 Thread Marek Vasut
The default timer rate may be different than 25 MHz, permit overriding the default rate in board configuration file. Ultimatelly, this should be properly handled by a clock driver, however that is not available on Gen5 yet. Signed-off-by: Marek Vasut Cc: Ley Foon Tan Cc: Simon Goldschmidt ---

[PATCH 2/2] ARM: socfpga: Add missing Denali NAND config options

2020-02-15 Thread Marek Vasut
The Denali SPL shim won't build without these options set, set them accordingly to fix the build error and let the SPL shim to work correctly. Signed-off-by: Marek Vasut Cc: Ley Foon Tan Cc: Simon Goldschmidt --- include/configs/socfpga_common.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH] rtc: m41t62: add compatible for m41st87

2020-02-15 Thread Marek Vasut
This adds a compatible string for m41st87. This ensures that this driver can be used for m41st87 . Signed-off-by: Marek Vasut Cc: Simon Goldschmidt Cc: Stefan Roese --- drivers/rtc/m41t62.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/m41t62.c b/drivers/rtc/m41t62.c index

[PATCH] power-domain: fix hang in endless loop on i.MX8

2020-02-15 Thread Anatolij Gustschin
Currently when booting the kernel on i.MX8 U-Boot hangs in an endless loop when switching off dma, connectivity or lsio power domains during device removal. It hapens first when removing gpio0 (gpio@5d08) device, here its power domain device 'lsio_gpio0' is obtained for switching off power.

[PATCH v3 4/6] test: log functions with CONFIG_LOG=n

2020-02-15 Thread Heinrich Schuchardt
If CONFIG_LOG=n, we still expect output for log_err(), log_warning(), log_notice(), log_info() and in case of DEBUG=1 also for log_debug(). Provide unit tests verifying this. The tests depend on: CONFIG_CONSOLE_RECORD=y CONFIG_LOG=n CONFIG_UT_LOG=y It may be necessary

[PATCH v3 6/6] configs: sandbox: enable LOG_SYSLOG

2020-02-15 Thread Heinrich Schuchardt
For testing purposes enable the syslog logging driver. Signed-off-by: Heinrich Schuchardt --- v3: new patch --- configs/sandbox64_defconfig| 1 + configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + 3 files changed, 3 insertions(+) diff --git

[PATCH v3 2/6] log: syslog driver

2020-02-15 Thread Heinrich Schuchardt
Provide a log driver that broadcasts RFC 3164 messages to syslog servers. rsyslog is one implementation of such a server. The messages are sent to the local broadcast address 255.255.255.255 on port 514. The environment variable log_hostname can be used to provide the HOSTNAME field for the

[PATCH v3 3/6] log: output for CONFIG_LOG=n

2020-02-15 Thread Heinrich Schuchardt
If CONFIG_LOG=n, we should still output errors, warnings, notices, infos, and for DEBUG=1 also debug messages. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change --- include/log.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 5/6] test: log: test syslog logging driver

2020-02-15 Thread Heinrich Schuchardt
Provide unit tests for the syslog logging driver. Signed-off-by: Heinrich Schuchardt --- v3: new patch --- test/log/Makefile | 4 + test/log/syslog_test.c | 186 + 2 files changed, 190 insertions(+) create mode 100644

[PATCH v3 1/6] log: correct CONFIG_LOG_TEST prerequisites

2020-02-15 Thread Heinrich Schuchardt
An error undefined reference to `do_log_test' occurs for CONFIG_CMD_LOG=y, CONFIG_LOG_TEST=y, CONGIG_UNIT_TEST=n Make CONFIG_UNIT_TEST a prerequisite. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change --- common/Kconfig | 2 +- 1 file changed, 1

[PATCH v3 0/6] log: syslog logging driver

2020-02-15 Thread Heinrich Schuchardt
This patch series provides a logging driver to send syslog messages via UDP port 514 to a syslog server and a unit test for the syslog driver. For testing LOG_SYSLOG is enabled on the sandbox. For CONFIG_LOG=n a patch enables printf() or debug() output for log_* functions. A unit test for this