Re: [PATCH v4] usb: xhci: fix lack of short packet event trb handling

2020-12-16 Thread Marek Vasut
On 12/16/20 4:02 AM, Bin Meng wrote: Hi [...] This patch adds a loop to make sure the event TRB for last transfer TRB has been handled in time. Applied, thanks. I see in patchwork this was assigned to me and I don't see this patch got its way to mainline. Let me know if I need to apply thi

[PATCH u-boot 1/2] eth/r8152: free previous memory if r8152_eth_probe fail

2020-12-16 Thread Hayes Wang
The r8152_eth_probe() may allocate a memory for ss->dev_priv. It has to be freed if r8152_eth_probe() fails finally. Signed-off-by: Hayes Wang --- drivers/usb/eth/r8152.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.

[PATCH u-boot 2/2] eth/r8152: fix the aggregation issue

2020-12-16 Thread Hayes Wang
Remove the redundant setting for USB_RX_EARLY_SIZE. Besides, for RTL8153B, it is necessary to notify the hardware of the changes of the aggregation settings. Signed-off-by: Hayes Wang --- drivers/usb/eth/r8152.c | 17 +++-- drivers/usb/eth/r8152.h | 5 + 2 files changed, 20 inse

[PATCH u-boot 0/2] eth/r8152: fix issues

2020-12-16 Thread Hayes Wang
The two patch are used to fix known issues. Hayes Wang (2): eth/r8152: free previous memory if r8152_eth_probe fail eth/r8152: fix the aggregation issue drivers/usb/eth/r8152.c | 26 ++ drivers/usb/eth/r8152.h | 5 + 2 files changed, 27 insertions(+), 4 deletions

Re: [PATCH v2] Add support for 10G Base-R IP core version to xilinx_axi_enet driver

2020-12-16 Thread Michal Simek
Hi, still please fix the subject. The best is to run git log drivers/net/xilinx_axi_emac.c and you will see that some tags are used. net: xilinx: axi_emac: Then your subject can be just net: xilinx: axi_emac: Add support for 10G Base-R IP On 15. 12. 20 19:27, Alessandro Temil wrote: > From: Ale

Re: [PATCH u-boot 0/2] eth/r8152: fix issues

2020-12-16 Thread Marek Vasut
On 12/16/20 10:03 AM, Hayes Wang wrote: The two patch are used to fix known issues. Applied both, thanks.

Please pull u-boot-x86

2020-12-16 Thread Bin Meng
Hi Tom, This PR includes the following x86 changes for v2021.01 release: - Update cmdline parameter to be an env var in zimage boot - Various minor fixes for Intel Edison board Azure pipelines results: PASS https://dev.azure.com/bmeng/GitHub/_build/results?buildId=301&view=results The following

[PATCH] board: phytec: imx8mp: Add PHYTEC phyCORE-i.MX8MP support

2020-12-16 Thread Teresa Remmet
Add initial support PHYTEC phyCORE-i.MX8MP SOM. Supported features: - 2GB LPDDR4 RAM - eMMC - external SD - debug UART2 - watchdog Signed-off-by: Teresa Remmet --- arch/arm/dts/Makefile|1 + arch/arm/dts/phycore-imx8mp-u-boot.dtsi |

RE: [PATCH v5 0/2] dm: core: drivers: add function uclass_probe_all()

2020-12-16 Thread Vabhav Sharma (OSS)
Dear Sean Anderson, I have incorporated all your review comments and request your review/ack to merge the changes Regards, Vabhav > -Original Message- > From: Vabhav Sharma > Sent: Wednesday, December 9, 2020 10:42 AM > To: s...@chromium.org; s...@denx.de; sean...@gmail.com > Cc: u-boot

[PATCH 0/2] Use RNG to get random behaviour

2020-12-16 Thread matthias . bgg
From: Matthias Brugger For now bootp and uuid code use a weak seed for generating random data. U-Boot as support for RNG devices now, so we should change to code to use them if they are present. This will help mitigate issues like seen in CVE-2019-11690. Matthias Brugger (2): lib: uuid: use

[PATCH 1/2] lib: uuid: use RNG device if present

2020-12-16 Thread matthias . bgg
From: Matthias Brugger When calculating a random UUID we use a weak seed. Use a RNG device if present to increase entropy. Signed-off-by: Matthias Brugger --- lib/uuid.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/lib/uuid.c b/lib/uuid.c index e62

[PATCH 2/2] net: Use NDRNG device in srand_mac()

2020-12-16 Thread matthias . bgg
From: Matthias Brugger When calling srand_mac we use a weak seed dependent on the mac address. If present, use a RNG device instead to incerase entropy. Signed-off-by: Matthias Brugger --- net/net_rand.h | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/n

Re: [PATCH 1/6] net: macb: use dummy descriptor for RBQP

2020-12-16 Thread Eugen.Hristev
On 03.12.2020 11:25, Claudiu Beznea wrote: > In case of multiple queues on RX side the queue scheduler > will try to use all the available configured queues (with > descriptors having TX_USED bit cleared). If at least one RBQP > points to a descriptor with a valid used bit configuration then > the

[PATCH] dm: spi: Fix spi_free_slave() freed memory write

2020-12-16 Thread Niel Fourie
Remove setting slave->dev to NULL after the device_remove() call. The slave pointer points to dev->parent_priv, which has already been freed by device_free(), called from device_remove() in the preceding line. Writing to slave->dev may cause corruption of the dlmalloc free chunk forward pointer of

[PATCH 1/1] doc: button command

2020-12-16 Thread Heinrich Schuchardt
Provide a description of the 'button' command. Signed-off-by: Heinrich Schuchardt --- doc/usage/button.rst | 64 doc/usage/index.rst | 1 + 2 files changed, 65 insertions(+) create mode 100644 doc/usage/button.rst diff --git a/doc/usage/button.rst

Re: [PATCH 1/6] net: macb: use dummy descriptor for RBQP

2020-12-16 Thread Eugen.Hristev
On 16.12.2020 09:17, Bin Meng wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Eugen, > > On Wed, Dec 16, 2020 at 2:55 PM wrote: >> >> On 03.12.2020 11:25, Claudiu Beznea wrote: >>> In case of multiple queues on RX side the queue sched

Re: Documentation fixes for v2020.01-rc4

2020-12-16 Thread Tom Rini
On Tue, Dec 15, 2020 at 05:51:13PM +0100, Heinrich Schuchardt wrote: > Hello Tom, > > this is just a collection of documentation changes. Please, pull them. > > The following changes since commit f40825e18e0a8560991072114b9b10b33fdad95b: > > Merge https://gitlab.denx.de/u-boot/custodians/u-bo

Re: [PATCH v1] distro_bootcmd: set devtype for dhcp boot

2020-12-16 Thread Tom Rini
On Thu, Oct 29, 2020 at 12:59:19PM +0200, Igor Opaniuk wrote: > From: Igor Opaniuk > > Set $devtype for DHCP boot, which can be handy for the boot.scr > for detection of devtype used (for example, when the same boot.scr is > used for both mmc/dhcp boot): > > if test ${devtype} = "dhcp"; then >

Re: [PATCH 0/2] Use RNG to get random behaviour

2020-12-16 Thread Torsten Duwe
On Wed, 16 Dec 2020 11:41:15 +0100 matthias@kernel.org wrote: > From: Matthias Brugger > > > For now bootp and uuid code use a weak seed for generating random > data. U-Boot as support for RNG devices now, so we should change to > code to use them if they are present. This will help mitigat

Re: [PATCH 2/2] net: Use NDRNG device in srand_mac()

2020-12-16 Thread Torsten Duwe
On Wed, 16 Dec 2020 11:41:17 +0100 matthias@kernel.org wrote: > From: Matthias Brugger > > When calling srand_mac we use a weak seed dependent on the > mac address. If present, use a RNG device instead to incerase entropy. > > Signed-off-by: Matthias Brugger > > --- > > net/net_rand.h |

Re: [PATCH 1/2] lib: uuid: use RNG device if present

2020-12-16 Thread Torsten Duwe
On Wed, 16 Dec 2020 11:41:16 +0100 matthias@kernel.org wrote: > @@ -249,9 +250,22 @@ void gen_rand_uuid(unsigned char *uuid_bin) > { > u32 ptr[4]; > struct uuid *uuid = (struct uuid *)ptr; > - int i; > - > - srand(get_ticks() + rand()); > + int i, ret; > + struct u

Re: [PATCH 0/2] Use RNG to get random behaviour

2020-12-16 Thread Peter Robinson
On Wed, Dec 16, 2020 at 1:17 PM Torsten Duwe wrote: > > On Wed, 16 Dec 2020 11:41:15 +0100 > matthias@kernel.org wrote: > > > From: Matthias Brugger > > > > > > For now bootp and uuid code use a weak seed for generating random > > data. U-Boot as support for RNG devices now, so we should chan

Re: [PATCH 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load()

2020-12-16 Thread Alex G.
On 12/16/20 1:13 AM, Peng Fan wrote: Subject: [PATCH 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load() The size is derived from the FIT image itself. Any alignment requirements are machine-specific and known by the board code. Thus the total length can be derived from the FIT im

U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Dave Jones
Hi, We've recently run across some failures with U-Boot on a couple of platforms, specifically the relatively new Pi Compute Module 4, and the Pi 4 8GB of RAM. On the CM4, U-Boot failed to identify the eMMC storage, and on the Pi 4 8GB, a crash and reset occurred when U-Boot tried to read fro

Re: [PATCH v5 1/2] dm: core: add function uclass_probe_all() to probe all devices

2020-12-16 Thread Sean Anderson
On 12/9/20 12:12 AM, Vabhav Sharma wrote: From: Vabhav Sharma Support a common method to probe all devices associated with uclass. This includes data structures and code for finding the first device and looping for remaining devices associated with uclasses (groups of devices with the same pur

Re: [PATCH v5 2/2] drivers: serial: probe all uart devices

2020-12-16 Thread Sean Anderson
On 12/9/20 12:12 AM, Vabhav Sharma wrote: From: Vabhav Sharma U-Boot DM model probe only single device at a time which is enabled and configured using device tree or platform data method. PL011 UART IP is SBSA compliant and firmware does the serial port set-up, initialization and let the kerne

[PATCH 01/18] Makefile: Build a separate .dtb for TPL

2020-12-16 Thread Simon Glass
At present both SPL and TPL use the same devicetree binary. While there is logic to run fdtgrep separately on each one, it does not actually happen. Add a new TPL rule and use that instead. Make this rule conditional on there actually being a TPL. Do the same for SPL for consistency. Note that th

[PATCH 02/18] Makefile: Build SPL dtbs in the spl/ directory

2020-12-16 Thread Simon Glass
Rather than putting these in the top-level dts/ directory (which is intended for U-Boot proper), put them in the correct subdirectory for SPL (either spl/ or tpl/). This is where other SPL targets are kept, so this is more consistent. Signed-off-by: Simon Glass --- dts/Makefile | 9

[PATCH 04/18] Makefile: Use common args for dtoc

2020-12-16 Thread Simon Glass
At present the dtoc commmand line is repeated twice in the Makefile. Use a variable to avoid this, so it is easier to add more conditional arguments. Signed-off-by: Simon Glass --- scripts/Makefile.spl | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.s

[PATCH 03/18] Makefile: Tidy up SPL dtb production

2020-12-16 Thread Simon Glass
Use the SPL_NAME variable to simplify the rules. Drop the SPL targets clean-files since the SPL and TPL dts/ directories are removed by existing rules. Move the SPL rules into a new spl_dtbs to avoid the complicated $(if) construct. Also drop unused pieces from the 'targets' variable. With this,

[PATCH 05/18] buildman: Report sizes for TPL also

2020-12-16 Thread Simon Glass
At present only U-Boot proper and SPL are scanned to obtain size information. Add TPL also, to complete the picture. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildman/builderthread.py b/tools/buildma

[PATCH 08/18] sandbox: Drop unnecessary test node

2020-12-16 Thread Simon Glass
The spl-test4 node deliberately has an invalid compatible string. This causes a warning from dtoc and the check it does is not really necessary. Drop it, to avoid the warning and associated confusion. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dtsi| 5 - test/py/tests/test

[PATCH 06/18] serial: Update NS16550_t and struct NS16550

2020-12-16 Thread Simon Glass
Typedefs should not be used in U-Boot and structs should be lower case. Update the code to use struct ns16550 consistently. Put a header guard on the file while we are here. Signed-off-by: Simon Glass --- arch/arm/mach-davinci/da850_lowlevel.c | 4 +- arch/arm/mach-davinci/spl.c

[PATCH 07/18] serial: Rename ns16550 functions to lower case

2020-12-16 Thread Simon Glass
Lower case should be used for function names. Update this driver and its callers accordingly. Signed-off-by: Simon Glass --- arch/arm/mach-davinci/da850_lowlevel.c | 2 +- arch/arm/mach-davinci/spl.c| 4 ++-- arch/arm/mach-keystone/init.c | 2 +- board/Arctur

[PATCH 09/18] spl: Drop bd_info in the data section

2020-12-16 Thread Simon Glass
This uses up space in the SPL binary but it always starts as zero. Also some boards cannot support data in TPL (e.g. Intel Apollo Lake). Use malloc() to allocate this structure instead, by moving the init a little later, after malloc() is inited. Make this function optional since it pulls in mallo

[PATCH 10/18] dm: core: Support dm_dump_all() in SPL

2020-12-16 Thread Simon Glass
At present the output from this function is hard to read in SPL, due to (intended) limitations in SPL's printf() function. Add an SPL version so it is clearer. Signed-off-by: Simon Glass --- drivers/core/dump.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/co

[PATCH 11/18] dm: core: Use 'uclass_driver' for the uclass linker_list

2020-12-16 Thread Simon Glass
At present the name 'uclass_driver' is used for the uclass linker list. This does not follow the convention of using the struct name. Fix it. Signed-off-by: Simon Glass --- drivers/core/lists.c | 4 ++-- drivers/core/root.c | 4 ++-- include/dm/uclass.h | 2 +- 3 files changed, 5 insertions(+

[PATCH 13/18] x86: apl: Drop support for !OF_PLATDATA_PARENT

2020-12-16 Thread Simon Glass
This code was kept around after of-platdata started supporting parent devices. That feature seems stable now, so let's drop it. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/Kconfig | 1 + arch/x86/cpu/apollolake/spl.c | 28 drivers/misc/p2sb-uclass.c

[PATCH 14/18] dm: core: Add function to access uclass priv

2020-12-16 Thread Simon Glass
Add functions so this information is not accessed directly. This will be needed for of-platdata which stores it in a different place. Signed-off-by: Simon Glass --- drivers/core/uclass.c| 10 ++ include/dm/uclass-internal.h | 14 ++ include/dm/uclass.h | 8

[PATCH 15/18] dm: core: Add functions to set priv/plat

2020-12-16 Thread Simon Glass
This should not normally be needed in drivers, but add accessors for the few cases that exist. Signed-off-by: Simon Glass --- drivers/core/device.c| 30 + include/dm/device-internal.h | 84 2 files changed, 114 insertions(+) diff --git a

[PATCH 12/18] dm: core: Only include simple-bus devicetree id when needed

2020-12-16 Thread Simon Glass
This is not needed when of-platdata is in use. Update it. Signed-off-by: Simon Glass --- drivers/core/simple-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/simple-bus.c b/drivers/core/simple-bus.c index c45212a0d3a..7dbcbecd948 100644 --- a/drivers/cor

[PATCH 17/18] dm: core: Use access methods for dev/uclass private data

2020-12-16 Thread Simon Glass
Use these functions in the core code as much as possible. With this, there are only two places where each priv/plat pointer is accessed, one for read and one for write. Signed-off-by: Simon Glass --- drivers/core/device-remove.c | 8 ++--- drivers/core/device.c| 61 +++-

[PATCH 18/18] dm: core: Rename the priv/plat members

2020-12-16 Thread Simon Glass
These are supposed to be private to driver model, not accessed by any code outside. Add a trailing underscore to indicate this. Signed-off-by: Simon Glass --- drivers/core/device.c | 24 drivers/core/uclass.c | 4 ++-- include/dm/device.h | 29 +--

[PATCH 00/18] dm: Preparation for enhanced of-platdata

2020-12-16 Thread Simon Glass
This series includes various patches in service of some upcoming of-platdata enhancements. The new features will support declaring devices and uclasses at build time (automatically, using dtoc) so as to further reduce the code-size overhead of driver model. The main changes in this series are: - S

[PATCH 16/18] dm: Use access methods for dev/uclass private data

2020-12-16 Thread Simon Glass
Most drivers use these access methods but a few do not. Update them. In some cases the access is not permitted, so mark those with a FIXME tag for the maintainer to check. Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/ls102xa/fdt.c | 4 ++ arch/arm/mach-stm32mp/pwr_regulator.c

Re: [PATCH 06/18] serial: Update NS16550_t and struct NS16550

2020-12-16 Thread Andy Shevchenko
On Wed, Dec 16, 2020 at 08:24:54AM -0700, Simon Glass wrote: > Typedefs should not be used in U-Boot and structs should be lower case. > Update the code to use struct ns16550 consistently. > > Put a header guard on the file while we are here. Reviewed-by: Andy Shevchenko > Signed-off-by: Simon

Re: [PATCH 07/18] serial: Rename ns16550 functions to lower case

2020-12-16 Thread Andy Shevchenko
On Wed, Dec 16, 2020 at 08:24:55AM -0700, Simon Glass wrote: > Lower case should be used for function names. Update this driver and its > callers accordingly. Reviewed-by: Andy Shevchenko > Signed-off-by: Simon Glass > --- > > arch/arm/mach-davinci/da850_lowlevel.c | 2 +- > arch/arm/mac

[PATCH 1/2] arm: dts: rockchip: rk3399: enable rng at the SoC level

2020-12-16 Thread Peter Robinson
The rng is embedded in the SoC so enable it in the device tree universally, the use of it can be controlled by enabling/disabling at the device config level. Signed-off-by: Peter Robinson Cc: Kever Yang --- arch/arm/dts/rk3399-evb-u-boot.dtsi | 4 arch/arm/dts/rk3399-pinebook-pro-

[PATCH 2/2] configs: rk3399: enable rng on firefly/rock960/rockpro64

2020-12-16 Thread Peter Robinson
Enable the RNG on the Firefly, rock960 and RockPro64 devices to enable KASLR on devices that support it. Signed-off-by: Peter Robinson Cc: Akash Gajjar Cc: Jagan Teki Cc: Kever Yang Cc: Manivannan Sadhasivam --- configs/firefly-rk3399_defconfig | 2 ++ configs/rock960-rk3399_defconfig |

Re: [PATCH 2/2] net: Use NDRNG device in srand_mac()

2020-12-16 Thread Matthias Brugger
On 16/12/2020 14:20, Torsten Duwe wrote: > On Wed, 16 Dec 2020 11:41:17 +0100 > matthias@kernel.org wrote: > >> From: Matthias Brugger >> >> When calling srand_mac we use a weak seed dependent on the >> mac address. If present, use a RNG device instead to incerase entropy. >> >> Signed-off

Re: Please pull u-boot-x86

2020-12-16 Thread Tom Rini
On Wed, Dec 16, 2020 at 05:34:07PM +0800, Bin Meng wrote: > Hi Tom, > > This PR includes the following x86 changes for v2021.01 release: > > - Update cmdline parameter to be an env var in zimage boot > - Various minor fixes for Intel Edison board > > Azure pipelines results: PASS > https://dev.

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Matthias Brugger
Hi Dave, On 16/12/2020 15:23, Dave Jones wrote: > Hi, > > We've recently run across some failures with U-Boot on a couple of platforms, > specifically the relatively new Pi Compute Module 4, and the Pi 4 8GB of RAM. > On > the CM4, U-Boot failed to identify the eMMC storage, and on the Pi 4 8GB,

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Peter Robinson
On Wed, Dec 16, 2020 at 4:15 PM Matthias Brugger wrote: > > Hi Dave, > > On 16/12/2020 15:23, Dave Jones wrote: > > Hi, > > > > We've recently run across some failures with U-Boot on a couple of > > platforms, > > specifically the relatively new Pi Compute Module 4, and the Pi 4 8GB of > > RAM.

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Matthias Brugger
On 16/12/2020 17:20, Peter Robinson wrote: > On Wed, Dec 16, 2020 at 4:15 PM Matthias Brugger > wrote: >> >> Hi Dave, >> >> On 16/12/2020 15:23, Dave Jones wrote: >>> Hi, >>> >>> We've recently run across some failures with U-Boot on a couple of >>> platforms, >>> specifically the relatively

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Peter Robinson
On Wed, Dec 16, 2020 at 4:21 PM Matthias Brugger wrote: > > > > On 16/12/2020 17:20, Peter Robinson wrote: > > On Wed, Dec 16, 2020 at 4:15 PM Matthias Brugger > > wrote: > >> > >> Hi Dave, > >> > >> On 16/12/2020 15:23, Dave Jones wrote: > >>> Hi, > >>> > >>> We've recently run across some fail

[PATCH v2 0/2] Use RNG to get random behaviour

2020-12-16 Thread matthias . bgg
From: Matthias Brugger For now bootp and uuid code use a weak seed for generating random data. U-Boot as support for RNG devices now, so we should change to code to use them if they are present. This will help mitigate issues like seen in CVE-2019-11690. Changes in v2: - fix dm_rng_read() param

[PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-16 Thread matthias . bgg
From: Matthias Brugger When calculating a random UUID we use a weak seed. Use a RNG device if present to increase entropy. Signed-off-by: Matthias Brugger --- Changes in v2: - fix dm_rng_read() parameters - add missing include lib/uuid.c | 21 ++--- 1 file changed, 18 insert

[PATCH v2 2/2] net: Use NDRNG device in srand_mac()

2020-12-16 Thread matthias . bgg
From: Matthias Brugger When calling srand_mac we use a weak seed dependent on the mac address. If present, use a RNG device instead to incerase entropy. Signed-off-by: Matthias Brugger --- Changes in v2: - fix dm_rng_read() parameters - add missing include file net/net_rand.h | 19 +

Re: [PATCH 0/3] board: amlogic: add WeTek Core2 support

2020-12-16 Thread Neil Armstrong
On 15/12/2020 13:32, Christian Hewitt wrote: > This patchset adds support for the WeTek Core2 box which is based on the > Amlogic S912 (GXM) SoC. Patches are based on u-boot-amlogic-next branch > in the custodians tree. > > Christian Hewitt (3): > ARM: dts: import WeTek Core2 DTs from Linux 5.10

Re: [PATCH v3 0/6] VIM3: add support for checking 'Function' button state

2020-12-16 Thread Neil Armstrong
On 16/12/2020 08:51, Marek Szyprowski wrote: > Hi All, > > This patchset adds all building blocks needed for checking the 'Function' > button state in the boot script on Amlogic A311D based VIM3 board. This > button is connected to the ADC lines of the SoC, so it required to enable > meson SARADC,

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Peter Robinson
On Wed, Dec 16, 2020 at 4:27 PM Peter Robinson wrote: > > On Wed, Dec 16, 2020 at 4:21 PM Matthias Brugger > wrote: > > > > > > > > On 16/12/2020 17:20, Peter Robinson wrote: > > > On Wed, Dec 16, 2020 at 4:15 PM Matthias Brugger > > > wrote: > > >> > > >> Hi Dave, > > >> > > >> On 16/12/2020

Re: [PATCH 8/8] spl: fit: Load devicetree when a Linux payload is found

2020-12-16 Thread Alex G.
On 12/15/20 6:09 PM, Alexandru Gagniuc wrote: When a FIT config specifies a devicetree, we should load it, no questions asked. In the case of the "simple" FIT loading path, a difficulty arises in selecting the load address of the FDT. The default FDT location is right after the "kernel" or "f

[PATCH v1 4/4] IOMUX: Stop dropped consoles

2020-12-16 Thread Andy Shevchenko
When at some point environment shrinks we need to stop dropped devices. Signed-off-by: Andy Shevchenko --- common/iomux.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/common/iomux.c b/common/iomux.c index 8a063563aa27..b6936317b12e 100644 --- a/c

[PATCH v1 2/4] IOMUX: Drop indentation level by removing redundant 'else'

2020-12-16 Thread Andy Shevchenko
Obviously the following has unnecessary indentation level in 'else' branch. if (foo) { ... return; } else { ... } Drop indentation level by removing redundant 'else'. Signed-off-by: Andy Shevchenko --- common/iomux.c | 10

[PATCH v1 1/4] IOMUX: Preserve console list if realloc() fails

2020-12-16 Thread Andy Shevchenko
It's realloc() 101 to avoid `foo = realloc(foo, ...);` call due to getting a memory leak. Actually it's not clear why realloc() has been used here. If we shrink the array, the memcpy() overwrites it anyway with the contents of a new array. If it becomes bigger, same story. Drop useless realloc()

[PATCH v1 3/4] IOMUX: Refactor iomux_doenv() in order to increase readability

2020-12-16 Thread Andy Shevchenko
Refactor iomux_doenv() a bit in order to increase readability. There is no change in code generation on x86. Signed-off-by: Andy Shevchenko --- common/iomux.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/common/iomux.c b/common/iomux.c index 9fae124442c1..8a0

Re: [PATCH v1 1/4] IOMUX: Preserve console list if realloc() fails

2020-12-16 Thread Andy Shevchenko
On Wed, Dec 16, 2020 at 8:05 PM Andy Shevchenko wrote: > > It's realloc() 101 to avoid `foo = realloc(foo, ...);` call > due to getting a memory leak. > > Actually it's not clear why realloc() has been used here. > If we shrink the array, the memcpy() overwrites it anyway > with the contents of a

Re: U-Boot failures on CM4 and Pi4-8Gb

2020-12-16 Thread Dave Jones
Hi Matthias, On Wed, Dec 16, 2020 at 05:21:50PM +0100, Matthias Brugger wrote: On 16/12/2020 17:20, Peter Robinson wrote: On Wed, Dec 16, 2020 at 4:15 PM Matthias Brugger wrote: [snip] Thanks for looking into this. I'm aware of problems booting CM4 and RPi 400 with PCI. I wasn't aware tha

[PATCH 1/1] doc: man-page for bootefi command

2020-12-16 Thread Heinrich Schuchardt
Provide a description of the bootefi command. Signed-off-by: Heinrich Schuchardt --- MAINTAINERS | 1 + doc/usage/bootefi.rst | 135 ++ doc/usage/index.rst | 1 + 3 files changed, 137 insertions(+) create mode 100644 doc/usage/bootefi.rst

[PULL] u-boot-usb/master

2020-12-16 Thread Marek Vasut
The following changes since commit 56f02f0ae85da8bb2dca66c7816dbb1429f92072: Merge tag 'u-boot-amlogic-20201215' of https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic (2020-12-15 09:08:14 -0500) are available in the Git repository at: git://git.denx.de/u-boot-usb.git master for you

[PATCH v2 2/7] console: Keep ->start() and ->stop() balanced

2020-12-16 Thread Andy Shevchenko
There is no need to call ->start() for already started device. All the same, there is no need to call ->stop() for devices still in use. For now enforce this only for CONSOLE_MUX case. Signed-off-by: Andy Shevchenko --- v2: new patch common/console.c | 21 + 1 file changed,

[PATCH v2 1/7] console: Introduce console_start() and console_stop()

2020-12-16 Thread Andy Shevchenko
In the future we would like to stop unused consoles and also add a reference counting to avoid imbalanced calls to ->start() and ->stop() in some cases. Signed-off-by: Andy Shevchenko --- v2: new patch common/console.c | 30 +++--- include/console.h | 3 +++ 2 files cha

[PATCH v2 3/7] IOMUX: move search_device() to console.h

2020-12-16 Thread Andy Shevchenko
search_device() is defined in console.c. Move its declaration to an appropriate header file. Signed-off-by: Andy Shevchenko --- v2: new patch include/console.h | 2 ++ include/iomux.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/console.h b/include/console.h ind

[PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else'

2020-12-16 Thread Andy Shevchenko
Obviously the following has unnecessary indentation level in 'else' branch. if (foo) { ... return; } else { ... } Drop indentation level by removing redundant 'else'. Signed-off-by: Andy Shevchenko --- v2: no changes commo

[PATCH v2 7/7] IOMUX: Stop dropped consoles

2020-12-16 Thread Andy Shevchenko
When at some point environment shrinks we need to stop dropped devices. Signed-off-by: Andy Shevchenko --- v2: rebased to use console_stop() common/iomux.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/common/iomux.c b/common/iomux.c index 8a063563aa27.

[PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails

2020-12-16 Thread Andy Shevchenko
It's realloc() 101 to avoid `foo = realloc(foo, ...);` call due to getting a memory leak. Actually it's not clear why realloc() has been used here. If we shrink the array, the memcpy() overwrites it anyway with the contents of a new array. If it becomes bigger, same story. Drop useless realloc()

[PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability

2020-12-16 Thread Andy Shevchenko
Refactor iomux_doenv() a bit in order to increase readability. There is no change in code generation on x86. Signed-off-by: Andy Shevchenko --- v2: no changes common/iomux.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/common/iomux.c b/common/iomux.c index ce

Re: [PATCH v1 1/4] IOMUX: Preserve console list if realloc() fails

2020-12-16 Thread Andy Shevchenko
On Wed, Dec 16, 2020 at 09:40:30PM +0200, Andy Shevchenko wrote: > On Wed, Dec 16, 2020 at 8:05 PM Andy Shevchenko > wrote: ... > It seems more patches will come. However, this one, since it is a fix, > can be applied disregarding that fact. Therefore please skip the rest > of the series for now

[PATCH v3] net: xilinx: axi_emac: Add support for 10G Base-R IP

2020-12-16 Thread Alessandro Temil
From: Alessandro Temil net: xilinx: axi_emac: Add support for 10G Base-R IP Developed with: Vivado version: 2020.1 IP version: 3.2 Signed-off-by: Alessandro Temil --- drivers/net/xilinx_axi_emac.c | 137 -- 1 file changed, 115 insertions(+), 22 deletions(-) dif

[PATCH] buildman: Remove output binaries before building

2020-12-16 Thread Simon Glass
Buildman reuses build directories from previous builds to avoid the cost of 'make mrproper' for every build. If the previous build produced an SPL image but the current one does not, the SPL image will remain and buildman will think it is a result of building the current board. Remove these files

[PATCH] dm: core: Inline a few ofnode functions in SPL

2020-12-16 Thread Simon Glass
A recent change to unify the flattree/livetree code introduced a small size increase in SPL on some boards. For example SPL code size for px30-core-ctouch2-px30 increased by 40 bytes. To address this we can take advantage of the fact that some of the ofnode functions are only called a few times in

Re: [PATCH 16/18] dm: Use access methods for dev/uclass private data

2020-12-16 Thread Andy Shevchenko
On Wed, Dec 16, 2020 at 08:25:04AM -0700, Simon Glass wrote: > Most drivers use these access methods but a few do not. Update them. > > In some cases the access is not permitted, so mark those with a FIXME tag > for the maintainer to check. Acked-by: Andy Shevchenko > Signed-off-by: Simon Glass

Fujitsu does not respond to GPL request

2020-12-16 Thread Hal Martin
Hello, I hope I am not breaking an community rules by posing this question to the mailing list, according to the DENX website, this is the correct place to ask my question. [1] I have a Fujitsu TX140 S2 server with iRMC S4. Fujitsu includes a written offer to provide the GPL source code through t

Re: Please pull u-boot-dm/next into -next

2020-12-16 Thread Simon Glass
Hi Tom, On Tue, 15 Dec 2020 at 09:28, Simon Glass wrote: > > Hi Tom, > > On Tue, 15 Dec 2020 at 07:06, Tom Rini wrote: > > > > On Mon, Dec 14, 2020 at 08:50:53AM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/5567 > > > > >

[PATCH v1 1/2] imx8mq: configs: add support for distro boot commands

2020-12-16 Thread Alice Guo (OSS)
From: Alice Guo Supported boot device types in iMX8MQ: MMC, DHCP. CONFIG_CMD_PART is added for command part and CONFIG_CMD_FS_GENERIC is for command fstype. scriptaddr is the location in RAM where boot.scr.uimg/boot.scr will be loaded to prior to execution. kernel_addr_r is the location in RAM

[PATCH v1 2/2] board: imx8mq: add boot.cmd for distro boot on iMX8MQ

2020-12-16 Thread Alice Guo (OSS)
From: Alice Guo Distro Boot requires a U-Boot-specific script named boot.scr or boot.scr.uimg which contains boot commands to boot the system. The boot.cmd is such a file. Use mkimage to generate boot.scr or boot.scr.uimg from boot.cmd, and the command is: mkimage -A arm -O linux -T script -C non

[PATCH] video: Drop unprintable characters from video_font_data.h

2020-12-16 Thread Simon Glass
This file contains characters which are not valid in utf-8. This confuses dtoc which wants to parse it. They don't really serve any purpose anyway, so drop them. To: U-Boot Mailing List Cc: Tom Rini Signed-off-by: Simon Glass --- include/video_font_data.h | 258 +++

[PATCH v3 00/28] dm: Change the way sequence numbers are implemented

2020-12-16 Thread Simon Glass
At present each device has two sequence numbers, with 'req_seq' being set up at bind time and 'seq' at probe time. The idea is that devices can 'request' a sequence number and then the conflicts are resolved when the device is probed. This makes things complicated in a few cases, since we don't re

[PATCH v3 01/28] linker_lists: Fix alignment issue

2020-12-16 Thread Simon Glass
The linker script uses alphabetic sorting to group the different linker lists together. Each group has its own struct and potentially its own alignment. But when the linker packs the structs together it cannot ensure that a linker list starts on the expected alignment boundary. For example, if the

[PATCH v3 05/28] dm: test: Check all devices have a sequence numbers

2020-12-16 Thread Simon Glass
Add a test that the new sequence numbers work as expected. Every device should get one. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop the GD_FLG_DM_NO_SEQ flag test/dm/core.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/dm/core.c b

[PATCH v3 04/28] dm: core: Add a new sequence number for devices

2020-12-16 Thread Simon Glass
At present each device has two sequence numbers, with 'req_seq' being set up at bind time and 'seq' at probe time. The idea is that devices can 'request' a sequence number and then the conflicts are resolved when the device is probed. This makes things complicated in a few cases, since we don't re

[PATCH v3 03/28] dm: core: Update uclass_find_next_free_req_seq() args

2020-12-16 Thread Simon Glass
At present this is passed a uclass ID and it has to do a lookup. The callers all have the uclass pointer, except for the I2C uclass where the code will soon be deleted. Update the argument to a uclass * instead of an ID since it is more efficient. Signed-off-by: Simon Glass --- (no changes sinc

[PATCH v3 06/28] dm: core: Switch binding to use new sequence numbers

2020-12-16 Thread Simon Glass
Update the core logic to use the new approach. For now the old code is left as is. Update one test so it still passes. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c | 5 + test/dm/bus.c | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --g

[PATCH v3 08/28] dm: test: Drop assumptions of no sequence numbers

2020-12-16 Thread Simon Glass
Drop code in a few tests which assumes that sequence numbers are only valid when a device is probed. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/blk.c | 3 --- test/dm/i2c.c | 3 --- test/dm/spi.c | 3 --- 3 files changed, 9 deletions(-) diff --git a/test/dm/blk.c b/test/dm/b

[PATCH v3 07/28] dm: Fix return value in dev_read_alias_seq()

2020-12-16 Thread Simon Glass
This should return 0 on success but currently does not. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/read.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/read.c b/drivers/core/read.c index 076125824ca..fc74d64814f 100644 --- a/

[PATCH v3 09/28] octeon: Don't attempt to set the sequence number

2020-12-16 Thread Simon Glass
Several Octeon drivers operate by setting the sequence number of their device. This should not be needed with the new sequence number setup. Also it is not permitted. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/i2c/octeon_i2c.c | 1 - drivers/mmc/octeontx_hsmmc.c

[PATCH v3 14/28] spi: Update for new sequence numbers

2020-12-16 Thread Simon Glass
Use the new sequence number in all cases. Drop the rockchip case because the sequence number should be 0 anyway, and assigning to the sequence number is not permitted. Signed-off-by: Simon Glass --- (no changes since v1) drivers/spi/fsl_dspi.c | 2 +- drivers/spi/rk_spi.c | 1 - 2 files chan

[PATCH v3 10/28] i2c: Update for new sequence numbers

2020-12-16 Thread Simon Glass
Use the new sequence number in all cases. Drop the logic to check for a valid number in designware_i2c, since it will always be valid. Also drop the numbering in the uclass, since we can rely on driver model giving us the right sequence numbers. Signed-off-by: Simon Glass --- (no changes since

[PATCH v3 12/28] dm: core: Allow manual sequence numbering

2020-12-16 Thread Simon Glass
Some buses have their own rules which require assigning sequence numbers with a bus-specific algorithm. For example, PCI requires that sub-buses are numbered higher than their parent buses, meaning effectively that parent buses must be numbered only after all of their child buses have been numbered

[PATCH v3 11/28] net: Update to use new sequence numbers

2020-12-16 Thread Simon Glass
Checking for seq == -1 is effectively checking that the device is activated. The new sequence numbers are never -1 for a bound device, so update the check. Also drop the note about valid sequence numbers so it is accurate with the new approach. Signed-off-by: Simon Glass --- (no changes since v

  1   2   >