Re: [PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

2021-02-13 Thread Roger Pau Monné
On Sat, Feb 13, 2021 at 11:45:50PM +0100, Heiko Stuebner wrote: > Hi Roger, > > Am Samstag, 13. Februar 2021, 16:59:01 CET schrieb Roger Pau Monne: > > From: Roger Pau Monné > > > > Using a non-default SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR setting makes the > > resulting u-boot-rockchip.bin

Re: [PATCH 01/26] Revert "pci: pci-uclass: Dynamically allocate the PCI regions"

2021-02-13 Thread Bin Meng
Hi Tom, On Wed, Feb 10, 2021 at 10:13 PM Tom Rini wrote: > > On Wed, Feb 10, 2021 at 08:46:51AM +0800, Bin Meng wrote: > > Hi Simon, > > > > On Sun, Feb 7, 2021 at 11:34 PM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Sun, 7 Feb 2021 at 08:11, Bin Meng wrote: > > > > > > > > This

[PATCH v4 1/1] timer: imx-gpt: Add timer support for i.MX SoCs family

2021-02-13 Thread Jesse
From: Jesse Taube This timer driver is using GPT Timer (General Purpose Timer) available on almost all i.MX SoCs family. Since this driver is only meant to provide u-boot's timer and counter, and most of the i.MX* SoCs use a 24Mhz crystal, let's only deal with that specific source.

[PATCH v4 0/1] timer: imx-gpt: Add timer support for i.MX SoCs family

2021-02-13 Thread Jesse
From: Jesse Taube This timer driver is using GPT Timer (General Purpose Timer) available on almost all i.MX SoCs family. Since this driver is only meant to provide u-boot's timer and counter, and most of the i.MX* SoCs use a 24Mhz crystal, let's only deal with that specific source. Jesse Taube

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Jesse T
Awesome, thanks! I must have forgotten how twos complement works for a sec... On Sat, Feb 13, 2021 at 10:17 PM Giulio Benetti < giulio.bene...@benettiengineering.com> wrote: > Hi Jesse, > > Il giorno 14 feb 2021, alle ore 03:58, Jesse T > ha scritto: > >  > This looks good to me, and helps

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
Hi Jesse, > Il giorno 14 feb 2021, alle ore 03:58, Jesse T ha > scritto: > >  > This looks good to me, and helps beginners like me. As for the function > itself, i have 2 concerns: If it does return a negative value why is it > unsigned, if it is in fact signed that a clock above 2.2Ghz is

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Jesse T
This looks good to me, and helps beginners like me. As for the function itself, i have 2 concerns: If it does return a negative value why is it unsigned, if it is in fact signed that a clock above 2.2Ghz is a negative number. As for the IS_ERR_VALUE macro there still is a chance that it will error

Re: [PATCH v2 1/1] timer: imx-gpt: Add timer support for i.MX SoCs family

2021-02-13 Thread Giulio Benetti
Hi Jesse, On 2/13/21 4:10 AM, Jesse T wrote: sry for top posting I'm on my phone just b4 bed. any way the comment in the header file says it returns an int. No, it says ulong I don't remember what it actually returns but it should have more clarity. I've sent a new patch to clarify it

[PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
Improve clk_get_rate() @return documentation that otherwise is a bit ambiguous. At the moment I expect to return 0 as error since the return type is 'ulong', instead the function really returns negative value in case the corresponding function pointer is null and returns 0 if the clock is invalid.

Re: [PATCH] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
On 2/13/21 7:24 PM, Simon Glass wrote: Hi Giulio, On Sat, 13 Feb 2021 at 01:47, Giulio Benetti wrote: Hi Simon, Sean, Il giorno 13 feb 2021, alle ore 05:17, Simon Glass ha scritto: On Fri, 12 Feb 2021 at 18:17, Giulio Benetti wrote: On 2/13/21 12:25 AM, Sean Anderson wrote: On

Re: [PATCH 08/16] arm: Remove mx53loco board

2021-02-13 Thread Fabio Estevam
Hi Tom, On Sat, Feb 13, 2021 at 11:14 AM Fabio Estevam wrote: > I have patches converting this board to DM, but need to test on the > real hardware. > > I will test them next week and if they work fine, I will submit the patches. I managed to get access to an imx53-qsb and the conversion to DM

[PATCH 4/4] mx53loco: Add myself as maintainer

2021-02-13 Thread Fabio Estevam
I would like to help supporting this board, so add myself as a maintainer. Signed-off-by: Fabio Estevam --- board/freescale/mx53loco/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/mx53loco/MAINTAINERS b/board/freescale/mx53loco/MAINTAINERS index

[PATCH 3/4] ARM: dts: imx53-qsb: Describe the esdhc1 card detect pin

2021-02-13 Thread Fabio Estevam
The micro SD card slot uses GPIO3_13 as card detect pin, so describe it in the devicetree. This was noticed when converting imx53-qsb board to driver model in U-Boot as the micro SD card was not getting detected. After this change it is possible to load the dtb and zImage from the SD card and

[PATCH 2/4] mx53loco: Convert to driver model

2021-02-13 Thread Fabio Estevam
Make the conversion to driver model as it is mandatory. Remove the SATA support for now as the i.MX53 support has not been added yet. Signed-off-by: Fabio Estevam --- I will add the DM SATA support later. arch/arm/dts/Makefile | 1 + board/freescale/mx53loco/mx53loco.c | 124

[PATCH 1/4] imx53-qsb: Import devicetree files from Linux

2021-02-13 Thread Fabio Estevam
Import the imx53-qsb devicetree files from Linux kernel version 5.11-rc7. This is in preparation for converting the mx53loco_defconfig target to driver model. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx53-qsb-common.dtsi | 385 + arch/arm/dts/imx53-qsb.dts

Re: [PATCH] sunxi: support boot console on uart1 for sun8i

2021-02-13 Thread Andre Przywara
On Sat, 13 Feb 2021 19:45:45 +0100 Tobias Schramm wrote: Hi, > > Which particular SoC or board is this triggered by? > > > > I'm currently using a board with a Sochip S3 SoC, where the boot console > is on uart1. > > > From the SoCs listed as belonging to the MACH_SUN8I "family", I

Re: [PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

2021-02-13 Thread Heiko Stuebner
Hi Roger, Am Samstag, 13. Februar 2021, 16:59:01 CET schrieb Roger Pau Monne: > From: Roger Pau Monné > > Using a non-default SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR setting makes the > resulting u-boot-rockchip.bin unbootable, as it gets stuck after SPL. > Removing the setting from the defconfig

Re: [PATCH] sunxi: support boot console on uart1 for sun8i

2021-02-13 Thread Tobias Schramm
Hi Andre, > Which particular SoC or board is this triggered by? > I'm currently using a board with a Sochip S3 SoC, where the boot console is on uart1. > From the SoCs listed as belonging to the MACH_SUN8I "family", I don't > see the R40 and V3s having UART1 muxed on PortG, only A23, A33,

Re: [PATCH] clk: fix clk_get_rate() documentation

2021-02-13 Thread Simon Glass
Hi Giulio, On Sat, 13 Feb 2021 at 01:47, Giulio Benetti wrote: > > Hi Simon, Sean, > > > Il giorno 13 feb 2021, alle ore 05:17, Simon Glass ha > > scritto: > > > > On Fri, 12 Feb 2021 at 18:17, Giulio Benetti > > wrote: > >> > >>> On 2/13/21 12:25 AM, Sean Anderson wrote: > >>> On 2/10/21

Re: [PATCH] sunxi: support boot console on uart1 for sun8i

2021-02-13 Thread Andre Przywara
On Fri, 12 Feb 2021 15:08:23 +0100 Tobias Schramm wrote: Hi Tobias, > From: Tobias Schramm > > This commit adds support for using uart1 as boot console on sun8i. Which particular SoC or board is this triggered by? From the SoCs listed as belonging to the MACH_SUN8I "family", I don't see the

Re: [PATCH 2/2] build/DTC: fix sed usage in DTC command

2021-02-13 Thread Warner Losh
On Sat, Feb 13, 2021 at 3:06 AM Roger Pau Monne wrote: > Current sed usage in the DTC command relies on GNU sed specific -i > option which has a slightly different syntax for BSD sed and always > expects an extension to be provided in order to create a backup file. > > Instead drop the cat

Re: [PATCH 1/2] scripts/check-config.sh: fix to be compatible with BSD sed

2021-02-13 Thread Warner Losh
On Sat, Feb 13, 2021 at 3:06 AM Roger Pau Monne wrote: > Fist use extended regexp in order to drop the '\' around the > parentheses which is not supported by BSD sed in regular mode. > > Secondly use [[:blank:]] instead of \s, as the later is a GNU > extension. > > No functional change intended.

Re: [PATCH 08/16] arm: Remove mx53loco board

2021-02-13 Thread Tom Rini
On Sat, Feb 13, 2021 at 11:14:53AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Tue, Feb 9, 2021 at 11:44 PM Tom Rini wrote: > > > > This board relies on using CONFIG_LIBATA but does not enable CONFIG_AHCI. > > The > > deadline for this conversion was the v2019.07 release. The use of > >

[PATCH] odroid-go2: remove setting SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

2021-02-13 Thread Roger Pau Monne
From: Roger Pau Monné Using a non-default SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR setting makes the resulting u-boot-rockchip.bin unbootable, as it gets stuck after SPL. Removing the setting from the defconfig allows U-Boot to load successfully. Signed-off-by: Roger Pau Monné --- Cc: Heiko Stuebner

Re: [PATCH 06/25] arm: Remove mx28evk board

2021-02-13 Thread Fabio Estevam
Hi Tom, On Tue, Feb 9, 2021 at 10:34 AM Tom Rini wrote: > It can stay so long as someone converts it. It's also missing the > CONFIG_DM conversion (v2020.01), CONFIG_DM_USB (v2019.07), > CONFIG_DM_VIDEO (v2019.07) and CONFIG_DM_ETH (v2020.07) conversions. I will work on converting this board

Re: [PATCH 08/16] arm: Remove mx53loco board

2021-02-13 Thread Fabio Estevam
Hi Tom, On Tue, Feb 9, 2021 at 11:44 PM Tom Rini wrote: > > This board relies on using CONFIG_LIBATA but does not enable CONFIG_AHCI. The > deadline for this conversion was the v2019.07 release. The use of CONFIG_AHCI > requires CONFIG_DM. The deadline for this conversion was v2020.01.

[PATCH] arm: dts: sync am33xx-clocks with Linux 5.9-rc7

2021-02-13 Thread Dario Binacchi
The commit 6337d53fdf45 ("arm: dts: sync am33xx with Linux 5.9-rc7") synchronized the am33xx-clocks.dtsi file with Linux 5.9-rc7 with the exception of two nodes. I think I was wrong and it is better to keep the two files similar and possibly make changes to the *-u-boot.dtsi files. Signed-off-by:

[PATCH] clk: ti: improve debug messages for clkctrl driver

2021-02-13 Thread Dario Binacchi
The previous version printed the same debug message for both the enable and disable routines without highlighting whether you were enabling or disabling the module. It is now clear whether you are enabling or disabling the module. Signed-off-by: Dario Binacchi --- drivers/clk/ti/clk-ctrl.c | 4

[PATCH 2/3] am33xx: board: remove GPIO platforma data

2021-02-13 Thread Dario Binacchi
Since the board has been converted to driver model and DT is supported, GPIO platform are no more required and can be removed. Signed-off-by: Dario Binacchi --- arch/arm/mach-omap2/am33xx/board.c | 23 --- 1 file changed, 23 deletions(-) diff --git

[PATCH 3/3] dm: am33xx: drop GPIO domain clock enabling by SOC api

2021-02-13 Thread Dario Binacchi
Enabling the domain clock is performed by the sysc interconnect target module driver during the GPIO device probing. Signed-off-by: Dario Binacchi --- arch/arm/mach-omap2/am33xx/clock_am33xx.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/am33xx/clock_am33xx.c

[PATCH 1/3] arm: dts: sync am33xx gpio nodes with Linux 5.9-rc7

2021-02-13 Thread Dario Binacchi
Move gpio controller nodes from am33xx.dtsi to am33xx-l4.dtsi. Now both files are more similar to those found in Linux 5.9-rc7. To be fully operational as before it was also necessary to fix the am33xx-clock.dtsi file. It too is now almost the same as the Linux kernel. Signed-off-by: Dario

[PATCH 0/3] arm: dts: sync am33xx gpio nodes with Linux 5.9-rc7

2021-02-13 Thread Dario Binacchi
My previous "Add DM support for omap PWM backlight" series synchronized much of the am33xx device tree with Linux 5.9-rc7, except for those nodes that were not affected by that patch set. GPIO nodes were among those left out of sync. The patch series can be cleanly applied to the HEAD of the

Re: [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it

2021-02-13 Thread Pali Rohár
On Monday 08 February 2021 23:34:06 Pali Rohár wrote: > On Monday 08 February 2021 23:21:38 Pali Rohár wrote: > > On Monday 08 February 2021 23:15:33 Lukasz Majewski wrote: > > > Hi Pali, > > > > > > > Resended v2 patch series with fixed commit messages > > > > > > > > This patch series fix

[PATCH 2/2] build/DTC: fix sed usage in DTC command

2021-02-13 Thread Roger Pau Monne
Current sed usage in the DTC command relies on GNU sed specific -i option which has a slightly different syntax for BSD sed and always expects an extension to be provided in order to create a backup file. Instead drop the cat concatenation done before the sed call and use sed itself to edit and

[PATCH 1/2] scripts/check-config.sh: fix to be compatible with BSD sed

2021-02-13 Thread Roger Pau Monne
Fist use extended regexp in order to drop the '\' around the parentheses which is not supported by BSD sed in regular mode. Secondly use [[:blank:]] instead of \s, as the later is a GNU extension. No functional change intended. Signed-off-by: Roger Pau Monné --- Cc: Masahiro Yamada Cc: Simon

[PATCH 0/2] Fixes for BSD sed compatibility

2021-02-13 Thread Roger Pau Monne
Hello, This series contain two fixes that allow me to build U-Boot with FreeBSD sed instead of GNU sed. Shouldn't introduce any functional change. Thanks, Roger. Roger Pau Monné (2): scripts/check-config.sh: fix to be compatible with BSD sed build/DTC: fix sed usage in DTC command

Re: [PATCH] fs: ext4: Add metadata checksums support

2021-02-13 Thread Fredrik Hallenberg
Thanks for trying it out. I have only used it on a custom arm-based board. I have done quite a lot of writing with and without metadata flag and have also tried to trigger errors that require journal recovery. It has worked well but of course it is hard to be sure that the code will handle every

Re: [PATCH] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
Hi Simon, Sean, > Il giorno 13 feb 2021, alle ore 05:17, Simon Glass ha > scritto: > > On Fri, 12 Feb 2021 at 18:17, Giulio Benetti > wrote: >> >>> On 2/13/21 12:25 AM, Sean Anderson wrote: >>> On 2/10/21 12:37 PM, Giulio Benetti wrote: clk_get_rate() can't and doesn't return -ve on