Re: Pull request for efi-2021-07-rc5-2

2021-07-04 Thread Ilias Apalodimas
> [...] > commit 44ffb6f0ecaf ("smbios: Allow properties to come from the device > tree") still used CONFIG symbols. > > commit e4f8e543f1a9 ("smbios: Drop the unused Kconfig options") dropped > the CONFIG symbols Exactly, that was the point I tried to make. I think whatever Da was seing on

Re: [PATCH v2 9/9] board: phytec: imx8mp-phycore: Switch to binman

2021-07-04 Thread Jagan Teki
On Fri, Jul 2, 2021 at 4:49 PM Teresa Remmet wrote: > > Use now binman for image creation. > > Signed-off-by: Teresa Remmet > --- > .../imx8mp-phyboard-pollux-rdk-u-boot.dtsi| 105 ++ > arch/arm/mach-imx/imx8m/Kconfig | 1 + >

Re: [PATCH v2 9/9] board: phytec: imx8mp-phycore: Switch to binman

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > Use now binman for image creation. > > Signed-off-by: Teresa Remmet > --- > .../imx8mp-phyboard-pollux-rdk-u-boot.dtsi| 105 ++ > arch/arm/mach-imx/imx8m/Kconfig | 1 + >

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-04 Thread Steve Bennett
On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: > > Dear Sean, > > In message you wrote: >> >> Well, since Hush was never updated, I don't believe LIL will be either. > > Let's please be exact here: Hus has never been updated _in_U-Boot_, > but it has seen a lot of changes upstream, which

Re: [PATCH v2 3/9] arm: dts: imx8mp-phyboard-pollux: Sync dts files with kernel

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > This update includes eqos support and debug uart changes. > > Synced with kernel commit > 846f752866bd ("arm64: dts: imx8mp-phyboard-pollux-rdk: Change debug UART") > > Signed-off-by: Teresa Remmet > --- >

Re: [PATCH v2 5/9] board: phytec: phycore_imx8mp: Add fec support

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > Enable support for the fec ethernet on phyCORE-i.MX8MP. > > Signed-off-by: Teresa Remmet > --- > board/phytec/phycore_imx8mp/phycore-imx8mp.c | 14 ++ > configs/phycore-imx8mp_defconfig | 7 +++ >

Re: [PATCH v2 4/9] board: phytec: phycore_imx8mp: Change debug UART

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > With the first redesign the debug UART had changed from > UART2 to UART1. > As the first hardware revision is considered as alpha and > will not be supported in future. The old setup will not > be preserved. > > Signed-off-by: Teresa Remmet

Re: [PATCH v2 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > Factor out the common node settings for dm-spl and dm-pre-reloc > and move them to imx8mp-u-boot.dtsi > > Signed-off-by: Teresa Remmet > --- > arch/arm/dts/imx8mp-evk-u-boot.dtsi | 39 + >

Re: [PATCH v2 1/9] arm: dts: imx8mp: Resync imx8mp device tree include

2021-07-04 Thread Heiko Schocher
Hello Teresa, On 02.07.21 13:19, Teresa Remmet wrote: > Sync imx8mp include with kernel commit: > d1689cd3c0f4 ("arm64: dts: imx8mp: Use the correct name for child node "snps, > dwc3"") > > Signed-off-by: Teresa Remmet > --- > arch/arm/dts/imx8mp.dtsi | 146

Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list

2021-07-04 Thread Heiko Schocher
Hello Marek, On 04.07.21 21:31, Marek Vasut wrote: > Linux kernel binding is using atmel,24c01 compatible string. On the > other hand there is atmel,24c01a which is not listed in the kernel. > Add compatible string without "a" suffix to be compatible with Linux > kernel binding. > >

Re: [PATCH v2 0/4] Allwinner H6 USB3 support

2021-07-04 Thread Bin Meng
Hi Andre, On Mon, Jul 5, 2021 at 7:10 AM Andre Przywara wrote: > > On Wed, 21 Apr 2021 12:53:42 +0200 > Marek Vasut wrote: > > Hi, > > > On 4/21/21 12:43 PM, Andre Przywara wrote: > > > On Sat, 17 Apr 2021 09:20:55 -0500 > > > Samuel Holland wrote: > > > > > > Hi, > > > > > >> This series adds

[PATCH] rockchip: rk3399: adjust Nanopi R4S board power layout

2021-07-04 Thread xiaobo
1. Modify the VCC VDD power layout 2. Modify Ethernet1 interface of PCIE0 Reviewed-by: Kever Yang Signed-off-by: xiaobo --- arch/arm/dts/rk3399-nanopi-r4s.dts | 85 ++ 1 file changed, 63 insertions(+), 22 deletions(-) diff --git a/arch/arm/dts/rk3399-nanopi-r4s.dts

Re: [PATCH v2 0/4] Allwinner H6 USB3 support

2021-07-04 Thread Andre Przywara
On Wed, 21 Apr 2021 12:53:42 +0200 Marek Vasut wrote: Hi, > On 4/21/21 12:43 PM, Andre Przywara wrote: > > On Sat, 17 Apr 2021 09:20:55 -0500 > > Samuel Holland wrote: > > > > Hi, > > > >> This series adds PHY and XHCI driver support for the USB3 controller > >> found in the Allwinner H6

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-04 Thread Tom Rini
On Sat, Jul 03, 2021 at 05:38:07PM -0400, Tom Rini wrote: > On Sat, Jul 03, 2021 at 05:27:44PM +0300, Alper Nebi Yasak wrote: > > > > > > On 02/07/2021 23:24, Tom Rini wrote: > > > On Fri, Jul 02, 2021 at 11:03:52PM +0300, Alper Nebi Yasak wrote: > > >> On 02/07/2021 22:01, Tom Rini wrote: > >

Re: [PATCH v3] sandbox: cros-ec: Add tests for the Chromium OS EC PWM driver

2021-07-04 Thread Simon Glass
This patch adds a limited pulse-width modulator to sandbox's Chromium OS Embedded Controller emulation. The emulated PWM device supports multiple channels but can only set a duty cycle for each, as the actual EC doesn't expose any functionality or information other than that. Though the EC

Re: [PATCH] sandbox: Support signal handling only when requested

2021-07-04 Thread Simon Glass
Hi Heinrich, On Sun, 6 Jun 2021 at 15:35, Heinrich Schuchardt wrote: > > Am 6. Juni 2021 20:07:31 MESZ schrieb Sean Anderson : > >On 6/6/21 1:57 PM, Heinrich Schuchardt wrote: > >> On 6/6/21 7:52 PM, Sean Anderson wrote: > >>> On 6/6/21 1:28 PM, Heinrich Schuchardt wrote: > On 6/6/21 6:44

Re: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory

2021-07-04 Thread Simon Glass
Hi Heinrich, On Sat, 15 May 2021 at 09:33, Heinrich Schuchardt wrote: > > On 5/15/21 5:19 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 14 May 2021 at 18:34, Heinrich Schuchardt > > wrote: > >> > >> Am 14. Mai 2021 22:44:32 MESZ schrieb Simon Glass : > >>> Hi Heinrich, > >>> > >>> On

Re: [PATCH] dm: define LOG_CATEGORY for all uclass

2021-07-04 Thread Simon Glass
On Tue, 27 Apr 2021 at 02:02, Patrick Delaunay wrote: > > Define LOG_CATEGORY for all uclass to allow filtering with > log command. > > Signed-off-by: Patrick Delaunay > --- > > drivers/adc/adc-uclass.c| 2 ++ > drivers/ata/ahci-uclass.c | 2 ++ >

Re: [PATCH 1/1] sandbox: fix sandbox_reset()

2021-07-04 Thread Simon Glass
On Wed, 12 May 2021 at 10:39, Heinrich Schuchardt wrote: > > state_uninit() and dm_uninit() are mutually exclusive: > > state_uninit() prints via drivers. So it cannot be executed after > dm_uninit(). > > dm_uninit() requires memory. So it cannot be executed after state_uninit() > which releases

Re: [PATCH v2 1/1] sandbox: don't refer to symbol _init

2021-07-04 Thread Simon Glass
> From: U-Boot On Behalf Of Heinrich Schuchardt > Sent: Wednesday, May 19, 2021 6:03 PM > To: Simon Glass > Cc: Ovidiu Panait ; Bin Meng > ; Stefan Roese ; Masahiro Yamada > ; u-boot@lists.denx.de; Heinrich Schuchardt > > Subject: [PATCH v2 1/1] sandbox: don't refer to symbol _init > > GCC

Re: [PATCH] remove struct uclass_driver::ops

2021-07-04 Thread Simon Glass
On Wed, 19 May 2021 at 10:08, Rasmus Villemoes wrote: > > Each _device_ belonging to a given uclass of course has its own ->ops, > of a type determined by and known to the uclass. > > However, no instance of a uclass_driver seems to populate ->ops, and > the only reference to it in code is this

Re: [PATCH] tools: Fix default target compile tools in Python tools

2021-07-04 Thread Simon Glass
In commit 1e4687aa47ed ("binman: Use target-specific tools when cross-compiling"), a utility function was implemented to get preferred compilation tools using environment variables like CC and CROSS_COMPILE. Although it intended to provide custom default tools (same as those in the global

Re: [PATCH 0/8] sunxi: mmc: Fixes and speed increase

2021-07-04 Thread Samuel Holland
On 7/3/21 6:24 PM, Andre Przywara wrote: > On Tue, 25 May 2021 00:30:21 +0100 > Andre Przywara wrote: > > Hi, > > thanks to Jaehoon for reviewing some patches in here! > > Can anyone else please have a look at this series? > I am tempted to push them in the upcoming merge window, to expose

[RFC PATCH] mtd: mxs_nand: Add support for edo mode for imx6ul(lz) architecture

2021-07-04 Thread Michael Trimarchi
Add a proof of concept to support nand speed mode. This reduce load time about 4 times for large binary Signed-off-by: Michael Trimarchi --- arch/arm/include/asm/mach-imx/regs-gpmi.h | 9 + drivers/mtd/nand/raw/mxs_nand.c | 238 --

[PATCH] arm: imx: Fix spl imx romapi for imx8mn

2021-07-04 Thread Michael Trimarchi
We experimenting problems with imx8mn family cpu. We try to support boot0 and boot1 fallback. The condition to decide what function the bootrom should choose come from is_boot_from_stream_device This is a boot from mmcblk0boot0 with some debug U-Boot SPL 2020.04-5.4.70-2.3.2+gf3bcbdfc62 (Jul 03

[PATCH] ARM: renesas: Set CONFIG_SYS_TEXT_BASE=0x0 on R-Car Gen3

2021-07-04 Thread Marek Vasut
Since R-Car Gen3 already enables position independent build, also set CONFIG_SYS_TEXT_BASE=0x0 to finalize the switch. This is possible since 534f0fbd65 ("arm64: Fix relocation of env_addr if POSITION_INDEPENDENT=y") fixed current env_get_char() crash with CONFIG_SYS_TEXT_BASE=0x0 . This change

[PATCH] ARM: rmobile: Remove default bootargs

2021-07-04 Thread Marek Vasut
The bootargs in all those boards are a copy of initial example bootargs, just remove those as they make little sense in most configurations. Signed-off-by: Marek Vasut --- configs/hihope_rzg2_defconfig | 1 - configs/r8a77970_eagle_defconfig | 1 - configs/r8a77980_condor_defconfig | 1

[PATCH] ARM: rmobile: Align CPU: print with other prints

2021-07-04 Thread Marek Vasut
The CPU: print only has one space after it, while the other prints from U-Boot align the value to offset 7. Align the CPU: print too. No functional change. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/cpu_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/3] ARM: rmobile: Enable sysinfo on R-Car Gen3

2021-07-04 Thread Marek Vasut
Enable support for sysinfo on supported R-Car Gen3 boards. The sysinfo is used e.g. to access and decode board-specific information and then in turn used by board-info to print those information. On R-Car Gen3 the sysinfo rcar3 driver is used to parse the board ID EEPROM, obtain board type and

[PATCH 2/3] ARM: rmobile: Enable I2C EEPROM support on R-Car Gen3

2021-07-04 Thread Marek Vasut
Enable support for I2C EEPROM driver on supported Renesas R-Car Gen3 boards. This is useful for accessing the board ID EEPROM. Signed-off-by: Marek Vasut --- configs/r8a77990_ebisu_defconfig | 7 +++ configs/rcar3_salvator-x_defconfig | 7 +++ configs/rcar3_ulcb_defconfig | 7

[PATCH 1/3] ARM: dts: rmobile: Add sysinfo extras on R-Car Gen3

2021-07-04 Thread Marek Vasut
Add sysinfo node and phandle to the board ID EEPROM on all boards where this functionality is described in DT, which is Salvator-X(S), ULCB and Ebisu. The u-boot,dm-pre-reloc is necessary here, since the sysinfo must be available early during boot. The V3M and V3H boards currently do not describe

[PATCH] sysinfo: rcar3: Add Renesas R-Car Gen3 sysinfo driver

2021-07-04 Thread Marek Vasut
The Renesas R-Car Gen3 development kits contain board ID EEPROM. This driver parses out the board ID and revision out of that EEPROM and exports it e.g. for the board-info print on boot. Signed-off-by: Marek Vasut Cc: Sean Anderson Cc: Simon Glass --- drivers/sysinfo/Kconfig | 7 ++

[PATCH 2/2] board-info: Call sysinfo_detect() before sysinfo_get_str()

2021-07-04 Thread Marek Vasut
The sysinfo_get_str() implementation checks whether the sysinfo was even detected. In U-Boot proper, sysinfo_detect() is not called anywhere but on one specific board. Call sysinfo_detect() before sysinfo_get_str() to make sure the sysinfo is detected and sysinfo_get_str() returns valid value

[PATCH 1/2] board-info: Use sysinfo_get()

2021-07-04 Thread Marek Vasut
Replace uclass_first_device_err(UCLASS_SYSINFO, ) with sysinfo_get(). The board_info code may use sysinfo to print board information, so use the sysinfo functions consistently. The sysinfo_get() is internally implemented as return uclass_first_device_err(UCLASS_SYSINFO, ) anyway, so there is no

[PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list

2021-07-04 Thread Marek Vasut
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding. Signed-off-by: Marek Vasut Cc: Heiko Schocher Cc: Michal Simek ---

Re: [PATCH 1/8] imx8mm: Fix USB reg addresses for i.MX8MM

2021-07-04 Thread Marek Vasut
On 7/4/21 5:35 PM, Fabio Estevam wrote: Hi Marek, Hi, On Sat, Jul 3, 2021 at 10:04 PM Marek Vasut wrote: Retrieving the USB base addresses from DT would be preferred, yes, but the current code does not do that. I implemented exactly that in mx6_parse_dt_addrs() , see: 4dcfa3bcbcb ("usb:

Re: [PATCH] sandbox: Support signal handling only when requested

2021-07-04 Thread Simon Glass
Hi Heinrich, On Sun, 6 Jun 2021 at 15:35, Heinrich Schuchardt wrote: > > Am 6. Juni 2021 20:07:31 MESZ schrieb Sean Anderson : > >On 6/6/21 1:57 PM, Heinrich Schuchardt wrote: > >> On 6/6/21 7:52 PM, Sean Anderson wrote: > >>> On 6/6/21 1:28 PM, Heinrich Schuchardt wrote: > On 6/6/21 6:44

Re: [PATCH] dm: core: fix no null pointer detection in ofnode_get_addr_size_index()

2021-07-04 Thread Simon Glass
Hi Chenguanqiao, On Sat, 15 May 2021 at 09:20, Simon Glass wrote: > > On Thu, 13 May 2021 at 01:38, chenguanqiao wrote: > > > > From: Chen Guanqiao > > > > Fixed a defect of a null pointer being discovered by Coverity Scan: > >CID 331544: Null pointer dereferences (REVERSE_INULL) > >

Re: [PATCH 1/1] test: NULL dereference in test-uclass

2021-07-04 Thread Simon Glass
Hi Heinrich, On Thu, 3 Jun 2021 at 14:08, Heinrich Schuchardt wrote: > > If a test-uclass device is probed outside a test, uts is not defined. > Avoid a NULL dereference in this case. I am missing the motivation for this patch. In what situation does this occur? Regards, Simon > >

Re: [PATCH] fdtdec: fdtdec_get_aliases_highest_id: skip aliases to disabled nodes

2021-07-04 Thread Simon Glass
Hi Tim, On Fri, 11 Jun 2021 at 11:30, Tim Harvey wrote: > > On Fri, Jun 11, 2021 at 10:23 AM Sean Anderson wrote: > > > > > > > > On 6/11/21 1:16 PM, Tim Harvey wrote: > > > On Fri, Jun 11, 2021 at 10:09 AM Sean Anderson > > wrote: > > >> > > >> > > >> > > >> On 6/11/21 12:32 PM, Tim

[PATCH 8/8] dtoc: Update documentation to cover warnings in more detail

2021-07-04 Thread Simon Glass
When things go wrong it can be confusing to figure out what to change. Add a few more details to the documentation. Fix a 'make htmldocs' warning while we are here. Signed-off-by: Simon Glass --- doc/develop/driver-model/of-plat.rst | 53 1 file changed, 53

[PATCH 7/8] dtoc: Detect drivers which do not parse correctly

2021-07-04 Thread Simon Glass
At present if a driver is missing a uclass or compatible stirng, this is silently ignored. This makes sense in most cases, particularly for the compatible string, since it is not required except when the driver is used with of-platdata. But it is also not very helpful. When there is some sort of

[PATCH 6/8] dtoc: Detect unexpected suffix on .of_match

2021-07-04 Thread Simon Glass
Some rockchip drivers use a suffix on the of_match line which is not strictly valid. At present this causes the parsing to fail. Fix this and offer a warning. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 12 +++-- tools/dtoc/test_src_scan.py | 92

[PATCH 2/8] dtoc: Convert to use ArgumentParser

2021-07-04 Thread Simon Glass
Use this parser instead of OptionParser, which is deprecated. Signed-off-by: Simon Glass --- tools/dtoc/main.py | 51 -- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/tools/dtoc/main.py b/tools/dtoc/main.py index

[PATCH 5/8] dtoc: Add a stdout check in test_normalized_name()

2021-07-04 Thread Simon Glass
This test captures output but does not always check it. Add the missing code and drop the old comment. Signed-off-by: Simon Glass --- tools/dtoc/test_src_scan.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/dtoc/test_src_scan.py b/tools/dtoc/test_src_scan.py

[PATCH 4/8] dtoc: Correct the re_compat regular expression

2021-07-04 Thread Simon Glass
This expects a . before the field name (.e.g '.compatible = ...) but presently accepts anything at all. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/dtoc/src_scan.py b/tools/dtoc/src_scan.py index

[PATCH 3/8] dtoc: Allow multiple warnings for a driver

2021-07-04 Thread Simon Glass
At present we show when a driver is missing but this is not always that useful. There are various reasons way a driver may appear to be missing, such as a parse error in the source code or a missing field in the driver declaration. Update the implementation to record all warnings for each driver,

[PATCH 1/8] dtoc: Avoid using subscripts on match objects

2021-07-04 Thread Simon Glass
These are not supported before Python 3.6 so avoid them. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dtoc/src_scan.py b/tools/dtoc/src_scan.py index 2db96884c85..1dbb56712a3 100644 --- a/tools/dtoc/src_scan.py

[PATCH 0/8] dtoc: Improvements to warnings

2021-07-04 Thread Simon Glass
The warning about a missing driver can be a bit confusing and is not specifically mentioned in the documentation. Also some parse errors result in the driver simply being ignored, which is hard to diagnose. This series updates dtoc to try harder to find common errors and report a useful warning.

Re: [PATCH v2 17/33] dtoc: Process driver aliases along with drivers

2021-07-04 Thread Simon Glass
Hi Johan, On Sat, 26 Jun 2021 at 12:32, Simon Glass wrote: > > Hi Johan, > > On Mon, 21 Jun 2021 at 12:39, Johan Jonker wrote: > > > > Hi Simon, Heiko, > > > > With introduction of rockchip-nand-controller.c in Linux and recently > > rockchip_nfc.c in U-boot it offers a renewed opportunity to

[PATCH] rockchip: rk3399: adjust Nanopi R4S board power layout

2021-07-04 Thread xiaobo
1. Modify the VCC VDD power layout 2. Modify Ethernet1 interface of PCIE0 Signed-off-by: xiaobo --- arch/arm/dts/rk3399-nanopi-r4s.dts | 85 ++ 1 file changed, 63 insertions(+), 22 deletions(-) diff --git a/arch/arm/dts/rk3399-nanopi-r4s.dts

Re: [PATCH 1/8] imx8mm: Fix USB reg addresses for i.MX8MM

2021-07-04 Thread Fabio Estevam
Hi Marek, On Sat, Jul 3, 2021 at 10:04 PM Marek Vasut wrote: > > Retrieving the USB base addresses from DT would be preferred, yes, but > > the current code does not do that. > > I implemented exactly that in mx6_parse_dt_addrs() , see: > 4dcfa3bcbcb ("usb: ehci-mx6: Parse USB PHY and MISC

Re: [RFC] Load U-Boot without LK on DragonBoard 410c (+ DB820c?)

2021-07-04 Thread Ramon Fried
On Sun, Jul 4, 2021 at 2:14 PM Stephan Gerhold wrote: > > On Sun, Jul 04, 2021 at 02:08:39PM +0300, Ramon Fried wrote: > > On Sun, Jul 4, 2021 at 12:42 AM Stephan Gerhold wrote: > > > > > > On Thu, Jul 01, 2021 at 11:07:55AM +0200, Stephan Gerhold wrote: > > > > Hi! > > > > > > > > at the moment

Re: [RFC] Load U-Boot without LK on DragonBoard 410c (+ DB820c?)

2021-07-04 Thread Stephan Gerhold
On Sun, Jul 04, 2021 at 02:08:39PM +0300, Ramon Fried wrote: > On Sun, Jul 4, 2021 at 12:42 AM Stephan Gerhold wrote: > > > > On Thu, Jul 01, 2021 at 11:07:55AM +0200, Stephan Gerhold wrote: > > > Hi! > > > > > > at the moment the U-Boot ports for both DragonBoard 410c and 820c are > > > designed

Re: [RFC] Load U-Boot without LK on DragonBoard 410c (+ DB820c?)

2021-07-04 Thread Ramon Fried
On Sun, Jul 4, 2021 at 12:42 AM Stephan Gerhold wrote: > > On Thu, Jul 01, 2021 at 11:07:55AM +0200, Stephan Gerhold wrote: > > Hi! > > > > at the moment the U-Boot ports for both DragonBoard 410c and 820c are > > designed to be loaded as an Android boot image after Qualcomm's LK > > bootloader.