Re: [BUG] patman: refused to send patches because of warnings

2021-12-17 Thread Tony Dinh
Hi Sean, Just tried again with -i and it works fine now! Thanks, Tony On Fri, Dec 17, 2021 at 8:02 PM Sean Anderson wrote: > > On 12/17/21 10:59 PM, Tony Dinh wrote: > > Hi Simon, > > > > I tried to send in patches to add support for a new board. patman > > seems to hit a problem with "Bad

[PATCH 8/8] arm: kirkwood: Pogoplug-V4 : Add board maintainer

2021-12-17 Thread Tony Dinh
Add board maintainer for Pogoplug V4 board Signed-off-by: Tony Dinh --- board/cloudengines/pogo_v4/MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 board/cloudengines/pogo_v4/MAINTAINERS diff --git a/board/cloudengines/pogo_v4/MAINTAINERS

[PATCH 7/8] arm: kirkwood: Pogoplug-V4 : Add board implementation

2021-12-17 Thread Tony Dinh
Add board implementation for Pogoplug V4 Note: currently the fdt_get_phy_addr function in this file is duplicate in this board and many other Kirkwood boards (eg. Sheevaplug, GoFlex Home, etc.). This function is being factored out into common area by another patch. And because it was written for

[PATCH 6/8] arm: kirkwood: Pogoplug-V4 : Add board implementation header

2021-12-17 Thread Tony Dinh
Add board implementation header and Makefile for Pogoplug V4 Signed-off-by: Tony Dinh --- board/cloudengines/pogo_v4/Makefile | 10 board/cloudengines/pogo_v4/pogo_v4.h | 36 2 files changed, 46 insertions(+) create mode 100644

[PATCH 5/8] arm: kirkwood: Pogoplug-V4 : Add board kwbimage file

2021-12-17 Thread Tony Dinh
Add board kwbimage file for Pogoplug V4 board Signed-off-by: Tony Dinh --- board/cloudengines/pogo_v4/kwbimage.cfg | 148 1 file changed, 148 insertions(+) create mode 100644 board/cloudengines/pogo_v4/kwbimage.cfg diff --git a/board/cloudengines/pogo_v4/kwbimage.cfg

[PATCH 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file

2021-12-17 Thread Tony Dinh
Add include configs file for Pogoplug V4 board Signed-off-by: Tony Dinh --- include/configs/pogo_v4.h | 94 +++ 1 file changed, 94 insertions(+) create mode 100644 include/configs/pogo_v4.h diff --git a/include/configs/pogo_v4.h b/include/configs/pogo_v4.h

[PATCH 3/8] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2021-12-17 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- arch/arm/mach-kirkwood/Kconfig | 4 board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 20 insertions(+) create mode 100644 board/cloudengines/pogo_v4/Kconfig diff --git

[PATCH 2/8] arm: kirkwood: Pogoplug V4 : Add board defconfig file

2021-12-17 Thread Tony Dinh
Add board defconfig file for Pogoplug V4 board Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 97 +++ 1 file changed, 97 insertions(+) create mode 100644 configs/pogo_v4_defconfig diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig

[PATCH 1/8] arm: kirkwood: Pogoplug-V4 : Add DTS files

2021-12-17 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug_v4.dts | 145 ++ 2 files changed, 146 insertions(+) create mode 100644 arch/arm/dts/kirkwood-pogoplug_v4.dts diff --git

[PATCH 0/8] arm: kirkwood: Add support for Pogoplug V4

2021-12-17 Thread Tony Dinh
Pogoplug V4 specifications: Kirkwood 88F6192 SoC 800 MHz CPU 1Gbs Ethernet 128 MB RAM 128 MB NAND 1x USB 2.0 2x USB 3.0 (on PCIe bus) 1 SDHC slot 1x External SATA port (USM enclosure form factor slot) Tony Dinh (8): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug V4 :

Re: [BUG] patman: refused to send patches because of warnings

2021-12-17 Thread Sean Anderson
On 12/17/21 10:59 PM, Tony Dinh wrote: Hi Simon, I tried to send in patches to add support for a new board. patman seems to hit a problem with "Bad divisor in main" error and refuses to send the patches. The warnings are not really important, are they? In some instances, we need camel cases

[BUG] patman: refused to send patches because of warnings

2021-12-17 Thread Tony Dinh
Hi Simon, I tried to send in patches to add support for a new board. patman seems to hit a problem with "Bad divisor in main" error and refuses to send the patches. The warnings are not really important, are they? In some instances, we need camel cases because that is what the convention in the

Re: [PATCH v8 07/32] arm: vexpress: Add a devicetree files for juno

2021-12-17 Thread Linus Walleij
On Fri, Dec 17, 2021 at 5:00 AM Simon Glass wrote: > Sync these file, obtained from Linux v5.15. > > Add a note for the maintainer, and SPDX lines where they are missing. > The added lines are: > >SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > > Note, this matches the text in those

Re: Please pull u-boot-dm/next

2021-12-17 Thread Tom Rini
On Fri, Dec 17, 2021 at 12:43:24PM -0700, Simon Glass wrote: > Hi Tom, > > This is for the -next branch. > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10299 > > The following changes since commit b9c9ce8a4064c8d88f714604db856cf1cd2b40b5: > > Merge tag

Re: [PATCH v3] timer: Add a migration message

2021-12-17 Thread Sean Anderson
On 12/17/21 6:12 PM, Simon Glass wrote: Some boards still use the old timer mechanism. Set a deadline for them to update to driver model. Point to some examples as well. This needs a bit of a strange rule to avoid an error on some boards. Signed-off-by: Simon Glass --- Changes in v3: -

Re: [PATCH] fastboot: only look up real partition names when no alias exists

2021-12-17 Thread Sean Anderson
Hi Matthias, On 12/16/21 5:26 AM, Matthias Schiffer wrote: Having U-Boot look up the passed partition name even though an alias exists is unexpected, leading to warning messages (when the alias name doesn't exist as a real partition name) or the use of the wrong partition. Change

Re: Broken arc toolchain

2021-12-17 Thread Simon Glass
Hi Alexey, On Sat, 10 Jul 2021 at 16:03, Alexey Brodkin wrote: > > Hi Tom and Simon, > > So there're a couple of things involved indeed. > > As Tom correctly mentioned we used to use SNSP pre-built tools for ARC in > TravisCI previously. And frankly the reason was we needed something GCC 8.x >

[PATCH v3] timer: Add a migration message

2021-12-17 Thread Simon Glass
Some boards still use the old timer mechanism. Set a deadline for them to update to driver model. Point to some examples as well. This needs a bit of a strange rule to avoid an error on some boards. Signed-off-by: Simon Glass --- Changes in v3: - Push out the deadline Makefile

Re: [PATCH 1/2] fastboot: fb_getvar: Add getvar_logical_blocksize for MXP mfgtool

2021-12-17 Thread Sean Anderson
Hi Angus, On 12/17/21 10:41 AM, Angus Ainslie wrote: uuu uses the blocksize to determine the upload size Can you please elaborate on this more? Signed-off-by: Angus Ainslie --- drivers/fastboot/fb_getvar.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

[PATCH 08/12] Kconfig: Remove some symbols from the whitelist

2021-12-17 Thread Tom Rini
There are a number of symbols that are never defined, only referenced in code imported from the Linux kernel or similar. Drop them from the list. Signed-off-by: Tom Rini --- scripts/config_whitelist.txt | 897 --- 1 file changed, 897 deletions(-) diff --git

[PATCH 09/12] Convert CONFIG_88F5182 et al to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_88F5182 CONFIG_BOARD_IS_OPENRD_BASE CONFIG_BOARD_IS_OPENRD_CLIENT CONFIG_BOARD_IS_OPENRD_ULTIMATE CONFIG_D2NET_V2 CONFIG_FEROCEON CONFIG_FEROCEON_88FR131 CONFIG_INETSPACE_V2 CONFIG_KW88F6192 CONFIG_KW88F6281

[PATCH 10/12] Convert CONFIG_SYS_KWD_CONFIG to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_KWD_CONFIG Signed-off-by: Tom Rini --- arch/arm/Kconfig | 8 arch/arm/mach-kirkwood/include/mach/config.h | 9 - arch/arm/mach-mvebu/include/mach/config.h| 9 -

[PATCH 12/12] Convert CONFIG_JFFS2_DEV et al to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_JFFS2_DEV CONFIG_JFFS2_LZO CONFIG_JFFS2_NAND CONFIG_JFFS2_PART_OFFSET CONFIG_JFFS2_PART_SIZE Signed-off-by: Tom Rini --- README | 3 --- cmd/Kconfig| 21 +

[PATCH 11/12] Convert CONFIG_KIRKWOOD_GPIO to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_KIRKWOOD_GPIO Signed-off-by: Tom Rini --- configs/SBx81LIFKW_defconfig | 1 + configs/SBx81LIFXCAT_defconfig | 1 + configs/d2net_v2_defconfig | 1 + configs/dns325_defconfig | 1 +

[PATCH 04/12] serial: arm_dcc: Use CONFIG_ARM64 not CONFIG_CPU_ARMV8

2021-12-17 Thread Tom Rini
The only place we use CONFIG_CPU_ARMV8 was in the arm_dcc serial driver. Switch this to CONFIG_ARM64 today, and if in the future we need finer granularity tuning here, a new CONFIG_SERIAL option needs to be introduced. Signed-off-by: Tom Rini --- drivers/serial/arm_dcc.c| 2 +-

[PATCH 07/12] Convert CONFIG_CPU_FREQ_HZ to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_CPU_FREQ_HZ Cc: Michal Simek Signed-off-by: Tom Rini --- arch/arm/mach-zynqmp-r5/Kconfig| 6 ++ configs/xilinx_zynqmp_r5_defconfig | 1 + include/configs/xilinx_zynqmp_r5.h | 3 --- include/configs/zynq-common.h | 5 - 4 files

[PATCH 05/12] Convert CONFIG_CPU_PXA27X to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_CPU_PXA27X Signed-off-by: Tom Rini --- arch/arm/Kconfig | 6 +- include/configs/colibri_pxa270.h | 1 - scripts/config_whitelist.txt | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/Kconfig

[PATCH 03/12] Convert CONFIG_SYS_I2C_EEPROM_ADDR_LEN to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_I2C_EEPROM_ADDR_LEN Signed-off-by: Tom Rini --- include/configs/km/km-mpc832x.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/km/km-mpc832x.h b/include/configs/km/km-mpc832x.h index aac1e999e40a..888bb2981f7b 100644

[PATCH 06/12] Convert CONFIG_CPU_SH7751 to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_CPU_SH7751 Signed-off-by: Tom Rini --- arch/sh/Kconfig | 6 +- include/configs/r2dplus.h| 1 - scripts/config_whitelist.txt | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/sh/Kconfig

[PATCH 01/12] Convert CONFIG_83XX_PCICLK to Kconfig

2021-12-17 Thread Tom Rini
This converts the following to Kconfig: CONFIG_83XX_PCICLK Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/Kconfig | 7 +++ configs/kmcoge5ne_defconfig | 1 + configs/kmopti2_defconfig| 1 + configs/kmsupx5_defconfig| 1 + configs/kmtegr1_defconfig| 1 +

[PATCH 02/12] ppc: mpc83xx: Remove unused CONFIG symbols

2021-12-17 Thread Tom Rini
Neither of these symbols are referenced anywhere else, so remove them. Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/start.S | 2 -- include/configs/km/km-mpc832x.h | 5 - 2 files changed, 7 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S

Re: [PATCH 2/2] fastboot: fb_mmc: Add mfgtool all partition size

2021-12-17 Thread Sean Anderson
On 12/17/21 10:42 AM, Angus Ainslie wrote: NXP mfgtool uses all to specify the entire partition Signed-off-by: Angus Ainslie --- drivers/fastboot/fb_mmc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c index

[PATCH v1 2/5] dts: allow dts files in board directory

2021-12-17 Thread Troy Kisky
Let the board specific dts files live in the board directory. Signed-off-by: Troy Kisky --- dts/Makefile | 11 +-- scripts/Makefile.lib | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/dts/Makefile b/dts/Makefile index cb311138295..09b46f9fcfd 100644 ---

[PATCH v1 4/5] genboardcfg: allow defconfigs in board directory

2021-12-17 Thread Troy Kisky
The adds boards whose defconfigs are in the board's directory. Signed-off-by: Troy Kisky --- tools/genboardscfg.py | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index

[PATCH v1 5/5] nitrogen6x: move board specific files to nitrogen6x directory

2021-12-17 Thread Troy Kisky
This makes it clearer which board uses a file. Signed-off-by: Troy Kisky --- arch/arm/dts/Makefile | 3 --- board/boundary/nitrogen6x/MAINTAINERS | 13 - board/boundary/nitrogen6x/Makefile | 13 +

[PATCH v1 3/5] scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to live in board directory

2021-12-17 Thread Troy Kisky
Let the board specific include file live in the board directory. Signed-off-by: Troy Kisky --- scripts/Makefile.autoconf | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf index 8a3efdb2db0..6a725a3e2ff 100644 ---

[PATCH v1 1/5] kconfig: allow defconfigs to live in board directory

2021-12-17 Thread Troy Kisky
This will reduce the size of the configs directory, and make it more clear which board directory uses the defconfig file. Signed-off-by: Troy Kisky --- scripts/kconfig/Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/Makefile

[PATCH v1 0/5] Move board specific files to board directory

2021-12-17 Thread Troy Kisky
This series intends to let board specific files live in the boards directory. The last patch moves files for nitrogen6x. I have tested it with buildman ./tools/buildman/buildman boundary -b denx_master But it is likely the more scripts then just tools/genboardscfg.py would need to be updated.

Timer migration to driver model

2021-12-17 Thread Simon Glass
Hi, I've sent a patch to set a deadline for migration to CONFIG_TIMER, i.e. using driver model for timers. This catches quite a lot of boards, so please take a look. Regards, Simon

[PATCH v11] driver: spi: add bcm iproc qspi support

2021-12-17 Thread Roman Bacik
From: Rayagonda Kokatanur IPROC qspi driver supports both BSPI and MSPI modes. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Gooty Acked-by: Rayagonda Kokatanur Signed-off-by: Roman Bacik --- Changes in v11: - fix condition for readl_poll_timeout in bspi_read_via_raf Changes

[PATCH v6 21/27] x86: efi: Show the system-table revision

2021-12-17 Thread Simon Glass
Show the revision of this table as it can be important. Also update the 'efi table' entry to show the actual address of the EFI table rather than our table that points to it. This saves a step and the intermediate table has nothing else in it. Signed-off-by: Simon Glass --- Changes in v6: -

[PATCH] arm: rmobile: rzg2_beacon: Migrate reset to SYSRESET_PSCI

2021-12-17 Thread Adam Ford
Instead of a custom cpu_reset function, use the sysreset_psci instead to reduce redundant code clutter. Signed-off-by: Adam Ford diff --git a/board/beacon/beacon-rzg2m/beacon-rzg2m.c b/board/beacon/beacon-rzg2m/beacon-rzg2m.c index df6044a429..4b41c6fdaa 100644 ---

Please pull u-boot-dm/next

2021-12-17 Thread Simon Glass
Hi Tom, This is for the -next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10299 The following changes since commit b9c9ce8a4064c8d88f714604db856cf1cd2b40b5: Merge tag 'u-boot-at91-2022.04-a' of https://source.denx.de/u-boot/custodians/u-boot-at91 into next

[PATCH v6 24/27] x86: efi: Round out the link script for 64-bit EFI

2021-12-17 Thread Simon Glass
Make sure the linker lists are in the right place and drop the eh_frame section, which is not needed. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch to round out the link script for 64-bit EFI arch/x86/lib/elf_x86_64_efi.lds | 5 - 1 file changed, 4

[PATCH v6 23/27] x86: efi: Tweak the code used for the 64-bit EFI app

2021-12-17 Thread Simon Glass
Add an empty CPU init function to avoid fiddling with low-level CPU features in the app. Set up the C runtime correctly for 64-bit use and avoid clearing BSS, since this is done by EFI when U-Boot is loaded. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch to

[PATCH v6 26/27] x86: efi: Set the correct link flags for the 64-bit EFI app

2021-12-17 Thread Simon Glass
At present some 32-bit settings are used with the 64-bit app. Fix this by separating out the two cases. Be careful not to break the 64-bit payload, which needs to build a 64-bit EFI stub with a 32-bit U-Boot. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch

[PATCH v6 27/27] efi: Build the 64-bit app properly

2021-12-17 Thread Simon Glass
Now that the linker crash is resolved, build the 64-bit EFI app, including all the required code. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch to build the 64-bit app properly - Add various patches to fix up the 64-bit app so that it boots Changes in v2:

[PATCH v6 25/27] x86: efi: Don't use the 64-bit link script for the EFI app

2021-12-17 Thread Simon Glass
That script is not intended for use with EFI, so update the logic to avoid using it. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch to avoid using the 64-bit link script for the EFI app arch/x86/cpu/config.mk | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v6 20/27] efi: Support the efi command in the app

2021-12-17 Thread Simon Glass
At present the 'efi' command only works in the EFI payload. Update it to work in the app too, so the memory map can be examined. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Makefile | 2 +- cmd/efi.c | 48 ---

[PATCH v6 22/27] x86: efi: Don't set up global_data again with EFI

2021-12-17 Thread Simon Glass
Since EFI does not relocate and uses the same global_data pointer throughout the board-init process, drop this unnecessary setup, to avoid a hang. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add new patch to avoid setting up global_data again with EFI

[PATCH v6 19/27] x86: efi: Update efi_get_next_mem_desc() to avoid needing a map

2021-12-17 Thread Simon Glass
At present this function requires a pointer to struct efi_entry_memmap but the only field used in there is the desc_size. We want to be able to use it from the app, so update it to use desc_size directly. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/efi/payload.c | 8

[PATCH v6 17/27] efi: Show when allocated pages are used

2021-12-17 Thread Simon Glass
Add a message here so that both paths of memory allocation are reported. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use log_info() instead of printf() lib/efi/efi_app.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/efi/efi_app.c

[PATCH v6 18/27] efi: Allow easy selection of serial-only operation

2021-12-17 Thread Simon Glass
Add info about how to select vidconsole or serial. Also set up a demo boot command. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add a better boot command too include/configs/efi-x86_app.h | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v6 14/27] efi: Move exit_boot_services into a function

2021-12-17 Thread Simon Glass
At present this code is inline in the app and stub. But they do the same thing. The difference is that the stub does it immediately and the app doesn't want to do it until the end (when it boots a kernel) or not at all, if returning to UEFI. Move it into a function so it can be called as needed.

[PATCH v6 13/27] efi: Share struct efi_priv between the app and stub code

2021-12-17 Thread Simon Glass
At present each of these has its own static variable and helper functions. Move them into a shared file. Signed-off-by: Simon Glass --- (no changes since v1) include/efi.h | 21 + lib/efi/efi.c | 29 + lib/efi/efi_app.c | 21

[PATCH v6 15/27] efi: Check for failure when initing the app

2021-12-17 Thread Simon Glass
The stub checks for failure with efi_init(). Add this for the app as well. It is unlikely that anything can be done, but we may as well stop. Signed-off-by: Simon Glass --- Changes in v6: - Use 'U-Boot' instead of 'ARP' typo lib/efi/efi_app.c | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH v6 16/27] efi: Mention that efi_info_get() is only used in the stub

2021-12-17 Thread Simon Glass
This provides access to EFI tables after U-Boot has exited boot services. It is not needed in the app since boot services remain alive and we can just call them whenever needed. Add a comment to explain this. Signed-off-by: Simon Glass --- Changes in v6: - Fix 'stuff' typo in comment - Update

[PATCH v6 12/27] efi: Add a few comments to the stub

2021-12-17 Thread Simon Glass
Comment some functions that need more information. Signed-off-by: Simon Glass --- Changes in v6: - Fix comment style in setup_info_table() lib/efi/efi_stub.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c index

[PATCH v6 09/27] efi: Drop device_path from struct efi_priv

2021-12-17 Thread Simon Glass
This is not used anywhere drop it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Move device_path path change to its own patch include/efi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/efi.h b/include/efi.h index 908c5dc6ebd..77e599c256e 100644 ---

[PATCH v6 11/27] efi: Fix ll_boot_init() operation with the app

2021-12-17 Thread Simon Glass
This should return false when the EFI app is running, since UEFI has done the required low-level init. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) include/init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/init.h b/include/init.h index

[PATCH v6 10/27] efi: Add comments to struct efi_priv

2021-12-17 Thread Simon Glass
This structure is uncommented. Fix it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Drop comments that confuse sphinx - Move device_path path change to its own patch include/efi.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH v6 04/27] efi: Locate all block devices in the app

2021-12-17 Thread Simon Glass
When starting the app, locate all block devices and make them available to U-Boot. This allows listing partitions and accessing files in filesystems. EFI also has the concept of 'disks', meaning boot media. For now, this is not obviously useful in U-Boot, but add code to at least locate these.

[PATCH v6 08/27] x86: efi: Add room for the binman definition in the dtb

2021-12-17 Thread Simon Glass
At present only 4KB of spare space is left in the DTB when building the EFI app. Increase this to 32KB so there is plenty of space to insert the binman definition. This cannot be expanded later (as with OF_SEPARATE) because the ELF image has already been built. Signed-off-by: Simon Glass ---

[PATCH v6 06/27] x86: Allow booting a kernel from the EFI app

2021-12-17 Thread Simon Glass
At present this is disabled, but it should work so long as the kernel does not need EFI services. Enable it and add a note about remaining work. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Update documentation arch/x86/lib/bootm.c | 11 +++

[PATCH v6 05/27] efi: serial: Support arrow keys

2021-12-17 Thread Simon Glass
At present only the backspace key is supported in U-Boot, when running as an EFI app. Add support for arrows, home and end as well, to make the CLI more friendly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/serial_efi.c | 11 +-- 1 file changed, 9

[PATCH v6 07/27] x86: Don't process the kernel command line unless enabled

2021-12-17 Thread Simon Glass
If the 'bootm' command is not enabled then this code is not available and this causes a link error. Fix it. Note that for the EFI app, there is no indication of missing code. It just hangs! Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/zimage.c | 13 - 1 file

[PATCH v6 03/27] efi: Add a media/block driver for EFI block devices

2021-12-17 Thread Simon Glass
Add a block driver which handles read/write for EFI block devices. This driver actually already exists ('efi_block') but is not really suitable for use as a real U-Boot driver: - The operations do not provide a udevice - The code is designed for running as part of EFI loader, so uses

[PATCH v6 02/27] efi: Add EFI uclass for media

2021-12-17 Thread Simon Glass
At present UCLASS_EFI_LOADER is used to represent an EFI filesystem among other things. The only driver that uses this uclass is in fact not a real U-Boot driver, since its operations do not include a struct udevice. Rather than mess with this, create a new UCLASS_EFI_MEDIA uclass to handle EFI

[PATCH v6 01/27] efi: Rename UCLASS_EFI and IF_TYPE_EFI

2021-12-17 Thread Simon Glass
These names are better used for access to devices provided by an EFI layer. Use EFI_LOADER instead here, since these are only available in U-Boot's EFI_LOADER layer. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v6: - Update comment to UCLASS_EFI_LOADER Changes in

[PATCH v6 00/27] efi: Improvements to U-Boot running on top of UEFI

2021-12-17 Thread Simon Glass
At present U-Boot can be built as an EFI app, but it is really just for testing, with very few features. Instead, the payload build is used for booting on top of UEFI, where U-Boot takes over the machine immediately and supplies its own drivers. But the app could be made more useful. This series

USB 2.0 Test Errors when XHCI driver is loaded on RZ/G2

2021-12-17 Thread Adam Ford
I have an RZ/G2 family of boards which has a USB 2.0 controller connected to a hub with 4 ports on it. I'm trying to run some hardware tests on the USB and when I issue the command: usb test 0 1 P I get a strange error and subsequently a message that looks like it's executing successfully,

Re: [PATCH 3/3] cmd: efi: efidebug print ECPT table

2021-12-17 Thread Heinrich Schuchardt
On 12/17/21 13:55, Jose Marinho wrote: Signed-off-by: Jose Marinho --- cmd/efidebug.c | 41 + include/efi_loader.h | 2 ++ 2 files changed, 43 insertions(+) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index a53a5029fa..c3246e1820 100644 ---

Re: [PATCH 0/3] Conformance Profiles Table support in U-boot

2021-12-17 Thread Heinrich Schuchardt
On 12/17/21 13:55, Jose Marinho wrote: The Conformance Profiles Table (ECPT) table will be included in the UEFI specification 2.9+. The change suggested in https://bugzilla.tianocore.org/show_bug.cgi?id=3591 is a not well designed: How could the missing of a table ever be taken as a sign of

Re: [PATCH 2/3] arch: imx8m: imx-regs.h add the USB regs

2021-12-17 Thread Fabio Estevam
On Fri, Dec 17, 2021 at 2:03 PM Adam Ford wrote: > I didn't think Driver model was a requirement for SPL. That's my understanding as well. > > I had problems getting the dwc3 to initialize properly when using the > > device model in the SPL. I'm currently just using this in the SPL and > > the

Re: [PATCH v5 05/28] efi: serial: Support arrow keys

2021-12-17 Thread Simon Glass
Hi Heinrich, On Fri, 17 Dec 2021 at 10:14, Heinrich Schuchardt wrote: > > On 12/17/21 17:37, Simon Glass wrote: > > Hi Heinrich, > > > > On Thu, 9 Dec 2021 at 12:44, Heinrich Schuchardt wrote: > >> > >> On 12/4/21 07:56, Simon Glass wrote: > >>> At present only the backspace key is supported in

Re: [PATCH v5 25/29] image: Remove #ifdefs from select_ramdisk()

2021-12-17 Thread Neil Armstrong
Hi, On 09/10/2021 03:41, Tom Rini wrote: > On Sat, Sep 25, 2021 at 07:43:38PM -0600, Simon Glass wrote: > >> Use boolean variables to deal with the strange #ifdef logic of this >> function, so we can remove the #ifdefs. >> >> Signed-off-by: Simon Glass > > Applied to u-boot/master, thanks! >

Re: [PATCH u-boot-next 00/12] Common U-Boot macros for PCI Configuration Mechanism #1

2021-12-17 Thread Pali Rohár
Hello! Could you look and review at this patch series? On Friday 26 November 2021 11:42:40 Pali Rohár wrote: > This patch series add new U-Boot macros for composing Config Address for > PCI Configuration Mechanism #1 as defined in PCI Local Bus Specification, > including extended variant (which

[PATCH] arm: mvebu: Use printf for printing fatal errors

2021-12-17 Thread Pali Rohár
There is no point to hide/disable fatal errors via debug() macro. Print fatal errors loudly. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index

[PATCH v10] driver: spi: add bcm iproc qspi support

2021-12-17 Thread Roman Bacik
IPROC qspi driver supports both BSPI and MSPI modes. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Gooty Acked-by: Rayagonda Kokatanur Signed-off-by: Roman Bacik --- Changes in v10: - remove binding document - use defined values for delays and timeouts - replace timer-based logic

[PATCH] arm: mvebu: Remove commented example code

2021-12-17 Thread Pali Rohár
Include file debug_uart.h already contains documentation how to use it. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/spl.c | 13 - 1 file changed, 13 deletions(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index 6a9e1d860cf7..29a8adc9d79c 100644 ---

Re: [PATCH 2/3] efi: ECPT add EBBRv2.0 conformance profile

2021-12-17 Thread Heinrich Schuchardt
On 12/17/21 13:55, Jose Marinho wrote: Display the EBBRv2.0 conformance in the ECPT table. The EBBRv2.0 conformance profile is set in the ECPT if CONFIG_EFI_EBBR_2_0_CONFORMANCE=y. The config defaults to 'n'. Signed-off-by: Jose Marinho --- include/efi_api.h| 4

Re: [PATCH 1/3] efi: Create ECPT table

2021-12-17 Thread Heinrich Schuchardt
On 12/17/21 13:55, Jose Marinho wrote: The ECPT table will be included in the UEFI specification 2.9+. The ECPT table was introduced in UEFI following the code-first path. The acceptance ticket can be viewed at: https://bugzilla.tianocore.org/show_bug.cgi?id=3591 The Conformance

Re: [PATCH v5 05/28] efi: serial: Support arrow keys

2021-12-17 Thread Heinrich Schuchardt
On 12/17/21 17:37, Simon Glass wrote: Hi Heinrich, On Thu, 9 Dec 2021 at 12:44, Heinrich Schuchardt wrote: On 12/4/21 07:56, Simon Glass wrote: At present only the backspace key is supported in U-Boot, when running as an EFI app. Add support for arrows, home and end as well, to make the CLI

Re: [PATCH 2/3] arch: imx8m: imx-regs.h add the USB regs

2021-12-17 Thread Adam Ford
On Fri, Dec 17, 2021 at 10:35 AM Angus Ainslie wrote: > > Hi Fabio, > > On 2021-12-17 08:28, Fabio Estevam wrote: > > Hi Angus, > > > > On Fri, Dec 17, 2021 at 12:21 PM Angus Ainslie wrote: > >> > >> Add the USB regs for SDP mode > >> > >> Signed-off-by: Angus Ainslie > >> --- > >>

Re: [PATCH 2/2] fdtgrep: Handle an empty output tree

2021-12-17 Thread Simon Glass
In strange cases it is possible for fdtgrep to find nothing to output. Typically this means that the resulting SPL device tree is not going to allow anything to boot, but at present the tree is actually invalid, since it only has an END tag in the struct region. The FDT spec requires at least a

Re: [PATCH 1/2] fdtgrep: Correct alignment of struct section

2021-12-17 Thread Simon Glass
When outputting a devicetree we should not align the struct section to a 16-byte boundary. The normal position is fine, which is 8-byte aligned. This avoids leaving adding 8 extra zero bytes in the output tree in the case where the reserved section is empty (i.e has 16 zero bytes).

Re: [PATCH v5 22/28] x86: efi: Show the system-table revision

2021-12-17 Thread Simon Glass
Hi Heinrich, On Thu, 9 Dec 2021 at 13:34, Heinrich Schuchardt wrote: > > On 12/4/21 07:56, Simon Glass wrote: > > Show the revision of this table as it can be important. > > > > Alo update the 'efi table' entry to show the actual address of the EFI > > %s/Alo/Also/ > > > table rather than our

Re: [PATCH v5 21/28] efi: Support the efi command in the app

2021-12-17 Thread Simon Glass
Hi Heinrich, On Thu, 9 Dec 2021 at 13:27, Heinrich Schuchardt wrote: > > On 12/4/21 07:56, Simon Glass wrote: > > At present the 'efi' command only works in the EFI payload. Update it to > > work in the app too, so the memory map can be examined. > > cmd/efi.c seems to be duplicating function

Re: [PATCH v5 15/28] efi: Move exit_boot_services into a function

2021-12-17 Thread Simon Glass
Hi Heinrich, On Sat, 4 Dec 2021 at 12:13, Heinrich Schuchardt wrote: > > On 12/4/21 16:56, Simon Glass wrote: > > At present this code is inline in the app and stub. But they do the same > > thing. The difference is that the stub does it immediately and the app > > doesn't want to do it until

Re: [PATCH v5 18/28] efi: Show when allocated pages are used

2021-12-17 Thread Simon Glass
Hi Heinrich, On Thu, 9 Dec 2021 at 12:55, Heinrich Schuchardt wrote: > > On 12/4/21 07:56, Simon Glass wrote: > > Add a message here so that both paths of memory allocation are reported. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since v2) > > > > Changes in v2: > > - Use

Re: [PATCH v5 05/28] efi: serial: Support arrow keys

2021-12-17 Thread Simon Glass
Hi Heinrich, On Thu, 9 Dec 2021 at 12:44, Heinrich Schuchardt wrote: > > On 12/4/21 07:56, Simon Glass wrote: > > At present only the backspace key is supported in U-Boot, when running as > > an EFI app. Add support for arrows, home and end as well, to make the CLI > > more friendly. > > > >

Re: [PATCH v5 04/28] efi: Locate all block devices in the app

2021-12-17 Thread Simon Glass
Hi Heinrich, On Thu, 9 Dec 2021 at 12:23, Heinrich Schuchardt wrote: > > On 12/4/21 10:43, Heinrich Schuchardt wrote: > > On 12/4/21 16:56, Simon Glass wrote: > >> When starting the app, locate all block devices and make them available > >> to U-Boot. This allows listing partitions and accessing

Re: [PATCH 2/2] doc: add Arm Juno board documentation

2021-12-17 Thread Simon Glass
On Tue, 14 Dec 2021 at 10:55, Andre Przywara wrote: > > The Juno Arm development board is an open, vendor-neutral, Armv8-A > development platform. > Add documentation that briefly outlines the hardware, and describes > building and installation of U-Boot. > > Signed-off-by: Andre Przywara > ---

Re: [PATCH 1/2] doc: Add documentation for the Arm VExpress64 board configs

2021-12-17 Thread Simon Glass
Hi Andre, On Tue, 14 Dec 2021 at 10:55, Andre Przywara wrote: > > From: Peter Hoyes > > Create a new documentation section for Arm Ltd boards with a sub-page > for the FVP VExpress64 system. > > Signed-off-by: Peter Hoyes > [Andre: remove Juno stub] > Signed-off-by: Andre Przywara > --- >

Re: [PATCH] doc: board: Add Calxeda Highbank/Midway documentation

2021-12-17 Thread Simon Glass
Hi Andre, On Tue, 14 Dec 2021 at 10:47, Andre Przywara wrote: > > The Calxeda servers are using U-Boot as the primary bootloader, which > was shipped as part of a firmware upgrade package. > Even though the machines are considered legacy at this point, the port > still works, so deserves some

Re: [PATCH] sunxi: add board documentation

2021-12-17 Thread Simon Glass
Hi Andre, On Sun, 12 Dec 2021 at 18:03, Andre Przywara wrote: > > Add some long overdue instructions for building and installing U-Boot on > Allwinner SoC based boards. > This describes the building process, including TF-A and crust, plus > installation to SD card, eMMC and SPI flash, both from

Re: [PATCH v2] phy: zynqmp: Add serdes/psgtr driver

2021-12-17 Thread Simon Glass
Hi Michal, On Wed, 15 Dec 2021 at 02:58, Michal Simek wrote: > > Add PSGTR driver for Xilinx ZynqMP. > The most of configurations are taken from Linux kernel psgtr driver. > > USB3.0 and SGMII configurations are tested on SOM. In SGMII case also > IOU_SLCR reg is updated to get proper clock

Re: Are dt-bindings headers part of the device tree spec?

2021-12-17 Thread Simon Glass
Hi Sean, On Wed, 15 Dec 2021 at 08:53, Sean Anderson wrote: > > > Hi all, > > I'm reviewing a clock driver [1], and the submitter has deviated from > the defines used by Linux. For example, where Linux might have > > #define CLOCK_FOOBAR 5 > > his driver might have > > #define

Re: [PATCH 2/3] arch: imx8m: imx-regs.h add the USB regs

2021-12-17 Thread Angus Ainslie
Hi Fabio, On 2021-12-17 08:28, Fabio Estevam wrote: Hi Angus, On Fri, Dec 17, 2021 at 12:21 PM Angus Ainslie wrote: Add the USB regs for SDP mode Signed-off-by: Angus Ainslie --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 2/3] arch: imx8m: imx-regs.h add the USB regs

2021-12-17 Thread Fabio Estevam
Hi Angus, On Fri, Dec 17, 2021 at 12:21 PM Angus Ainslie wrote: > > Add the USB regs for SDP mode > > Signed-off-by: Angus Ainslie > --- > arch/arm/include/asm/arch-imx8m/imx-regs.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h >

  1   2   >