Re: [PATCH 6/8] arm: kirkwood: Pogoplug-V4 : Add board implementation header

2021-12-19 Thread Stefan Roese
Hi Tony, On 12/18/21 22:47, Tony Dinh wrote: Hi Pali, On Sat, Dec 18, 2021 at 5:09 AM Pali Rohár wrote: On Friday 17 December 2021 20:23:32 Tony Dinh wrote: Add board implementation header and Makefile for Pogoplug V4 Signed-off-by: Tony Dinh --- board/cloudengines/pogo_v4/Makefile |

Re: [PATCH 2/8] arm: kirkwood: Pogoplug V4 : Add board defconfig file

2021-12-19 Thread Stefan Roese
Hi Tony, On 12/18/21 22:41, Tony Dinh wrote: Hi Pali, On Sat, Dec 18, 2021 at 5:17 AM Pali Rohár wrote: On Friday 17 December 2021 20:23:28 Tony Dinh wrote: Add board defconfig file for Pogoplug V4 board Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 97 ++

Re: [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1

2021-12-19 Thread Heiko Schocher
Hello Marek, On 18.12.21 23:41, Marek Behún wrote: > On Sat, 18 Dec 2021 14:42:51 +0100 > Stefan Roese wrote: > >> Hi Heiko, >> >> On 11/18/21 09:18, Stefan Roese wrote: >>> Testing on Armada XP with an EEPROM using register address with size >>> of 2 has shown, that the register address bytes a

Re: [RFC PATCH v2 7/8] FWU: Add support for FWU Multi Bank Update feature

2021-12-19 Thread AKASHI Takahiro
On Sun, Dec 19, 2021 at 12:36:04PM +0530, Sughosh Ganu wrote: > The FWU Multi Bank Update feature supports updation of firmware images > to one of multiple sets(also called banks) of images. The firmware > images are clubbed together in banks, with the system booting images > from the active bank.

Re: [RFC PATCH v2 6/8] FWU: Add boot time checks as highlighted by the FWU specification

2021-12-19 Thread AKASHI Takahiro
Sughosh, On Sun, Dec 19, 2021 at 12:36:03PM +0530, Sughosh Ganu wrote: > The FWU Multi Bank Update specification requires the Update Agent to > carry out certain checks at the time of platform boot. The Update > Agent is the component which is responsible for updating the firmware > components and

Re: [RFC v2 02/20] blk: add a helper function, blk_probe_or_unbind()

2021-12-19 Thread AKASHI Takahiro
On Sat, Dec 18, 2021 at 11:55:41AM +0100, Heinrich Schuchardt wrote: > On 12/14/21 08:01, AKASHI Takahiro wrote: > > Hi Simon, > > > > Thank you for your review on this series. > > > > On Mon, Dec 13, 2021 at 05:51:40AM -0700, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 9 Dec 2021

[PATCH v8 12/12] (RFC) efi_loader, dts: add public keys for capsules to device tree

2021-12-19 Thread AKASHI Takahiro
By specifying CONFIG_EFI_CAPSULE_KEY_PATH, the build process will automatically insert the given key into the device tree. Otherwise, users are required to do so manually, possibly, with the utility script, fdtsig.sh. Signed-off-by: AKASHI Takahiro --- doc/develop/uefi/uefi.rst | 4 dts/Ma

[PATCH v8 11/12] (RFC) tools: add fdtsig.sh

2021-12-19 Thread AKASHI Takahiro
With this script, a public key is added to a device tree blob as the default efi_get_public_key_data() expects. Signed-off-by: AKASHI Takahiro --- MAINTAINERS | 1 + tools/fdtsig.sh | 40 2 files changed, 41 insertions(+) create mode 100755 tools/fd

[PATCH v8 10/12] test/py: efi_capsule: check the results in case of CAPSULE_AUTHENTICATE

2021-12-19 Thread AKASHI Takahiro
Before the capsule authentication is supported, this test script works correctly, but with the feature enabled, most tests will fail due to unsigned capsules. So check the results depending on CAPSULE_AUTHENTICATE or not. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- .../test_efi_

[PATCH v8 09/12] test/py: efi_capsule: add a test for "--guid" option

2021-12-19 Thread AKASHI Takahiro
This test scenario tests a new feature of mkeficapsule, "--guid" option, which allows us to specify FMP driver's guid explicitly at the command line. Signed-off-by: AKASHI Takahiro --- test/py/tests/test_efi_capsule/conftest.py| 3 + .../test_efi_capsule/test_capsule_firmware.py | 67 ++

[PATCH v8 08/12] test/py: efi_capsule: align with the syntax change of mkeficapsule

2021-12-19 Thread AKASHI Takahiro
Since the syntax of mkeficapsule was changed in the previous commit, we need to modify command line arguments in a pytest script. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- test/py/tests/test_efi_capsule/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[PATCH v8 07/12] tools: mkeficapsule: allow for specifying GUID explicitly

2021-12-19 Thread AKASHI Takahiro
The existing options, "--fit" and "--raw," are only used to put a proper GUID in a capsule header, where GUID identifies a particular FMP (Firmware Management Protocol) driver which then would handle the firmware binary in a capsule. In fact, mkeficapsule does the exact same job in creating a capsu

[PATCH v8 06/12] test/py: efi_capsule: add image authentication test

2021-12-19 Thread AKASHI Takahiro
Add a couple of test cases against capsule image authentication for capsule-on-disk, where only a signed capsule file with the verified signature will be applied to the system. Due to the difficulty of embedding a public key (esl file) in U-Boot binary during pytest setup time, all the keys/certif

[PATCH v8 05/12] doc: update UEFI document for usage of mkeficapsule

2021-12-19 Thread AKASHI Takahiro
Now we can use mkeficapsule command instead of EDK-II's script to create a signed capsule file. So update the instruction for capsule authentication. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- doc/develop/uefi/uefi.rst | 143 ++---

[PATCH v8 04/12] tools: mkeficapsule: add man page

2021-12-19 Thread AKASHI Takahiro
Add a man page for mkeficapsule command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- MAINTAINERS| 1 + doc/mkeficapsule.1 | 95 ++ 2 files changed, 96 insertions(+) create mode 100644 doc/mkeficaps

[PATCH v8 03/12] tools: mkeficapsule: add firmwware image signing

2021-12-19 Thread AKASHI Takahiro
With this enhancement, mkeficapsule will be able to sign a capsule file when it is created. A signature added will be used later in the verification at FMP's SetImage() call. To do that, We need specify additional command parameters: -monotonic-cout : monotonic count -private-key : private k

[PATCH v8 02/12] tools: build mkeficapsule with tools-only_defconfig

2021-12-19 Thread AKASHI Takahiro
Add CONFIG_TOOLS_MKEFICAPSULE. Then we want to always build mkeficapsule if tools-only_defconfig is used. Signed-off-by: AKASHI Takahiro --- configs/tools-only_defconfig | 1 + tools/Kconfig| 8 tools/Makefile | 3 +-- 3 files changed, 10 insertions(+), 2 d

[PATCH v8 01/12] tools: mkeficapsule: rework the code a little bit

2021-12-19 Thread AKASHI Takahiro
Abstract common routines to make the code easily understandable. No functional change. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- tools/mkeficapsule.c | 223 ++- 1 file changed, 159 insertions(+), 64 deletions(-) diff --git a/tools/mkefi

[PATCH v8 00/12] efi_loader: capsule: improve capsule authentication support

2021-12-19 Thread AKASHI Takahiro
As I proposed and discussed in [1] and [2], I have made a couple of improvements on the current implementation of capsule update in this patch set. * add signing feature to mkeficapsule * add "--guid" option to mkeficapsule * add man page of mkeficapsule * update uefi document regarding capsule up

Re: [PATCH v5 21/28] efi: Support the efi command in the app

2021-12-19 Thread AKASHI Takahiro
On Fri, Dec 17, 2021 at 09:37:21AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Thu, 9 Dec 2021 at 13:27, Heinrich Schuchardt wrote: > > > > On 12/4/21 07:56, Simon Glass wrote: > > > At present the 'efi' command only works in the EFI payload. Update it to > > > work in the app too, so the mem

Re: [PATCH 3/3] bootstage: Enable SPL bootstage in sandbox_spl config

2021-12-19 Thread Marek Vasut
On 11/5/21 03:02, Simon Glass wrote: On Wed, 3 Nov 2021 at 08:20, Marek Vasut wrote: Enable SPL bootstage support in sandbox_spl config to detect build issues in CI. Signed-off-by: Marek Vasut Cc: Simon Glass --- configs/sandbox_spl_defconfig | 1 + 1 file changed, 1 insertion(+) Revi

Re: [PATCH 2/6] ARM: dts: imx6qdl-udoo: Properly describe the SD card detect

2021-12-19 Thread Fabio Estevam
Hi Peter, On Sun, Dec 19, 2021 at 12:54 PM Peter Robinson wrote: > > > GPIO7_IO00 is used as SD card detect. > > > > Properly describe this in the devicetree. > > Has this also been sent upstream for the Linux kernel dt? Yes, here it goes: http://lists.infradead.org/pipermail/linux-arm-kernel/20

Re: [RFC v2 11/20] dm: add event notification

2021-12-19 Thread Simon Glass
Hi Takahiro, On Tue, 14 Dec 2021 at 00:07, AKASHI Takahiro wrote: > > On Mon, Dec 13, 2021 at 05:51:46AM -0700, Simon Glass wrote: > > Hi Takahiro, > > > > On Fri, 10 Dec 2021 at 00:00, AKASHI Takahiro > > wrote: > > > > > > From: Simon Glass > > > > > > This is a draft implementation of event

[RESEND PATCH] Enable Fastboot(UUU) for O4-iMX6ULL-NANO boards

2021-12-19 Thread Oleh Kravchenko
Make O4-iMX6ULL-NANO-based board compatible with Yocto layer meta-out4 and fix device flashing by UUU (aka MFG Tools). Signed-off-by: Oleh Kravchenko --- arch/arm/dts/o4-imx-nano.dts | 4 ++-- configs/ev-imx280-nano-x-mb_defconfig | 5 + configs/o4-imx6ull-nano_defconfig | 5 +++

[PATCH] Enable Fastboot(UUU) for O4-iMX6ULL-NANO boards

2021-12-19 Thread Oleh Kravchenko
Make O4-iMX6ULL-NANO-based board compatible with Yocto layer meta-out4 and fix device flashing by UUU (aka MFG Tools). Signed-off-by: Oleh Kravchenko --- arch/arm/dts/o4-imx-nano.dts | 4 ++-- configs/ev-imx280-nano-x-mb_defconfig | 5 + configs/o4-imx6ull-nano_defconfig | 5 +++

Re: [PATCH v2 0/4] rockchip: Improve support for Bob chromebook and add support for Kevin

2021-12-19 Thread Simon Glass
Hi Alper, On Mon, 13 Dec 2021 at 15:15, Alper Nebi Yasak wrote: > > I have recently started testing booting U-Boot from SPI on my gru-kevin > (as opposed to chainloading it from vendor coreboot + depthcharge) and > brought it to a better working state based on an initial support patch > from Mart

[PATCH v2 1/1] fastboot: fb_getvar: Add getvar_logical_blocksize for NXP mfgtool

2021-12-19 Thread Angus Ainslie
NXP's mfgtool queies the mmc blocksize and splits a sparse image into blocksize size pieces for the upload. Signed-off-by: Angus Ainslie --- drivers/fastboot/fb_getvar.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_

[PATCH v2 0/1] Add more support for NXP's mfgtool

2021-12-19 Thread Angus Ainslie
NXP's mfgtool needs to query the block size for sparse image upload Changes since v1: * Dropped the "all" parition type patch * Added more detail to the patch commit message * Only define getvar_logical_blocksize when FASTBOOT_FLASH_MMC is defined * Combined fb_get_block_size into getvar_logical_

Re: [PATCH 2/6] ARM: dts: imx6qdl-udoo: Properly describe the SD card detect

2021-12-19 Thread Peter Robinson
> GPIO7_IO00 is used as SD card detect. > > Properly describe this in the devicetree. Has this also been sent upstream for the Linux kernel dt? > Signed-off-by: Fabio Estevam > --- > arch/arm/dts/imx6qdl-udoo.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arc

Re: [PATCH] fw_setenv: Unbreak fw_setenv caused by buggy MEMISLOCKED use

2021-12-19 Thread Joakim Tjernlund
On Sun, 2021-12-19 at 14:20 +, Ivan Mikhaylov wrote: > On Sat, 2021-12-18 at 18:23 +, Joakim Tjernlund wrote: > > Ping? > > Maybe just revert commit 8a726b852502 ("fw_setenv: lock the flash > > only if it was locked before") ? > > > > > > From: Joak

Re: [PATCH 1/2] fastboot: fb_getvar: Add getvar_logical_blocksize for MXP mfgtool

2021-12-19 Thread Angus Ainslie
Hi Sean, On 2021-12-17 15:10, Sean Anderson wrote: Hi Angus, On 12/17/21 10:41 AM, Angus Ainslie wrote: uuu uses the blocksize to determine the upload size Can you please elaborate on this more? Signed-off-by: Angus Ainslie --- drivers/fastboot/fb_getvar.c | 27

Re: Pull request for efi-2022-01-rc4-3

2021-12-19 Thread Tom Rini
On Sat, Dec 18, 2021 at 08:21:53PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit c03942ddc9e88d86d919504299905e4e8b0003cd: > > Merge commit '4720b83d2c711062cfb55f03591b8f12c897d7cb' of > https://github.com/tienfong/uboot_mainline (2021-12-17 07:24:56 -05

Please pull u-boot-marvell/next v2

2021-12-19 Thread Stefan Roese
Hi Tom, please pull the following Marvell MVEBU related patches into next, this time really against upstream next: - Armada XP etc: Move to DM_I2C (Stefan) - Some mvebu comphy + mox + fdt_support changes (Marek & Pali) - mvebu: a38

Re: [PATCH v2 5/5] net: Drop #ifdefs with CONFIG_BOOTP_SERVERIP

2021-12-19 Thread Ramon Fried
On Sat, Dec 18, 2021 at 8:28 PM Simon Glass wrote: > > Use IS_ENABLED() instead, to reduce the number of build paths. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/net.c | 4 +--- > net/bootp.c | 5 +++-- > net/net.c | 24 > 3 files changed