Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-01-21 Thread Tom Rini
On Sat, Jan 22, 2022 at 02:44:22AM +0100, Pali Rohár wrote: > On Friday 21 January 2022 16:21:33 Tom Rini wrote: > > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote: > > > > > If image backend provides verify_header callback then call it after > > > writing > > > image to disk. This

Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-01-21 Thread Pali Rohár
On Friday 21 January 2022 16:21:33 Tom Rini wrote: > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote: > > > If image backend provides verify_header callback then call it after writing > > image to disk. This ensures that written image is correct. > > > > Signed-off-by: Pali Rohár > >

Re: [PATCH 2/8] mailbox: apple: Add driver for Apple IOP mailbox

2022-01-21 Thread Simon Glass
On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > This mailbox driver provides a communication channel with the > Apple IOP controllers found on Apple SoCs. These IOP controllers > are used to implement various functions such as the System > Manegement Controller (SMC) and NVMe storage. It

Re: [PATCH 3/8] arm: apple: Add RTKit support

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > Most Apple IOPs run a firmware that is based on what Apple calls > RTKit. RTKit implements a common mailbox protocol. This code > provides an implementation of the AP side of this protocol, > providing a function to initialize

Re: [PATCH 2/2] input: apple: Add support for Apple SPI keyboard

2022-01-21 Thread Simon Glass
Hi Mark, On Sun, 16 Jan 2022 at 10:06, Mark Kettenis wrote: > > This driver adds support for the keyboard on Apple Silicon laptops. > The controller for this keyboard sits on an SPI bus and uses an > Apple-specific HID over SPI protocol. The packets sent by this > controller for key presses and

Re: [PATCH 1/2] spi: apple: Add driver for Apple SPI controller

2022-01-21 Thread Simon Glass
Hi Mark, On Sun, 16 Jan 2022 at 10:06, Mark Kettenis wrote: > > Add a driver for the SPI controller integrated on Apple SoCs. > This is necessary to support the keyboard on Apple Silicon laopts > since their keyboard uses an Apple-specific HID over SPI protocol. > > Signed-off-by: Mark Kettenis

Re: [PATCH 7/8] nvme: apple: Add driver for Apple NVMe storage controller

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > Add a driver for the NVMe storage controller integrated on > Apple SoCs. This NVMe controller isn't PCI based and deviates > from the NVMe standard in its implementation of the command > submission queue and the integration of an

Re: [PATCH 6/8] power: domain: apple: Add reset support

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > The power management controller found on Apple SoCs als provides > a way to reset all devices within a power domain. This is needed > to cleanly shutdown the NVMe controller before we hand over > control to the OS. > >

Re: [PATCH 5/8] nvme: Add shutdown function

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > Add a function to disable the NVMe controller. This will be used > to let the driver for the NVMe storage integrated on Apple SoCs > shutdown the NVMe controller such we can shutdown the NVMe > IOP controller in a clean way

Re: [PATCH 4/8] nvme: Introduce driver ops

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > The NVMe storage controller integrated on Apple SoCs deviates > from the NVMe standard in two aspects. It uses a "linear" > submission queue and it integrates an NVMMU that needs to be > programmed for each NVMe command. Introduce

Re: [PATCH 1/8] nvme: Split out PCI support

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 14 Jan 2022 at 04:05, Mark Kettenis wrote: > > Apple SoCs have an integrated NVMe controller that isn't connected > over a PCIe bus. In preparation for adding support for this NVMe > controller, split out the PCI support into its own file. This file > is selected through a new

[PATCH v4 2/4] efi: Use 16-bit unicode strings

2022-01-21 Thread Simon Glass
At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt Reviewed-by: Heinrich Schuchardt --- Changes in v4: -

[PATCH v4 4/4] treewide: Use 16-bit unicode strings

2022-01-21 Thread Simon Glass
At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Note: This applies tree-wide Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add a new patch to

[PATCH v4 3/4] sandbox: Detect the host bit size automatically

2022-01-21 Thread Simon Glass
At present if you build sandbox on a 32-bit host a lot of errors are produced. This is because CONFIG_HOST_64BIT is enabled by default. It is quite annoying to have to change that manually before building sandbox. It is also quite confusing for new users. Add a way to detect the setting and add

[PATCH v4 1/4] checkpatch: Support wide strings

2022-01-21 Thread Simon Glass
From: Joe Perches Allow prefixing typical strings with L for wide strings and u for unicode strings. Signed-off-by: Joe Perches Signed-off-by: Simon Glass --- This was found on LKML: https://lore.kernel.org/lkml/1508280192.6530.31.ca...@perches.com/T/ It likely wasn't applied because it did

[PATCH v4 0/4] Fix compiler warnings for 32-bit ARM

2022-01-21 Thread Simon Glass
These were noticed when building sandbox on a Raspberry Pi 400, which uses 32-bit linux. To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It would be nice if that were automatic, since we have the logic already in arch/sandbox/config.mk So this series adds that. It also

[PATCH 3/3] efi: Drop unnecessary calls to blk_find_device()

2022-01-21 Thread Simon Glass
When we have the block descriptor we can simply access the device. Drop the unnecessary function call. Signed-off-by: Simon Glass --- lib/efi_loader/efi_device_path.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/efi_loader/efi_device_path.c

[PATCH 2/3] efi: Use device_get_uclass_id() where appropriate

2022-01-21 Thread Simon Glass
Use this function rather than following the pointers, since it is there for this purpose. Add the uclass name to the debug call at the end of dp_fill() since it is quite useful. Signed-off-by: Simon Glass --- lib/efi_loader/efi_device_path.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH 1/3] efi: Add debugging to efi_set_bootdev()

2022-01-21 Thread Simon Glass
The operation of this function can be confusing. Add some debugging so we can see what it is doing and when it is called. Also drop the preprocessor usage. Signed-off-by: Simon Glass --- cmd/bootefi.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-)

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 14:46, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 02:15:24PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jan 2022 at 12:23, Tom Rini wrote: > > > > > > On Fri, Jan 21, 2022 at 12:14:22PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Heinrich, On Fri, 21 Jan 2022 at 15:05, Heinrich Schuchardt wrote: > > On 1/21/22 20:17, Simon Glass wrote: > > Hi Mark, > > > > On Fri, 21 Jan 2022 at 11:23, Mark Kettenis wrote: > >> > >>> From: Simon Glass > >>> Date: Fri, 21 Jan 2022 09:53:37 -0700 > >>> > >>> Hi Mark, > >>> > >>> On

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Heinrich Schuchardt
On 1/21/22 20:17, Simon Glass wrote: Hi Mark, On Fri, 21 Jan 2022 at 11:23, Mark Kettenis wrote: From: Simon Glass Date: Fri, 21 Jan 2022 09:53:37 -0700 Hi Mark, On Fri, 21 Jan 2022 at 09:03, Mark Kettenis wrote: From: Simon Glass Date: Fri, 21 Jan 2022 08:20:17 -0700 Hi, On Fri,

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 02:15:24PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jan 2022 at 12:23, Tom Rini wrote: > > > > On Fri, Jan 21, 2022 at 12:14:22PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jan 2022 at 11:09, Tom Rini wrote: > > > > > > > > On Fri, Jan 21,

Re: [PATCH v4 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-21 Thread Tony Dinh
Hi Pali and Stefan, On Fri, Jan 21, 2022 at 2:01 AM Pali Rohár wrote: > > On Thursday 20 January 2022 17:50:54 Tony Dinh wrote: > > diff --git a/board/cloudengines/pogo_v4/pogo_v4.c > > b/board/cloudengines/pogo_v4/pogo_v4.c > > new file mode 100644 > > index 00..c85de0b22e > > ---

Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-01-21 Thread Tom Rini
On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote: > If image backend provides verify_header callback then call it after writing > image to disk. This ensures that written image is correct. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese > Reviewed-by: Simon Glass > --- >

Re: [PATCH V2] phy: nop-phy: Enable reset-gpios support

2022-01-21 Thread Tom Rini
On Mon, Jan 17, 2022 at 05:45:59PM -0600, Adam Ford wrote: > Some usb-nop-xceiv devices use a gpio to put them in and > out of reset. Add a reset function to put them into that > state. This is similar to how Linux handles the > usb-nop-xceiv driver. > > Signed-off-by: Adam Ford > --- > V2:

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 12:23, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 12:14:22PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jan 2022 at 11:09, Tom Rini wrote: > > > > > > On Fri, Jan 21, 2022 at 09:02:13AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-21 Thread Angus Ainslie
On 2022-01-20 06:39, Jagan Teki wrote: On Thu, Jan 20, 2022 at 7:53 PM wrote: On 1/20/22 3:20 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> + { >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024,

Re: [PATCH 1/1] sandbox: eth-raw: fix building with musl library

2022-01-21 Thread Milan P . Stanić
Hi, it works and build pass without error or warning. Tested on alpine edge aarch64 bare metal. Thank you On Fri, 2022-01-21 at 18:01, Heinrich Schuchardt wrote: > The definition of struct udphdr in include netinet/udp.h in the > musl library differs from the definition in the glibc library. >

Re: [PATCH] sandbox: fix build failure with musl and SDL

2022-01-21 Thread Milan P . Stanić
Hi, it works and build pass without error or warning. Tested on alpine edge aarch64 bare metal. Thank you On Fri, 2022-01-21 at 18:00, Heinrich Schuchardt wrote: > sdl.c is compiled against the SDL library. > > Trying to redefine wchar_t with -fshort-wchar is not necessary > and leads to build

Re: [u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

2022-01-21 Thread Tom Rini
On Fri, Dec 03, 2021 at 08:52:38AM -0700, Simon Glass wrote: > Add a means of testing a coreboot + U-Boot build using qemu. > > Signed-off-by: Simon Glass Applied to u-boot-test-hooks/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 12:14:22PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jan 2022 at 11:09, Tom Rini wrote: > > > > On Fri, Jan 21, 2022 at 09:02:13AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jan 2022 at 08:31, Tom Rini wrote: > > > > > > > > On Fri, Jan 21,

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 21 Jan 2022 at 11:23, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Fri, 21 Jan 2022 09:53:37 -0700 > > > > Hi Mark, > > > > On Fri, 21 Jan 2022 at 09:03, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Fri, 21 Jan 2022 08:20:17 -0700 > > > > > > >

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 11:09, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 09:02:13AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jan 2022 at 08:31, Tom Rini wrote: > > > > > > On Fri, Jan 21, 2022 at 08:20:17AM -0700, Simon Glass wrote: > > > > Hi, > > > > > > > > On Fri,

Re: [PATCH v1 4/5] configs: Migrate CONFIG_SYS_MAX_FLASH_BANKS to Kconfig

2022-01-21 Thread Tom Rini
On Tue, Jan 04, 2022 at 02:24:00PM +0100, Patrick Delaunay wrote: > Use moveconfig.py script to convert define CONFIG_SYS_MAX_FLASH_BANKS > and CONFIG_SYS_MAX_FLASH_BANKS_DETECT to Kconfig and move these entries > to defconfigs. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass >

Re: [PATCH v2 3/5] Convert CONFIG_TIMESTAMP to Kconfig

2022-01-21 Thread Tom Rini
On Sat, Dec 18, 2021 at 11:27:50AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_TIMESTAMP > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 2/2] sunxi: Add option to prevent booting on power plug-in

2022-01-21 Thread Chris Morgan
On Fri, Jan 21, 2022 at 01:37:32PM +, Andre Przywara wrote: > From: Chris Morgan > > For sunxi boards with the AXP209, AXP221, AXP809, and AXP818 PMICs > (plus possibly others, I only confirmed the datasheets for these), > it is sometimes desirable to not boot whenever the device is >

Re: [PATCH v1 5/5] Convert CONFIG_AT91_EFLASH to Kconfig

2022-01-21 Thread Tom Rini
On Tue, Jan 04, 2022 at 02:24:01PM +0100, Patrick Delaunay wrote: > This converts the following to Kconfig: >CONFIG_AT91_EFLASH > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass > Reviewed-by: Stefan Roese > Acked-by: Eugen Hristev Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v1 3/5] mtd: cfi: change CONFIG_SYS_MAX_FLASH_BANKS_DETECT as boolean

2022-01-21 Thread Tom Rini
On Tue, Jan 04, 2022 at 02:23:59PM +0100, Patrick Delaunay wrote: > Prepare migration to Kconfig. > > CONFIG_SYS_MAX_FLASH_BANKS_DETECT becomes boolean and > CONFIG_SYS_MAX_FLASH_BANKS define the MAX size, also used > for detection when CONFIG_SYS_MAX_FLASH_BANKS_DETECT=y > (CFI_MAX_FLASH_BANKS

Re: [PATCH v1 2/5] mtd: cfi: introduce CFI_FLASH_BANKS

2022-01-21 Thread Tom Rini
On Tue, Jan 04, 2022 at 02:23:58PM +0100, Patrick Delaunay wrote: > Replace CONFIG_SYS_MAX_FLASH_BANKS by CFI_FLASH_BANKS to prepare > Kconfig migration and avoid to redefine CONFIG_SYS_MAX_FLASH_BANKS > in cfi_flash.h. > > After this patch CONFIG_SYS_MAX_FLASH_BANKS should be never used in >

Re: [PATCH v1 1/5] cmd: Fix up warnings in flash.c

2022-01-21 Thread Tom Rini
On Tue, Jan 04, 2022 at 02:23:57PM +0100, Patrick Delaunay wrote: > Tidy up the warnings reported by checkpatch.pl to prepare next patches > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH] spl: Convert SYS_MMCSD_RAW_MODE_KERNEL_SECTOR to Kconfig

2022-01-21 Thread Tom Rini
On Thu, Dec 30, 2021 at 10:39:59AM -0600, Alexandru Gagniuc wrote: > Falcon mode is very useful in improving boot speed. A question that > Falcon mode asks is "Where do I look for the kernel". With MMC boot > media, the correct answer is CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR. > The scope of

Re: [PATCH v2 5/5] net: Drop #ifdefs with CONFIG_BOOTP_SERVERIP

2022-01-21 Thread Tom Rini
On Sat, Dec 18, 2021 at 11:27:52AM -0700, Simon Glass wrote: > Use IS_ENABLED() instead, to reduce the number of build paths. > > Signed-off-by: Simon Glass > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 4/5] Convert CONFIG_BOOTP_SERVERIP to Kconfig

2022-01-21 Thread Tom Rini
On Sat, Dec 18, 2021 at 11:27:51AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_BOOTP_SERVERIP > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 2/5] Convert CONFIG_UDP_CHECKSUM to Kconfig

2022-01-21 Thread Tom Rini
On Sat, Dec 18, 2021 at 11:27:49AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_UDP_CHECKSUM > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/5] Convert CONFIG_KEEP_SERVERADDR to Kconfig

2022-01-21 Thread Tom Rini
On Sat, Dec 18, 2021 at 11:27:48AM -0700, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_KEEP_SERVERADDR > > Drop the preprocessor usage also. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 07:22:55PM +0100, Mark Kettenis wrote: > > From: Simon Glass > > Date: Fri, 21 Jan 2022 09:53:37 -0700 > > > > Hi Mark, > > > > On Fri, 21 Jan 2022 at 09:03, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Fri, 21 Jan 2022 08:20:17 -0700 > > > > > >

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Mark Kettenis
> From: Simon Glass > Date: Fri, 21 Jan 2022 09:53:37 -0700 > > Hi Mark, > > On Fri, 21 Jan 2022 at 09:03, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Fri, 21 Jan 2022 08:20:17 -0700 > > > > > > Hi, > > > > > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > > > > > On

Re: [PATCH v4] gitlab/azure: x86: Add a coreboot test

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 10:23:01AM -0700, Simon Glass wrote: > Coreboot supports U-Boot as a payload and this recently got a bit of a > facelist. Add a test for this. > > For now this uses a binary build of coreboot (v4.15). Future work could > potentially build it from source, but we need to

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 09:02:13AM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jan 2022 at 08:31, Tom Rini wrote: > > > > On Fri, Jan 21, 2022 at 08:20:17AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > > > > > On Wed, Jan 19, 2022

[PATCH v4] gitlab/azure: x86: Add a coreboot test

2022-01-21 Thread Simon Glass
Coreboot supports U-Boot as a payload and this recently got a bit of a facelist. Add a test for this. For now this uses a binary build of coreboot (v4.15). Future work could potentially build it from source, but we need to figure out the toolchain problems first, since coreboot uses its own

[PATCH 1/1] sandbox: eth-raw: fix building with musl library

2022-01-21 Thread Heinrich Schuchardt
The definition of struct udphdr in include netinet/udp.h in the musl library differs from the definition in the glibc library. To use the same definition with musl the symbol _GNU_SOURCE has to be defined. Reported-by: Milan P. Stanić Signed-off-by: Heinrich Schuchardt ---

[PATCH] sandbox: fix build failure with musl and SDL

2022-01-21 Thread Heinrich Schuchardt
sdl.c is compiled against the SDL library. Trying to redefine wchar_t with -fshort-wchar is not necessary and leads to build failures when compiling against musl. Cc: Milan P. Stanić Signed-off-by: Heinrich Schuchardt --- arch/sandbox/Makefile | 7 +++ arch/sandbox/cpu/Makefile | 11

Re: [PATCH] net: xilinx: fix the wrong dma base address issue

2022-01-21 Thread Michal Simek
čt 20. 1. 2022 v 9:42 odesílatel Andy Chiu napsal: > > From: Greentime Hu > > If we just use fdtdec_get_addr_size_fixed to get "reg" it will use > 64bit address cell to get the base address. > > soc { >#address-cells = <1>; >#size-cells = <1>; >compatible ="SiFive,FU500-soc",

Re: [PATCH v3] gitlab: x86: Add a coreboot test

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 07:54, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 08:43:25PM -0700, Simon Glass wrote: > > Coreboot supports U-Boot as a payload and this recently got a bit of a > > facelist. Add a test for this. > > > > For now this uses a binary build of coreboot (v4.15).

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 21 Jan 2022 at 09:03, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Fri, 21 Jan 2022 08:20:17 -0700 > > > > Hi, > > > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > > > On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > > > > On 1/19/22

Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs

2022-01-21 Thread Simon Glass
Hi Heinrich, On Fri, 21 Jan 2022 at 09:03, Heinrich Schuchardt wrote: > > On 1/21/22 16:20, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > wrote: > >> > >> Use "%pS" to print text representations of GUIDs. > >> > >> Signed-off-by: Heinrich

Re: [PATCH 1/1] sandbox: sandbox_serial_pending depends on DM_VIDEO

2022-01-21 Thread Simon Glass
On Fri, 21 Jan 2022 at 08:07, Heinrich Schuchardt wrote: > > When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error > occurs: > >in function `sandbox_serial_pending': >drivers/serial/sandbox.c:101: undefined reference to `video_sync_all' > > video_sync_all() is only

Re: [PATCH] vexpress64: semi_defconfig: disable CRC32 support

2022-01-21 Thread Marek Vasut
On 1/21/22 17:36, Andre Przywara wrote: Commit 270f8710f92f ("crc32: Add crc32 implementation using __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A cores support the instructions, and they are mandatory

Re: [PATCH v2 2/2] sunxi: Add option to prevent booting on power plug-in

2022-01-21 Thread Andre Przywara
On Fri, 21 Jan 2022 10:35:33 -0600 Chris Morgan wrote: Hi Chris, > On Fri, Jan 21, 2022 at 01:37:32PM +, Andre Przywara wrote: > > From: Chris Morgan > > > > For sunxi boards with the AXP209, AXP221, AXP809, and AXP818 PMICs > > (plus possibly others, I only confirmed the datasheets for

[PATCH] vexpress64: semi_defconfig: disable CRC32 support

2022-01-21 Thread Andre Przywara
Commit 270f8710f92f ("crc32: Add crc32 implementation using __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A cores support the instructions, and they are mandatory starting with architecture revision v8.1,

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Mark Kettenis
> From: Simon Glass > Date: Fri, 21 Jan 2022 08:20:17 -0700 > > Hi, > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > > > On 1/19/22 02:43, Simon Glass wrote: > > > > Add documentation for this feature, including

Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs

2022-01-21 Thread Heinrich Schuchardt
On 1/21/22 16:20, Simon Glass wrote: Hi Heinrich, On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: Use "%pS" to print text representations of GUIDs. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 160 ++--- include/efi_api.h

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 08:31, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 08:20:17AM -0700, Simon Glass wrote: > > Hi, > > > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > > > On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > > > > On 1/19/22 02:43, Simon

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 08:20:17AM -0700, Simon Glass wrote: > Hi, > > On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > > > On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > > > On 1/19/22 02:43, Simon Glass wrote: [snip] > > > > +Introduction > > > > + > > > >

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-21 Thread Simon Glass
Hi Mark, On Fri, 21 Jan 2022 at 02:36, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Thu, 20 Jan 2022 20:12:41 -0700 > > > > Hi Tom, > > > > On Thu, 20 Jan 2022 at 18:08, Tom Rini wrote: > > > > > > On Thu, Jan 20, 2022 at 05:59:53PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > >

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jan 2022 at 08:05, Tom Rini wrote: > > On Thu, Jan 20, 2022 at 08:12:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jan 2022 at 18:08, Tom Rini wrote: > > > > > > On Thu, Jan 20, 2022 at 05:59:53PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH 2/2] tools/fitimage: make sure dumpimage still works when "@" are detected

2022-01-21 Thread Simon Glass
On Mon, 10 Jan 2022 at 10:48, Stefan Eichenberger wrote: > > fit_verify_header fails if it detects unit addresses "@". However, this > will break tools like dumpimage on fit images which worked with previous > versions of the tool (e.g. 2020.04 vs 2021.07). As an example the output > of: >

Re: [PATCH] scripts: setlocalversion: remove quotes around localversion from config

2022-01-21 Thread Simon Glass
On Thu, 13 Jan 2022 at 20:38, Nikita Maslov wrote: > > From: Nikita Maslov > Date: Fri, 14 Jan 2022 00:13:39 +0300 > Subject: [PATCH] scripts: setlocalversion: remove quotes around > localversion from config > > After replacing of include/config/auto.conf sourcing with > extraction of

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-01-21 Thread Simon Glass
On Tue, 4 Jan 2022 at 00:42, Patrice Chotard wrote: > > When OF_LIVE flag is enabled on a 64 bits platform, there is an > issue when dev_read_addr() is called and need to perform an address > translation using __of_translate_address(). > > In case of error, __of_translate_address() return's value

Re: [resent][PATCH 1/3] image-fit: Make string of algo parameter constant

2022-01-21 Thread Simon Glass
On Fri, 14 Jan 2022 at 02:21, Jan Kiszka wrote: > > From: Jan Kiszka > > Modifications would be invalid. > > Signed-off-by: Jan Kiszka > --- > boot/image-fit-sig.c | 2 +- > boot/image-fit.c | 8 > include/image.h | 2 +- > tools/image-host.c | 4 ++-- > 4 files changed, 8

Re: [PATCH v1] serial: npcm: Add support for Nuvoton NPCM SoCs

2022-01-21 Thread Simon Glass
Hi Stanley, On Sun, 16 Jan 2022 at 20:20, Stanley Chu wrote: > > Add Nuvoton BMC NPCM7xx/NPCM8xx uart driver > > Signed-off-by: Stanley Chu > --- > drivers/serial/Kconfig | 7 ++ > drivers/serial/Makefile | 1 + > drivers/serial/serial_npcm.c | 151

Re: [resent][PATCH 3/3] mkimage: Allow to specify the signature algorithm on the command line

2022-01-21 Thread Simon Glass
Hi Jan, On Fri, 14 Jan 2022 at 02:21, Jan Kiszka wrote: > > From: Jan Kiszka > > This permits to prepare FIT image description that do not hard-code the > final choice of the signature algorithm, possibly requiring the user to > patch the sources. > > When -o is specified, this information is

Re: [resent][PATCH 2/3] mkimage: Drop unused OPT_STRING constant

2022-01-21 Thread Simon Glass
On Fri, 14 Jan 2022 at 02:21, Jan Kiszka wrote: > > From: Jan Kiszka > > The actual opt string is inlined - and different. Seems this was a > left-over from older versions of 603e26f76346. > > Signed-off-by: Jan Kiszka > --- > tools/mkimage.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH 8/8] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 08:48:05PM +0530, Vignesh Raghavendra wrote: > > > On 21/01/22 8:27 pm, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 09:59:21AM +0530, Vignesh Raghavendra wrote: > >> > >> > >> On 17/01/22 8:47 am, Tom Rini wrote: > >>> On Fri, Dec 24, 2021 at 12:55:36PM +0530, Vignesh

Re: [PATCH 7/8] efi_loader: user %pUs for printing GUIDs

2022-01-21 Thread Simon Glass
On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > For printing GUIDs with macro EFI_ENTRY use %pUs instead of %pUl to provide > readable debug output. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 26 +- >

Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs

2022-01-21 Thread Simon Glass
Hi Heinrich, On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > Use "%pS" to print text representations of GUIDs. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/efidebug.c | 160 ++--- > include/efi_api.h | 8 +++ >

Re: [PATCH 5/8] test: add test for %pUs

2022-01-21 Thread Simon Glass
On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > Add a unit test for the %pUs printf code. > > Use ut_asserteq_str() for checking string results. > > Signed-off-by: Heinrich Schuchardt > --- > test/print_ut.c | 20 > 1 file changed, 16 insertions(+), 4

Re: [PATCH 4/8] sandbox: imply PARTITION_TYPE_GUID

2022-01-21 Thread Simon Glass
On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > CONFIG_PARTITION_TYPE_GUID=y is needed for testing some GPT related GPT-related > functionality. > > Signed-off-by: Heinrich Schuchardt > --- > arch/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass

Re: [PATCH 3/8] disk: simplify part_print_efi()

2022-01-21 Thread Simon Glass
On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > Use printf code %pUs to print the text representation of the partition type > GUID. > > Signed-off-by: Heinrich Schuchardt > --- > disk/part_efi.c | 21 - > 1 file changed, 8 insertions(+), 13 deletions(-)

Re: [PATCH 1/8] lib: compile uuid_guid_get_str if CONFIG_LIB_UUID=y

2022-01-21 Thread Simon Glass
On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt wrote: > > Currently uuid_guid_get_str() is only built if > CONFIG_PARTITION_TYPE_GUID=y. > > To make it usable for other GUIDs compile it if CONFIG_LIB_UUID=y. > The linker will take care of removing it if it is unused. > > Signed-off-by:

Re: [PATCH] spi: Add spi_get_bus_and_cs() new use_dt param

2022-01-21 Thread Simon Glass
Hi Patrice, On Wed, 12 Jan 2022 at 03:59, Patrice Chotard wrote: > > Add spi_flash_probe_bus_cs() and spi_get_bus_and_cs() new "use_dt" > param which allows to select SPI speed and mode from DT or from > default value passed in parameters. > > Since commit e2e95e5e2542 ("spi: Update speed/mode

Re: [PATCH 1/2] tools/fitimage: remove redundant format check

2022-01-21 Thread Simon Glass
On Mon, 10 Jan 2022 at 10:48, Stefan Eichenberger wrote: > > fit_extract_contents does a fit_check_format even thought it was already > checked during imagetool_verify_print_header. > Therefore, this check is not necessary. This commit removes the > redundancy. > > Signed-off-by: Stefan

Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-21 Thread Simon Glass
Hi Alper, On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak wrote: > > The Rockchip RK3399 eMMC PHY has to be power-cycled while changing its > clock speed to some higher speeds. This is dependent on the desired > SDHCI clock speed, and it looks like the PHY should be powered off while > setting

Re: [PATCH v2 1/4] mmc: sdhci: Add HS400 Enhanced Strobe support

2022-01-21 Thread Simon Glass
Hi Alper, On Tue, 11 Jan 2022 at 06:39, Alper Nebi Yasak wrote: > > Delegate setting the Enhanced Strobe configuration to individual drivers > if they set a function for it. Return -ENOTSUPP if they do not, like > what the MMC uclass does. > > Signed-off-by: Alper Nebi Yasak > Reviewed-by:

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Simon Glass
Hi, On Fri, 21 Jan 2022 at 08:08, Tom Rini wrote: > > On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > > On 1/19/22 02:43, Simon Glass wrote: > > > Add documentation for this feature, including the commands and full > > > devicetree bindings. > > > > > > Signed-off-by:

Re: [PATCH 8/8] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot

2022-01-21 Thread Vignesh Raghavendra
On 21/01/22 8:27 pm, Tom Rini wrote: > On Fri, Jan 21, 2022 at 09:59:21AM +0530, Vignesh Raghavendra wrote: >> >> >> On 17/01/22 8:47 am, Tom Rini wrote: >>> On Fri, Dec 24, 2021 at 12:55:36PM +0530, Vignesh Raghavendra wrote: >>> Enable config options needed to support Ethernet boot on

Re: [PATCH v3 30/31] bootstd: doc: Add documentation

2022-01-21 Thread Tom Rini
On Wed, Jan 19, 2022 at 12:39:03PM +0100, Heinrich Schuchardt wrote: > On 1/19/22 02:43, Simon Glass wrote: > > Add documentation for this feature, including the commands and full > > devicetree bindings. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v3: > > - Update docs for

[PATCH 1/1] sandbox: sandbox_serial_pending depends on DM_VIDEO

2022-01-21 Thread Heinrich Schuchardt
When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error occurs: in function `sandbox_serial_pending': drivers/serial/sandbox.c:101: undefined reference to `video_sync_all' video_sync_all() is only defined if we have CONFIG_DM_VIDEO=y. Calling this function in a serial

Re: [PATCH v3 31/31] RFC: Switch rpi over to use bootstd

2022-01-21 Thread Tom Rini
On Thu, Jan 20, 2022 at 08:12:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jan 2022 at 18:08, Tom Rini wrote: > > > > On Thu, Jan 20, 2022 at 05:59:53PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 20 Jan 2022 at 16:23, Tom Rini wrote: > > > > > > > > On Thu, Jan 20,

Re: [PATCH 8/8] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot

2022-01-21 Thread Tom Rini
On Fri, Jan 21, 2022 at 09:59:21AM +0530, Vignesh Raghavendra wrote: > > > On 17/01/22 8:47 am, Tom Rini wrote: > > On Fri, Dec 24, 2021 at 12:55:36PM +0530, Vignesh Raghavendra wrote: > > > >> Enable config options needed to support Ethernet boot on AM64x SK. > >> > >> Signed-off-by: Vignesh

Re: [PATCH v3] gitlab: x86: Add a coreboot test

2022-01-21 Thread Tom Rini
On Thu, Jan 20, 2022 at 08:43:25PM -0700, Simon Glass wrote: > Coreboot supports U-Boot as a payload and this recently got a bit of a > facelist. Add a test for this. > > For now this uses a binary build of coreboot (v4.15). Future work could > potentially build it from source, but we need to

[PATCH v2 2/2] sunxi: Add option to prevent booting on power plug-in

2022-01-21 Thread Andre Przywara
From: Chris Morgan For sunxi boards with the AXP209, AXP221, AXP809, and AXP818 PMICs (plus possibly others, I only confirmed the datasheets for these), it is sometimes desirable to not boot whenever the device is plugged in. An example would be when using the NTC CHIP inside a PocketCHIP. This

[PATCH v2 1/2] pmic: axp: define ALDO_IN startup bit

2022-01-21 Thread Andre Przywara
Most AXP PMICs feature a "startup source" register, which keeps information about how the PMIC started operation. Bit 0 in there means it has been started by "plugging in the power cable". Define a symbol in each PMIC's header file to be able to use that register and bit later on. Signed-off-by:

[PATCH v2 0/2] sunxi: Add option to prevent boot on plug-in

2022-01-21 Thread Andre Przywara
Sometimes it is desirable to prevent a board from automatically booting as soon as the power cable is plugged in. For boards with an AXP PMIC, we can actually query the power up source. Add a AXP_DISABLE_BOOT_ON_POWERON Kconfig option to enable this behaviour. Patch 1 prepares the PMIC header

Re: [RFC PATCH v3 6/9] FWU: Add boot time checks as highlighted by the FWU specification

2022-01-21 Thread Ilias Apalodimas
Hi Sughosh [...] > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +static u8 trial_state = 0; > +static u8 boottime_check = 0; > + > +static int fwu_trial_state_check(void) > +{ > + int ret, i; > + efi_status_t status; > +

Re: [RFC PATCH v3 9/9] mkeficapsule: Add support for generating empty capsules

2022-01-21 Thread Ilias Apalodimas
Hi Sughosh, On Thu, Jan 20, 2022 at 12:25:48AM +0530, Sughosh Ganu wrote: > The Dependable Boot specification describes the structure of the > firmware accept and revert capsules. These are empty capsules which > are used for signalling the acceptance or rejection of the updated > firmware by

Re: [RFC PATCH v3 3/9] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-01-21 Thread Ilias Apalodimas
Hi Sughosh, [...] > } > > U_BOOT_FIT_LOADABLE_HANDLER(IH_TYPE_COPRO, board_copro_image_process); > + > +#if defined(CONFIG_FWU_MULTI_BANK_UPDATE) > +#include > +#include > + > +static int gpt_plat_get_alt_num(int dev_num, void *identifier) > +{ > + int i; > + int ret = -1; > +

[PATCH] arm: mvebu: Espressobin: Fix URLs in comments

2022-01-21 Thread Pali Rohár
Use versioned URLs for line numbers as branches are moving in the time and use master branch for mv-ddr-marvell where is up-to-date code. Signed-off-by: Pali Rohár --- board/Marvell/mvebu_armada-37xx/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-21 Thread Sughosh Ganu
On Thu, 20 Jan 2022 at 16:57, Heinrich Schuchardt wrote: > > On 1/19/22 19:55, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, on a separate > > partition. Add functions for reading from and writing to

  1   2   >