Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-16 Thread Michal Simek
On 2/17/22 01:43, Ricardo Salveti wrote: On Tue, Feb 15, 2022 at 12:39 PM Michal Simek wrote: On 2/15/22 16:02, Sean Anderson wrote: On 2/15/22 8:54 AM, Michal Simek wrote: Hi, On 2/15/22 14:27, Jorge Ramirez-Ortiz, Foundries wrote: On 15/02/22, Michal Simek wrote: Hi, On 2/14/22

Re: [PATCH u-boot-marvell 0/7] tools: kwbimage: Support for parsing extended v0 format

2022-02-16 Thread Stefan Roese
Hi Pali, On 2/15/22 19:59, Pali Rohár wrote: This patch series extends kwbimage v0 format support by providing ability to dump content of Dove boot images (extension of v0 format). It also fixes recognition of these images in kwboot utility (as it uses macros and inline functions from

Re: [PATCH u-boot-marvell 2/2] arm: mvebu: turris_omnia: Reset the board immediately on DDR training failure

2022-02-16 Thread Stefan Roese
On 2/17/22 01:08, Marek Behún wrote: From: Marek Behún The state of the current DDR training code for Armada 38x is such that we cannot be sure it will always train successfully - although after the last change we were yet unable to find a board that failed DDR training, from experience in the

Re: [PATCH u-boot-marvell 1/2] arm: mvebu: spl: Add option to reset the board on DDR training failure

2022-02-16 Thread Stefan Roese
On 2/17/22 01:08, Marek Behún wrote: From: Marek Behún Some boards may occacionally fail DDR training. Currently we hang() in this case. Add an option that makes the board do an immediate reset in such a case, so that a new training is tried as soon as possible, instead of hanging and possibly

Re: kwboot: Marvell Dove UART booting

2022-02-16 Thread Tony Dinh
Hi Pali, Please see below. On Tue, Feb 15, 2022 at 3:02 PM Pali Rohár wrote: > > Hello! > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > *** With jumper inserted, serial console connected, start serial console > > > > # picocom --b 115200 --f n --p n --d 8 /dev/ttyUSB0 > >

[PATCH] tools: pblimage: fix image header verification function

2022-02-16 Thread Zhiqiang Hou
From: Hou Zhiqiang The Layerscape platforms have different RCW header value from FSL PowerPC platforms, the current image header verification callback is only working on PowerPC, it will fail on Layerscape, this patch is to fix this issue. This is a historical problem and exposed by the

Re: [PATCH v1 2/9] clk: nuvoton: Add support for NPCM845

2022-02-16 Thread Stanley
Hi Tom, Thanks for the reminder. I made a big change on clk driver and will submit the new patch later. -- Stanley Tom Rini 於 2022年2月17日 週四 上午12:25 寫道: > > On Wed, Dec 15, 2021 at 10:57:53AM +0800, Stanley Chu wrote: > > > Add clock controller driver for NPCM845 > > > > Signed-off-by: Stanley

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Masami Hiramatsu
Hi Simon, Let me confirm your point. So are you concerning the 'real' reset for the capsule update test case itself or this patch? I'm actually learning how the test is working, so please help me to understand how I can solve it. There are 3 environments to run the test, sandbox, Qemu, and a

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-16 Thread Ricardo Salveti
On Tue, Feb 15, 2022 at 12:39 PM Michal Simek wrote: > On 2/15/22 16:02, Sean Anderson wrote: > > On 2/15/22 8:54 AM, Michal Simek wrote: > >> Hi, > >> > >> On 2/15/22 14:27, Jorge Ramirez-Ortiz, Foundries wrote: > >>> On 15/02/22, Michal Simek wrote: > Hi, > > On 2/14/22 21:10,

Re: [PATCH 0/3] gpio: Add AST2[456]00 GPIO driver

2022-02-16 Thread Andrew Jeffery
On Wed, 16 Feb 2022, at 19:02, Ryan Chen wrote: > Hello Andrew, > This patch series are ok, Please help add Reviewed-by: Ryan Chen > Thanks Ryan. This is all that's necessary! Andrew

Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary

2022-02-16 Thread Fabio Estevam
Hi Bough, On Sun, Feb 13, 2022 at 11:58 PM Bough Chen wrote: > > Hi Fabio, > > Can you help test these 3 patches on imx6qdl-pico board or imx7s board on > your side to double check whether these patches enlarge the total boot time? I have tested the series on an imx7s-warp and the previous

[PATCH u-boot-marvell 2/2] arm: mvebu: turris_omnia: Reset the board immediately on DDR training failure

2022-02-16 Thread Marek Behún
From: Marek Behún The state of the current DDR training code for Armada 38x is such that we cannot be sure it will always train successfully - although after the last change we were yet unable to find a board that failed DDR training, from experience in the last 2 years we know that it is

[PATCH u-boot-marvell 1/2] arm: mvebu: spl: Add option to reset the board on DDR training failure

2022-02-16 Thread Marek Behún
From: Marek Behún Some boards may occacionally fail DDR training. Currently we hang() in this case. Add an option that makes the board do an immediate reset in such a case, so that a new training is tried as soon as possible, instead of hanging and possibly waiting for watchdog to reset the

[PATCH u-boot-marvell] ddr: marvell: a38x: fix BYTE_HOMOGENEOUS_SPLIT_OUT decision

2022-02-16 Thread Marek Behún
From: Marek Behún In commit 3fc92a215b69 ("ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision") I ported a cleaned up and changed version of patch mv_ddr: a380: fix SPLIT_OUT_MIX state decision In the port we removed checking for BYTE_HOMOGENEOUS_SPLIT_OUT bit, because: - the fix seemed to

Re: bind/unbind command not working for usb_ether

2022-02-16 Thread Tim Harvey
On Wed, Feb 16, 2022 at 12:23 AM Patrice CHOTARD wrote: > > Hi Tim > > On 2/15/22 19:28, Tim Harvey wrote: > > On Tue, Feb 15, 2022 at 9:36 AM Patrice CHOTARD > > wrote: > >> > >> Hi Tim > >> > >> On 2/15/22 17:09, Tim Harvey wrote: > >>> On Tue, Feb 15, 2022 at 5:29 AM Patrice CHOTARD > >>>

[PATCH] cmd: abootimg: Accept a DTB in second for index 0

2022-02-16 Thread Linus Walleij
If the user is using an old Android image (version < 2) there are no special DTB pointers. What systems do in this case is to use the "second" area for a DTB, and this is what bootm is falling back to when booting and abootimg, see image-fdt.c function boot_get_fdt(). So since I need this on some

[PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO

2022-02-16 Thread Pali Rohár
--- I had to comment "return -ENOSPC;" in video-uclass.c because without it DM_VIDEO does not work and I do not know why. This looks like either false-positive test or a bug in DM_VIDEO code. I have already set PRE_RELOC flag but it has no effect on that code. Second thing is that

[PULL] u-boot-usb/master

2022-02-16 Thread Marek Vasut
The following changes since commit ab8903a24db11571d634ef255976bb364c3ba64d: configs: Resync with savedefconfig (2022-02-14 22:21:29 +) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to fetch changes up to

[PATCH] fdtdec.h: Remove gurads around fdtdec_resetup function

2022-02-16 Thread Tom Rini
This function has not been conditionally compiled for some time, so remove the incorrect guards around the declaration. Signed-off-by: Tom Rini --- include/fdtdec.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/fdtdec.h b/include/fdtdec.h index 4b0b505773dd..12355afd7fa1 100644

Re: [PATCH] dm: core: fix uclass_get_by_name

2022-02-16 Thread Tim Harvey
On Wed, Feb 16, 2022 at 11:00 AM Simon Glass wrote: > > Hi Tim, > > On Wed, 16 Feb 2022 at 08:57, Tim Harvey wrote: > > > > When calling uclass_get_by_name we want to do a full match on the uclass > > name, not a partial match. > > > > Signed-off-by: Tim Harvey > > --- > >

Re: [PATCH v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model

2022-02-16 Thread Simon Glass
Hi Takahiro, On Wed, 16 Feb 2022 at 01:31, AKASHI Takahiro wrote: > > Hi Simon, > > On Mon, Feb 14, 2022 at 11:35:06AM +0900, AKASHI Takahiro wrote: > > Heinrich, > > > > On Thu, Feb 10, 2022 at 04:20:11PM +0100, Heinrich Schuchardt wrote: > > > On 2/10/22 09:11, AKASHI Takahiro wrote: > > > >

Re: [PATCH] dm: core: fix uclass_get_by_name

2022-02-16 Thread Simon Glass
Hi Tim, On Wed, 16 Feb 2022 at 08:57, Tim Harvey wrote: > > When calling uclass_get_by_name we want to do a full match on the uclass > name, not a partial match. > > Signed-off-by: Tim Harvey > --- > drivers/core/uclass.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) >

Re: [PATCH v1] imx: imx8qm: cgtqmx8: switch to binman

2022-02-16 Thread Simon Glass
On Wed, 16 Feb 2022 at 07:02, Oliver Graute wrote: > > Switch to use binman to pack images > > Signed-off-by: Oliver Graute > --- > arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + > arch/arm/mach-imx/imx8/Kconfig | 1 + > board/congatec/cgtqmx8/imximage.cfg | 4 ++-- > configs/cgtqmx8_defconfig

Re: make mrproper deletes lib/acpi/dsdt.c

2022-02-16 Thread Simon Glass
+Heinrich Schuchardt who noticed the same thing We should know the pathname of the generated dsdt.c file so perhaps we should delete it explicitly? - Simon On Fri, 4 Feb 2022 at 08:34, Simon Glass wrote: > > Hi Marcel, > > On Fri, 4 Feb 2022 at 03:10, Marcel Ziswiler > wrote: > > > > Hi

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Simon Glass
Hi Heinrich, On Wed, 16 Feb 2022 at 10:50, Heinrich Schuchardt wrote: > > On 2/16/22 16:46, Tom Rini wrote: > > On Wed, Feb 16, 2022 at 04:32:40PM +0100, Heinrich Schuchardt wrote: > >> On 2/16/22 16:26, Simon Glass wrote: > >>> Hi Masami, > >>> > >>> On Tue, 15 Feb 2022 at 02:05, Masami

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Tom Rini
On Wed, Feb 16, 2022 at 06:45:32PM +0100, Heinrich Schuchardt wrote: > On 2/16/22 16:46, Tom Rini wrote: > > On Wed, Feb 16, 2022 at 04:32:40PM +0100, Heinrich Schuchardt wrote: > > > On 2/16/22 16:26, Simon Glass wrote: > > > > Hi Masami, > > > > > > > > On Tue, 15 Feb 2022 at 02:05, Masami

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Simon Glass
Hi Heinrich, On Wed, 16 Feb 2022 at 08:37, Heinrich Schuchardt wrote: > > On 2/16/22 16:26, Simon Glass wrote: > > Hi Masami, > > > > On Tue, 15 Feb 2022 at 02:05, Masami Hiramatsu > > wrote: > >> > >> Since now the capsule_on_disk will restart the u-boot sandbox right > >> after the capsule

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Heinrich Schuchardt
On 2/16/22 16:46, Tom Rini wrote: On Wed, Feb 16, 2022 at 04:32:40PM +0100, Heinrich Schuchardt wrote: On 2/16/22 16:26, Simon Glass wrote: Hi Masami, On Tue, 15 Feb 2022 at 02:05, Masami Hiramatsu wrote: Since now the capsule_on_disk will restart the u-boot sandbox right after the capsule

Re: [PATCH v1 2/9] clk: nuvoton: Add support for NPCM845

2022-02-16 Thread Tom Rini
On Wed, Dec 15, 2021 at 10:57:53AM +0800, Stanley Chu wrote: > Add clock controller driver for NPCM845 > > Signed-off-by: Stanley Chu > --- > drivers/clk/Makefile | 1 + > drivers/clk/nuvoton/Makefile | 1 + > drivers/clk/nuvoton/clk_npcm8xx.c |

[PATCH] dm: core: fix uclass_get_by_name

2022-02-16 Thread Tim Harvey
When calling uclass_get_by_name we want to do a full match on the uclass name, not a partial match. Signed-off-by: Tim Harvey --- drivers/core/uclass.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index

Re: [PATCH 2/2] usb: dwc3: core: stop the core when it's removed

2022-02-16 Thread Marek Vasut
On 2/16/22 08:37, Bin Meng wrote: On Thu, Feb 3, 2022 at 7:09 AM Angus Ainslie wrote: If u-boot doesn't stop the core when it's finished with it then linux can't find it. Signed-off-by: Angus Ainslie --- drivers/usb/dwc3/core.c | 9 + 1 file changed, 9 insertions(+)

Re: [PATCH 1/2] usb: dwc3: dwc3-generic: check the parent nodes

2022-02-16 Thread Marek Vasut
On 2/16/22 08:37, Bin Meng wrote: On Thu, Feb 3, 2022 at 7:09 AM Angus Ainslie wrote: The kernel devicetree has definitions for port and hub nodes as subnodes to the USB devices. These subnodes don't contain all of the data required to properly configure the dwc3. Check the parent nodes if

Re: [PATCH] usb: xhci: reset endpoint on USB stall

2022-02-16 Thread Marek Vasut
On 2/16/22 08:53, Bin Meng wrote: On Mon, Sep 27, 2021 at 8:43 PM Stefan Agner wrote: There are devices which cause a USB stall when trying to read strings. Specifically Arduino Mega R3 stalls when trying to read the product string. The stall currently remains unhandled, and subsequent

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Tom Rini
On Wed, Feb 16, 2022 at 04:32:40PM +0100, Heinrich Schuchardt wrote: > On 2/16/22 16:26, Simon Glass wrote: > > Hi Masami, > > > > On Tue, 15 Feb 2022 at 02:05, Masami Hiramatsu > > wrote: > > > > > > Since now the capsule_on_disk will restart the u-boot sandbox right > > > after the capsule

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Heinrich Schuchardt
On 2/16/22 16:26, Simon Glass wrote: Hi Masami, On Tue, 15 Feb 2022 at 02:05, Masami Hiramatsu wrote: Since now the capsule_on_disk will restart the u-boot sandbox right after the capsule update, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=y, the boot with a new capsule file will repeat reboot

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-02-16 Thread Simon Glass
Hi Masami, On Tue, 15 Feb 2022 at 02:05, Masami Hiramatsu wrote: > > Since now the capsule_on_disk will restart the u-boot sandbox right > after the capsule update, if CONFIG_EFI_CAPSULE_ON_DISK_EARLY=y, the > boot with a new capsule file will repeat reboot sequence. On the > other hand, if

[PATCH] kontron-pitx-imx8m: fix board_mmc_getcd()

2022-02-16 Thread Heiko Thiery
The function wrongly will return the card detection status of the SD card (USDHC2) for the eMMC (USDHC1). Thus booting from eMMC without an inserted SD card will fail. Signed-off-by: Heiko Thiery --- board/kontron/pitx_imx8m/spl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-16 Thread Michal Simek
On 2/16/22 13:59, Rafał Miłecki wrote: On 15.02.2022 15:57, Sean Anderson wrote: On 2/15/22 9:02 AM, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be

[PATCH] cmd: eeprom: Do not rewrite EEPROM I2C bus with DM I2C enabled

2022-02-16 Thread Marek Vasut
With DM I2C, the EEPROM bus has been correctly configured in eeprom_execute_command() already. Do not reconfigure it here with hard-coded bus number again. Signed-off-by: Marek Vasut Cc: Heiko Schocher Cc: Tom Rini --- cmd/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-16 Thread Michal Simek
On 2/16/22 13:54, Rafał Miłecki wrote: On 15.02.2022 15:02, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often

Re: [PATCH] binman: Include also subnodes in generator nodes

2022-02-16 Thread Simon Glass
Hi Jan, On Mon, 14 Feb 2022 at 05:05, Jan Kiszka wrote: > > From: Jan Kiszka > > This allows to prefill fdt and config nodes with hash and signature > subnodes. It's just important to place the child nodes last so that > hashes do not come before the data - would be disliked by mkimage. > >

RE: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-02-16 Thread Z.Q. Hou
> -Original Message- > From: Pali Rohár > Sent: 2022年2月16日 3:52 > To: Priyanka Jain > Cc: Tom Rini ; Alison Wang ; > Mingkai Hu ; Rajesh Bhagat > ; Jiafei Pan ; Simon Glass > ; Alexandru Gagniuc ; Yann > Dirson ; Stefan Roese ; Marek > Behún ; u-boot@lists.denx.de > Subject: Re: [PATCH

[PATCH v1] imx: imx8qm: cgtqmx8: switch to binman

2022-02-16 Thread Oliver Graute
Switch to use binman to pack images Signed-off-by: Oliver Graute --- arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + arch/arm/mach-imx/imx8/Kconfig | 1 + board/congatec/cgtqmx8/imximage.cfg | 4 ++-- configs/cgtqmx8_defconfig | 2 +- doc/board/congatec/cgtqmx8.rst | 3 +-- 5

Re: [PATCH u-boot-marvell RFC] PLEASE TEST: ddr: marvell: a38x: fix BYTE_HOMOGENEOUS_SPLIT_OUT decision

2022-02-16 Thread Stefan Roese
On 2/16/22 14:26, Marek Behún wrote: On Wed, 16 Feb 2022 09:41:44 +0100 Stefan Roese wrote: On 2/15/22 23:21, Chris Packham wrote: On Fri, Feb 11, 2022 at 5:25 AM Marek Behún wrote: From: Marek Behún In commit 3fc92a215b69 ("ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision") I

Re: [PATCH u-boot-marvell RFC] PLEASE TEST: ddr: marvell: a38x: fix BYTE_HOMOGENEOUS_SPLIT_OUT decision

2022-02-16 Thread Marek Behún
On Wed, 16 Feb 2022 09:41:44 +0100 Stefan Roese wrote: > On 2/15/22 23:21, Chris Packham wrote: > > On Fri, Feb 11, 2022 at 5:25 AM Marek Behún wrote: > >> > >> From: Marek Behún > >> > >> In commit 3fc92a215b69 ("ddr: marvell: a38x: fix SPLIT_OUT_MIX state > >> decision") I ported a cleaned

Boot logging to file in ESP

2022-02-16 Thread Tom Hale
Can U-Boot log its output to file? I'm a digital nomad operating a RPi 4B headless. I have 2 boot USB keys: one "known-good", and one for experimentation. Plugging into a monitor (which I don't have in my backpack) isn't trivial. Is there a way to have U-Boot write all output to a file on

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-16 Thread Rafał Miłecki
On 15.02.2022 15:57, Sean Anderson wrote: On 2/15/22 9:02 AM, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often

Re: [PATCH] dt-bindings: nvmem: add U-Boot environment variables binding

2022-02-16 Thread Rafał Miłecki
On 15.02.2022 15:02, Michal Simek wrote: On 2/15/22 14:49, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data on flash. That data usually needs to be accessed by a bootloader, kernel and often user-space. This binding allows describing

[PATCH] kontron-pitx-imx8m: change environment address variables

2022-02-16 Thread Heiko Thiery
Currently the space between kernel_addr_r and the fdt_addr_r is only 32MB. To have enought space to load kernel images bigger than 32MB change the variables to a feasible value. The new environment variables layout is based on the scheme from "include/configs/ti_armv7_common.h". The

[PATCH v2] kontron-sl-mx8mm: change environment address variables

2022-02-16 Thread Heiko Thiery
Currently the space between kernel_addr_r and the fdt_addr_r is only 32MB. To have enought space to load kernel images bigger than 32MB change the variables to a feasible value. The new environment variables layout is based on the scheme from "include/configs/ti_armv7_common.h". The

[PATCH 1/1] doc: describe generation of SMBIOS table

2022-02-16 Thread Heinrich Schuchardt
SMBIOS is not x86 specific. So we should have an architecture independent page describing it. Signed-off-by: Heinrich Schuchardt --- doc/arch/x86.rst | 2 +- doc/develop/index.rst | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/arch/x86.rst b/doc/arch/x86.rst index

[PATCH 1/1] doc: describe generation of SMBIOS table

2022-02-16 Thread Heinrich Schuchardt
SMBIOS is not x86 specific. So we should have an architecture independent page describing it. Signed-off-by: Heinrich Schuchardt --- doc/arch/x86.rst | 2 +- doc/develop/index.rst | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/arch/x86.rst b/doc/arch/x86.rst index

Re: [PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

2022-02-16 Thread Daniel Klauer
On 15.02.22 08:08, Ramon Fried wrote: > On Mon, Feb 14, 2022 at 12:33 PM Daniel Klauer wrote: >> >> On 12.02.22 12:50, Ramon Fried wrote: >> > On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer wrote: >> >> >> >> The miiphy_read/miiphy_write functions return 1 on error, not -errno. >> > Why don't you

Re: [PATCH u-boot-mvebu v2 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-16 Thread Stefan Roese
On 2/16/22 11:18, Pali Rohár wrote: In function build_mem_map() prepare also mapping for CCI-400 and BootROM windows. BootROM window is 1 MB long and by default starts at address 0xfff0. A53 AP BootROM is 16 kB long and repeats in this BootROM window 64 times. RVBAR_EL3 register is set to

[PATCH u-boot-mvebu v2 3/3] arm: mvebu: a37xx: Fix comment with name of the function

2022-02-16 Thread Pali Rohár
Function is named build_mem_map, not a3700_build_mem_map. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Reviewed-by: Marek Behún --- arch/arm/mach-mvebu/armada3700/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/armada3700/cpu.c

[PATCH u-boot-mvebu v2 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-16 Thread Pali Rohár
In function build_mem_map() prepare also mapping for CCI-400 and BootROM windows. BootROM window is 1 MB long and by default starts at address 0xfff0. A53 AP BootROM is 16 kB long and repeats in this BootROM window 64 times. RVBAR_EL3 register is set to value 0x, so by default A53 AP

[PATCH u-boot-mvebu v2 1/3] arm: mvebu: a37xx: Fix calling build_mem_map()

2022-02-16 Thread Pali Rohár
Function build_mem_map() modifies global variable mem_map. This variable is used by the get_page_table_size() function which is called by function arm_reserve_mmu() (as aliased macro PGTABLE_SIZE). Function arm_reserve_mmu() is called earlier than enable_caches() which calls build_mem_map(). So

[PATCH u-boot-mvebu v2 0/3] arm: mvebu: a37xx: Fix and extend building memory map

2022-02-16 Thread Pali Rohár
Fix calling build_mem_map() function and extend it to map also CCI-400 and AP BootROM address space. With this change it is possible to access A53 AP BootROM on Armada 3720 from U-Boot and e.g. dump it via U-Boot md command: => md 4000 (Changes in v2: Fixed above dump command) Pali

Re: [PATCH u-boot-marvell] arm: mvebu: Do not define or overwrite vectors in SPL build

2022-02-16 Thread Pali Rohár
On Wednesday 16 February 2022 11:08:19 Stefan Roese wrote: > On 2/15/22 20:02, Pali Rohár wrote: > > U-Boot SPL is executed by the BootROM. And BootROM expects that U-Boot SPL > > code returns back to the BootROM. Reset vectors during execution of > > U-Boot SPL should not be changed as BootROM

Re: [PATCH u-boot-marvell] arm: mvebu: Do not define or overwrite vectors in SPL build

2022-02-16 Thread Stefan Roese
On 2/15/22 20:02, Pali Rohár wrote: U-Boot SPL is executed by the BootROM. And BootROM expects that U-Boot SPL code returns back to the BootROM. Reset vectors during execution of U-Boot SPL should not be changed as BootROM does not expect it and uses its own reset vectors. Just curious: How

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
Akashi-san, Here's an example of what was not working in case it helps you understand [...] > > > > > > > > > > > When you said "in a reversed order" in your commit, I expected that > > > > either > > > > 1.the image(helloworld.efi) has two signatures in a reversed order, or > > > >

Re: [PATCH u-boot-marvell 0/7] tools: kwbimage: Support for parsing extended v0 format

2022-02-16 Thread Tony Dinh
Hi Pali, Works great! I've tested this patch using dumpimage for the following boards: HP Thin Client T5335z Marvell Dove board: RD-88AP510-Avengers SoC: 88AP510 (A1) 1Ghz CPU, 1GB RAM Dell Kace M300 Marvell Kirkwood board: DB-88F6282A-BP LE SoC: Armada 300 ( aka 88F6282) 2GHz CPU, 2GB RAM

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
On Wed, 16 Feb 2022 at 04:20, AKASHI Takahiro wrote: > > Heinrich, > > We (I and Ilias) are still discussing on this patch. > I don't think it appropriate to merge it (in -rc2) at this point. I think it's fine to keep this as is since it's actually testing for a case that the patch fixed. I'll

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
On Wed, 16 Feb 2022 at 04:18, AKASHI Takahiro wrote: > > Ilias, > > On Tue, Feb 15, 2022 at 08:50:08AM +0200, Ilias Apalodimas wrote: > > Akashi-san, > > > > > > > > > > > > > > > > > > +# Try rejection in reverse order. > > > > > > > > > > > > > > "Reverse order" of what? > > > > > > > >

Re: [PATCH u-boot-marvell 7/7] tools: kwbimage: Add me as an author of kwbimage

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: Signed-off-by: Pali Rohár --- tools/kwbimage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index d82f04bea7c3..a3c1592b8140 100644 --- a/tools/kwbimage.c +++ b/tools/kwbimage.c @@ -6,6 +6,8 @@ * * (C)

Re: [PATCH u-boot-marvell 6/7] tools: kwbimage: Fix help how to extract DDR3 training code

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: First binary executable header is extracted by '-p 1' argument. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c

Re: [PATCH u-boot-marvell 5/7] tools: kwbimage: Add support for NAND_BLKSZ and NAND_BADBLK_LOCATION for v0 images

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: These two commands are currently not processed when generating v0 images. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/kwbimage.c

Re: [PATCH u-boot-marvell 4/7] tools: kwbimage: Do not show mkimage error message in dumpimage

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: When pflag is set then kwbimage was invoked by dumpimage and not mkimage. So do not show mkimage error message in this case. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.c | 2 +- 1 file changed, 1

Re: [PATCH u-boot-marvell 3/7] tools: kwbimage: Add support for dumping extended and binary v0 headers

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: dumpimage is now able to successfully parse and dump content of the Dove bootloader image. Note that support for generating these extended parts of v0 images is not included yet. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH u-boot-marvell 2/7] tools: kwbimage: Fix calculating size of kwbimage v0 header

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: Extended and binary headers are optional and are part of the image header. Fixes kwboot to determinate correct length of Dove images. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/kwbimage.h | 14 +- 1

Re: [PATCH u-boot-marvell 1/7] tools: kwbimage: Define structures for extended kwbimage v0 headers

2022-02-16 Thread Stefan Roese
On 2/15/22 19:59, Pali Rohár wrote: They are used by Marvell Dove 88AP510 BootROM. After the main header is a list of optional extended headers and after that is a list of optional binary executable headers. Between each two extended headers is additional 0x20 byte long padding. Original

Re: [PATCH u-boot-marvell] pci: mvebu: Ensure that root port is always on root zero bus

2022-02-16 Thread Stefan Roese
On 2/15/22 11:34, Pali Rohár wrote: Writing to the PCI_PRIMARY_BUS register of the root port should not change bus number on which is root port present. Same change and exactly same fix as was done in commit for pci-aardvark.c. Fixes: a7b61ab58d5d ("pci: pci_mvebu: Properly configure and use

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-16 Thread Pali Rohár
On Wednesday 16 February 2022 09:55:15 Stefan Roese wrote: > On 2/15/22 14:04, Pali Rohár wrote: > > On Tuesday 15 February 2022 13:11:25 Marek Behún wrote: > > > On Tue, 15 Feb 2022 00:28:34 +0100 > > > Pali Rohár wrote: > > > > > > > In function build_mem_map() prepares also mapping for

RE: [PATCH 1/2] stm32mp: bsec: add permanent lock write support

2022-02-16 Thread Johann Neuhauser
> -Original Message- > From: Patrick Delaunay [mailto:patrick.delau...@foss.st.com] > Sent: Tuesday, February 15, 2022 4:09 PM > > Add support of the permanent lock support in U-Boot proper > when BSEC is not managed by secure monitor (TF-A SP_MIN or OP-TEE). > > This patch avoid issue

RE: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-02-16 Thread Priyanka Jain
>-Original Message- >From: Pali Rohár >Sent: Wednesday, February 16, 2022 1:22 AM >To: Priyanka Jain >Cc: Tom Rini ; Alison Wang ; >Mingkai Hu ; Rajesh Bhagat ; >Jiafei Pan ; Simon Glass ; Alexandru >Gagniuc ; Yann Dirson ; >Stefan Roese ; Marek Behún ; u- >b...@lists.denx.de >Subject:

Re: [PATCH v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model

2022-02-16 Thread Heinrich Schuchardt
On 2/16/22 09:31, AKASHI Takahiro wrote: Hi Simon, On Mon, Feb 14, 2022 at 11:35:06AM +0900, AKASHI Takahiro wrote: Heinrich, On Thu, Feb 10, 2022 at 04:20:11PM +0100, Heinrich Schuchardt wrote: On 2/10/22 09:11, AKASHI Takahiro wrote: Background: === The purpose of this patch is to

Re: [PATCH u-boot-marvell 3/3] arm: a37xx: pci: Update comment about Command/Direct mode

2022-02-16 Thread Stefan Roese
On 2/15/22 11:23, Pali Rohár wrote: Code is changing PCIe controller from Command mode to Direct mode. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pci/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH u-boot-marvell 2/3] arm: a37xx: pci: Register controller also when no PCIe card is connected

2022-02-16 Thread Stefan Roese
On 2/15/22 11:23, Pali Rohár wrote: Allow access to config space of PCIe Root Port (which is always present on the root bus) even when PCIe link is down or no card is connected. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pci/pci-aardvark.c | 12

Re: [PATCH u-boot-marvell 1/3] arm: a37xx: pci: Do not try to access other buses when link is down

2022-02-16 Thread Stefan Roese
On 2/15/22 11:23, Pali Rohár wrote: If a PIO request is executed while link-down, the whole controller gets stuck in a non-functional state, and even after link comes up again, PIO requests won't work anymore, and a reset of the whole PCIe controller is needed. Therefore we need to prevent

Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: a37xx: Fix comment with name of the function

2022-02-16 Thread Stefan Roese
On 2/15/22 00:28, Pali Rohár wrote: Function is named build_mem_map, not a3700_build_mem_map. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/armada3700/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-16 Thread Stefan Roese
On 2/15/22 00:28, Pali Rohár wrote: In function build_mem_map() prepares also mapping for CCI-400 and AP BootROM address space. A53 AP BootROM by default starts at address 0xfff0 and is 16 kB long. CCI-400 in new TF-A version starts at address 0xfe00 and is 64 kB long. Physical

Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space

2022-02-16 Thread Stefan Roese
On 2/15/22 14:04, Pali Rohár wrote: On Tuesday 15 February 2022 13:11:25 Marek Behún wrote: On Tue, 15 Feb 2022 00:28:34 +0100 Pali Rohár wrote: In function build_mem_map() prepares also mapping for CCI-400 and * prepare AP BootROM address space. A53 AP

Re: [PATCH u-boot-marvell RFC] PLEASE TEST: ddr: marvell: a38x: fix BYTE_HOMOGENEOUS_SPLIT_OUT decision

2022-02-16 Thread Stefan Roese
On 2/15/22 23:21, Chris Packham wrote: On Fri, Feb 11, 2022 at 5:25 AM Marek Behún wrote: From: Marek Behún In commit 3fc92a215b69 ("ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision") I ported a cleaned up and changed version of patch mv_ddr: a380: fix SPLIT_OUT_MIX state decision

Re: [PATCH v11 5/9] test/py: efi_capsule: add image authentication test

2022-02-16 Thread Heinrich Schuchardt
On 2/14/22 01:43, AKASHI Takahiro wrote: Heinrich, On Fri, Feb 11, 2022 at 08:25:15PM +0100, Heinrich Schuchardt wrote: On 2/9/22 11:10, AKASHI Takahiro wrote: Add a couple of test cases against capsule image authentication for capsule-on-disk, where only a signed capsule file with the

RE: [PATCH 0/3] gpio: Add AST2[456]00 GPIO driver

2022-02-16 Thread Ryan Chen
Hello Andrew, This patch series are ok, Please help add Reviewed-by: Ryan Chen > -Original Message- > From: Andrew Jeffery > Sent: Wednesday, February 16, 2022 7:57 AM > To: u-boot@lists.denx.de > Cc: max...@google.com; ChiaWei Wang ; > Ryan Chen ; Troy Lee > ; BMC-SW ; >

Re: [PATCH v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model

2022-02-16 Thread AKASHI Takahiro
Hi Simon, On Mon, Feb 14, 2022 at 11:35:06AM +0900, AKASHI Takahiro wrote: > Heinrich, > > On Thu, Feb 10, 2022 at 04:20:11PM +0100, Heinrich Schuchardt wrote: > > On 2/10/22 09:11, AKASHI Takahiro wrote: > > > Background: > > > === > > > The purpose of this patch is to reignite the

[BUG] clean target deletes lib/acpi/dsdt.c

2022-02-16 Thread Heinrich Schuchardt
Hello Simon, The clean target deletes lib/acpi/dsdt.c. But without it building some x86 targets fails: +Some images are invalid x86: + edison +make[3]: *** No rule to make target 'lib/acpi/dsdt.asl', needed by 'lib/acpi/dsdt.c'. Stop. Should lib/acpi/dsdt.c be generated code? Or

Re: [PATCH] kontron-sl-mx8mm: change environment address variables

2022-02-16 Thread Michael Walle
Am 2022-02-16 09:12, schrieb Heiko Thiery: Currently the space between kernel_addr_r and the fdt_addr_r is only 32MB. To have enought space to load kernel images bigger than 32MB change the varialbes to a feasable value. variables, feasible The new environment variables layout is based on

Re: [PATCH v2] dm: Fix OF_BAD_ADDR definition

2022-02-16 Thread Patrice CHOTARD
Hi Jan On 2/15/22 21:36, Jan Kiszka wrote: > On 15.02.22 14:49, Jan Kiszka wrote: >> On 15.02.22 14:34, Patrice CHOTARD wrote: >>> Hi Jan >>> >>> On 2/15/22 14:00, Jan Kiszka wrote: On 15.02.22 12:56, Patrice CHOTARD wrote: > Hi Jan > > On 2/14/22 16:21, Jan Kiszka wrote: >>

Re: bind/unbind command not working for usb_ether

2022-02-16 Thread Patrice CHOTARD
Hi Tim On 2/15/22 19:28, Tim Harvey wrote: > On Tue, Feb 15, 2022 at 9:36 AM Patrice CHOTARD > wrote: >> >> Hi Tim >> >> On 2/15/22 17:09, Tim Harvey wrote: >>> On Tue, Feb 15, 2022 at 5:29 AM Patrice CHOTARD >>> wrote: Hi Tim On 2/10/22 18:04, Tim Harvey wrote: >

RE: [PATCH] ram: aspeed: Rework kconfig options

2022-02-16 Thread Dylan Hung
> -Original Message- > From: joel.s...@gmail.com [mailto:joel.s...@gmail.com] On Behalf Of Joel > Stanley > Sent: 2022年2月16日 3:53 PM > To: ChiaWei Wang ; Ryan Chen > ; BMC-SW > Cc: Cédric Le Goater ; u-boot@lists.denx.de > Subject: [PATCH] ram: aspeed: Rework kconfig options > > Ensure

[PATCH] kontron-sl-mx8mm: change environment address variables

2022-02-16 Thread Heiko Thiery
Currently the space between kernel_addr_r and the fdt_addr_r is only 32MB. To have enought space to load kernel images bigger than 32MB change the varialbes to a feasable value. The new environment variables layout is based on the scheme from "include/configs/ti_armv7_common.h". The

[PATCH] arm: dts: iot2050: Add cfg register space for ringacc and udmap

2022-02-16 Thread Jan Kiszka
From: Jan Kiszka Recent unrelated fixes (9876ae7db6da) revealed that we were missing bits from 2af181b53e28 in the IOT2050 dt. Add them, but only for main U-Boot. SPL loads from QSPI only, thus cannot use DMA. Signed-off-by: Jan Kiszka --- .../dts/k3-am65-iot2050-common-u-boot.dtsi| 25