Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Masami Hiramatsu
Hi Sughosh, OK I understand that if the platform uses the FIT capsule, the fw_images[] must have 1 entry and it is completely non relationship with dfu_alt_info... We may need a document for this case too. Thanks, 2022年3月25日(金) 10:09 Masami Hiramatsu : > > Hi Sughosh, > > 2022年3月24日(木) 23:40

Re: [RFC PATCH 0/6] efi: capsule: Image GUID usage cleanup

2022-03-24 Thread AKASHI Takahiro
Sughosh, On Thu, Mar 24, 2022 at 06:08:55PM +0530, Sughosh Ganu wrote: > > This series is cleaning up the usage of the image GUIDs that are used > in capsule update and the EFI System Resource Table(ESRT). > > Currently, there are two instances of the Firmware Management > Protocol(FMP), one

Re: [PATCH 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-03-24 Thread William Zhang
On 3/24/22 18:13, Andre Przywara wrote: On Wed, 23 Mar 2022 19:03:48 -0700 William Zhang wrote: Hi, This is the initial support for Broadcom's ARM-based 47622 SOC. In this change, our first SOC is an armv7 platform called 47622. The initial support includes a bare-bone implementation and

Re: [PATCH 04/11] exynos: Drop CONFIG_DEVICE_TREE_LIST

2022-03-24 Thread Minkyu Kang
Dear Tom, On Fri, 25 Mar 2022 at 09:22, Jaehoon Chung wrote: > > On 3/25/22 06:17, Tom Rini wrote: > > This value isn't used anywhere, drop it. > > > > Signed-off-by: Tom Rini > > Reviewed-by : Jaehoon Chung > > > Reviewed-by: Minkyu Kang -- Thanks, Minkyu Kang.

Re: [PATCH 19/22] exynos: Drop CONFIG_CLK_*

2022-03-24 Thread Minkyu Kang
Dear Tom, On Thu, 24 Mar 2022 at 06:23, Tom Rini wrote: > We only set one of these values ever at this point, so remove dead code. > > Cc: Minkyu Kang > Cc: Jaehoon Chung > Signed-off-by: Tom Rini > --- > arch/arm/mach-exynos/exynos4_setup.h | 20 >

Re: [PATCH 07/11] virtio: pci: Check virtio configs are mapped

2022-03-24 Thread Bin Meng
On Sun, Mar 20, 2022 at 7:42 PM Andrew Scull wrote: > > The calls to `virtio_pci_map_capability()` return NULL on error. If this > happens, later accesses to the pointers would be unsafe. Avoid this by > failing if the configs were not successfully mapped. > > Signed-off-by: Andrew Scull > --- >

Re: [PATCH 06/11] virtio: pci: Read entire capability into memory

2022-03-24 Thread Bin Meng
On Sun, Mar 20, 2022 at 7:42 PM Andrew Scull wrote: > > Read the virtio PCI capability out of the device configuration space to > a struct rather than accessing fields directly from the configuration > space as they are needed. This both makes access to the fields easier > and avoids re-reading

Re: [PATCH 03/11] virtio: pci: Bounds check notification writes

2022-03-24 Thread Bin Meng
On Fri, Mar 25, 2022 at 12:24 AM Andrew Scull wrote: > > On Thu, 24 Mar 2022 at 14:19, Bin Meng wrote: > > > > On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > > > > > Make sure virtio notifications are written within their allocated > > > buffer. > > > > > > Signed-off-by: Andrew Scull

Re: [PATCH 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-03-24 Thread Andre Przywara
On Wed, 23 Mar 2022 19:03:48 -0700 William Zhang wrote: Hi, > This is the initial support for Broadcom's ARM-based 47622 SOC. > > In this change, our first SOC is an armv7 platform called 47622. The > initial support includes a bare-bone implementation and dts with ARM > PL011 uart. As Tom

Re: [PATCH 05/11] virtio: pci: Check virtio capability is in bounds

2022-03-24 Thread Bin Meng
On Fri, Mar 25, 2022 at 12:27 AM Andrew Scull wrote: > > On Thu, 24 Mar 2022 at 15:24, Bin Meng wrote: > > > > On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > > > > > Ensure the virtio PCI capabilities are contained within the bounds of > > > the device's configuration space. The

Re: [PATCH v4 00/11] enable menu-driven boot device selection

2022-03-24 Thread Takahiro Akashi
Kojima-san, On Thu, Mar 24, 2022 at 10:54:32PM +0900, Masahisa Kojima wrote: > This patch series adds the menu-driven boot device selection, > by extending the existing "bootmenu" to include UEFI and distro_boot > related entries, and supports menu-driven UEFI boot variable > maintenance. > >

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Masami Hiramatsu
Hi Sughosh, 2022年3月24日(木) 23:40 Sughosh Ganu : > > hi Masami, > > On Thu, 24 Mar 2022 at 19:14, Masami Hiramatsu > wrote: > > > > Hi Sughosh, > > > > 2022年3月24日(木) 21:39 Sughosh Ganu : > > > > > > Currently, all platforms that enable capsule updates do so using > > > either

Re: [PATCH 04/11] exynos: Drop CONFIG_DEVICE_TREE_LIST

2022-03-24 Thread Jaehoon Chung
On 3/25/22 06:17, Tom Rini wrote: > This value isn't used anywhere, drop it. > > Signed-off-by: Tom Rini Reviewed-by : Jaehoon Chung Best Regards, Jaehoon Chung > --- > include/configs/exynos5420-common.h | 3 --- > include/configs/exynos7420-common.h | 3 --- >

Re: [PATCH 00/14] video: Drop old CFB code

2022-03-24 Thread Simon Glass
Hi Anatloij, On Fri, 25 Mar 2022 at 11:16, Anatolij Gustschin wrote: > > Hi Simon, > > On Thu, 24 Mar 2022 13:54:22 -0600 > Simon Glass s...@chromium.org wrote: > ... > > > > Is there any word on this series, please? > > last week I've rebased and applied this series to next (PATCH 02/14 >

Re: [PATCH 00/14] video: Drop old CFB code

2022-03-24 Thread Anatolij Gustschin
Hi Simon, On Thu, 24 Mar 2022 13:54:22 -0600 Simon Glass s...@chromium.org wrote: ... > > Is there any word on this series, please? last week I've rebased and applied this series to next (PATCH 02/14 dropped) and will submit a pull request when Tom merges last -rc into his next branch.

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-24 Thread Tony Dinh
Hi Hajo, I've added Stefan. When you send patches for Kirkwood or other Marvell boards, please also send it directly to Stefan (Stefan is the maintainer of Marvell u-boots). Tony On Thu, Mar 24, 2022 at 3:11 AM Pali Rohár wrote: > > Hello! > > On Thursday 24 March 2022 10:55:38 Hajo

Re: [PATCH v3] mtd: gpmi: fix the bch setting backward compatible issue

2022-03-24 Thread Fabio Estevam
On Thu, Mar 24, 2022 at 6:39 PM Han Xu wrote: > > Previous u-boot code changed the default bch setting behavior and caused > backward compatible issue. This fix choose the legacy bch geometry back > again as the default option. If the minimum ecc strength that NAND chips > required need to be

[PATCH v3] mtd: gpmi: fix the bch setting backward compatible issue

2022-03-24 Thread Han Xu
Previous u-boot code changed the default bch setting behavior and caused backward compatible issue. This fix choose the legacy bch geometry back again as the default option. If the minimum ecc strength that NAND chips required need to be chosen, it can be enabled by either adding DT flag

Re: Please pull u-boot-marvell/master

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 05:42:27PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull this Espressobin fix from Pali: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 10/11] Convert CONFIG_SYS_MONITOR_BASE to Kconfig

2022-03-24 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_MONITOR_BASE Note that for how this is re-used on some PowePC platforms, we introduce CONFIG_SPL_SYS_MONITOR_BASE and CONFIG_TPL_SYS_MONITOR_BASE and use the CONFIG_VAL macro to get the correct value at build time, in the code. Signed-off-by:

[PATCH 11/11] global: Remove CONFIG_SYS_EXTRA_OPTIONS support

2022-03-24 Thread Tom Rini
All options have now been migrated to Kconfig correctly so remove this support. Signed-off-by: Tom Rini --- boot/Kconfig | 13 doc/README.kconfig | 7 doc/develop/moveconfig.rst | 3 +- scripts/Makefile.autoconf | 4 --- scripts/build-whitelist.sh | 23

[PATCH 08/11] at91: Switch to SD_BOOT / CONFIG_NAND_BOOT

2022-03-24 Thread Tom Rini
The values CONFIG_SYS_USE_NANDFLASH and CONFIG_SYS_USE_MMC serve the same purpose as CONFIG_SD_BOOT / CONFIG_NAND_BOOT so migrate to using these switches instead as they're already in Kconfig. Cc: Stelian Pop Cc: Heiko Schocher Cc: Daniel Gorsulowski Cc: Eugen Hristev Signed-off-by: Tom Rini

[PATCH 09/11] Convert CONFIG_NORFLASH_PS32BIT to Kconfig

2022-03-24 Thread Tom Rini
This converts the following to Kconfig: CONFIG_NORFLASH_PS32BIT Note that we also attempt to correct the behavior of the code here, which had been testing for "NORFLASH_PS32BIT" which would never be set, instead check for the now set "CONFIG_NORFLASH_PS32BIT", which results in some behavior

[PATCH 06/11] Convert CONFIG_E300 et al to Kconfig

2022-03-24 Thread Tom Rini
This converts the following to Kconfig: CONFIG_E300 CONFIG_E5500 Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/Kconfig | 3 +++ arch/powerpc/cpu/mpc85xx/Kconfig | 6 ++ arch/powerpc/include/asm/config_mpc85xx.h | 2 -- include/configs/MPC837XERDB.h

[PATCH 07/11] Convert CONFIG_SRIO_PCIE_BOOT_SLAVE to Kconfig

2022-03-24 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SRIO_PCIE_BOOT_SLAVE Signed-off-by: Tom Rini --- board/freescale/t208xqds/Kconfig | 3 +++ configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/board/freescale/t208xqds/Kconfig

[PATCH 05/11] mx53loco: Convert CONFIG_DIALOG_POWER to Kconfig

2022-03-24 Thread Tom Rini
Signed-off-by: Tom Rini --- board/freescale/mx53loco/Kconfig | 3 +++ include/configs/mx53loco.h | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/board/freescale/mx53loco/Kconfig b/board/freescale/mx53loco/Kconfig index a690a601ac0e..5dcdcd9f725e 100644 ---

[PATCH 03/11] Convert CONFIG_DEEP_SLEEP to Kconfig

2022-03-24 Thread Tom Rini
This converts the following to Kconfig: CONFIG_DEEP_SLEEP Signed-off-by: Tom Rini --- README | 4 board/freescale/common/Kconfig | 7 +++ configs/ls1021aiot_qspi_defconfig | 1 + configs/ls1021aiot_sdcard_defconfig | 1 +

[PATCH 04/11] exynos: Drop CONFIG_DEVICE_TREE_LIST

2022-03-24 Thread Tom Rini
This value isn't used anywhere, drop it. Signed-off-by: Tom Rini --- include/configs/exynos5420-common.h | 3 --- include/configs/exynos7420-common.h | 3 --- include/configs/exynos78x0-common.h | 3 --- 3 files changed, 9 deletions(-) diff --git a/include/configs/exynos5420-common.h

[PATCH 02/11] M5329EVB, M5373EVB: Remove CONFIG_NANDFLASH_SIZE

2022-03-24 Thread Tom Rini
In the case of M5373EVB we always had NANDFLASH_SIZE=16, so just use it directly. In the case of M5329EVB we had not removed the rest of NAND support when saying we didn't have NAND, so instead use that to key off of rather than NANDFLASH_SIZE. Cc: TsiChung Liew Signed-off-by: Tom Rini ---

[PATCH 01/11] db-mv784mp-gp: Rename CONFIG_DB_784MP_GP to CONFIG_TARGET_DB_MV784MP_GP

2022-03-24 Thread Tom Rini
The value CONFIG_DB_784MP_GP is only used in the DDR code to refer to CONFIG_TARGET_DB_MV784MP_GP so just use that second value directly. Cc: Stefan Roese Signed-off-by: Tom Rini --- arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c | 2 +- drivers/ddr/marvell/axp/ddr3_axp.h

Re: [PATCH v4 00/33] Initial implementation of standard boot

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 02:04:57PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 24 Mar 2022 at 13:27, Tom Rini wrote: > > > > On Thu, Mar 24, 2022 at 12:33:38PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 24 Mar 2022 at 08:46, Tom Rini wrote: > > > > > > > > On Wed, Mar 23,

Re: [PATCH 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-03-24 Thread William Zhang
On 3/24/22 11:58, Tom Rini wrote: On Thu, Mar 24, 2022 at 11:53:19AM -0700, William Zhang wrote: Hi Tom, On 3/23/22 20:08, Tom Rini wrote: On Wed, Mar 23, 2022 at 07:03:48PM -0700, William Zhang wrote: This is the initial support for Broadcom's ARM-based 47622 SOC. In this change, our

Re: [PATCH] arm64: zynqmp: enable the PMUFW watchdog

2022-03-24 Thread Jorge Ramirez-Ortiz, Foundries
On 24/03/22, Michal Simek wrote: > > > On 3/23/22 15:04, Jorge Ramirez-Ortiz wrote: > > From 528b3117a36b7b4eea1839afbea7191d60638b0c Mon Sep 17 00:00:00 2001 > > From: Jorge Ramirez-Ortiz > > Date: Wed, 23 Mar 2022 14:41:15 +0100 > > Subject: [PATCH] arm64: zynqmp: enable the PMUFW watchdog >

Re: [PATCH-next] include: configs: at91/sam: remove stray #ifdef/#else

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 12:01:19PM -0400, Tom Rini wrote: > On Thu, Mar 24, 2022 at 01:08:48PM +0200, Eugen Hristev wrote: > > > With the commit that moves the BOOTCOMMAND to Kconfig: > > > > 970bf8603b ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig") > > > > some stray ifdefs have been left

Re: [PATCH 00/14] video: Drop old CFB code

2022-03-24 Thread Simon Glass
Hi Pali, On Thu, 24 Mar 2022 at 13:56, Pali Rohár wrote: > > On Thursday 24 March 2022 13:54:22 Simon Glass wrote: > > Hi Anatolij, > > > > On Sun, 23 Jan 2022 at 07:04, Simon Glass wrote: > > > > > > There is still quite a bit of cruft in the video subsystem. Mainly this is > > > users of the

Re: [PATCH 00/14] video: Drop old CFB code

2022-03-24 Thread Pali Rohár
On Thursday 24 March 2022 13:54:22 Simon Glass wrote: > Hi Anatolij, > > On Sun, 23 Jan 2022 at 07:04, Simon Glass wrote: > > > > There is still quite a bit of cruft in the video subsystem. Mainly this is > > users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD. > > > > This series

Re: [PATCH 00/14] video: Drop old CFB code

2022-03-24 Thread Simon Glass
Hi Anatolij, On Sun, 23 Jan 2022 at 07:04, Simon Glass wrote: > > There is still quite a bit of cruft in the video subsystem. Mainly this is > users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD. > > This series removes most of the first two. The exception is videomodes.c > and its

Re: [PATCH v4 00/33] Initial implementation of standard boot

2022-03-24 Thread Simon Glass
Hi Tom, On Thu, 24 Mar 2022 at 13:27, Tom Rini wrote: > > On Thu, Mar 24, 2022 at 12:33:38PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 24 Mar 2022 at 08:46, Tom Rini wrote: > > > > > > On Wed, Mar 23, 2022 at 08:13:42PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH v4 00/33] Initial implementation of standard boot

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 12:33:38PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 24 Mar 2022 at 08:46, Tom Rini wrote: > > > > On Wed, Mar 23, 2022 at 08:13:42PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 23 Mar 2022 at 14:09, Tom Rini wrote: > > > > > > > > On Wed, Mar 23,

Re: [PATCH] efi_loader: Expose relocated address for gdb debugging purposes

2022-03-24 Thread Alex
March 24, 2022 1:25 PM, "Alexander von Gluck IV" wrote: > March 24, 2022 12:06 PM, "Heinrich Schuchardt" wrote: > >> On 3/24/22 17:22, Alexander von Gluck IV wrote: >> Do we really always need this output for every invokation of LoadImage()? >> >> Writing test messages during the runtime of a

[PATCH] efi_loader (v2): Expose relocated address for gdb debugging purposes

2022-03-24 Thread Alexander von Gluck IV
* If users want to debug EFI applications via qemu + GDB, they need to know the relocated address of the application to align their symbols to in GDB via add-symbol-file. * This exposes where EFI applications are relocated to enable debugging EFI applications via qemu + gdb * Usage is

Re: [PATCH 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 11:53:19AM -0700, William Zhang wrote: > Hi Tom, > > On 3/23/22 20:08, Tom Rini wrote: > > On Wed, Mar 23, 2022 at 07:03:48PM -0700, William Zhang wrote: > > > This is the initial support for Broadcom's ARM-based 47622 SOC. > > > > > > In this change, our first SOC is an

Re: [PATCH 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-03-24 Thread William Zhang
Hi Tom, On 3/23/22 20:08, Tom Rini wrote: On Wed, Mar 23, 2022 at 07:03:48PM -0700, William Zhang wrote: This is the initial support for Broadcom's ARM-based 47622 SOC. In this change, our first SOC is an armv7 platform called 47622. The initial support includes a bare-bone implementation and

Re: [PATCH v4 00/33] Initial implementation of standard boot

2022-03-24 Thread Simon Glass
Hi Tom, On Thu, 24 Mar 2022 at 08:46, Tom Rini wrote: > > On Wed, Mar 23, 2022 at 08:13:42PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 23 Mar 2022 at 14:09, Tom Rini wrote: > > > > > > On Wed, Mar 23, 2022 at 12:45:50PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH] efi_loader: Expose relocated address for gdb debugging purposes

2022-03-24 Thread Alexander von Gluck IV
March 24, 2022 12:06 PM, "Heinrich Schuchardt" wrote: > On 3/24/22 17:22, Alexander von Gluck IV wrote: > Do we really always need this output for every invokation of LoadImage()? > > Writing test messages during the runtime of a menu driven program like > the UEFI SCT can be very disturbing. >

[PATCH 6/6] net: fm: Add support for FIT firmware

2022-03-24 Thread Sean Anderson
Fman microcode is executable code (AFAICT) loaded into a coprocessor. As such, if verified boot is enabled, it must be verified like other executable code. However, this is not currently done. This commit adds verified boot functionality by encapsulating the microcode in a FIT, which can then be

[PATCH 5/6] net: fm: Support loading firmware from a filesystem

2022-03-24 Thread Sean Anderson
This adds a new method to load Fman firmware from a filesystem. This allows users to use regular files instead of hard-coded offsets for the firmware. Signed-off-by: Sean Anderson --- drivers/net/fm/fm.c | 25 - drivers/qe/Kconfig | 4 2 files changed, 28

[PATCH 4/6] net: fm: Add firmware name parameter

2022-03-24 Thread Sean Anderson
In order to read the firmware from the filesystem, we need a file name. Read the firmware name from the device tree, using the firmware-name property. This property is commonly used in Linux to determine the correct name to use (and can be seen in several device trees in U-Boot). Signed-off-by:

[PATCH 3/6] misc: fs_loader: Add function to get the chosen loader

2022-03-24 Thread Sean Anderson
The fs_loader device is used to pull in settings via the chosen node. However, there was no library function for this, so arria10 was doing it explicitly. This function subsumes that, and uses ofnode_get_chosen_node instead of navigating the device tree directly. Because fs_loader pulls its config

[PATCH 2/6] image: fit: Add some helpers for getting data

2022-03-24 Thread Sean Anderson
Several different firmware users have repetitive code to extract the firmware data from a FIT. Add some helper functions to reduce the amount of repetition. fit_conf_get_prop_node (eventually) calls fdt_check_node_offset_, so we can avoid an explicit if. In general, this version avoids printing on

[PATCH 0/6] net: fm: Verify Fman microcode

2022-03-24 Thread Sean Anderson
Surprisingly, Fman microcode does not seem to be verified. This series aims to rectify this by introducing an optional FIT wrapper. This wrapper is made mandatory if FIT_SIGNATURE is enabled. NXP boards do not use this config, so the microcode will remain unverified for them. This is OK, since we

[PATCH 1/6] ARMv8/sec_firmware: Remove SEC_FIRMWARE_FIT_CNF_NAME

2022-03-24 Thread Sean Anderson
The config to use for FIT images can be better specified by enabling CONFIG_MULTI_DTB_FIT and implementing board_fit_config_name_match. Signed-off-by: Sean Anderson --- arch/arm/cpu/armv8/sec_firmware.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git

Re: [PATCH 12/22] Convert CONFIG_LSCHLV2 to Kconfig et al

2022-03-24 Thread Michael Walle
Am 2022-03-23 22:19, schrieb Tom Rini: This converts the following to Kconfig: CONFIG_LSCHLV2 CONFIG_LSXHL Cc: Michael Walle Signed-off-by: Tom Rini Reviewed-by: Michael Walle thanks, -michael --- board/buffalo/lsxl/Kconfig | 11 +++ configs/lschlv2_defconfig | 2 +-

Re: [PATCH v5 5/9] qemu: arm: Remove platform specific function to get RNG device

2022-03-24 Thread Heinrich Schuchardt
On 3/24/22 17:44, Sughosh Ganu wrote: On Sun, 13 Mar 2022 at 20:18, Sughosh Ganu wrote: The Qemu platform has a function defined to get the random number generator(RNG) device. However, the RNG device can be obtained simply by searching for a device belonging to the RNG uclass. Remove the

Re: [PATCH] efi_loader: Expose relocated address for gdb debugging purposes

2022-03-24 Thread Heinrich Schuchardt
On 3/24/22 17:22, Alexander von Gluck IV wrote: * If users want to debug EFI applications via qemu + GDB, they need to know the relocated address of the application to align their symbols to in GDB via add-symbol-file. * This exposes where EFI applications are relocated to enable

Re: [PATCH v5 5/9] qemu: arm: Remove platform specific function to get RNG device

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:18, Sughosh Ganu wrote: > > The Qemu platform has a function defined to get the random number > generator(RNG) device. However, the RNG device can be obtained simply > by searching for a device belonging to the RNG uclass. Remove the > superfluous platform

Please pull u-boot-marvell/master

2022-03-24 Thread Stefan Roese
Hi Tom, please pull this Espressobin fix from Pali: - a37xx: espressobin: Fix non-working SPI (Pali) Here the Azure build, without any issues:

Re: [PATCH u-boot-marvell] arm: a37xx: espressobin: Fix non-working SPI

2022-03-24 Thread Stefan Roese
On 3/23/22 14:18, Pali Rohár wrote: Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke SPI support on some Espressobin boards and results in following U-Boot error: Loading Environment

Re: [RFC] Dumping load addresses - bootefi qemu gdb remote debugging

2022-03-24 Thread Alexander von Gluck IV
See "[PATCH] efi_loader: Expose relocated address for gdb debugging purposes" This actually solves the problem by exposing (previously hidden) relocated address. Now it's a *LOT* easier to debug u-boot loaded EFI binaries using the exposed address: This is helpful on pretty much every

Re: [PATCH 05/11] virtio: pci: Check virtio capability is in bounds

2022-03-24 Thread Andrew Scull
On Thu, 24 Mar 2022 at 15:24, Bin Meng wrote: > > On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > > > Ensure the virtio PCI capabilities are contained within the bounds of > > the device's configuration space. The expected size of the capability is > > passed when searching for the

[PATCH] efi_loader: Expose relocated address for gdb debugging purposes

2022-03-24 Thread Alexander von Gluck IV
* If users want to debug EFI applications via qemu + GDB, they need to know the relocated address of the application to align their symbols to in GDB via add-symbol-file. * This exposes where EFI applications are relocated to enable debugging EFI applications via qemu + gdb * Usage is

Re: [PATCH v3 8/8] test: rng: Add a UT testcase for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Fri, 4 Mar 2022 at 19:05, Sughosh Ganu wrote: > > The 'rng' command dumps a number of random bytes on the console. Add a > set of tests for the 'rng' command. The test function performs basic > sanity testing of the command. > > Since a unit test is being added for the command,

Re: [PATCH v5 9/9] test: rng: Add a UT testcase for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > The 'rng' command dumps a number of random bytes on the console. Add a > set of tests for the 'rng' command. The test function performs basic > sanity testing of the command. > > Since a unit test is being added for the command,

Re: [PATCH v5 8/9] doc: rng: Add documentation for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > Add a usage document for the 'rng' u-boot command. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Ilias Apalodimas > Reviewed-by: Simon Glass > --- > > Changes since V4: > > * Reflect the fact that a maximum of 64 bytes can be

Re: [PATCH v5 7/9] cmd: rng: Use a statically allocated array for random bytes

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > Use a statically allocated buffer on stack instead of using malloc for > reading the random bytes. Using a local array is faster than > allocating heap memory on every initiation of the command. > > Signed-off-by: Sughosh Ganu >

Re: [PATCH v5 6/9] cmd: rng: Add support for selecting RNG device

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Mon, 14 Mar 2022 at 03:53, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 13 Mar 2022 at 08:49, Sughosh Ganu wrote: > > > > The 'rng' u-boot command is used for printing a select number of > > random bytes on the console. Currently, the RNG device from which the > > random bytes

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-24 Thread Tim Harvey
On Thu, Mar 24, 2022 at 8:59 AM Fabio Estevam wrote: > > Hi Tim, > > On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > > > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. > > I think we should be

Re: [PATCH-next] include: configs: at91/sam: remove stray #ifdef/#else

2022-03-24 Thread Tom Rini
On Thu, Mar 24, 2022 at 01:08:48PM +0200, Eugen Hristev wrote: > With the commit that moves the BOOTCOMMAND to Kconfig: > > 970bf8603b ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig") > > some stray ifdefs have been left in the header files which > are now useless. > Clean up the include

Re: [RESEND PATCH] gpio: rgpio2p: Enhance reading of GPIO pin value

2022-03-24 Thread Fabio Estevam
On Thu, Mar 24, 2022 at 12:11 PM Christoph Fritz wrote: > > Add support for reading GPIO pin value when function is output. > With this patch applied, gpio toggle command is working. > > Signed-off-by: Christoph Fritz > Cc: Fabio Estevam > Reviewed-by: Peng Fan Reviewed-by: Fabio Estevam

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-24 Thread Fabio Estevam
Hi Tim, On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. I think we should be consistent with Linux and return -ENXIO for the NACK case:

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 20:40, Michal Simek wrote: > > > > On 3/24/22 15:51, Sughosh Ganu wrote: > > On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > >> > >> > >> > >> On 3/24/22 13:39, Sughosh Ganu wrote: > >>> While building a capsule, the GUID value of that specific image is to > >>> be

[PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-24 Thread Tim Harvey
commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. Update the gsc_i2c_read and gsc_i2c_write functions for this change to properly retry the transaction on a NAK meaning the GSC is busy. Fixes: 7c84319af9c7 ("dm:

Re: [RFC] Dumping load addresses - bootefi qemu gdb remote debugging

2022-03-24 Thread Bin Meng
+Heinrich Schuchardt On Thu, Mar 24, 2022 at 10:51 PM Alex wrote: > > Good morning! > > So, some time ago I wrote a short guide on how to debug EFI bootloaders > started > by u-boot in qemu. > > https://www.haiku-os.org/blog/kallisti5/2021-01-17_debugging_riscv-64_bootloader_in_qemu/ > > At the

[PATCH] image: fit: Align hash output buffers

2022-03-24 Thread Sean Anderson
Hardware-accelerated hash functions require that the input and output buffers be aligned to the minimum DMA alignment. memalign.h helpfully provides a macro just for this purpose. It doesn't exist on the host, but we don't need to be aligned there either. Fixes: 5dfb521386 ("[new uImage] New

Re: [PATCH 1/1] dm: fix function documentation in include/dm/ofnode.h

2022-03-24 Thread Bin Meng
On Thu, Mar 24, 2022 at 11:22 PM Heinrich Schuchardt wrote: > > We use Sphinx style comments to describe functions. > > Signed-off-by: Heinrich Schuchardt > --- > include/dm/ofnode.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 05/11] virtio: pci: Check virtio capability is in bounds

2022-03-24 Thread Bin Meng
On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > Ensure the virtio PCI capabilities are contained within the bounds of > the device's configuration space. The expected size of the capability is > passed when searching for the capability to enforce this check. > > Signed-off-by: Andrew

[PATCH 1/1] dm: fix function documentation in include/dm/ofnode.h

2022-03-24 Thread Heinrich Schuchardt
We use Sphinx style comments to describe functions. Signed-off-by: Heinrich Schuchardt --- include/dm/ofnode.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index 744dffe0a2..6a996d9521 100644 --- a/include/dm/ofnode.h +++

[RESEND PATCH] gpio: rgpio2p: Enhance reading of GPIO pin value

2022-03-24 Thread Christoph Fritz
Add support for reading GPIO pin value when function is output. With this patch applied, gpio toggle command is working. Signed-off-by: Christoph Fritz Cc: Fabio Estevam Reviewed-by: Peng Fan --- drivers/gpio/imx_rgpio2p.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-)

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Michal Simek
On 3/24/22 15:51, Sughosh Ganu wrote: On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: On 3/24/22 13:39, Sughosh Ganu wrote: While building a capsule, the GUID value of that specific image is to be passed through the --guid command option to the mkeficapsule tool. This renders the

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 20:21, Michal Simek wrote: > > > > On 3/24/22 15:44, Sughosh Ganu wrote: > > On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > >> > >> > >> > >> On 3/24/22 13:38, Sughosh Ganu wrote: > >>> Currently, all platforms that enable capsule updates do so using > >>> either

[RFC] Dumping load addresses - bootefi qemu gdb remote debugging

2022-03-24 Thread Alex
Good morning! So, some time ago I wrote a short guide on how to debug EFI bootloaders started by u-boot in qemu. https://www.haiku-os.org/blog/kallisti5/2021-01-17_debugging_riscv-64_bootloader_in_qemu/ At the time it worked, however figuring the elf load addresses from u-boot was extremely

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Michal Simek
On 3/24/22 15:44, Sughosh Ganu wrote: On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: On 3/24/22 13:38, Sughosh Ganu wrote: Currently, all platforms that enable capsule updates do so using either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > > > > On 3/24/22 13:39, Sughosh Ganu wrote: > > While building a capsule, the GUID value of that specific image is to > > be passed through the --guid command option to the mkeficapsule > > tool. This renders the

Re: [PATCH v4 00/33] Initial implementation of standard boot

2022-03-24 Thread Tom Rini
On Wed, Mar 23, 2022 at 08:13:42PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 23 Mar 2022 at 14:09, Tom Rini wrote: > > > > On Wed, Mar 23, 2022 at 12:45:50PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 23 Mar 2022 at 08:05, Tom Rini wrote: > > > > > > > > On Sun, Mar 06,

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > > > > On 3/24/22 13:38, Sughosh Ganu wrote: > > Currently, all platforms that enable capsule updates do so using > > either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or > > EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is based on the Firmware > >

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
hi Masami, On Thu, 24 Mar 2022 at 19:14, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年3月24日(木) 21:39 Sughosh Ganu : > > > > Currently, all platforms that enable capsule updates do so using > > either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or > > EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This

Re: [PATCH] arm64: zynqmp: enable the PMUFW watchdog

2022-03-24 Thread Michal Simek
On 3/23/22 15:04, Jorge Ramirez-Ortiz wrote: From 528b3117a36b7b4eea1839afbea7191d60638b0c Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Wed, 23 Mar 2022 14:41:15 +0100 Subject: [PATCH] arm64: zynqmp: enable the PMUFW watchdog If the PMUFW was built with support for the CSU

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Michal Simek
On 3/24/22 13:38, Sughosh Ganu wrote: Currently, all platforms that enable capsule updates do so using either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is based on the Firmware Management Protocol(FMP) instance used on the platform. However, this

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Michal Simek
On 3/24/22 13:39, Sughosh Ganu wrote: While building a capsule, the GUID value of that specific image is to be passed through the --guid command option to the mkeficapsule tool. This renders the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values

Re: [PATCH 04/11] virtio: pci: Check virtio common config size

2022-03-24 Thread Bin Meng
On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > Check that the common config is at least as large as the struct it is > expected to contain. Only then is it safe to cast the pointer and be > safe from out-of-bounds accesses. > > Signed-off-by: Andrew Scull > --- >

Re: [PATCH 03/11] virtio: pci: Bounds check notification writes

2022-03-24 Thread Bin Meng
On Sun, Mar 20, 2022 at 7:41 PM Andrew Scull wrote: > > Make sure virtio notifications are written within their allocated > buffer. > > Signed-off-by: Andrew Scull > --- > drivers/virtio/virtio_pci_modern.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git

[PATCH v3 8/9] arm: dts: imx8mm_evk: add pwm1/backlight support

2022-03-24 Thread Tommaso Merciai
Add pwm1/backlight support nodes for imx8mm_evk board Signed-off-by: Tommaso Merciai --- arch/arm/dts/imx8mm-evk.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/dts/imx8mm-evk.dtsi b/arch/arm/dts/imx8mm-evk.dtsi index 60179e006d..e7a2bd8a64 100644 ---

[PATCH v3 9/9] configs: imx8mm_evk: add pwm backlight support

2022-03-24 Thread Tommaso Merciai
Enable support for backlight/pwm-imx driver Signed-off-by: Tommaso Merciai --- configs/imx8mm_evk_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/imx8mm_evk_defconfig b/configs/imx8mm_evk_defconfig index 01395fc7eb..cfba6cc673 100644 --- a/configs/imx8mm_evk_defconfig

[PATCH v3 4/9] drivers: pwm: pwm-imx: move pwm-imx-util into pwm-imx

2022-03-24 Thread Tommaso Merciai
Move pwm_imx_get_parms, pwm_id_to_reg functions into pwm-imx.c and drop off pwm-imx-util.c Signed-off-by: Tommaso Merciai --- drivers/pwm/Makefile | 2 +- drivers/pwm/pwm-imx-util.c | 80 -- drivers/pwm/pwm-imx-util.h | 15 ---

[PATCH v3 6/9] driver: pwm: pwm-imx: introduce pwm_dm_imx_get_parms

2022-03-24 Thread Tommaso Merciai
Introduce pwm_dm_imx_get_parms, dm version of pwm_imx_get_parms. This function get clock rate using clk dm api Signed-off-by: Tommaso Merciai --- drivers/pwm/pwm-imx.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-imx.c

[PATCH v3 7/9] driver: pwm: pwm-imx: separe dm from non dm implementation

2022-03-24 Thread Tommaso Merciai
Separe dm implementation from non dm implementation of pwm-imx driver using CONFIG_DM_PWM Signed-off-by: Tommaso Merciai --- drivers/pwm/pwm-imx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index

[PATCH v3 5/9] driver: pwm: pwm-imx: get and enable per/ipg clock using dm

2022-03-24 Thread Tommaso Merciai
Get and enable ipg/per pwms clocks using dm api into imx_pwm_of_to_plat and imx_pwm_probe driver function Signed-off-by: Tommaso Merciai --- drivers/pwm/pwm-imx.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c

[PATCH v3 3/9] clk: imx8mm: add pwm clocks support

2022-03-24 Thread Tommaso Merciai
Add clocks support for the PWM controllers. This is ported from Linux v5.17-rc8. Signed-off-by: Tommaso Merciai --- drivers/clk/imx/clk-imx8mm.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c index

[PATCH v3 2/9] arch: mach-imx: imx8m: add pwm_regs struct in imx-regs

2022-03-24 Thread Tommaso Merciai
Add pwm_regs struct for i.MX8MM SOC Signed-off-by: Tommaso Merciai --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h b/arch/arm/include/asm/arch-imx8m/imx-regs.h index 57a95de1b8..f31f54ad0c

[PATCH v3 1/9] arch: mach-imx: imx8m: add pwm ctrl registers fields defines

2022-03-24 Thread Tommaso Merciai
Add pwm control registers fields defines into imx-regs.h: - prescaler - dozeen - waiten - dbgen - clksrc_ipg_high - clksrc_ipg, en field References: - iMX8MMRM.pdf p 3884 Signed-off-by: Tommaso Merciai --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 8 1 file changed, 8

  1   2   >