Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Josua Mayer
Hi Stefan, Thank you for starting to review this patchset! Am 03.05.22 um 09:09 schrieb Stefan Roese: Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that   reviewers have a summary of the changes. I have sent a cover-letter t

Re: [PATCH 10/15] imx: kontron-sl-mx8mm: enable DM_SERIAL

2022-05-02 Thread Frieder Schrempf
Am 30.04.22 um 14:43 schrieb Peng Fan (OSS): > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart and its pinmux was already > marked with u-boot,dm-spl. > Move preloader_console_init after spl_init to make sure driver > model work. > > Signed-off-by: Peng Fan Acked-by: Frieder Schrempf > ---

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-02 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while creating a new API it makes sense to prepend the function names identical IMHO to not "pollute" t

Re: [PATCH 03/12] cmd: tlv_eeprom: do_tlv_eeprom: stop using non-api read_eeprom function

2022-05-02 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: IN the scope of do_tlv_eeprom, the error-checking provided by the Nitpicking: "In ..." read_eeprom function is not required. Instead use the API function read_tlv_eeprom. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH 02/12] cmd: tlv_eeprom: remove use of global variable has_been_read

2022-05-02 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: has_been_read is only used as an optimization for do_tlv_eeprom. Explicitly use and set inside this function, thus making read_eeprom stateless. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 25 - 1 file changed, 12 insertions

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Stefan Roese
Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that reviewers have a summary of the changes. - Please Cc the original author of this code Baruch Siach in the next version as well (if there is next version that is). On 02.05.2

[PATCH v6] pinctrl: nuvoton: Add NPCM8xx pinctrl driver

2022-05-02 Thread Stanley Chu
Add Nuvoton BMC NPCM845 Pinmux and Pinconf support. Signed-off-by: Stanley Chu --- v6: - sync pin name with Linux driver - add support for gpi35/gpi36/gpio183~189 v5: - lower-case hex consistently - use uint type for pin list in the group_config struct v4: - correct the pin flags, add slew r

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-02 Thread Stefan Roese
On 02.05.22 18:41, Pali Rohár wrote: MAX6370 watchdog is available e.g. on Freescale P1/P2 RDB-PC boards. Signed-off-by: Pali Rohár --- drivers/watchdog/Kconfig | 7 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/max6370_wdt.c | 119 + 3

Re: [PATCH V2 2/4] mtd: nand: mxs_nand_spl: Fix bad block skipping

2022-05-02 Thread Michael Nazzareno Trimarchi
Hi Han On Mon, May 2, 2022 at 11:32 PM Han Xu wrote: > > On 22/05/01 08:36AM, Michael Nazzareno Trimarchi wrote: > > Dear Han and Fabio > > > > On Thu, Apr 28, 2022 at 7:01 AM Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi > > > > > > On Thu, Apr 28, 2022 at 2:27 AM Han Xu wrote: > > > >

Re: [PATCH] efi_loader: Select EVENT as well

2022-05-02 Thread Jan Kiszka
On 28.04.22 13:04, Heinrich Schuchardt wrote: > On 4/28/22 12:03, Jan Kiszka wrote: >> On 27.04.22 07:55, AKASHI Takahiro wrote: >>> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote: From: Jan Kiszka Fixes WARNING: unmet direct dependencies detected for EVENT_DYN

Re: [PATCH 11/15] imx: imx8mn_bsh_smm_s2: drop CONFIG_MXC_UART_BASE

2022-05-02 Thread Peng Fan (OSS)
Hi Stefano, On 2022/4/30 20:43, Peng Fan (OSS) wrote: From: Peng Fan CONFIG_DM_SERIAL is enabled, this macro not needed. I squashed this patch to "[PATCH V2] imx: drop CONFIG_MXC_UART_BASE" Thanks, Peng. Signed-off-by: Peng Fan --- include/configs/imx8mn_bsh_smm_s2_common.h | 2 --

Re: [PATCH 02/15] imx: imx8m[m/n/p]_venice: Enable SPL_DM_SERIAL

2022-05-02 Thread Peng Fan (OSS)
On 2022/5/3 0:59, Tim Harvey wrote: On Sat, Apr 30, 2022 at 5:01 AM Peng Fan (OSS) wrote: From: Peng Fan Enable CONFIG_SPL_DM_SERIAL. uart2 and its pinmux was already marked with u-boot,dm-spl. Move preloader_console_init after spl_early_init to make sure driver model work. Signed-off-by

[PATCH V2] imx: drop CONFIG_MXC_UART_BASE

2022-05-02 Thread Peng Fan (OSS)
From: Peng Fan Since these boards has CONFIG_DM_SERIAL and/or CONFIG_SPL_DM_SERIAL, the legacy macro no need to be defined. Reviewed-by: Heiko Schocher Reviewed-by: Fabio Estevam Signed-off-by: Peng Fan --- V2: Add R-b Drop comments add imx8mn_bsh_smm_s2_common.h include/configs/aristai

RE: [PATCH] pwm: aspeed: Select SYSCON to get parent detail.

2022-05-02 Thread ChiaWei Wang
> From: Billy Tsai > Sent: Friday, April 29, 2022 11:51 AM > > To work correctly, this driver depends on SYSCON to get the base address from > the parent dts node. > > Signed-off-by: Billy Tsai > --- > drivers/pwm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/Kc

Re: [PATCH 00/12] sunxi: Devicetree sync from Linux v5.18-rc1

2022-05-02 Thread Samuel Holland
On 4/30/22 7:59 PM, Andre Przywara wrote: >>> So those DT updates are really only important for mobile devices like >>> the >>> Pinephone, which probably don't use UEFI booting. >> >> We would really like to use UEFI booting on the PinePhone, and the >> out-of-date >> devicetree is

Re: [RFC PATCH] efi_loader: add sha384/512 on certificate revocation

2022-05-02 Thread Stuart Yoder
On 4/11/22 3:40 AM, Ilias Apalodimas wrote: Hi Akashi-san, On Mon, Apr 11, 2022 at 05:31:08PM +0900, AKASHI Takahiro wrote: On Mon, Apr 11, 2022 at 10:56:22AM +0300, Ilias Apalodimas wrote: Currently we don't support sha384/512 for the X.509 certificate To-Be-Signed contents. Moreover if w

Re: [PATCH V2 2/4] mtd: nand: mxs_nand_spl: Fix bad block skipping

2022-05-02 Thread Han Xu
On 22/05/01 08:36AM, Michael Nazzareno Trimarchi wrote: > Dear Han and Fabio > > On Thu, Apr 28, 2022 at 7:01 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > On Thu, Apr 28, 2022 at 2:27 AM Han Xu wrote: > > > > > > > > > > > > > -Original Message- > > > > From: Michael Trimar

Re: [PATCH 08/15] imx: imx8mn_var_som: enable DM_SERIAL

2022-05-02 Thread Ariel D'Alessandro
Hi Peng, On 4/30/22 09:43, Peng Fan (OSS) wrote: > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart and its pinmux was already > marked with u-boot,dm-spl. > Move preloader_console_init after spl_init to make sure driver > model work. > > Signed-off-by: Peng Fan > --- > board/variscite/imx8mn

Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

2022-05-02 Thread Daniel Schwierzeck
Hi Stefan, Am 02.05.22 um 18:00 schrieb Stefan Roese: Hi Daniel, On 07.04.22 09:11, Stefan Roese wrote: This patchset adds the networking files and drivers including device helper headers and C files. Please excuse the massive amount of files in this patch series. Also the sometimes huge files

Re: [PATCH 02/15] imx: imx8m[m/n/p]_venice: Enable SPL_DM_SERIAL

2022-05-02 Thread Tim Harvey
On Sat, Apr 30, 2022 at 5:01 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Enable CONFIG_SPL_DM_SERIAL. uart2 and its pinmux was already > marked with u-boot,dm-spl. > Move preloader_console_init after spl_early_init to make sure driver > model work. > > Signed-off-by: Peng Fan > --- > board/

[PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-02 Thread Pali Rohár
MAX6370 watchdog is available e.g. on Freescale P1/P2 RDB-PC boards. Signed-off-by: Pali Rohár --- drivers/watchdog/Kconfig | 7 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/max6370_wdt.c | 119 + 3 files changed, 127 insertions(+) create m

[PATCH 1/2] powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support for NOR booting

2022-05-02 Thread Pali Rohár
Commit e8c0e0064c8a ("powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support") fixed SD card booting on mpc85xx boards but broke NOR booting on these boards. Reason is that U-Boot build system for NOR images uses binman and this binman ignores alignment defined in linker script. Instead it has own config

[PATCH 2/2] powerpc: mpc85xx: Fix CONFIG_OF_EMBED support for NOR booting

2022-05-02 Thread Pali Rohár
mpc85xx NOR binary contains also reset vector and therefore option CONFIG_MPC85XX_HAVE_RESET_VECTOR must be defined. When build system uses binman, it takes care of constructing final image which consist of u-boot-without-reset-vector, DTB and reset-vector. CONFIG_OF_EMBED does not use binman, th

[PATCH 0/2] powerpc: mpc85xx: Fix NOR booting

2022-05-02 Thread Pali Rohár
NOR version of U-Boot for mpc85xx is currently broken. NOR booting with CONFIG_OF_SEPARATE is broken since my commit e8c0e0064c8a ("powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support") which was merged into master few days ago and was fixing SD card booting. NOR booting with CONFIG_OF_EMBED seems t

[PATCH] powerpc: mpc85xx: Set default SYS_IMMR value for P1/P2 CPUs

2022-05-02 Thread Pali Rohár
This reduce usage of per-board custom settings. Signed-off-by: Pali Rohár --- arch/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 7ecb375b6b5a..920dadea5dcc 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -369,6 +369,9 @@ config SYS_IMMR

[PATCH] mtd: rawnand: fsl_elbc: Fix DM support in DTS code path

2022-05-02 Thread Pali Rohár
For proper DM support it is required to fill also mtd->dev member. Otherwise DM would not see nand device at all. Signed-off-by: Pali Rohár --- drivers/mtd/nand/raw/fsl_elbc_nand.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_elbc_nand.c

Re: [PATCH v2 03/12] sandbox: Migrate getopt section to linker list

2022-05-02 Thread Tom Rini
On Mon, May 02, 2022 at 09:24:52AM -0700, Andrew Scull wrote: > On Fri, 29 Apr 2022 at 08:11, Tom Rini wrote: > > > > On Thu, Apr 14, 2022 at 01:59:32PM +, Andrew Scull wrote: > > > > > Use the common infrastructure to create a linker list of the sandbox > > > command line flags rather than us

[PATCH] board: freescale: p1_p2_rdb_pc: Allow to compile without CONFIG_BOARDNAME

2022-05-02 Thread Pali Rohár
Signed-off-by: Pali Rohár --- board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c index 53ff121d3b3d..0b10701f4d48 100644 --- a/board/freesca

Re: [PATCH v2 03/12] sandbox: Migrate getopt section to linker list

2022-05-02 Thread Andrew Scull
On Fri, 29 Apr 2022 at 08:11, Tom Rini wrote: > > On Thu, Apr 14, 2022 at 01:59:32PM +, Andrew Scull wrote: > > > Use the common infrastructure to create a linker list of the sandbox > > command line flags rather than using a custom method. > > > > The list is changed from containing pointers

Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

2022-05-02 Thread Stefan Roese
Hi Daniel, On 07.04.22 09:11, Stefan Roese wrote: This patchset adds the networking files and drivers including device helper headers and C files. Please excuse the massive amount of files in this patch series. Also the sometimes huge files (mostly headers with register definitions) that I neede

Please pull u-boot-marvell/master

2022-05-02 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - Misc turris_omnia/mox related Fixes and impovements (Pali) - Turris Omnia: Add support for configuring mSATA and WWAN slots via env variables (Pali) - net: mvgbe:

Re: [PATCH] ARM: mvebu: x530: set MPP55 to gpio

2022-05-02 Thread Stefan Roese
On 02.05.22 05:16, Chris Packham wrote: MPP55 is used as a reset connected to the L3 switch chip. This doesn't matter for u-boot as it doesn't use the L3 switch but it is useful to be able to toggle the switch in/out of reset for the OS. Signed-off-by: Chris Packham --- I sent this out a while

Re: [PATCH] arm: mvebu: clearfog_defconfig: enable setexpr command

2022-05-02 Thread Stefan Roese
On 29.04.22 17:49, Josef Schlehofer wrote: This command is useful in U-boot scripts and it is being used by OpenWrt bootscript for this board [1]. Otherwise shell scripting commands are enabled by default in cmd/Kconfig. [1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6

Re: [PATCH] arm: mvebu: turris_omnia: Fix SYS_RSTOUT_* macro names

2022-05-02 Thread Stefan Roese
On 29.04.22 13:53, Pali Rohár wrote: This is A385 register. Signed-off-by: Pali Rohár Applied to u-boot-marvell/master Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_o

Re: [PATCH] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-05-02 Thread Stefan Roese
On 17.04.22 22:42, Tony Dinh wrote: The Zyxel NSA310s board has the network chip Marvell Alaska 88E1318S. Use uclass mvgbe and the compatible driver M88E1310 driver to bring up Ethernet. - Use uclass mvgbe to bring up the network. And remove ad-hoc code. - Remove CONFIG_RESET_PHY_R. - Enable CON

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-05-02 Thread Stefan Roese
Applied to u-boot-marvell/master Thanks, Stefan On 26.04.22 00:01, Tony Dinh wrote: Hi Stefan, On Mon, Apr 25, 2022 at 4:18 AM Stefan Roese wrote: Hi Tony, On 4/25/22 11:33, Tony Dinh wrote: Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: Hi Tony, On 4/23/22 04:15, To

Re: [PATCH 5/5] arm: mvebu: turris_mox: Add NVMe and SCSI to boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Mox has already enabled NVMe and SCSI support. So add NVMe and SCSI to boot targets. Signed-off-by: Pali Rohár --- include/configs/turris_mox.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/turris_mox.h b/include/

Re: [PATCH 4/5] arm: mvebu: turris_omnia: Add NVMe to boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Omnia has already enabled NVMe support. So add NVMe to boot targets. Signed-off-by: Pali Rohár --- include/configs/turris_omnia.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/turris_omnia.h b/include/configs/turris

Re: [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Omnia is always compiled with MMC, SCSI and USB support, so always enable macros for booting from these devices. Signed-off-by: Pali Rohár --- include/configs/turris_omnia.h | 24 +++- 1 file changed, 3 insertions(+),

Re: [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: CONFIG_ETHPRIME defines primary ethernet device and env variable $ethact stores currently active ethernet device. So there is no point to set ethact= in default environment. Instead set CONFIG_ETHPRIME properly. Signed-off-by: Pali Rohár --- include/confi

Re: [PATCH 1/5] arm: mvebu: turris_omnia: Fix RESET button message

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: Signed-off-by: Pali Rohár --- board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c index 83cfc80d1930..97292456f148

Re: [PATCH u-boot-marvell 0/8] Turris Omnia: Add support for configuring mSATA and WWAN slots via env variables

2022-05-02 Thread Stefan Roese
On 02.03.22 12:47, Pali Rohár wrote: Some mPCIe cards are broken and their PIN 43 incorrectly that card is mSATA. U-Boot SPL on Turris Omnia is using PIN 43 for configuring PCIe vs SATA functionality on SerDes. Allow to configure functionality via additional env variable "omnia_msata_slot" which

[PATCH] board_r: use IS_ENABLED(CONFIG_NEEDS_MANUAL_RELOC) in board_init_r()

2022-05-02 Thread Ovidiu Panait
Drop CONFIG_NEEDS_MANUAL_RELOC ifdefs in board_init_r() and use IS_ENABLED() instead. Also, use the MANUAL_RELOC() macro to update the initcall pointers. Signed-off-by: Ovidiu Panait --- common/board_r.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/common/bo

Re: SquashFS not compiling due to missing __udivmoddi4 (x86)

2022-05-02 Thread Tom Rini
On Mon, May 02, 2022 at 12:39:32PM +0200, Sean Nyekjaer wrote: > Hi, > > I'm trying to build Squashfs for u-boot for x86. > > Looks like we are missing some libgcc helper function. > > ld.bfd: fs/squashfs/sqfs.o: in function `sqfs_read': > /home/sean/development/siemens/u-boot/fs/squashfs/sqfs.

[PATCH 10/12] cmd: tlv_eeprom: split off tlv library from command

2022-05-02 Thread Josua Mayer
The eeprom command includes functions for reading and writing tlv-formatted data from an eeprom, as well as an implementation of the cli command tlv_eeprom. Split off the parsing, read and write into a standalone tlv library. Signed-off-by: Josua Mayer --- cmd/Kconfig | 2 + cmd/tlv_

[PATCH 12/12] lib: tlv_eeprom: add function for reading one entry into a C string

2022-05-02 Thread Josua Mayer
This solves the potentially common problem of getting a specific tlv entry from an eeprom in board-files, without having to introduce several variables, error handling, memcpy and 0-terminating the string. Signed-off-by: Josua Mayer --- include/tlv_eeprom.h | 12 lib/tlv/tlv_eeprom.

[PATCH 09/12] cmd: tlv_eeprom: add my copyright

2022-05-02 Thread Josua Mayer
While each of the previous individual changes is small, accumulated they amount to a substantial effort. Explicitly add a Copyright declaration. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c index c110927cb

[PATCH 11/12] arm: mvebu: clearfog: enable tlv library for spl in favour of eeprom cmd

2022-05-02 Thread Josua Mayer
The board file used CONFIG_SPL_CMD_TLV_EEPROM as a library to facilitate reading tlv data with the memory size from eeprom. Since the tlv library has been split off, only CONFIG_SPL_EEPROM_TLV_LIB is required now. Signed-off-by: Josua Mayer --- configs/clearfog_defconfig | 3 ++- 1 file changed,

[PATCH 07/12] cmd: tlv_eeprom: hide access to static tlv_devices array behind accessor

2022-05-02 Thread Josua Mayer
The tlv_eeprom command logic checks the static tlv_devices array to validate the eeprom number. This array will be move to a separate tlv library. Hide this access behind a new function exists_tlv_eeprom. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 12 ++-- include/tlv_eeprom.h

[PATCH 08/12] cmd: tlv_eeprom: clean up two defines for one thing

2022-05-02 Thread Josua Mayer
MAX_TLV_DEVICES defined in C, and TLV_MAX_DEVICES defined in the header serve the same purpose. Replace all occurences of the former by the latter. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/cmd/tlv_eeprom.c b/

[PATCH 06/12] cmd: tlv_eeprom: move missing declarations and defines to header

2022-05-02 Thread Josua Mayer
In preparation of splitting the tlv_eeprom command into a separate library, add function declarations and defines used by the command logic to the tlv_eeprom header file. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 59 include/tlv_eeprom.h |

[PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-02 Thread Josua Mayer
- prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 56 +++ include/tlv_eeprom.h | 57 +

[PATCH 05/12] cmd: tlv_eeprom: remove empty function implementations from header

2022-05-02 Thread Josua Mayer
tlv_eeprom exposed functions are independent from platforms, hence no stubs are required. Signed-off-by: Josua Mayer --- include/tlv_eeprom.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/include/tlv_eeprom.h b/include/tlv_eeprom.h index 30626a1067

[PATCH 02/12] cmd: tlv_eeprom: remove use of global variable has_been_read

2022-05-02 Thread Josua Mayer
has_been_read is only used as an optimization for do_tlv_eeprom. Explicitly use and set inside this function, thus making read_eeprom stateless. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/cmd/tlv

[PATCH 03/12] cmd: tlv_eeprom: do_tlv_eeprom: stop using non-api read_eeprom function

2022-05-02 Thread Josua Mayer
IN the scope of do_tlv_eeprom, the error-checking provided by the read_eeprom function is not required. Instead use the API function read_tlv_eeprom. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/tlv_eeprom.c b/cmd/tlv

[PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Josua Mayer
Make tlv_eeprom command device selection an explicit parameter of all function calls. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 50 ++-- include/tlv_eeprom.h | 3 ++- 2 files changed, 27 insertions(+), 26 deletions(-) diff --git a/cmd/tlv_eep

[PATCH 00/12] split tlv_eeprom command into a separate library

2022-05-02 Thread Josua Mayer
The tlv_eeprom command provides much more than just a cli command: - de- and encoding tlv format - for reading and writing eeprom - setting the eth?addr environment variable - setting the serial# environment variable One device (Clearfog) is already using the decoding functionality to choose the c

Re: [PATCH 1/5] phy: adin: remove broken support for adi,phy-mode-override

2022-05-02 Thread Nate Drude
Hi Josua, On Sun, 2022-05-01 at 15:41 +0300, Josua Mayer wrote: > The adin_get_phy_mode_override function does not compile, because it > is > missing both declaration and implementation of > phy_get_interface_by_name. > > Remove the whole function for now, since the missing implementation > is >

[PATCH V2] configs: drop CONFIG_SPL_ABORT_ON_RAW_IMAGE

2022-05-02 Thread Peng Fan (OSS)
From: Peng Fan CONFIG_SPL_RAW_IMAGE_SUPPORT default y has been used to replace CONFIG_SPL_ABORT_ON_RAW_IMAGE for quite some time, so drop CONFIG_SPL_ABORT_ON_RAW_IMAGE. Signed-off-by: Peng Fan --- V2: Drop comments include/configs/capricorn-common.h | 1 - include/configs/cgtqmx8.h

[PATCH] configs: drop CONFIG_SPL_ABORT_ON_RAW_IMAGE

2022-05-02 Thread Peng Fan (OSS)
From: Peng Fan CONFIG_SPL_RAW_IMAGE_SUPPORT default y has been used to replace CONFIG_SPL_ABORT_ON_RAW_IMAGE for quite some time, so drop CONFIG_SPL_ABORT_ON_RAW_IMAGE. Signed-off-by: Peng Fan --- include/configs/capricorn-common.h | 1 - include/configs/cgtqmx8.h |

[PATCH v1] arm: dts: rockchip: rk3288: move dma-controller nodes

2022-05-02 Thread Johan Jonker
In order to better compare the Linux rk3288.dtsi version with the u-boot version move the dma-controller nodes to the DT root. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3288.dtsi | 76 ++-- 1 file changed, 35 insertions(+), 41 deletions(-) diff --git a/a

SquashFS not compiling due to missing __udivmoddi4 (x86)

2022-05-02 Thread Sean Nyekjaer
Hi, I'm trying to build Squashfs for u-boot for x86. Looks like we are missing some libgcc helper function. ld.bfd: fs/squashfs/sqfs.o: in function `sqfs_read': /home/sean/development/siemens/u-boot/fs/squashfs/sqfs.c:1443: undefined reference to `__udivmoddi4' ld.bfd: /home/sean/development/si

[PATCH v1] arm: dts: rockchip: rk3288: sort mipi hdmi lvds and dp nodes

2022-05-02 Thread Johan Jonker
In order to better compare the Linux rk3288.dtsi version with the u-boot version sort the mipi,hdmi,lvds and dp nodes. Changed: Rename mipi_dsi label. Rename dp nodename. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3288-evb.dtsi | 2 +- arch/arm/dts/rk3288.dtsi | 110 ++

[PATCH v1] arm: dts: rockchip: rk3288: rename mmc nodenames

2022-05-02 Thread Johan Jonker
The boot_devices constants for rk3288 were changed to match the binding, but the dtsi file was not synced. Fix by renaming the rk3288 mmc node names. Also correct the clock name for "ciu-drive". Signed-off-by: Johan Jonker --- arch/arm/dts/rk3288.dtsi | 16 1 file changed, 8 ins

Re: [PATCH 1/2] misc: i2c_eeprom: add support for microchip 24aa025e48

2022-05-02 Thread Michael Walle
> 24aa025e48 is a variant of 24aa02e48 that has a page size of 16 bytes. > > Signed-off-by: Eugen Hristev > --- > drivers/misc/i2c_eeprom.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c > index 89a450d0f8..265c1d0591 10064

[PATCH v1] arm: dts: rockchip: rk3288: bulk convert gpios to their constant counterparts

2022-05-02 Thread Johan Jonker
Bulk convert rk3288 DT gpios to their constant counterparts. Partial Linux sync for the rk3288.dtsi file. ARM: dts: rockchip: bulk convert gpios to their constant counterparts https://lore.kernel.org/all/20190402121852.14442-1-he...@sntech.de/ sed -i -f script.sed rk3288.dtsi ==

Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM

2022-05-02 Thread Patrick DELAUNAY
Hi, On 5/1/22 18:43, Marek Vasut wrote: Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Patrice Chotard Cc: Ramon

Re: [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM

2022-05-02 Thread Patrick DELAUNAY
Hi Marek, On 5/1/22 18:43, Marek Vasut wrote: The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which

Re: [PATCH u-boot-marvell 13/19] net: mvneta: Don't check for CONFIG_PHYLIB

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop checking for CONFIG_PHYLIB in mvneta, this is already done in Kconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 4 1 file changed, 4 deletions(-) diff --git a/dri

Re: [PATCH u-boot-marvell 19/19] net: mvneta: Drop unneeded macro

2022-05-02 Thread Stefan Roese
On 27.04.22 12:42, Marek Behún wrote: From: Marek Behún Macro MVNETA_GMAC_FORCE_LINK_UP can be dropped from value assignment in fixed link case, since it's value is written into the register later in the function for link-down-to-link-up case. The value is written as MVNETA_GMAC_FORCE_LINK_DOWN

Re: [PATCH u-boot-marvell 18/19] net: mvneta: Disable fixed PHY code if PHY_FIXED is not compiled in

2022-05-02 Thread Stefan Roese
On 27.04.22 12:42, Marek Behún wrote: From: Marek Behún Guard the code handling the fixed PHY case by CONFIG_IS_ENABLED(PHY_FIXED). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-

Re: [PATCH u-boot-marvell 16/19] net: mvneta: Write PHY address just before enabling HW polling

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Write PHY address just before enabling HW polling of the PHY. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH u-boot-marvell 17/19] net: mvneta: Drop fixed_link member from private struct

2022-05-02 Thread Stefan Roese
On 27.04.22 12:42, Marek Behún wrote: From: Marek Behún Since this member is checked only at two places drop it and inline it's usage. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletio

Re: [PATCH u-boot-marvell 15/19] net: mvneta: Convert to use PHY_FIXED for fixed-link

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Stop parsing fixed-link in the MAC driver. Instead support only PHY mode and let the fixed PHY driver handle the fixed-link case. Enable CONFIG_PHY_FIXED for mvneta boards that need it: Turris Omnia and ESPRESSObin. Signed-off-by: Marek

Re: [PATCH u-boot-marvell 14/19] net: mvneta: Rename CONFIG_NR_CPUS to MVNETA_NR_CPUS

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún The CONFIG_* macros are reserved for Kconfig. This was probably done when this driver was being imported from Linux. Rename the macro. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c

Re: [PATCH u-boot-marvell 12/19] net: mvneta: Drop unnecessary space

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop unnecessary space in mvneta_adjust_link(). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvneta

Re: [PATCH u-boot-marvell 11/19] net: mvneta: Use bool instead of int for boolean variable

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Use the bool type instead of int for status_change variable. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH u-boot-marvell 10/19] net: mvneta: Drop one indentation level in mvneta_adjust_link()

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop one indentation level in the mvneta_adjust_link() function. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 38 ++ 1 file changed, 18 inser

Re: [PATCH u-boot-marvell 09/19] net: mvneta: Fix unused variable warning if DM_GPIO is disabled

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún The `ret` variable in mvneta_probe() is unused if DM_GPIO is disabled. Since the variable is used only once after assigning value, we can inline the usage and drop the variable. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese T

Re: [PATCH u-boot-marvell 08/19] net: mvneta: Don't register MDIO bus

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún This MDIO bus is now handled by a proper mvmdio DM driver. Remove it from mvneta. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 143 +-- 1

Re: [PATCH u-boot-marvell 06/19] net: mdio-uclass: add dm_phy_find_by_ofnode() helper

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Add helper to resolve PHY node from it's ofnode via DM MDIO subsystem. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- include/miiphy.h | 9 + net/mdio-uclass.c | 22 ++ 2

Re: [PATCH u-boot-marvell 07/19] arm: mvebu: turris_mox: Use DM registered MDIO

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún In order to be able to get rid of the non-DM MDIO bus registered in mvneta driver, start using the DM registered one in Turris MOX board code. This also allows us to drop the hack introduced in MOX' -u-boot.dtsi file. Signed-off-by: Mare