Re: [PATCH 0/8] arm: mvebu: Add Armada 38x pin muxing support

2022-07-28 Thread Tony Dinh
Hi Pali, After correcting my MPP configuration in board_early_init, I ran the test again with this patch series. Everything works (upon u-boot startup) : Ethernet, SPI, SATA and USB. Board: Synology DS116, Armada 385 (out-of-tree u-boot) Tested-by: Tony Dinh Thanks, Tony On Mon, Jul 25, 2022

Re: [PATCH] rockchip: rk3399: boot_devices: fix eMMC node name

2022-07-28 Thread Art Nikpal
On Mon, Jul 18, 2022 at 5:19 PM Quentin Schulz wrote: > > On 7/11/22 20:22, Xavier Drudis Ferran wrote: > > El Mon, Jul 11, 2022 at 04:15:33PM +0200, Quentin Schulz deia: > >> From: Quentin Schulz > >> > >> When idbloader.img is flashed on the eMMC, the SPL still tries to load > >> from SPI-NOR

Re: [PATCH 8/8] arm: mvebu: turris_omnia: Enable a38x pinctrl and gpio support

2022-07-28 Thread Tony Dinh
Hi Pali, I noticed that PINCTRL_FULL is default to Y already in Kconfig. Is it normal practice to include it in the defconfig anyway? ./drivers/pinctrl/Kconfig config PINCTRL_FULL bool "Support full pin controllers" depends on PINCTRL && OF_CONTROL default y All the

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 09:43:23PM +0200, Pali Rohár wrote: > On Thursday 28 July 2022 15:26:08 Tom Rini wrote: > > On Thu, Jul 28, 2022 at 09:21:52PM +0200, Pali Rohár wrote: > > > On Thursday 28 July 2022 15:18:03 Tom Rini wrote: > > > > On Thu, Jul 28, 2022 at 09:05:07PM +0200, Pali Rohár

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 15:26:08 Tom Rini wrote: > On Thu, Jul 28, 2022 at 09:21:52PM +0200, Pali Rohár wrote: > > On Thursday 28 July 2022 15:18:03 Tom Rini wrote: > > > On Thu, Jul 28, 2022 at 09:05:07PM +0200, Pali Rohár wrote: > > > > On Thursday 28 July 2022 14:53:49 Tom Rini wrote: > > >

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 09:21:52PM +0200, Pali Rohár wrote: > On Thursday 28 July 2022 15:18:03 Tom Rini wrote: > > On Thu, Jul 28, 2022 at 09:05:07PM +0200, Pali Rohár wrote: > > > On Thursday 28 July 2022 14:53:49 Tom Rini wrote: > > [snip] > > > > +When it has been determined that the practical

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 15:18:03 Tom Rini wrote: > On Thu, Jul 28, 2022 at 09:05:07PM +0200, Pali Rohár wrote: > > On Thursday 28 July 2022 14:53:49 Tom Rini wrote: > [snip] > > > +When it has been determined that the practical solution for where to have > > > +something is in the ``CFG``

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 09:05:07PM +0200, Pali Rohár wrote: > On Thursday 28 July 2022 14:53:49 Tom Rini wrote: [snip] > > +When it has been determined that the practical solution for where to have > > +something is in the ``CFG`` namespace, the next decision is where to place > > these > >

Re: [RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 14:53:49 Tom Rini wrote: > Start by describing in general the best practices for how to implement > configuration of some aspect of U-Boot. This generally means finding > the right choices for when something should be static or dynamically > configured and enabled. Then

[RFCv2] doc: develop: Describe system configuration

2022-07-28 Thread Tom Rini
Start by describing in general the best practices for how to implement configuration of some aspect of U-Boot. This generally means finding the right choices for when something should be static or dynamically configured and enabled. Then further document when to use CONFIG or CFG namespaces for

Re: [RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Heinrich Schuchardt
Am 28. Juli 2022 19:53:34 MESZ schrieb Tom Rini : >On Thu, Jul 28, 2022 at 06:44:56PM +0200, Heinrich Schuchardt wrote: >> >> >> Am 28. Juli 2022 15:20:46 MESZ schrieb Tom Rini : >> >Document how and when to use CONFIG or CFG namespace for options. There >> >are times where Kconfig is not a

Re: [RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 06:44:56PM +0200, Heinrich Schuchardt wrote: > > > Am 28. Juli 2022 15:20:46 MESZ schrieb Tom Rini : > >Document how and when to use CONFIG or CFG namespace for options. There > >are times where Kconfig is not a great fit for our needs, so we want to > >use the CFG

[PATCH 5/5] configs: imx8mn_bsh_smm_s2: Use nand_base ident for nand identification

2022-07-28 Thread Michael Trimarchi
The board can mount different nand brand type. Try to use the full scan detection and not the onfi one Signed-off-by: Michael Trimarchi --- configs/imx8mn_bsh_smm_s2_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/imx8mn_bsh_smm_s2_defconfig

[PATCH 4/5] mtd: nand: samsung: Retrieve ECC requirements from extended

2022-07-28 Thread Michael Trimarchi
Upstream linux commit 8fc82d456e40a0. On some nand controllers with hw-ecc the controller code wants to know the ecc strength and size and having these as 0, 0 is not accepted. Specifying these in devicetree is possible but undesirable as the nand may be different in different production runs of

[PATCH 3/5] mtd: nand: Rename nand_get_flash_type() into nand_detect()

2022-07-28 Thread Michael Trimarchi
Upstream linux commit 7bb427990ee364. Rename the function to match this new behavior. NOTE: fix nand_detect/nand_get_flash_type parameters in mxs_nand_spl. This code seems never executed by any board as alternative for nand detect Signed-off-by: Michael Trimarchi ---

[PATCH 2/5] mtd: nand: change return type of nand_get_flash_type() to int

2022-07-28 Thread Michael Trimarchi
Upstream linux commit 4722c0e958e636. The returned "type" is never used in nand_scan_ident() and spl code Make nand_get_flash_type() simply return an integer value in order to avoid unnecessary ERR_PTR/PTR_ERR dance. Signed-off-by: Michael Trimarchi --- drivers/mtd/nand/raw/mt7621_nand.c |

[PATCH 1/5] mtd: nand: Rename the nand_manufacturers struct

2022-07-28 Thread Michael Trimarchi
Upstream linux commit 8cfb9ab68f9070. Drop the 's' at the end of nand_manufacturers since the struct is actually describing a single manufacturer, not a manufacturer table. Signed-off-by: Michael Trimarchi --- drivers/mtd/nand/raw/nand_base.c | 4 ++-- drivers/mtd/nand/raw/nand_ids.c | 2 +-

[PATCH 0/5] Another smaller update to the nand stack

2022-07-28 Thread Michael Trimarchi
Update the stack to move it slowly to linux with some improvements. We want to support more samsung variant and clean up a bit the code. This will be the last upstream changes for now until a quick review of spl code will be done to reduce duplication. I decided to move the imx8mn_bsh_smm_s2 board

Re: [RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Heinrich Schuchardt
Am 28. Juli 2022 15:20:46 MESZ schrieb Tom Rini : >Document how and when to use CONFIG or CFG namespace for options. There >are times where Kconfig is not a great fit for our needs, so we want to >use the CFG namespace instead. > >Signed-off-by: Tom Rini >--- >RFCv1: >- This is essentially my

Re: [PATCH 4/8] pinctrl: Add third argument label for pinctrl_gpio_request() function

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 15:18:46 Stefan Roese wrote: > On 28.07.22 15:15, Pali Rohár wrote: > > On Thursday 28 July 2022 15:07:51 Stefan Roese wrote: > > > Hi Pali. > > > > > > On 25.07.22 13:56, Pali Rohár wrote: > > > > This change allows to use pinctrl_gpio_request() function as a direct > >

Re: [PATCH] pci: pci_mvebu: Add support for reset-gpios

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 17:13:12 Stefan Roese wrote: > On 28.07.22 17:10, Pali Rohár wrote: > > On Thursday 28 July 2022 17:05:38 Stefan Roese wrote: > > > On 28.07.22 15:03, Pali Rohár wrote: > > > > Release PERST# signal via GPIO when "reset-gpios" is defined in device > > > > tree. > > > > >

Re: [PATCH] pci: pci_mvebu: Add support for reset-gpios

2022-07-28 Thread Stefan Roese
On 28.07.22 17:10, Pali Rohár wrote: On Thursday 28 July 2022 17:05:38 Stefan Roese wrote: On 28.07.22 15:03, Pali Rohár wrote: Release PERST# signal via GPIO when "reset-gpios" is defined in device tree. Signed-off-by: Pali Rohár --- drivers/pci/pci_mvebu.c | 14 ++ 1 file

Re: [PATCH] pci: pci_mvebu: Add support for reset-gpios

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 17:05:38 Stefan Roese wrote: > On 28.07.22 15:03, Pali Rohár wrote: > > Release PERST# signal via GPIO when "reset-gpios" is defined in device tree. > > > > Signed-off-by: Pali Rohár > > --- > > drivers/pci/pci_mvebu.c | 14 ++ > > 1 file changed, 14

Re: [PATCH] pci: pci_mvebu: Add support for reset-gpios

2022-07-28 Thread Stefan Roese
On 28.07.22 15:03, Pali Rohár wrote: Release PERST# signal via GPIO when "reset-gpios" is defined in device tree. Signed-off-by: Pali Rohár --- drivers/pci/pci_mvebu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index

[PATCH] board: ls1043ardb: fdt fixups for revision v7.0 boards

2022-07-28 Thread Camelia Groza
From: Camelia Groza The LS1043ARDB rev v7.0 board replaces the AQR105 PHY on MAC9 with an AQR113C PHY. The address of the PHY on the MDIO bus changes from 0x1 to 0x8. Enable CONFIG_OF_BOARD_FIXUP and update both u-boot and Linux device trees to reflect this change. Signed-off-by: Camelia Groza

Re: [RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 03:34:43PM +0200, Pali Rohár wrote: > On Thursday 28 July 2022 09:20:46 Tom Rini wrote: > > Document how and when to use CONFIG or CFG namespace for options. There > > are times where Kconfig is not a great fit for our needs, so we want to > > use the CFG namespace

Re: [RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 09:20:46 Tom Rini wrote: > Document how and when to use CONFIG or CFG namespace for options. There > are times where Kconfig is not a great fit for our needs, so we want to > use the CFG namespace instead. > > Signed-off-by: Tom Rini > --- > RFCv1: > - This is

Re: [PATCH v6] board: purism: add the Purism Librem5 phone

2022-07-28 Thread Angus Ainslie
On 2022-07-26 00:35, Stefano Babic wrote: On 30.06.22 21:29, Angus Ainslie wrote: Hi Stefano, On 2022-06-30 12:09, Stefano Babic wrote: Hi Angus, On 30.06.22 19:30, Angus Ainslie wrote: Hi All, Are there any remaining issues with this patch ? Rather yes, it was supposed that issues with

Re: [PATCH v2 1/7] rockchip: generate idbloader.img content for u-boot-rockchip.bin with binman for ARM

2022-07-28 Thread Jagan Teki
On Fri, Jul 22, 2022 at 5:05 PM Quentin Schulz wrote: > > From: Quentin Schulz > > idbloader.img content - currently created by way of Makefile - can be > created by binman directly. > > So let's do that for Rockchip ARM platforms. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > --- >

[RFCv1] doc: develop: Describe using CONFIG vs CFG for values

2022-07-28 Thread Tom Rini
Document how and when to use CONFIG or CFG namespace for options. There are times where Kconfig is not a great fit for our needs, so we want to use the CFG namespace instead. Signed-off-by: Tom Rini --- RFCv1: - This is essentially my idea on how to better handle the problem of CONFIG values

Re: [PATCH 4/8] pinctrl: Add third argument label for pinctrl_gpio_request() function

2022-07-28 Thread Stefan Roese
On 28.07.22 15:15, Pali Rohár wrote: On Thursday 28 July 2022 15:07:51 Stefan Roese wrote: Hi Pali. On 25.07.22 13:56, Pali Rohár wrote: This change allows to use pinctrl_gpio_request() function as a direct pointer for dm_gpio_ops's .request callback. Signed-off-by: Pali Rohár Running a

Re: [PATCH] rockchip: rk3399: boot_devices: fix eMMC node name

2022-07-28 Thread Jagan Teki
On Mon, Jul 11, 2022 at 7:54 PM Quentin Schulz wrote: > > From: Quentin Schulz > > When idbloader.img is flashed on the eMMC, the SPL still tries to load > from SPI-NOR first. > > This is due to an incorrect look-up in the Device Tree. Since commit > 822556a93459 ("arm: dts: sync the Rockhip

Re: [PATCH 4/8] pinctrl: Add third argument label for pinctrl_gpio_request() function

2022-07-28 Thread Pali Rohár
On Thursday 28 July 2022 15:07:51 Stefan Roese wrote: > Hi Pali. > > On 25.07.22 13:56, Pali Rohár wrote: > > This change allows to use pinctrl_gpio_request() function as a direct > > pointer for dm_gpio_ops's .request callback. > > > > Signed-off-by: Pali Rohár > > Running a CI build on

Re: [PATCH 4/8] pinctrl: Add third argument label for pinctrl_gpio_request() function

2022-07-28 Thread Stefan Roese
Hi Pali. On 25.07.22 13:56, Pali Rohár wrote: This change allows to use pinctrl_gpio_request() function as a direct pointer for dm_gpio_ops's .request callback. Signed-off-by: Pali Rohár Running a CI build on Azure, I see these errors at least for this target: rzg2_beacon

[PATCH] pci: pci_mvebu: Add support for reset-gpios

2022-07-28 Thread Pali Rohár
Release PERST# signal via GPIO when "reset-gpios" is defined in device tree. Signed-off-by: Pali Rohár --- drivers/pci/pci_mvebu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index d80f87e0cfc6..269c027db204 100644 ---

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 08:51:01AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Thu, Jul 28, 2022 at 8:41 AM Tom Rini wrote: > > > > On Thu, Jul 28, 2022 at 10:05:40AM +0300, Josua Mayer wrote: > > > > > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > > > addresses.

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Fabio Estevam
Hi Tom, On Thu, Jul 28, 2022 at 8:41 AM Tom Rini wrote: > > On Thu, Jul 28, 2022 at 10:05:40AM +0300, Josua Mayer wrote: > > > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > > addresses. U-Boot needs to auto-detect which phy is actually present, > > and at which address

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 10:05:40AM +0300, Josua Mayer wrote: > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > addresses. U-Boot needs to auto-detect which phy is actually present, > and at which address it is responding. > > Auto-detection from multiple phy nodes

Re: [PATCH v2] boot: allow bootmeth-distro without CONFIG_NET

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 11:19:15AM +0100, John Keeping wrote: > Remove the dependency on CMD_PXE from BOOTMETH_DISTRO by introducing a > new hidden kconfig symbol to control whether pxe_utils is compiled, > allowing bootstd's distro method to be compiled without needing > networking support

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Tom Rini
On Thu, Jul 28, 2022 at 07:08:35AM +, Josua Mayer wrote: > Please hold off merging this patch until someone tested it, I can not do so > this week. > @Tom Can you confirm if this fixes the networking on your Cubox? > Also note that the phy-handle property may or may not be required, I am not >

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Fabio Estevam
Hi Josua, On Thu, Jul 28, 2022 at 4:08 AM Josua Mayer wrote: > > Please hold off merging this patch until someone tested it, I can not do so > this week. > @Tom Can you confirm if this fixes the networking on your Cubox? > Also note that the phy-handle property may or may not be required, I am

[PATCH v2 1/2] gpio: Add Turris Omnia MCU driver

2022-07-28 Thread Pali Rohár
This driver registers GPIO controller and allows U-Boot to control GPIO pins on MCU which is connected to Turris Omnia via i2c. Signed-off-by: Pali Rohár --- Changes in v2: * Remove invalid checks in xlate (GPIOF_* vs GPIO_* macros) * Fix parsing flags in xlate * Use gpio_flags_xlate(flags) for

[PATCH v2 2/2] arm: mvebu: turris_omnia: Add mcu node with gpio-controller

2022-07-28 Thread Pali Rohár
This allows U-Boot to register new Turris Omnia MCU driver. Signed-off-by: Pali Rohár --- Changes in v2: * Add missing #gpio-cells for phandle usage --- arch/arm/dts/armada-385-turris-omnia.dts | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH v2] boot: allow bootmeth-distro without CONFIG_NET

2022-07-28 Thread John Keeping
Remove the dependency on CMD_PXE from BOOTMETH_DISTRO by introducing a new hidden kconfig symbol to control whether pxe_utils is compiled, allowing bootstd's distro method to be compiled without needing networking support enabled. Signed-off-by: John Keeping --- v2: - Fix MENU dependency for

Re: Pull request: u-boot-imx u-boot-imx-20220726

2022-07-28 Thread Stefano Babic
Hi Francesco, On 28.07.22 09:53, Francesco Dolcini wrote: Hello Tom, and all On Thu, Jul 28, 2022 at 06:23:05AM +, Josua Mayer wrote: This approach does work in Linux, but the maintainers there have rejected it for producing unnecessary errors in the boot log. For U-Boot imo this approach

[PATCH V4] bsh: imx6ulz_smm_m2: Add imx6ulz BSH SMM M2 boards

2022-07-28 Thread Michael Trimarchi
Introduce BSH SystemMaster (SMM) M2 board family, which consists of: imx6ulz SMM M2 and imx6ulz SMM M2 PRO boards. Add support for imx6ulz BSH SMM M2 board: - 128 MiB DDR3 RAM - 256MiB Nand - USBOTG1 peripheral - fastboot. Signed-off-by: Michael Trimarchi --- Changes V3->V4: - really

Re: [PATCH V3] bsh: imx6ulz_smm_m2: Add imx6ulz BSH SMM M2 boards

2022-07-28 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jul 27, 2022 at 7:57 PM Michael Trimarchi wrote: > > Introduce BSH SystemMaster (SMM) M2 board family, which consists of: > imx6ulz SMM M2 and imx6ulz SMM M2 PRO boards. > > Add support for imx6ulz BSH SMM M2 board: > > - 128 MiB DDR3 RAM > - 256MiB Nand > - USBOTG1 peripheral -

Re: [PATCH 1/4] arm: mvebu: Fix compatible string for nand controller

2022-07-28 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jul 28, 2022 at 8:39 AM Stefan Roese wrote: > > On 27.07.22 14:47, Pali Rohár wrote: > > Linux kernel uses compatible string "marvell,armada370-nand-controller" for > > nand controllers on Armada 370/XP/38x. U-Boot currently uses mix of > > "marvell,armada370-nand" and

[PATCH v2 7/7] mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure

2022-07-28 Thread Stefan Roese
From: Aaron Williams This patch adds a fixup function related to a PCIe FLR (Function Level Reset) problem on the NIC23 PCIe board. This function is imported from the Marvell Octeon 2013 U-Boot version as a (nearly) verbatim copy. It uses the newly introduced cyclic infrastructure, so that this

[PATCH v2 2/7] cyclic: Add basic support for cyclic function execution infrastruture

2022-07-28 Thread Stefan Roese
Add the basic infrastructure to periodically execute code, e.g. all 100ms. Examples for such functions might be LED blinking etc. The functions that are hooked into this cyclic list should be small timewise as otherwise the execution of the other code that relies on a high frequent polling (e.g.

[PATCH v2 3/7] cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET

2022-07-28 Thread Stefan Roese
This patch integrates the main function responsible for calling all registered cyclic functions cyclic_run() into the common WATCHDOG_RESET macro. This guarantees that cyclic_run() is executed very often, which is necessary for the cyclic functions to get scheduled and executed at their configured

[PATCH v2 4/7] cyclic: Integrate cyclic functionality at bootup in board_r/f

2022-07-28 Thread Stefan Roese
This patch adds a call to cyclic_init() to board_f/r.c, enabling the common cyclic infrastructure. After this it's possible to add cyclic functions via cyclic_register(). Signed-off-by: Stefan Roese --- v2: - No change common/board_f.c | 2 ++ common/board_r.c | 2 ++ 2 files changed, 4

[PATCH v2 6/7] sandbox: Add cyclic demo function

2022-07-28 Thread Stefan Roese
This patch enables the cyclic infrastructure on sandbox and also adds one simple example/demo functions using this cyclic functionality. Signed-off-by: Stefan Roese --- v2: - Extend CONFIG_CYCLIC_MAX_CPU_TIME_US to 1ms as running this in CI might take a bit longer board/sandbox/sandbox.c

[PATCH v2 5/7] cyclic: Add 'cyclic list' command

2022-07-28 Thread Stefan Roese
This patch adds the cyclic command, which currently only supports the 'list' subcommand, to list all currently registered cyclic functions. Here an example: => cyclic list function: cyclic_demo, cpu-time: 7010 us, frequency: 99.80 times/s function: cyclic_demo2, cpu-time: 1 us, frequency: 1.13

[PATCH v2 0/7] Add support for cyclic function execution infrastruture

2022-07-28 Thread Stefan Roese
This patchset adds the basic infrastructure to periodically execute code, e.g. all 100ms. Examples for such functions might be LED blinking etc. The functions that are hooked into this cyclic list should be small timewise as otherwise the execution of the other code that relies on a high frequent

[PATCH v2 1/7] time: Import time_after64() and friends from Linux

2022-07-28 Thread Stefan Roese
When using us times it makes sense to use 64bit variables for storage. The currently implemented time_after() and friends functions only handle 32bit variables. This patch now includes the 64bit variants as well from Linux. This will be used by the upcoming generic cyclic function infrastructure.

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Josua Mayer
Please hold off merging this patch until someone tested it, I can not do so this week. @Tom Can you confirm if this fixes the networking on your Cubox? Also note that the phy-handle property may or may not be required, I am not sure. sincerely Josua Mayer On Thu, Jul 28, 2022 at 7:05 AM Josua

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix mpp26 pin name and comment

2022-07-28 Thread Stefan Roese
On 27.07.22 15:00, Marek Behún wrote: There is a bug in Turris Omnia's schematics, whereupon the MPP[26] pin, which is routed to CN11 pin header, is documented as SPI CS1, but MPP[26] pin does not support this function. Instead it controls chip select 2 if in "spi0" mode. Fix the name of the

Re: [PATCH 4/4] arm: mvebu: Synchronize armada-385-turris-omnia with Linux v5.20

2022-07-28 Thread Stefan Roese
On 27.07.22 14:47, Pali Rohár wrote: * Add SPDX-License-Identifier * Add SFP and LED nodes * Fix PHY nad NOR nodes * Remove duplicates from u-boot.dtsi file Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- .../dts/armada-385-turris-omnia-u-boot.dtsi | 5 +-

Re: [PATCH 3/4] arm: mvebu: Synchronize armada-385.dtsi with Linux v5.20

2022-07-28 Thread Stefan Roese
On 27.07.22 14:47, Pali Rohár wrote: * Define PCIe interrupts Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-385.dtsi | 52 ++-- 1 file changed, 44 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 2/4] arm: mvebu: Synchronize armada-38x.dtsi with Linux v5.20

2022-07-28 Thread Stefan Roese
On 27.07.22 14:47, Pali Rohár wrote: * Replace skeleton.dtsi by explicit #address-cells / #size-cells * Add sdramc@1400 and phy@18300 nodes * Remove (unused) timeout-ms i2c properties * Fix compatible string for UARTs * Add interrupts properties for watchdog Signed-off-by: Pali Rohár

Re: [PATCH 1/4] arm: mvebu: Fix compatible string for nand controller

2022-07-28 Thread Stefan Roese
On 27.07.22 14:47, Pali Rohár wrote: Linux kernel uses compatible string "marvell,armada370-nand-controller" for nand controllers on Armada 370/XP/38x. U-Boot currently uses mix of "marvell,armada370-nand" and "marvell,mvebu-pxa3xx-nand". So unify it and use just Linux kernel compatible string.

Re: [PATCH 4/4] cmd: mvebu/bubt: Fix cmd main return value on error

2022-07-28 Thread Stefan Roese
On 26.07.22 16:11, Pali Rohár wrote: Negative return value from cmd main function cause U-Boot to print criplic error message: exit not allowed from main input shell. Set return value on error to 1. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan ---

Re: [PATCH 3/4] cmd: mvebu/bubt: Add support for sha512 checksum validation for Armada 3700

2022-07-28 Thread Stefan Roese
On 26.07.22 16:11, Pali Rohár wrote: Armada 3700 BootROM supports also images with sha512 checksums and mox-imager tool [1] generates such bootable images. Without sha512 support U-Boot bubt command just prints error message: Error: Unsupported hash_algorithm_id = 64 Error: Image header

Re: [PATCH 2/4] cmd: mvebu/bubt: Correctly propagate failure during tftp transport

2022-07-28 Thread Stefan Roese
On 26.07.22 16:11, Pali Rohár wrote: net_loop() returns signed int type and negative value represents error. tftp_read_file() returns unsigned size_t type and zero value represents error. Casting signed negative value to unsigned size_t type cause losing information about error and bubt thinks

Re: [PATCH 1/4] cmd: mvebu/bubt: Verify image type for all 32-bit Aramda SoCs and Armada 3700

2022-07-28 Thread Stefan Roese
On 26.07.22 16:11, Pali Rohár wrote: Current image type verification code is specific to 32-bit Armada SoCs but used only for Armada 38x. Implement image type verification for Armada 3700 and enable Armada 38x image verification for all 32-bit Armada SoCs. Signed-off-by: Pali Rohár

Re: [PATCH 2/2] arm: mvebu: turris_omnia: Add mcu node with gpio-controller

2022-07-28 Thread Stefan Roese
On 25.07.22 15:01, Pali Rohár wrote: This allows U-Boot to register new Turris Omnia MCU driver. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-385-turris-omnia.dts | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] gpio: Add Turris Omnia MCU driver

2022-07-28 Thread Stefan Roese
On 25.07.22 15:01, Pali Rohár wrote: This driver registers GPIO controller and allows U-Boot to control GPIO pins on MCU which is connected to Turris Omnia via i2c. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/MAINTAINERS | 1 +

Re: [PATCH] mvebu: pinctrl: apply SDHCI PHY config for A7K

2022-07-28 Thread Stefan Roese
On 25.07.22 14:13, Pali Rohár wrote: From: Konstantin Porotchkin Current pin control driver applies SDHCI PHY MUX selection when board DT calls for eMMC function on MPP wires. However, for CP side eMMC, only the "armada-8k-cpm-pinctrl" compatibility string is taken into account, which causes

Re: [PATCH 6/6] arm64: a37xx: pinctrl: Implement get_pins_count, get_pin_name and get_pin_muxing functions

2022-07-28 Thread Stefan Roese
On 25.07.22 14:09, Pali Rohár wrote: These functions are required for 'pinmux status -a' command to print current configuration of each MPP pin. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 78 +

Re: [PATCH 5/6] arm64: a37xx: pinctrl: Implement gpio_request_enable for gpio functionality

2022-07-28 Thread Stefan Roese
On 25.07.22 14:09, Pali Rohár wrote: To automatically enable GPIO functionality of some MPP pin, it is required to implement .gpio_request_enable and .gpio_disable_free callbacks in pinctrl driver and set .request and .rfree callbacks in GPIO driver to pinctrl_gpio_request / pinctrl_gpio_free

Re: [PATCH 4/6] arm64: a37xx: pinctrl: Add missing pinmuxes into the list

2022-07-28 Thread Stefan Roese
On 25.07.22 14:09, Pali Rohár wrote: Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

Re: [PATCH 3/6] arm64: a37xx: pinctrl: Mark all functions and structures as static

2022-07-28 Thread Stefan Roese
On 25.07.22 14:09, Pali Rohár wrote: Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

Re: [PATCH 2/6] arm64: a37xx: pinctrl: Remove duplicate info->groups and info->ngroups fields

2022-07-28 Thread Stefan Roese
On 25.07.22 14:08, Pali Rohár wrote: They are available in pin_data structure. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git

Re: [PATCH 1/6] arm64: a37xx: pinctrl: Remove unused grp->pins fields

2022-07-28 Thread Stefan Roese
On 25.07.22 14:08, Pali Rohár wrote: grp->pins is just filled and never used. Remove it. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff

Re: [PATCH 8/8] arm: mvebu: turris_omnia: Enable a38x pinctrl and gpio support

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig index

Re: [PATCH 7/8] gpio: mvebu_gpio: Set bank name to mvebu%d

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: Currently bank name is just one alphabetical letter. Change it to mvebu and number. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/mvebu_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 6/8] gpio: mvebu_gpio: Read number of gpios from DT

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: Device tree property "ngpios" contains number of gpios. Use it when available. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/mvebu_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 5/8] gpio: mvebu_gpio: Add .request and .rfree methods for Armada 38x

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: To use particular pin GPIO, it needs to be first switched to GPIO by pinctrl. Use pinctrl_gpio_request() and pinctrl_gpio_free() for this purpose. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/mvebu_gpio.c | 5

Re: [PATCH 4/8] pinctrl: Add third argument label for pinctrl_gpio_request() function

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: This change allows to use pinctrl_gpio_request() function as a direct pointer for dm_gpio_ops's .request callback. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/pinctrl-uclass.c | 3 ++- include/dm/pinctrl.h

Re: [PATCH 3/8] arm: mvebu: Add gpio-ranges into Armada 38x device tree file

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: This allows U-Boot mvebu-gpio.c driver to switch particular MPP pin into GPIO mode and enable GPIO support. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-38x.dtsi | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH 2/8] mvebu: pinctrl: Add Armada 38x driver

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: This new Armada 38x driver is based on Linux kernel driver. It can set any pin to any valid function specified in DT like Linux kernel, it provides support for 'pinmux status -a' command and also for pinctrl_gpio_request(). Signed-off-by: Pali Rohár I'm

Re: [PATCH 1/8] pinctrl: Add new function pinctrl_generic_set_state_prefix()

2022-07-28 Thread Stefan Roese
On 25.07.22 13:56, Pali Rohár wrote: This new function pinctrl_generic_set_state_prefix() behaves like pinctrl_generic_set_state() but it takes third string argument which is used as the prefix for each device tree string property. This is needed for Marvell pinctrl drivers, becase Linux device

Re: Pull request: u-boot-imx u-boot-imx-20220726

2022-07-28 Thread Josua Mayer
Hi Fabio, Marcel, Tom, The intuitive way to make ethernet work in case we do not know which phy is assembled,and at what address it will be available, is having 3 phy nodes in the dts, and setting all of their status fields to "okay" - so that they would be probed in order until one succeeds.

Re: [PATCH 1/4] arm: mvebu: Fix compatible string for nand controller

2022-07-28 Thread Stefan Roese
On 27.07.22 20:40, Pali Rohár wrote: On Wednesday 27 July 2022 14:55:51 Michael Nazzareno Trimarchi wrote: Hi Pali On Wed, Jul 27, 2022 at 2:49 PM Pali Rohár wrote: Linux kernel uses compatible string "marvell,armada370-nand-controller" for nand controllers on Armada 370/XP/38x. U-Boot