Re: [PATCH v2] tee: optee: rework TA bus scanning code

2022-08-30 Thread Jens Wiklander
On Mon, Aug 29, 2022 at 8:34 AM Ilias Apalodimas wrote: > > Late versions of OP-TEE support a pseudo bus. TAs that behave as > hardware blocks (e.g TPM, RNG etc) present themselves on a bus which we can > scan. Unfortunately U-Boot doesn't support that yet. It's worth noting > that we already

Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-08-30 Thread Stefan Roese
Hi Simon, On 30.08.22 17:56, Simon Glass wrote: Hi Stefan, On Tue, 30 Aug 2022 at 06:08, Stefan Roese wrote: Adding Simon to Cc... On 30.08.22 14:00, Michael Walle wrote: Am 2022-08-30 13:53, schrieb Stefan Roese: Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE

Re: [PATCH 0/6] Enable CONFIG_TIMER for all Kirwood / MVEBU boards

2022-08-30 Thread Stefan Roese
Hi Tony, On 31.08.22 07:02, Stefan Roese wrote: Hi Tony, On 31.08.22 00:15, Tony Dinh wrote: Hi Stefan, On Tue, Aug 30, 2022 at 4:53 AM Stefan Roese wrote: This patchset enhaces the recently added Orion Timer driver to support all other Kirkwood & 32bit MVEBU Armada platforms.

Re: [PATCH 0/6] Enable CONFIG_TIMER for all Kirwood / MVEBU boards

2022-08-30 Thread Stefan Roese
Hi Tony, On 31.08.22 00:15, Tony Dinh wrote: Hi Stefan, On Tue, Aug 30, 2022 at 4:53 AM Stefan Roese wrote: This patchset enhaces the recently added Orion Timer driver to support all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this timer support is then enabled per default

[PATCH 19/21] dm: core: Add definitions for multiple ofnode trees

2022-08-30 Thread Simon Glass
At present, unless OF_LIVE is enabled, ofnode only supports access to one device tree, the control FDT. This is because only the node offset is encoded in ofnode, with the tree being implicit. This makes ofnode (without OF_LIVE) unsuitable for device tree fixups, as implemented by

Re: [PATCH v5 1/8] binman: add support for skipping file concatenation for mkimage

2022-08-30 Thread Simon Glass
Hi Quentin, On Tue, 30 Aug 2022 at 11:54, Quentin Schulz wrote: > > Hi Simon, > > On 8/30/22 17:56, Simon Glass wrote: > > Hi Quentin, > > > > On Tue, 30 Aug 2022 at 03:57, Quentin Schulz > > wrote: > >> > >> Hi Simon, > >> > >> On 8/27/22 02:21, Simon Glass wrote: > >>> Hi Quentin, > >>> > >>>

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-30 Thread Simon Glass
Hi Michal, On Tue, 30 Aug 2022 at 10:48, Michal Suchánek wrote: > > On Tue, Aug 30, 2022 at 09:56:52AM -0600, Simon Glass wrote: > > Hi Michal, > > > > On Tue, 30 Aug 2022 at 04:23, Michal Suchánek wrote: > > > > > > On Sat, Aug 27, 2022 at 07:52:27PM -0600, Simon Glass wrote: > > > > Hi

Re: [PATCH 1/2] dt-bindings: clock: sifive: sync FU740 PRCI clock binding header

2022-08-30 Thread Leo Liang
On Wed, Aug 31, 2022 at 12:38:01AM +0800, Icenowy Zheng wrote: > 在 2022-08-30星期二的 03:26 +,Leo Liang写道: > > Hi Icenowy, > > On Thu, Aug 25, 2022 at 04:11:18PM +0800, Icenowy Zheng wrote: > > > This commit sychornizes the header file for FU740 PRCI clocks with > > > the > > > one from Linux

[PATCH 21/21] dm: core: Add the ofnode multi-tree implementation

2022-08-30 Thread Simon Glass
Add the logic to redirect requests for the device tree through a function which can look up the tree ID. This works by using the top bits of ofnode.of_offset to encode a tree. It is assumed that there will only be a few device trees used at runtime, typically the control FDT (always tree ID 0)

[PATCH 18/21] dm: core: Allow obtaining a node offset in the same tree

2022-08-30 Thread Simon Glass
In some cases we want to obtain an ofnode in the same tree as a different ofnode, such as when looking up a subnode. At present this is trivial, since there is only one tree. When there are multiple trees, this implementation will change. Also move the ofnode_to_offset() function up higher in the

[PATCH 17/21] dm: core: Add a way to look up a phandle in an oftree

2022-08-30 Thread Simon Glass
When we have multiple trees, the ofnode logic needs to be told which one to use. Create a new function which takes an oftree argument, along with a helper to obtain the FDT pointer from an oftree. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 14 ++ include/dm/ofnode.h |

[PATCH 16/21] dm: core: Add ofnode functions to obtain an oftree

2022-08-30 Thread Simon Glass
At present dm_test_ofnode_root() does this manually. Add some inline functions to handle it, so this code can be centralised. Signed-off-by: Simon Glass --- include/dm/ofnode.h | 31 +++ test/dm/ofnode.c| 4 ++-- 2 files changed, 33 insertions(+), 2

[PATCH 15/21] dm: core: Add an ofnode function to obtain the flat tree

2022-08-30 Thread Simon Glass
The flat device tree is assumed to be the control FDT but this is not always the case. Update the ofnode implementation to obtain the node via an function call so we can eventually add support for selecting different trees. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 93

[PATCH 14/21] dm: core: Provide a way to reset the device tree

2022-08-30 Thread Simon Glass
At present there is only one device tree used by the ofnode functions, except for some esoteric use of live tree. In preparation for supporting more than one, add a way to reset the list of device trees. For now this does nothing. Signed-off-by: Simon Glass --- common/board_r.c| 2 ++

[PATCH 12/21] test: Detect a change in the device tree

2022-08-30 Thread Simon Glass
If the device tree changes during a test and we cannot restore it, mark it as such so that future tests which need the live tree are skipped. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 4 test/test-main.c | 19 --- 2 files changed,

[PATCH 10/21] dm: core: Drop the const from ofnode

2022-08-30 Thread Simon Glass
Now that we support writing to ofnodes, the const is not accurate. Drop it to avoid undesirable casting. Signed-off-by: Simon Glass --- drivers/core/ofnode.c| 2 +- include/dm/ofnode.h | 4 ++-- include/dm/ofnode_decl.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 09/21] dm: core: Support writing a property to an empty node

2022-08-30 Thread Simon Glass
At present this does not work with livetree. Fix it and add a test. Signed-off-by: Simon Glass --- drivers/core/of_access.c | 8 test/dm/ofnode.c | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/core/of_access.c b/drivers/core/of_access.c index

[PATCH 20/21] dm: core: Reduce code size with dev_of_offset()

2022-08-30 Thread Simon Glass
Update the function to mark it with the const attribute. Also avoid calling it multiple times in the devfdt_get_addr_index() function. Signed-off-by: Simon Glass --- drivers/core/fdtaddr.c | 18 +- include/dm/device.h| 6 +++--- 2 files changed, 12 insertions(+), 12

[PATCH 08/21] dm: core: Allow adding ofnode subnodes

2022-08-30 Thread Simon Glass
Add this feature to the ofnode interface, supporting both livetree and flattree. Signed-off-by: Simon Glass --- drivers/core/of_access.c | 50 drivers/core/ofnode.c| 30 include/dm/of_access.h | 12 ++

[PATCH 07/21] event: Pass the images to EVT_FT_FIXUP

2022-08-30 Thread Simon Glass
Pass the boot images along as well, in case the fixups need to look at them. Signed-off-by: Simon Glass --- boot/image-fdt.c | 1 + include/event.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/boot/image-fdt.c b/boot/image-fdt.c index ca51796322d..884e089f2d8 100644 ---

[PATCH 11/21] test: Make a copy of the device tree before running a test

2022-08-30 Thread Simon Glass
When the flat device tree changes it can mess up the live tree since that uses the flat tree for its strings. This affects only a few sandbox tests which modify the device tree, but the number will grow as ofnode support for writing improves. While the control FDT is not intended to change while

[PATCH 13/21] test: Drop the UT_TESTF_LIVE_OR_FLAT flag

2022-08-30 Thread Simon Glass
This was a workaround for a rare situation. Now that it will be more common and we have a proper fix, drop the flag. We can run both types of tests in the same sandbox executable, even if the flat device tree is modified. Signed-off-by: Simon Glass --- include/test/test.h | 2 --

[PATCH 06/21] dm: core: Pass a root node to of_find_node_by_phandle()

2022-08-30 Thread Simon Glass
This function currently assumes that the control FDT is used. Update it to allow a root node to be passed, so it can work with any tree. Also add a comment to ofnode_get_by_phandle() so that its purpose is clear. Signed-off-by: Simon Glass --- drivers/core/of_access.c | 7 ---

[PATCH 05/21] event: Fix a typo in the EVENT help

2022-08-30 Thread Simon Glass
Fix the help message. Signed-off-by: Simon Glass --- common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/Kconfig b/common/Kconfig index e7914ca750a..5cfa63b0db1 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -551,7 +551,7 @@ config EVENT help

[PATCH 03/21] treewide: Drop image_info_t typedef

2022-08-30 Thread Simon Glass
This is not needed and we should avoid typedefs. Use the struct instead. Signed-off-by: Simon Glass --- boot/bootm.c| 2 +- include/image.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index 73f7552fe4c..93bdbb0455c 100644 ---

[PATCH 01/21] image: Fix BOOTM_STATE values

2022-08-30 Thread Simon Glass
Tidy up the code style for these. Signed-off-by: Simon Glass --- include/image.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/include/image.h b/include/image.h index a148073113a..5e81fad8774 100644 --- a/include/image.h +++ b/include/image.h @@

[PATCH v5 7/7] tpm: Allow committing non-volatile data

2022-08-30 Thread Simon Glass
Add an option to tell the TPM to commit non-volatile data immediately it is changed, rather than waiting until later. This is needed in some situations, since if the device reboots it may not write the data. Add definitions for the rest of the Cr50 commands while we are here. Signed-off-by:

[PATCH v5 6/7] tpm: Implement state command for Cr50

2022-08-30 Thread Simon Glass
Add a vendor-specific TPM2 command for this and implement it for Cr50. Note: This is not part of the TPM spec, but is a Cr50 extension. Signed-off-by: Simon Glass --- Changes in v5: - Use size_t for buffer size Changes in v4: - Rename function and add arguments for the command/subcmd

[PATCH v5 5/7] tpm: Allow reporting the internal state

2022-08-30 Thread Simon Glass
It is useful to read information about the current TPM state, where supported, e.g. for debugging purposes when verified boot fails. Add support for this to the TPM interface as well as Cr50. Add a simple sandbox test. Signed-off-by: Simon Glass Reviewed-by: Ilias Apalodimas --- (no changes

[PATCH v5 4/7] tpm: sandbox: Allow init of TPM in a different phase

2022-08-30 Thread Simon Glass
At present the emulator assumes that the TPM is inited in the same phase where it is used. But in fact SPL may init the TPM, so we don't want to complain when U-Boot proper later uses it. Remove this check. It might be best to save this information into the device state for the TPM, so that we

[PATCH v5 3/7] tpm: Correct the define-space command in TPMv2

2022-08-30 Thread Simon Glass
The message format is incorrect. Fix it. Signed-off-by: Simon Glass Acked-by: Ilias Apalodimas --- (no changes since v2) Changes in v2: - Use constants instead of open-coded values lib/tpm-v2.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v5 2/7] tpm: Correct the permissions command in TPMv1

2022-08-30 Thread Simon Glass
The offset here is incorrect. Fix it. Signed-off-by: Simon Glass Acked-by: Ilias Apalodimas --- (no changes since v1) lib/tpm-v1.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/tpm-v1.c b/lib/tpm-v1.c index 22a769c5874..d0e3ab1b21d 100644 --- a/lib/tpm-v1.c +++

[PATCH v5 1/7] tpm: Require a digest source when extending the PCR

2022-08-30 Thread Simon Glass
This feature is used for measured boot, so we can add a log entry to the TCPA with some information about where the digest comes from. It is not currently supported in the TPM drivers, but add it to the API so that code which expects it can signal its request. Signed-off-by: Simon Glass

[PATCH v5 0/7] tpm: Various minor fixes and enhancements

2022-08-30 Thread Simon Glass
This series contains some minor enhancements for the TPM code to make it work with Chromium OS verified boot. Changes in v5: - Reword mention of measured boot - Use size_t for buffer size Changes in v4: - Rename function and add arguments for the command/subcmd - Rename function and add

Re: [PATCH] cli: Reduce size of readline buffers in SPL

2022-08-30 Thread Simon Glass
On Tue, 30 Aug 2022 at 14:40, Sean Anderson wrote: > > Normally, readline is not used int SPL. However, it may be useful to > enable the Freescale DDR interactive mode in SPL, while U-Boot is still > executing from SRAM. The default settings for readline result in a large > buffer being

Re: [PATCH 0/6] Enable CONFIG_TIMER for all Kirwood / MVEBU boards

2022-08-30 Thread Tony Dinh
Hi Stefan, On Tue, Aug 30, 2022 at 4:53 AM Stefan Roese wrote: > > This patchset enhaces the recently added Orion Timer driver to support > all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this > timer support is then enabled per default for those platforms, so that > the board

Re: [PATCH] dt-bindings: nvmem: u-boot,env: add basic NVMEM cells

2022-08-30 Thread Tom Rini
On Tue, Aug 16, 2022 at 11:26:37AM +0200, Rafał Miłecki wrote: > On 3.07.2022 10:48, Rafał Miłecki wrote: > > U-Boot doesn't have cells at hardcoded addresses. They are stored in > > internal format. It's still important to define relevant cells in DT so > > NVMEM consumers can reference them. > >

[PATCH] ddr: fsl: Make bank_addr_bits reflect actual bits

2022-08-30 Thread Sean Anderson
In both the Freescale DDR controller and the SPD spec, bank address bits are stored as the number of bank address bits minus 2. For example, if a chip had 8 banks (3 total bank address bits), the value of bank_addr_bits would be 1. This is rather surprising for users configuring their memory

[PATCH] ddr: fsl: Reduce the size of interactive options

2022-08-30 Thread Sean Anderson
The interactive mode uses large several tables of options which can be configured. However, much of the contents of these tables are repetetive. For example, no struct is larger than half a kilobyte, so the offset only takes up 9 bits. Similarly, the size is only ever 4 or 8, and printhex is a

[PATCH] cli: Reduce size of readline buffers in SPL

2022-08-30 Thread Sean Anderson
Normally, readline is not used int SPL. However, it may be useful to enable the Freescale DDR interactive mode in SPL, while U-Boot is still executing from SRAM. The default settings for readline result in a large buffer being allocated. Reduce the size of the maximum input line, and the number of

[PATCH] arm: smh: Fix uninitialized parameters with newer GCCs

2022-08-30 Thread Sean Anderson
Newer versions of GCC won't initialize parts of structures which don't appear to be used. This results in uninitialized semihosting parameters passed via R1. Fix this by marking the inline assembly as clobbering memory. Signed-off-by: Sean Anderson --- arch/arm/lib/semihosting.c | 6 +++--- 1

[PATCHv5] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-30 Thread Jorge Ramirez-Ortiz
Early instantiation of this I2C device would lock up when being probed. https://www.nxp.com/docs/en/errata/SE050_Erratasheet.pdf 3.2.2 In scenarios of detecting I2C ICs on the bus using an empty I2C frame containing only the address the SE050 will block the I2C bus. Tested on STM32MP1

[PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI

2022-08-30 Thread Jorge Ramirez-Ortiz
Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing. The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset. Signed-off-by: Jorge Ramirez-Ortiz --- configs/stm32mp13_defconfig | 1 - configs/stm32mp15_defconfig | 1

[PATCH] arch: arm: mach-socfpga: To notify SDM when SPL pass control to U-Boot

2022-08-30 Thread Jit Loon Lim
From: Chin Liang See Prior SPL pass control to U-Boot, SPL will send a mailbox command "HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on HPS SW transition. The purpose is for debug as user can query SDM on HPS error details when HPS enters a warm reset due to error such as watchdog.

[PATCH] arch: arm: mach-socfpga: To notify SDM when SPL pass control to U-Boot

2022-08-30 Thread Jit Loon Lim
From: Chin Liang See Prior SPL pass control to U-Boot, SPL will send a mailbox command "HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on HPS SW transition. The purpose is for debug as user can query SDM on HPS error details when HPS enters a warm reset due to error such as watchdog.

[PATCH] arch: arm : mach-socfpga: Add mailbox command for HPS execution stage notification

2022-08-30 Thread Jit Loon Lim
From: Chin Liang See Add a new mailbox command "HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on the stage of HPS code execution. In general, there are three main code execution stages: First Stage Boot Loader (FSBL) which is U-Boot SPL, Second Stage Boot Loader (SSBL) which is U-Boot,

[PATCH] arch: arm: mach-socfpga: Add mailbox command for HPS execution stage notification

2022-08-30 Thread Jit Loon Lim
From: Chin Liang See Add a new mailbox command "HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on the stage of HPS code execution. In general, there are three main code execution stages: First Stage Boot Loader (FSBL) which is U-Boot SPL, Second Stage Boot Loader (SSBL) which is U-Boot,

[RFC PATCH] mxs: Don't enable 4P2 reg if mx28 is powered only from DCDC_BATT without 5V

2022-08-30 Thread Alan Kay
mxs_power_enable_4p2() was added to mxs_batt_boot() in 'commit a0f97610757d ("ARM: mxs: Enable DCDC converter for battery boot")' to enable DCDC converter when board is powered from 5V and has detected sufficient battery voltage. This involves enabling 4P2 regulator and there is a code in

Re: [PATCH v5 1/8] binman: add support for skipping file concatenation for mkimage

2022-08-30 Thread Quentin Schulz
Hi Simon, On 8/30/22 17:56, Simon Glass wrote: Hi Quentin, On Tue, 30 Aug 2022 at 03:57, Quentin Schulz wrote: Hi Simon, On 8/27/22 02:21, Simon Glass wrote: Hi Quentin, On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: From: Quentin Schulz Some image types handled by mkimage

Re: [PATCH] ARM: imx: Update Data Modul i.MX8M Mini eDM SBC DRAM timing

2022-08-30 Thread Marek Vasut
On 8/30/22 18:01, Tim Harvey wrote: Hi, Marek, Might I ask how you ran into the issue There were a couple of boards which were unstable and kept crashing at runtime, often when using GPU. Either the machine locked up completely or there were rendering artifacts. Eventually also memtester

Re: [PATCH v4 1/2] bootm: fix typo imape_comp -> image_comp

2022-08-30 Thread Tom Rini
On Tue, Aug 30, 2022 at 09:56:56AM -0600, Simon Glass wrote: > Hi Daniel, > > On Mon, 29 Aug 2022 at 21:04, Daniel Golle wrote: > > > > On Mon, Aug 29, 2022 at 08:30:14PM -0600, Simon Glass wrote: > > > On Fri, 26 Aug 2022 at 21:15, Daniel Golle wrote: > > > > > > > > Chage variable name

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-30 Thread Michal Suchánek
On Tue, Aug 30, 2022 at 09:56:52AM -0600, Simon Glass wrote: > Hi Michal, > > On Tue, 30 Aug 2022 at 04:23, Michal Suchánek wrote: > > > > On Sat, Aug 27, 2022 at 07:52:27PM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On Fri, 19 Aug 2022 at 14:23, Michal Suchanek wrote: > > > > > > >

Re: [PATCH 1/2] dt-bindings: clock: sifive: sync FU740 PRCI clock binding header

2022-08-30 Thread Icenowy Zheng
在 2022-08-30星期二的 03:26 +,Leo Liang写道: > Hi Icenowy, > On Thu, Aug 25, 2022 at 04:11:18PM +0800, Icenowy Zheng wrote: > > This commit sychornizes the header file for FU740 PRCI clocks with > > the > > one from Linux 5.19. > > > > The constant values are the same, but all constant names are > >

Re: [PATCH] ARM: imx: Update Data Modul i.MX8M Mini eDM SBC DRAM timing

2022-08-30 Thread Tim Harvey
On Tue, Aug 30, 2022 at 5:34 AM Marek Vasut wrote: > > Adjust the DRAM timing settings for this board per ones provided > by hardware department. The change is applied to the LPDDR4 MR11 > register CA ODT configuration, from RZQ/6 to RZQ/3, which fixes > stability issues on subset of boards. The

Re: [PATCH v4 1/2] bootm: fix typo imape_comp -> image_comp

2022-08-30 Thread Simon Glass
Hi Daniel, On Mon, 29 Aug 2022 at 21:04, Daniel Golle wrote: > > On Mon, Aug 29, 2022 at 08:30:14PM -0600, Simon Glass wrote: > > On Fri, 26 Aug 2022 at 21:15, Daniel Golle wrote: > > > > > > Chage variable name 'imape_comp' to the supposedly intended name > > > > Change > > Can you fix that

Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-08-30 Thread Simon Glass
Hi Stefan, On Tue, 30 Aug 2022 at 06:08, Stefan Roese wrote: > > Adding Simon to Cc... > > On 30.08.22 14:00, Michael Walle wrote: > > Am 2022-08-30 13:53, schrieb Stefan Roese: > >> Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE > >> enabled, like pogo_v4. > >> > >>

Re: [PATCH] doc: Add gpio status output fields description

2022-08-30 Thread Simon Glass
On Tue, 30 Aug 2022 at 08:56, Patrice Chotard wrote: > > Add gpio status output fields description and one output example. > > Signed-off-by: Patrice Chotard > --- > > doc/usage/cmd/gpio.rst | 26 ++ > 1 file changed, 26 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v5 1/8] binman: add support for skipping file concatenation for mkimage

2022-08-30 Thread Simon Glass
Hi Quentin, On Tue, 30 Aug 2022 at 03:57, Quentin Schulz wrote: > > Hi Simon, > > On 8/27/22 02:21, Simon Glass wrote: > > Hi Quentin, > > > > On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > >> > >> From: Quentin Schulz > >> > >> Some image types handled by mkimage require the datafiles

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-30 Thread Simon Glass
Hi Michal, On Tue, 30 Aug 2022 at 04:23, Michal Suchánek wrote: > > On Sat, Aug 27, 2022 at 07:52:27PM -0600, Simon Glass wrote: > > Hi Michal, > > > > On Fri, 19 Aug 2022 at 14:23, Michal Suchanek wrote: > > > > > > When probing a device fails NULL pointer is returned, and other devices > > >

Re: [PATCH 4/4] arm: dts: chameleonv3: Add 270-2 variant

2022-08-30 Thread Simon Glass
Hi Paweł, On Tue, 30 Aug 2022 at 05:51, Paweł Anikiel wrote: > > On Tue, Aug 30, 2022 at 5:13 AM Alexandru M Stan wrote: > > > > Hey Simon, > > > > On Mon, Aug 29, 2022 at 7:29 PM Simon Glass wrote: > > > > > > Hi Paweł, > > > > > > On Mon, 29 Aug 2022 at 02:23, Paweł Anikiel wrote: > > > > >

[PATCH] doc: Add gpio status output fields description

2022-08-30 Thread Patrice Chotard
Add gpio status output fields description and one output example. Signed-off-by: Patrice Chotard --- doc/usage/cmd/gpio.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/usage/cmd/gpio.rst b/doc/usage/cmd/gpio.rst index f6a5668388..b768b08a9b 100644 ---

[PATCH 17/17] test/py: add a ping6 test

2022-08-30 Thread Viacheslav Mitrofanov
Add a simple ICMPv6 echo request test Signed-off-by: Viacheslav Mitrofanov --- test/py/tests/test_net.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py index 9ca6743afd..bd3d60774b 100644 --- a/test/py/tests/test_net.py

[PATCH 15/17] test: dm: eth: Add ip6_make_snma test

2022-08-30 Thread Viacheslav Mitrofanov
Add a test that checks generated Solicited Node Multicast Address from our ipv6 address. Use in sandbox Signed-off-by: Viacheslav Mitrofanov --- test/dm/eth.c | 20 1 file changed, 20 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c index d4a39e53d9..c892c68523

[PATCH 16/17] test: dm: eth: Add ip6_make_lladdr test

2022-08-30 Thread Viacheslav Mitrofanov
Add a test that checks generated Link Local Address. Use in sandbox Signed-off-by: Viacheslav Mitrofanov --- test/dm/eth.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c index c892c68523..f84714b735 100644 --- a/test/dm/eth.c +++

[PATCH 13/17] test: dm: eth: Add csum_ipv6_magic test

2022-08-30 Thread Viacheslav Mitrofanov
Test checksum computation. csum_ipv6_magic() uses in upper layer protocols as TCP/UDP/ICMPv6/etc to calculate payload checksum. Signed-off-by: Viacheslav Mitrofanov --- test/dm/eth.c | 29 + 1 file changed, 29 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c

[PATCH 14/17] test: dm: eth: Add ip6_addr_in_subnet test

2022-08-30 Thread Viacheslav Mitrofanov
Add a test if two address are in the same subnet. Use in sandbox Signed-off-by: Viacheslav Mitrofanov --- test/dm/eth.c | 25 + 1 file changed, 25 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c index bbfa14ef6d..d4a39e53d9 100644 --- a/test/dm/eth.c +++

[PATCH 11/17] net: ping6: Add ping6 command

2022-08-30 Thread Viacheslav Mitrofanov
Implement ping6 command to ping hosts using IPv6. It works the same way as an ordinary ping command. There is no ICMP request so it is not possible to ping our host. This patch adds options in Kconfig and Makefile to build ping6 command. Signed-off-by: Viacheslav Mitrofanov --- cmd/Kconfig|

[PATCH 12/17] test: dm: eth: Add string_to_ip6 test

2022-08-30 Thread Viacheslav Mitrofanov
Add a test to check convertation from char* to struct in6_addr. Use in sandbox Signed-off-by: Viacheslav Mitrofanov --- test/dm/eth.c | 48 1 file changed, 48 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c index 5437f9ea4a..4cc90cf514

[PATCH 10/17] net: tftp: Add IPv6 support for tftpboot

2022-08-30 Thread Viacheslav Mitrofanov
The command tftpboot uses IPv4 by default. Add the possibility to use IPv6 instead. If an address in the command is an IPv6 address it will use IPv6 to boot or if there is a suffix -ipv6 in the end of the command it also force using IPv6. All other tftpboot features and parameters are left the

[PATCH 09/17] net: ipv6: Incorporate IPv6 support into u-boot net subsystem

2022-08-30 Thread Viacheslav Mitrofanov
Add net_ip6_handler (an IPv6 packet handler) into net_loop. Add neighbor discovery mechanism into network init process. That is the main step to run IPv6 in u-boot. Now u-boot is capable to use NDP and handle IPv6 packets. Signed-off-by: Viacheslav Mitrofanov --- net/net.c | 23

[PATCH 08/17] net: ipv6: Add implementation of main IPv6 functions

2022-08-30 Thread Viacheslav Mitrofanov
Functions that were exposed in "net: ipv6: Add IPv6 basic primitives" had only empty implementations and were exposed as API for futher patches. This patch add implementation of these functions. Main functions are: net_ip6_handler() - IPv6 packet handler for incoming packets;

[PATCH 07/17] net: ipv6: Add ip6addr, gatewayip6, serverip6 variables callbacks

2022-08-30 Thread Viacheslav Mitrofanov
Implement actions on ip6addr, gatewayip6, serverip6 varaibles. on_ip6addr - convert IPv6 string addr to struct ip6_addr on_gatewayip6 - convert IPv6 string addr to struct ip6_addr on_serverip6 - convert IPv6 string addr to struct ip6_addr Signed-off-by: Viacheslav Mitrofanov --- net/net6.c | 67

[PATCH 05/17] net: ipv6: Add string_to_ip6 converter

2022-08-30 Thread Viacheslav Mitrofanov
This functions is used as a converter from IPv6 address string notation to struct ip6_addr that is used everywhere in IPv6 implementation. For example it is used to parse and convert IPv6 address from tftpboot command. Conversion algorithm uses two passes, first to verify syntax and locate colons

[PATCH 06/17] net: ipv6: Enable IPv6 typeconversion specifier

2022-08-30 Thread Viacheslav Mitrofanov
Add the possibility to recognize IPv6 address in print function. To output IPv6 address use %pI6 specifier. Signed-off-by: Viacheslav Mitrofanov --- lib/vsprintf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index

[PATCH 04/17] net: ipv6: Add Neighbor Discovery Protocol (NDP)

2022-08-30 Thread Viacheslav Mitrofanov
Implement basic of NDP. It doesn't include such things as Router Solicitation, Router Advertisement and Redirect. It just has Neighbor Solicitation and Neighbor Advertisement. Only these two features are used in u-boot IPv6. Implementation of some NDP functions uses API that was exposed in "net:

[PATCH 02/17] net: ipv6: Add IPv6 build options

2022-08-30 Thread Viacheslav Mitrofanov
Add options to Makefile and Kconfig file to build IPv6 Signed-off-by: Viacheslav Mitrofanov --- net/Kconfig | 4 net/Makefile | 1 + 2 files changed, 5 insertions(+) diff --git a/net/Kconfig b/net/Kconfig index 52e261884d..568e622de8 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -174,6

[PATCH 03/17] net: ipv6: Add callbacks declarations to get access to IPv6 variables

2022-08-30 Thread Viacheslav Mitrofanov
Set up callbacks for main IPv6 variables ip6add, serverip6, gatewayip6 and set options to them in flag file. These variables are often set up by users. Signed-off-by: Viacheslav Mitrofanov --- include/env_callback.h | 10 ++ include/env_flags.h| 10 ++ 2 files changed, 20

[PATCH 01/17] net: ipv6: Add IPv6 basic primitives

2022-08-30 Thread Viacheslav Mitrofanov
This patch is a collection of basic primitives that are prerequisite for further IPv6 implementation. There are structures definition such as IPv6 header, UDP header (for TFTP), ICMPv6 header. There are auxiliary defines such as protocol codes, padding, struct size and etc. Also here are

[PATCH v2 00/17] IPv6 support

2022-08-30 Thread Viacheslav Mitrofanov
This patch set adds basic IPv6 support to U-boot. It is based on Chris's Packham patches (https://lists.denx.de/pipermail/u-boot/2017-January/279366.html) Chris's patches were taken as base. There were efforts to launch it on HiFive SiFive Unmatched board but the board didn't work well. The code

Re: [PATCH v14 01/10] eficonfig: menu-driven addition of UEFI boot option

2022-08-30 Thread Ilias Apalodimas
On Tue, 30 Aug 2022 at 14:53, Ilias Apalodimas wrote: > > Hi Kojima-san, > > [...] > > +/** > > + * eficonfig_choice_entry() - user key input handler > > + * > > + * @data:pointer to the efimenu structure > > + * Return: key string to identify the selected entry > > + */ > > +static char

Re: [PATCH] ARM: imx: Update Data Modul i.MX8M Mini eDM SBC DRAM timing

2022-08-30 Thread Fabio Estevam
On Tue, Aug 30, 2022 at 9:34 AM Marek Vasut wrote: > > Adjust the DRAM timing settings for this board per ones provided > by hardware department. The change is applied to the LPDDR4 MR11 > register CA ODT configuration, from RZQ/6 to RZQ/3, which fixes > stability issues on subset of boards. The

[PATCH] ARM: imx: Update Data Modul i.MX8M Mini eDM SBC DRAM timing

2022-08-30 Thread Marek Vasut
Adjust the DRAM timing settings for this board per ones provided by hardware department. The change is applied to the LPDDR4 MR11 register CA ODT configuration, from RZQ/6 to RZQ/3, which fixes stability issues on subset of boards. The DDR PHY PIE block has been updated accordingly.

Re: [PATCH] arm: mvebu: turris_mox: Add support for distroboot $fdt_addr

2022-08-30 Thread Stefan Roese
On 29.08.22 15:44, Pali Rohár wrote: $fdt_addr is mandatory for systems which provides DTB in HW (e.g. ROM) and wishes to pass that DTB to Linux. Turris Mox contains DTB binary in SPI NOR memory at "dtb" partition which starts at offset 0x7f and is 0x1 bytes long. Armada 3700 CPU does

Re: [PATCH] arm: mvebu: turris_{omnia, mox}: Reset bootdelay env for rescue

2022-08-30 Thread Stefan Roese
On 27.08.22 20:49, Pali Rohár wrote: When rescue mode was activated reset also bootdelay env variable to its default value. This will ensure that reset button works and starts rescue mode also in the case when user changed bootdelay env variable to -1 (which has meaning to not start autoboot).

Re: [PATCH] board: turris: Initialize serial# env

2022-08-30 Thread Stefan Roese
On 27.08.22 20:06, Pali Rohár wrote: Store serial number from atsha cryptochip into the serial# env variable. U-Boot automatically puts content of this variable into the root device tree property serial-number when booting Linux kernel. Refactor turris atsha code and from

Re: [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE

2022-08-30 Thread Stefan Roese
On 27.08.22 14:00, Pali Rohár wrote: Signed-off-by: Pali Rohár As mentioned by Simon, please add a short sentence in the commit text as well. Other than that: Reviewed-by: Stefan Roese Thanks, Stefan --- board/Marvell/mvebu_armada-37xx/board.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 4/4] gpio: sandbox: Add GPIOD_IS_AF for gpio configured in alternate function

2022-08-30 Thread Patrick DELAUNAY
Hi Patrice, On 8/30/22 14:09, Patrice Chotard wrote: This allows to test if a pin's label if displayed using gpio_get_status() when this pin is configured in alternate function. Signed-off-by: Patrice Chotard Reviewed-by: Simon Glass --- (no changes since v1) drivers/gpio/sandbox.c

Re: [PATCH v3 3/4] pinctrl: pinctrl_stm32: Populate uc_priv->name[] with pinmux node's name

2022-08-30 Thread Patrick DELAUNAY
Hi, On 8/30/22 14:09, Patrice Chotard wrote: Populate uc_priv->name[] with pinmux node's name in order to indicate the pinmuxing's name in case GPIO is configured in alternate. For example, for STM32 SoC's based platform, "gpio status" command output : before Bank GPIOZ:

Re: [PATCH v3 2/4] gpio: Fix pin's status display for pin with GPIOF_UNUSED function

2022-08-30 Thread Patrick DELAUNAY
Hi Patrice, On 8/30/22 14:09, Patrice Chotard wrote: Even pin with GPIOF_UNUSED function can have a label. The criteria to add or not a space character is linked to label not to the used/unused status. Signed-off-by: Patrice Chotard Reviewed-by: Simon Glass --- Changes in v3: - add

Re: [PATCH v3 1/4] gpio: Allow to print pin's label even for pin with GPIOF_FUNC function

2022-08-30 Thread Patrick DELAUNAY
Hi Patrice On 8/30/22 14:09, Patrice Chotard wrote: Currently, if pin's function is GPIOF_FUNC, only "func" if displayed without any other information. It would be interesting, if information is available, to indicate which pinmuxing's name is used. For example, for STM32 SoC's based platform,

Re: [PATCH 3/6] arm: mvebu: Use CONFIG_TIMER on all MVEBU & KIRKWOOD platforms

2022-08-30 Thread Stefan Roese
On 30.08.22 14:04, Michael Walle wrote: Am 2022-08-30 13:53, schrieb Stefan Roese: Now that the new timer support is available for these platforms, let's select this IF for all these platforms. This way it's not necessary that each board changes it's config header. Signed-off-by: Stefan Roese

[PATCH v3 0/4] gpio: update gpio_get_status()

2022-08-30 Thread Patrice Chotard
Currently, if pin's function is GPIOF_FUNC, only "func" if displayed without any other information. It would be interesting, if information is available, to indicate which pinmuxing's name is used. Changes in v3: - add lost Simon Glass's reviewed-by during v1 review in patch 1 and 2

[PATCH v3 2/4] gpio: Fix pin's status display for pin with GPIOF_UNUSED function

2022-08-30 Thread Patrice Chotard
Even pin with GPIOF_UNUSED function can have a label. The criteria to add or not a space character is linked to label not to the used/unused status. Signed-off-by: Patrice Chotard Reviewed-by: Simon Glass --- Changes in v3: - add lost Simon Glass's reviewed-by during v1 review

[PATCH v3 1/4] gpio: Allow to print pin's label even for pin with GPIOF_FUNC function

2022-08-30 Thread Patrice Chotard
Currently, if pin's function is GPIOF_FUNC, only "func" if displayed without any other information. It would be interesting, if information is available, to indicate which pinmuxing's name is used. For example, for STM32 SoC's based platform, "gpio status" command output : before Bank

[PATCH v3 4/4] gpio: sandbox: Add GPIOD_IS_AF for gpio configured in alternate function

2022-08-30 Thread Patrice Chotard
This allows to test if a pin's label if displayed using gpio_get_status() when this pin is configured in alternate function. Signed-off-by: Patrice Chotard Reviewed-by: Simon Glass --- (no changes since v1) drivers/gpio/sandbox.c | 5 + include/asm-generic/gpio.h

[PATCH v3 3/4] pinctrl: pinctrl_stm32: Populate uc_priv->name[] with pinmux node's name

2022-08-30 Thread Patrice Chotard
Populate uc_priv->name[] with pinmux node's name in order to indicate the pinmuxing's name in case GPIO is configured in alternate. For example, for STM32 SoC's based platform, "gpio status" command output : before Bank GPIOZ: GPIOZ0: unused : 0 [ ] GPIOZ1: unused : 0 [ ]

Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-08-30 Thread Stefan Roese
Adding Simon to Cc... On 30.08.22 14:00, Michael Walle wrote: Am 2022-08-30 13:53, schrieb Stefan Roese: Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE enabled, like pogo_v4. Signed-off-by: Stefan Roese ---  drivers/timer/orion-timer.c | 22 ++  1

Re: [PATCH 3/6] arm: mvebu: Use CONFIG_TIMER on all MVEBU & KIRKWOOD platforms

2022-08-30 Thread Michael Walle
Am 2022-08-30 13:53, schrieb Stefan Roese: Now that the new timer support is available for these platforms, let's select this IF for all these platforms. This way it's not necessary that each board changes it's config header. Signed-off-by: Stefan Roese --- arch/arm/Kconfig

Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-08-30 Thread Michael Walle
Am 2022-08-30 13:53, schrieb Stefan Roese: Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE enabled, like pogo_v4. Signed-off-by: Stefan Roese --- drivers/timer/orion-timer.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-30 Thread Pali Rohár
On Tuesday 30 August 2022 13:15:26 Stefan Roese wrote: > On 30.08.22 11:19, Pali Rohár wrote: > > On Tuesday 30 August 2022 10:04:51 Maciej W. Rozycki wrote: > > > On Sat, 27 Aug 2022, Pali Rohár wrote: > > > > > > > Moreover this workaround is enabled for all existing hardware and also > > > >

  1   2   >