Hello Sughosh,
On Wed, 28 Sept 2022 at 11:30, Sughosh Ganu wrote:
>
> In the FWU Multi Bank Update feature, the information about the
> updatable images is stored as part of the metadata, which is stored on
> a dedicated partition. Add the metadata structure, and a driver model
> uclass which
On Wed, 28 Sept 2022 at 11:30, Sughosh Ganu wrote:
>
> Enabling capsule update functionality on the platform requires
> populating information on the images that are to be updated using the
> functionality. Do so for the DK2 board.
>
> Signed-off-by: Sughosh Ganu
> Reviewed-by: Patrick Delaunay
Hi Simon,
On 28.09.22 03:54, Simon Glass wrote:
Hi Stefan,
On Mon, 26 Sept 2022 at 07:52, Stefan Roese wrote:
Hi Simon,
On 25.09.22 16:15, Simon Glass wrote:
Hi Stefan,
On Wed, 21 Sept 2022 at 08:06, Stefan Roese wrote:
The early timer functions provided via CONFIG_TIMER_EARLY don't
Hi Heinrich,
On Thu, 29 Sept 2022 at 15:00, Heinrich Schuchardt wrote:
>
> On 9/29/22 22:11, Simon Glass wrote:
> > +U-Boot Custodians too
> >
> > On Thu, 29 Sept 2022 at 13:58, Simon Glass wrote:
> >>
> >> Until recently it has not been possible to add any U-Boot-specific
> >> properties to
On 9/26/22 09:34, Thomas Glanzmann wrote:
Hallo Marek,
Hi,
Can you be more specific about those logitech receivers ? I might have one
of those devices, and I have DWC3 in i.MX8MP and i.MX8MQ, as well as ZynqMP,
so I should be able to try and trigger the problem. Can you share the
reproducer
On 9/26/22 23:55, Christian Kohlschütter wrote:
On 26. Sep 2022, at 01:45, Marek Vasut wrote:
On 9/25/22 16:46, Christian Kohlschütter wrote:
When detecting USB storage devices, we currently skip everything that is
not marked as "undefined device class".
Composite devices such as tinyusb's
On Wed, Sep 28, 2022 at 08:35:58PM -0600, Simon Glass wrote:
> Hi Takahiro,
>
> On Wed, 28 Sept 2022 at 18:51, AKASHI Takahiro
> wrote:
> >
> > Hi Simon,
> >
> > On Wed, Sep 28, 2022 at 04:20:56AM -0600, Simon Glass wrote:
> > > Hi Takahiro,
> > >
> > > On Sun, 25 Sept 2022 at 18:17, AKASHI
On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuchardt wrote:
> Don't try to delete a non-existent handle.
It is okay as a safe guard, but it doesn't fix underlying issues.
efi_initrd_register() is called only in efi_bootmgr_load(), and so
efi_initrd_deregister() should be called only at
Until recently it has not been possible to add any U-Boot-specific
properties to the device tree schema. Now that it is somewhat separated
from Linux and people are feeling the enormous pain of the bifurcated
schema, it seems like a good time to add this and other U-Boot-specific
bindings.
U-Boot
The current tests do not cover all the behaviour. Add some more.
Tidy up a few inconsistencies between livetree and flattree which come to
light with these tests. Also drop the -ENODATA error since it is never
actually returned.
Signed-off-by: Simon Glass
---
Changes in v3:
- Avoid code-size
Don't try to delete a non-existent handle.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_load_initrd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/efi_loader/efi_load_initrd.c b/lib/efi_loader/efi_load_initrd.c
index c5e6652e66..3d6044f760 100644
---
Hi Jonathan,
On Wed, 28 Sept 2022 at 18:44, Jonathan DeNoon
wrote:
>
> Hello, I want to define my own default environment, so I have enabled
> CONFIG_USE_DEFAULT_ENV_FILE. The next step appears to be setting the path to
> the default environment file via CONFIG_DEFAULT_ENV_FILE. My questions
On Thu, 29 Sept 2022 at 03:57, Mayuresh Chitale
wrote:
>
> This patch adds options to enable PCI NVMe support in SPL
>
> Signed-off-by: Mayuresh Chitale
> ---
> common/spl/Kconfig | 25 +
> 1 file changed, 25 insertions(+)
Reviewed-by: Simon Glass
Hi Tom,
On Thu, 29 Sept 2022 at 09:05, Tom Rini wrote:
>
> On Wed, Sep 28, 2022 at 04:20:41AM -0600, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Mon, 26 Sept 2022 at 00:35, Heinrich Schuchardt
> > wrote:
> > >
> > > On 9/25/22 17:02, Simon Glass wrote:
> > > > Binman needs this module to
Hi Christian,
On Thu, 29 Sept 2022 at 08:24, Christian Kohlschütter
wrote:
>
> > On 29. Sep 2022, at 04:36, Simon Glass wrote:
> >
> > Hi Christian,
> >
> > On Wed, 28 Sept 2022 at 18:20, Christian Kohlschütter
> > wrote:
> >>
> >> With CONFIG_DISPLAY_CPUINFO=y and CONFIG_CPU=y, the initcall
Hi Mayuresh,
On Thu, 29 Sept 2022 at 03:57, Mayuresh Chitale
wrote:
>
> Add spl_nvme to read a fat partition from a bootable NVMe device.
>
> Signed-off-by: Mayuresh Chitale
> ---
> arch/riscv/include/asm/spl.h | 1 +
> common/spl/Makefile | 1 +
> common/spl/spl_nvme.c| 44
Hi Ilias,
On Thu, 29 Sept 2022 at 04:23, Ilias Apalodimas
wrote:
>
> Hi Simon,
>
> On Thu, Sep 29, 2022 at 03:59:51AM -0600, Simon Glass wrote:
> > Hi,
> >
> > On Tue, 20 Sept 2022 at 05:10, Peter Robinson wrote:
> > >
> > > On Tue, Sep 6, 2022 at 2:44 PM Ilias Apalodimas
> > > wrote:
> > > >
Hi Mayuresh,
On Thu, 29 Sept 2022 at 03:57, Mayuresh Chitale
wrote:
>
> Build PCI NVMe driver when enabled for SPI and enable dm-pre-reloc for
> the driver. Also enable PCI_PNP for SPL which is required to auto
> configure the PCIe devices.
>
> Signed-off-by: Mayuresh Chitale
> ---
>
On Thu, 29 Sept 2022 at 10:09, Martyn Welch
wrote:
>
> Hi Simon,
>
> Is this approach acceptable to you (instead of adding legacy support
> for this device)?
Reviewed-by: Simon Glass
>
> Martyn
>
> On Fri, 2022-09-16 at 11:24 +0100, Martyn Welch wrote:
> > The support added later in this
Hi Christian,
On Thu, 29 Sept 2022 at 08:30, Christian Kohlschütter
wrote:
>
> > On 29. Sep 2022, at 04:36, Simon Glass wrote:
> >
> > On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
> > wrote:
> >>
> >> Provide human-readable manufacturer and product names for the
> >> FriendlyELEC
Hi Tom,
On Thu, 29 Sept 2022 at 17:13, Tom Rini wrote:
>
> On Tue, Sep 06, 2022 at 08:27:18PM -0600, Simon Glass wrote:
>
> > The current tests do not cover all the behaviour. Add some more.
> >
> > Tidy up a few inconsistencies between livetree and flattree which come to
> > light with these
On Tue, Sep 06, 2022 at 08:27:18PM -0600, Simon Glass wrote:
> The current tests do not cover all the behaviour. Add some more.
>
> Tidy up a few inconsistencies between livetree and flattree which come to
> light with these tests. Also drop the -ENODATA error since it is never
> actually
I think I've found a bug in the ext2load command. When the file
being read is a sparse file, the command fails as in this example.
=> ext2load usb 0:1 $load_addr firmware_ls2088ardb_norboot.img
fs_devread read outside partition 60063712
Failed to load
On the 32bit ARM sandbox 'dm ut dm_test_devm_regmap' fails with an abort.
This is due to incorrect range checks.
On 32-bit systems the size of size_t and int is both 32 bit. The expression
(offset + val_len) is bound to overflow if offset == -1. Add an overflow
check.
Signed-off-by: Heinrich
On 9/29/22 22:11, Simon Glass wrote:
+U-Boot Custodians too
On Thu, 29 Sept 2022 at 13:58, Simon Glass wrote:
Until recently it has not been possible to add any U-Boot-specific
properties to the device tree schema. Now that it is somewhat separated
from Linux and people are feeling the
+U-Boot Custodians too
On Thu, 29 Sept 2022 at 13:58, Simon Glass wrote:
>
> Until recently it has not been possible to add any U-Boot-specific
> properties to the device tree schema. Now that it is somewhat separated
> from Linux and people are feeling the enormous pain of the bifurcated
>
On Wed, Sep 28, 2022 at 05:23:01PM +0200, Pankaj Raghav wrote:
> This line probably got in by mistake as there is no fs_mutex member in
> the btrfs_fs_info struct.
>
> Signed-off-by: Pankaj Raghav
> Reviewed-by: Qu Wenruo
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description:
On Sat, Sep 24, 2022 at 03:36:24PM +0200, Michael Trimarchi wrote:
> The max size is defined at architectural level. On the same commit
> I have checked mostly all the other architecture and look like they are
>
> Fixes: commit ca8a329a1b7f ("Convert CONFIG_SPL_PAD_TO et al to Kconfig")
>
On Wed, Sep 21, 2022 at 06:09:46PM +0100, Andre Przywara wrote:
> Commit c0fce929564f("vexpress64: fvp: enable OF_CONTROL") added code to
> consider a potential DTB address being passed in the x0 register, or
> revert to the built-in DTB otherwise.
> The former case was used when using the
On Wed, Sep 21, 2022 at 08:38:42AM -0500, Nishanth Menon wrote:
> The situation is similar to commit bf6376642fe8 ("board: ti: common:
> board_detect: Fix EEPROM read quirk"). This is seen on a variant of
> eeproms seen on some BeagleBone-AI64 which now has a mix of both 1 byte
> addressing and 2
On Mon, Sep 19, 2022 at 08:28:09AM +0400, Miaoqian Lin wrote:
> The function calls opendir() but missing the corresponding
> closedir() before exit the function.
> Add missing closedir() to fix it.
>
> Signed-off-by: Miaoqian Lin
Applied to u-boot/master, thanks!
--
Tom
signature.asc
On Thu, Sep 15, 2022 at 03:54:45PM +0200, Pali Rohár wrote:
> Signed-off-by: Pali Rohár
> Reviewed-by: Bin Meng
> Reviewed-by: Stefan Roese
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Fri, Sep 09, 2022 at 09:16:18PM +0100, Pierre-Clément Tosi wrote:
> When the embedded device tree is pointed to by the __dtb_dt_*begin
> symbols, it seems to be covered by the early relocation code and doesn't
> need to be manually patched.
>
> Cc: Simon Glass
> Signed-off-by:
Until recently it has not been possible to add any U-Boot-specific
properties to the device tree schema. Now that it is somewhat separated
from Linux and people are feeling the enormous pain of the bifurcated
schema, it seems like a good time to add this and other U-Boot-specific
bindings.
U-Boot
On 9/29/22 05:45, Majid B. wrote:
Hello,
I've tried to build U-Boot 2022.07 with the following series of
instructions:
export CROSS_COMPILE=mipsel-linux-gnu-
make mrproper
make O=build maltael_defconfig
make V=1 O=build -j$(nproc)
Unfortunately, I seem to always run into this error:
In
Hi Roger,
On Thu, 29 Sept 2022 at 01:03, Roger Quadros wrote:
>
> Hi Simon,
>
> On 28/09/2022 19:27, Simon Glass wrote:
> > Hi Roger,
> >
> > On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote:
> >>
> >> We will need ti-gpmc driver for SPL. Allow memory drivers
> >> do be built for SPL.
> >>
>
On Wed, Sep 28, 2022 at 03:11:46PM +0300, Roger Quadros wrote:
> Hi,
>
> The GPMC is a unified memory controller dedicated for interfacing
> with external memory devices like
> - Asynchronous SRAM-like memories and ASICs
> - Asynchronous, synchronous, and page mode burst NOR flash
> - NAND
On Thu, Sep 29, 2022 at 10:02:54AM +0300, Roger Quadros wrote:
> Hi Simon,
>
> On 28/09/2022 19:27, Simon Glass wrote:
> > Hi Roger,
> >
> > On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote:
> >>
> >> We will need ti-gpmc driver for SPL. Allow memory drivers
> >> do be built for SPL.
> >>
>
From: Dave Gerlach
Move k3-am64-sk to use 1600MT/s LPDDR4 configuration and update to latest EMIF
tool v0.08.40.
Signed-off-by: Dave Gerlach
Signed-off-by: Anand Gadiyar
---
...33MTs.dtsi => k3-am64-sk-lp4-1600MTs.dtsi} | 371 +-
arch/arm/dts/k3-am642-r5-sk.dts
From: Dave Gerlach
Move to latest DDR4 1600MT/s for k3-am64-evm based on EMIF tool
v0.08.40.
Signed-off-by: Dave Gerlach
Signed-off-by: Anand Gadiyar
---
arch/arm/dts/k3-am64-evm-ddr4-1600MTs.dtsi | 122 +++--
1 file changed, 62 insertions(+), 60 deletions(-)
diff --git
Hi Simon,
Is this approach acceptable to you (instead of adding legacy support
for this device)?
Martyn
On Fri, 2022-09-16 at 11:24 +0100, Martyn Welch wrote:
> The support added later in this series tweaks the PMIC voltages in
> the
> SPL. Enable support for the rn5t567 in SPL builds to allow
On Thu, Sep 29, 2022 at 05:23:15PM +0200, quentin.sch...@theobroma-systems.com
wrote:
> Hi Tom,
>
> On 9/29/22 4:34 PM, Tom Rini wrote:
> > On Thu, Sep 22, 2022 at 03:53:46PM +0200, Marek Vasut wrote:
> > > On 9/22/22 15:45, Quentin Schulz wrote:
> > >> From: Quentin Schulz
> > >>
> > >> One
Hi Tom,
On 9/29/22 4:34 PM, Tom Rini wrote:
On Thu, Sep 22, 2022 at 03:53:46PM +0200, Marek Vasut wrote:
> On 9/22/22 15:45, Quentin Schulz wrote:
>> From: Quentin Schulz
>>
>> One needs to set u-boot,dm-pre-reloc in a device Device Tree node so
>> that it is kept in SPL/TPL variant of the
On Sun, Sep 25, 2022 at 09:02:10AM -0600, Simon Glass wrote:
> The expression in boot_from_devices() is fairly long. Move it into a
> function with a suitable comment.
>
> Signed-off-by: Simon Glass
> ---
>
> common/spl/spl.c | 16 +---
> 1 file changed, 13 insertions(+), 3
On Wed, Sep 28, 2022 at 04:20:41AM -0600, Simon Glass wrote:
> Hi Heinrich,
>
> On Mon, 26 Sept 2022 at 00:35, Heinrich Schuchardt wrote:
> >
> > On 9/25/22 17:02, Simon Glass wrote:
> > > Binman needs this module to build sandbox_vpl so install it in the
> > > before_script and in the world
On Thu, Sep 22, 2022 at 03:53:46PM +0200, Marek Vasut wrote:
> On 9/22/22 15:45, Quentin Schulz wrote:
> > From: Quentin Schulz
> >
> > One needs to set u-boot,dm-pre-reloc in a device Device Tree node so
> > that it is kept in SPL/TPL variant of the device tree. However, a device
> > is
> On 29. Sep 2022, at 04:36, Simon Glass wrote:
>
> On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
> wrote:
>>
>> Provide human-readable manufacturer and product names for the
>> FriendlyELEC NanoPi R4S.
>>
>> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>>
>>
> On 29. Sep 2022, at 04:36, Simon Glass wrote:
>
> Hi Christian,
>
> On Wed, 28 Sept 2022 at 18:20, Christian Kohlschütter
> wrote:
>>
>> With CONFIG_DISPLAY_CPUINFO=y and CONFIG_CPU=y, the initcall sequence
>> may fail (and therefore hang the boot process) with an -ENODEV (err=-19)
>> error
On 9/29/22 05:59, Simon Glass wrote:
Hi,
On Wed, 28 Sept 2022 at 22:34, Sean Anderson wrote:
On 9/26/22 06:56, Ilias Apalodimas wrote:
Hi Sean
On Sat, 17 Sept 2022 at 19:55, Sean Anderson wrote:
On 9/16/22 16:30, Ilias Apalodimas wrote:
Hi Simon,
[...]
Signed-off-by: Ilias
On Mon, Sep 26, 2022 at 04:29:30PM +0800, Peng Fan wrote:
>
>
> On 9/24/2022 9:36 PM, Michael Trimarchi wrote:
> > The max size is defined at architectural level. On the same commit
> > I have checked mostly all the other architecture and look like they are
> >
> > Fixes: commit ca8a329a1b7f
On Sun, Sep 25, 2022 at 12:46:10PM -0400, marty leisner wrote:
> I'm running ubuntu 20.04 server (which uses u-boot v2021.01 with minor
> changes/enhancements)
>
> fw_printenv doesn't seem to work -- it always comes up with a crc error (I
> haven't tried fw_setenv yet).
>
> Is there a spec of
On Thu, Sep 29, 2022 at 12:02:43AM -0400, Sean Anderson wrote:
> On 9/28/22 22:36, Simon Glass wrote:
> > Hi Sean,
> >
> > On Wed, 28 Sept 2022 at 15:50, Sean Anderson wrote:
> > >
> > > On 9/28/22 17:06, Simon Glass wrote:
> > > > Hi Sean,
> > > >
> > > > On Wed, 28 Sept 2022 at 11:18, Sean
Hi Michal,
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> Hello,
>
> this patch series fixes the simple uclass iterators to be usable for
> iterating uclasses even if some devices fail to probe.
>
> Before this series when a probe error happens an error is returned
> without any
Add spl_nvme to read a fat partition from a bootable NVMe device.
Signed-off-by: Mayuresh Chitale
---
arch/riscv/include/asm/spl.h | 1 +
common/spl/Makefile | 1 +
common/spl/spl_nvme.c| 44
3 files changed, 46 insertions(+)
create mode
Build PCI NVMe driver when enabled for SPI and enable dm-pre-reloc for
the driver. Also enable PCI_PNP for SPL which is required to auto
configure the PCIe devices.
Signed-off-by: Mayuresh Chitale
---
drivers/Makefile | 2 +-
drivers/nvme/Makefile| 2 +-
drivers/nvme/nvme_pci.c | 1
This patch adds options to enable PCI NVMe support in SPL
Signed-off-by: Mayuresh Chitale
---
common/spl/Kconfig | 25 +
1 file changed, 25 insertions(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 70d97815f0..2bc97421f9 100644
--- a/common/spl/Kconfig
This patchset adds support to load images of the SPL's next booting stage from
a NVMe device.
Mayuresh Chitale (3):
spl: Add Kconfig options for NVME
nvme: pci: Enable for SPL
common: spl: Add spl NVMe boot support
arch/riscv/include/asm/spl.h | 1 +
common/spl/Kconfig | 25
Here are the smatch warning messages:
drivers/net/xilinx_axi_emac.c:324 axiemac_phy_init()
error: 'phydev' dereferencing possible ERR_PTR()
drivers/net/zynq_gem.c:340 zynq_phy_init()
error: 'priv->phydev' dereferencing possible ERR_PTR()
Fix by adding error checking before dereferencing the
Correct pointer dereferencing check to be more consistent.
Eliminate the below smatch warning:
drivers/mmc/mmc.c:3118 mmc_init_device()
warn: variable dereferenced before check 'm' (see line 3116)
Signed-off-by: Venkatesh Yadav Abbarapu
---
drivers/mmc/mmc.c | 6 --
1 file changed, 4
Hello,
I've tried to build U-Boot 2022.07 with the following series of
instructions:
export CROSS_COMPILE=mipsel-linux-gnu-
make mrproper
make O=build maltael_defconfig
make V=1 O=build -j$(nproc)
Unfortunately, I seem to always run into this error:
In file included from
Hi Simon,
On Thu, Sep 29, 2022 at 03:59:51AM -0600, Simon Glass wrote:
> Hi,
>
> On Tue, 20 Sept 2022 at 05:10, Peter Robinson wrote:
> >
> > On Tue, Sep 6, 2022 at 2:44 PM Ilias Apalodimas
> > wrote:
> > >
> > > In order to fill in the SMBIOS tables U-Boot currently relies on a
> > >
OMAP3 BeagleBoard NAND boot hangs when spl_load_legacy_img() tries
to read the header into 'struct hdr' which is allocated on the
stack.
As the header has already been read once before by spl_nand.c,
we can avoid the extra header read here by simply passing around
the pointer to the header.
This
Hi Sean,
On Thu, Sep 29, 2022 at 12:34:37AM -0400, Sean Anderson wrote:
> On 9/26/22 06:56, Ilias Apalodimas wrote:
> > Hi Sean
> >
> > On Sat, 17 Sept 2022 at 19:55, Sean Anderson wrote:
> > >
> > > On 9/16/22 16:30, Ilias Apalodimas wrote:
> > > > Hi Simon,
> > > >
> > > > [...]
> > > >
>
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> There are a few commands that iterate uclass with
> uclass_first_device/uclass_next_device or the _err variant.
>
> Use the _check class iterator variant to get devices that fail to probe
> as well, and print the status.
>
> Signed-off-by:
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> The ret value is never used. It is only set when no device is returned,
> and that is handled before the value of ret would be used.
>
> Signed-off-by: Michal Suchanek
> ---
> drivers/dma/dma-uclass.c | 7 +++
> 1 file changed, 3
On Tue, 27 Sept 2022 at 15:40, Michal Suchanek wrote:
>
> There are a couple users of uclass_next_device return value that get the
> first device by other means and use uclass_next_device assuming the
> following device in the uclass is related to the first one.
>
> Use uclass_next_device_err
Hi Michal,
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> The description claims that the device is probed but it isn't.
>
> Add the device_probe() call.
>
> Also consolidate the iteration into one function.
>
> Fixes: 8a5cbc065d ("dm: blk: Use uclass_find_first/next_device() in
>
On Sun, 25 Sept 2022 at 02:31, Michal Suchanek wrote:
>
> The cycle is guarded by !ret && dev, code in if (ret || ! dev) is never
> executed. dev implies !ret, and ret is not even checked when getting
> next device, just drop the ret variable completely.
>
> Signed-off-by: Michal Suchanek
> ---
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> When probing a device fails NULL pointer is returned, and following
> devices in uclass list cannot be iterated. Skip to next device on error
> instead.
>
> With that the only condition under which these simple iteration
> functions return
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> When there is no PCI bus uclass_first_device will return no bus and no
> error which will result in pci_find_first_device calling
> skip_to_next_device with no bus, and the bus is only checked at the end
> of the while cycle, not the
Hi Michal,
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> The _err variant iterators use the simple iterators without suffix as
> basis.
>
> However, there is no user that uclass_next_device_err for iteration,
> many users of uclass_first_device_err use it to get the first and
>
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> There is a number of users that use uclass_first_device to access the
> first and (assumed) only device in uclass.
>
> Some check the return value of uclass_first_device and also that a
> device was returned which is exactly what
On Tue, 27 Sept 2022 at 15:40, Michal Suchanek wrote:
>
> Use uclass_first_device_check/uclass_next_device_check to correctly
> count buses that fail to probe.
>
> Fixes: d3e19cf919 ("w1: Add 1-Wire uclass")
> Signed-off-by: Michal Suchanek
> ---
> drivers/w1/w1-uclass.c | 20
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> blk_first_device_err/blk_next_device_err uses
> uclass_first_device_err/uclass_next_device_err for device iteration.
>
> Although the function names superficially match the return value from
> uclass_first_device_err/uclass_next_device_err
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> uclass_first_device/uclass_next_device return value will be removed,
> don't use it.
>
> With the current implementation bus is equivalent to !ret. It i
> redundant to check both, ret check can be replaced with bus check, and
> ret check
Hi Michal,
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> There is a complaint in the code that iterates keyboards that we don't
> have the _check variant of class iterator but we in fact do, use it.
>
> In the code that iterates video devices there is an attempt to print
> errors but
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> The code checks that uclass_first_device returned a device but the
> returned value that is assigned is never used. Use
> uclass_first_device_err instead, and move the error return outside of
> the if block.
>
> Fixes: f4ec1ae08e
On Sun, 25 Sept 2022 at 02:30, Michal Suchanek wrote:
>
> The code checks the return value from uclass_first_device as well as
> that the device exists but it passes on the return value which may be
> zero if there are no gadget devices. Just check that a device was
> returned and return -ENODEV
Hi Michal,
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> bootdev_list() uses uclass_*_device_err() to iterate devices.
> However, the only value _err adds is returning an error when the device
> pointer is null, and that's checked anyway.
>
> Also there is some intent to report
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> We already have a function for probing all devices of a specific class,
> use it.
>
> Signed-off-by: Michal Suchanek
> ---
> drivers/cpu/cpu-uclass.c | 20
> drivers/virtio/virtio-uclass.c | 15 +--
On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote:
>
> uclass_probe_all uses uclass_first_device/uclass_next_device assigning
> the return value.
>
> The interface for getting meaningful error is
> uclass_first_device_check/uclass_next_device_check, use it.
>
> Also do not stop iteration when
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> These functions use device_bind_with_driver_data internally, copy the
> return value description.
>
> Signed-off-by: Michal Suchanek
> ---
> include/dm/lists.h | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Simon Glass
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> device_probe returns early when the device is already activated.
> Add a note to the documentation that it can be used on already activated
> devices.
>
> Signed-off-by: Michal Suchanek
> ---
> include/dm/device-internal.h | 4 ++--
> 1
Hi,
On Wed, 28 Sept 2022 at 22:34, Sean Anderson wrote:
>
> On 9/26/22 06:56, Ilias Apalodimas wrote:
> > Hi Sean
> >
> > On Sat, 17 Sept 2022 at 19:55, Sean Anderson wrote:
> >>
> >> On 9/16/22 16:30, Ilias Apalodimas wrote:
> >>> Hi Simon,
> >>>
> >>> [...]
> >>>
> > Signed-off-by: Ilias
On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote:
>
> pci_find_first_device description says it can be used for iteration with
> itself but it should really be with pci_find_next_device
>
> Signed-off-by: Michal Suchanek
> ---
> include/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1
Hi,
On Tue, 20 Sept 2022 at 05:10, Peter Robinson wrote:
>
> On Tue, Sep 6, 2022 at 2:44 PM Ilias Apalodimas
> wrote:
> >
> > In order to fill in the SMBIOS tables U-Boot currently relies on a
> > "u-boot,sysinfo-smbios" compatible node. This is fine for the boards
> > that already include
Hi Abdellatif,
> --- a/arch/arm/cpu/armv8/cache.S
> +++ b/arch/arm/cpu/armv8/cache.S
> @@ -3,6 +3,9 @@
> * (C) Copyright 2013
> * David Feng
> *
> + * (C) Copyright 2022 ARM Limited
> + * Abdellatif El Khlifi
> + *
> * This file is based on sample code from ARMv8 ARM.
> */
>
> @@
Hi Simon,
On 28/09/2022 19:27, Simon Glass wrote:
> Hi Roger,
>
> On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote:
>>
>> We will need ti-gpmc driver for SPL. Allow memory drivers
>> do be built for SPL.
>>
>> Signed-off-by: Roger Quadros
>> ---
>> scripts/Makefile.spl | 1 +
>> 1 file
Hi
Il mer 28 set 2022, 13:42 Roger Quadros ha scritto:
> This fixes the below build error if nand.c is included in
> an SPL build.
>
> /work/u-boot/drivers/mtd/nand/raw/nand.c: In function ‘nand_init_chip’:
> /work/u-boot/drivers/mtd/nand/raw/nand.c:82:28: error: ‘nand_chip’
> undeclared (first
On Thu, 29 Sept 2022 at 00:59, Jassi Brar wrote:
>
> On Wed, Sep 28, 2022 at 1:00 AM Sughosh Ganu wrote:
> >
> > On Tue, 27 Sept 2022 at 21:55, Jassi Brar wrote:
> > >
> > > On Tue, Sep 27, 2022 at 2:14 AM Sughosh Ganu
> > > wrote:
> > > >
> > > > On Mon, 26 Sept 2022 at 20:12, Jassi Brar
>
90 matches
Mail list logo
