Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Ilias Apalodimas
Hi Heinrich [...] > > diff --git a/lib/efi_loader/efi_load_initrd.c > > b/lib/efi_loader/efi_load_initrd.c > > index 3d6044f76047..87fde3f88c2b 100644 > > --- a/lib/efi_loader/efi_load_initrd.c > > +++ b/lib/efi_loader/efi_load_initrd.c > > @@ -208,14 +208,13 @@ efi_status_t efi_initrd_register

Re: [PATCH v4] imx: support i.MX8QM DMSSE20 a1 board

2022-10-06 Thread Marcel Ziswiler
Hi Oliver On Wed, 2022-10-05 at 16:22 +0200, oliver.gra...@kococonnector.com wrote: > On 13/07/22, Marcel Ziswiler wrote: [snip] > > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +/* First 128KB is for PSCI ATF. */ > > > +/memreserve/ 0x8000 0x0002; > > > + > > > +#include "fsl-imx8qm

Re: [RFC PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06 Thread Ilias Apalodimas
On Thu, Oct 06, 2022 at 04:26:37AM +0200, Heinrich Schuchardt wrote: > On 10/6/22 03:53, AKASHI Takahiro wrote: > > On Wed, Oct 05, 2022 at 06:26:02PM +0300, Ilias Apalodimas wrote: > > > In general handles should only be deleted if the last remaining protocol > > > is removed. Instead of explicit

Re: [PATCH 1/1] cmd: simplify do_env_set_efi()

2022-10-06 Thread Ilias Apalodimas
Hi Heinrich, On Thu, Oct 06, 2022 at 06:54:19AM +0200, Heinrich Schuchardt wrote: > Use efi_convert_string() to convert a UTF-8 to a UTF-16 string. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/nvedit_efi.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/cmd

[PATCH] MAINTAINERS: get rid of the optee variables entry

2022-10-06 Thread Ilias Apalodimas
Since I am co-maintaining EFI with Heinrich remove the special entry for EFI variable storage via OP-TEE Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b4b185aacd43..a26b36c7c20d 100644 ---

Re: [PATCH 0/3] arm: smh: Fix and improve semihosting traps

2022-10-06 Thread Andre Przywara
On Wed, 5 Oct 2022 19:41:01 -0400 Sean Anderson wrote: Hi Sean, > On 10/5/22 12:38, Andre Przywara wrote: > > While playing around with QEMU's semihosting implementation, I stared at > > our semihosting trap code, and found some issues, that this mini-series > > fixes. > > > > Please have a loo

[PATCH v13 00/15] FWU: Add FWU Multi Bank Update feature support

2022-10-06 Thread Sughosh Ganu
The patchset adds support for the FWU Multi Bank Update[1] feature. Certain aspects of the Dependable Boot[2] specification have also been implemented. The FWU multi bank update feature is used for supporting multiple sets(also called banks) of firmware image(s), allowing the platform to boot fr

[PATCH v13 01/15] dt/bindings: Add bindings for GPT based FWU Metadata storage device

2022-10-06 Thread Sughosh Ganu
Add bindings needed for accessing the FWU metadata partitions. These include the compatible string which point to the access method and the actual device which stores the FWU metadata. The current patch adds basic bindings needed for accessing the metadata structure on GPT partitioned block device

[PATCH v13 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-10-06 Thread Sughosh Ganu
In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, which is stored on a dedicated partition. Add the metadata structure, and a driver model uclass which provides functions to access the metadata. These are generic API's, and implement

[PATCH v13 05/15] stm32mp1: Add image information for capsule updates

2022-10-06 Thread Sughosh Ganu
Enabling capsule update functionality on the platform requires populating information on the images that are to be updated using the functionality. Do so for the DK2 board. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay Reviewed-by: Ilias Apalodimas Reviewed-by: Etienne Carriere ---

[PATCH v13 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-10-06 Thread Sughosh Ganu
In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, on a separate partition. Add a driver for reading from and writing to the metadata when the updatable images and the metadata are stored on a block device which is formatted with GPT

[PATCH v13 04/15] stm32mp1: dk2: Add a node for the FWU metadata device

2022-10-06 Thread Sughosh Ganu
The FWU metadata structure is accessed through the driver model interface. On the stm32mp157c-dk2 board, the FWU metadata is stored on the uSD card. Add the fwu-mdata node on the u-boot specifc dtsi file for accessing the metadata structure. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaun

[PATCH v13 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-10-06 Thread Sughosh Ganu
The FWU Multi Bank Update feature allows the platform to boot the firmware images from one of the partitions(banks). The first stage bootloader(fsbl) passes the value of the boot index, i.e. the bank from which the firmware images were booted from to U-Boot. On the STM32MP157C-DK2 board, this value

[PATCH v13 06/15] FWU: Add helper functions for accessing FWU metadata

2022-10-06 Thread Sughosh Ganu
Add weak functions for getting the update index value and dfu alternate number needed for FWU Multi Bank update functionality. The current implementation for getting the update index value is for platforms with 2 banks. If a platform supports more than 2 banks, it can implement it's own function.

[PATCH v13 08/15] event: Add an event for main_loop

2022-10-06 Thread Sughosh Ganu
Add an event type EVT_MAIN_LOOP that can be used for registering events that need to be run after the platform has been initialised and before the main_loop function is called. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V12: None commo

[PATCH v13 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-06 Thread Sughosh Ganu
The FWU Multi Bank Update specification requires the Update Agent to carry out certain checks at the time of platform boot. The Update Agent is the component which is responsible for updating the firmware components and maintaining and keeping the metadata in sync. The spec requires that the Updat

[PATCH v13 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-06 Thread Sughosh Ganu
The FWU Multi Bank Update feature supports updation of firmware images to one of multiple sets(also called banks) of images. The firmware images are clubbed together in banks, with the system booting images from the active bank. Information on the images such as which bank they belong to is stored

[PATCH v13 11/15] FWU: cmd: Add a command to read FWU metadata

2022-10-06 Thread Sughosh Ganu
Add a command to read the metadata as specified in the FWU specification and print the fields of the metadata. Signed-off-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas Reviewed-by: Etienne Carriere --- Changes since V12: None cmd/Kconfig | 6 +++ cmd/Makefile

[PATCH v13 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-06 Thread Sughosh Ganu
Add test cases for accessing the FWU Metadata on the sandbox platform. The sandbox platform also uses the metadata access driver for GPT partitioned block devices. The FWU feature will be tested on the sandbox64 variant with a raw capsule. Remove the FIT capsule testing from sandbox64 defconfig --

[PATCH v13 13/15] mkeficapsule: Add support for generating empty capsules

2022-10-06 Thread Sughosh Ganu
The Dependable Boot specification[1] describes the structure of the firmware accept and revert capsules. These are empty capsules which are used for signalling the acceptance or rejection of the updated firmware by the OS. Add support for generating these empty capsules. [1] - https://git.codelin

[PATCH v13 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-06 Thread Sughosh Ganu
Add support for setting OEM flags in the capsule header. As per the UEFI specification, bits 0-15 of the flags member of the capsule header can be defined per capsule GUID. The oemflags will be used for the FWU Multi Bank update feature, as specified by the Dependable Boot specification[1]. Bit 15

[PATCH v13 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-06 Thread Sughosh Ganu
Add documentation for the FWU Multi Bank Update feature. The document describes the steps needed for setting up the platform for the feature, as well as steps for enabling the feature on the platform. Signed-off-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass --- Changes

Re: [PATCH 1/1] efi_driver: provide driver binding protocol to bind function

2022-10-06 Thread Ilias Apalodimas
Hi Heinrich, On Tue, Oct 04, 2022 at 07:21:02PM +0200, Heinrich Schuchardt wrote: > DisconnectController() is based on the open protocol information created > when the driver opens a protocol with BY_CHILD_CONTROLLER or BY_DRIVER. > > To create an open protocol information it is required to supp

Re: [RFC PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 09:38, Ilias Apalodimas wrote: On Thu, Oct 06, 2022 at 04:26:37AM +0200, Heinrich Schuchardt wrote: On 10/6/22 03:53, AKASHI Takahiro wrote: On Wed, Oct 05, 2022 at 06:26:02PM +0300, Ilias Apalodimas wrote: In general handles should only be deleted if the last remaining protocol is

Re: [RFC PATCH 0/2] Clean up protocol installation API

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 08:55, Ilias Apalodimas wrote: Hi Akashi-san, On Thu, 6 Oct 2022 at 04:35, AKASHI Takahiro wrote: Hi Ilias, On Wed, Oct 05, 2022 at 06:26:00PM +0300, Ilias Apalodimas wrote: This RFC is trying to clean up the usage of the internal functions used to manage the protocol and handle

Re: [PATCH] MAINTAINERS: get rid of the optee variables entry

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 10:41, Ilias Apalodimas wrote: Since I am co-maintaining EFI with Heinrich remove the special entry for EFI variable storage via OP-TEE Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- MAINTAINERS | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

Re: [PATCH] board/km: remove kirkwood boards

2022-10-06 Thread Stefan Roese
On 15.08.22 08:35, Holger Brunck wrote: These boards are out of maintenance and can be removed. Signed-off-by: Holger Brunck --- arch/arm/dts/Makefile | 1 - arch/arm/dts/kirkwood-km_common.dtsi | 48 --- arch/arm/dts/kirkwood-km_kirkwood.dts | 53 --- b

Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Ilias Apalodimas
Hi Heinrich [...] > > - return EFI_EXIT(EFI_INVALID_PARAMETER); > > + return EFI_INVALID_PARAMETER; > > Please, use a efi_search_obj(handle) to determine if the handle is valid. > > if (!efi_search_obj(handle)) > return EFI_INVALID_PARAMETER; We should

Re: [PATCH] mtd: nand: pxa3xx: simplify ECC hardware parameters

2022-10-06 Thread Stefan Roese
On 25.08.22 06:59, Chris Packham wrote: Replace the if/else chain in pxa_ecc_init() with a lookup table. This makes the code more concise and hopefully easier to follow. Remove the unused ecc_layout tables and replace it with a single dummy one (the pxa3xx driver has never used this but the mtd s

Re: [PATCH] tools: kwbimage: Verify maximal kwbimage header size

2022-10-06 Thread Stefan Roese
On 18.09.22 18:39, Pali Rohár wrote: BootROM loads kwbimage header to L2-SRAM and BootROM reserve only 192 kB for it. Signed-off-by: Pali Rohár Applied to u-boot-marvell/master Thanks, Stefan --- tools/kwbimage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/kwbimage.c b/

Re: [PATCH v3 0/8] Enable CONFIG_TIMER for all Kirkwood / MVEBU boards

2022-10-06 Thread Stefan Roese
On 15.09.22 16:20, Stefan Roese wrote: This patchset enhaces the recently added Orion Timer driver to support all other Kirkwood & 32bit MVEBU Armada platforms. Additionally, this timer support is then enabled per default for those platforms, so that the board config files don't need to be change

Re: [PATCH 1/2] arm: mvebu: Remove timer.c

2022-10-06 Thread Stefan Roese
On 21.09.22 08:26, Stefan Roese wrote: Since the move to CONFIG_TIMER with support for CONFIG_TIMER_EARLY, this platform specific init_timer() function is not needed any more. Let's remove it completely. Signed-off-by: Stefan Roese Cc: Michael Walle Cc: Pali Rohár Applied to u-boot-marvell/

Re: [PATCH 2/2] timer: orion-timer: Only init timer once

2022-10-06 Thread Stefan Roese
On 21.09.22 08:26, Stefan Roese wrote: Move the code making sure that the timer is initialized only once into orion_timer_init(), which is called from timer_early_init() and from orion_timer_probe(). This way the timer is not re-initialized. Signed-off-by: Stefan Roese Cc: Michael Walle Cc: Pa

Please pull u-boot-marvell/master

2022-10-06 Thread Stefan Roese
Hi Tom, please pull this batch of mostly Marvell related patches: - Kirkwood: remove km/keymile kirkwood boards (Holger) - mtd: nand: pxa3xx: simplify ECC hardware parameters (Chris) - tools: kwbimage: Verify maximal kwbimage heade

Re: [PATCH 1/1] efi_driver: provide driver binding protocol to bind function

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 11:29, Ilias Apalodimas wrote: Hi Heinrich, On Tue, Oct 04, 2022 at 07:21:02PM +0200, Heinrich Schuchardt wrote: DisconnectController() is based on the open protocol information created when the driver opens a protocol with BY_CHILD_CONTROLLER or BY_DRIVER. To create an open prot

[PATCH v2 1/1] cmd: simplify do_env_set_efi()

2022-10-06 Thread Heinrich Schuchardt
Use efi_convert_string() to convert a UTF-8 to a UTF-16 string. Signed-off-by: Heinrich Schuchardt --- v2: remove local variable p don' assign unused NULL to var_name16 --- cmd/nvedit_efi.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/nvedit_ef

[PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy In the description of struct mtd_ooblayout_ops we see: * @free: function returning a free region in the OOB area. *Should return -ERANGE if %section exceeds the total number of *free sections. but corresponding field of the structure named as 'rfree'

[PATCH 2/7] mtd/nand: try to erase bad blocks only if scrub flag is provided

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy 'mtd erase' command should not erase bad blocks. To force bad block erasing there is 'mtd erase.dontskipbad' command (this command sets 'scrub' flag to true in the erase_info structure). Unfortunately nand layer ignore scrub flag and try to erases bad blocks unconditiona

[PATCH 3/7] mtd/spinand: rework detect procedure for different READ_ID operation

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy Currently there are 3 different variants of read_id implementation: 1. opcode only. Found in GD5FxGQ4xF. 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E 3. opcode + 1 dummy byte. Found in other currently supported chips. Original implementation was for variant 1 and let

[PATCH 4/7] mtd/spinand: sync core spinand code with linux-5.10.118

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/core.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index e42c061049..d0c7d82010 100644 --- a/drivers

[PATCH 6/7] mtd/spinand: add Winbond W25N02KV flash support, fix Winbond flashes identifications

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1, but current driver uses only first 2 bytes of it for devices idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22) is identified as W25N01GV (id_bytes: EF, AA, 21). Fix this and add

[PATCH 5/7] mtd/spinand: sync supported devices with linux-5.15.43

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/Makefile | 2 +- drivers/mtd/nand/spi/core.c | 1 + drivers/mtd/nand/spi/gigadevice.c | 223 ++ drivers/mtd/nand/spi/macronix.c | 145 +-- drivers/mt

[PATCH 7/7] net/tftp: make tftpput working with servers that do not use OACK

2022-10-06 Thread mikhail . kshevetskiy
From: Mikhail Kshevetskiy Signed-off-by: Mikhail Kshevetskiy --- net/tftp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/tftp.c b/net/tftp.c index dea9c25ffd..e120e4d766 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -483,8 +483,15 @@ static void tftp_handler(uch

Uboot support intel xeon gold

2022-10-06 Thread fontaine garin Tham
Hi Developers, I would like to know if uboot supports intel xeon gold processors and if the is any samples for make menuconfig. I have check the board in intel it does not show Xeon processor. So I am abit hesitant. With Regards, Fontaine Sent from my iPhone

Re: [PATCH v2 1/1] cmd: simplify do_env_set_efi()

2022-10-06 Thread Ilias Apalodimas
On Thu, 6 Oct 2022 at 14:04, Heinrich Schuchardt wrote: > > Use efi_convert_string() to convert a UTF-8 to a UTF-16 string. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > remove local variable p > don' assign unused NULL to var_name16 > --- > cmd/nvedit_efi.c | 9 ++---

[PATCH 1/1] efi_loader: efi_dp_part_node check dp_alloc return value

2022-10-06 Thread Heinrich Schuchardt
dp_alloc() may return NULL. This needs to be caught. Fixes: 98d48bdf415e ("efi_loader: provide a function to create a partition node") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c | 3 ++- lib/efi_loader/efi_disk.c| 5 + 2 files changed, 7 insertions(+), 1

Re: [PATCH 1/1] efi_loader: efi_dp_part_node check dp_alloc return value

2022-10-06 Thread Ilias Apalodimas
On Thu, 6 Oct 2022 at 14:45, Heinrich Schuchardt wrote: > > dp_alloc() may return NULL. This needs to be caught. > > Fixes: 98d48bdf415e ("efi_loader: provide a function to create a partition > node") > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_device_path.c | 3 ++- > lib/e

Re: [PATCH 1/1] efi_loader: efi_dp_part_node check dp_alloc return value

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 13:59, Ilias Apalodimas wrote: On Thu, 6 Oct 2022 at 14:45, Heinrich Schuchardt wrote: dp_alloc() may return NULL. This needs to be caught. Fixes: 98d48bdf415e ("efi_loader: provide a function to create a partition node") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/ef

Re: [PATCH 1/1] efi_loader: efi_dp_part_node check dp_alloc return value

2022-10-06 Thread Ilias Apalodimas
On Thu, 6 Oct 2022 at 15:18, Heinrich Schuchardt wrote: > > On 10/6/22 13:59, Ilias Apalodimas wrote: > > On Thu, 6 Oct 2022 at 14:45, Heinrich Schuchardt > > wrote: > >> > >> dp_alloc() may return NULL. This needs to be caught. > >> > >> Fixes: 98d48bdf415e ("efi_loader: provide a function to cr

[PATCH] imx8m: fix reading of DDR4 MR registers [again]

2022-10-06 Thread Rasmus Villemoes
Commit 290ffe5788 (imx8m: fix reading of DDR4 MR registers) lifted a private definition of lpddr4_mr_read() from imx8mm-cl-iot-gate board code to drivers/ddr/imx/imx8m/ddrphy_utils.c, because that version actually seems to work in practice. However, commit 99c7cc58e1 (ddr: imx: Add i.MX9 DDR contr

[PATCH 0/2] Clean up protocol installation API

2022-10-06 Thread Ilias Apalodimas
Hi! This is v1 of [0] trying to clean up the handle and protocol management APIs. [0] https://lore.kernel.org/u-boot/4766d2b2-7fd3-0206-37ee-709a6fe2b...@gmx.de/T/ Changes since RFC: patch [1/2]: - Use ret instead of r as a return variable - Use goto for handling efi_va_end() patch [2/2]: -

[PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Ilias Apalodimas
A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes all protocols on a handle and deletes the han

[PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06 Thread Ilias Apalodimas
In general handles should only be deleted if the last remaining protocol is removed. Instead of explicitly calling efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly removes all protocols from a handle before removing it, use InstallMultiple/UninstallMultiple which adheres t

[PATCH 0/2] Clean up protocol installation API

2022-10-06 Thread Ilias Apalodimas
Hi! This is v1 of [0] trying to clean up the handle and protocol management APIs. [0] https://lore.kernel.org/u-boot/4766d2b2-7fd3-0206-37ee-709a6fe2b...@gmx.de/T/ Changes since RFC: patch [1/2]: - Use ret instead of r as a return variable - Use goto for handling efi_va_end() patch [2/2]: -

[PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Ilias Apalodimas
A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes all protocols on a handle and deletes the han

Re: [PATCH 1/1] efi_loader: efi_dp_part_node check dp_alloc return value

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 14:49, Ilias Apalodimas wrote: On Thu, 6 Oct 2022 at 15:18, Heinrich Schuchardt wrote: On 10/6/22 13:59, Ilias Apalodimas wrote: On Thu, 6 Oct 2022 at 14:45, Heinrich Schuchardt wrote: dp_alloc() may return NULL. This needs to be caught. Fixes: 98d48bdf415e ("efi_loader: provid

Re: [PATCH] imx8m: fix reading of DDR4 MR registers [again]

2022-10-06 Thread Fabio Estevam
Hi Rasmus, On 06/10/2022 09:56, Rasmus Villemoes wrote: Commit 290ffe5788 (imx8m: fix reading of DDR4 MR registers) lifted a private definition of lpddr4_mr_read() from imx8mm-cl-iot-gate board code to drivers/ddr/imx/imx8m/ddrphy_utils.c, because that version actually seems to work in practice.

[u-boot][PATCH v2 0/4] Introduce MEMORY uclass and TI GPMC driver

2022-10-06 Thread Roger Quadros
Hi, This series introduces the MEMORY controller uclass for the drivers that exist in drivers/memory directory. With that, we add the TI GPMC Memory controller driver as the first user of this uclass. The GPMC is a unified memory controller dedicated for interfacing with external memory devices

[u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-06 Thread Roger Quadros
We will need ti-gpmc driver for SPL. Allow memory drivers do be built for SPL. Signed-off-by: Roger Quadros --- scripts/Makefile.spl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 3bafeb4fe9..110076b22f 100644 --- a/scripts/Makefile.spl +++

[u-boot][PATCH v2 1/4] dm: memory: Introduce new uclass

2022-10-06 Thread Roger Quadros
Introduce UCLASS_MEMORY for future Memory Controller device drivers. Signed-off-by: Roger Quadros --- arch/sandbox/dts/test.dts | 4 drivers/memory/Kconfig | 17 + drivers/memory/Makefile | 2 ++ drivers/memory/memory-sandbox.c | 18 +

[u-boot][PATCH v2 3/4] dt/bindings: memory: Add bindings for TI GPMC driver

2022-10-06 Thread Roger Quadros
GPMC stands for General Purpose Memory Controller and it is present on many Texas Instruments SoCs. It supports a number of Asynchronous and Synchronous interfaces and has various settings to configure the bus interface. The DT bindings define all the various GPMC settings. As the GPMC supports

[u-boot][PATCH v2 4/4] memory: Add TI GPMC driver

2022-10-06 Thread Roger Quadros
The GPMC is a unified memory controller dedicated for interfacing with external memory devices like - Asynchronous SRAM-like memories and ASICs - Asynchronous, synchronous, and page mode burst NOR flash - NAND flash - Pseudo-SRAM devices This driver will take care of setting up the GPMC based

Re: [u-boot][PATCH] mtd: nand: Fix SPL build after migration of CONFIG_SYS_NAND_SELF_INIT to Kconfig

2022-10-06 Thread Roger Quadros
Hello Michael, On 29/09/2022 09:08, Michael Nazzareno Trimarchi wrote: > Hi > > Il mer 28 set 2022, 13:42 Roger Quadros > ha scritto: > > This fixes the below build error if nand.c is included in > an SPL build. > > /work/u-boot/drivers/mtd/nand/raw/nand.c

Re: [u-boot][PATCH] mtd: nand: Fix SPL build after migration of CONFIG_SYS_NAND_SELF_INIT to Kconfig

2022-10-06 Thread Michael Nazzareno Trimarchi
Hi On Thu, Oct 6, 2022 at 3:29 PM Roger Quadros wrote: > > Hello Michael, > > On 29/09/2022 09:08, Michael Nazzareno Trimarchi wrote: > > Hi > > > > Il mer 28 set 2022, 13:42 Roger Quadros > > ha scritto: > > > > This fixes the below build error if nand.c is include

Re: [PATCH v13 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-06 Thread Etienne Carriere
Hi Sughosh, On Thu, 6 Oct 2022 at 11:07, Sughosh Ganu wrote: > > Add test cases for accessing the FWU Metadata on the sandbox > platform. The sandbox platform also uses the metadata access driver > for GPT partitioned block devices. > > The FWU feature will be tested on the sandbox64 variant with

Re: [PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 15:08, Ilias Apalodimas wrote: A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes a

Re: [PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06 Thread Heinrich Schuchardt
On 10/6/22 15:08, Ilias Apalodimas wrote: In general handles should only be deleted if the last remaining protocol is removed. Instead of explicitly calling efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly removes all protocols from a handle before removing it, use Insta

Re: Please pull u-boot-marvell/master

2022-10-06 Thread Tom Rini
On Thu, Oct 06, 2022 at 12:47:04PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull this batch of mostly Marvell related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 00/16] video: Enhancements to Truetype console

2022-10-06 Thread Simon Glass
This series includes some minor enhancements to the Truetype console to allow it to support multiple fonts and sizes at the same time. This is useful for displays where the title needs to be in a larger font than the rest of the text on the display. The fonts must still be compiled into U-Boot, bu

[PATCH 02/16] video: Provide a function to set the cursor position

2022-10-06 Thread Simon Glass
Add an exported function which allows the cursor position to be set to pixel granularity. Make use of this in the existing code. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 18 +- include/video_console.h | 12 2 files changed, 25 ins

[PATCH 05/16] video: Move and rename DM_HX8238D option

2022-10-06 Thread Simon Glass
This is actually a panel, not a video device. Rename the option, move it into the right place and make it depend on PANEL. Signed-off-by: Simon Glass --- arch/arm/mach-omap2/am33xx/Kconfig | 2 +- drivers/video/Kconfig | 20 ++-- drivers/video/Makefile

[PATCH 09/16] video: Refactor to allow more than one font size

2022-10-06 Thread Simon Glass
At present the truetype console supports only a single font and size. It is useful to be able to support different combinations. As a first step, move the metrics into there own structure and allow having multiple metrics. Signed-off-by: Simon Glass --- drivers/video/Kconfig| 15 ++

[PATCH 08/16] video: Tidy up the check for valid fonts

2022-10-06 Thread Simon Glass
Put this check into a function so we can use it elsewhere. Also drop the macros which do the same thing but are not actually used. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/video

[PATCH 10/16] video: Record the truetype font name

2022-10-06 Thread Simon Glass
Add this to the metrics so we can later adjust the font size without changing the font itself. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/video/console_truetype.c b/drivers

[PATCH 06/16] video: Allow filling the display with a colour

2022-10-06 Thread Simon Glass
Generalise the video_clear() function to allow filling with a different colour. Tidy up the comments while we are here. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 20 include/video.h | 13 +++-- 2 files changed, 27 insertions(+), 6 d

[PATCH 11/16] video: Add a function to select the truetype metrics

2022-10-06 Thread Simon Glass
Move this code into a function so we can call it later when we want to change the font. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/video/console_truetype.c b/drivers/video/

[PATCH 12/16] video: Add a way to change the font name and size

2022-10-06 Thread Simon Glass
It is useful to be able to support multiple fonts. Add a function to handle this as well as one to list the available fonts. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 75 include/video_console.h | 16 +++ 2 files changed, 91

[PATCH 13/16] video: Enable the cls command by default

2022-10-06 Thread Simon Glass
This is enabled for LCD but not for VIDEO. Enable it since it is useful to be able to clear the screen and adds very little code. Signed-off-by: Simon Glass --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index a512a55c031..30094244f

[PATCH 14/16] video: Add commands to list and change fonts

2022-10-06 Thread Simon Glass
Add a new 'font' command which allows the fonts to be listed as well as selecting a different font and size. Allow the test to run on sandbox, where multiple font/size combinations are supported, as well as sandbox_flattree, where they are not. Signed-off-by: Simon Glass --- cmd/Makefile

[PATCH 15/16] video: Add a function to get the dimensions of a BMP image

2022-10-06 Thread Simon Glass
This is useful for some other users, so break this out into a function. Signed-off-by: Simon Glass --- drivers/video/video_bmp.c | 16 include/video.h | 11 +++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/video/video_bmp.c b/drivers

[PATCH 16/16] video: Add a way to get the default font height

2022-10-06 Thread Simon Glass
This is not as simple as it seems. Add a function to provide it so that the upcoming menu feature can space lines out correctly. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 11 +++ include/video.h | 9 + 2 files changed, 20 insertions(+) diff --g

Re: [PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG

2022-10-06 Thread Michal Simek
Hi, On 10/5/22 13:44, Alexander Dahl wrote: Hei hei, while working on FPGA support for a new device I discovered debug logging in some FPGA drivers is still done as in the old days. Bring that to what I thougt would be the currently preferred approach. Notes: Adding those Kconfig symbols in p

[PATCH 03/16] video: Use vidconsole_put_string() to write a string

2022-10-06 Thread Simon Glass
Use the existing function rather that duplicating the code. Also fix up the missing error handling. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vi

[PATCH 04/16] video: Move the console commands to cmd/

2022-10-06 Thread Simon Glass
Move these commands and the implementation to the cmd/ directory, which is where most commands are kept. Signed-off-by: Simon Glass --- cmd/Kconfig | 12 + cmd/Makefile | 2 + cmd/video.c | 73 +++

[PATCH 01/16] video: Move console colours to the video uclass

2022-10-06 Thread Simon Glass
At present these are attached to vidconsole which means that the video uclass requires that a console is enabled. This is not the intention. The colours are a reasonable way of indexing common colours in any case, so move them to the video uclass instead. Rename vid_console_color() to video_index_

[PATCH 07/16] video: Add function to obtain the U-Boot logo

2022-10-06 Thread Simon Glass
It is useful to show the logo from other code, coming in a later feature. Add a function to obtain it. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 5 + include/video.h | 7 +++ 2 files changed, 12 insertions(+) diff --git a/drivers/video/video-uclass.c b/

Re: [PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG

2022-10-06 Thread Alexander Dahl
Hello Michal, Am Donnerstag, 6. Oktober 2022, 16:44:29 CEST schrieb Michal Simek: > Hi, > > On 10/5/22 13:44, Alexander Dahl wrote: > > Hei hei, > > > > while working on FPGA support for a new device I discovered debug > > logging in some FPGA drivers is still done as in the old days. Bring > >

Re: Adding 'N:' field support to buildman's boards database

2022-10-06 Thread Tom Rini
On Mon, Sep 12, 2022 at 04:20:07PM -0400, Tom Rini wrote: > Hey, > > So looking at series such as > https://patchwork.ozlabs.org/project/uboot/patch/20220801113804.v2.1.I49e41e791b038a159729c535e9dcfc4a7d59e95c@changeid/ > we run in to the case that instead of using "F: configs/..." to list > eac

Re: [PATCH 1/2] arm: dts: k3-am625-sk: Add OSPI support

2022-10-06 Thread Tom Rini
On Tue, Sep 27, 2022 at 10:59:17AM +0530, Dhruva Gole wrote: > Add DT nodes to enable S28HS512T OSPI flash on the SK board. > > Signed-off-by: Dhruva Gole > --- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 24 + > arch/arm/dts/k3-am625-sk.dts | 77 What

Re: [PATCH 2/7] mtd/nand: try to erase bad blocks only if scrub flag is provided

2022-10-06 Thread Michael Nazzareno Trimarchi
On Thu, Oct 6, 2022 at 5:52 PM Mikhail Kshevetskiy wrote: > > On Thu, 6 Oct 2022 08:56:08 +0200 > Michael Nazzareno Trimarchi wrote: > > > [External email] > > > > > > > > > > > > Hi > > > > On Thu, Oct 6, 2022 at 5:15 AM wrote: > > > > > > From: Mikhail Kshevetskiy > > > > > > 'mtd erase' comm

Re: [PATCH 2/7] mtd/nand: try to erase bad blocks only if scrub flag is provided

2022-10-06 Thread Michael Nazzareno Trimarchi
Hi Mikhail On Thu, Oct 6, 2022 at 6:17 PM Mikhail Kshevetskiy wrote: > > On Thu, 6 Oct 2022 18:03:17 +0200 > Michael Nazzareno Trimarchi wrote: > > > [External email] > > > > > > > > > > > > On Thu, Oct 6, 2022 at 5:52 PM Mikhail Kshevetskiy > > wrote: > > > > > > On Thu, 6 Oct 2022 08:56:08 +0

Re: [PATCH 7/7] net/tftp: make tftpput working with servers that do not use OACK

2022-10-06 Thread Tom Rini
On Thu, Oct 06, 2022 at 06:18:13AM +0300, mikhail.kshevets...@iopsys.eu wrote: > From: Mikhail Kshevetskiy > > Signed-off-by: Mikhail Kshevetskiy > --- > net/tftp.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/net/tftp.c b/net/tftp.c > index dea9c25ffd..e12

Re: Adding 'N:' field support to buildman's boards database

2022-10-06 Thread Simon Glass
Hi Tom, On Thu, 6 Oct 2022 at 09:33, Tom Rini wrote: > > On Mon, Sep 12, 2022 at 04:20:07PM -0400, Tom Rini wrote: > > > Hey, > > > > So looking at series such as > > https://patchwork.ozlabs.org/project/uboot/patch/20220801113804.v2.1.I49e41e791b038a159729c535e9dcfc4a7d59e95c@changeid/ > > we ru

Re: RFC: return value of event_register()

2022-10-06 Thread Simon Glass
+U-Boot Mailing List On Wed, 5 Oct 2022 at 02:54, Heinrich Schuchardt wrote: > > Hello Simon, > > event_register() currently returns an integer to indicate success. > > If we ever want to implement an event_unregister() function ,it would be > preferable if the return value of event_register were

Re: [u-boot][PATCH v2 1/4] dm: memory: Introduce new uclass

2022-10-06 Thread Simon Glass
Hi Roger, On Thu, 6 Oct 2022 at 07:24, Roger Quadros wrote: > > Introduce UCLASS_MEMORY for future Memory Controller > device drivers. > > Signed-off-by: Roger Quadros > --- > arch/sandbox/dts/test.dts | 4 > drivers/memory/Kconfig | 17 + > drivers/memory/M

Re: [PATCH v13 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-06 Thread Simon Glass
Hi Sughosh, On Thu, 6 Oct 2022 at 03:07, Sughosh Ganu wrote: > > Add test cases for accessing the FWU Metadata on the sandbox > platform. The sandbox platform also uses the metadata access driver > for GPT partitioned block devices. > > The FWU feature will be tested on the sandbox64 variant with

Re: Uboot support intel xeon gold

2022-10-06 Thread Simon Glass
Hi Fontaine, +Bin Meng On Thu, 6 Oct 2022 at 05:18, fontaine garin Tham wrote: > > Hi Developers, > > I would like to know if uboot supports intel xeon gold processors and if the > is any samples for make menuconfig. > > I have check the board in intel it does not show Xeon processor. So I am a

[PATCH 0/2 v2] Clean up protocol installation API

2022-10-06 Thread Ilias Apalodimas
Hi! This is v2 of [0] trying to clean up the handle and protocol management APIs. [0] https://lore.kernel.org/u-boot/4766d2b2-7fd3-0206-37ee-709a6fe2b...@gmx.de/T/ Changes since v1: patch 1/2: - remove (void*) since it's not needed when installing protocols - convert #ifdefs to if CONFIG_IS_EN

[PATCH 1/2 v2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-06 Thread Ilias Apalodimas
A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes all protocols on a handle and deletes the han

[PATCH 2/2 v2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06 Thread Ilias Apalodimas
In general handles should only be deleted if the last remaining protocol is removed. Instead of explicitly calling efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly removes all protocols from a handle before removing it, use InstallMultiple/UninstallMultiple which adheres t

  1   2   >