Re: [PATCH] ARM: omap3: evm: Name this directory omap3

2022-10-07 Thread Derald Woods
On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote: > Before this was named just evm, which doesn't match the naming > of the other TI board file directory and makes it look like a > common directory for evms. Name this omap3. > > Signed-off-by: Andrew Davis > --- >

Re: [PATCH] doc: board: j721e_evm: Add DM firmware steps

2022-10-07 Thread Heinrich Schuchardt
On 10/7/22 22:37, Andrew Davis wrote: J721e needs DM firmware when using updated SYSFW. Add steps to fetch, build, and deploy the same. Signed-off-by: Andrew Davis --- doc/board/ti/j721e_evm.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 1/1] doc: describe usage of virt-make-fs for testing

2022-10-07 Thread Heinrich Schuchardt
We want tests to avoid the usage of sudo. Describe that virt-make-fs can generate disk images without being root. Signed-off-by: Heinrich Schuchardt --- doc/develop/py_testing.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/develop/py_testing.rst

[PATCH 1/1] doc: add python3-filelock python3-pytest-xdist

2022-10-07 Thread Heinrich Schuchardt
Packages python3-filelock python3-pytest-xdist as required to run 'make tests'. Add them to the required packages list in the documentation. Signed-off-by: Heinrich Schuchardt --- doc/build/gcc.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/build/gcc.rst

[PATCH] efi_driver: fix efi_uc_stop()

2022-10-07 Thread Heinrich Schuchardt
We must always call EFI_EXIT() when returning from an EFIAPI function. Fixes: 05ef48a2484b ("efi_driver: EFI block driver") Signed-off-by: Heinrich Schuchardt --- lib/efi_driver/efi_uclass.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/efi_driver/efi_uclass.c

[PATCH] doc: board: j721e_evm: Add DM firmware steps

2022-10-07 Thread Andrew Davis
J721e needs DM firmware when using updated SYSFW. Add steps to fetch, build, and deploy the same. Signed-off-by: Andrew Davis --- doc/board/ti/j721e_evm.rst | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/board/ti/j721e_evm.rst

[PATCH] tools: k3_gen_x509_cert: Do not print SWRV on build

2022-10-07 Thread Andrew Davis
This matches the others here. Signed-off-by: Andrew Davis --- tools/k3_gen_x509_cert.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh index 029247c105..d9cde07417 100755 --- a/tools/k3_gen_x509_cert.sh +++

[PATCH] arm: mach-k3: Move hardware handling to common files

2022-10-07 Thread Andrew Davis
These hardware register definitions are common for all K3, remove duplicate data them by moving them to hardware.h. While here do some minor whitespace cleanup + grouping. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 1 -

[PATCH v2 1/1] doc: man-page for cls

2022-10-07 Thread Heinrich Schuchardt
Provide a man-page for the cls command. Signed-off-by: Heinrich Schuchardt --- v2: send the full patch --- doc/usage/cmd/cls.rst | 26 ++ doc/usage/index.rst | 1 + 2 files changed, 27 insertions(+) create mode 100644 doc/usage/cmd/cls.rst diff --git

[PATCH 1/1] doc: man-page for cls

2022-10-07 Thread Heinrich Schuchardt
Provide a man-page for the cls command. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/cls.rst | 2 +- doc/usage/index.rst | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/usage/cmd/cls.rst b/doc/usage/cmd/cls.rst index 44204b32a1..b5c43e0a2e 100644 ---

[PATCH 1/1] cmd: CMD_CLS should not depend on video

2022-10-07 Thread Heinrich Schuchardt
The cls command works fine on the serial console. There is no reason to let it depend on the availability of video. Signed-off-by: Heinrich Schuchardt --- cmd/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index bfa12ce12a..6f00bd9307 100644 ---

Re: [PATCH v2] mtd: Update the function name to 'rfree'

2022-10-07 Thread Michael Nazzareno Trimarchi
Hi On Fri, Oct 7, 2022 at 4:36 PM Fabio Estevam wrote: > > Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") > the function has been renamed to rfree(), so update the description > inside the mtd_oob_region structure as well. > > Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") >

[PATCH] ARM: omap3: evm: Name this directory omap3

2022-10-07 Thread Andrew Davis
Before this was named just evm, which doesn't match the naming of the other TI board file directory and makes it look like a common directory for evms. Name this omap3. Signed-off-by: Andrew Davis --- arch/arm/mach-omap2/omap3/Kconfig | 2 +- board/ti/{evm => omap3}/Kconfig | 2 +-

[PATCH] arm: mach-k3: security: Use dma-mapping for cache ops

2022-10-07 Thread Andrew Davis
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/security.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-k3/security.c

[PATCH 3/3] dma: Transfer dma_ops should use DMA address types

2022-10-07 Thread Andrew Davis
DMA operations should function on DMA addresses, not virtual addresses. Although these are usually the same in U-Boot, it is more correct to be explicit with our types here. Signed-off-by: Andrew Davis --- drivers/dma/dma-uclass.c | 2 +- drivers/dma/sandbox-dma-test.c | 4 ++--

[PATCH 2/3] dma: ti-edma3: Add DMA map operations before and after transfers

2022-10-07 Thread Andrew Davis
We should clean the caches before any DMA operation and clean+invalidate after. This matches what the DMA framework does for us already but adds it to the two functions here in this driver that don't yet go through the new DMA framework. Signed-off-by: Andrew Davis --- drivers/dma/ti-edma3.c |

[PATCH 1/3] dma: Use dma-mapping for cache ops and sync after write

2022-10-07 Thread Andrew Davis
The DMA'd memory area needs cleaned and invalidated after the DMA write so that any stale cache lines do not mask new data. Signed-off-by: Andrew Davis --- drivers/dma/dma-uclass.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dma-uclass.c

Re: [PATCH 1/1] efi_loader: CloseProtocol in tcg2_measure_gpt_data

2022-10-07 Thread Ilias Apalodimas
On Fri, Oct 07, 2022 at 03:38:45PM +0200, Heinrich Schuchardt wrote: > The CloseProtocol() boot service requires a handle as first argument. > Passing the protocol interface is incorrect. > > CloseProtocol() only has an effect if called with a non-zero value for > agent_handle. HandleProtocol()

Re: [PATCH v3] gpio: ftgpio010: Add support for Faraday Technology FTGPIO010

2022-10-07 Thread Pali Rohár
On Friday 07 October 2022 12:27:43 Sergei Antonov wrote: > On Mon, 12 Sept 2022 at 13:11, Sergei Antonov wrote: > > > > Add Faraday Technology's FTGPIO010 controller driver. > > > > Signed-off-by: Sergei Antonov > > --- > > v2 -> v3: > > Implement .get_function to make "gpio status" command

[PATCH] arm: mach-k3: common: Set boot_fit on non-GP devices

2022-10-07 Thread Andrew Davis
This matches what we did for pre-K3 devices. This allows us to build boot commands that can check for our device type at runtime. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-k3/common.c

Re: [PATCH v4 3/3] riscv: Fix build against binutils 2.38

2022-10-07 Thread Tom Rini
On Mon, Oct 03, 2022 at 06:07:54PM +0200, Heinrich Schuchardt wrote: > From: Alexandre Ghiti > > The following description is copied from the equivalent patch for the > Linux Kernel proposed by Aurelien Jarno: > > >From version 2.38, binutils default to ISA spec version 20191213. This > means

Re: [PATCH v4 2/3] buildman: differentiate between riscv32, riscv64

2022-10-07 Thread Tom Rini
On Mon, Oct 03, 2022 at 06:07:53PM +0200, Heinrich Schuchardt wrote: > riscv32 needs a different toolchain than riscv64 > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > Reviewed-by: Rick Chen Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v4 1/3] docker: install riscv32 toolchain

2022-10-07 Thread Tom Rini
On Mon, Oct 03, 2022 at 06:07:52PM +0200, Heinrich Schuchardt wrote: > For building riscv32 targets we should use the riscv32 toolchain. > Add it to the Docker image. > > Drop the riscv toolchain-alias as we do not need it in future. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Tom

Re: [PATCH v2 4/4] common/board_f: drop ifdefs around header includes

2022-10-07 Thread Tom Rini
On Tue, Sep 13, 2022 at 09:31:29PM +0300, Ovidiu Panait wrote: > Drop the remaining ifdef around spl.h include. > > Reviewed-by: Simon Glass > Signed-off-by: Ovidiu Panait Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] arm64: versal: Add zynq_board_read_rom_ethaddr()

2022-10-07 Thread Venkatesh Yadav Abbarapu
zynq_gem.c invokes zynq_board_read_rom_ethaddr(), but neglected to declare its declaration, causing the following sparse and compile time warnings: drivers/net/zynq_gem.c:662:12: warning: no previous prototype for 'zynq_board_read_rom_ethaddr' [-Wmissing-prototypes] 662 | __weak int

Re: [PATCH v2 3/4] common/board_f: introduce arch_setup_dest_addr()

2022-10-07 Thread Tom Rini
On Tue, Sep 13, 2022 at 09:31:28PM +0300, Ovidiu Panait wrote: > In order to move ppc-specific code out of setup_dest_addr(), provide an > arch-specific variant arch_setup_dest_addr(), that can be used by > architecture code to fix up the initial reloc address. > > It is called at the end of

Re: [PATCH v2 2/4] common/board_f: move CONFIG_MACH_TYPE logic to arch/arm/lib/bdinfo.c

2022-10-07 Thread Tom Rini
On Tue, Sep 13, 2022 at 09:31:27PM +0300, Ovidiu Panait wrote: > asm/mach_type.h header and CONFIG_MACH_TYPE macro are arm-specific, so move > related bdinfo logic to arch_setup_bdinfo() in arch/arm/lib/bdinfo.c. > > Reviewed-by: Simon Glass > Signed-off-by: Ovidiu Panait Applied to

Re: [PATCH v2 1/4] common/board_f: remove XTRN_DECLARE_GLOBAL_DATA_PTR dead code

2022-10-07 Thread Tom Rini
On Tue, Sep 13, 2022 at 09:31:26PM +0300, Ovidiu Panait wrote: > The XTRN_DECLARE_GLOBAL_DATA_PTR declarations in ppc code are permanently > commented out, so there are no users for this macro: > #if 1 >#define DECLARE_GLOBAL_DATA_PTR register volatile gd_t *gd asm ("r2") > #else /* We

Re: [PATCH v3] gpio: ftgpio010: Add support for Faraday Technology FTGPIO010

2022-10-07 Thread Tom Rini
On Mon, Sep 12, 2022 at 01:09:15PM +0300, Sergei Antonov wrote: > Add Faraday Technology's FTGPIO010 controller driver. > > Signed-off-by: Sergei Antonov Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v1 2/2] clk: nuvoton: Add support for NPCM845

2022-10-07 Thread Tom Rini
On Tue, Sep 27, 2022 at 04:45:16PM +0800, Jim Liu wrote: > Add clock controller driver for NPCM845 > > Signed-off-by: Jim Liu > Acked-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v1 1/2] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-10-07 Thread Tom Rini
On Tue, Sep 27, 2022 at 04:45:15PM +0800, Jim Liu wrote: > Add basic support for the Nuvoton NPCM845 EVB (Arbel). > > Signed-off-by: Jim Liu Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] net: ti: am65-cpsw-nuss: Enable MDIO manual mode

2022-10-07 Thread Tom Rini
On Thu, Sep 22, 2022 at 03:21:24PM +0530, Ravi Gunasekaran wrote: > For the TI SoCs affected by errata i2329, enable MDIO manual > mode by default > > Signed-off-by: Ravi Gunasekaran > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 1/2] net: ti: cpsw-mdio: Add workaround for errata i2329

2022-10-07 Thread Tom Rini
On Thu, Sep 22, 2022 at 03:21:23PM +0530, Ravi Gunasekaran wrote: > In certain TI SoCs, on the CPSW and ICSS peripherals, there is > a possibility that the MDIO interface returns corrupt data on > MDIO reads or writes incorrect data on MDIO writes. There is also > a possibility for the MDIO

Re: [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error

2022-10-07 Thread Tom Rini
On Tue, Sep 20, 2022 at 10:56:02AM +0530, Dhruva Gole wrote: > Include linux/sizes.h because it defines SZ_64K which is used in many > places inside k3-udma.c > This fixes the error: ‘SZ_64K’ undeclared which appears during build > time > > Signed-off-by: Dhruva Gole > Reviewed-by: Tom Rini

Re: [PATCH] armv8: cache_v8: Fix pgtables setup when MMU is already enabled

2022-10-07 Thread Tom Rini
On Wed, Sep 14, 2022 at 01:37:46PM +0200, Pali Rohár wrote: > When MMU is already enabled then dcache_enable() does not call mmu_setup() > and so setup_all_pgtables() is also never called. > > In this situation when some driver calls mmu_set_region_dcache_behaviour() > function then U-Boot

Re: [PATCH 2/2] board: developerbox: move mem_map setup later

2022-10-07 Thread Tom Rini
On Mon, Sep 12, 2022 at 12:05:29PM -0500, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > dram_init() can't modify global/static variables, so > move the mem_map setup later when bss is available. > > Signed-off-by: Jassi Brar Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 1/2] board: developerbox: use identity mapping for >4GB

2022-10-07 Thread Tom Rini
On Mon, Sep 12, 2022 at 12:05:15PM -0500, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > Identity-map the second and later memory banks which are located >4GB. > > Signed-off-by: Jassi Brar Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] efi_loader: CloseProtocol in efi_fmp_find

2022-10-07 Thread Ilias Apalodimas
Hi Heinrich On Fri, 7 Oct 2022 at 17:06, Heinrich Schuchardt wrote: > > The CloseProtocol() boot service requires a handle as first argument. > Passing the protocol interface is incorrect. > > CloseProtocol() only has an effect if called with a non-zero value for > agent_handle. HandleProtocol()

Re: [PATCH 1/1] efi_loader: don't export efi_remove_all_protocols

2022-10-07 Thread Ilias Apalodimas
Hi Heinrich, On Fri, 7 Oct 2022 at 17:57, Heinrich Schuchardt wrote: > > This function is only used inside efi_boottime.c and is not safe to use > outside of this context. Yep, thanks for this. We also need to do the same with efi_delete_handle, once I finish up that cleanup > >

[PATCH 1/1] efi_loader: don't export efi_remove_all_protocols

2022-10-07 Thread Heinrich Schuchardt
This function is only used inside efi_boottime.c and is not safe to use outside of this context. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 160f554ee9..1bac3f49a3 100644 ---

[PATCH v2] mtd: Update the function name to 'rfree'

2022-10-07 Thread Fabio Estevam
Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") the function has been renamed to rfree(), so update the description inside the mtd_oob_region structure as well. Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") Reported-by: Mikhail Kshevetskiy Signed-off-by: Fabio Estevam ---

Re: [PATCH] mtd.h: Update the function name to 'rfree'

2022-10-07 Thread Michael Nazzareno Trimarchi
HI On Fri, Oct 7, 2022 at 4:13 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Fri, Oct 7, 2022 at 4:12 PM Fabio Estevam wrote: > > > > Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") > > the function has been renamed to rfree(), so update the description > > inside the

Re: [PATCH] mtd.h: Update the function name to 'rfree'

2022-10-07 Thread Michael Nazzareno Trimarchi
Hi On Fri, Oct 7, 2022 at 4:12 PM Fabio Estevam wrote: > > Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") > the function has been renamed to rfree(), so update the description > inside the mtd_oob_region structure as well. > > Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") >

[PATCH] mtd.h: Update the function name to 'rfree'

2022-10-07 Thread Fabio Estevam
Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") the function has been renamed to rfree(), so update the description inside the mtd_oob_region structure as well. Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") Reported-by: Mikhail Kshevetskiy Signed-off-by: Fabio Estevam ---

[PATCH 1/1] efi_loader: CloseProtocol in efi_fmp_find

2022-10-07 Thread Heinrich Schuchardt
The CloseProtocol() boot service requires a handle as first argument. Passing the protocol interface is incorrect. CloseProtocol() only has an effect if called with a non-zero value for agent_handle. HandleProtocol() uses an opaque agent_handle when invoking OpenProtocol() (currently NULL).

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-07 Thread Michael Nazzareno Trimarchi
Hi Fabio If you send the change of the comment, I will queue it Michael On Fri, Oct 7, 2022 at 1:59 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Fri, Oct 7, 2022 at 1:58 PM Fabio Estevam wrote: > > > > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi > > wrote: > > > > >

[PATCH 1/1] efi_loader: CloseProtocol in tcg2_measure_gpt_data

2022-10-07 Thread Heinrich Schuchardt
The CloseProtocol() boot service requires a handle as first argument. Passing the protocol interface is incorrect. CloseProtocol() only has an effect if called with a non-zero value for agent_handle. HandleProtocol() uses an opaque agent_handle when invoking OpenProtocol() (currently NULL).

Re: [PATCH 1/1] efi_loader: printf code n efi_disk_get_device_name()

2022-10-07 Thread Ilias Apalodimas
On Fri, 7 Oct 2022 at 13:56, Heinrich Schuchardt wrote: > > part is unsigned. So it must be printed with %u. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_disk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_disk.c

[PATCH v5] imx: support i.MX8QM DMSSE20 a1 board

2022-10-07 Thread Oliver Graute
Add i.MX8QM DMSSE20 a1 board support U-Boot 2022.10-00033-g934b00a6e7 (Oct 07 2022 - 14:22:04 +0200) Model: Advantech iMX8QM DMSSE20 Board: DMS-SE20A1 8GB Build: SCFW 549b1e18, SECO-FW c9de51c0, ATF 5782363 Boot: USB DRAM: 8 GiB Core: 100 devices, 19 uclasses, devicetree: separate MMC:

[PATCH v4] imx: imx8qm: cgtqmx8: switch to binman

2022-10-07 Thread Oliver Graute
Switch to use binman to pack images Signed-off-by: Oliver Graute Reviewed-by: Fabio Estevam Reviewed-by: Simon Glass --- Changes for v4 - rebased on master Changes for v3 -added Reviewed-by - rebased on master arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + arch/arm/mach-imx/imx8/Kconfig

[PATCH v3] imx: imx8qm-rom7720: switch to binman

2022-10-07 Thread Oliver Graute
Switch to use binman to pack images Signed-off-by: Oliver Graute --- Changes for v3 - just rebased to master Changes for v2 - just rebased to master arch/arm/dts/imx8qm-rom7720-a1.dts| 1 + arch/arm/dts/imx8qm-u-boot.dtsi | 133 ++

Re: [PATCH 1/3] mmc: zynq_sdhci: Change node_id prototype to u32

2022-10-07 Thread Jaehoon Chung
On 9/30/22 18:25, Ashok Reddy Soma wrote: > In Versal platform power domain node_id is bigger than u8, hence > change prototype to u32 to accommodate. Change u8 to u32 in the function > prototypes that use node_id and remove casting to u32 from > xilinx_pm_request() call parameters. > >

Re: [PATCH] mmc: Fix static checker warnings

2022-10-07 Thread Jaehoon Chung
On 9/29/22 13:52, Venkatesh Yadav Abbarapu wrote: > Correct pointer dereferencing check to be more consistent. > > Eliminate the below smatch warning: > drivers/mmc/mmc.c:3118 mmc_init_device() > warn: variable dereferenced before check 'm' (see line 3116) > > Signed-off-by: Venkatesh Yadav

Re: [PATCH] power: fan53555: Fix missing newline in error message

2022-10-07 Thread Jaehoon Chung
On 9/25/22 22:43, Michal Suchanek wrote: > Avoid concatenation with following message. > > Signed-off-by: Michal Suchanek Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/power/pmic/fan53555.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] mmc: fsl_esdhc: fix problem when using clk driver

2022-10-07 Thread Jaehoon Chung
On 9/24/22 07:29, Marek Vasut wrote: > From: Ye Li > > Move init_clk_usdhc to non-clk driver case, since assigned-clocks properties > will initialize the clocks by clk driver. > > Signed-off-by: Ye Li > Signed-off-by: Marek Vasut Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung

Re: [PATCH] bootcount: pmic: Correct misleading comment

2022-10-07 Thread Jaehoon Chung
On 9/19/22 17:11, Philip Oberfichtner wrote: > Fix a copy-paste error I did when inserting the comment. > > Signed-off-by: Philip Oberfichtner Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > > --- > > drivers/bootcount/Kconfig | 2 +- >

Re: [PATCH v3 4/5] drivers: power: pmic: Enable use of rn5t567 PMIC in SPL

2022-10-07 Thread Jaehoon Chung
On 9/16/22 19:24, Martyn Welch wrote: > The support added later in this series tweaks the PMIC voltages in the > SPL. Enable support for the rn5t567 in SPL builds to allow this to be done > cleanly. > > Signed-off-by: Martyn Welch Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung >

Re: [PATCH v3 3/5] drivers: power: pmic: Add support for rn5t568 PMIC

2022-10-07 Thread Jaehoon Chung
On 9/16/22 19:24, Martyn Welch wrote: > From: Martyn Welch > > Add support for the rn5t568 PMIC to the rn5t567 driver. > > Signed-off-by: Martyn Welch Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v2: > - None > > Changes in v3: > - None > >

Re: [PATCH] mmc: dwmmc: only clear handled interrupts

2022-10-07 Thread Jaehoon Chung
On 9/16/22 02:56, John Keeping wrote: > Unconditionally clearing DTO when RXDR is set leads to spurious timeouts > in FIFO mode transfers if events occur in the following order: > > mask = dwmci_readl(host, DWMCI_RINTSTS); > > // Hardware asserts DWMCI_INTMSK_DTO here > >

Re: [PATCH 3/3] mmc: stm32_sdmmc2: manage vqmmc

2022-10-07 Thread Jaehoon Chung
On 9/13/22 20:23, Yann Gautier wrote: > The SDMMC IOs can be in an IO domain, that has to be enabled. > This is done by enabling vqmmc in the driver. > This has no impact on configurations not using an IO domain, the check > can then be executed on all platforms managing regulator, and the

Re: [PATCH 2/3] mmc: stm32_sdmmc2: protect against unsupported modes

2022-10-07 Thread Jaehoon Chung
On 9/13/22 20:23, Yann Gautier wrote: > The UHS modes for SD, HS200 and HS400 modes for eMMC are not supported > by the stm32_sdmmc2 driver. > Make it clear by removing the corresponding caps after parsing the DT. > > Signed-off-by: Yann Gautier Reviewed-by: Jaehoon Chung Best Regards,

Re: [PATCH 1/3] mmc: stm32_sdmmc2: add dual data rate support

2022-10-07 Thread Jaehoon Chung
On 9/13/22 20:23, Yann Gautier wrote: > To support dual data rate with STM32 sdmmc2 driver, the dedicated bit > (DDR - BIT(18)) needs to be set in the CLKRC register. Clock bypass > (no divider) is not allowed in this case. This is required for the > eMMC DDR modes. > > Signed-off-by: Yann

Re: [PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Hello Michal, Am Freitag, 7. Oktober 2022, 08:34:15 CEST schrieb Michal Simek: > Hi, > > On 10/6/22 16:56, Alexander Dahl wrote: > > Hello Michal, > > > > Am Donnerstag, 6. Oktober 2022, 16:44:29 CEST schrieb Michal Simek: > >> Hi, > >> > >> On 10/5/22 13:44, Alexander Dahl wrote: > >>> Hei

[PATCH v4 08/10] fpga: spartan2: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/spartan2.c | 80 +++-- 1 file changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/fpga/spartan2.c

[PATCH v4 01/10] fpga: Add missing Kconfig symbols for old FPGA drivers

2022-10-07 Thread Alexander Dahl
Those drivers could not be built anymore without those options present. Signed-off-by: Alexander Dahl --- drivers/fpga/Kconfig | 12 1 file changed, 12 insertions(+) diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index e2fd16e6d2..813d6a836d 100644 ---

[PATCH v4 07/10] fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/ACEX1K.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/fpga/ACEX1K.c

[PATCH v4 00/10] Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Hei hei, while working on FPGA support for a new device I discovered debug logging in some FPGA drivers is still done as in the old days. Bring that to what I thougt would be the currently preferred approach. Notes: Adding those Kconfig symbols in patch 1 is just to be able to build two of the

[PATCH v4 10/10] fpga: virtex2: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/virtex2.c | 69 ++ 1 file changed, 30 insertions(+), 39 deletions(-) diff --git a/drivers/fpga/virtex2.c

[PATCH v4 09/10] fpga: spartan3: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/spartan3.c | 80 +++-- 1 file changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/fpga/spartan3.c

[PATCH v4 05/10] fpga: altera: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/altera.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/altera.c b/drivers/fpga/altera.c index

[PATCH v4 02/10] fpga: spartan2: Fix printf arguments warning

2022-10-07 Thread Alexander Dahl
That extra comma messes up format arguments. Warning appears if built with FPGA_DEBUG defined: CC drivers/fpga/spartan2.o /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c: In function ‘spartan2_sp_load’: /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c:112:11: warning: too

[PATCH v4 06/10] fpga: cyclon2: Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/cyclon2.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/fpga/cyclon2.c

[PATCH v4 03/10] fpga: spartan3: Fix printf arguments warning

2022-10-07 Thread Alexander Dahl
The additional comma messes up the arguments. Warning appears if built with FPGA_DEBUG defined: CC drivers/fpga/spartan3.o /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c: In function ‘spartan3_sp_load’: /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:118:11: warning:

[PATCH v4 04/10] fpga: virtex2: Fix printf format string warnings

2022-10-07 Thread Alexander Dahl
Warning appears if built with FPGA_DEBUG defined: CC drivers/fpga/virtex2.o /mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c: In function ‘virtex2_ssm_load’: /mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:333:11: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-07 Thread Michael Nazzareno Trimarchi
Hi On Fri, Oct 7, 2022 at 1:58 PM Fabio Estevam wrote: > > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi > wrote: > > > About this change, there was a commit from Simon 8d38a8459b0 > > that was renamed. You ask basically to revert it > > Correct, what about fixing it like this? > >

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-07 Thread Fabio Estevam
On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi wrote: > About this change, there was a commit from Simon 8d38a8459b0 > that was renamed. You ask basically to revert it Correct, what about fixing it like this? diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-07 Thread Michael Nazzareno Trimarchi
Hi mikhail On Thu, Oct 6, 2022 at 5:15 AM wrote: > > From: Mikhail Kshevetskiy > > In the description of struct mtd_ooblayout_ops we see: > > * @free: function returning a free region in the OOB area. > *Should return -ERANGE if %section exceeds the total number of > *free

[PATCH] clk: versal: Mark versal_clock_setup() as static

2022-10-07 Thread Venkatesh Yadav Abbarapu
Fix the following sparse and compile time warning triggered with W=1: drivers/clk/clk_versal.c:605:5: warning: no previous prototype for 'versal_clock_setup' [-Wmissing-prototypes] 605 | int versal_clock_setup(void) Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/clk/clk_versal.c | 2 +-

Re: Uboot support intel xeon gold

2022-10-07 Thread fontaine garin Tham
Hi Simon, Thank you very much for your kind response and your time. I will go look into coreboot. With Regards, Fontaine Sent from my iPhone > On 7 Oct 2022, at 3:07 AM, Simon Glass wrote: > > Hi Fontaine, > > +Bin Meng > >> On Thu, 6 Oct 2022 at 05:18, fontaine garin Tham >> wrote: >>

[PATCH 1/1] efi_loader: printf code n efi_disk_get_device_name()

2022-10-07 Thread Heinrich Schuchardt
part is unsigned. So it must be printed with %u. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index 3b4ac27b76..0c6d35874f 100644 ---

[PATCH] smem: msm: add missing

2022-10-07 Thread Robert Marko
MSM SMEM driver is currently missing header and throws the following compile error: drivers/smem/msm_smem.c: In function ‘qcom_smem_get_ptable’: drivers/smem/msm_smem.c:635:71: error: ‘SZ_4K’ undeclared (first use in this function) 635 | ptable = smem->regions[0].virt_base +

Re: [PATCH] xilinx: zynqmp: change the type of multiboot variable

2022-10-07 Thread Michal Simek
On 10/4/22 07:52, Venkatesh Yadav Abbarapu wrote: In function ‘set_dfu_alt_info’ a comparison of a u8 value against 0 is done. Since it is always false, change the signature of this function to use an `int` instead, which match the type used in caller: `multi_boot()`. Fix the following

[PATCH v2 2/2] mach-meson: g12a: reset usb controller in reset_misc()

2022-10-07 Thread Mattijs Korpershoek
On some g12a boards like the VIM3L and the SEI610, with some USB cables/hosts, there is a long (5s) delay before between "fastboot reboot" and the host detecting a USB reset. This breaks tools relying on "fastboot reboot fastboot" which assume that 1s after the command send, the board should

[PATCH v2 1/2] usb: gadget: fastboot: detach usb on reboot commands

2022-10-07 Thread Mattijs Korpershoek
When host issues "fastboot reboot fastboot", it's expected that the board drops the USB connection before resetting. On some boards, such as Khadas VIM3L and SEI610, this is not the case. We observe the following error: $ fastboot reboot fastboot Rebooting into fastboot

[PATCH v2 0/2] fastboot/mach-meson: release usb_gadget on reboot commands

2022-10-07 Thread Mattijs Korpershoek
When host issues "fastboot reboot fastboot", it's expected that the board drops the USB connection before resetting. On some boards, such as Khadas VIM3L and SEI610, this is not the case. We observe the following error: $ fastboot reboot fastboot Rebooting into fastboot

Re: [PATCH] soc: xilinx: zynqmp: Mark soc_xilinx_zynqmp_get_machine() as static

2022-10-07 Thread Michal Simek
On 10/4/22 07:52, Venkatesh Yadav Abbarapu wrote: Fix the following sparse and compile time warning triggered with W=1: drivers/soc/soc_xilinx_zynqmp.c:288:5: warning: no previous prototype for 'soc_xilinx_zynqmp_get_machine' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu

Re: [PATCH] xilinx: common: Add print_cpuinfo() declaration

2022-10-07 Thread Michal Simek
On 10/4/22 07:50, Venkatesh Yadav Abbarapu wrote: cpu-info.c defines print_cpuinfo(), but neglected to include its declaration, causing the following sparse and compile time warnings: board/xilinx/common/cpu-info.c:10:5: warning: no previous prototype for 'print_cpuinfo'

Re: [PATCH] xilinx: common: Add zynq_board_read_rom_ethaddr() declaration

2022-10-07 Thread Michal Simek
On 10/4/22 07:46, Venkatesh Yadav Abbarapu wrote: board.c defines zynq_board_read_rom_ethaddr(), but neglected to include its declaration, causing the following sparse and compile time warnings: board/xilinx/common/board.c:56:5: warning: no previous prototype for

Re: [PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static

2022-10-07 Thread Michal Simek
On 10/4/22 07:37, Venkatesh Yadav Abbarapu wrote: Fix the following sparse and compile time warning triggered with W=1: drivers/spi/zynqmp_gqspi.c:286:6: warning: no previous prototype for 'zynqmp_qspi_set_tapdelay' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu ---

Re: [PATCH] arm64: zynqmp: Fix compiler warnings in mp.c

2022-10-07 Thread Michal Simek
On 10/4/22 07:34, Venkatesh Yadav Abbarapu wrote: make W=1 generates the following warning in cpu_disable, cpu_status and cpu_release functions. arch/arm/mach-zynqmp/mp.c:166:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits] 166 | if (nr >=

[PATCH 1/1] efi_loader: reformat efi_disk_add_dev()

2022-10-07 Thread Heinrich Schuchardt
Make it clearer why InstallMultipleProtocolInterfaces is invoked with two NULLs: * rename guid to esp_guid * put protocol GUIDs and the related interfaces on same lines * add comment Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 20 1 file changed, 12

Re: [PATCH v3] gpio: ftgpio010: Add support for Faraday Technology FTGPIO010

2022-10-07 Thread Sergei Antonov
On Mon, 12 Sept 2022 at 13:11, Sergei Antonov wrote: > > Add Faraday Technology's FTGPIO010 controller driver. > > Signed-off-by: Sergei Antonov > --- > v2 -> v3: > Implement .get_function to make "gpio status" command work. > > v1 -> v2: > Replace setbits_le32() with a simpler function

commit 787f04bb6a - imx: add USB2_BOOT type

2022-10-07 Thread Rasmus Villemoes
Hi Peng It seems that commit 787f04bb6a (imx: add USB2_BOOT type) broke our board logic which relies on whether get_boot_device() returns USB_BOOT or not. Instrumenting get_boot_device() shows that on our imx8mp board, boot_instance is 3 when we're booting over USB, so boot_dev becomes 20 instead

Re: [PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG

2022-10-07 Thread Michal Simek
Hi, On 10/6/22 16:56, Alexander Dahl wrote: Hello Michal, Am Donnerstag, 6. Oktober 2022, 16:44:29 CEST schrieb Michal Simek: Hi, On 10/5/22 13:44, Alexander Dahl wrote: Hei hei, while working on FPGA support for a new device I discovered debug logging in some FPGA drivers is still done as