[PATCH] riscv: ae350: Check firmware_fdt_addr header

2022-10-12 Thread Rick Chen
Check firmware_fdt_addr header to see if it is a valid fdt blob. Signed-off-by: Rick Chen --- board/AndesTech/ax25-ae350/ax25-ae350.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c b/board/AndesTech/ax25-ae350/ax25-ae350.c index

Re: [PATCH v3] schemas: Add schema for U-Boot driver model 'phase tags'

2022-10-12 Thread Simon Glass
Hi Rob, On Mon, 10 Oct 2022 at 10:34, Rob Herring wrote: > > On Tue, Oct 4, 2022 at 6:22 PM Simon Glass wrote: > > > > Until recently it has not been possible to add any U-Boot-specific > > properties to the device tree schema. Now that it is somewhat separated > > from Linux and people are

Re: [PATCH v6 01/20] dm: core: Fix uclass_probe_all to really probe all devices

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 13:58, Michal Suchanek wrote: > > uclass_probe_all uses uclass_first_device/uclass_next_device assigning > the return value. > > The interface for getting meaningful error is > uclass_first_device_check/uclass_next_device_check, use it. > > Also do not stop iteration when

Re: [PATCH v6 14/20] dm: pci: Update error handling in pci_sriov_init

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 13:58, Michal Suchanek wrote: > > Check the returned value from pci_get_bus. After a later patch > uclass_first_device_err may return a device on error and then checking > that a device is returned will not suffice. > > Signed-off-by: Michal Suchanek > --- > v6: - split

Re: [PATCH v6 15/20] mpc83xx: gazerbeam: Update sysinfo_get error handling

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 14:01, Michal Suchanek wrote: > > In a later patch sysinfo_get will be changed to return the device in cae > of an error. Set sysinfo to NULL on error to preserve previous behavior. > > Signed-off-by: Michal Suchanek > --- > board/gdsys/mpc8308/gazerbeam.c | 12

Re: [PATCH v6 16/20] dm: core: Switch uclass_foreach_dev_probe to use simple iterator

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 13:58, Michal Suchanek wrote: > > The return value is not used for anythig, and in a later patch the > behavior of the _err iterator will change in an incompatible way. > > Signed-off-by: Michal Suchanek > --- > v6: - split off as separate patch > --- >

Re: [PATCH v6 18/20] dm: core: Non-activated device may be returned from uclass iterators that provide error handling

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 13:58, Michal Suchanek wrote: > > Note in documentation that a non-activated device can be returned on > error. > > Signed-off-by: Michal Suchanek > --- > v6: - split off as separate patch > --- > include/dm/uclass.h | 12 > 1 file changed, 8 insertions(+), 4

Re: [PATCH 2/2] spl: spl_legacy: Fix printing image name

2022-10-12 Thread Simon Glass
On Wed, 12 Oct 2022 at 13:47, Michal Suchanek wrote: > > image_set_name does not terminate the name in the image header. > > Then is should not be assument it's nul terminated. image_print_contents > correctly print only IH_NMLEN characters. > > Fix printing the unterminated field in

Re: Bad Data CRC

2022-10-12 Thread Simon Glass
Hi, On Wed, 12 Oct 2022 at 07:50, momo aubin wrote: > > Thanks Fabio and Simon, > > find attached the log picture. > When I changed the size of the one partition in the kernel, I got this > message. Does the calculation of CRC in uboot depended on the size ? It seems like your kernel is

Re: [PATCH 5/6] sunxi: f1c100: dtsi: add UART1 pins

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:34:57 CEST je Andre Przywara napisal(a): > The F1Cx00 SoCs connect the first PortA pins to UART1. > > Add this to the SoC .dtsi, so boards can reference UART1 pins. > > Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec Best regards, Jernej

Re: [PATCH 4/6] sunxi: f1c100: add UART1 support

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:34:56 CEST je Andre Przywara napisal(a): > Some boards use UART1 for its debug UART, so define the pins for the SPL > and the pinmux name and mux value for U-Boot proper. > > Signed-off-by: Andre Przywara > --- > arch/arm/mach-sunxi/board.c

Re: [PATCH 3/6] sunxi: f1c100: move SKIP_LOWLEVEL_INIT_ONLY into Kconfig

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:34:55 CEST je Andre Przywara napisal(a): > So far we stated the lack of a lowlevel() init function for the F1C100s > board by defining the respective SKIP_* symbol in the board's > defconfig. However we don't expect any *board* to employ such low level

Re: [PATCH 2/6] sunxi: fix 32MB load address layout

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:34:54 CEST je Andre Przywara napisal(a): > The default load addresses for the various payloads (kernel, DT, > ramdisk) on systems with just 32MB of DRAM have some issues: > For a start the preceding comment doesn't match the actual values: > apparently

Re: [PATCH 1/6] sunxi: Kconfig: introduce SUNXI_MINIMUM_DRAM_MB

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:34:53 CEST je Andre Przywara napisal(a): > Traditionally we assumed that every Allwinner board would come with at > least 256 MB of DRAM, and set our DRAM layout accordingly. This affected > both the default load addresses, but also U-Boot's own address

Re: [PATCH] sunxi: defconfig: Add X96 Mate TV box

2022-10-12 Thread Jernej Škrabec
Hi Andre, Dne sreda, 12. oktober 2022 ob 18:26:10 CEST je Andre Przywara napisal(a): > The X96 Mate TV box is a TV box with the Allwinner H616 SoC. It is > available with up to 4GB of DRAM and 64GB eMMC. > The DRAM chips require a different configuration when compared to the > OrangePi Zero2, we

[PATCH v6 17/20] dm: core: Switch uclass_*_device_err to use uclass_*_device_check

2022-10-12 Thread Michal Suchanek
The _err variant iterators use the simple iterators without suffix as basis. However, there is no user that uclass_next_device_err for iteration, many users of uclass_first_device_err use it to get the first and (assumed) only device of an uclass, and a couple that use uclass_next_device_err to

[PATCH v6 19/20] dm: treewide: Do not use the return value of simple uclass iterator

2022-10-12 Thread Michal Suchanek
uclass_first_device/uclass_next_device return value will be removed, don't use it. With the current implementation dev is equivalent to !ret. It is redundant to check both, ret check can be replaced with dev check, and ret check inside the iteration is dead code. Signed-off-by: Michal Suchanek

[PATCH v6 20/20] dm: core: Do not stop uclass iteration on error

2022-10-12 Thread Michal Suchanek
When probing a device fails NULL pointer is returned, and following devices in uclass list cannot be iterated. Skip to next device on error instead. With that the only condition under which these simple iteration functions return error is when the dm is not initialized at uclass_get time. This is

[PATCH v6 18/20] dm: core: Non-activated device may be returned from uclass iterators that provide error handling

2022-10-12 Thread Michal Suchanek
Note in documentation that a non-activated device can be returned on error. Signed-off-by: Michal Suchanek --- v6: - split off as separate patch --- include/dm/uclass.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/include/dm/uclass.h b/include/dm/uclass.h

[PATCH v6 15/20] mpc83xx: gazerbeam: Update sysinfo_get error handling

2022-10-12 Thread Michal Suchanek
In a later patch sysinfo_get will be changed to return the device in cae of an error. Set sysinfo to NULL on error to preserve previous behavior. Signed-off-by: Michal Suchanek --- board/gdsys/mpc8308/gazerbeam.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH v6 13/20] net: eth-uclass: Do not set device on error

2022-10-12 Thread Michal Suchanek
eth_get_dev relies on the broken behavior that returns an error but not the device on which the error happened which gives the caller no reasonable way to report or handle the error. In a later patch uclass_first_device_err will be changed to return the device on error but eth_get_dev stores the

[PATCH v6 14/20] dm: pci: Update error handling in pci_sriov_init

2022-10-12 Thread Michal Suchanek
Check the returned value from pci_get_bus. After a later patch uclass_first_device_err may return a device on error and then checking that a device is returned will not suffice. Signed-off-by: Michal Suchanek --- v6: - split off as separate patch --- drivers/pci/pci-uclass.c | 7 +++ 1 file

[PATCH v6 16/20] dm: core: Switch uclass_foreach_dev_probe to use simple iterator

2022-10-12 Thread Michal Suchanek
The return value is not used for anythig, and in a later patch the behavior of the _err iterator will change in an incompatible way. Signed-off-by: Michal Suchanek --- v6: - split off as separate patch --- include/dm/uclass.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v6 12/20] dm: blk: Do not use uclass_next_device_err

2022-10-12 Thread Michal Suchanek
blk_first_device_err/blk_next_device_err uses uclass_first_device_err/uclass_next_device_err for device iteration. Although the function names superficially match the return value from uclass_first_device_err/uclass_next_device_err is never used meaningfully, and

[PATCH v6 11/20] dm: treewide: Use uclass_next_device_err when accessing second device

2022-10-12 Thread Michal Suchanek
There are a couple users of uclass_next_device return value that get the first device by other means and use uclass_next_device assuming the following device in the uclass is related to the first one. Use uclass_next_device_err because the return value from uclass_next_device will be removed in a

[PATCH v6 10/20] dm: treewide: Use uclass_first_device_err when accessing one device

2022-10-12 Thread Michal Suchanek
There is a number of users that use uclass_first_device to access the first and (assumed) only device in uclass. Some check the return value of uclass_first_device and also that a device was returned which is exactly what uclass_first_device_err does. Some are not checking that a device was

[PATCH v6 09/20] cmd: List all uclass devices regardless of probe error

2022-10-12 Thread Michal Suchanek
There are a few commands that iterate uclass with uclass_first_device/uclass_next_device or the _err variant. Use the _check class iterator variant to get devices that fail to probe as well, and print the status. Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- v6: Drop errno_str

[PATCH v6 07/20] video: ipuv3: Fix error handling when getting the display

2022-10-12 Thread Michal Suchanek
The code checks that uclass_first_device returned a device but the returned value that is assigned is never used. Use uclass_first_device_err instead, and move the error return outside of the if block. Fixes: f4ec1ae08e ("mxc_ipuv3_fb.c: call display_enable") Signed-off-by: Michal Suchanek

[PATCH v6 06/20] stdio: Fix class iteration in stdio_add_devices()

2022-10-12 Thread Michal Suchanek
There is a complaint in the code that iterates keyboards that we don't have the _check variant of class iterator but we in fact do, use it. In the code that iterates video devices there is an attempt to print errors but the simple iterator does not return a device when there is an error. Use the

[PATCH v6 08/20] w1: Fix bus counting in w1_get_bus

2022-10-12 Thread Michal Suchanek
Use uclass_first_device_check/uclass_next_device_check to correctly count buses that fail to probe. Fixes: d3e19cf919 ("w1: Add 1-Wire uclass") Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- drivers/w1/w1-uclass.c | 20 +++- 1 file changed, 11 insertions(+), 9

[PATCH v6 05/20] usb: ether: Fix error handling in usb_ether_init

2022-10-12 Thread Michal Suchanek
The code checks the return value from uclass_first_device as well as that the device exists but it passes on the return value which may be zero if there are no gadget devices. Just check that a device was returned and return -ENODEV otherwise. Also remove the dev variable which is not really used

[PATCH v6 04/20] bootstd: Fix listing boot devices

2022-10-12 Thread Michal Suchanek
bootdev_list() uses uclass_*_device_err() to iterate devices. However, the only value _err adds is returning an error when the device pointer is null, and that's checked anyway. Also there is some intent to report errors, and that's what uclass_*_device_check() is for, use it. Signed-off-by:

[PATCH v6 02/20] dm: treewide: Do not opencode uclass_probe_all()

2022-10-12 Thread Michal Suchanek
We already have a function for probing all devices of a specific class, use it. Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- drivers/cpu/cpu-uclass.c | 20 drivers/virtio/virtio-uclass.c | 15 +-- test/dm/core.c | 17

[PATCH v6 01/20] dm: core: Fix uclass_probe_all to really probe all devices

2022-10-12 Thread Michal Suchanek
uclass_probe_all uses uclass_first_device/uclass_next_device assigning the return value. The interface for getting meaningful error is uclass_first_device_check/uclass_next_device_check, use it. Also do not stop iteration when an error is encountered. Probing all devices includes those that

[PATCH v6 03/20] dm: pci: Fix device PCI iteration

2022-10-12 Thread Michal Suchanek
When there is no PCI bus uclass_first_device will return no bus and no error which will result in pci_find_first_device calling skip_to_next_device with no bus, and the bus is only checked at the end of the while cycle, not the beginning. Fixes: 76c3fbcd3d ("dm: pci: Add a way to iterate through

Re: [PATCH v6 7/8] net: add MV88E61xx DSA driver

2022-10-12 Thread Vladimir Oltean
On Mon, Oct 10, 2022 at 09:39:43AM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E6xxx compatible Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by: Tim Harvey > Reviewed-by: Vladimir Oltean > Reviewed-by: Fabio Estevam > --- > v6: > - update commit msg

Re: [PATCH 2/3] clk: stm32mp13: introduce STM32MP13 RCC driver

2022-10-12 Thread Sean Anderson
On 10/12/22 08:33, Gabriel Fernandez wrote: Introduce STM32MP13 RCC driver using Common Clock Framework. Signed-off-by: Gabriel Fernandez --- drivers/clk/stm32/Kconfig | 15 + drivers/clk/stm32/Makefile |2 + drivers/clk/stm32/clk-stm32-core.c | 349 ++

[PATCH 2/2] spl: spl_legacy: Fix printing image name

2022-10-12 Thread Michal Suchanek
image_set_name does not terminate the name in the image header. Then is should not be assument it's nul terminated. image_print_contents correctly print only IH_NMLEN characters. Fix printing the unterminated field in spl_parse_legacy_header. The format specifies the minimum printed length, not

[PATCH 1/2] image: Suppress string truncation warning

2022-10-12 Thread Michal Suchanek
In file included from ../tools/imagetool.h:24, from ../tools/default_image.c:16: In function ‘image_set_name’, inlined from ‘image_set_header’ at ../tools/default_image.c:133:2: ../include/image.h:786:9: warning: ‘strncpy’ specified bound 32 equals destination size

Re: [PATCH] Nokia RX-51: Fix double space key press

2022-10-12 Thread Tom Rini
On Sun, Oct 09, 2022 at 09:38:25PM +0200, Pali Rohár wrote: > Space key is indicated by two different bits. Some HW models indicate press > of space key only by the first bit. Qemu indicates it by both bits at the > same time, which is currently interpreted by u-boot as double key press. > > Fix

Re: [PATCH] Nokia RX-51: Remove CONFIG_UBI_SIZE

2022-10-12 Thread Tom Rini
On Sun, Oct 09, 2022 at 03:12:09PM +0200, Pali Rohár wrote: > CONFIG_UBI_SIZE option is not used, so remove it. > > Signed-off-by: Pali Rohár Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] Fix typo in CONFIG_USBNET_DEVADDR

2022-10-12 Thread Tom Rini
On Sat, Oct 08, 2022 at 09:50:56AM -0500, nachopitt wrote: > From: Ignacio Zamora > > Fix typo that was causing the same feature to be > splitted into 2 different configuration options > > Replacing CONFIG_USBNET_DEVADDR with CONFIG_USBNET_DEV_ADDR > > Signed-off-by: Ignacio Zamora Applied

Re: [PATCH] tools: k3_gen_x509_cert: Do not print SWRV on build

2022-10-12 Thread Tom Rini
On Fri, Oct 07, 2022 at 03:35:31PM -0500, Andrew Davis wrote: > This matches the others here. > > Signed-off-by: Andrew Davis Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] smem: msm: add missing

2022-10-12 Thread Tom Rini
On Fri, Oct 07, 2022 at 11:52:44AM +0200, Robert Marko wrote: > MSM SMEM driver is currently missing header and throws > the following compile error: > > drivers/smem/msm_smem.c: In function ‘qcom_smem_get_ptable’: > drivers/smem/msm_smem.c:635:71: error: ‘SZ_4K’ undeclared (first use in this

Re: [PATCH 1/1] test: run setexpr test only on sandbox

2022-10-12 Thread Tom Rini
On Sat, Oct 01, 2022 at 09:42:35PM +0200, Heinrich Schuchardt wrote: > The test relies on memory being available at 0x0. This in not valid for > many boards. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH] firmware: scmi: fix the multi channel support with CCF

2022-10-12 Thread Tom Rini
On Fri, Sep 30, 2022 at 09:36:38AM +0200, Patrick Delaunay wrote: > When the CCF is activated, the dev->parent is not necessary > the reference to SCMI transport and the function devm_scmi_of_get_channel > failed for the registered SCMI clock, child for protocol@14, > the channel is null and the

Re: [PATCH 1/1] regmap: fix range checks

2022-10-12 Thread Tom Rini
On Thu, Sep 29, 2022 at 10:27:06PM +, Heinrich Schuchardt wrote: > On the 32bit ARM sandbox 'dm ut dm_test_devm_regmap' fails with an abort. > This is due to incorrect range checks. > > On 32-bit systems the size of size_t and int is both 32 bit. The expression > (offset + val_len) is bound

Re: [PATCH] cmd: ubi: Add 'ubi list' command for printing list of all UBI volumes

2022-10-12 Thread Tom Rini
On Mon, Sep 12, 2022 at 11:38:55AM +0200, Pali Rohár wrote: > To allow easily iterate over all UBI volumes, add a new command which > either print all user UBI volumes on output or set them into env variable. > > As UBI volumes can have arbitrary name/label, in most cases it is useful to >

Re: [PATCH v6 8/8] board: gw_ventana: enable MV88E6XXX DSA support

2022-10-12 Thread Vladimir Oltean
On Mon, Oct 10, 2022 at 09:39:44AM -0700, Tim Harvey wrote: > Add MV88E6XXX DSA support: > - update dt to provide internal MDIO bus and port handles. >U-Boot requires a more restrictive subset of the dt bindings >required by Linux for the sake of simplifying code > - update defconfig to

Re: [PATCH v6 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-10-12 Thread Vladimir Oltean
Hi Simon, On Mon, Oct 10, 2022 at 04:25:29PM -0600, Simon Glass wrote: > Hi Tim, > > On Mon, 10 Oct 2022 at 10:40, Tim Harvey wrote: > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > does not care to mangle a packet as in U-Boot only one network port is > >

Re: [PATCH] distro_bootcmd: Always check for custom boot scripts first

2022-10-12 Thread Vagrant Cascadian
On 2022-10-12, Tom Rini wrote: > On Fri, Sep 02, 2022 at 01:06:16AM +0300, Andrey Skvortsov wrote: >> If extlinux.conf is used, then it's not possible to customize boot >> environment, because scripts are not loaded. >> Usually it's possible to make some changes manually using command line >> and

[PATCH 1/1] powerpc: fix fdt_fixup_liodn_tbl_fman()

2022-10-12 Thread Heinrich Schuchardt
Builiding with GCC 12.2 fails: arch/powerpc/cpu/mpc85xx/liodn.c: In function 'fdt_fixup_liodn_tbl_fman': arch/powerpc/cpu/mpc85xx/liodn.c:340:35: error: the comparison will always evaluate as 'false' for the address of 'compat' will never be NULL [-Werror=address] 340 |

[PATCH 1/1] board: gateworks: gw_ventana: fix building with GCC 12.2

2022-10-12 Thread Heinrich Schuchardt
Building with GCC 12.2 results in an error board/gateworks/gw_ventana/gw_ventana.c:636:68: error: the comparison will always evaluate as 'true' for the address of 'pwm_padmux' will never be NULL [-Werror=address] 636 | } else if (hwconfig_subarg_cmp(arg, "mode",

Re: [PATCH] distro_bootcmd: Always check for custom boot scripts first

2022-10-12 Thread Tom Rini
On Fri, Sep 02, 2022 at 01:06:16AM +0300, Andrey Skvortsov wrote: > If extlinux.conf is used, then it's not possible to customize boot > environment, because scripts are not loaded. > Usually it's possible to make some changes manually using command line > and save boot environment. But if

Re: [PATCH 3/3] arm: dts: stm32mp13: add support of RCC driver

2022-10-12 Thread Patrick DELAUNAY
Hi, On 10/12/22 14:33, Gabriel Fernandez wrote: Adds support of Clock and Reset drivers for STM32MP13 platform. Signed-off-by: Gabriel Fernandez --- arch/arm/dts/stm32mp13-u-boot.dtsi | 4 + arch/arm/dts/stm32mp131.dtsi | 119 +++--

[PATCH 6/6] sunxi: add CherryPi-F1C200s support

2022-10-12 Thread Andre Przywara
The CherryPi F1C200s board is a small development board, featuring the F1C200s with 64MB of co-packaged DRAM. It comes with two USB-C sockets, of which one is connected to a USB-UART chip, that provides easy access to UART1. Beside the usual micro-SD card slot, the board comes with a SPI NAND

[PATCH 5/6] sunxi: f1c100: dtsi: add UART1 pins

2022-10-12 Thread Andre Przywara
The F1Cx00 SoCs connect the first PortA pins to UART1. Add this to the SoC .dtsi, so boards can reference UART1 pins. Signed-off-by: Andre Przywara --- arch/arm/dts/suniv-f1c100s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/suniv-f1c100s.dtsi

[PATCH 4/6] sunxi: f1c100: add UART1 support

2022-10-12 Thread Andre Przywara
Some boards use UART1 for its debug UART, so define the pins for the SPL and the pinmux name and mux value for U-Boot proper. Signed-off-by: Andre Przywara --- arch/arm/mach-sunxi/board.c | 4 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 1 + 2 files changed, 5 insertions(+) diff

[PATCH 3/6] sunxi: f1c100: move SKIP_LOWLEVEL_INIT_ONLY into Kconfig

2022-10-12 Thread Andre Przywara
So far we stated the lack of a lowlevel() init function for the F1C100s board by defining the respective SKIP_* symbol in the board's defconfig. However we don't expect any *board* to employ such low level code, so expect this to be never used for the ARMv5 Allwinner SoCs. Select the appropriate

[PATCH 2/6] sunxi: fix 32MB load address layout

2022-10-12 Thread Andre Przywara
The default load addresses for the various payloads (kernel, DT, ramdisk) on systems with just 32MB of DRAM have some issues: For a start the preceding comment doesn't match the actual values: apparently they were copied from the 64MB S3 layout, then halved, but since 0x5 is NOT the half of 0x10,

[PATCH 1/6] sunxi: Kconfig: introduce SUNXI_MINIMUM_DRAM_MB

2022-10-12 Thread Andre Przywara
Traditionally we assumed that every Allwinner board would come with at least 256 MB of DRAM, and set our DRAM layout accordingly. This affected both the default load addresses, but also U-Boot's own address expectations (like being loaded at 160 MB). Some SoCs come with co-packaged DRAM, but only

[PATCH 0/6] sunxi: improve F1C200s support

2022-10-12 Thread Andre Przywara
The Allwinner F1C200s is reportedly the same chip as the F1C100s, just with twice the amount of co-packaged DRAM: 64MB instead of just 32MB. U-Boot's F1C100 platform supported this quite naturally (since the DRAM size is auto-detected), but those better chips do not need to suffer from the same

Re: [PATCH] mkimage: fit: Fix signing of configs with external data

2022-10-12 Thread Sean Anderson
On 10/12/22 08:59, Simon Glass wrote: Hi Sean, On Tue, 11 Oct 2022 at 15:52, Sean Anderson wrote: Just like we exclude data-size, data-position, and data-offset from fit_config_check_sig, we must exclude them while signing as well. Fixes: 8edecd3110e ("fit: Fix verification of images with

Re: [PATCH 2/3] clk: stm32mp13: introduce STM32MP13 RCC driver

2022-10-12 Thread Patrick DELAUNAY
Hi Gabriel, On 10/12/22 14:33, Gabriel Fernandez wrote: Introduce STM32MP13 RCC driver using Common Clock Framework. Signed-off-by: Gabriel Fernandez --- drivers/clk/stm32/Kconfig | 15 + drivers/clk/stm32/Makefile |2 + drivers/clk/stm32/clk-stm32-core.c | 349

Re: [PATCH] image: fit: Fix not verifying data configuration

2022-10-12 Thread Sean Anderson
On 10/12/22 08:59, Simon Glass wrote: Hi Sean, On Tue, 11 Oct 2022 at 17:25, Sean Anderson wrote: When reading data from a FIT image, we must verify the configuration we get it from. This is because when we have a key with required = "conf", the image does not need any particular signature

Re: [PATCH] image: fit: Fix not verifying data configuration

2022-10-12 Thread Sean Anderson
On 10/12/22 08:59, Simon Glass wrote: Hi Sean, On Tue, 11 Oct 2022 at 17:25, Sean Anderson wrote: When reading data from a FIT image, we must verify the configuration we get it from. This is because when we have a key with required = "conf", the image does not need any particular signature

[PATCH] sunxi: defconfig: Add X96 Mate TV box

2022-10-12 Thread Andre Przywara
The X96 Mate TV box is a TV box with the Allwinner H616 SoC. It is available with up to 4GB of DRAM and 64GB eMMC. The DRAM chips require a different configuration when compared to the OrangePi Zero2, we must not use read/write training and write leveling. Add a defconfig for the box, so that we

Re: [PATCH 1/3] dt-bindings: stm32mp13: add clock & reset support for STM32MP13

2022-10-12 Thread Patrick DELAUNAY
Hi Gabriel, On 10/12/22 14:33, Gabriel Fernandez wrote: Add support of stm32mp13 DT bindings of clock and reset. Signed-off-by: Gabriel Fernandez --- MAINTAINERS | 2 + include/dt-bindings/clock/stm32mp13-clks.h | 229 +++

Re: [PATCH 2/3] timer-uclass: relocate ops pointers for CONFIG_NEEDS_MANUAL_RELOC

2022-10-12 Thread Ovidiu Panait
Hi Simon, On 10/12/22 15:59, Simon Glass wrote: On Tue, 11 Oct 2022 at 23:37, Ovidiu Panait wrote: Relocate timer_ops pointers when CONFIG_NEEDS_MANUAL_RELOC is enabled. The (gd->flags & GD_FLG_RELOC) check was added to make sure the reloc_done logic works for drivers that use

Re: [PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1

2022-10-12 Thread Tom Rini
On Wed, Oct 12, 2022 at 06:59:35AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 11 Oct 2022 at 10:22, Tom Rini wrote: > > > > On Mon, Oct 10, 2022 at 05:48:55PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 10 Oct 2022 at 09:18, Tom Rini wrote: > > > > > > > > Add a new flag to

Re: [PATCH 4/5] binman: Use an exit code when blobs are missing

2022-10-12 Thread Tom Rini
On Wed, Oct 12, 2022 at 06:59:21AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 11 Oct 2022 at 15:05, Tom Rini wrote: > > > > On Mon, Oct 10, 2022 at 04:25:36PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 10 Oct 2022 at 14:41, Tom Rini wrote: > > > > > > > > On Mon, Oct 10,

Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

2022-10-12 Thread Tom Rini
On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > > > > > From: Tien Fong Chee > > > > > > Using imply instead of select for CMD_FAT so overwritten is

Re: Bad Data CRC

2022-10-12 Thread momo aubin
Thanks Fabio and Simon, find attached the log picture. When I changed the size of the one partition in the kernel, I got this message. Does the calculation of CRC in uboot depended on the size ? [image: image.png] Thanks, Aubin On Wed, 12 Oct 2022 at 15:05, Fabio Estevam wrote: > On Mon, Oct

Re: Bad Data CRC

2022-10-12 Thread Fabio Estevam
On Mon, Oct 10, 2022 at 6:31 PM momo aubin wrote: > > Hello Simon, > > My board boots well . When I added the second partition into my kernel I > got this message > *Verifying Checksum ... Bad Data CRC* > what could be the root cause ? Try to run "saveenv",

Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

2022-10-12 Thread Simon Glass
Hi Tom, On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > > > From: Tien Fong Chee > > > > Using imply instead of select for CMD_FAT so overwritten is allowed in > > later configuration. > > > > Signed-off-by: Tien Fong Chee > >

Re: [RESEND PATCH 2/2] splash: get devpart from environment variable

2022-10-12 Thread Simon Glass
Hi Julien, On Wed, 12 Oct 2022 at 05:38, Julien Masson wrote: > > By default several types of splash locations are supported and the > user can select one of them through environment var (splashsource). > > However the devpart is still hardcoded and we cannot change it from > the environment. >

Re: [PATCH 1/3] timer-uclass: add timer_get_ops() macro

2022-10-12 Thread Simon Glass
On Tue, 11 Oct 2022 at 23:37, Ovidiu Panait wrote: > > Align timer uclass with the other subsystems and provide a timer_get_ops() > convenience macro. > > Using this instead of the generic device_get_ops() also prevents > -Wdiscarded-qualifiers warnings when used with non-const variables. > >

Re: [PATCH] image: fit: Fix not verifying data configuration

2022-10-12 Thread Simon Glass
Hi Sean, On Tue, 11 Oct 2022 at 17:25, Sean Anderson wrote: > > When reading data from a FIT image, we must verify the configuration we > get it from. This is because when we have a key with required = "conf", > the image does not need any particular signature or hash. The > configuration is the

[PATCH v2 1/1] riscv: support building double-float modules

2022-10-12 Thread Heinrich Schuchardt
The riscv32 toolchain for GCC-12 provided by kernel.org contains libgcc.a compiled for double-float. To link to it we have to adjust how we build U-Boot. As U-Boot actually does not use floating point at all this should not make a significant difference for the produced binaries. Signed-off-by:

Re: [PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1

2022-10-12 Thread Simon Glass
Hi Tom, On Tue, 11 Oct 2022 at 10:22, Tom Rini wrote: > > On Mon, Oct 10, 2022 at 05:48:55PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 10 Oct 2022 at 09:18, Tom Rini wrote: > > > > > > Add a new flag to buildman so that we will in turn pass > > > BINMAN_ALLOW_MISSING=1 to 'make'.

Re: [RESEND PATCH 1/2] splash: support raw image from MMC

2022-10-12 Thread Simon Glass
HI Julien, On Wed, 12 Oct 2022 at 05:38, Julien Masson wrote: > > The user has now the choice to specify the splash location in the MMC > as a raw storage. > > Signed-off-by: Julien Masson > --- > common/splash.c| 6 ++ > common/splash_source.c | 29 + >

Re: [PATCH] mkimage: fit: Fix signing of configs with external data

2022-10-12 Thread Simon Glass
Hi Sean, On Tue, 11 Oct 2022 at 15:52, Sean Anderson wrote: > > Just like we exclude data-size, data-position, and data-offset from > fit_config_check_sig, we must exclude them while signing as well. > > Fixes: 8edecd3110e ("fit: Fix verification of images with external data") > Fixes:

Re: [PATCH 2/3] timer-uclass: relocate ops pointers for CONFIG_NEEDS_MANUAL_RELOC

2022-10-12 Thread Simon Glass
On Tue, 11 Oct 2022 at 23:37, Ovidiu Panait wrote: > > Relocate timer_ops pointers when CONFIG_NEEDS_MANUAL_RELOC is enabled. > > The (gd->flags & GD_FLG_RELOC) check was added to make sure the reloc_done > logic works for drivers that use DM_FLAG_PRE_RELOC. > > Signed-off-by: Ovidiu Panait >

Re: Bad Data CRC

2022-10-12 Thread Simon Glass
Hi Momo, On Tue, 11 Oct 2022 at 00:13, momo aubin wrote: > > Hi Simon > > > On 11 Oct 2022, at 12:33 AM, Simon Glass wrote: > > > > Hi Momo, > > > >> On Mon, 10 Oct 2022 at 15:31, momo aubin wrote: > >> > >> Hello Simon, > >> > >> My board boots well . When I added the second partition into

Re: [PATCH 4/5] binman: Use an exit code when blobs are missing

2022-10-12 Thread Simon Glass
Hi Tom, On Tue, 11 Oct 2022 at 15:05, Tom Rini wrote: > > On Mon, Oct 10, 2022 at 04:25:36PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 10 Oct 2022 at 14:41, Tom Rini wrote: > > > > > > On Mon, Oct 10, 2022 at 02:00:31PM -0600, Simon Glass wrote: > > > > > > > At present binman

Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

2022-10-12 Thread Tom Rini
On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > From: Tien Fong Chee > > Using imply instead of select for CMD_FAT so overwritten is allowed in > later configuration. > > Signed-off-by: Tien Fong Chee > --- > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] avb: Extend support to non-eMMC interfaces

2022-10-12 Thread Mattijs Korpershoek
On mar., oct. 11, 2022 at 13:40, Alistair Delva wrote: > On Mon, Oct 10, 2022 at 7:53 AM Mattijs Korpershoek > wrote: >> >> Hi Alistair, >> >> Thank you for your patch. >> >> On lun., sept. 26, 2022 at 22:02, Alistair Delva wrote: >> >> > From: Jiyong Park >> > >> > Previously Android AVB

[PATCH 2/3] clk: stm32mp13: introduce STM32MP13 RCC driver

2022-10-12 Thread Gabriel Fernandez
Introduce STM32MP13 RCC driver using Common Clock Framework. Signed-off-by: Gabriel Fernandez --- drivers/clk/stm32/Kconfig | 15 + drivers/clk/stm32/Makefile |2 + drivers/clk/stm32/clk-stm32-core.c | 349 ++ drivers/clk/stm32/clk-stm32-core.h | 154 +++

[PATCH 3/3] arm: dts: stm32mp13: add support of RCC driver

2022-10-12 Thread Gabriel Fernandez
Adds support of Clock and Reset drivers for STM32MP13 platform. Signed-off-by: Gabriel Fernandez --- arch/arm/dts/stm32mp13-u-boot.dtsi | 4 + arch/arm/dts/stm32mp131.dtsi | 119 +++-- arch/arm/dts/stm32mp133.dtsi | 4 +- arch/arm/dts/stm32mp13xf.dtsi

[PATCH 1/3] dt-bindings: stm32mp13: add clock & reset support for STM32MP13

2022-10-12 Thread Gabriel Fernandez
Add support of stm32mp13 DT bindings of clock and reset. Signed-off-by: Gabriel Fernandez --- MAINTAINERS | 2 + include/dt-bindings/clock/stm32mp13-clks.h | 229 +++ include/dt-bindings/reset/stm32mp13-resets.h | 100 3 files

[PATCH 0/3] Introduce STM32MP13 RCC driver

2022-10-12 Thread Gabriel Fernandez
This serie adds support of clock and reset for STM32MP13. Gabriel Fernandez (3): dt-bindings: stm32mp13: add clock & reset support for STM32MP13 clk: stm32mp13: introduce STM32MP13 RCC driver arm: dts: stm32mp13: add support of RCC driver MAINTAINERS |

Re: [u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-12 Thread Adam Ford
On Wed, Oct 12, 2022 at 6:57 AM Ladislav Michl wrote: > > Hi Adam, > > On Wed, Oct 12, 2022 at 06:42:22AM -0500, Adam Ford wrote: > [snip] > > On my board the GPMC runs more than just NAND. I am hoping to get the > > GPMC driver working in U-Boot first then in SPL (assuming it fits). I > > have

Re: [u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-12 Thread Ladislav Michl
Hi Adam, On Wed, Oct 12, 2022 at 06:42:22AM -0500, Adam Ford wrote: [snip] > On my board the GPMC runs more than just NAND. I am hoping to get the > GPMC driver working in U-Boot first then in SPL (assuming it fits). I > have LTO enabled on my DM3730, so I am hoping it might help make some >

Re: [u-boot][PATCH 02/14] mtd: rawnand: omap_gpmc: Enable build for K2/K3 platforms

2022-10-12 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > The GPMC module is present on some K2 and K3 SoCs. > Enable building GPMC NAND driver for K2/K3 platforms. > > Signed-off-by: Roger Quadros > --- > drivers/mtd/nand/raw/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-12 Thread Adam Ford
On Wed, Oct 12, 2022 at 1:22 AM Roger Quadros wrote: > > Hi Adam, > > On 11/10/2022 18:01, Adam Ford wrote: > > On Tue, Oct 11, 2022 at 6:52 AM Roger Quadros wrote: > >> > >> Adds driver model support. > >> > >> We need to be able to self initialize the NAND controller/chip > >> at probe and so

[RESEND PATCH 2/2] splash: get devpart from environment variable

2022-10-12 Thread Julien Masson
By default several types of splash locations are supported and the user can select one of them through environment var (splashsource). However the devpart is still hardcoded and we cannot change it from the environment. This patch add the support of "splashdevpart" which allow the user to set

[RESEND PATCH 1/2] splash: support raw image from MMC

2022-10-12 Thread Julien Masson
The user has now the choice to specify the splash location in the MMC as a raw storage. Signed-off-by: Julien Masson --- common/splash.c| 6 ++ common/splash_source.c | 29 + 2 files changed, 35 insertions(+) diff --git a/common/splash.c

[RESEND PATCH 0/2] splash: add more options/support

2022-10-12 Thread Julien Masson
This patch series add several options/support for splashscreen feature: - support raw image from MMC - get devpart from environment variable With these changes the user has now more options and can change default configurations through environment variables. Example: image located in

RE: [PATCH 1/3] mmc: zynq_sdhci: Change node_id prototype to u32

2022-10-12 Thread Soma, Ashok Reddy
Hi Jaehoon, > -Original Message- > From: 정재훈 > Sent: Wednesday, October 12, 2022 3:09 PM > To: Soma, Ashok Reddy ; 'Jaehoon Chung' > ; u-boot@lists.denx.de > Cc: Simek, Michal ; peng@nxp.com; Halder, > Ayan Kumar ; Mehta, Piyush > ; lakshmi.sai.krishna.potth...@amd.com; >

Re: [u-boot][PATCH 01/14] mtd: rawnand: omap_gpmc: Deprecate asm/arch/mem.h

2022-10-12 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > We want to get rid of so don't > enforce it for new platforms. > > This also means GPMC_MAX CS doesn't have to be defined > by platform code. > > Define it locally here for now. > > Signed-off-by: Roger Quadros > --- >

  1   2   >