Re: [PATCH v2 2/2] tools: mkimage: add new image type "flat_dt_legacy"

2022-11-16 Thread Sean Anderson
On 11/16/22 05:49, Marc Kleine-Budde wrote: On 31.10.2022 15:51:21, Marc Kleine-Budde wrote: If the user select the image type "flat_dt" a FIT image will be build. This breaks the legacy use case of putting a Flat Device Tree into a legacy u-boot image. Add a new image type "flat_dt_legacy" to

Re: USB Device buffer overflow

2022-11-16 Thread Fabio Estevam
Hi Szymon, [Adding Marek] On Wed, Nov 16, 2022 at 8:56 PM Szymon Heidrich wrote: > > Hello, > > Similar to CVE-2021-39685 affecting the Linux kernel U-Boot is vulnerable to > a buffer overflow > present in the USB Gadget stack. Handling of a control transfer request with > wLength larger than

Re: USB Device buffer overflow

2022-11-16 Thread Sultan Khan
Hello Szymon, Looks like a generalization of CVE-2022-2347 I found earlier. While both I and Venkatesh Yadav Abbarapu of AMD made patches for that CVE localized to DFU, given the presence of the same problematic pattern elsewhere, the bounds check aspect of that CVE fix would perhaps be better

Re: [PATCH 0/6] broken CVE fix (b85d130ea0ca)

2022-11-16 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 10:04 AM Tom Rini wrote: > > On Mon, Nov 14, 2022 at 10:35:51AM +0100, Rasmus Villemoes wrote: > > On 14/10/2022 19.43, Rasmus Villemoes wrote: > > > tl;dr: b85d130ea0ca didn't fix the CVE(s), but did break tftp of > > > certain file sizes - which is somewhat lucky, since t

Re: U-Boot SPL not getting generated

2022-11-16 Thread Venkatakrishnan S ic11539
Hi, I am trying to generate u-boot spl for a custom processor based out of risc-v arch. I have done the defconfig for u-boot proper and is working now. I am able to use that alone with opensbi. I am trying to generate u-boot spl for the same board and I am not able to generate it despite adding th

USB Device buffer overflow

2022-11-16 Thread Szymon Heidrich
Hello, Similar to CVE-2021-39685 affecting the Linux kernel U-Boot is vulnerable to a buffer overflow present in the USB Gadget stack. Handling of a control transfer request with wLength larger than USB_BUFSIZ (4096) may result in a buffer overflow. The buffer for USB control endpoint is alloca

Re: [PATCH 07/17] Remove unused symbols

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:11, Tom Rini wrote: > > This commit removes the following unused symbols: >CONFIG_SYS_NVRAM_BASE_ADDR >CONFIG_SYS_NVRAM_SIZE >CONFIG_SYS_PAXE_BASE >CONFIG_SYS_PCCNT >CONFIG_SYS_PCDAT >CONFIG_SYS_PCDDR >CONFIG_SYS_PCI1_ADDR >CONFIG_SYS_PCI2_

Re: [PATCH 02/17] powerpc: Rename CONFIG_NS16550_MIN_FUNCTIONS

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:10, Tom Rini wrote: > > This symbol is specific to the PowerPC SPL implementation, so rename > this to reflect that it's in SPL and used / tested there, so that we can > then safely migrate it to Kconfig. > > Signed-off-by: Tom Rini > --- > README

Re: [PATCH 06/17] rtc: Remove unused drivers

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:11, Tom Rini wrote: > > These RTC drivers are currently unused and reference other unused CONFIG > variables, so remove them. > > Signed-off-by: Tom Rini > --- > README | 1 - > drivers/rtc/Makefile | 3 - > drivers/rtc/ds1556.c | 179 -

Re: [PATCH 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:14, Tom Rini wrote: > > This converts the following to Kconfig: >CONFIG_SPL_NS16550_MIN_FUNCTIONS >CONFIG_SYS_NS16550_MEM32 >CONFIG_SYS_NS16550_PORT_MAPPED >CONFIG_SYS_NS16550_REG_SIZE >CONFIG_SYS_NS16550_SERIAL > > Signed-off-by: Tom Rini > --- > RE

Re: [PATCH 01/17] global: Move remaining CONFIG_SYS_NOR_* to CFG_SYS_NOR_*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:11, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NOR > namespace do not easily transition to Kconfig. In many cases they likely > should come from the device tree instead. Move these out of CONFIG > namespace and in to CFG namespace. > >

Re: [PATCH 09/17] global: Move remaining CONFIG_SYS_PCI* to CFG_SYS_PCI*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:12, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_PCI and > CONFIG_SYS_PCIE namespace do not easily transition to Kconfig. In many > cases they likely should come from the device tree instead. Move these > out of CONFIG namespace and in t

Re: [PATCH 08/17] Convert CONFIG_SYS_OMAP_ABE_SYSCK to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:11, Tom Rini wrote: > > This converts the following to Kconfig: >CONFIG_SYS_OMAP_ABE_SYSCK > > Signed-off-by: Tom Rini > --- > arch/arm/mach-omap2/Kconfig | 3 +++ > arch/arm/mach-omap2/omap5/Kconfig | 1 + > include/configs/am57xx_evm.h | 2 -- > include

Re: [PATCH 17/17] global: Move remaining CONFIG_SYS_* to CFG_SYS_*

2022-11-16 Thread Simon Glass
Reviewed-by: Simon Glass

Re: [PATCH 16/17] global: Move remaining CONFIG_*SRIO_* to CFG_*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:13, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the SRIO namespace do not > easily transition to Kconfig. In many cases they likely should come from > the device tree instead. Move these out of CONFIG namespace and in to > CFG namespace. > > Signed-of

Re: [PATCH 15/17] Convert CONFIG_SYS_SRIO et al to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:13, Tom Rini wrote: > > This converts the following to Kconfig: >CONFIG_SRIO1 >CONFIG_SRIO2 >CONFIG_SRIO_PCIE_BOOT_MASTER >CONFIG_SYS_SRIO > > Signed-off-by: Tom Rini > --- > README| 12 > arch/powerpc/Kco

Re: [PATCH 14/17] Convert CONFIG_SYS_TIMER_COUNTS_DOWN to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:12, Tom Rini wrote: > > This converts the following to Kconfig: >CONFIG_SYS_TIMER_COUNTS_DOWN > > Signed-off-by: Tom Rini > --- > arch/arm/mach-kirkwood/include/mach/config.h | 1 - > arch/sh/include/asm/config.h | 1 - > configs/alt_defconfig

Re: [PATCH 11/17] spl: Migrate SYS_SATA_FAT_BOOT_PARTITION to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:12, Tom Rini wrote: > > This moves SYS_SATA_FAT_BOOT_PARTITION to Kconfig and enforces the > current default via Kconfig rather than C code. > > Signed-off-by: Tom Rini > --- > common/spl/Kconfig | 5 + > common/spl/spl_sata.c | 4 > include/config

Re: [PATCH 13/17] global: Move remaining CONFIG_SYS_SDRAM_* to CFG_SYS_SDRAM_*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:14, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_SDRAM > namespace do not easily transition to Kconfig. In many cases they likely > should come from the device tree instead. Move these out of CONFIG > namespace and in to CFG namespace. >

Re: [PATCH 12/17] imx6/imx7: Remove now empty imx6_spl.h and imx7_spl.h

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:12, Tom Rini wrote: > > There are now no flags being set in these files, so remove them. > > Signed-off-by: Tom Rini > --- > include/configs/apalis_imx6.h| 4 > include/configs/brppt2.h | 5 - > include/configs/cl-som-imx7.h

Re: [PATCH 10/17] Convert CONFIG_SYS_PMAN et al to Kconfig

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:12, Tom Rini wrote: > > This converts the following to Kconfig: >CONFIG_NOBQFMAN >CONFIG_SYS_DPAA_DCE >CONFIG_SYS_DPAA_FMAN >CONFIG_SYS_DPAA_PME >CONFIG_SYS_DPAA_RMAN >CONFIG_SYS_PMAN > > Signed-off-by: Tom Rini > --- > arch/Kconfig.nxp

Re: [PATCH 05/17] global: Move remaining CONFIG_SYS_NUM_* to CFG_SYS_NUM_*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:11, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NUM > namespace do not easily transition to Kconfig. In many cases they likely > should come from the device tree instead. Move these out of CONFIG > namespace and in to CFG namespace. > >

Re: [PATCH 04/17] global: Move remaining CONFIG_SYS_NS16550_* to CFG_SYS_NS16550_*

2022-11-16 Thread Simon Glass
On Wed, 16 Nov 2022 at 11:13, Tom Rini wrote: > > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NS16550 > namespace do not easily transition to Kconfig. In many cases they likely > should come from the device tree instead. Move these out of CONFIG > namespace and in to CFG namespace.

Re: [PATCH 1/1] doc: add man-page for cmp command

2022-11-16 Thread Simon Glass
Hi Heinrich, On Wed, 16 Nov 2022 at 00:07, Heinrich Schuchardt wrote: > > Provide a man-page for the cmp command. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/cmd/cmp.rst | 105 ++ > doc/usage/index.rst | 1 + > 2 files changed, 106 insert

Re: [PATCH v2 1/2] tools: mkimage: don't print error message "Success" in case of failure

2022-11-16 Thread Simon Glass
+Tom Rini Hi Marc, On Wed, 16 Nov 2022 at 03:42, Marc Kleine-Budde wrote: > > On 31.10.2022 13:27:10, Simon Glass wrote: > > On Mon, 31 Oct 2022 at 08:51, Marc Kleine-Budde wrote: > > > > > > In case there's no struct image_type_params::set_header callback, no > > > "errno" will be set. Don't f

[PATCH 03/17] Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig

2022-11-16 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SPL_NS16550_MIN_FUNCTIONS CONFIG_SYS_NS16550_MEM32 CONFIG_SYS_NS16550_PORT_MAPPED CONFIG_SYS_NS16550_REG_SIZE CONFIG_SYS_NS16550_SERIAL Signed-off-by: Tom Rini --- README| 7 --- arch/arm/inclu

[PATCH 15/17] Convert CONFIG_SYS_SRIO et al to Kconfig

2022-11-16 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SRIO1 CONFIG_SRIO2 CONFIG_SRIO_PCIE_BOOT_MASTER CONFIG_SYS_SRIO Signed-off-by: Tom Rini --- README| 12 arch/powerpc/Kconfig | 15 +++ configs/MPC8548CDS_3

[PATCH 04/17] global: Move remaining CONFIG_SYS_NS16550_* to CFG_SYS_NS16550_*

2022-11-16 Thread Tom Rini
The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NS16550 namespace do not easily transition to Kconfig. In many cases they likely should come from the device tree instead. Move these out of CONFIG namespace and in to CFG namespace. Signed-off-by: Tom Rini --- arch/arm/cpu/armv7/ls102x

[PATCH 16/17] global: Move remaining CONFIG_*SRIO_* to CFG_*

2022-11-16 Thread Tom Rini
The rest of the unmigrated CONFIG symbols in the SRIO namespace do not easily transition to Kconfig. In many cases they likely should come from the device tree instead. Move these out of CONFIG namespace and in to CFG namespace. Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc8xxx/law.c

[PATCH 09/17] global: Move remaining CONFIG_SYS_PCI* to CFG_SYS_PCI*

2022-11-16 Thread Tom Rini
The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_PCI and CONFIG_SYS_PCIE namespace do not easily transition to Kconfig. In many cases they likely should come from the device tree instead. Move these out of CONFIG namespace and in to CFG namespace. Signed-off-by: Tom Rini --- arch/arm/

[PATCH 12/17] imx6/imx7: Remove now empty imx6_spl.h and imx7_spl.h

2022-11-16 Thread Tom Rini
There are now no flags being set in these files, so remove them. Signed-off-by: Tom Rini --- include/configs/apalis_imx6.h| 4 include/configs/brppt2.h | 5 - include/configs/cl-som-imx7.h| 3 --- include/configs/cm_fx6.h | 3 -

[PATCH 14/17] Convert CONFIG_SYS_TIMER_COUNTS_DOWN to Kconfig

2022-11-16 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_TIMER_COUNTS_DOWN Signed-off-by: Tom Rini --- arch/arm/mach-kirkwood/include/mach/config.h | 1 - arch/sh/include/asm/config.h | 1 - configs/alt_defconfig| 1 + configs/bitmain_antminer_s9_defconfig

[PATCH 11/17] spl: Migrate SYS_SATA_FAT_BOOT_PARTITION to Kconfig

2022-11-16 Thread Tom Rini
This moves SYS_SATA_FAT_BOOT_PARTITION to Kconfig and enforces the current default via Kconfig rather than C code. Signed-off-by: Tom Rini --- common/spl/Kconfig | 5 + common/spl/spl_sata.c | 4 include/configs/imx6_spl.h | 5 - 3 files changed, 5 insertions(+), 9 dele

[PATCH 10/17] Convert CONFIG_SYS_PMAN et al to Kconfig

2022-11-16 Thread Tom Rini
This converts the following to Kconfig: CONFIG_NOBQFMAN CONFIG_SYS_DPAA_DCE CONFIG_SYS_DPAA_FMAN CONFIG_SYS_DPAA_PME CONFIG_SYS_DPAA_RMAN CONFIG_SYS_PMAN Signed-off-by: Tom Rini --- arch/Kconfig.nxp | 3 ++ arch/arm/cpu/armv8/fsl-layerscape/Kconfig

[PATCH 05/17] global: Move remaining CONFIG_SYS_NUM_* to CFG_SYS_NUM_*

2022-11-16 Thread Tom Rini
The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NUM namespace do not easily transition to Kconfig. In many cases they likely should come from the device tree instead. Move these out of CONFIG namespace and in to CFG namespace. Signed-off-by: Tom Rini --- README

[PATCH 07/17] Remove unused symbols

2022-11-16 Thread Tom Rini
This commit removes the following unused symbols: CONFIG_SYS_NVRAM_BASE_ADDR CONFIG_SYS_NVRAM_SIZE CONFIG_SYS_PAXE_BASE CONFIG_SYS_PCCNT CONFIG_SYS_PCDAT CONFIG_SYS_PCDDR CONFIG_SYS_PCI1_ADDR CONFIG_SYS_PCI2_ADDR CONFIG_SYS_PCI1_IO_BUS CONFIG_SYS_PCI1_IO_SIZE CONFIG

[PATCH 08/17] Convert CONFIG_SYS_OMAP_ABE_SYSCK to Kconfig

2022-11-16 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_OMAP_ABE_SYSCK Signed-off-by: Tom Rini --- arch/arm/mach-omap2/Kconfig | 3 +++ arch/arm/mach-omap2/omap5/Kconfig | 1 + include/configs/am57xx_evm.h | 2 -- include/configs/dra7xx_evm.h | 2 -- 4 files changed, 4 insertions(+

[PATCH 06/17] rtc: Remove unused drivers

2022-11-16 Thread Tom Rini
These RTC drivers are currently unused and reference other unused CONFIG variables, so remove them. Signed-off-by: Tom Rini --- README | 1 - drivers/rtc/Makefile | 3 - drivers/rtc/ds1556.c | 179 --- drivers/rtc/ds164x.c | 171 -

[PATCH 01/17] global: Move remaining CONFIG_SYS_NOR_* to CFG_SYS_NOR_*

2022-11-16 Thread Tom Rini
The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NOR namespace do not easily transition to Kconfig. In many cases they likely should come from the device tree instead. Move these out of CONFIG namespace and in to CFG namespace. Signed-off-by: Tom Rini --- board/freescale/ls1043aqds/ls

[PATCH 02/17] powerpc: Rename CONFIG_NS16550_MIN_FUNCTIONS

2022-11-16 Thread Tom Rini
This symbol is specific to the PowerPC SPL implementation, so rename this to reflect that it's in SPL and used / tested there, so that we can then safely migrate it to Kconfig. Signed-off-by: Tom Rini --- README | 2 +- drivers/serial/ns16550.c| 8 drive

Re: Pull request for efi-2023-01-rc2

2022-11-16 Thread Tom Rini
On Wed, Nov 16, 2022 at 11:13:38AM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit c4ee4fe92e9be120be6d12718273dec6b63cc7d9: > > Merge tag 'u-boot-imx-20221114' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-11-14 09:33:36 > -0500) > > are

Re: [PULL] u-boot-riscv/master

2022-11-16 Thread Tom Rini
On Wed, Nov 16, 2022 at 06:16:25AM +, Leo Liang wrote: > Hi Tom, > > The following changes since commit c4ee4fe92e9be120be6d12718273dec6b63cc7d9: > > Merge tag 'u-boot-imx-20221114' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-11-14 09:33:36 > -0500) > > are available

Re: [PATCH 01/11] imx: implement get_effective_memsize

2022-11-16 Thread Peng Fan
Hi Stefan, On 11/16/2022 2:03 PM, Stefan Roese wrote: Hi Peng, please find one late comment from me below... On 16.11.22 03:43, Peng Fan wrote: +Tom On 11/9/2022 3:40 PM, Pali Rohár wrote: On Wednesday 09 November 2022 09:48:53 Peng Fan wrote: On 11/8/2022 4:03 PM, Pali Rohár wrote: On T

[PATCH] qspi: versal-net: Add condition for tapdelay register

2022-11-16 Thread Michal Simek
From: Ashok Reddy Soma Add CONFIG_ARCH_VERSAL_NET to select tapdelay register for versal-net. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal Simek --- drivers/spi/zynqmp_gqspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/

[PATCH] soc: xilinx: versal-net: Add soc_xilinx_versal_net driver

2022-11-16 Thread Michal Simek
Add soc_xilinx_versal_net driver to identify the family & revision of versal-net SoC. Add Kconfig option CONFIG_SOC_XILINX_VERSAL_NET to enable/disable this driver. To enable this driver by default, add this config to xilinx_versal_net_virt_defconfig file. This driver will be probed using platdata

[PATCH] xilinx: versal-net: Disable LMB for mini configuration

2022-11-16 Thread Michal Simek
There is no reason to have LMB enabled on mini configuration because it is only consuming space that's why disable it. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_mini_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_versal_net_mini_defconfig b/configs

[PATCH 3/3] arm64: versal: Add octal spi flash mini u-boot configuration

2022-11-16 Thread Ashok Reddy Soma
Add configuration file for mini u-boot configuration which runs on a smaller footprint from on chip memory(OCM). This configuration has required CONFIG's enabled to support octal spi flash and uses DCC terminal for console output. Add required dts for octal spi flash mini u-boot configuration. Sig

[PATCH 2/3] spi: cadence-qspi: Fix compilation error in mini u-boot flash reset

2022-11-16 Thread Ashok Reddy Soma
When cadence_qspi_versal_flash_reset() function is called in mini u-boot where there is no firmware support, it is missing defines for macro's BOOT_MODE_POR_0 & BOOT_MODE_POR_1. Remove them and replace with already define macro's which have same values as these. Signed-off-by: Ashok Reddy Soma --

[PATCH 1/3] arm64: versal: Add qspi flash mini u-boot configuration

2022-11-16 Thread Ashok Reddy Soma
Add configuration file for mini u-boot configuration which runs on a smaller footprint from on chip memory(OCM). This configuration has required CONFIG's enabled to support qspi flash and uses DCC terminal for console output. Add required dts files for qspi mini configuration. Signed-off-by: Ashok

[PATCH 0/3] Add quad & octal spi flash mini u-boot configuration files

2022-11-16 Thread Ashok Reddy Soma
Add new configuration files and device trees for quad and octal spi flash mini u-boot. With these configs's mini u-boot will run from on chip memory(OCM) and uses DCC terminal for console output. Changes in v3: - Added dts files for qspi mini configuration - Added CONFIG_HAS_CUSTOM_SYS_INIT_SP_A

Re: [PATCH v3 3/4] arm_ffa: introduce Arm FF-A low-level driver

2022-11-16 Thread Abdellatif El Khlifi
On Tue, Nov 15, 2022 at 08:24:24AM -0700, Simon Glass wrote: > Hi, > > On Mon, 1 Aug 2022 at 11:21, Abdellatif El Khlifi > wrote: > > > > Add the driver implementing Arm Firmware Framework for Armv8-A v1.0 > > > > The Firmware Framework for Arm A-profile processors (FF-A) > > describes interfaces

Boot Loader Specification (UAPI Group)

2022-11-16 Thread Sebastian Veit
Dear devs of U-Boot, I'd like to know if there's already a work in progress on the support of the "fairly new" Boot Loader Specification [1]. Summary of the new spec: Defines a set of file formats and naming conventions to allow distribution independent boot loader menus supportable by multiple b

[PATCH] arm64: zynqmp: Describe TI phy as ethernet-phy-id with reset on zcu106

2022-11-16 Thread Michal Simek
zcu106 also connects ethernet phy reset via tca6416 chip as is done on other evaluation boards. That's why describe this connection to make sure that ethernet phy is reset before it's use. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-zcu106-revA.dts | 19 +-- 1 file chang

Re: [PATCH v2 2/2] tools: mkimage: add new image type "flat_dt_legacy"

2022-11-16 Thread Marc Kleine-Budde
On 31.10.2022 15:51:21, Marc Kleine-Budde wrote: > If the user select the image type "flat_dt" a FIT image will be build. > This breaks the legacy use case of putting a Flat Device Tree into a > legacy u-boot image. > > Add a new image type "flat_dt_legacy" to build a legacy u-boot image > with a

Re: [PATCH v2 1/2] tools: mkimage: don't print error message "Success" in case of failure

2022-11-16 Thread Marc Kleine-Budde
On 31.10.2022 13:27:10, Simon Glass wrote: > On Mon, 31 Oct 2022 at 08:51, Marc Kleine-Budde wrote: > > > > In case there's no struct image_type_params::set_header callback, no > > "errno" will be set. Don't fail with an error message, followed by > > "Success". Remove the printing of the human re

[PATCH v9 5/5] eficonfig: add "Show Signature Database" menu entry

2022-11-16 Thread Masahisa Kojima
This commit adds the menu-driven interface to show the signature list content. Signed-off-by: Masahisa Kojima --- No update since v7 Changes in v7: - remove delete signature list feature user can clear the signature database with signed null key - rename function name to avoid confusion - upda

[PATCH v9 4/5] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-11-16 Thread Masahisa Kojima
This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll PK, KEK, db and dbx by selecting file. Only the signed EFI Signature List(s) with an authenticated header, typically '.auth' file, is accepted. To clear the PK, KEK, db and dbx, user needs to enroll the nul

[PATCH v9 3/5] eficonfig: refactor change boot order implementation

2022-11-16 Thread Masahisa Kojima
All the eficonfig menus other than "Change Boot Order" use 'eficonfig_entry' structure for each menu entry. This commit refactors change boot order implementation to use 'eficonfig_entry' structure same as other menus to have consistent menu handling. This commit also simplifies the data->active h

[PATCH v9 2/5] eficonfig: expose append entry function

2022-11-16 Thread Masahisa Kojima
Following commits are adding support for UEFI variable management via the eficonfig menu. Those functions needs to use append_entry() and append_quit_entry() to construct the menu, so move them out of their static declarations. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- No

[PATCH v9 1/5] eficonfig: refactor file selection handling

2022-11-16 Thread Masahisa Kojima
eficonfig_select_file_handler() is commonly used to select the file. eficonfig_display_select_file_option() adds an additional menu to clear the selected file. eficonfig_display_select_file_option() is not always necessary for the file selection process, so it must be outside of eficonfig_select_fi

[PATCH v9 0/5] eficonfig: add UEFI Secure Boot key maintenance interface

2022-11-16 Thread Masahisa Kojima
This series adds the UEFI Secure Boot key maintenance interface to the eficonfig command. User can enroll PK, KEK, db and dbx. Source code can be cloned with: $ git clone https://git.linaro.org/people/masahisa.kojima/u-boot.git -b kojima/eficonfig_sbkey_v9 Masahisa Kojima (5): eficonfig: refac

Pull request for efi-2023-01-rc2

2022-11-16 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit c4ee4fe92e9be120be6d12718273dec6b63cc7d9: Merge tag 'u-boot-imx-20221114' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-11-14 09:33:36 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-

Re: [PATCH] Revert "imx: imx8: apalis: switch to binman"

2022-11-16 Thread Stefano Babic
On 16.11.22 09:25, Marcel Ziswiler wrote: On Tue, 2022-11-15 at 11:49 +0100, Stefano Babic wrote: This reverts commit b8072ae848b73e89a73ba5b535324e4dc2793f37. Thanks Stefano. This way at least no completely defunct flash.bin gets generated. Sorry for that - patch slip in, I was aware it s

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-16 Thread Marcel Ziswiler
Hi guys On Fri, 2022-11-11 at 14:55 -0300, Fabio Estevam wrote: > On Fri, Nov 11, 2022 at 2:40 PM Fabio Estevam wrote: > > > I removed SPL support, which does not seems to be needed as the scufw > > handles DDR init. > > > > I don't have access to an imx8qm/qxp board here. > > > > Could you tr

Re: [PATCH] Revert "imx: imx8: apalis: switch to binman"

2022-11-16 Thread Marcel Ziswiler
On Tue, 2022-11-15 at 11:49 +0100, Stefano Babic wrote: > This reverts commit b8072ae848b73e89a73ba5b535324e4dc2793f37. Thanks Stefano. This way at least no completely defunct flash.bin gets generated. As I do have further doubts about the whole topic I will continue on the discussion where the