Re: [PATCH] xilinx: zynqmp: Fix SPL_FS_LOAD_PAYLOAD_NAME usage

2022-12-04 Thread Michal Simek
On 12/2/22 14:06, Michal Simek wrote: SPL_FS_LOAD_PAYLOAD_NAME depends on SPL to be enabled. If SPL is not enabled code still expects SPL_FS_LOAD_PAYLOAD_NAME to be present. That's why setup proper dependency in the code. And by doing so also change the logic around dfu_alt_info string composi

Re: [PATCH] arm64: versal-net: Enable defconfig for Micron octal flashes

2022-12-04 Thread Michal Simek
On 11/29/22 11:18, Michal Simek wrote: From: Ashok Reddy Soma Micron mt35 series octal flashes are under config option CONFIG_SPI_FLASH_MT35XU. Enable it in default defconfig for octal flashes to be detected. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal Simek --- configs/xilin

Re: [PATCH] spi: cadence-qspi: Remove condition for calling enable linear mode

2022-12-04 Thread Michal Simek
On 11/29/22 12:41, Ashok Reddy Soma wrote: cadence_qspi_apb_enable_linear_mode() has a weak function defined, so no need to gaurd this under if (CONFIG_IS_ENABLED(ARCH_VERSAL)). In cadence_qspi_apb_write_execute(), enable linear mode is called twice by mistake, remove extra one. Signed-off-b

Re: [PATCH] ARM: zynq: Add missing twd timer for mini configurations

2022-12-04 Thread Michal Simek
On 11/29/22 13:23, Michal Simek wrote: The commit b7e0750d8872 ("zynq: Convert arm twd timer to DM driver") switched timer to DM but missing to add nodes to all mini configurations. Based on it missing timer end up in non functional system where any delay doesn't work. Signed-off-by: Michal S

Re: [PATCH] arm64: zynqmp: Do not enable IPI by default

2022-12-04 Thread Michal Simek
On 11/29/22 16:09, Michal Simek wrote: ZynqMP mini configurations are not using IPI driver and enabling this is adding additional ~1200 Bytes (depends on configuration). This ends up in situation that there is no enough space in OCM for relocation that's why disable this driver for all mini co

Re: [PATCH] arm64: zynqmp: Do not include psu_init to U-Boot by default

2022-12-04 Thread Michal Simek
On 12/2/22 09:18, Michal Simek wrote: The commit ed35de617013 ("Convert CONFIG_ZYNQMP_PSU_INIT_ENABLED to Kconfig") converted CONFIG_ZYNQMP_PSU_INIT_ENABLED symbol and enabled it by default which is not correct configuration. Intention of this config was to have it enabled by default for SPL a

Re: [PATCH] board/xilinx/zynqmp/MAINTAINERS: change e-mail address for Luca Ceresoli

2022-12-04 Thread Michal Simek
On 12/3/22 22:49, Luca Ceresoli wrote: My Bootlin address is the preferred one now. Signed-off-by: Luca Ceresoli Signed-off-by: Luca Ceresoli --- board/xilinx/zynqmp/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/zynqmp/MAINTAINERS b/board/xi

Please pull u-boot-i2c

2022-12-04 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c: The following changes since commit d2c5607edde2544e059fa871927877213f6bd532: Merge tag 'efi-2023-01-rc3' of https://source.denx.de/u-boot/custodians/u-boot-efi (2022-12-04 10:01:48 -0500) are available in the Git repository at: https://source.denx.d

Re: [PATCH v1] i2c: nuvoton: renamed the NPCM i2c driver

2022-12-04 Thread Heiko Schocher
Hello Jim Liu, On 21.11.22 09:59, Jim Liu wrote: > The Makefile name is npcm_i2c but the driver is npcm-i2c. > > Signed-off-by: Jim Liu > --- > drivers/i2c/{npcm-i2c.c => npcm_i2c.c} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename drivers/i2c/{npcm-i2c.c => npcm_i2c.c} (100%) >

Re: [PATCH 1/1] doc: board: typo GIUD Microchip MPFS Icicle Kit doc

2022-12-04 Thread Padmarao.Begari
> On Wed, 2022-11-30 at 18:03 +0100, Heinrich Schuchardt wrote: > %s/GIUD/GUID/ > > Fixes: 9e550e18305f ("doc: board: Add Microchip MPFS Icicle Kit doc") > Signed-off-by: Heinrich Schuchardt > > --- > doc/board/microchip/mpfs_icicle.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] serial: Use -EAGAIN in getc and putc

2022-12-04 Thread Stefan Roese
On 12/4/22 13:36, Pali Rohár wrote: U-Boot serial code already handles -EAGAIN value from getc and putc callbacks. So change drivers code to return -EAGAIN when HW is busy instead of doing its own busy loop and waiting until HW is ready. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese T

Re: [PATCH v5 3/3] board: qemu-riscv: enable semihosting

2022-12-04 Thread Kautuk Consul
Hi, On Sat, Dec 3, 2022 at 9:44 AM Bin Meng wrote: > > On Fri, Sep 23, 2022 at 3:03 PM Kautuk Consul > wrote: > > > > To enable semihosting we also need to enable the following > > configs in defconfigs: > > CONFIG_SEMIHOSTING > > CONFIG_SPL_SEMIHOSTING > > CONFIG_SEMIHOSTING_SERIAL > > CONFIG_

Re: [PATCH v5 0/3] Add riscv semihosting support in u-boot

2022-12-04 Thread Kautuk Consul
Sorry about that! I assumed everyone would know the option and decided to just upt the ordinary command to show that the semihosting changes don't impact the non-semihosting scenarios. On Sat, Dec 3, 2022 at 11:32 AM Bin Meng wrote: > Hi Kautuk, > > On Sat, Dec 3, 2022 at 12:28 PM Bin Meng wrot

Re: [PATCH v1] i2c: nuvoton: renamed the NPCM i2c driver

2022-12-04 Thread Heiko Schocher
Hello Jim Liu, On 21.11.22 09:59, Jim Liu wrote: > The Makefile name is npcm_i2c but the driver is npcm-i2c. > > Signed-off-by: Jim Liu > --- > drivers/i2c/{npcm-i2c.c => npcm_i2c.c} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename drivers/i2c/{npcm-i2c.c => npcm_i2c.c} (100%) >

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-12-04 Thread offougajoris
Tested on Warp7 , thanks Tested-by: Joris Offouga > Le 30 nov. 2022 à 19:55, hsimeliere.opensou...@witekio.com a écrit : > > From: Hugo SIMELIERE > > Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 > blocks DFU usb requests. > The verification of the transfer direction

Re: [PATCH] Enforce buffer boundaries on RNDIS USB Gadget

2022-12-04 Thread Marek Vasut
On 12/4/22 21:36, Szymon Heidrich wrote: Hi, sorry for the delays. diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c index 13c327ea38..3948f2cc9a 100644 --- a/drivers/usb/gadget/rndis.c +++ b/drivers/usb/gadget/rndis.c @@ -855,14 +855,17 @@ static int rndis_set_response(int

[RFC 1/1] sound: allow waveform selection

2022-12-04 Thread Heinrich Schuchardt
* Allow the sound command to select the sine or the square waveform. * Allow to play multiple tones with one command. * Adjust documentation. * Adjust unit test. Signed-off-by: Heinrich Schuchardt --- This would be the alternative to [v2,6/7] sound: add CONFIG_SOUND_SINE symbol For testing with t

[PATCHv2 010/149] rsa-verify: Rework host check for CONFIG_RSA_VERIFY_WITH_PKEY

2022-12-04 Thread Tom Rini
While we do not want to use CONFIG_RSA_VERIFY_WITH_PKEY on the host, we cannot undef the symbol in this manner. As this ends up being a test within another function we can use !tools_build() as a test here. Cc: Simon Glass Signed-off-by: Tom Rini --- Changes in v2: - Switch to !tools_build() per

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-04 Thread Pali Rohár
On Monday 05 December 2022 10:16:51 Simon Glass wrote: > On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > > > Properly seek the end of default_environment variables. > > > > The current algorithm overwrites from the second variable. This > > replacement finds the end of the array of strings

Re: [PATCH 1/1] sound: avoid endless loop

2022-12-04 Thread Heinrich Schuchardt
On 12/4/22 22:17, Simon Glass wrote: On Mon, 5 Dec 2022 at 02:05, Heinrich Schuchardt wrote: 'sound play 1 10' results in an endless loop on the sandbox. If the frequency exceeds half the sampling rate, zero out the output buffer. Fixes: 511ed5fdd389 ("SOUND: SAMSUNG: Add I2S driver")

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2022-12-04 Thread Pierre-Clément Tosi
Hi, On Fri, Dec 02, 2022 at 08:38:37PM +0100, s...@geanix.com wrote: > > Quoting Pierre-Clément Tosi : > > > Add a check for calloc() failing to allocate the requested memory. > > > > Make decode_regions() return an error code. > > > > Cc: Bin Meng > > Cc: Simon Glass > > Cc: Stefan Roese >

Re: [PATCH 05/41] chromebook_samus_tpl: Disable SPL networking

2022-12-04 Thread Simon Glass
On Mon, 28 Nov 2022 at 04:25, Tom Rini wrote: > > We don't appear to actually use networking in SPL here, disable it. > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > configs/chromebook_samus_tpl_defconfig | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH 2/3] sound: add CONFIG_SOUND_SINE symbol

2022-12-04 Thread Simon Glass
Hi Heinrich, On Mon, 5 Dec 2022 at 09:53, Heinrich Schuchardt wrote: > > Provide a configuration symbol to allow the sound command play a sine wave > instead of a square wave. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/sound/Kconfig| 6 ++ > drivers/sound/sound-uclass.c

Re: [PATCH 002/149] rk32xx: Use standard TPL linker script

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 04:06, Tom Rini wrote: > > As of 2f41ade79e59 ("linker: Modify linker scripts to be more generic") > we can use the same linker script for SPL and TPL and not have to make > use of #undef tricks. Remove these last remnants. > > Signed-off-by: Tom Rini > --- > arch/arm/mach-

Re: [PATCH 1/1] drivers:spi:fix some typos

2022-12-04 Thread Simon Glass
On Sat, 3 Dec 2022 at 01:26, Pengfei Fan wrote: > > Fix some typos in spi drivers > > Signed-off-by: Pengfei Fan > --- > drivers/spi/bcm63xx_hsspi.c | 2 +- > drivers/spi/cadence_qspi.c| 2 +- > drivers/spi/fsl_dspi.c| 4 ++-- > drivers/spi/mtk_snfi_spi.c| 4 ++-- > drivers/spi

Re: [PATCH 1/1] test:dm:fix typo

2022-12-04 Thread Simon Glass
On Sat, 3 Dec 2022 at 01:26, Yuepeng Xing wrote: > > Fix typos in the 'test/dm' directory. > > Signed-off-by: Yuepeng Xing > --- > test/dm/blk.c| 2 +- > test/dm/button.c | 4 ++-- > test/dm/gpio.c | 4 ++-- > test/dm/host.c | 2 +- > test/dm/remoteproc.c | 2 +- > test/d

Re: [PATCH 1/1] common:autoboot:modify function parameters

2022-12-04 Thread Simon Glass
On Sat, 3 Dec 2022 at 01:25, Shenlin Liang wrote: > > the blob parameter of the function process_fdt_options has not been > invoked in the function body and should be changed to void type > > Signed-off-by: Shenlin Liang > --- > common/autoboot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH 001/149] exynos: Rework legacy PWM usage

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 04:06, Tom Rini wrote: > > The way that the timer support is currently done for exynos/nexell > platforms relies on the legacy PWM infrastructure, and that needs to be > updated. However, we really cannot safely undef CONFIG_DM_PWM to build > the timer.c file without warnings

Re: [PATCH v5 1/1] u-boot-initial-env: rework make target

2022-12-04 Thread Simon Glass
Hi Max, On Mon, 28 Nov 2022 at 21:41, Max Krummenacher wrote: > > From: Max Krummenacher > > With LTO enabled the U-Boot initial environment is no longer stored > in an easy accessible section in env/common.o. I.e. the section name > changes from build to build, its content maybe compressed and

Re: [PATCH v3 1/2] tools: mkimage: don't print error message "Success" in case of failure

2022-12-04 Thread Simon Glass
On Thu, 24 Nov 2022 at 00:55, Marc Kleine-Budde wrote: > > In case there's no struct image_type_params::set_header callback, no > "errno" will be set. Don't fail with an error message, followed by > "Success". Remove the printing of the human readable "errno" value. > > Signed-off-by: Marc Kleine-

Re: [PATCH 33/41] sandbox: Finish migration to Kconfig

2022-12-04 Thread Simon Glass
Hi Tom, On Sat, 3 Dec 2022 at 10:43, Tom Rini wrote: > > Stop using CONFIG_SANDBOX_ARCH and use CONFIG_SANDBOX instead. For the > SPI related defines, set them directly in Kconfig. This now empties > arch/sandbox/include/asm/config.h. > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > arch/

Re: [PATCH 01/41] usb: Update USB_STORAGE dependencies

2022-12-04 Thread Simon Glass
On Sat, 3 Dec 2022 at 10:43, Tom Rini wrote: > > As it's no longer possible to have !DM_USB set, we can remove these > dependencies. > > Signed-off-by: Tom Rini > --- > common/spl/Kconfig | 2 +- > drivers/usb/Kconfig | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Simon

Re: [PATCH 010/149] rsa-verify: Rework host check for CONFIG_RSA_VERIFY_WITH_PKEY

2022-12-04 Thread Simon Glass
Hi Tom, On Mon, 5 Dec 2022 at 04:07, Tom Rini wrote: > > While we do not want to use CONFIG_RSA_VERIFY_WITH_PKEY on the host, we > cannot undef the symbol in this manner. As this ends up only being a > single location in a file that already has other checks for HOST_CC, add > one more HOST_CC che

Re: [PATCH 1/1] sound: avoid endless loop

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 02:05, Heinrich Schuchardt wrote: > > 'sound play 1 10' results in an endless loop on the sandbox. > > If the frequency exceeds half the sampling rate, zero out the output > buffer. > > Fixes: 511ed5fdd389 ("SOUND: SAMSUNG: Add I2S driver") > Signed-off-by: Heinrich Schuc

Re: Patch proposal - mkimage: fit: Support signed conf 'auto' FITs

2022-12-04 Thread Simon Glass
()Hi Sean, On Tue, 29 Nov 2022 at 04:45, Sean Anderson wrote: > > On 11/22/22 21:09, Simon Glass wrote: > > Hi Pegorer, > > > > On Sat, 19 Nov 2022 at 11:01, Pegorer Massimo > > wrote: > >> > >> Commit 87b0af9317cb4105f3f29cb0a4c28c7cd87ea65f added support for signing > >> auto-generated (mkim

Re: [PATCH] reboot-mode: Add NVMEM reboot mode

2022-12-04 Thread Simon Glass
On Sat, 3 Dec 2022 at 05:04, Sean Anderson wrote: > > This adds an NVMEM reboot mode driver, similar to Linux's > implementation. This allows using the same device tree binding for Linux > and U-Boot in most cases. > > Signed-off-by: Sean Anderson > --- > > MAINTAINERS

Re: [PATCH] serial: Use -EAGAIN in getc and putc

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 01:37, Pali Rohár wrote: > > U-Boot serial code already handles -EAGAIN value from getc and putc > callbacks. So change drivers code to return -EAGAIN when HW is busy instead > of doing its own busy loop and waiting until HW is ready. > > Signed-off-by: Pali Rohár > --- > d

Re: [PATCH 00/17] Support android boot image v3/v4

2022-12-04 Thread Simon Glass
Hi Safae, On Sun, 27 Nov 2022 at 05:59, Safae Ouajih wrote: > > Hello everyone, > > * This is based on Roman Stratiienko's work to support boot image header > version 3 and 4. > > * This supports the new boot image headers v3, v4 and bootconfig feature. > https://source.android.com/docs/core/arc

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-04 Thread Simon Glass
On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > Properly seek the end of default_environment variables. > > The current algorithm overwrites from the second variable. This > replacement finds the end of the array of strings. > > Stomped variables include "board", "soc", "loadaddr". These

Re: [PATCH] ata: ahci-pci: Replace magic constant by macro

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 01:32, Pali Rohár wrote: > > Replace 0x1b21 by macro PCI_VENDOR_ID_ASMEDIA with the same value. > > Signed-off-by: Pali Rohár > --- > drivers/ata/ahci-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 1/1] doc: man-page for the sound command

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 04:23, Heinrich Schuchardt wrote: > > Provide a man-page for the sound command. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/cmd/sound.rst | 41 + > doc/usage/index.rst | 1 + > 2 files changed, 42 insertions(+) > cr

Re: [PATCH 1/1] cmd: fix long text for sound command

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 04:38, Heinrich Schuchardt wrote: > > Make it clear that if only 1 parameter is provided this is the duration. > > The ISO symbol for hertz is Hz. > > Fixes: c0c88533fffd ("Sound: Add command for audio playback") > Signed-off-by: Heinrich Schuchardt > --- > cmd/sound.c | 2

Re: [PATCH 1/1] test: test sandbox sound driver more rigorously

2022-12-04 Thread Simon Glass
On Mon, 5 Dec 2022 at 05:16, Heinrich Schuchardt wrote: > > Consider unexpected values for frequency: > > * negative frequency > * zero frequency > * frequency exceeding sampling frequency > > As in these cases the sum of the samples is zero also check the count of > the samples. > > Signed-off-by

[PATCH v2 7/7] sandbox: fix sound driver

2022-12-04 Thread Heinrich Schuchardt
In the callback function we have to use memcpy(). Otherwise we add the new samples on top of what is stored in the stream buffer. If we don't have enough data, zero out the rest of the stream buffer. Our sampling frequency is 48000. Let the batch size for the callback function be 960. If we play

[PATCH v2 2/7] test: test sandbox sound driver more rigorously

2022-12-04 Thread Heinrich Schuchardt
Consider unexpected values for frequency: * negative frequency * zero frequency * frequency exceeding sampling frequency As in these cases the sum of the samples is zero also check the count of the samples. Signed-off-by: Heinrich Schuchardt --- v2: no change --- arch/sandbox/include/a

[PATCH v2 4/7] doc: man-page for the sound command

2022-12-04 Thread Heinrich Schuchardt
Provide a man-page for the sound command. Signed-off-by: Heinrich Schuchardt --- v2: add default values --- doc/usage/cmd/sound.rst | 41 + doc/usage/index.rst | 1 + 2 files changed, 42 insertions(+) create mode 100644 doc/usage/cmd/sound.rs

[PATCH v2 6/7] sound: add CONFIG_SOUND_SINE symbol

2022-12-04 Thread Heinrich Schuchardt
Provide a configuration symbol to allow the sound command play a sine wave instead of a square wave. Signed-off-by: Heinrich Schuchardt --- v2: update documentation --- doc/usage/cmd/sound.rst | 3 +++ drivers/sound/Kconfig| 6 ++ drivers/sound/sound-uclass.c | 10

[PATCH v2 3/7] cmd: fix long text for sound command

2022-12-04 Thread Heinrich Schuchardt
Make it clear that if only 1 parameter is provided this is the duration. The ISO symbol for hertz is Hz. Fixes: c0c88533fffd ("Sound: Add command for audio playback") Signed-off-by: Heinrich Schuchardt --- v2: no change --- cmd/sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH v2 5/7] sound: function to generate sine wave

2022-12-04 Thread Heinrich Schuchardt
Add function sound_create_sine_wave(). Signed-off-by: Heinrich Schuchardt --- v2: remove stray printf() --- drivers/sound/sound.c | 37 + include/sound.h | 12 2 files changed, 49 insertions(+) diff --git a/drivers/sound/sound.c b/d

[PATCH v2 1/7] sound: avoid endless loop

2022-12-04 Thread Heinrich Schuchardt
'sound play 1 10' results in an endless loop on the sandbox. If the frequency exceeds half the sampling rate, zero out the output buffer. Fixes: 511ed5fdd389 ("SOUND: SAMSUNG: Add I2S driver") Signed-off-by: Heinrich Schuchardt --- v2: no change --- drivers/sound/sound.c | 5 -

[PATCH v2 0/7] sound: fix drivers

2022-12-04 Thread Heinrich Schuchardt
* Avoid endless loop in sound_create_square_wave() * In unit test add edge cases. * Fix long text for sound command. * Add man-page for sound command. * Add sine wave generator. * Fix sandbox driver. v2: bring all sound related patches into one series add default values in man-page

[PATCH 3/3] sandbox: fix sound driver

2022-12-04 Thread Heinrich Schuchardt
In the callback function we have to use memcpy(). Otherwise we add the new samples on top of what is stored in the stream buffer. If we don't have enough data, zero out the rest of the stream buffer. Our sampling frequency is 48000. Let the batch size for the callback function be 960. If we play

[PATCH 2/3] sound: add CONFIG_SOUND_SINE symbol

2022-12-04 Thread Heinrich Schuchardt
Provide a configuration symbol to allow the sound command play a sine wave instead of a square wave. Signed-off-by: Heinrich Schuchardt --- drivers/sound/Kconfig| 6 ++ drivers/sound/sound-uclass.c | 10 -- test/dm/sound.c | 20 3 files chan

[PATCH 0/3] sandbox: fix sound driver

2022-12-04 Thread Heinrich Schuchardt
The playback from the sound driver does not provide the expected sound. To make this easier to hear add a sine wave generator to the sound driver and add a configuration symbol to select it. This series is on top of [PATCH 1/1] test: test sandbox sound driver more rigorously https://lists.denx.de

[PATCH 1/3] sound: function to generate sine wave

2022-12-04 Thread Heinrich Schuchardt
Add function sound_create_sine_wave(). Signed-off-by: Heinrich Schuchardt --- drivers/sound/sound.c | 39 +++ include/sound.h | 12 2 files changed, 51 insertions(+) diff --git a/drivers/sound/sound.c b/drivers/sound/sound.c index c0fc50c99

Re: [PATCH] Enforce buffer boundaries on RNDIS USB Gadget

2022-12-04 Thread Szymon Heidrich
On 04/12/2022 20:12, Marek Vasut wrote: > On 12/3/22 15:59, Szymon Heidrich wrote: >> On 20/11/2022 16:02, Fabio Estevam wrote: >>> Szymon, >>> >>> On Thu, Nov 17, 2022 at 4:46 PM Szymon Heidrich >>> wrote: Prevent access to arbitrary memory locations in gen_ndis_set_resp via manipu

Re: Pull request for efi-2023-01-rc3

2022-12-04 Thread Tom Rini
On Fri, Dec 02, 2022 at 08:49:48PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit a32f6341ccf2ea69f64fe87b9d07fd87325a2056: > > Merge branch '2022-12-02-assorted-updates' (2022-12-02 10:00:55 -0500) > > are available in the Git repository at: > > https

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2022-12-04 Thread Simon Glass
Hi Rob, On Tue, 29 Nov 2022 at 05:22, Rob Herring wrote: > > On Fri, Nov 25, 2022 at 3:18 PM Simon Glass wrote: > > > > Hi Abdellatif, > > > > On Thu, 24 Nov 2022 at 06:21, Abdellatif El Khlifi > > wrote: > > > > > > On Tue, Nov 22, 2022 at 07:09:16PM -0700, Simon Glass wrote: > > > > should

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-12-04 Thread Marek Vasut
On 11/30/22 19:58, Fabio Estevam wrote: Adding Marek and Sultan On Wed, Nov 30, 2022 at 3:55 PM wrote: From: Hugo SIMELIERE Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 blocks DFU usb requests. The verification of the transfer direction was done by an equality but it

Re: [PATCH] Enforce buffer boundaries on RNDIS USB Gadget

2022-12-04 Thread Marek Vasut
On 12/3/22 15:59, Szymon Heidrich wrote: On 20/11/2022 16:02, Fabio Estevam wrote: Szymon, On Thu, Nov 17, 2022 at 4:46 PM Szymon Heidrich wrote: Prevent access to arbitrary memory locations in gen_ndis_set_resp via manipulation of buf->InformationBufferOffset. Lack of validation of BufOffse

Re: [PATCH] dfu: Make DFU virtual backend SPL friendly

2022-12-04 Thread Marek Vasut
On 11/30/22 11:42, Patrick Delaunay wrote: Define stub for dfu_*_virt function in SPL, because CONFIG_SPL_DFU_VIRT is not defined. This patch avoids compilation issue in dfu_fill_entity() when CONFIG_SPL_DFU is activated because the dfu_fill_entity_virt() function is not available. Fixes: ec44c

Re: [PATCH 091/149] global: Migrate CONFIG_MXC_USB_FLAGS et al to CFG

2022-12-04 Thread Tom Rini
On Sun, Dec 04, 2022 at 10:13:22AM -0500, Tom Rini wrote: > Perform simple renames of: >CONFIG_MXC_USB_FLAGS to CFG_MXC_USB_FLAGS >CONFIG_MXC_USB_PORT to CFG_MXC_USB_PORT >CONFIG_MXC_USB_PORTSC to CFG_MXC_USB_PORTSC > > Signed-off-by: Tom Rini Duplicate posting because I once again

Re: [PATCH 144/149] CI: Replace unmigrated symbol test with non-Kconfig introduction test

2022-12-04 Thread Tom Rini
On Sun, Dec 04, 2022 at 10:14:15AM -0500, Tom Rini wrote: > Now that all symbols have been migrated to Kconfig, or are part of the > CFG namespace we do not need a complex check for unmigrated CONFIG > symbols. Any instance of #define (or #undef) or a CONFIG value is wrong, > so cause CI to fail.

[PATCH 1/1] test: test sandbox sound driver more rigorously

2022-12-04 Thread Heinrich Schuchardt
Consider unexpected values for frequency: * negative frequency * zero frequency * frequency exceeding sampling frequency As in these cases the sum of the samples is zero also check the count of the samples. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/include/asm/test.h | 10 ++

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-04 Thread Marek Vasut
On 12/4/22 13:59, Thorsten Leemhuis wrote: On 04.12.22 13:50, Marek Vasut wrote: On 12/2/22 16:56, Thorsten Leemhuis wrote: On 02.12.22 15:31, Marek Vasut wrote: On 12/2/22 15:05, Miquel Raynal wrote: [...] 3. To fix the current situation: Immediately revert commit (and prevent it from

[PATCH 1/1] cmd: fix long text for sound command

2022-12-04 Thread Heinrich Schuchardt
Make it clear that if only 1 parameter is provided this is the duration. The ISO symbol for hertz is Hz. Fixes: c0c88533fffd ("Sound: Add command for audio playback") Signed-off-by: Heinrich Schuchardt --- cmd/sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/sound

[PATCH 1/1] doc: man-page for the sound command

2022-12-04 Thread Heinrich Schuchardt
Provide a man-page for the sound command. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/sound.rst | 41 + doc/usage/index.rst | 1 + 2 files changed, 42 insertions(+) create mode 100644 doc/usage/cmd/sound.rst diff --git a/doc/usage/cmd/sound

[PATCH 145/149] kbuild: Remove checking for adhoc CONFIG symbols

2022-12-04 Thread Tom Rini
At this point all listed adhoc CONFIG symbols have been migrated to Kconfig or removed from the tree or renamed to CFG (or similar). We also now have CI tests that will error on any new introductions, and checkpatch.pl also looks. We can now remove these hooks and related scripts. Signed-off-by: T

[PATCH 149/149] common/spl/spl_ram: Remove unused default

2022-12-04 Thread Tom Rini
We ask for CONFIG_SPL_LOAD_FIT_ADDRESS in Kconfig, so we cannot define it in C as a fall-back. However, this option previously was buried under "if ... endif" Kconfig logic. Rework a number of config options to now have more robust dependency lines so that we can ask this address when needed. With

[PATCH 148/149] cf_spi.c: Rename CONFIG_SPI_IDLE_VAL to SPI_IDLE_VAL

2022-12-04 Thread Tom Rini
This value is never changed by boards, so just rename it to SPI_IDLE_VAL to fit with the rest of the code. Signed-off-by: Tom Rini --- drivers/spi/cf_spi.c | 12 ++-- drivers/spi/sandbox_spi.c | 4 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/spi/cf_

[PATCH 146/149] post: Move CONFIG_SYS_POST to CFG_SYS_POST

2022-12-04 Thread Tom Rini
Migrate the rest of the CONFIG_SYS_POST macros over to CFG_SYS_POST namespace. Signed-off-by: Tom Rini --- doc/README.POST | 12 +-- drivers/serial/serial-uclass.c| 2 +- drivers/serial/serial.c | 2 +- include/post.h

[PATCH 144/149] CI: Replace unmigrated symbol test with non-Kconfig introduction test

2022-12-04 Thread Tom Rini
Now that all symbols have been migrated to Kconfig, or are part of the CFG namespace we do not need a complex check for unmigrated CONFIG symbols. Any instance of #define (or #undef) or a CONFIG value is wrong, so cause CI to fail. This test is not as strict as possible yet as we have more symbols

[PATCH 143/149] checkpatch.pl: Update CONFIG logic in U-Boot section

2022-12-04 Thread Tom Rini
Now that all CONFIG symbols are in Kconfig, checkpatch.pl should check for and error on any case of define/undef CONFIG_*. Signed-off-by: Tom Rini --- scripts/checkpatch.pl | 8 tools/patman/test_checkpatch.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --gi

[PATCH 147/149] pci-rcar-gen3: Rename CONFIG_SEND_ENABLE

2022-12-04 Thread Tom Rini
We rename the symbol CONFIG_SEND_ENABLE to just SEND_ENABLE, and remove the second whitespace following the define. Signed-off-by: Tom Rini --- drivers/pci/pci-rcar-gen3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-rcar-gen3.c b/drivers/pci/pci-rcar

[PATCH 142/149] kbuild: Remove uncmd_spl logic

2022-12-04 Thread Tom Rini
At this point in the conversion there should be no need to have logic to disable some symbol during the SPL build as all symbols should have an SPL counterpart. The main real changes done here are that we now must make proper use of CONFIG_IS_ENABLED(DM_SERIAL) rather than many of the odd tricks w

[PATCH 141/149] bcmcygnus: Convert CONFIG_IPROC to Kconfig

2022-12-04 Thread Tom Rini
Select this symbol as needed. Signed-off-by: Tom Rini --- arch/arm/Kconfig| 4 arch/arm/include/asm/iproc-common/configs.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 42576e503a4a..d7318cad8f63

[PATCH 140/149] configs: Remove unused or redundant CONFIG symbols

2022-12-04 Thread Tom Rini
A number of CONFIG symbols have crept in that are never referenced in code, so drop them here. Further, we have two symbols being enabled in headers while already enabled correctly in Kconfig, so these lines can also be removed. Signed-off-by: Tom Rini --- arch/arm/cpu/armv8/fsl-layerscape/Kconf

[PATCH 139/149] librem5: Rename CONFIG_POWER_BD71837 symbols

2022-12-04 Thread Tom Rini
Rename the CONFIG_POWER_BD71837_I2C_* symbols to not have the CONFIG prefix and be local to the file they are used in. Signed-off-by: Tom Rini --- board/purism/librem5/spl.c | 8 +--- include/configs/librem5.h | 4 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/board/pu

[PATCH 138/149] global: Migrate CONFIG_X86_REFCODE_RUN_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_X86_REFCODE_RUN_ADDR to CFG_X86_REFCODE_RUN_ADDR Signed-off-by: Tom Rini --- arch/x86/cpu/broadwell/refcode.c | 4 ++-- include/configs/x86-chromebook.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/cpu/broadwell/refcode.c b/ar

[PATCH 137/149] global: Migrate CONFIG_X86_REFCODE_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_X86_REFCODE_ADDR to CFG_X86_REFCODE_ADDR Signed-off-by: Tom Rini --- arch/x86/cpu/broadwell/refcode.c | 2 +- arch/x86/dts/u-boot.dtsi | 2 +- include/configs/x86-chromebook.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x8

[PATCH 136/149] global: Migrate CONFIG_X86_MRC_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_X86_MRC_ADDR to CFG_X86_MRC_ADDR Signed-off-by: Tom Rini --- arch/x86/cpu/intel_common/mrc.c | 2 +- arch/x86/dts/u-boot.dtsi | 2 +- include/configs/x86-chromebook.h | 2 +- tools/binman/binman.rst | 2 +- 4 files changed, 4 insertions(+), 4 d

[PATCH 135/149] global: Migrate CONFIG_WATCHDOG_PRESC et al to CFG

2022-12-04 Thread Tom Rini
Perform simple renames of: CONFIG_WATCHDOG_PRESC to CFG_WATCHDOG_PRESC CONFIG_WATCHDOG_RC to CFG_WATCHDOG_RC Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- include/configs/kmcent2.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/power

[PATCH 129/149] global: Migrate CONFIG_TESTPIN_REG to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_TESTPIN_REG to CFG_TESTPIN_REG Signed-off-by: Tom Rini --- board/keymile/km83xx/km83xx.c | 2 +- include/configs/kmcoge5ne.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c in

[PATCH 134/149] global: Migrate CONFIG_VSC7385_IMAGE et al to CFG

2022-12-04 Thread Tom Rini
Perform simple renames of: CONFIG_VSC7385_IMAGE to CFG_VSC7385_IMAGE CONFIG_VSC7385_IMAGE_SIZE to CFG_VSC7385_IMAGE_SIZE Signed-off-by: Tom Rini --- board/freescale/mpc837xerdb/mpc837xerdb.c | 6 +++--- board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 2 +- include/configs/MPC837XERDB.h

[PATCH 133/149] global: Migrate CONFIG_USB_ISP1301_I2C_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_USB_ISP1301_I2C_ADDR to CFG_USB_ISP1301_I2C_ADDR Signed-off-by: Tom Rini --- drivers/usb/host/ohci-lpc32xx.c | 2 +- include/configs/devkit3250.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-lpc32xx.c b/drivers

[PATCH 132/149] global: Migrate CONFIG_USART_ID to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_USART_ID to CFG_USART_ID Signed-off-by: Tom Rini --- drivers/serial/atmel_usart.c| 2 +- include/configs/corvus.h| 2 +- include/configs/sam9x60_curiosity.h | 2 +- include/configs/sam9x60ek.h | 2 +- include/configs/smartweb.h

[PATCH 131/149] global: Migrate CONFIG_USART_BASE to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_USART_BASE to CFG_USART_BASE Signed-off-by: Tom Rini --- drivers/serial/atmel_usart.c| 10 +- include/configs/corvus.h| 2 +- include/configs/sam9x60_curiosity.h | 2 +- include/configs/sam9x60ek.h | 2 +- include/configs/s

[PATCH 127/149] global: Migrate CONFIG_TEGRA_BOARD_STRING to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_TEGRA_BOARD_STRING to CFG_TEGRA_BOARD_STRING Signed-off-by: Tom Rini --- arch/arm/mach-tegra/board2.c | 2 +- include/configs/beaver.h | 2 +- include/configs/cardhu.h | 2 +- include/configs/cei-tk1-som.h | 2 +- include/configs/dalmore.h | 2 +-

[PATCH 130/149] global: Migrate CONFIG_TSEC_TBICR_SETTINGS to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_TSEC_TBICR_SETTINGS to CFG_TSEC_TBICR_SETTINGS Signed-off-by: Tom Rini --- drivers/net/tsec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index f465409d8c8e..8833e3098d52 100644 --- a/driver

[PATCH 128/149] global: Migrate CONFIG_TESTPIN_MASK to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_TESTPIN_MASK to CFG_TESTPIN_MASK Signed-off-by: Tom Rini --- board/keymile/km83xx/km83xx.c | 2 +- include/configs/kmcoge5ne.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board/keymile/km83xx/km83xx.c b/board/keymile/km83xx/km83xx.c

[PATCH 126/149] global: Migrate CONFIG_SYS_I2C_DIRECT_BUS to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SYS_I2C_DIRECT_BUS to CFG_SYS_I2C_DIRECT_BUS Signed-off-by: Tom Rini --- README | 4 ++-- cmd/i2c.c | 4 ++-- drivers/i2c/i2c_core.c | 10 +- include/i2c.h | 8 4 files changed, 13 insertions(+), 13 delet

[PATCH 123/149] global: Migrate CONFIG_SMP_PEN_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SMP_PEN_ADDR to CFG_SMP_PEN_ADDR Signed-off-by: Tom Rini --- arch/arm/cpu/armv7/nonsec_virt.S | 4 ++-- board/samsung/arndale/arndale.c | 4 ++-- include/configs/arndale.h| 2 +- include/configs/km/pg-wcom-ls102xa.h | 2 +- include/configs/l

[PATCH 125/149] global: Migrate CONFIG_STD_DEVICES_SETTINGS to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_STD_DEVICES_SETTINGS to CFG_STD_DEVICES_SETTINGS Signed-off-by: Tom Rini --- include/configs/bayleybay.h | 2 +- include/configs/cherryhill.h | 2 +- include/configs/chromebook_coral.h| 4 ++-- include/configs/chromebook_samus

[PATCH 124/149] global: Migrate CONFIG_STACKBASE to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_STACKBASE to CFG_STACKBASE Signed-off-by: Tom Rini --- include/configs/tegra-common.h| 2 +- include/configs/tegra114-common.h | 2 +- include/configs/tegra124-common.h | 2 +- include/configs/tegra20-common.h | 2 +- include/configs/tegra30-common.h | 2 +

[PATCH 122/149] global: Migrate CONFIG_SLIC to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SLIC to CFG_SLIC Signed-off-by: Tom Rini --- board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 2 +- include/configs/p1_p2_rdb_pc.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/b

[PATCH 121/149] global: Migrate CONFIG_SH_ETHER_USE_PORT to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SH_ETHER_USE_PORT to CFG_SH_ETHER_USE_PORT Signed-off-by: Tom Rini --- README| 2 +- drivers/net/sh_eth.c | 6 +++--- include/configs/alt.h | 2 +- include/configs/condor.h | 2 +- include/configs/gose.h| 2 +- include/configs/g

[PATCH 120/149] global: Migrate CONFIG_SH_ETHER_PHY_MODE to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SH_ETHER_PHY_MODE to CFG_SH_ETHER_PHY_MODE Signed-off-by: Tom Rini --- include/configs/alt.h | 2 +- include/configs/condor.h | 2 +- include/configs/gose.h| 2 +- include/configs/grpeach.h | 2 +- include/configs/koelsch.h | 2 +- include/configs/lager

[PATCH 116/149] global: Migrate CONFIG_SH_ETHER_ALIGNE_SIZE to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SH_ETHER_ALIGNE_SIZE to CFG_SH_ETHER_ALIGNE_SIZE Signed-off-by: Tom Rini --- drivers/net/sh_eth.c | 4 ++-- drivers/net/sh_eth.h | 16 include/configs/alt.h | 2 +- include/configs/condor.h | 2 +- include/configs/gose.h|

[PATCH 119/149] global: Migrate CONFIG_SH_ETHER_PHY_ADDR to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SH_ETHER_PHY_ADDR to CFG_SH_ETHER_PHY_ADDR Signed-off-by: Tom Rini --- README| 2 +- drivers/net/sh_eth.c | 6 +++--- include/configs/alt.h | 2 +- include/configs/condor.h | 2 +- include/configs/gose.h| 2 +- include/configs/g

[PATCH 118/149] global: Migrate CONFIG_SH_ETHER_CACHE_WRITEBACK to CFG

2022-12-04 Thread Tom Rini
Perform a simple rename of CONFIG_SH_ETHER_CACHE_WRITEBACK to CFG_SH_ETHER_CACHE_WRITEBACK Signed-off-by: Tom Rini --- README| 2 +- drivers/net/sh_eth.c | 2 +- include/configs/alt.h | 2 +- include/configs/condor.h | 2 +- include/configs/gose.h| 2 +- includ

  1   2   3   >