Re: [PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-02-04 Thread Jassi Brar
On Wed, 18 Jan 2023 at 08:24, Michal Simek wrote: > > > > On 1/9/23 02:06, Jassi Brar wrote: > > From: Sughosh Ganu > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, on a separate > > region. Add a driver for reading

[PATCHv4 5/5] fwu: rename fwu_get_verified_mdata to fwu_get_mdata

2023-02-04 Thread jassisinghbrar
From: Jassi Brar fwu_get_mdata() sounds more appropriate than fwu_get_verified_mdata() Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- cmd/fwu_mdata.c | 2 +- include/fwu.h | 4 ++-- lib/fwu_updates/fwu.c | 6 +++--- 3 files changed, 6

[PATCHv4 4/5] fwu: meta-data: switch to management by common code

2023-02-04 Thread jassisinghbrar
From: Jassi Brar The common code can now read, verify and fix meta-data copies while exposing one consistent structure to users. Only the .read_mdata() and .write_mdata() callbacks of fwu_mdata_ops are needed. Get rid of .get_mdata() .update_mdata() .get_mdata_part_num() .read_mdata_partition()

[PATCHv4 3/5] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-02-04 Thread jassisinghbrar
From: Jassi Brar Moving towards using common code for meta-data management, implement the read/write mdata hooks. Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- drivers/fwu-mdata/gpt_blk.c | 36 1 file changed,

[PATCHv4 2/5] fwu: move meta-data management in core

2023-02-04 Thread jassisinghbrar
From: Jassi Brar Instead of each i/f having to implement their own meta-data verification and storage, move the logic in common code. This simplifies the i/f code much simpler and compact. Signed-off-by: Jassi Brar --- drivers/fwu-mdata/fwu-mdata-uclass.c | 34 +++ include/fwu.h

[PATCHv4 1/5] fwu: gpt: use cached meta-data partition numbers

2023-02-04 Thread jassisinghbrar
From: Jassi Brar Use cached values and avoid parsing and scanning through partitions everytime for meta-data partitions because they can't change after bootup. Acked-by: Etienne Carriere Reviewed-by: Ilias Apalodimas Signed-off-by: Jassi Brar --- drivers/fwu-mdata/gpt_blk.c | 43

[PATCHv4 0/5] FWU: Handle meta-data in common code

2023-02-04 Thread jassisinghbrar
From: Jassi Brar The patchset reduces ~400 lines of code, while keeping the functionality same and making meta-data operations much faster (by using cached structures). Issue: meta-data copies (primary and secondary) are being handled by the backend/storage layer instead of the common core

Re: [PATCHv3 2/5] fwu: move meta-data management in core

2023-02-04 Thread Jassi Brar
On Mon, 9 Jan 2023 at 06:54, Ilias Apalodimas wrote: > > Hi Jassi, > > On Mon, Jan 02, 2023 at 12:26:40PM -0600, Jassi Brar wrote: > > Instead of each i/f having to implement their own meta-data verification > > and storage, move the logic in common code. This simplifies the i/f code > > much

[PATCH v2 2/2] cli: Correct handling of invalid escape sequences in cread_line()

2023-02-04 Thread Simon Glass
The second call to cli_ch_process() is in the wrong place, meaning that the one of the characters of an invalid escape sequence is swallowed instead of being returned. Fix the bug and add a test to cover this. Signed-off-by: Simon Glass Reported-by: Heinrich Schuchardt --- Changes in v2: -

[PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-04 Thread Simon Glass
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will

Re: [PATCH 019/171] lib: Add a Kconfig for SPL_GENERATE_ACPI_TABLE

2023-02-04 Thread Tom Rini
On Sat, Feb 04, 2023 at 06:21:47PM -0700, Simon Glass wrote: > Hi Tom, Heinrich, > > On Mon, 30 Jan 2023 at 07:52, Tom Rini wrote: > > > > On Mon, Jan 30, 2023 at 03:50:23PM +0100, Heinrich Schuchardt wrote: > > > On 1/30/23 15:40, Simon Glass wrote: > > > > This is implicitly used in the source

Re: [PATCH 020/171] efi: Add a Kconfig for SPL_EFI_LOADER et all

2023-02-04 Thread Tom Rini
On Sat, Feb 04, 2023 at 06:21:48PM -0700, Simon Glass wrote: > Hi Tom, Heinrich, > > On Mon, 30 Jan 2023 at 07:51, Tom Rini wrote: > > > > On Mon, Jan 30, 2023 at 03:48:44PM +0100, Heinrich Schuchardt wrote: > > > On 1/30/23 15:40, Simon Glass wrote: > > > > This and EFI_DEVICE_PATH_TO_TEXT are

Re: [PATCH 020/171] efi: Add a Kconfig for SPL_EFI_LOADER et all

2023-02-04 Thread Simon Glass
Hi Tom, Heinrich, On Mon, 30 Jan 2023 at 07:51, Tom Rini wrote: > > On Mon, Jan 30, 2023 at 03:48:44PM +0100, Heinrich Schuchardt wrote: > > On 1/30/23 15:40, Simon Glass wrote: > > > This and EFI_DEVICE_PATH_TO_TEXT are implicitly used in the source and > > > > This code is not compiled in SPL.

Re: [PATCH 019/171] lib: Add a Kconfig for SPL_GENERATE_ACPI_TABLE

2023-02-04 Thread Simon Glass
Hi Tom, Heinrich, On Mon, 30 Jan 2023 at 07:52, Tom Rini wrote: > > On Mon, Jan 30, 2023 at 03:50:23PM +0100, Heinrich Schuchardt wrote: > > On 1/30/23 15:40, Simon Glass wrote: > > > This is implicitly used in the source and seems useful, so add it. > > > > Please, provide a clear description

Re: [PATCH 015/171] iommu: Add a Kconfig for SPL_IOMMU

2023-02-04 Thread Simon Glass
Hi Mark, On Mon, 30 Jan 2023 at 09:24, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 30 Jan 2023 07:40:48 -0700 > > > > This is implicitly used in the source and seems useful, so add it. > > At this point the IOMMU support isn't used for SPL. While I can't > rule out we'll see an

[PATCH 2/2] cli: Correct handling of invalid escape sequences in cread_line()

2023-02-04 Thread Simon Glass
The second call to cli_ch_process() is in the wrong place, meaning that the one of the characters of an invalid escape sequence is swallowed instead of being returned. Fix the bug and add a test to cover this. Signed-off-by: Simon Glass Reported-by: Heinrich Schuchardt ---

[PATCH 1/2] cli: Correct several bugs in cli_getch()

2023-02-04 Thread Simon Glass
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will

Re: [PATCH 1/1] common: remove "impossible condition #876" message

2023-02-04 Thread Simon Glass
Hi Heinrich, On Mon, 30 Jan 2023 at 18:50, Heinrich Schuchardt wrote: > > On 1/30/23 16:50, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 29 Jan 2023 at 15:32, Heinrich Schuchardt > > wrote: > >> > >> Function cli_ch_esc() supports only a small subset of the escape sequences > >> used by

Re: [PATCH V5 08/12] iot2050: Add script for signing artifacts

2023-02-04 Thread Simon Glass
Hi Jan, On Fri, 3 Feb 2023 at 23:35, Jan Kiszka wrote: > > On 03.02.23 19:51, Tom Rini wrote: > > On Fri, Feb 03, 2023 at 01:26:37PM +0100, Jan Kiszka wrote: > > > >> From: Jan Kiszka > >> > >> There are many ways to get a signed firmware for the IOT2050 devices, > >> namely for the parts under

[PATCH] binman: Support updating section contents

2023-02-04 Thread Simon Glass
Implement this feature since it is useful for updating FITs within an image. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 16 ++ tools/binman/etype/section.py | 28 - tools/binman/ftest.py | 58 --- 3 files

Re: [PATCH] Revert "rockchip: Only call binman when TPL available"

2023-02-04 Thread Simon Glass
Hi Quentin, On Tue, 31 Jan 2023 at 03:54, Quentin Schulz wrote: > > Hi Kever, > > On 1/31/23 03:53, Kever Yang wrote: > > Hi > > > > I think I do this modify for those soc not have TPL, or else it > > will cause the CI build error. > > > > > > TPL/ddr binary is mandatory in all rockchip

Re: [PATCH V6 02/13] arm: dts: iot2050: Use the auto generator nodes for fdt

2023-02-04 Thread Simon Glass
On Sat, 4 Feb 2023 at 02:06, Jan Kiszka wrote: > > From: Su Baocheng > > Refactor according to the entry `fit: Entry containing a FIT` of > document tools/binman/README.entries. > > As the generator uses the device tree name for the config description, > board_fit_config_name_match requires a

Re: [RFC PATCH v1 1/2] include: fdtdec: decouple fdt_addr_t and phys_addr_t size

2023-02-04 Thread Simon Glass
Hi Johan, On Thu, 2 Feb 2023 at 10:58, Johan Jonker wrote: > > The DT specification supports CPUs with both 32-bit and 64-bit addressing > capabilities. In U-boot the fdt_addr_t and phys_addr_t size are coupled > by a typedef. The MTD NAND drivers for 32-bit CPU's can describe partitions > with

Re: [PATCH V5 07/12] tools: Add script for converting public key into device tree include

2023-02-04 Thread Simon Glass
Hi Jan, On Fri, 3 Feb 2023 at 23:35, Jan Kiszka wrote: > > On 04.02.23 01:20, Simon Glass wrote: > > Hi Jan, > > > > On Fri, 3 Feb 2023 at 05:29, Jan Kiszka wrote: > >> > >> From: Jan Kiszka > >> > >> Allows to create a public key device tree dtsi for inclusion into U-Boot > >> SPL and proper

Re: [PATCH 1/3] binman: add sign option for binman

2023-02-04 Thread Simon Glass
Hi Ivan, On Sun, 15 Jan 2023 at 16:54, Ivan Mikhaylov wrote: > > On Fri, 2023-01-13 at 11:00 -0700, Simon Glass wrote: > > Hi Ivan, > > > > On Sat, 24 Dec 2022 at 15:35, Ivan Mikhaylov > > wrote: > > > > > > On Sat, 2022-12-17 at 15:02 -0700, Simon Glass wrote: > > > > Hi Ivan, > > > > > > > >

Re: [RESEND PATCH v3] video: ti: am335x: restore driver-model code

2023-02-04 Thread Anatolij Gustschin
On Sat, 28 Jan 2023 16:55:31 +0100 Dario Binacchi dario.binac...@amarulasolutions.com wrote: > The commit 82f7b869f5d7a ("video: Drop CONFIG_AM335X_LCD") removed not > only the LCD legacy implementation but also the code with driver model > support. The patch restores the code with driver model

Re: [PATCH v2 5/7] board: ti: am62x: am62x: Add splash screen env variables

2023-02-04 Thread Anatolij Gustschin
On Tue, 31 Jan 2023 15:35:18 +0530 Nikhil M Jain n-ja...@ti.com wrote: > Set splash screen related env variables. Default splash source is > set to mmc where user is expected to keep bmp in compressed format > with name ti.gz on first partition of mmc. > > Splash file will be uncompressed to DDR

Re: [PATCH v2 7/7] tools: logos: Add TI logo files

2023-02-04 Thread Anatolij Gustschin
On Tue, 31 Jan 2023 15:35:20 +0530 Nikhil M Jain n-ja...@ti.com wrote: > The default splashfile name saved is ti.gz. User can use these > logo files and use it to test splash screen. > > Signed-off-by: Nikhil M Jain > --- > tools/logos/ti.bmp | Bin 0 -> 160770 bytes > tools/logos/ti.gz | Bin

Re: [PATCH v2 6/7] board: ti: am62x: evm: Add splash screen support

2023-02-04 Thread Anatolij Gustschin
On Tue, 31 Jan 2023 15:35:19 +0530 Nikhil M Jain n-ja...@ti.com wrote: > Splash screen function needs splash source information > to load image and display it, splash_location provides > the necessary info, Set default_splash_location to MMC > at partition 1:1. Probe DSS for splash screen

Re: [PATCH v2 2/7] test: dm: test-fdt: Add decode_panel_timing test

2023-02-04 Thread Anatolij Gustschin
On Tue, 31 Jan 2023 15:35:15 +0530 Nikhil M Jain n-ja...@ti.com wrote: > To test decode_panel_timing add a panel-timings node > and a DM test for decode panel timingd by matching > the panel timing node parameters. > > Signed-off-by: Nikhil M Jain > --- > arch/sandbox/dts/test.dts | 18

Re: [PATCH v3 1/7] drivers: core: ofnode: Add panel timing decode.

2023-02-04 Thread Anatolij Gustschin
On Sat, 4 Feb 2023 18:41:25 +0100 Anatolij Gustschin ag...@denx.de wrote: ... > --- > Changes in v3: > - add static inline dev_decode_panel_timing() in include/dm/read.h >to fix sandbox test errors when CONFIG_DM_DEV_READ_INLINE enabled > > drivers/core/ofnode.c | 47

Please pull u-boot-video

2023-02-04 Thread Anatolij Gustschin
/custodians/u-boot-imx (2023-02-03 10:30:45 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-video.git tags/video-20230204 for you to fetch changes up to 03610ebf3520ae768ff90c4831f39088088ee666: tools: logos: Add TI logo files (2023-02-04 18:19:00 +0100

[PATCH v3 1/7] drivers: core: ofnode: Add panel timing decode.

2023-02-04 Thread Anatolij Gustschin
From: Nikhil M Jain ofnode_decode_display_timing supports reading timing parameters from subnode of display-timings node, for displays supporting multiple resolution, in case if a display supports single resolution, it fails reading directly from display-timings node, to support it

Re: [PATCH V5 08/12] iot2050: Add script for signing artifacts

2023-02-04 Thread Tom Rini
On Sat, Feb 04, 2023 at 07:34:46AM +0100, Jan Kiszka wrote: > On 03.02.23 19:51, Tom Rini wrote: > > On Fri, Feb 03, 2023 at 01:26:37PM +0100, Jan Kiszka wrote: > > > >> From: Jan Kiszka > >> > >> There are many ways to get a signed firmware for the IOT2050 devices, > >> namely for the parts

Re: U-Boot support for M68K removal

2023-02-04 Thread John Paul Adrian Glaubitz
On Mon, 2023-01-30 at 17:22 +0100, John Paul Adrian Glaubitz wrote: > FWIW, m68k is still a very actively maintained architecture in the > Linux kernel and userland with even LLVM and Rust having recently > added support for m68k. > > I also own a Coldfire board myself (not sure which one without

Re: U-Boot tools and binman build fails in macOS 13

2023-02-04 Thread Simon Glass
Hi Alif, On Sat, 4 Feb 2023 at 05:32, Alif Ilhan wrote: > > I also want to specify that, every binman using board build fails in macOS > 13, resulting in the exact Python Symbols missing error. It would be nice if > problem is looked upon….. Unfortunately I don't use MacOS for development. I

Re: [PATCH v7] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-02-04 Thread Dominique Martinet
Patrick Wildt wrote on Wed, Feb 01, 2023 at 12:57:47AM +0100: > The MNT Reform 2 is a modular DIY laptop. In its initial version it > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > lifted from BoundaryDevices official U-Boot downstream project. > > Signed-off-by: Patrick

Re: U-Boot tools and binman build fails in macOS 13

2023-02-04 Thread Alif Ilhan
I also want to specify that, every binman using board build fails in macOS 13, resulting in the exact Python Symbols missing error. It would be nice if problem is looked upon….. > On 4 Feb, 2023, at 8:44 AM, Simon Glass wrote: > > Hi Alif, > > On Fri, 3 Feb 2023 at 19:29, Alif Ilhan wrote:

Re: [PATCH] schemas: Add schema for firmware logs

2023-02-04 Thread Simon Glass
Hi Peter, On Sat, 4 Feb 2023 at 02:36, Peter Robinson wrote: > > Hi Simon, > > Does it make sense to devise something that is compatible with the > kernel's pstore [1] mechanism? Possibly...can you please be a little more specific? Regards, Simon > > Peter > > [1]

Re: [PATCH] schemas: Add schema for firmware logs

2023-02-04 Thread Peter Robinson
Hi Simon, Does it make sense to devise something that is compatible with the kernel's pstore [1] mechanism? Peter [1] https://lwn.net/Articles/434821/ On Sat, Feb 4, 2023 at 12:20 AM Simon Glass wrote: > > A common way to detect problems in firmware is to collect logs from > the firmware,

[PATCH V6 11/13] doc: iot2050: Add a note about the watchdog firmware

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka This is enabled by default, thus should be described as well. Signed-off-by: Jan Kiszka --- doc/board/siemens/iot2050.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/board/siemens/iot2050.rst b/doc/board/siemens/iot2050.rst index cb49a0e36bf..efe94a448a9

[PATCH V6 12/13] board: siemens: iot2050: use the named gpio to control the user-button

2023-02-04 Thread Jan Kiszka
From: chao zeng User-button is controlled by the mcu domain gpio number 25. But main0 main1 mcu domain all have gpio number 25. To identify where the gpio is from, Using gpio controll base as the prefix to indicate the gpio resource. Signed-off-by: chao zeng --- board/siemens/iot2050/board.c

[PATCH V6 10/13] arm: dts: iot2050: Optionally embed OTP programming data into image

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Use external blob otpcmd.bin to replace the 0xff filled OTP programming command block to create a firmware image that provisions the OTP on first boot. This otpcmd.bin is generated from the customer keys using steps described in the meta-iot2050 integration layer for the device.

[PATCH V6 13/13] iot2050: Refresh defconfigs and activate CONFIG_EFI_SCROLL_ON_CLEAR_SCREEN

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka This feature is desired on the platform. Signed-off-by: Jan Kiszka --- configs/iot2050_pg1_defconfig | 6 +++--- configs/iot2050_pg2_defconfig | 7 +++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/configs/iot2050_pg1_defconfig

[PATCH V6 07/13] arm: dts: iot2050: Allow verifying U-Boot proper by SPL

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Add hashes and configuration signature stubs to prepare verified boot of main U-Boot by SPL. Signed-off-by: Jan Kiszka --- arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 16 1 file changed, 16 insertions(+) diff --git

[PATCH V6 09/13] iot2050: Add script for signing artifacts

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka There are many ways to get a signed firmware for the IOT2050 devices, namely for the parts under user-control. This script documents one way of doing it, given a signing key. Augment the board documentation with the required procedure around it. Signed-off-by: Jan Kiszka ---

[PATCH V6 05/13] iot2050: Add watchdog start to bootcmd

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Allows run-time control over watchdog auto-start and the timeout via setting the environment variable watchdog_timeout_ms. A value of zero means "do not start". Use CONFIG_WATCHDOG_TIMEOUT_MSECS as initial value and this to zero by default. Users can then enable the watchdog

[PATCH V6 02/13] arm: dts: iot2050: Use the auto generator nodes for fdt

2023-02-04 Thread Jan Kiszka
From: Su Baocheng Refactor according to the entry `fit: Entry containing a FIT` of document tools/binman/README.entries. As the generator uses the device tree name for the config description, board_fit_config_name_match requires a small adjustment as well. Signed-off-by: Su Baocheng [Jan:

[PATCH V6 03/13] iot2050: Update firmware layout

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka The latest version of the binary-only firmware parts come in a combined form of FSBL and sysfw containers. This implies some layout changes to the generated firmware image but also makes handling of artifacts much simpler (4 files less). The env locations will not change, just

[PATCH V6 08/13] tools: Add script for converting public key into device tree include

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Allows to create a public key device tree dtsi for inclusion into U-Boot SPL and proper during first build already. This can be achieved via CONFIG_DEVICE_TREE_INCLUDES. Signed-off-by: Jan Kiszka --- tools/key2dtsi.py | 64 +++ 1

[PATCH V6 06/13] iot2050: Add CFG_ENV_FLAGS_LIST_STATIC

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed variables shall remain writable, for informational purposes - they have to be considered untrusted because the persistent U-Boot env is not protected. Signed-off-by: Jan Kiszka --- include/configs/iot2050.h

[PATCH V6 04/13] iot2050: Migrate settings into board env file

2023-02-04 Thread Jan Kiszka
From: Jan Kiszka Anything that is not boot-env related is better kept there by now. At this chance, also drop a stale comment from iot2050.h Signed-off-by: Jan Kiszka --- board/siemens/iot2050/iot2050.env | 9 + include/configs/iot2050.h | 11 ++- 2 files changed, 11

[PATCH V6 00/13] IOT2050-related enhancements

2023-02-04 Thread Jan Kiszka
(Almost) flushing our upstream queue for the IOT2050 device, this mostly brings board-specific changes such as: - updated build process and firmware layout for PG1 vs. PG2 devices - more watchdog preparations - preparations for verified boot on IOT2050 Advanced devices This series depends on

[PATCH V6 01/13] board: siemens: iot2050: Split the build for PG1 and PG2

2023-02-04 Thread Jan Kiszka
From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single flash.bin for both variants, so we can also split the build. A new target is added to indicates the build is for PG1 vs.

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-04 Thread Greg Kroah-Hartman
On Fri, Feb 03, 2023 at 07:37:03PM +0100, Francesco Dolcini wrote: > > > Il 3 febbraio 2023 19:16:23 CET, Miquel Raynal ha > scritto: > >Hi Francesco, > > > >france...@dolcini.it wrote on Fri, 03 Feb 2023 19:03:27 +0100: > > > >> Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal > >> ha