Re: [PATCH 2/2] ARM: dts: uniphier: Sync DT with Linux v6.2

2023-02-27 Thread Marek Vasut
On 2/28/23 03:37, Kunihiko Hayashi wrote: Synchronize devicetree sources with Linux v6.2. - Use GIC interrupt definitions - Add reg properties in USB-glue and SoC-glue node - Fix node names to follow the generic names list in DT specification - Add L2 cache and AHCI nodes - Update nand and pcie

Re: [PATCH 1/2] ARM: dts: uniphier: Switch USB node to the original

2023-02-27 Thread Marek Vasut
On 2/28/23 03:37, Kunihiko Hayashi wrote: UniPhier DT applies its own USB node for U-Boot due to the USB driver constrains. After solving this issue, u-boot allows the original USB node. After switching USB node, synchronization of USB node with Linux becomes possible. Signed-off-by: Kunihiko

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-27 Thread Stefan Roese
Hi Martin, Hi Pali, On 2/27/23 12:29, Martin Rowe wrote: On Mon, 27 Feb 2023 at 08:04, Pali Rohár > wrote: On Monday 27 February 2023 08:44:30 Stefan Roese wrote: > Hi Pali, > > On 2/25/23 23:00, Pali Rohár wrote: > > On Tuesday 21 February 2023

[PATCH 4/4] ARM: rmobile: Split R-Car Gen3 into separate Kconfig from common 64bit options

2023-02-27 Thread Marek Vasut
There are multiple shared Kconfig options between R-Car Gen3 and Gen4. Keep the common options in Kconfig.64 and move the R-Car Gen3 specific options into separate Kconfig.rcar3 . The Kconfig.rcar3 contains SoC and board list, which is limited to R-Car Gen3. Signed-off-by: Marek Vasut ---

[PATCH 3/4] ARM: rmobile: Introduce CONFIG_RCAR_64 symbol

2023-02-27 Thread Marek Vasut
Introduce common Kconfig symbol for 64bit R-Car platforms and move common configuration options into it. This is preparatory patch to prevent duplication of Kconfig lists later on, when Gen4 is added. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/Kconfig | 29

[PATCH 2/4] ARM: rmobile: Factor out SYS_SOC Kconfig option

2023-02-27 Thread Marek Vasut
Pull the SYS_SOC Kconfig option to avoid duplication of this option in Kconfig.{32,64,rza1} . The default value is the same, so just set it in one location. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/Kconfig | 3 +++ arch/arm/mach-rmobile/Kconfig.32 | 3 ---

[PATCH 1/4] ARM: rmobile: Sort R-Car Gen3 Kconfig lists

2023-02-27 Thread Marek Vasut
Sort the 'imply' and 'select' lists in R-Car Gen3 Kconfig options. No functional change. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/Kconfig| 10 +- arch/arm/mach-rmobile/Kconfig.64 | 22 +++--- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH] ARM: rmobile: Convert ifdef in rmobile_get_prr() to IS_ENABLED()

2023-02-27 Thread Marek Vasut
Switch ifdef in rmobile_get_prr() to IS_ENABLED() macro. The CONFIG_RCAR_GEN3 will never have SPL counterpart, so the IS_ENABLED() macro is the right one here. No functional change, except for improved build test coverage. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/cpu_info-rcar.c | 7

[PATCH 2/2] pinctrl: renesas: Drop non-existent PFC info table entries

2023-02-27 Thread Marek Vasut
Remove PFC info table entries which are never instantiated, since there are no drivers for those. No functional change. Signed-off-by: Marek Vasut --- drivers/pinctrl/renesas/sh_pfc.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/pinctrl/renesas/sh_pfc.h

[PATCH 1/2] pinctrl: renesas: Replace ifdeffery with IS_ENABLED()

2023-02-27 Thread Marek Vasut
Switch ifdef in sh_gpio_get_value() to IS_ENABLED() macro. The CONFIG_RCAR_GEN3 will never have SPL counterpart, so the IS_ENABLED() macro is the right one here. No functional change, except for improved build test coverage. Signed-off-by: Marek Vasut --- drivers/gpio/sh_pfc.c | 6 +++--- 1

[PATCH] clk: renesas: rcar-gen3: Replace SSCG caching with MDSEL/PE caching

2023-02-27 Thread Marek Vasut
Do not cache the single CPG MODE register bit 12, instead cache the entire register value, and only pick the matching bit from the cached value when core clock of type MDSEL or PE are used. Both MDSEL and PE clock type currently define .offset field as 12 on Gen3, which means this code will use

[PATCH] mmc: tmio: Replace ifdeffery with IS_ENABLED/CONFIG_IS_ENABLED macros

2023-02-27 Thread Marek Vasut
Instead of #if and #ifdef, use IS_ENABLED and CONFIG_IS_ENABLED macros. This improves build test coverage. The CONFIG_SPL_BUILD must remain an ifdef, as CONFIG_SPL_STACK may not always be defined, e.g. in U-Boot proper build. No functional change. Signed-off-by: Marek Vasut --- Cc: Jaehoon Chung

[PATCH] Kconfig: Sort the BUILD_TARGET list

2023-02-27 Thread Marek Vasut
Sort the defaults list in BUILD_TARGET Kconfig option. No functional change. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Kconfig b/Kconfig index

Re: [PATCH] clk: rockchip: rk3568: add more supported clk rates for sdmmc and emmc

2023-02-27 Thread Kever Yang
On 2023/2/24 05:03, Vasily Khoruzhick wrote: SDHCI driver may attempt to set 26MHz clock, but clk_rk3568 will return error in this case. Apparently, SDHCI silently ignores the error and as a result eMMC initialization fails. Add 25 MHz and 26 MHz clk rates for sdmmc and emmc on rk3568 to fix

Re: [PATCH v2 12/12] rockchip: rk3588: Read cpuid from otp

2023-02-27 Thread Kever Yang
On 2023/2/23 06:44, Jonas Karlman wrote: Read cpuid from otp and set ethaddr for RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: - New patch arch/arm/dts/rk3588s-u-boot.dtsi | 12 arch/arm/mach-rockchip/Kconfig | 2 ++ 2 files

Re: [PATCH v2 2/2] board: rock5b-rk3588: add memory gaps into kernel's DTB

2023-02-27 Thread Kever Yang
On 2023/2/22 17:05, Eugen Hristev wrote: RK3588 has two memory gaps when using 16 GiB DRAM size: [0x3fc00 , 0x3fc50] and [0x3fff0 , 0x3] If the kernel is agnostic to these gaps, accessing the area causes a SError panic. Hence, add reserved memory areas in kernel's DTB

Re: [PATCH v2 1/2] board: rockchip: add Radxa ROCK5B Rk3588 board

2023-02-27 Thread Kever Yang
On 2023/2/22 17:05, Eugen Hristev wrote: ROCK 5B is a Rockchip RK3588 based SBC (Single Board Computer) by Radxa. There are tree variants depending on the DRAM size : 4G, 8G and 16G. Specification: Rockchip Rk3588 SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory

Re: [PATCH] Reads high bits of DDR type for Rockchip

2023-02-27 Thread Recursive G
Hi Jonas, Thank you for the reply and your patch does work. How do I mark mine as retracted? Best, R. Jonas Karlman 于2023年2月26日周日 09:00写道: > > Hi, > > Please try the series at [1], it should solve the same issue you are > trying to solve with this patch. That series is also queued in the >

Re: [PATCH] rockchip: rk3288: Use ft_system_setup instead of ft_board_setup

2023-02-27 Thread Kever Yang
On 2023/2/24 03:28, John Keeping wrote: ft_board_setup() should be availble for use in board files but using it in the rk3288 machine file blocks this functionality. ft_system_setup() is the more appropriate function to use in a machine definition. Signed-off-by: John Keeping Reviewed-by:

Re: [PATCH v5 6/6] binman: Mark mkimage entry missing when its subnodes is missing

2023-02-27 Thread Kever Yang
On 2023/2/26 03:01, Jonas Karlman wrote: Using the mkimage entry with the multiple-data-files prop and having a missing external blob result in an unexpected ValueError exception using the --allow-missing flag. ValueError: Filename 'missing.bin' not found in input path (...) Fix this by

[PATCH 2/2] ARM: dts: uniphier: Sync DT with Linux v6.2

2023-02-27 Thread Kunihiko Hayashi
Synchronize devicetree sources with Linux v6.2. - Use GIC interrupt definitions - Add reg properties in USB-glue and SoC-glue node - Fix node names to follow the generic names list in DT specification - Add L2 cache and AHCI nodes - Update nand and pcie nodes - And some trivial fixes

[PATCH 1/2] ARM: dts: uniphier: Switch USB node to the original

2023-02-27 Thread Kunihiko Hayashi
UniPhier DT applies its own USB node for U-Boot due to the USB driver constrains. After solving this issue, u-boot allows the original USB node. After switching USB node, synchronization of USB node with Linux becomes possible. Signed-off-by: Kunihiko Hayashi ---

[PATCH 0/2] Update UniPhier devicetree

2023-02-27 Thread Kunihiko Hayashi
Migrate the USB node to the original node after updating dwc3-generic and dwc3-uniphier. https://lists.denx.de/pipermail/u-boot/2023-February/509635.html And synchronize UniPhier devicetree with Linux v6.2. Kunihiko Hayashi (2): ARM: dts: uniphier: Switch USB node to the original ARM: dts:

[PATCH v2] CI: gitlab: Collect pytest artifacts

2023-02-27 Thread Marek Vasut
Copy build artifacts for all test.py tests, so they show up in artifacts storage for later inspection. The test.py tests output in CI is basically useless, but it is far more useful in the html output for analysis and debugging. Reviewed-by: Tom Rini Suggested-by: Simon Glass Signed-off-by:

Re: [PATCH] CI: gitlab: Collect pytest artifacts

2023-02-27 Thread Marek Vasut
On 2/28/23 00:36, Tom Rini wrote: [...] @@ -454,9 +457,4 @@ coreboot test.py: TEST_PY_BD: "coreboot" TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id qemu" - artifacts: -paths: - - "*.html" - - "*.css" -expire_in: 1 week <<: *buildman_and_testpy_dfn

[PATCH 6/6] video: tl070wsh30: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

[PATCH 5/6] video: simple-panel: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

[PATCH 3/6] video: otm8009a: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

[PATCH 2/6] mmc: npcm_sdhci: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

[PATCH 4/6] video: rm68200: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

[PATCH 1/6] misc: ub251xb: Fix use of CONFIG_IS_ENABLED on DM_REGULATOR

2023-02-27 Thread Marek Vasut
The DM_REGULATOR symbol has SPL counterpart in: drivers/power/regulator/Kconfig:config SPL_DM_REGULATOR Use CONFIG_IS_ENABLED() macro to match on the correct variant depending on the build stage. Signed-off-by: Marek Vasut --- Cc: Anatolij Gustschin Cc: Jaehoon Chung Cc: Marek Vasut Cc:

Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Jassi Brar
Hi Ilias, On Thu, Feb 23, 2023 at 2:36 AM Ilias Apalodimas wrote: > > +int fwu_get_verified_mdata(struct fwu_mdata *mdata) > > +{ > > + int err; > > + bool pri_ok, sec_ok; > > + struct fwu_mdata s, *p_mdata, *s_mdata; > > + > > + p_mdata = _mdata; > > + s_mdata = > > + > > +

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Jassi Brar
On Mon, Feb 27, 2023 at 7:28 PM Tom Rini wrote: > > On Mon, Feb 27, 2023 at 07:00:10PM -0600, Jassi Brar wrote: > > On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > > > > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > > > > > > > From: Jassi Brar > > > > > > > >

Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:35:30PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 27 Feb 2023 at 15:08, Tom Rini wrote: > > > > With clang-15 we now will get warnings such as: > > > > warning: a function declaration without a prototype is deprecated in all > > versions of C

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 07:00:10PM -0600, Jassi Brar wrote: > On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > > > > > From: Jassi Brar > > > > > > The patchset reduces ~400 lines of code, while keeping the

Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

2023-02-27 Thread Tony Dinh
Hi Pali, On Mon, Feb 27, 2023 at 4:42 PM Tony Dinh wrote: > > Hi Pali, > > On Mon, Feb 27, 2023 at 3:41 PM Tony Dinh wrote: > > > > Hi Pali, > > > > On Mon, Feb 27, 2023 at 1:57 PM Tony Dinh wrote: > > > > > > Hi Stefan, > > > > > > On Sun, Feb 26, 2023 at 11:40 PM Stefan Roese wrote: > > > >

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Jassi Brar
On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > The patchset reduces ~400 lines of code, while keeping the functionality > > same and making > > meta-data operations much faster (by using

Re: [PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-02-27 Thread Jassi Brar
On Sat, 4 Feb 2023 at 22:09, Jassi Brar wrote: > > > > + fwu-mdata { > > + compatible = "u-boot,fwu-mdata-mtd"; > > + fwu-mdata-store = <_flash>; > > + mdata-offsets = <0x50 0x53>; > > + }; > > >

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The patchset reduces ~400 lines of code, while keeping the functionality same > and making > meta-data operations much faster (by using cached structures). > > Issue: > meta-data copies (primary

[PATCH v5 6/6] fwu: rename fwu_get_verified_mdata to fwu_get_mdata

2023-02-27 Thread jassisinghbrar
From: Jassi Brar fwu_get_mdata() sounds more appropriate than fwu_get_verified_mdata() Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- cmd/fwu_mdata.c | 2 +- include/fwu.h | 4 ++-- lib/fwu_updates/fwu.c | 6 +++--- 3 files changed, 6

[PATCH v5 5/6] fwu: meta-data: switch to management by common code

2023-02-27 Thread jassisinghbrar
From: Jassi Brar The common code can now read, verify and fix meta-data copies while exposing one consistent structure to users. Only the .read_mdata() and .write_mdata() callbacks of fwu_mdata_ops are needed. Get rid of .get_mdata() .update_mdata() .get_mdata_part_num() .read_mdata_partition()

[PATCH v5 4/6] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-02-27 Thread jassisinghbrar
From: Jassi Brar Moving towards using common code for meta-data management, implement the read/write mdata hooks. Signed-off-by: Jassi Brar Reviewed-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- drivers/fwu-mdata/gpt_blk.c | 36 1 file changed,

[PATCH v5 3/6] fwu: move meta-data management in core

2023-02-27 Thread jassisinghbrar
From: Jassi Brar Instead of each i/f having to implement their own meta-data verification and storage, move the logic in common code. This simplifies the i/f code much simpler and compact. Signed-off-by: Jassi Brar --- drivers/fwu-mdata/fwu-mdata-uclass.c | 34 +++ include/fwu.h

[PATCH v5 2/6] fwu: gpt: use cached meta-data partition numbers

2023-02-27 Thread jassisinghbrar
From: Jassi Brar Use cached values and avoid parsing and scanning through partitions everytime for meta-data partitions because they can't change after bootup. Acked-by: Etienne Carriere Reviewed-by: Ilias Apalodimas Signed-off-by: Jassi Brar --- drivers/fwu-mdata/gpt_blk.c | 43

[PATCH v5 1/6] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-02-27 Thread jassisinghbrar
From: Jassi Brar Any requirement of FWU should not require changes to bindings of other subsystems. For example, for mtd-backed storage we can do without requiring 'fixed-partitions' children to also carry 'uuid', a property which is non-standard and not in the bindings. There exists no code

[PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread jassisinghbrar
From: Jassi Brar The patchset reduces ~400 lines of code, while keeping the functionality same and making meta-data operations much faster (by using cached structures). Issue: meta-data copies (primary and secondary) are being handled by the backend/storage layer instead of the common core

Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

2023-02-27 Thread Tony Dinh
Hi Pali, On Mon, Feb 27, 2023 at 3:41 PM Tony Dinh wrote: > > Hi Pali, > > On Mon, Feb 27, 2023 at 1:57 PM Tony Dinh wrote: > > > > Hi Stefan, > > > > On Sun, Feb 26, 2023 at 11:40 PM Stefan Roese wrote: > > > > > > Hi Tony, > > > > > > On 2/27/23 01:11, Tony Dinh wrote: > > > > Hi Pali, > > >

Re: [RFC PATCH] binman: bintool: etype: Add support for ti-secure entry

2023-02-27 Thread Simon Glass
Hi Neha, On Fri, 24 Feb 2023 at 05:03, Neha Malcom Francis wrote: > > core-secdev-k3 is the TI security development package provided for K3 > platform devices. This tool helps sign bootloader images with the x509 > ceritificate header. > > Signed-off-by: Neha Malcom Francis > --- > This patch

Re: [PATCH 3/7] libavb: Fix a warning with clang-15

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:09, Tom Rini wrote: > > With clang-15 we now will get warnings such as: > > warning: a function declaration without a prototype is deprecated in all > versions of C [-Wstrict-prototypes] > > And it is easy enough to address this warning here, as we aren't > concerned

Re: [PATCH v7 05/10] video console: move vidconsole_get_font_size() logic to driver ops

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 10:37, Dzmitry Sankouski wrote: > > Since multiple vidconsole drivers exists, vidconsole_get_font_size() > implementation cannot longer live in vidconsole_uclass.c file. > > Move current vidconsole_get_font_size logic to truetype driver ops. > > Signed-off-by: Dzmitry

Re: [PATCH v7 09/10] video console: sandbox_defconfig: add 12x22 font

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 10:37, Dzmitry Sankouski wrote: > > Add 12x22 font in order to write a test for it. > Run savedefconfig. > > Signed-off-by: Dzmitry Sankouski > --- > Changes for v2: N/A > Changes for v3: N/A > Charges for v4: N/A > Charges for v5: N/A > Charges for v6: N/A > Charges for

Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Simon Glass
Hi Tom, On Mon, 27 Feb 2023 at 15:08, Tom Rini wrote: > > With clang-15 we now will get warnings such as: > > warning: a function declaration without a prototype is deprecated in all > versions of C [-Wstrict-prototypes] > > And it is easy enough to address this warning here, as we aren't >

Re: [PATCH 6/7] proftool: Remove unused variables in make_flame_tree

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:08, Tom Rini wrote: > > With clang-15 we now get reported that in the make_flame_tree function, > neither the missing_count nor depth variables are used, only > incremenete/decremented. Remove these. > > Signed-off-by: Tom Rini > --- > Cc: Simon Glass > --- >

Re: [PATCH 7/7] CI: Move to clang-15

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:10, Tom Rini wrote: > > As this is now the stable release, move to using that now for our tests. > > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml| 6 +++--- > .gitlab-ci.yml | 4 ++-- > tools/docker/Dockerfile | 4 ++-- > 3 files changed, 7

Re: [PATCH 5/7] imx8image: Remove unused cont_img_count variable

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:09, Tom Rini wrote: > > With clang-15, it is now reported that cont_img_count is unused. This is > true as the code will increment / reset this counter, but never > functionally use it. Remove it. > > Signed-off-by: Tom Rini > --- > Cc: Peng Fan > Cc: Mikhail Ilin >

Re: [PATCH 1/7] global: Disable deprecated-non-prototype warning with clang

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:09, Tom Rini wrote: > > We have a number of places in the code which use the following syntax: > > void func(a, b, c) > int a; /* Does a */ > something_t *b; /* Pointer to b */ > int c; /* Does c */ > { > ... > } > > Which while not what we document as our

Re: [PATCH 4/7] zlib: trees.c: Fix a warning with clang-15

2023-02-27 Thread Simon Glass
On Mon, 27 Feb 2023 at 15:09, Tom Rini wrote: > > With clang-15 we now will get warnings such as: > > warning: a function declaration without a prototype is deprecated in all > versions of C [-Wstrict-prototypes] > > And it is easy enough to address this warning here, even if we would > like to

Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

2023-02-27 Thread Tony Dinh
Hi Pali, On Mon, Feb 27, 2023 at 1:57 PM Tony Dinh wrote: > > Hi Stefan, > > On Sun, Feb 26, 2023 at 11:40 PM Stefan Roese wrote: > > > > Hi Tony, > > > > On 2/27/23 01:11, Tony Dinh wrote: > > > Hi Pali, > > > > > > On Sun, Feb 26, 2023 at 2:52 AM Pali Rohár wrote: > > >> > > >> On Saturday

Re: [PATCH] CI: gitlab: Collect pytest artifacts

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 11:51:30PM +0100, Marek Vasut wrote: > Copy build artifacts for all test.py tests, so they show up in > artifacts storage for later inspection. The test.py tests output > in CI is basically useless, but it is far more useful in the html > output for analysis and debugging.

Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Etienne Carriere
- err = fwu_write_mdata(g_dev, mdata, part & PRIMARY_PART ? true : false); On Mon, 27 Feb 2023 at 17:46, Jassi Brar wrote: > > On Mon, Feb 27, 2023 at 10:30 AM Etienne Carriere > wrote: > > > > Hello Jassi, > > > > On Sun, 5 Feb 2023 at 04:01, wrote: > > > > > > From: Jassi Brar > > > >

[PATCH] net: ravb: Support fixed PHY in R-Car

2023-02-27 Thread Marek Vasut
From: Mikhail Lappo Calling old U-Boot API doesn't allow to use fixed PHY. Searching by mask is the part of new function, after scanning FDT for a fixed PHY definition Fixes: e821a7bdb13 ("net: ravb: Detect PHY correctly") Reviewed-by: Marek Vasut Signed-off-by: Mikhail Lappo Signed-off-by:

[PATCH 2/2] i2c: rcar_i2c: Sort Kconfig depends list ascending

2023-02-27 Thread Marek Vasut
Sort the list of "depends" symbols in ascending order. No functional change. Signed-off-by: Marek Vasut --- Cc: Heiko Schocher --- drivers/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index aa51f0c869e..1d998d14732

[PATCH 1/2] i2c: rcar_iic: Sort Kconfig depends list ascending

2023-02-27 Thread Marek Vasut
Sort the list of "depends" symbols in ascending order. No functional change. Signed-off-by: Marek Vasut --- Cc: Heiko Schocher --- drivers/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index 3279fef1eb0..aa51f0c869e

[PATCH 2/2] ARM: renesas: falcon: Enable RWDT reset for V3U Falcon

2023-02-27 Thread Marek Vasut
From: Hai Pham Enable RWDT reset on Reset Controller so that it can be used as reset trigger source for V3U Falcon. Reviewed-by: Marek Vasut Signed-off-by: Hai Pham Signed-off-by: Marek Vasut # Use one current_el() in board_init --- board/renesas/falcon/falcon.c | 16 +++- 1

[PATCH 1/2] ARM: renesas: falcon: Initialize ARM generic timer and GICv3 if EL3

2023-02-27 Thread Marek Vasut
From: Hai Pham U-Boot executes at EL3 is required to initalize those settings. In other cases, they will be done by prior-stage firmware instead. This fixes crash when U-Boot is at non-secure exception level. Reviewed-by: Marek Vasut Signed-off-by: Hai Pham Signed-off-by: Marek Vasut ---

[PATCH] ARM: renesas: Enable DTO support by default on R-Car Gen3

2023-02-27 Thread Marek Vasut
All R-Car Gen3 defconfigs present in U-Boot do enable DTO support, enable it for all of R-Car Gen3 by default in Kconfig instead, so that no new boards would miss this functionality. Signed-off-by: Marek Vasut --- arch/arm/mach-rmobile/Kconfig.64 | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH] ARM: renesas: Demote overlap memory nodes message to debug on Gen3

2023-02-27 Thread Marek Vasut
From: Hai Pham The R-Car DTs might contains multiple /memory@* nodes from various sources, i.e. prior firmware, u-boot itself or the OS The duplicates are likely to happen so the messages are not meaningful in the default setting since we have already handled that. Reduce the message to debug

[PATCH] ARM: renesas: Remove defines for USB on Eagle/Condor

2023-02-27 Thread Marek Vasut
From: Hai Pham The Eagle board based on R-Car V3M, which does not support any USB interfaces. The same applies for the Condor board based on R-Car V3H. Remove the defines. Reviewed-by: Marek Vasut Signed-off-by: Hai Pham Signed-off-by: Marek Vasut --- configs/r8a77970_eagle_defconfig | 6

[PATCH 2/3] ARM: dts: renesas: Enable sysinfo on R-Car V3H Condor/Condor-I

2023-02-27 Thread Marek Vasut
From: Tam Nguyen Add new sysinfo IDs for R-Car V3H Condor/Condor-I . Enable support for sysinfo on R-Car V3H Condor/Condor-I. The sysinfo is used e.g. to access and decode board-specific information and then in turn used by board-info to print those information. Reviewed-by: Marek Vasut

[PATCH 3/3] ARM: dts: renesas: Enable sysinfo on R-Car D3 Draak

2023-02-27 Thread Marek Vasut
From: Tam Nguyen Enable support for sysinfo on R-Car D3 Draak board. The sysinfo is used e.g. to access and decode board-specific information and then in turn used by board-info to print those information. Reviewed-by: Marek Vasut Signed-off-by: Tam Nguyen Signed-off-by: Hai Pham

[PATCH 1/3] sysinfo: rcar3: Fix Draak and Eagle board code

2023-02-27 Thread Marek Vasut
From: Tam Nguyen Correct the board code ID based on the hardware documentation Reviewed-by: Marek Vasut Signed-off-by: Tam Nguyen Signed-off-by: Hai Pham Signed-off-by: Marek Vasut --- drivers/sysinfo/rcar3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] CI: gitlab: Collect pytest artifacts

2023-02-27 Thread Marek Vasut
Copy build artifacts for all test.py tests, so they show up in artifacts storage for later inspection. The test.py tests output in CI is basically useless, but it is far more useful in the html output for analysis and debugging. Suggested-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Simon

[PATCH 2/2] mmc: renesas-sdhi: Add proper probe error fail path

2023-02-27 Thread Marek Vasut
In case one of the calls in probe fail, trigger a fail path and undo all the steps done in probe until the point of failure. The current implementation failed to stop controller clock and free claimed clock, so fix that. Furthermore, print return code in error prints for easier debugging.

[PATCH 1/2] mmc: renesas-sdhi: Always configure default SDnH clock rate to 800 MHz

2023-02-27 Thread Marek Vasut
The prior stage bootloader might have left the SDnCKCR register in completely arbitrary state before passing control to U-Boot, which includes the register being populated with incorrect values. Currently the SDHI driver will attempt to use clock framework to configure SDn clock, which may fail in

[ANN] U-Boot v2023.04-rc3 released

2023-02-27 Thread Tom Rini
Hey all, It's the scheduled day for -rc3, and it's the end of my day, mainly because I got side-tracked. The delta between -rc2 and -rc3 is bigger than I'd have liked, but, I can accept it. I will be more stringent moving forward, and at this point the only "big" changes I'm expecting are the

[PATCH 6/7] proftool: Remove unused variables in make_flame_tree

2023-02-27 Thread Tom Rini
With clang-15 we now get reported that in the make_flame_tree function, neither the missing_count nor depth variables are used, only incremenete/decremented. Remove these. Signed-off-by: Tom Rini --- Cc: Simon Glass --- tools/proftool.c | 15 +-- 1 file changed, 1 insertion(+), 14

[PATCH 7/7] CI: Move to clang-15

2023-02-27 Thread Tom Rini
As this is now the stable release, move to using that now for our tests. Signed-off-by: Tom Rini --- .azure-pipelines.yml| 6 +++--- .gitlab-ci.yml | 4 ++-- tools/docker/Dockerfile | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.azure-pipelines.yml

[PATCH 5/7] imx8image: Remove unused cont_img_count variable

2023-02-27 Thread Tom Rini
With clang-15, it is now reported that cont_img_count is unused. This is true as the code will increment / reset this counter, but never functionally use it. Remove it. Signed-off-by: Tom Rini --- Cc: Peng Fan Cc: Mikhail Ilin Cc: Stefano Babic Cc: Fabio Estevam Cc: "NXP i.MX U-Boot Team"

[PATCH 3/7] libavb: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] And it is easy enough to address this warning here, as we aren't concerned with re-syncing with an upstream. Signed-off-by: Tom Rini ---

[PATCH 4/7] zlib: trees.c: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] And it is easy enough to address this warning here, even if we would like to stay in sync more with upstream as it's a single location.

[PATCH 1/7] global: Disable deprecated-non-prototype warning with clang

2023-02-27 Thread Tom Rini
We have a number of places in the code which use the following syntax: void func(a, b, c) int a; /* Does a */ something_t *b; /* Pointer to b */ int c; /* Does c */ { ... } Which while not what we document as our coding style, this is also code which we have imported from other

[PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] And it is easy enough to address this warning here, as we aren't concerned with re-syncing with an upstream. Signed-off-by: Tom Rini ---

Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

2023-02-27 Thread Tony Dinh
Hi Stefan, On Sun, Feb 26, 2023 at 11:40 PM Stefan Roese wrote: > > Hi Tony, > > On 2/27/23 01:11, Tony Dinh wrote: > > Hi Pali, > > > > On Sun, Feb 26, 2023 at 2:52 AM Pali Rohár wrote: > >> > >> On Saturday 25 February 2023 20:56:10 Tony Dinh wrote: > >>> Hi Martin, > >>> > >>> On Sat, Feb

[PATCH] image: Fix potentially uninitialized data variable

2023-02-27 Thread Marek Vasut
In case fitImage support is disabled, and image_locate_script() is passed a fitImage, then the 'data' variable is used uninitialized. Drop into the default: branch of the switch-case statement and do not return the uninitialized data, and do not modify the return pointer either, just print an

[PATCH] console: Use only 0x00 as line separator for console recording

2023-02-27 Thread Marek Vasut
In case character 0x20 (space) is used as line separator, character 0x9 (tab) is treated end of line. Commands which output a lot of tabs, i.e. various tree printing commands like 'fdt print' then end up generating a lot of newlines in the recorded output, and the recorded output is corrupted.

[PATCH 31/32] test: cmd: fdt: Test fdt apply

2023-02-27 Thread Marek Vasut
Add 'fdt chosen' test which works as follows: - Create basic DT, map it to sysmem - Apply DTO which adds single property via fragment (without address spec) - Apply DTO which adds more properties (string, u32, empty) and a subnode, with phandle via frament@0 and thus tests /__symbols__ node -

[PATCH 32/32] test: cmd: fdt: Add list of remaining missing tests

2023-02-27 Thread Marek Vasut
Add list of missing tests for the 'fdt' command, currently the missing sandbox tests are only 'fdt boardsetup' and 'fdt checksign' . Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- test/cmd/fdt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 28/32] test: cmd: fdt: Test fdt memory

2023-02-27 Thread Marek Vasut
Add 'fdt memory' test which works as follows: - Create custom FDT with /memory node, with select #*cells, map it to sysmem - Perform memory fixup - Read back the /memory node and validate its content The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from

[PATCH 29/32] test: cmd: fdt: Test fdt rsvmem

2023-02-27 Thread Marek Vasut
Add 'fdt rsvmem' test which works as follows: - Create custom FDT with single reserved memory (rsvmem) entry, map it to sysmem - Add new rsvmem entry - Delete existing older rsvmem entry - Add new rsvmem entry again - Always print the rsvmem list and validate it The test case can be triggered

[PATCH 30/32] test: cmd: fdt: Test fdt chosen

2023-02-27 Thread Marek Vasut
Add 'fdt chosen' test which works as follows: - Create basic DT, map it to sysmem - Print /chosen node, verify it is nonexistent - Create chosen node - Print /chosen node, verify it contains only version - Create /chosen node with initrd entries - Print /chosen node, verify it contains version and

[PATCH 27/32] test: cmd: fdt: Test fdt bootcpu

2023-02-27 Thread Marek Vasut
Add 'fdt bootcpu' test which works as follows: - Create basic FDT, map it to sysmem - Print the FDT bootcpu - Set the FDT bootcpu and read the value back using 'fdt header get' - Perform the previous step twice to validate bootcpu overwrite The test case can be triggered using: " ./u-boot -Dc 'ut

[PATCH 26/32] test: cmd: fdt: Test fdt header

2023-02-27 Thread Marek Vasut
Add 'fdt header' test which works as follows: - Create basic FDT, map it to sysmem - Print the FDT header - Get all members of the FDT header into variable and verify the variables contain correct data The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from

[PATCH 25/32] test: cmd: fdt: Test fdt rm

2023-02-27 Thread Marek Vasut
Add 'fdt rm' test which works as follows: - Create fuller FDT, map it to sysmem - Selectively delete nodes or properties by both path and aliases - Verify created nodes or properties using fdt print command The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output

[PATCH 24/32] test: cmd: fdt: Test fdt mknode

2023-02-27 Thread Marek Vasut
Add 'fdt mknode' test which works as follows: - Create fuller FDT, map it to sysmem - Create node either in / or subnode - Attempt to create node over existing node, which fails - Attempt to create subnodes in non-existing nodes or aliases - Verify created nodes using fdt list command The test

[PATCH 23/32] test: cmd: fdt: Test fdt set

2023-02-27 Thread Marek Vasut
Add 'fdt set' test which works as follows: - Create fuller FDT, map it to sysmem - Set either existing property to overwrite it, or new property - Test setting both single properties as well as string and integer arrays - Test setting to non-existent nodes and aliases - Verify set values using

[PATCH 22/32] test: cmd: fdt: Test fdt get size

2023-02-27 Thread Marek Vasut
Add 'fdt get size' test which works as follows: - Create fuller FDT, map it to sysmem - Get size of various properties - Get node count of available nodes - Test non-existent nodes and properties The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from commands

[PATCH 21/32] test: cmd: fdt: Test fdt get addr

2023-02-27 Thread Marek Vasut
Add 'fdt get addr' test which works as follows: - Create fuller FDT, map it to sysmem - Get address of various properties - Compare addresses calculated by UT and fdt command This test is special in that it has to go through gruesome remapping scheme where the test calculates: - pointer offsets

[PATCH 20/32] test: cmd: fdt: Test fdt get name

2023-02-27 Thread Marek Vasut
Add 'fdt get name' test which works as follows: - Create fuller FDT, map it to sysmem - Get name of / node 0, 1 and /clk-test node 0 - Compare output and validate the node name - Get name of / node 2 and /clk-test node 1 - Compare output and validate the node is not present - Get name of / node -1

[PATCH 19/32] test: cmd: fdt: Test fdt print and list

2023-02-27 Thread Marek Vasut
Add 'fdt print' and 'fdt list' test which works as follows: - Create fuller FDT, map it to sysmem - Print the entire FDT, parts of the FDT and select properties - Compare output from the print or list The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from

[PATCH 18/32] test: cmd: fdt: Test fdt resize

2023-02-27 Thread Marek Vasut
Add 'fdt resize' test which works as follows: - Create simple FDT with extra size 0, map it to sysmem - 'resize' the FDT by 0x2000 bytes - Verify the new space has been added to the FDT The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from commands used

  1   2   >